Re: [PATCH] powerpc: fix 32-bit KVM-PR lockup and panic with MacOS guest

2019-02-18 Thread Mark Cave-Ayland
On 19/02/2019 04:20, Michael Ellerman wrote: Hi Michael, > Mark Cave-Ayland writes: >> On 08/02/2019 14:45, Christophe Leroy wrote: >> >>> Le 08/02/2019 à 15:33, Mark Cave-Ayland a écrit : Commit 8792468da5e1 "powerpc: Add the ability to save FPU without giving it up" >>> >>>

Re: [RFC PATCH 2/2] powerpc/mm/hash64: Map all the kernel mapping in the same 0xc range

2019-02-18 Thread Nicholas Piggin
Aneesh Kumar K.V's on February 19, 2019 4:00 pm: > On 2/19/19 11:28 AM, Nicholas Piggin wrote: >> Aneesh Kumar K.V's on February 17, 2019 3:16 pm: >>> This patch maps vmap, IO and vmemap regions in the 0xc address range >>> instead of the current 0xd and 0xf range. This brings the mapping closer

RE: [PATCHv6 1/4] dt-bindings: add DT binding for the layerscape PCIe controller with EP mode

2019-02-18 Thread Xiaowei Bao
-Original Message- From: Lorenzo Pieralisi Sent: 2019年2月6日 2:03 To: Xiaowei Bao Cc: bhelg...@google.com; robh...@kernel.org; mark.rutl...@arm.com; shawn...@kernel.org; Leo Li ; kis...@ti.com; a...@arndb.de; gre...@linuxfoundation.org; M.h. Lian ; Mingkai Hu ; Roy Zang ;

Re: [RFC PATCH 5/5] powerpc: KASAN for 64bit Book3E

2019-02-18 Thread Daniel Axtens
Dmitry Vyukov writes: > On Fri, Feb 15, 2019 at 1:05 AM Daniel Axtens wrote: >> >> Wire up KASAN. Only outline instrumentation is supported. >> >> The KASAN shadow area is mapped into vmemmap space: >> 0x8000 0400 to 0x8000 0600 . >> To do this we require that vmemmap be

Re: [RFC PATCH 0/5] powerpc: KASAN for 64-bit Book3E

2019-02-18 Thread Daniel Axtens
Hi Balbir, > Thanks for following through with this, could you please share details on > how you've been testing this? > > I know qemu supports qemu -cpu e6500, but beyond that what does the machine > look like? I've been using a T4240RDB, so real hardware. It boots both the QorIQ Yocto-based

Re: [RFC PATCH 2/2] powerpc/mm/hash64: Map all the kernel mapping in the same 0xc range

2019-02-18 Thread Aneesh Kumar K.V
On 2/19/19 11:28 AM, Nicholas Piggin wrote: Aneesh Kumar K.V's on February 17, 2019 3:16 pm: This patch maps vmap, IO and vmemap regions in the 0xc address range instead of the current 0xd and 0xf range. This brings the mapping closer to radix translation mode. What was the reason for that

Re: [RFC PATCH 2/2] powerpc/mm/hash64: Map all the kernel mapping in the same 0xc range

2019-02-18 Thread Nicholas Piggin
Aneesh Kumar K.V's on February 17, 2019 3:16 pm: > This patch maps vmap, IO and vmemap regions in the 0xc address range > instead of the current 0xd and 0xf range. This brings the mapping closer > to radix translation mode. What was the reason for that address layout in the first place? Thanks,

Re: [PATCH] powerpc/book3s: Remove a few page table update interfaces.

2019-02-18 Thread Aneesh Kumar K.V
On 2/19/19 11:23 AM, Nicholas Piggin wrote: Aneesh Kumar K.V's on February 14, 2019 4:45 pm: When updating page tables, we need to make sure we fill the page table entry valid bit. We should be using page table populate interface for updating the table entries. The page table 'set' interface

Re: [PATCH] powerpc/book3s: Remove a few page table update interfaces.

2019-02-18 Thread Nicholas Piggin
Aneesh Kumar K.V's on February 14, 2019 4:45 pm: > When updating page tables, we need to make sure we fill the page table > entry valid bit. We should be using page table populate interface for > updating the table entries. The page table 'set' interface allows > updating the raw value of page

Re: [RFC PATCH v1] powerpc/accounting: do not account system time on transition to user.

2019-02-18 Thread Nicholas Piggin
Christophe Leroy's on February 9, 2019 12:40 am: > Time spent in kernel mode don't need to be accounted on transition > to user space. As far as the time spent in user is known, it > is possible to calculate the time spent in kernel by substracting > the time spent in user. > > To do so, this

Re: [PATCH] powerpc: fix 32-bit KVM-PR lockup and panic with MacOS guest

2019-02-18 Thread Michael Ellerman
Mark Cave-Ayland writes: > On 11/02/2019 00:30, Benjamin Herrenschmidt wrote: > >> On Fri, 2019-02-08 at 14:51 +, Mark Cave-Ayland wrote: >>> >>> Indeed, but there are still some questions to be asked here: >>> >>> 1) Why were these bits removed from the original bitmask in the first place

Re: [PATCH] powerpc/powernv/idle: Restore IAMR after idle

2019-02-18 Thread Nicholas Piggin
Michael Ellerman's on February 8, 2019 11:04 am: > Nicholas Piggin writes: >> Russell Currey's on February 6, 2019 4:28 pm: >>> Without restoring the IAMR after idle, execution prevention on POWER9 >>> with Radix MMU is overwritten and the kernel can freely execute userspace >>> without >>>

Re: [PATCH] powerpc: fix 32-bit KVM-PR lockup and panic with MacOS guest

2019-02-18 Thread Michael Ellerman
Mark Cave-Ayland writes: > On 08/02/2019 14:45, Christophe Leroy wrote: > >> Le 08/02/2019 à 15:33, Mark Cave-Ayland a écrit : >>> Commit 8792468da5e1 "powerpc: Add the ability to save FPU without giving it >>> up" >> >> Expected format for the above is: >> >> Commit 123456789abc ("text") > >

Re: [PATCH v6] powerpc/64s: reimplement book3s idle code in C

2019-02-18 Thread Nicholas Piggin
Paul Mackerras's on February 18, 2019 9:06 am: > On Sat, Oct 13, 2018 at 10:04:09PM +1000, Nicholas Piggin wrote: >> Reimplement Book3S idle code in C, moving POWER7/8/9 implementation >> speific HV idle code to the powernv platform code. >> > > [...] > >> @@ -2760,21 +2744,47 @@

[PATCH v2] KVM: PPC: Book3S: Add KVM stat largepages_[2M/1G]

2019-02-18 Thread Suraj Jitindar Singh
This adds an entry to the kvm_stats_debugfs directory which provides the number of large (2M or 1G) pages which have been used to setup the guest mappings. Signed-off-by: Suraj Jitindar Singh --- V1 -> V2: - Rename debugfs files from num_[2M/1G]_pages to largepages_[2M/1G] to match x86

Re: [PATCH -next] powerpc/pseries: Drop pointless static qualifier in vpa_debugfs_init()

2019-02-18 Thread Daniel Axtens
Hi YueHaibing, writes: > There is no need to have the 'struct dentry *vpa_dir' variable static > since new value always be assigned before use it. > Much to my surprise this seems to be a correct change. I don't know why the struct was ever static but it seems to have been this way since the

Re: [RFC PATCH v3 3/4] kvmppc: H_SVM_INIT_START and H_SVM_INIT_DONE hcalls

2019-02-18 Thread Bharata B Rao
On Tue, Feb 19, 2019 at 02:21:40PM +1100, Paul Mackerras wrote: > On Wed, Jan 30, 2019 at 11:37:25AM +0530, Bharata B Rao wrote: > > H_SVM_INIT_START: Initiate securing a VM > > H_SVM_INIT_DONE: Conclude securing a VM > > > > During early guest init, these hcalls will be issued by UV. > > As part

Re: [RFC PATCH v3 3/4] kvmppc: H_SVM_INIT_START and H_SVM_INIT_DONE hcalls

2019-02-18 Thread Paul Mackerras
On Wed, Jan 30, 2019 at 11:37:25AM +0530, Bharata B Rao wrote: > H_SVM_INIT_START: Initiate securing a VM > H_SVM_INIT_DONE: Conclude securing a VM > > During early guest init, these hcalls will be issued by UV. > As part of these hcalls, [un]register memslots with UV. That last sentence is a

Re: [PATCH 05/11] tracing: consolidate the TRACE_IRQFLAGS_SUPPORT symbol

2019-02-18 Thread Ley Foon Tan
On Fri, 2019-02-15 at 16:55 +0900, Masahiro Yamada wrote: > +CC: Ley Foon Tan > +CC: nios2-...@lists.rocketboards.org > > > On Thu, Feb 14, 2019 at 2:40 AM Christoph Hellwig wrote: > > > > > diff --git a/arch/nios2/Kconfig b/arch/nios2/Kconfig > > index 715e6c09b4a5..3b50689007f5 100644 > >

Re: [PATCH] powerpc/ptrace: Simplify vr_get/set() to avoid GCC warning

2019-02-18 Thread Michael Ellerman
Meelis Roos writes: >> Rather than relying on that we can pass an explict end_pos based on >> the sizeof(vrsave). The result should be exactly the same but it's >> more obviously not over-reading/writing the stack and it avoids the >> compiler warning. > > It works on my PowerMac G4 with

Re: [PATCH kernel] powerpc/powernv/sriov: Register IOMMU groups for VFs

2019-02-18 Thread David Gibson
On Mon, Feb 18, 2019 at 04:58:01PM +1100, Alexey Kardashevskiy wrote: > The compound IOMMU group rework moved iommu_register_group() together in > pnv_pci_ioda_setup_iommu_api() (which is a part of ppc_md.pcibios_fixup). > As the result, pnv_ioda_setup_bus_iommu_group() does not create groups >

Re: [RFC PATCH 4/5] powerpc: move KASAN into its own subdirectory

2019-02-18 Thread Michael Ellerman
Christophe Leroy writes: > Le 18/02/2019 à 10:14, Michael Ellerman a écrit : >> christophe leroy writes: >> >>> Le 15/02/2019 à 01:04, Daniel Axtens a écrit : In preparation for adding ppc64 implementations, break out the code into its own subdirectory. >>> >>> That's not a bad idea,

Re: [RFC PATCH 5/5] powerpc: KASAN for 64bit Book3E

2019-02-18 Thread Daniel Axtens
>> diff --git a/arch/powerpc/mm/kasan/kasan_init_book3e_64.c >> b/arch/powerpc/mm/kasan/kasan_init_book3e_64.c >> new file mode 100644 >> index ..93b9afcf1020 >> --- /dev/null >> +++ b/arch/powerpc/mm/kasan/kasan_init_book3e_64.c >> @@ -0,0 +1,53 @@ >> +// SPDX-License-Identifier:

[PATCH 8/8] iio/counter/ftm-quaddec: add handling of under/overflow of the counter.

2019-02-18 Thread Patrick Havelange
This is implemented by polling the counter value. A new parameter "poll-interval" can be set in the device tree, or can be changed at runtime. The reason for the polling is to avoid interrupts flooding. If the quadrature input is going up and down around the overflow value (or around 0), the

[PATCH 4/8] dt-bindings: iio/counter: ftm-quaddec

2019-02-18 Thread Patrick Havelange
FlexTimer quadrature decoder driver. Signed-off-by: Patrick Havelange Reviewed-by: Esben Haabendal --- .../bindings/iio/counter/ftm-quaddec.txt | 18 ++ 1 file changed, 18 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/counter/ftm-quaddec.txt

[PATCH 7/8] dt-bindings: iio/counter: ftm-quaddec: add poll-interval parameter

2019-02-18 Thread Patrick Havelange
New optional parameter supported by updated driver. Signed-off-by: Patrick Havelange Reviewed-by: Esben Haabendal --- .../devicetree/bindings/iio/counter/ftm-quaddec.txt | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

[PATCH 6/8] LS1021A: dtsi: add ftm quad decoder entries

2019-02-18 Thread Patrick Havelange
Add the 4 Quadrature counters for this board. Signed-off-by: Patrick Havelange Reviewed-by: Esben Haabendal --- arch/arm/boot/dts/ls1021a.dtsi | 28 1 file changed, 28 insertions(+) diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi index

[PATCH 2/8] drivers/pwm: pwm-fsl-ftm: use common header for FlexTimer #defines

2019-02-18 Thread Patrick Havelange
This also fixes the wrong value for the previously defined FTM_MODE_INIT macro (it was not used). Signed-off-by: Patrick Havelange Reviewed-by: Esben Haabendal --- drivers/pwm/pwm-fsl-ftm.c | 44 +-- 1 file changed, 1 insertion(+), 43 deletions(-) diff

[PATCH 1/8] include/fsl: add common FlexTimer #defines in a separate header.

2019-02-18 Thread Patrick Havelange
Signed-off-by: Patrick Havelange Reviewed-by: Esben Haabendal --- include/linux/fsl/ftm.h | 88 + 1 file changed, 88 insertions(+) create mode 100644 include/linux/fsl/ftm.h diff --git a/include/linux/fsl/ftm.h b/include/linux/fsl/ftm.h new file mode

[PATCH 3/8] drivers/clocksource: timer-fsl-ftm: use common header for FlexTimer #defines

2019-02-18 Thread Patrick Havelange
Signed-off-by: Patrick Havelange Reviewed-by: Esben Haabendal --- drivers/clocksource/timer-fsl-ftm.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/clocksource/timer-fsl-ftm.c b/drivers/clocksource/timer-fsl-ftm.c index 846d18daf893..e1c34b2f53a5

[PATCH 5/8] iio/counter: add FlexTimer Module Quadrature decoder counter driver

2019-02-18 Thread Patrick Havelange
This driver exposes the counter for the quadrature decoder of the FlexTimer Module, present in the LS1021A soc. Signed-off-by: Patrick Havelange Reviewed-by: Esben Haabendal --- drivers/iio/counter/Kconfig | 10 + drivers/iio/counter/Makefile | 1 +

Re: [RFC PATCH 5/5] powerpc: KASAN for 64bit Book3E

2019-02-18 Thread Christophe Leroy
Le 15/02/2019 à 01:04, Daniel Axtens a écrit : Wire up KASAN. Only outline instrumentation is supported. The KASAN shadow area is mapped into vmemmap space: 0x8000 0400 to 0x8000 0600 . To do this we require that vmemmap be disabled. (This is the default in the kernel

Applied "ASoC: fsl_spdif: fix sysclk_df type" to the asoc tree

2019-02-18 Thread Mark Brown
The patch ASoC: fsl_spdif: fix sysclk_df type has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus

Applied "ASoC: fsl_spdif: fix sysclk_df type" to the asoc tree

2019-02-18 Thread Mark Brown
The patch ASoC: fsl_spdif: fix sysclk_df type has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus

Applied "ASoC: fsl_spdif: fix TXCLK_DF mask" to the asoc tree

2019-02-18 Thread Mark Brown
The patch ASoC: fsl_spdif: fix TXCLK_DF mask has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus

Re: [PATCH v04] powerpc/numa: Perform full re-add of CPU for PRRN/VPHN topology update

2019-02-18 Thread Michael Bringmann
On 2/18/19 8:15 AM, Michal Suchánek wrote: > On Mon, 18 Feb 2019 11:49:17 +0100 > Michal Suchánek wrote: > > Nevermind > > Looks like some version of the patch is queued in powerpc/next already. Might you be referring to, [PATCH] powerpc/pseries: Perform full re-add of CPU for topology

[PATCH] ASoC: fsl_spdif: fix sysclk_df type

2019-02-18 Thread Viorel Suman
According to RM SPDIF STC SYSCLK_DF field is 9-bit wide, values being in 0..511 range. Use a proper type to handle sysclk_df. Signed-off-by: Viorel Suman --- sound/soc/fsl/fsl_spdif.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/sound/soc/fsl/fsl_spdif.c

[PATCH 1/3] SoC: imx-sgtl5000: add missing put_device()

2019-02-18 Thread Wen Yang
The of_find_device_by_node() takes a reference to the underlying device structure, we should release that reference. Detected by coccinelle with the following warnings: ./sound/soc/fsl/imx-sgtl5000.c:169:1-7: ERROR: missing put_device; call of_find_device_by_node on line 105, but without a

Re: [PATCH v4 0/3] locking/rwsem: Rwsem rearchitecture part 0

2019-02-18 Thread Will Deacon
On Fri, Feb 15, 2019 at 01:58:34PM -0500, Waiman Long wrote: > On 02/15/2019 01:40 PM, Will Deacon wrote: > > On Thu, Feb 14, 2019 at 11:37:15AM +0100, Peter Zijlstra wrote: > >> On Wed, Feb 13, 2019 at 05:00:14PM -0500, Waiman Long wrote: > >>> v4: > >>> - Remove rwsem-spinlock.c and make all

Re: [PATCH 3/8] drivers/clocksource: timer-fsl-ftm: use common header for FlexTimer #defines

2019-02-18 Thread Daniel Lezcano
On 18/02/2019 15:03, Patrick Havelange wrote: Changelog please > Signed-off-by: Patrick Havelange > Reviewed-by: Esben Haabendal > --- > drivers/clocksource/timer-fsl-ftm.c | 15 ++- > 1 file changed, 2 insertions(+), 13 deletions(-) > > diff --git

Re: [PATCH v04] powerpc/numa: Perform full re-add of CPU for PRRN/VPHN topology update

2019-02-18 Thread Michal Suchánek
On Mon, 18 Feb 2019 11:49:17 +0100 Michal Suchánek wrote: Nevermind Looks like some version of the patch is queued in powerpc/next already. Thanks Michal

[PATCH] ASoC: fsl_spdif: fix TXCLK_DF mask

2019-02-18 Thread Viorel Suman
According to RM SPDIF TXCLK_DF mask is 7-bit wide. Signed-off-by: Viorel Suman --- sound/soc/fsl/fsl_spdif.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/fsl_spdif.h b/sound/soc/fsl/fsl_spdif.h index 7666dab..e6c61e0 100644 --- a/sound/soc/fsl/fsl_spdif.h

[PATCH 3.18 052/108] block/swim3: Fix -EBUSY error when re-opening device after unmount

2019-02-18 Thread Greg Kroah-Hartman
3.18-stable review patch. If anyone has any objections, please let me know. -- [ Upstream commit 296dcc40f2f2e402facf7cd26cf3f2c8f4b17d47 ] When the block device is opened with FMODE_EXCL, ref_count is set to -1. This value doesn't get reset when the device is closed which

[PATCH 4.4 068/143] block/swim3: Fix -EBUSY error when re-opening device after unmount

2019-02-18 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- [ Upstream commit 296dcc40f2f2e402facf7cd26cf3f2c8f4b17d47 ] When the block device is opened with FMODE_EXCL, ref_count is set to -1. This value doesn't get reset when the device is closed which means

[PATCH v2 -next] powerpc/pseries: Fix platform_no_drv_owner.cocci warnings

2019-02-18 Thread YueHaibing
Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Signed-off-by: YueHaibing --- arch/powerpc/platforms/pseries/papr_scm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/powerpc/platforms/pseries/papr_scm.c

Re: [PATCH -next] powerpc/pseries: Fix platform_no_drv_owner.cocci warnings

2019-02-18 Thread YueHaibing
On 2019/2/18 20:53, Julia Lawall wrote: > > > On Mon, 18 Feb 2019, YueHaibing wrote: > >> Remove .owner field if calls are used which set it automatically >> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci >> >> Signed-off-by: YueHaibing >> --- >>

Re: [PATCH -next] powerpc/pseries: Fix platform_no_drv_owner.cocci warnings

2019-02-18 Thread Julia Lawall
On Mon, 18 Feb 2019, YueHaibing wrote: > Remove .owner field if calls are used which set it automatically > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci > > Signed-off-by: YueHaibing > --- > arch/powerpc/platforms/pseries/papr_scm.c | 2 +- > 1 file changed, 1

[PATCH -next] powerpc/pseries: Fix platform_no_drv_owner.cocci warnings

2019-02-18 Thread YueHaibing
Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Signed-off-by: YueHaibing --- arch/powerpc/platforms/pseries/papr_scm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH -next] powerpc/pseries: Drop pointless static qualifier in vpa_debugfs_init()

2019-02-18 Thread YueHaibing
There is no need to have the 'struct dentry *vpa_dir' variable static since new value always be assigned before use it. Signed-off-by: YueHaibing --- arch/powerpc/platforms/pseries/lpar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/pseries/lpar.c

[PATCH] powerpc: Move page table dump files in a dedicated subdirectory

2019-02-18 Thread Christophe Leroy
This patch moves the files related to page table dump in a dedicated subdirectory. The purpose is to clean a bit arch/powerpc/mm by regrouping multiple files handling a dedicated function. Signed-off-by: Christophe Leroy --- arch/powerpc/Kconfig.debug | 4

Re: [RFC PATCH 4/5] powerpc: move KASAN into its own subdirectory

2019-02-18 Thread Christophe Leroy
Le 18/02/2019 à 10:14, Michael Ellerman a écrit : christophe leroy writes: Le 15/02/2019 à 01:04, Daniel Axtens a écrit : In preparation for adding ppc64 implementations, break out the code into its own subdirectory. That's not a bad idea, arch/powerpc/mm is rather messy with lot of

[PATCH] powerpc: dump as a single line areas mapping a single physical page.

2019-02-18 Thread Christophe Leroy
When using KASAN, there are parts of the shadow area where all pages are mapped to the kasan_early_shadow_page. It is pointless to dump one line for each of those pages (in the example below there are 7168 entries pointing to the same physical page). ~# cat /sys/kernel/debug/kernel_page_tables

Re: [PATCH v04] powerpc/numa: Perform full re-add of CPU for PRRN/VPHN topology update

2019-02-18 Thread Michal Suchánek
On Thu, 14 Feb 2019 09:56:26 -0600 Michael Bringmann wrote: Hello, > To: linuxppc-dev@lists.ozlabs.org > To: linux-ker...@vger.kernel.org > Benjamin Herrenschmidt > Paul Mackerras > Michael Ellerman > Nathan Lynch > Corentin Labbe > Tyrel Datwyler > Srikar Dronamraju > Guenter Roeck >

Re: [PATCH v5 3/3] powerpc/32: Add KASAN support

2019-02-18 Thread Michael Ellerman
Christophe Leroy writes: > diff --git a/arch/powerpc/include/asm/ppc_asm.h > b/arch/powerpc/include/asm/ppc_asm.h > index e0637730a8e7..dba2c1038363 100644 > --- a/arch/powerpc/include/asm/ppc_asm.h > +++ b/arch/powerpc/include/asm/ppc_asm.h > @@ -251,6 +251,10 @@ GLUE(.,name): > > #define

Re: [RFC PATCH 4/5] powerpc: move KASAN into its own subdirectory

2019-02-18 Thread Michael Ellerman
christophe leroy writes: > Le 15/02/2019 à 01:04, Daniel Axtens a écrit : >> In preparation for adding ppc64 implementations, break out the >> code into its own subdirectory. > > That's not a bad idea, arch/powerpc/mm is rather messy with lot of > subarch stuff. I'm always happy to have more

[PATCH V3] ASoC: fsl_esai: fix register setting issue in RIGHT_J mode

2019-02-18 Thread S.j. Wang
The ESAI_xCR_xWA is xCR's bit, not the xCCR's bit, driver set it to wrong register, correct it. Fixes 43d24e76b698 ("ASoC: fsl_esai: Add ESAI CPU DAI driver") Cc: Signed-off-by: Shengjiu Wang Reviewed-by: Fabio Estevam Ackedy-by: Nicolin Chen --- Changes in v3 - Add Cc:

RE: [PATCH V2] ASoC: fsl_esai: fix register setting issue in RIGHT_J mode

2019-02-18 Thread S.j. Wang
Thanks, will send the patch again. Best regards Wang shengjiu > > On Mon, Feb 18, 2019 at 02:08:52AM +, S.j. Wang wrote: > > Fixes commit 43d24e76b698 ("ASoC: fsl_esai: Add ESAI CPU DAI driver") > > > > The ESAI_xCR_xWA is xCR's bit, not the xCCR's bit, driver set it to > > wrong register,

Re: [PATCH V2] ASoC: fsl_esai: fix register setting issue in RIGHT_J mode

2019-02-18 Thread Greg KH
On Mon, Feb 18, 2019 at 02:08:52AM +, S.j. Wang wrote: > Fixes commit 43d24e76b698 ("ASoC: fsl_esai: Add ESAI CPU DAI driver") > > The ESAI_xCR_xWA is xCR's bit, not the xCCR's bit, driver set it to > wrong register, correct it. > > Signed-off-by: Shengjiu Wang > Reviewed-by: Fabio Estevam