Re: [PATCH 1/5] ocxl: Rename struct link to ocxl_link

2019-02-26 Thread Andrew Donnellan
On 27/2/19 6:34 pm, Alastair D'Silva wrote:>>> diff --git a/drivers/misc/ocxl/file.c b/drivers/misc/ocxl/file.c index e6a607488f8a..16eb8a60d5c7 100644 --- a/drivers/misc/ocxl/file.c +++ b/drivers/misc/ocxl/file.c @@ -152,7 +152,7 @@ static long afu_ioctl_enable_p9_wait(struct ocxl_context *ctx,

RE: [PATCH 1/5] ocxl: Rename struct link to ocxl_link

2019-02-26 Thread Alastair D'Silva
> -Original Message- > From: Andrew Donnellan > Sent: Wednesday, 27 February 2019 6:16 PM > To: Alastair D'Silva ; alast...@d-silva.org > Cc: Greg Kurz ; Frederic Barrat ; > Arnd Bergmann ; Greg Kroah-Hartman > ; linuxppc-dev@lists.ozlabs.org; linux- > ker...@vger.kernel.org > Subject:

Re: [PATCH 1/5] ocxl: Rename struct link to ocxl_link

2019-02-26 Thread Andrew Donnellan
On 27/2/19 3:57 pm, Alastair D'Silva wrote: From: Alastair D'Silva The term 'link' is ambiguous (especially when the struct is used for a list), so rename it for clarity. Signed-off-by: Alastair D'Silva Reviewed-by: Greg Kurz --- drivers/misc/ocxl/file.c | 2 +- drivers/misc/ocxl/link.c

Re: [PATCH v8 02/11] powerpc: prepare string/mem functions for KASAN

2019-02-26 Thread Daniel Axtens
Christophe Leroy writes: > CONFIG_KASAN implements wrappers for memcpy() memmove() and memset() > Those wrappers are doing the verification then call respectively > __memcpy() __memmove() and __memset(). The arches are therefore > expected to rename their optimised functions that way. > > For

Re: [PATCH] powerpc/fsl: Fix the flush of branch predictor.

2019-02-26 Thread Diana Madalina Craciun
Reviewed-by: Diana Craciun Thanks for fixing it! On 2/26/2019 8:18 PM, Christophe Leroy wrote: > The commit identified below adds MC_BTB_FLUSH macro only when > CONFIG_PPC_FSL_BOOK3E is defined. This results in the following error > on some configs (seen several times with kisskb

Re: build failure of current mmotm with skiroot_defconfig

2019-02-26 Thread Christophe Leroy
Le 26/02/2019 à 23:24, Paul Mackerras a écrit : On Tue, Feb 26, 2019 at 11:59:08AM +0200, Mike Rapoport wrote: On Tue, Feb 26, 2019 at 10:39:54AM +0100, Christophe Leroy wrote: Le 26/02/2019 à 09:12, Mike Rapoport a écrit : Hi, I've encountered the following error when building

[PATCH V4] ASoC: fsl_esai: fix channel swap issue when stream starts

2019-02-26 Thread S.j. Wang
There is very low possibility ( < 0.1% ) that channel swap happened in beginning when multi output/input pin is enabled. The issue is that hardware can't send data to correct pin in the beginning with the normal enable flow. This is hardware issue, but there is no errata, the workaround flow is

RE: [PATCH V3] ASoC: fsl_esai: fix channel swap issue when stream starts

2019-02-26 Thread S.j. Wang
Ok, will send v4. Best regards Wang shengjiu > > Hi Shengjiu, > > Two more trivial comments inline. > > On Tue, Feb 26, 2019 at 03:12:25AM +, S.j. Wang wrote: > > There is very low possibility ( < 0.1% ) that channel swap happened in > > beginning when multi output/input pin is enabled.

[PATCH 4/5] ocxl: Remove superfluous 'extern' from headers

2019-02-26 Thread Alastair D'Silva
From: Alastair D'Silva The 'extern' keyword adds no value here. Signed-off-by: Alastair D'Silva --- drivers/misc/ocxl/ocxl_internal.h | 54 +++ include/misc/ocxl.h | 36 ++--- 2 files changed, 44 insertions(+), 46 deletions(-) diff

[PATCH 0/5] ocxl: OpenCAPI Cleanup

2019-02-26 Thread Alastair D'Silva
From: Alastair D'Silva Some minor cleanups for the OpenCAPI driver as a prerequisite for an ocxl driver refactoring to allow the driver core to be utilised by external drivers. Alastair D'Silva (5): ocxl: Rename struct link to ocxl_link ocxl: Clean up printf formats ocxl: read_pasid never

[PATCH 1/5] ocxl: Rename struct link to ocxl_link

2019-02-26 Thread Alastair D'Silva
From: Alastair D'Silva The term 'link' is ambiguous (especially when the struct is used for a list), so rename it for clarity. Signed-off-by: Alastair D'Silva Reviewed-by: Greg Kurz --- drivers/misc/ocxl/file.c | 2 +- drivers/misc/ocxl/link.c | 36 ++-- 2

[PATCH 3/5] ocxl: read_pasid never returns an error, so make it void

2019-02-26 Thread Alastair D'Silva
From: Alastair D'Silva No need for a return value in read_pasid as it only returns 0. Signed-off-by: Alastair D'Silva Reviewed-by: Greg Kurz --- drivers/misc/ocxl/config.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/misc/ocxl/config.c

[PATCH 2/5] ocxl: Clean up printf formats

2019-02-26 Thread Alastair D'Silva
From: Alastair D'Silva Use %# instead of using a literal '0x' Signed-off-by: Alastair D'Silva --- drivers/misc/ocxl/config.c | 6 +++--- drivers/misc/ocxl/context.c | 2 +- drivers/misc/ocxl/trace.h | 10 +- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git

[PATCH 5/5] ocxl: Remove some unused exported symbols

2019-02-26 Thread Alastair D'Silva
From: Alastair D'Silva Remove some unused exported symbols. Signed-off-by: Alastair D'Silva --- drivers/misc/ocxl/config.c| 2 -- drivers/misc/ocxl/ocxl_internal.h | 26 +- include/misc/ocxl.h | 23 --- 3 files changed, 25

[PATCH 6/8] PCI: iproc: fix a leaked reference by adding missing of_node_put

2019-02-26 Thread Wen Yang
The call to of_parse_phandle returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. iproc_msi_init also calls of_node_get to increase refcount (proc_msi_init -> iproc_msi_alloc_domains -> pci_msi_create_irq_domain -> msi_create_irq_domain ->

[PATCH 7/8] PCI: mediatek: fix a leaked reference by adding missing of_node_put

2019-02-26 Thread Wen Yang
The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. irq_domain_add_linear also calls of_node_get to increase refcount, so irq_domain will not be affected when it is released. Detected by coccinelle with the

[PATCH 8/8] PCI: rpadlpar: fix a leaked reference by adding missing of_node_put

2019-02-26 Thread Wen Yang
The call to of_find_node_by_name returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./drivers/pci/hotplug/rpadlpar_core.c:55:1-7: ERROR: missing of_node_put; acquired a node pointer

[PATCH 2/8] PCI: uniphier: fix a leaked reference by adding missing of_node_put

2019-02-26 Thread Wen Yang
The call to of_get_child_by_name returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. irq_domain_add_linear also calls of_node_get to increase refcount, so irq_domain will not be affected when it is released. Detected by coccinelle with the

[PATCH 4/8] PCI: rockchip: fix a leaked reference by adding missing of_node_put

2019-02-26 Thread Wen Yang
The call to of_get_child_by_name returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. irq_domain_add_linear also calls of_node_get to increase refcount, so irq_domain will not be affected when it is released. Detected by coccinelle with the

[PATCH 5/8] PCI: aardvark: fix a leaked reference by adding missing of_node_put

2019-02-26 Thread Wen Yang
The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. irq_domain_add_linear also calls of_node_get to increase refcount, so irq_domain will not be affected when it is released. Detected by coccinelle with the

[PATCH 3/8] PCI: dwc: layerscape: fix a leaked reference by adding missing of_node_put

2019-02-26 Thread Wen Yang
The call to of_parse_phandle returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./drivers/pci/controller/dwc/pci-layerscape.c:204:1-7: ERROR: missing of_node_put; acquired a node

[PATCH 1/8] PCI: dwc: pci-dra7xx: fix a leaked reference by adding missing of_node_put

2019-02-26 Thread Wen Yang
The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. irq_domain_add_linear also calls of_node_get to increase refcount, so irq_domain will not be affected when it is released. Detected by coccinelle with the

Re: [PATCH 00/18] Add FADump support on PowerNV platform

2019-02-26 Thread Nicholas Piggin
Hari Bathini's on February 22, 2019 3:35 am: > Firmware-Assisted Dump (FADump) is currently supported only on pseries > platform. This patch series adds support for powernv platform too. > > The first and third patches refactor the FADump code to make use of common > code across multiple

Re: [PATCH] powerpc/powernv: Make opal log only readable by root

2019-02-26 Thread Andrew Donnellan
On 27/2/19 2:02 pm, Jordan Niethe wrote: Currently the opal log is globally readable. It is kernel policy to limit the visibility of physical addresses / kernel pointers to root. Given this and the fact the opal log may contain this information it would be better to limit the readability to

Re: [PATCH] powerpc/powernv: Make opal log only readable by root

2019-02-26 Thread Stewart Smith
Jordan Niethe writes: > Currently the opal log is globally readable. It is kernel policy to limit > the visibility of physical addresses / kernel pointers to root. > Given this and the fact the opal log may contain this information it would > be better to limit the readability to root. > >

Re: [PATCH 00/18] Add FADump support on PowerNV platform

2019-02-26 Thread Daniel Axtens
Hi Hari, > Firmware-Assisted Dump (FADump) is currently supported only on pseries > platform. This patch series adds support for powernv platform too. > > The first and third patches refactor the FADump code to make use of common > code across multiple platforms. The fifth patch adds basic FADump

Re: [PATCH] powerpc/fsl: Fix the flush of branch predictor.

2019-02-26 Thread Daniel Axtens
Christophe Leroy writes: > The commit identified below adds MC_BTB_FLUSH macro only when > CONFIG_PPC_FSL_BOOK3E is defined. This results in the following error > on some configs (seen several times with kisskb randconfig_defconfig) > > arch/powerpc/kernel/exceptions-64e.S:576: Error:

[PATCH] powerpc/powernv: Make opal log only readable by root

2019-02-26 Thread Jordan Niethe
Currently the opal log is globally readable. It is kernel policy to limit the visibility of physical addresses / kernel pointers to root. Given this and the fact the opal log may contain this information it would be better to limit the readability to root. Signed-off-by: Jordan Niethe ---

Re: [PATCH] powerpc/powernv: move OPAL call wrapper tracing and interrupt handling to C

2019-02-26 Thread Stewart Smith
Nicholas Piggin writes: > The OPAL call wrapper gets interrupt disabling wrong. It disables > interrupts just by clearing MSR[EE], which has two problems: > > - It doesn't call into the IRQ tracing subsystem, which means tracing > across OPAL calls does not always notice IRQs have been

Re: [PATCH V7 0/4] mm/kvm/vfio/ppc64: Migrate compound pages out of CMA region

2019-02-26 Thread Andrew Morton
[patch 1/4]: OK. I guess. Was this worth consuming our last PF_ flag? [patch 2/4]: unreviewed [patch 3/4]: unreviewed, mpe still unhappy, I expect? [patch 4/4]: unreviewed

Re: [PATCH V5 0/5] NestMMU pte upgrade workaround for mprotect

2019-02-26 Thread Andrew Morton
[patch 1/5]: unreviewed and has unaddressed comments from mpe. [patch 2/5]: ditto [patch 3/5]: ditto [patch 4/5]: seems ready [patch 5/5]: reviewed by mpe, but appears to need more work

Re: [PATCH v2 11/16] KVM: introduce a 'mmap' method for KVM devices

2019-02-26 Thread David Gibson
On Tue, Feb 26, 2019 at 01:52:39PM +0100, Paolo Bonzini wrote: > On 25/02/19 11:57, Cédric Le Goater wrote: > > Hello Paolo, > > > > On 2/25/19 4:33 AM, David Gibson wrote: > >> On Fri, Feb 22, 2019 at 12:28:35PM +0100, Cédric Le Goater wrote: > >>> Some KVM devices will want to handle special

Re: [PATCH v2 04/16] KVM: PPC: Book3S HV: XIVE: add a control to initialize a source

2019-02-26 Thread David Gibson
On Tue, Feb 26, 2019 at 03:25:15PM +1100, Paul Mackerras wrote: > On Mon, Feb 25, 2019 at 01:10:12PM +1100, David Gibson wrote: > > On Fri, Feb 22, 2019 at 12:28:28PM +0100, Cédric Le Goater wrote: > > > + /* > > > + * If the source doesn't already have an IPI, allocate > > > + * one and get the

Re: build failure of current mmotm with skiroot_defconfig

2019-02-26 Thread Paul Mackerras
On Tue, Feb 26, 2019 at 11:59:08AM +0200, Mike Rapoport wrote: > On Tue, Feb 26, 2019 at 10:39:54AM +0100, Christophe Leroy wrote: > > > > > > Le 26/02/2019 à 09:12, Mike Rapoport a écrit : > > >Hi, > > > > > >I've encountered the following error when building skyroot_defconfig with > > >current

[PATCH] KVM: PPC: Fix compilation when KVM is not enabled

2019-02-26 Thread Paul Mackerras
Compiling with CONFIG_PPC_POWERNV=y and KVM disabled currently gives an error like this: CC arch/powerpc/kernel/dbell.o In file included from arch/powerpc/kernel/dbell.c:20:0: arch/powerpc/include/asm/kvm_ppc.h: In function ‘xics_on_xive’: arch/powerpc/include/asm/kvm_ppc.h:625:9: error:

Re: [PATCH v1 4/4] clk: qoriq: Add clockgen support for lx2160a

2019-02-26 Thread Scott Wood
On Tue, 2019-02-26 at 10:11 +, Vabhav Sharma wrote: > From: Yogesh Gaur > > Add clockgen support for lx2160a. > Added entry for compat 'fsl,lx2160a-clockgen'. > > Signed-off-by: Tang Yuantian > Signed-off-by: Yogesh Gaur > Signed-off-by: Vabhav Sharma > Acked-by: Stephen Boyd >

Re: [PATCH v1 3/4] clk: qoriq: increase array size of cmux_to_group

2019-02-26 Thread Scott Wood
On Tue, 2019-02-26 at 10:11 +, Vabhav Sharma wrote: > From: Yogesh Gaur > > Increase size of cmux_to_group array, to accomdate entry of > -1 termination. > > Added -1, terminated, entry for 4080_cmux_grpX. > > Signed-off-by: Yogesh Gaur > Signed-off-by: Vabhav Sharma > Acked-by: Stephen

PROBLEM: monotonic clock going backwards on ppc64

2019-02-26 Thread Jakub Drnec
Hi all, I think I observed a potential problem, is this the correct place to report it? (CC me, not on list) [1.] One line summary: monotonic clock can be made to decrease on ppc64 [2.] Full description: Setting the realtime clock can sometimes make the monotonic clock go back by over a

Re: [PATCH V3] ASoC: fsl_esai: fix channel swap issue when stream starts

2019-02-26 Thread Nicolin Chen
Hi Shengjiu, Two more trivial comments inline. On Tue, Feb 26, 2019 at 03:12:25AM +, S.j. Wang wrote: > There is very low possibility ( < 0.1% ) that channel swap happened > in beginning when multi output/input pin is enabled. The issue is > that hardware can't send data to correct pin in

[PATCH] powerpc/fsl: Fix the flush of branch predictor.

2019-02-26 Thread Christophe Leroy
The commit identified below adds MC_BTB_FLUSH macro only when CONFIG_PPC_FSL_BOOK3E is defined. This results in the following error on some configs (seen several times with kisskb randconfig_defconfig) arch/powerpc/kernel/exceptions-64e.S:576: Error: Unrecognized opcode: `mc_btb_flush' make[3]:

Re: [PATCH] soc: fsl: guts: make fsl_guts_get_svr() static

2019-02-26 Thread Li Yang
On Fri, Feb 22, 2019 at 2:09 AM Y.b. Lu wrote: > > > > > -Original Message- > > From: Horia Geantă > > Sent: Thursday, February 21, 2019 6:38 PM > > To: Leo Li > > Cc: Y.b. Lu ; linuxppc-dev@lists.ozlabs.org; > > linux-arm-ker...@lists.infradead.org; linux-ker...@vger.kernel.org > >

[PATCH v8 10/11] powerpc/32s: move hash code patching out of MMU_init_hw()

2019-02-26 Thread Christophe Leroy
For KASAN, hash table handling will be activated early for accessing to KASAN shadow areas. In order to avoid any modification of the hash functions while they are still used with the early hash table, the code patching is moved out of MMU_init_hw() and put close to the big-bang switch to the

[PATCH v8 11/11] powerpc/32s: set up an early static hash table for KASAN.

2019-02-26 Thread Christophe Leroy
KASAN requires early activation of hash table, before memblock() functions are available. This patch implements an early hash_table statically defined in __initdata. During early boot, a single page table is used. For hash32, when doing the final init, one page table is allocated for each PGD

[PATCH v8 08/11] powerpc: disable KASAN instrumentation on early/critical files.

2019-02-26 Thread Christophe Leroy
All files containing functions run before kasan_early_init() is called must have KASAN instrumentation disabled. For those file, branch profiling also have to be disabled otherwise each if () generates a call to ftrace_likely_update(). Signed-off-by: Christophe Leroy ---

[PATCH v8 05/11] powerpc/32: use memset() instead of memset_io() to zero BSS

2019-02-26 Thread Christophe Leroy
Since commit 400c47d81ca38 ("powerpc32: memset: only use dcbz once cache is enabled"), memset() can be used before activation of the cache, so no need to use memset_io() for zeroing the BSS. Acked-by: Dmitry Vyukov Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/early_32.c | 4 ++-- 1

[PATCH v8 09/11] powerpc/32: Add KASAN support

2019-02-26 Thread Christophe Leroy
This patch adds KASAN support for PPC32. The following patch will add an early activation of hash table for book3s. Until then, a warning will be raised if trying to use KASAN on an hash 6xx. To support KASAN, this patch initialises that MMU mapings for accessing to the KASAN shadow area defined

[PATCH v8 06/11] powerpc/32: make KVIRT_TOP dependent on FIXMAP_START

2019-02-26 Thread Christophe Leroy
When we add KASAN shadow area, KVIRT_TOP can't be anymore fixed at 0xfe00. This patch uses FIXADDR_START to define KVIRT_TOP. Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/book3s/32/pgtable.h | 13 ++--- arch/powerpc/include/asm/nohash/32/pgtable.h | 13 ++---

[PATCH v8 07/11] powerpc/32: prepare shadow area for KASAN

2019-02-26 Thread Christophe Leroy
This patch prepares a shadow area for KASAN. The shadow area will be at the top of the kernel virtual memory space above the fixmap area and will occupy one eighth of the total kernel virtual memory space. Signed-off-by: Christophe Leroy --- arch/powerpc/Kconfig.debug| 5 +

[PATCH v8 03/11] powerpc/prom_init: don't use string functions from lib/

2019-02-26 Thread Christophe Leroy
When KASAN is active, the string functions in lib/ are doing the KASAN checks. This is too early for prom_init. This patch implements dedicated string functions for prom_init, which will be compiled in with KASAN disabled. Size of prom_init before the patch: textdata bss dec

[PATCH v8 01/11] powerpc/32: Move early_init() in a separate file

2019-02-26 Thread Christophe Leroy
In preparation of KASAN, move early_init() into a separate file in order to allow deactivation of KASAN for that function. Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/Makefile | 2 +- arch/powerpc/kernel/early_32.c | 36

[PATCH v8 02/11] powerpc: prepare string/mem functions for KASAN

2019-02-26 Thread Christophe Leroy
CONFIG_KASAN implements wrappers for memcpy() memmove() and memset() Those wrappers are doing the verification then call respectively __memcpy() __memmove() and __memset(). The arches are therefore expected to rename their optimised functions that way. For files on which KASAN is inhibited,

[PATCH v8 00/11] KASAN for powerpc/32

2019-02-26 Thread Christophe Leroy
This series adds KASAN support to powerpc/32 Tested on nohash/32 (8xx) and book3s/32 (mpc832x ie 603). Boot tested on qemu mac99 Changes in v8: - Fixed circular issue between pgtable.h and fixmap.h - Added missing includes in ppc64 string files - Fixed kasan string related macro names for ppc64.

[PATCH v8 04/11] powerpc/mm: don't use direct assignation during early boot.

2019-02-26 Thread Christophe Leroy
In kernel/cputable.c, explicitly use memcpy() instead of *y = *x; This will allow GCC to replace it with __memcpy() when KASAN is selected. Acked-by: Dmitry Vyukov Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/cputable.c | 13 ++--- 1 file changed, 10 insertions(+), 3

Re: [PATCH 0/2] x86, numa: always initialize all possible nodes

2019-02-26 Thread Michal Hocko
On Tue 12-02-19 10:53:41, Michal Hocko wrote: > Hi, > this has been posted as an RFC previously [1]. There didn't seem to be > any objections so I am reposting this for inclusion. I have added a > debugging patch which prints the zonelist setup for each numa node > for an easier debugging of a

Re: [PATCH V3 1/10] X86/Hyper-V: Add parameter offset for hyperv_fill_flush_guest_mapping_list()

2019-02-26 Thread Tianyu Lan
Hi Stephen: Thanks for your review. On Sat, Feb 23, 2019 at 1:08 AM Stephen Hemminger wrote: > > int hyperv_fill_flush_guest_mapping_list( > struct hv_guest_mapping_flush_list *flush, > - u64 start_gfn, u64 pages) > + int offset, u64

Re: [PATCH v2 11/16] KVM: introduce a 'mmap' method for KVM devices

2019-02-26 Thread Paolo Bonzini
On 25/02/19 11:57, Cédric Le Goater wrote: > Hello Paolo, > > On 2/25/19 4:33 AM, David Gibson wrote: >> On Fri, Feb 22, 2019 at 12:28:35PM +0100, Cédric Le Goater wrote: >>> Some KVM devices will want to handle special mappings related to the >>> underlying HW. For instance, the XIVE interrupt

Re: Re: Kernel panic when loading the IDE controller driver

2019-02-26 Thread Bartlomiej Zolnierkiewicz
On 02/14/2019 06:54 PM, Christophe Leroy wrote: > > > Le 13/02/2019 à 16:27, Christophe Leroy a écrit : >> >> >> Le 13/02/2019 à 13:53, sgosavi1 a écrit : Why using 4.15.13 which is obsolete instead of using one of the Long Term Support versions which are still maintained, like 4.14

[PATCH v1 4/4] clk: qoriq: Add clockgen support for lx2160a

2019-02-26 Thread Vabhav Sharma
From: Yogesh Gaur Add clockgen support for lx2160a. Added entry for compat 'fsl,lx2160a-clockgen'. Signed-off-by: Tang Yuantian Signed-off-by: Yogesh Gaur Signed-off-by: Vabhav Sharma Acked-by: Stephen Boyd Acked-by: Viresh Kumar --- drivers/clk/clk-qoriq.c | 12

[PATCH v1 3/4] clk: qoriq: increase array size of cmux_to_group

2019-02-26 Thread Vabhav Sharma
From: Yogesh Gaur Increase size of cmux_to_group array, to accomdate entry of -1 termination. Added -1, terminated, entry for 4080_cmux_grpX. Signed-off-by: Yogesh Gaur Signed-off-by: Vabhav Sharma Acked-by: Stephen Boyd --- drivers/clk/clk-qoriq.c | 4 ++-- 1 file changed, 2

[PATCH v1 2/4] soc/fsl/guts: Add definition for LX2160A

2019-02-26 Thread Vabhav Sharma
Adding compatible string "lx2160a-dcfg" to initialize guts driver for lx2160 and SoC die attribute definition for LX2160A Signed-off-by: Vabhav Sharma Signed-off-by: Yinbo Zhu Acked-by: Li Yang --- drivers/soc/fsl/guts.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[PATCH v1 1/4] dt-bindings: arm64: add compatible for LX2160A

2019-02-26 Thread Vabhav Sharma
Add compatible for LX2160A SoC,QDS and RDB board Add lx2160a compatible for clockgen and dcfg Signed-off-by: Vabhav Sharma Reviewed-by: Rob Herring --- .../bindings/arm/freescale/fsl,layerscape-dcfg.txt | 2 +- Documentation/devicetree/bindings/arm/fsl.txt| 12

[PATCH v1 0/4] arm64: dts: NXP: add basic dts file for LX2160A SoC

2019-02-26 Thread Vabhav Sharma
These patches were reviewed and acked but dropped during merge window. Patchwork link was https://lore.kernel.org/patchwork/cover/1004155/ Changes for v1: - Updated lx2160a clockgen in alphabetical order Vabhav Sharma (2): dt-bindings: arm64: add compatible for LX2160A soc/fsl/guts: Add

RE: [PATCH 4/4] clk: qoriq: Add clockgen support for lx2160a

2019-02-26 Thread Vabhav Sharma
> -Original Message- > From: Scott Wood > Sent: Tuesday, February 26, 2019 3:15 PM > To: Vabhav Sharma ; sudeep.ho...@arm.com; > linux-ker...@vger.kernel.org; devicet...@vger.kernel.org; > robh...@kernel.org; mark.rutl...@arm.com; linuxppc-dev@lists.ozlabs.org; >

Re: build failure of current mmotm with skiroot_defconfig

2019-02-26 Thread Mike Rapoport
On Tue, Feb 26, 2019 at 10:39:54AM +0100, Christophe Leroy wrote: > > > Le 26/02/2019 à 09:12, Mike Rapoport a écrit : > >Hi, > > > >I've encountered the following error when building skyroot_defconfig with > >current mmotm tree: > > > >make CONFIG_OF_ALL_DTBS=y CONFIG_DTC=y >

Re: [PATCH 4/4] clk: qoriq: Add clockgen support for lx2160a

2019-02-26 Thread Scott Wood
On Tue, 2019-02-26 at 08:34 +, Vabhav Sharma wrote: > @@ -1435,6 +1446,7 @@ CLK_OF_DECLARE(qoriq_clockgen_t1023, "fsl,t1023- > clockgen", clockgen_init); > CLK_OF_DECLARE(qoriq_clockgen_t1040, "fsl,t1040-clockgen", clockgen_init); > CLK_OF_DECLARE(qoriq_clockgen_t2080, "fsl,t2080-clockgen",

Re: build failure of current mmotm with skiroot_defconfig

2019-02-26 Thread Christophe Leroy
Le 26/02/2019 à 09:12, Mike Rapoport a écrit : Hi, I've encountered the following error when building skyroot_defconfig with current mmotm tree: make CONFIG_OF_ALL_DTBS=y CONFIG_DTC=y CROSS_COMPILE=/opt/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- ARCH=powerpc vmlinux ...

[PATCH] powerpc/powernv: move OPAL call wrapper tracing and interrupt handling to C

2019-02-26 Thread Nicholas Piggin
The OPAL call wrapper gets interrupt disabling wrong. It disables interrupts just by clearing MSR[EE], which has two problems: - It doesn't call into the IRQ tracing subsystem, which means tracing across OPAL calls does not always notice IRQs have been disabled. - It doesn't go through the IRQ

[PATCH v4 4/4] powerpc/64s: Fix data interrupts vs d-side MCE reentrancy

2019-02-26 Thread Nicholas Piggin
Handlers for interrupts that set DAR / DSISR, set MSR[RI] before those SPRs are read. If a d-side machine check hits in this window, DAR / DSISR will be clobbered silently, leading to random corruption. Fix this by having handlers save those registers before setting MSR[RI]. Signed-off-by:

[PATCH v4 3/4] powerpc/64s: Prepare to handle data interrupts vs d-side MCE reentrancy

2019-02-26 Thread Nicholas Piggin
A subsequent fix for data interrupts (those that set DAR / DSISR) requires some interrupt macros to be open-coded, and also requires the 0x300 interrupt handler to be moved out-of-line. This patch does that without changing behaviour, which makes the later fix a smaller change. Signed-off-by:

[PATCH v4 2/4] powerpc/64s: system reset interrupt preserve HSRRs

2019-02-26 Thread Nicholas Piggin
Code that uses HSRR registers is not required to clear MSR[RI] by convention, however the system reset NMI itself may use HSRR registers (e.g., to call OPAL) and clobber them. Rather than introduce the requirement to clear RI in order to use HSRRs, have system reset interrupt save and restore

[PATCH v4 1/4] powerpc/64s: Fix HV NMI vs HV interrupt recoverability test

2019-02-26 Thread Nicholas Piggin
HV interrupts that use HSRR registers do not enter with MSR[RI] clear, but their entry code is not recoverable vs NMI, due to shared use of HSPRG1 as a scratch register to save r13. This means that a system reset or machine check that hits in HSRR interrupt entry can cause r13 to be silently

[PATCH v4 0/4] Fixes for 3 separate NMI reentrancy bugs

2019-02-26 Thread Nicholas Piggin
This series fixes several similar but unrelated bugs with NMIs clobbering live registers without noticing it, because MSR[RI] is set. Pretty rare bugs, but serious silent corruption consequences. For the most part these can be observed and tested quite easily with the mambo simulator, except that

[PATCH 2/4] soc/fsl/guts: Add definition for LX2160A

2019-02-26 Thread Vabhav Sharma
Adding compatible string "lx2160a-dcfg" to initialize guts driver for lx2160 and SoC die attribute definition for LX2160A Signed-off-by: Vabhav Sharma Signed-off-by: Yinbo Zhu Acked-by: Li Yang --- drivers/soc/fsl/guts.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[PATCH 1/4] dt-bindings: arm64: add compatible for LX2160A

2019-02-26 Thread Vabhav Sharma
Add compatible for LX2160A SoC,QDS and RDB board Add lx2160a compatible for clockgen and dcfg Signed-off-by: Vabhav Sharma Reviewed-by: Rob Herring --- .../bindings/arm/freescale/fsl,layerscape-dcfg.txt | 2 +- Documentation/devicetree/bindings/arm/fsl.txt| 12

[PATCH 4/4] clk: qoriq: Add clockgen support for lx2160a

2019-02-26 Thread Vabhav Sharma
From: Yogesh Gaur Add clockgen support for lx2160a. Added entry for compat 'fsl,lx2160a-clockgen'. Signed-off-by: Tang Yuantian Signed-off-by: Yogesh Gaur Signed-off-by: Vabhav Sharma Acked-by: Stephen Boyd Acked-by: Viresh Kumar --- drivers/clk/clk-qoriq.c | 12

[PATCH 3/4] clk: qoriq: increase array size of cmux_to_group

2019-02-26 Thread Vabhav Sharma
From: Yogesh Gaur Increase size of cmux_to_group array, to accomdate entry of -1 termination. Added -1, terminated, entry for 4080_cmux_grpX. Signed-off-by: Yogesh Gaur Signed-off-by: Vabhav Sharma Acked-by: Stephen Boyd --- drivers/clk/clk-qoriq.c | 4 ++-- 1 file changed, 2

[PATCH 0/4] arm64: dts: NXP: add basic dts file for LX2160A SoC

2019-02-26 Thread Vabhav Sharma
These patches were reviewed and acked but dropped during merge window. Patchwork link was https://lore.kernel.org/patchwork/cover/1004155/ Vabhav Sharma (2): dt-bindings: arm64: add compatible for LX2160A soc/fsl/guts: Add definition for LX2160A Yogesh Gaur (2): clk: qoriq: increase array

[PATCH 1/3] ASoC: wcd9335: fix a leaked reference by adding missing of_node_put

2019-02-26 Thread Wen Yang
The call to of_parse_phandle returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./sound/soc/codecs/wcd9335.c:5193:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount

[PATCH 3/3] ASoC: eukrea-tlv320: fix a leaked reference by adding missing of_node_put

2019-02-26 Thread Wen Yang
The call to of_parse_phandle returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./sound/soc/fsl/eukrea-tlv320.c:121:3-9: ERROR: missing of_node_put; acquired a node pointer with

[PATCH 2/3] ASoC: fsl_utils: fix a leaked reference by adding missing of_node_put

2019-02-26 Thread Wen Yang
The call to of_parse_phandle returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./sound/soc/fsl/fsl_utils.c:74:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount

Re: linux-next: build failure after merge of the akpm tree

2019-02-26 Thread Mike Rapoport
On Tue, Feb 26, 2019 at 06:39:15PM +1100, Stephen Rothwell wrote: > Hi Andrew, > > After merging the akpm tree, today's linux-next build (powerpc > allnoconfig) failed like this: > > /home/sfr/next/next/arch/powerpc/kernel/setup_32.c:176:21: error: > redefinition of 'alloc_stack' > static void

build failure of current mmotm with skiroot_defconfig

2019-02-26 Thread Mike Rapoport
Hi, I've encountered the following error when building skyroot_defconfig with current mmotm tree: make CONFIG_OF_ALL_DTBS=y CONFIG_DTC=y CROSS_COMPILE=/opt/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- ARCH=powerpc vmlinux ... CC arch/powerpc/kernel/dbell.o In file included