[PATCH] powerpc: vdso: Make vdso32 installation conditional in vdso_install

2019-03-21 Thread Ben Hutchings
The 32-bit vDSO is not needed and not normally built for 64-bit little-endian configurations. However, the vdso_install target still builds and installs it. Add the same config condition as is normally used for the build. Fixes: e0d005916994 ("powerpc/vdso: Disable building the 32-bit VDSO

[PATCH linux-next v8 5/7] powerpc: define syscall_get_error()

2019-03-21 Thread Dmitry V. Levin
syscall_get_error() is required to be implemented on this architecture in addition to already implemented syscall_get_nr(), syscall_get_arguments(), syscall_get_return_value(), and syscall_get_arch() functions in order to extend the generic ptrace API with PTRACE_GET_SYSCALL_INFO request. Cc:

[PATCH linux-next v8 0/7] ptrace: add PTRACE_GET_SYSCALL_INFO request

2019-03-21 Thread Dmitry V. Levin
PTRACE_GET_SYSCALL_INFO is a generic ptrace API that lets ptracer obtain details of the syscall the tracee is blocked in. There are two reasons for a special syscall-related ptrace request. Firstly, with the current ptrace API there are cases when ptracer cannot retrieve necessary information

Re: [PATCH kernel RFC 2/2] vfio-pci-nvlink2: Implement interconnect isolation

2019-03-21 Thread David Gibson
On Thu, Mar 21, 2019 at 12:19:34PM -0600, Alex Williamson wrote: > On Thu, 21 Mar 2019 10:56:00 +1100 > David Gibson wrote: > > > On Wed, Mar 20, 2019 at 01:09:08PM -0600, Alex Williamson wrote: > > > On Wed, 20 Mar 2019 15:38:24 +1100 > > > David Gibson wrote: > > > > > > > On Tue, Mar 19,

[PATCH 3/5] powerpc/powernv: fix possible object reference leak

2019-03-21 Thread Wen Yang
The call to of_find_node_by_path returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./arch/powerpc/platforms/powernv/opal.c:741:2-8: ERROR: missing of_node_put; acquired a node pointer

[PATCH 5/5] powerpc/8xx: fix possible object reference leak

2019-03-21 Thread Wen Yang
The call to of_find_compatible_node returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. irq_domain_add_linear also calls of_node_get to increase refcount, so irq_domain will not be affected when it is released. Detected by coccinelle with

[PATCH 4/5] powerpc/embedded6xx: fix possible object reference leak

2019-03-21 Thread Wen Yang
The call to of_find_compatible_node returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./arch/powerpc/platforms/embedded6xx/mvme5100.c:89:2-8: ERROR: missing of_node_put; acquired a

[PATCH 2/5] powerpc/83xx: fix possible object reference leak

2019-03-21 Thread Wen Yang
The call to of_find_node_by_name returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./arch/powerpc/platforms/83xx/km83xx.c:68:2-8: ERROR: missing of_node_put; acquired a node pointer

[PATCH 1/5] powerpc/sparse: fix possible object reference leak

2019-03-21 Thread Wen Yang
The call to of_find_node_by_path returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./arch/powerpc/platforms/pseries/pseries_energy.c:101:1-7: ERROR: missing of_node_put; acquired a

Re: [PATCH] arch/powerpc/crypto/crc-vpmsum_test: Use cheaper random numbers for self-test

2019-03-21 Thread Daniel Axtens
Hi George, > This code was filling a 64K buffer from /dev/urandom in order to > compute a CRC over (on average half of) it by two different methods, > comparing the CRCs, and repeating. > > This is not a remotely security-critical application, so use the far > faster and cheaper prandom_u32()

Re: [PATCH v5 05/10] powerpc: Add a framework for Kernel Userspace Access Protection

2019-03-21 Thread Michael Ellerman
Christophe Leroy writes: > Le 20/03/2019 à 13:57, Michael Ellerman a écrit : >> Christophe Leroy writes: >>> Le 08/03/2019 à 02:16, Michael Ellerman a écrit : From: Christophe Leroy This patch implements a framework for Kernel Userspace Access Protection. Then

Re: [PATCH] powerpc: vmlinux.lds: Drop Binutils 2.18 workarounds

2019-03-21 Thread Michael Ellerman
Segher Boessenkool writes: > On Thu, Mar 21, 2019 at 11:02:53AM +1030, Joel Stanley wrote: >> Segher added some workarounds for GCC 4.2 and bintuils 2.18. We now set >> 4.6 and 2.20 as the minimum, so they can be dropped. > > It was a bug in binutils _before_ 2.18, only seen by people using GCC

Re: [RFC PATCH] virtio_ring: Use DMA API if guest memory is encrypted

2019-03-21 Thread Thiago Jung Bauermann
Michael S. Tsirkin writes: > On Wed, Mar 20, 2019 at 01:13:41PM -0300, Thiago Jung Bauermann wrote: >> >> Another way of looking at this issue which also explains our reluctance >> >> is that the only difference between a secure guest and a regular guest >> >> (at least regarding virtio) is

Re: [PATCH] powerpc: vmlinux.lds: Drop Binutils 2.18 workarounds

2019-03-21 Thread Segher Boessenkool
On Thu, Mar 21, 2019 at 11:02:53AM +1030, Joel Stanley wrote: > Segher added some workarounds for GCC 4.2 and bintuils 2.18. We now set > 4.6 and 2.20 as the minimum, so they can be dropped. It was a bug in binutils _before_ 2.18, only seen by people using GCC _before_ 4.2. It's all ancient

Re: [PATCH 1/4] add generic builtin command line

2019-03-21 Thread Andrew Morton
On Thu, 21 Mar 2019 08:13:08 -0700 Daniel Walker wrote: > > The patches (or some version of them) are already in linux-next, > > which messes me up. I'll disable them for now. > > Those are from my tree, but I remove them when you picked up the series. The > next linux-next should not have

Re: powerpc32 boot crash in 5.1-rc1

2019-03-21 Thread LEROY Christophe
Meelis Roos a écrit : While 5.0.0 worked fine on my PowerMac G4, 5.0 + git (unknown rev as of Mar 13), 5.0.0-11520-gf261c4e and todays git all fail to boot. The problem seems to be in page fault handler in load_elf_binary() of init process. The patch at

powerpc32 boot crash in 5.1-rc1

2019-03-21 Thread Meelis Roos
While 5.0.0 worked fine on my PowerMac G4, 5.0 + git (unknown rev as of Mar 13), 5.0.0-11520-gf261c4e and todays git all fail to boot. The problem seems to be in page fault handler in load_elf_binary() of init process. Two different screenshots are at

[PATCH] arch/powerpc/crypto/crc-vpmsum_test: Use cheaper random numbers for self-test

2019-03-21 Thread George Spelvin
This code was filling a 64K buffer from /dev/urandom in order to compute a CRC over (on average half of) it by two different methods, comparing the CRCs, and repeating. This is not a remotely security-critical application, so use the far faster and cheaper prandom_u32() generator. And, while

Re: [PATCH kernel RFC 2/2] vfio-pci-nvlink2: Implement interconnect isolation

2019-03-21 Thread Alex Williamson
On Thu, 21 Mar 2019 10:56:00 +1100 David Gibson wrote: > On Wed, Mar 20, 2019 at 01:09:08PM -0600, Alex Williamson wrote: > > On Wed, 20 Mar 2019 15:38:24 +1100 > > David Gibson wrote: > > > > > On Tue, Mar 19, 2019 at 10:36:19AM -0600, Alex Williamson wrote: > > > > On Fri, 15 Mar 2019

Re: [PATCH] kmemleak: powerpc: skip scanning holes in the .bss section

2019-03-21 Thread Qian Cai
On Thu, 2019-03-21 at 17:19 +, Catalin Marinas wrote: > The commit 2d4f567103ff ("KVM: PPC: Introduce kvm_tmp framework") adds > kvm_tmp[] into the .bss section and then free the rest of unused spaces > back to the page allocator. > > kernel_init >   kvm_guest_init > kvm_free_tmp >   

[PATCH] kmemleak: powerpc: skip scanning holes in the .bss section

2019-03-21 Thread Catalin Marinas
The commit 2d4f567103ff ("KVM: PPC: Introduce kvm_tmp framework") adds kvm_tmp[] into the .bss section and then free the rest of unused spaces back to the page allocator. kernel_init kvm_guest_init kvm_free_tmp free_reserved_area free_unref_page

Re: [RESEND PATCH 0/7] Add FOLL_LONGTERM to GUP fast and use it

2019-03-21 Thread Ira Weiny
On Tue, Mar 19, 2019 at 03:19:30PM -0700, Andrew Morton wrote: > On Sun, 17 Mar 2019 11:34:31 -0700 ira.we...@intel.com wrote: > > > Resending after rebasing to the latest mm tree. > > > > HFI1, qib, and mthca, use get_user_pages_fast() due to it performance > > advantages. These pages can be

Re: [PATCH 1/4] add generic builtin command line

2019-03-21 Thread Daniel Walker
On Wed, Mar 20, 2019 at 08:14:33PM -0700, Andrew Morton wrote: > On Wed, 20 Mar 2019 16:23:28 -0700 Daniel Walker wrote: > > > On Wed, Mar 20, 2019 at 03:53:19PM -0700, Andrew Morton wrote: > > > On Tue, 19 Mar 2019 16:24:45 -0700 Daniel Walker > > > wrote: > > > > > > > This code allows

[PATCH -next] crypto: vmx - Make p8_init and p8_exit static

2019-03-21 Thread Yue Haibing
From: YueHaibing Fix sparse warnings: drivers/crypto/vmx/vmx.c:44:12: warning: symbol 'p8_init' was not declared. Should it be static? drivers/crypto/vmx/vmx.c:70:13: warning: symbol 'p8_exit' was not declared. Should it be static? Signed-off-by: YueHaibing --- drivers/crypto/vmx/vmx.c | 4

Applied "ASoC: fsl_asrc: add constraint for the asrc of older version" to the asoc tree

2019-03-21 Thread Mark Brown
The patch ASoC: fsl_asrc: add constraint for the asrc of older version has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24

Applied "ASoC: fsl_esai: fix channel swap issue when stream starts" to the asoc tree

2019-03-21 Thread Mark Brown
The patch ASoC: fsl_esai: fix channel swap issue when stream starts has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24

Re: [RFC PATCH 1/1] KVM: PPC: Report single stepping capability

2019-03-21 Thread Fabiano Rosas
Alexey Kardashevskiy writes: > In the cover letter (which is not really required for a single patch) > you say the capability will be present for BookE and PR KVM (which > Book3s) but here it is BookE only, is that intentional? A few lines below (falling through) we have: /* We support

[PATCH v5 04/19] powerpc: mm: Add p?d_large() definitions

2019-03-21 Thread Steven Price
walk_page_range() is going to be allowed to walk page tables other than those of user space. For this it needs to know when it has reached a 'leaf' entry in the page tables. This information is provided by the p?d_large() functions/macros. For powerpc pmd_large() was already implemented, so hoist

Re: [alsa-devel] [PATCH V4] ASoC: fsl_esai: fix channel swap issue when stream starts

2019-03-21 Thread Mark Brown
On Tue, Mar 19, 2019 at 02:08:20AM +, S.j. Wang wrote: > Hi Mark > > Can this patch be accepted? Or need I do any update? Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is

[RFC PATCH 7/8] vfs: Convert spufs to fs_context

2019-03-21 Thread David Howells
Signed-off-by: David Howells cc: Jeremy Kerr cc: Arnd Bergmann cc: linuxppc-dev@lists.ozlabs.org --- arch/powerpc/platforms/cell/spufs/inode.c | 207 - 1 file changed, 116 insertions(+), 91 deletions(-) diff --git a/arch/powerpc/platforms/cell/spufs/inode.c

[RFC PATCH 0/8] Convert mount_single-using filesystems to fs_context

2019-03-21 Thread David Howells
Hi Al, Here's a set of patches that converts the mount_single()-using filesystems to use the new fs_context struct. There may be prerequisite commits in the branch detailed below. (1) Add a new keying to vfs_get_super() that indicates that ->reconfigure() should be called instead of

Re: [PATCH v1 00/27] Reduce ifdef mess in hugetlbpage.c and slice.c

2019-03-21 Thread Christophe Leroy
This series went through a successfull build test on kisskb: http://kisskb.ellerman.id.au/kisskb/branch/chleroy/head/f9dc3b2203af4356e9eac2d901126a0dfc5b51f6/ Christophe Le 20/03/2019 à 11:06, Christophe Leroy a écrit : The main purpose of this series is to reduce the amount of #ifdefs in

Re: [PATCH v1 11/27] powerpc/mm: split asm/hugetlb.h into dedicated subarch files

2019-03-21 Thread Christophe Leroy
snowpatch fails applying this. I usually base my patches on branch merge. Shouldn't snowpatch use merge branch as well instead of next branch ? Christophe Le 20/03/2019 à 11:06, Christophe Leroy a écrit : Three subarches support hugepages: - fsl book3e - book3s/64 - 8xx This patch splits

Re: [PATCH v5 05/10] powerpc: Add a framework for Kernel Userspace Access Protection

2019-03-21 Thread Christophe Leroy
Le 20/03/2019 à 14:04, Christophe Leroy a écrit : Le 20/03/2019 à 13:57, Michael Ellerman a écrit : Christophe Leroy writes: Le 08/03/2019 à 02:16, Michael Ellerman a écrit : From: Christophe Leroy This patch implements a framework for Kernel Userspace Access Protection. Then

Re: [PATCH] powerpc/highmem: change BUG_ON() to WARN_ON()

2019-03-21 Thread Christophe Leroy
Le 21/03/2019 à 11:07, Michael Ellerman a écrit : Christophe Leroy writes: Le 21/03/2019 à 06:29, Michael Ellerman a écrit : Christophe Leroy writes: In arch/powerpc/mm/highmem.c, BUG_ON() is called only when CONFIG_DEBUG_HIGHMEM is selected, this means the BUG_ON() is not vital and can

Re: [PATCH] powerpc/highmem: change BUG_ON() to WARN_ON()

2019-03-21 Thread Michael Ellerman
Christophe Leroy writes: > Le 21/03/2019 à 06:29, Michael Ellerman a écrit : >> Christophe Leroy writes: >>> In arch/powerpc/mm/highmem.c, BUG_ON() is called only when >>> CONFIG_DEBUG_HIGHMEM is selected, this means the BUG_ON() is >>> not vital and can be replaced by a a WARN_ON >>> >>> At

Re: [PATCH] powerpc/security: Fix spectre_v2 reporting

2019-03-21 Thread Diana Madalina Craciun
Reviewed-by: Diana Craciun On 3/21/2019 6:24 AM, Michael Ellerman wrote: > When I updated the spectre_v2 reporting to handle software count cache > flush I got the logic wrong when there's no software count cache > enabled at all. > > The result is that on systems with the software count cache

Re: [PATCH v4 06/17] KVM: PPC: Book3S HV: XIVE: add controls for the EQ configuration

2019-03-21 Thread Cédric Le Goater
On 3/21/19 12:09 AM, David Gibson wrote: > On Wed, Mar 20, 2019 at 09:37:40AM +0100, Cédric Le Goater wrote: >> These controls will be used by the H_INT_SET_QUEUE_CONFIG and >> H_INT_GET_QUEUE_CONFIG hcalls from QEMU to configure the underlying >> Event Queue in the XIVE IC. They will also be used

Re: [PATCH] compiler: allow all arches to enable CONFIG_OPTIMIZE_INLINING

2019-03-21 Thread Heiko Carstens
On Wed, Mar 20, 2019 at 03:20:27PM +0900, Masahiro Yamada wrote: > Commit 60a3cdd06394 ("x86: add optimized inlining") introduced > CONFIG_OPTIMIZE_INLINING, but it has been available only for x86. > > The idea is obviously arch-agnostic although we need some code fixups. > This commit moves the

Re: [PATCH] powerpc/security: Fix spectre_v2 reporting

2019-03-21 Thread Michael Neuling
On Thu, 2019-03-21 at 15:24 +1100, Michael Ellerman wrote: > When I updated the spectre_v2 reporting to handle software count cache > flush I got the logic wrong when there's no software count cache > enabled at all. > > The result is that on systems with the software count cache flush > disabled

Re: [PATCH] powerpc/highmem: change BUG_ON() to WARN_ON()

2019-03-21 Thread Christophe Leroy
Le 21/03/2019 à 06:29, Michael Ellerman a écrit : Christophe Leroy writes: In arch/powerpc/mm/highmem.c, BUG_ON() is called only when CONFIG_DEBUG_HIGHMEM is selected, this means the BUG_ON() is not vital and can be replaced by a a WARN_ON At the sametime, use IS_ENABLED() instead of