Re: [Qemu-ppc] pseries on qemu-system-ppc64le crashes in doorbell_core_ipi()

2019-04-05 Thread Frederic Weisbecker
On Mon, Apr 01, 2019 at 10:38:27AM +0200, Peter Zijlstra wrote: > > + fweisbec, who did the remote bits > > On Sat, Mar 30, 2019 at 01:10:28PM +1000, Nicholas Piggin wrote: > > diff --git a/kernel/irq_work.c b/kernel/irq_work.c > > index 6b7cdf17ccf8..f0e539d0f879 100644 > > ---

Re: [PATCH 1/2] pci: rpadlpar: fix leaked device_node references in add/remove paths

2019-04-05 Thread Bjorn Helgaas
On Fri, Mar 22, 2019 at 01:27:21PM -0500, Tyrel Datwyler wrote: > The find_dlpar_node() helper returns a device node with its reference > incremented. Both the add and remove paths use this helper for find the > appropriate node, but fail to release the reference when done. > > Annotate the

Re: [PATCH 2/3] ASoC: fsl_utils: fix a leaked reference by adding missing of_node_put

2019-04-05 Thread Markus Elfring
> @@ -71,6 +71,7 @@ int fsl_asoc_get_dma_channel(struct device_node *ssi_np, > iprop = of_get_property(dma_np, "cell-index", NULL); > if (!iprop) { > of_node_put(dma_np); > + of_node_put(dma_channel_np); > return -EINVAL; > } >

Re: [PATCH 0/4] Enabling secure boot on PowerNV systems

2019-04-05 Thread Claudio Carvalho
On 4/3/19 7:27 PM, Matthew Garrett wrote: > On Tue, Apr 2, 2019 at 4:31 PM Claudio Carvalho > wrote: >> >> On 4/2/19 6:51 PM, Matthew Garrett wrote: >>> So you implement the full PK/KEK/db/dbx/dbt infrastructure, and >>> updates are signed in the same way? >> For the first version, our

Re: [PATCH RFC 1/5] cpu/speculation: Add 'cpu_spec_mitigations=' cmdline options

2019-04-05 Thread Josh Poimboeuf
On Fri, Apr 05, 2019 at 06:01:36PM +0200, Borislav Petkov wrote: > Thinking about this more, we can shave off the first 4 chars and have it > be: > > spec_mitigations= > > I think it is painfully clear which speculation mitigations we mean. And > the other switches don't have "cpu_" prefixes too

Re: [PATCH RFC 2/5] x86/speculation: Add support for 'cpu_spec_mitigations=' cmdline options

2019-04-05 Thread Josh Poimboeuf
On Fri, Apr 05, 2019 at 05:26:50PM +0200, Borislav Petkov wrote: > On Fri, Apr 05, 2019 at 09:31:01AM -0500, Josh Poimboeuf wrote: > > My thinking was that the individual options could be used to override > > the global option. But maybe that's overkill? I dunno. > > You mean if the user

Re: [PATCH RFC 5/5] arm64/speculation: Add support for 'cpu_spec_mitigations=' cmdline options

2019-04-05 Thread Josh Poimboeuf
On Fri, Apr 05, 2019 at 03:44:14PM +0100, Will Deacon wrote: > Hi Josh, > > On Thu, Apr 04, 2019 at 11:44:15AM -0500, Josh Poimboeuf wrote: > > Configure arm64 runtime CPU speculation bug mitigations in accordance > > with the 'cpu_spec_mitigations=' cmdline options. This affects > > Meltdown

Re: [PATCH RFC 1/5] cpu/speculation: Add 'cpu_spec_mitigations=' cmdline options

2019-04-05 Thread Borislav Petkov
Thinking about this more, we can shave off the first 4 chars and have it be: spec_mitigations= I think it is painfully clear which speculation mitigations we mean. And the other switches don't have "cpu_" prefixes too so... -- Regards/Gruss, Boris. Good mailing practices for 400: avoid

Re: [PATCH RFC 2/5] x86/speculation: Add support for 'cpu_spec_mitigations=' cmdline options

2019-04-05 Thread Josh Poimboeuf
On Fri, Apr 05, 2019 at 08:18:09AM -0700, Randy Dunlap wrote: > On 4/5/19 6:57 AM, Borislav Petkov wrote: > > On Thu, Apr 04, 2019 at 11:44:12AM -0500, Josh Poimboeuf wrote: > >> Configure x86 runtime CPU speculation bug mitigations in accordance with > >> the 'cpu_spec_mitigations=' cmdline

Re: [PATCH RFC 2/5] x86/speculation: Add support for 'cpu_spec_mitigations=' cmdline options

2019-04-05 Thread Borislav Petkov
On Fri, Apr 05, 2019 at 09:31:01AM -0500, Josh Poimboeuf wrote: > My thinking was that the individual options could be used to override > the global option. But maybe that's overkill? I dunno. You mean if the user deliberately types: "cpu_spec_mitigations=off spectre_v2=auto" on the cmdline

Re: [PATCH RFC 1/5] cpu/speculation: Add 'cpu_spec_mitigations=' cmdline options

2019-04-05 Thread Borislav Petkov
On Fri, Apr 05, 2019 at 09:20:48AM -0500, Josh Poimboeuf wrote: > In your scenario, the fact that it's so easy to remember would save the > day, since you wouldn't have to go look up some obscure shortened option > name in the documentation :-) No no, the idea is for the short option to be

Re: [PATCH RFC 2/5] x86/speculation: Add support for 'cpu_spec_mitigations=' cmdline options

2019-04-05 Thread Randy Dunlap
On 4/5/19 6:57 AM, Borislav Petkov wrote: > On Thu, Apr 04, 2019 at 11:44:12AM -0500, Josh Poimboeuf wrote: >> Configure x86 runtime CPU speculation bug mitigations in accordance with >> the 'cpu_spec_mitigations=' cmdline options. This affects Meltdown, >> Spectre v2, Speculative Store Bypass,

Re: [Qemu-ppc] pseries on qemu-system-ppc64le crashes in doorbell_core_ipi()

2019-04-05 Thread Sebastian Andrzej Siewior
On 2019-04-05 02:25:44 [+1000], Nicholas Piggin wrote: > Sebastian, are you able to test if this patch solves your problem? yes, it does. Tested-by: Sebastian Andrzej Siewior > Thanks, > Nick Sebastian

Re: [PATCH RFC 5/5] arm64/speculation: Add support for 'cpu_spec_mitigations=' cmdline options

2019-04-05 Thread Will Deacon
Hi Josh, On Thu, Apr 04, 2019 at 11:44:15AM -0500, Josh Poimboeuf wrote: > Configure arm64 runtime CPU speculation bug mitigations in accordance > with the 'cpu_spec_mitigations=' cmdline options. This affects > Meltdown and Speculative Store Bypass. > > The default behavior is unchanged. > >

Re: [PATCH RFC 5/5] arm64/speculation: Add support for 'cpu_spec_mitigations=' cmdline options

2019-04-05 Thread Josh Poimboeuf
On Fri, Apr 05, 2019 at 03:39:58PM +0100, Steven Price wrote: > On 04/04/2019 17:44, Josh Poimboeuf wrote: > > Configure arm64 runtime CPU speculation bug mitigations in accordance > > with the 'cpu_spec_mitigations=' cmdline options. This affects > > Meltdown and Speculative Store Bypass. > > >

[PATCH v2 1/2] bus: mc-bus: Add support for mapping shareable portals

2019-04-05 Thread Roy Pledge
Starting with v5 of NXP QBMan devices the hardware supports using regular cacheable/shareable memory as the backing store for the portals. This patch adds support for the new portal mode by switching to use the DPRC get object region v2 command which returns both a base address and offset for the

[PATCH v2 2/2] soc: fsl: dpio: Add support for memory backed QBMan portals

2019-04-05 Thread Roy Pledge
NXP devices with QBMan version 5 and above can enable software portals that are memory backed. This allows the portal to be mapped as cacheable/sharable (same as all normal memory) so that portals can freely migrate between cores and clusters in the SoC. The driver will enable this mode by default

[PATCH v2 0/2] soc: fsl: dpio: Add support for memory backed QBMan portals

2019-04-05 Thread Roy Pledge
This patch series adds support for QBMan memory backed portals which is avaialble in devices containing QBMan verion 5.0 and above (for example NXP's LX2160A SoC). Memory backed portals can be mapped as normal cacheable/shareable memory which allows the portals to migrate between cores without

Re: [PATCH RFC 5/5] arm64/speculation: Add support for 'cpu_spec_mitigations=' cmdline options

2019-04-05 Thread Steven Price
On 04/04/2019 17:44, Josh Poimboeuf wrote: > Configure arm64 runtime CPU speculation bug mitigations in accordance > with the 'cpu_spec_mitigations=' cmdline options. This affects > Meltdown and Speculative Store Bypass. > > The default behavior is unchanged. > > Signed-off-by: Josh Poimboeuf

Re: [PATCH RFC 2/5] x86/speculation: Add support for 'cpu_spec_mitigations=' cmdline options

2019-04-05 Thread Josh Poimboeuf
On Fri, Apr 05, 2019 at 03:57:12PM +0200, Borislav Petkov wrote: > > diff --git a/arch/x86/include/asm/processor.h > > b/arch/x86/include/asm/processor.h > > index 2bb3a648fc12..7e95b310f869 100644 > > --- a/arch/x86/include/asm/processor.h > > +++ b/arch/x86/include/asm/processor.h > > @@ -982,6

Re: [PATCH RFC 1/5] cpu/speculation: Add 'cpu_spec_mitigations=' cmdline options

2019-04-05 Thread Josh Poimboeuf
On Fri, Apr 05, 2019 at 03:12:11PM +0200, Borislav Petkov wrote: > On Thu, Apr 04, 2019 at 11:44:11AM -0500, Josh Poimboeuf wrote: > > Keeping track of the number of mitigations for all the CPU speculation > > bugs has become overwhelming for many users. It's getting more and more > > complicated

Re: [PATCH RFC 2/5] x86/speculation: Add support for 'cpu_spec_mitigations=' cmdline options

2019-04-05 Thread Borislav Petkov
On Thu, Apr 04, 2019 at 11:44:12AM -0500, Josh Poimboeuf wrote: > Configure x86 runtime CPU speculation bug mitigations in accordance with > the 'cpu_spec_mitigations=' cmdline options. This affects Meltdown, > Spectre v2, Speculative Store Bypass, and L1TF. > > The default behavior is

Re: [PATCH 02/20] ASoC: efika-audio-fabric.c: Switch to SPDX identifier

2019-04-05 Thread Fabio Estevam
On Fri, Apr 5, 2019 at 10:24 AM Mukesh Ojha wrote: > you mean all lines to start with //, does not it look to noisy to eyes ? Mark Brown's recommendation is to use // in all the initial block lines instead of only in the SPDX one.

Re: [PATCH 02/20] ASoC: efika-audio-fabric.c: Switch to SPDX identifier

2019-04-05 Thread Mukesh Ojha
On 4/5/2019 6:20 PM, Fabio Estevam wrote: On Fri, Apr 5, 2019 at 9:47 AM Mukesh Ojha wrote: Don't change entire thing with //. only above line with the license is enough. Please apply this rule every patch of yours. Not really. This is the style preferred in this subsystem. you mean

Re: [PATCH RFC 1/5] cpu/speculation: Add 'cpu_spec_mitigations=' cmdline options

2019-04-05 Thread Borislav Petkov
On Thu, Apr 04, 2019 at 11:44:11AM -0500, Josh Poimboeuf wrote: > Keeping track of the number of mitigations for all the CPU speculation > bugs has become overwhelming for many users. It's getting more and more > complicated to decide which mitigations are needed for a given > architecture.

Re: [PATCH 02/20] ASoC: efika-audio-fabric.c: Switch to SPDX identifier

2019-04-05 Thread Fabio Estevam
On Fri, Apr 5, 2019 at 9:47 AM Mukesh Ojha wrote: > Don't change entire thing with //. only above line with the license is > enough. > > Please apply this rule every patch of yours. Not really. This is the style preferred in this subsystem.

Re: [PATCH 02/20] ASoC: efika-audio-fabric.c: Switch to SPDX identifier

2019-04-05 Thread Mukesh Ojha
On 4/5/2019 5:19 PM, Andra Danciu wrote: Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Andra Danciu --- sound/soc/fsl/efika-audio-fabric.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git

Re: [PATCH 01/20] ASoC: imx-pcm: Switch to SPDX identifier

2019-04-05 Thread Mukesh Ojha
On 4/5/2019 5:19 PM, Andra Danciu wrote: Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Andra Danciu Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- sound/soc/fsl/imx-pcm.h | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff

Re: [PATCH 01/20] ASoC: imx-pcm: Switch to SPDX identifier

2019-04-05 Thread Mukesh Ojha
On 4/5/2019 5:19 PM, Andra Danciu wrote: Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Andra Danciu Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- sound/soc/fsl/imx-pcm.h | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff

[PATCH 20/20] ASoC: wm1133-ev1: Switch to SPDX identifier

2019-04-05 Thread Andra Danciu
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Andra Danciu --- sound/soc/fsl/wm1133-ev1.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/sound/soc/fsl/wm1133-ev1.c b/sound/soc/fsl/wm1133-ev1.c index

[PATCH 19/20] ASoC: phycore-ac97: Switch to SPDX identifier

2019-04-05 Thread Andra Danciu
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Andra Danciu --- sound/soc/fsl/phycore-ac97.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/sound/soc/fsl/phycore-ac97.c b/sound/soc/fsl/phycore-ac97.c index

[PATCH 18/20] ASoC: pcm030-audio-fabric: Switch to SPDX identifier

2019-04-05 Thread Andra Danciu
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Andra Danciu --- sound/soc/fsl/pcm030-audio-fabric.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/sound/soc/fsl/pcm030-audio-fabric.c

[PATCH 17/20] ASoC: p1022_rdk: Switch to SPDX identifier

2019-04-05 Thread Andra Danciu
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Andra Danciu --- sound/soc/fsl/p1022_rdk.c | 32 ++-- 1 file changed, 14 insertions(+), 18 deletions(-) diff --git a/sound/soc/fsl/p1022_rdk.c b/sound/soc/fsl/p1022_rdk.c

[PATCH 16/20] ASoC: p1022_ds: Switch to SPDX identifier

2019-04-05 Thread Andra Danciu
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Andra Danciu --- sound/soc/fsl/p1022_ds.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/sound/soc/fsl/p1022_ds.c b/sound/soc/fsl/p1022_ds.c index

[PATCH 15/20] ASoC: mx27vis-aic32x4: Switch to SPDX identifier

2019-04-05 Thread Andra Danciu
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Andra Danciu --- sound/soc/fsl/mx27vis-aic32x4.c | 29 +++-- 1 file changed, 7 insertions(+), 22 deletions(-) diff --git a/sound/soc/fsl/mx27vis-aic32x4.c

[PATCH 14/20] ASoC: mpc8610_hpcd: Switch to SPDX identifier

2019-04-05 Thread Andra Danciu
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Andra Danciu --- sound/soc/fsl/mpc8610_hpcd.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/sound/soc/fsl/mpc8610_hpcd.c b/sound/soc/fsl/mpc8610_hpcd.c index

[PATCH 13/20] ASoC: mpc5200_psc_i2s: Switch to SPDX identifier

2019-04-05 Thread Andra Danciu
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Andra Danciu --- sound/soc/fsl/mpc5200_psc_i2s.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/sound/soc/fsl/mpc5200_psc_i2s.c b/sound/soc/fsl/mpc5200_psc_i2s.c

[PATCH 12/20] ASoC: mpc5200_psc_ac97: Switch to SPDX identifier

2019-04-05 Thread Andra Danciu
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Andra Danciu --- sound/soc/fsl/mpc5200_psc_ac97.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/sound/soc/fsl/mpc5200_psc_ac97.c

[PATCH 11/20] ASoC: mpc5200_dma: Switch to SPDX identifier

2019-04-05 Thread Andra Danciu
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Andra Danciu --- sound/soc/fsl/mpc5200_dma.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/sound/soc/fsl/mpc5200_dma.c b/sound/soc/fsl/mpc5200_dma.c index

[PATCH 10/20] ASoC: imx-ssi: Switch to SPDX identifier

2019-04-05 Thread Andra Danciu
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Andra Danciu --- sound/soc/fsl/imx-ssi.c | 57 ++--- sound/soc/fsl/imx-ssi.h | 6 +- 2 files changed, 26 insertions(+), 37 deletions(-) diff --git

[PATCH 09/20] ASoC: imx-spdif: Switch to SPDX identifier

2019-04-05 Thread Andra Danciu
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Andra Danciu --- sound/soc/fsl/imx-spdif.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/sound/soc/fsl/imx-spdif.c b/sound/soc/fsl/imx-spdif.c index

[PATCH 08/20] ASoC: imx-pcm-fiq: Switch to SPDX identifier

2019-04-05 Thread Andra Danciu
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Andra Danciu --- sound/soc/fsl/imx-pcm-fiq.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/sound/soc/fsl/imx-pcm-fiq.c b/sound/soc/fsl/imx-pcm-fiq.c index

[PATCH 07/20] ASoC: imx-mc13783: Switch to SPDX identifier

2019-04-05 Thread Andra Danciu
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Andra Danciu --- sound/soc/fsl/imx-mc13783.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/sound/soc/fsl/imx-mc13783.c b/sound/soc/fsl/imx-mc13783.c

[PATCH 06/20] ASoC: imx-es8328: Switch to SPDX identifier

2019-04-05 Thread Andra Danciu
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Andra Danciu --- sound/soc/fsl/imx-es8328.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/sound/soc/fsl/imx-es8328.c b/sound/soc/fsl/imx-es8328.c index

[PATCH 05/20] ASoC: imx-audmux: Switch to SPDX identifier

2019-04-05 Thread Andra Danciu
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Andra Danciu --- sound/soc/fsl/imx-audmux.c | 26 -- 1 file changed, 8 insertions(+), 18 deletions(-) diff --git a/sound/soc/fsl/imx-audmux.c b/sound/soc/fsl/imx-audmux.c

[PATCH 04/20] ASoC: fsl-dma: Switch to SPDX identifier

2019-04-05 Thread Andra Danciu
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Andra Danciu --- sound/soc/fsl/fsl_dma.c | 26 +++--- sound/soc/fsl/fsl_dma.h | 5 + 2 files changed, 12 insertions(+), 19 deletions(-) diff --git a/sound/soc/fsl/fsl_dma.c

[PATCH 03/20] ASoC: eukrea-tlv320: Switch to SPDX identifier

2019-04-05 Thread Andra Danciu
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Andra Danciu --- sound/soc/fsl/eukrea-tlv320.c | 26 ++ 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/sound/soc/fsl/eukrea-tlv320.c

[PATCH 02/20] ASoC: efika-audio-fabric.c: Switch to SPDX identifier

2019-04-05 Thread Andra Danciu
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Andra Danciu --- sound/soc/fsl/efika-audio-fabric.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/sound/soc/fsl/efika-audio-fabric.c

[PATCH 00/20] Switch to SPDX identifier

2019-04-05 Thread Andra Danciu
This patch set switches to SPDX identifier inside the fsl directory. Andra Danciu (20): ASoC: imx-pcm: Switch to SPDX identifier ASoC: efika-audio-fabric.c: Switch to SPDX identifier ASoC: eukrea-tlv320: Switch to SPDX identifier ASoC: fsl-dma: Switch to SPDX identifier ASoC:

[PATCH 01/20] ASoC: imx-pcm: Switch to SPDX identifier

2019-04-05 Thread Andra Danciu
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Andra Danciu --- sound/soc/fsl/imx-pcm.h | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/fsl/imx-pcm.h b/sound/soc/fsl/imx-pcm.h index 133c4470acad..5dd406774d3e

[PATCH v2 2/2] cpuidle : Add auto-promotion flag to cpuidle flags

2019-04-05 Thread Abhishek Goel
This patch sets up flags for the state which needs to be auto-promoted. On POWERNV system, only lite states need to be autopromoted. We identify lite states by those which do not lose user context. That information has been used to set the flag for lite states. Signed-off-by: Abhishek Goel ---

[PATCH v2 1/2] cpuidle : auto-promotion for cpuidle states

2019-04-05 Thread Abhishek Goel
Currently, the cpuidle governors (menu /ladder) determine what idle state an idling CPU should enter into based on heuristics that depend on the idle history on that CPU. Given that no predictive heuristic is perfect, there are cases where the governor predicts a shallow idle state, hoping that

[PATCH v2 0/2] Auto-promotion logic for cpuidle states

2019-04-05 Thread Abhishek Goel
Currently, the cpuidle governors (menu/ladder) determine what idle state a idling CPU should enter into based on heuristics that depend on the idle history on that CPU. Given that no predictive heuristic is perfect, there are cases where the governor predicts a shallow idle state, hoping that the

Re: [1/5] powerpc/sparse: fix possible object reference leak

2019-04-05 Thread Markus Elfring
> @@ -131,7 +131,7 @@ static int drc_index_to_cpu(u32 drc_index) > > of_read_drc_info_cell(, , ); > if (strncmp(drc.drc_type, "CPU", 3)) > - goto err; > + goto err_of_node_put; > >

Re: [PATCH v4 4/4] ocxl: Remove some unused exported symbols

2019-04-05 Thread Andrew Donnellan
On 25/3/19 4:34 pm, Alastair D'Silva wrote: From: Alastair D'Silva Remove some unused exported symbols. Signed-off-by: Alastair D'Silva Acked-by: Andrew Donnellan --- drivers/misc/ocxl/config.c| 4 +--- drivers/misc/ocxl/ocxl_internal.h | 23 +++

Re: [PATCH v4 3/4] ocxl: Remove superfluous 'extern' from headers

2019-04-05 Thread Andrew Donnellan
On 25/3/19 4:34 pm, Alastair D'Silva wrote: From: Alastair D'Silva The 'extern' keyword adds no value here. Signed-off-by: Alastair D'Silva --- Acked-by: Andrew Donnellan drivers/misc/ocxl/ocxl_internal.h | 54 +++ include/misc/ocxl.h | 36

Re: [PATCH v4 2/4] ocxl: read_pasid never returns an error, so make it void

2019-04-05 Thread Andrew Donnellan
On 25/3/19 4:34 pm, Alastair D'Silva wrote: From: Alastair D'Silva No need for a return value in read_pasid as it only returns 0. Signed-off-by: Alastair D'Silva Reviewed-by: Greg Kurz Acked-by: Andrew Donnellan --- drivers/misc/ocxl/config.c | 9 ++--- 1 file changed, 2

Re: [PATCH v4 1/4] ocxl: Rename struct link to ocxl_link

2019-04-05 Thread Andrew Donnellan
On 25/3/19 4:34 pm, Alastair D'Silva wrote: From: Alastair D'Silva The term 'link' is ambiguous (especially when the struct is used for a list), so rename it for clarity. Signed-off-by: Alastair D'Silva Reviewed-by: Greg Kurz Acked-by: Andrew Donnellan --- drivers/misc/ocxl/file.c |