Re: [PATCH] mm/nvdimm: Use correct #defines instead of opencoding

On 5/21/19 9:37 PM, Dan Williams wrote: On Tue, May 21, 2019 at 2:51 AM Aneesh Kumar K.V wrote: Something like the below (Not tested). I am not sure what we will init the page_size for minor version < 3. This will mark the namespace disabled if the PAGE_SIZE and sizeof(struct page)

Re: [PATCH 10/10] docs: fix broken documentation links

On Monday, May 20, 2019 4:47:39 PM CEST Mauro Carvalho Chehab wrote: > Mostly due to x86 and acpi conversion, several documentation > links are still pointing to the old file. Fix them. > > Signed-off-by: Mauro Carvalho Chehab > --- > Documentation/acpi/dsd/leds.txt | 2 +- >

Re: [PATCH 2/2] powerpc/perf: Fix mmcra corruption by bhrb_filter

On 11/05/19 8:12 AM, Ravi Bangoria wrote: Consider a scenario where user creates two events: 1st event: attr.sample_type |= PERF_SAMPLE_BRANCH_STACK; attr.branch_sample_type = PERF_SAMPLE_BRANCH_ANY; fd = perf_event_open(attr, 0, 1, -1, 0); This sets cpuhw->bhrb_filter

Re: [PATCH] misc: remove redundant 'default n' from Kconfig-s

Le 20/05/2019 à 16:10, Bartlomiej Zolnierkiewicz a écrit : 'default n' is the default value for any bool or tristate Kconfig setting so there is no need to write it explicitly. Also since commit f467c5640c29 ("kconfig: only write '# CONFIG_FOO is not set' for visible symbols") the Kconfig

Re: [RFC PATCH 02/12] powerpc: Add support for adding an ESM blob to the zImage wrapper

On Tue, May 21, 2019 at 07:13:26AM +0200, Christoph Hellwig wrote: > On Tue, May 21, 2019 at 01:49:02AM -0300, Thiago Jung Bauermann wrote: > > From: Benjamin Herrenschmidt > > > > For secure VMs, the signing tool will create a ticket called the "ESM blob" > > for the Enter Secure Mode

[BISECTED] kexec regression on PowerBook G4

Hi, I was trying to upgrade from v5.0 -> v5.1 on PowerBook G4, but when trying to kexec a kernel the system gets stuck (no errors seen on the console). Bisected to: 93c4a162b014 ("powerpc/6xx: Store PGDIR physical address in a SPRG"). This commit doesn't revert cleanly anymore but I tested that

Applied "ASoC: fsl_asrc: Unify the supported input and output rate" to the asoc tree

The patch ASoC: fsl_asrc: Unify the supported input and output rate has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.3 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next

Re: [PATCH 1/2] open: add close_range()

On Tue, May 21, 2019 at 9:41 AM Christian Brauner wrote: > > Yeah, you mentioned this before. I do like being able to specify an > upper bound to have the ability to place fds strategically after said > upper bound. I suspect that's the case. And if somebody really wants to just close

Re: [PATCH 1/2] open: add close_range()

On Tue, May 21, 2019 at 08:20:09PM +0100, Al Viro wrote: > On Tue, May 21, 2019 at 05:30:27PM +0100, David Howells wrote: > > > If we can live with close_from(int first) rather than close_range(), then > > this > > can perhaps be done a lot more efficiently by: > > > > new =

Re: [PATCH 1/2] open: add close_range()

On Tue, May 21, 2019 at 05:30:27PM +0100, David Howells wrote: > If we can live with close_from(int first) rather than close_range(), then this > can perhaps be done a lot more efficiently by: > > new = alloc_fdtable(first); > spin_lock(>file_lock); > old =

Re: [PATCH v1 02/15] crypto: talitos - rename alternative AEAD algos.

On Tue, 2019-05-21 at 17:54 +, Christophe Leroy wrote: > Hi Joe & Andy [] > diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c [] > > @@ -2356,7 +2356,7 @@ static struct talitos_alg_template driver_algs[] = { > > .base = { > >

Re: [PATCH v1 02/15] crypto: talitos - rename alternative AEAD algos.

Hi Joe & Andy On 05/21/2019 01:34 PM, Christophe Leroy wrote: The talitos driver has two ways to perform AEAD depending on the HW capability. Some HW support both. It is needed to give them different names to distingish which one it is for instance when a test fails. Signed-off-by: Christophe

Re: [PATCH v2 2/5] powerpc: Fix vDSO clock_getres()

Le 21/05/2019 à 18:08, Vincenzo Frascino a écrit : Hi Christophe, I did not see this patch in 5.2-rc1 and I was wondering if there is anything I can do to help with upstraming it. As far as I can see you series still has status 'new' in patchwork so I guess Michael didn't have time to

Re: [PATCH v2 2/5] powerpc: Fix vDSO clock_getres()

Le 21/05/2019 à 18:46, Christophe Leroy a écrit : Le 21/05/2019 à 18:08, Vincenzo Frascino a écrit : Hi Christophe, I did not see this patch in 5.2-rc1 and I was wondering if there is anything I can do to help with upstraming it. As far as I can see you series still has status 'new'

Re: [PATCH 1/2] open: add close_range()

On Tue, May 21, 2019 at 04:00:06PM +0100, Al Viro wrote: > On Tue, May 21, 2019 at 01:34:47PM +0200, Christian Brauner wrote: > > > This adds the close_range() syscall. It allows to efficiently close a range > > of file descriptors up to all file descriptors of a calling task. > > > > The

Re: [PATCH 1/2] open: add close_range()

On Tue, May 21, 2019 at 05:30:27PM +0100, David Howells wrote: > Al Viro wrote: > > > Umm... That's going to be very painful if you dup2() something to MAX_INT > > and > > then run that; roughly 2G iterations of bouncing ->file_lock up and down, > > without anything that would yield CPU in

Re: [PATCH 1/2] open: add close_range()

Al Viro wrote: > Umm... That's going to be very painful if you dup2() something to MAX_INT and > then run that; roughly 2G iterations of bouncing ->file_lock up and down, > without anything that would yield CPU in process. > > If anything, I would suggest something like > > fd =

Extra selftests failure on Talitos SEC1 hash algs - how can I identify the issue ?

Hello, With the new selftests I get the following failures with Talitos on SEC1 (mpc885). I don't get those failures with Talitos on SEC2 (mpc8321E), but the driver is slightly different for SEC1 as it doesn't support S/G operations. How can I identify what problem to look for based on the

Re: [PATCH] mm/nvdimm: Use correct #defines instead of opencoding

On Tue, May 21, 2019 at 2:51 AM Aneesh Kumar K.V wrote: > > Dan Williams writes: > > > On Mon, May 13, 2019 at 9:46 PM Aneesh Kumar K.V > > wrote: > >> > >> On 5/14/19 9:42 AM, Dan Williams wrote: > >> > On Mon, May 13, 2019 at 9:05 PM Aneesh Kumar K.V > >> > wrote: > >> >> > >> >> On 5/14/19

Re: Re: [RFC PATCH 02/12] powerpc: Add support for adding an ESM blob to the zImage wrapper

On Tue, May 21, 2019 at 07:13:26AM +0200, Christoph Hellwig wrote: > On Tue, May 21, 2019 at 01:49:02AM -0300, Thiago Jung Bauermann wrote: > > From: Benjamin Herrenschmidt > > > > For secure VMs, the signing tool will create a ticket called the "ESM blob" > > for the Enter Secure Mode

Re: [PATCH 1/2] open: add close_range()

On Tue, May 21, 2019 at 01:34:47PM +0200, Christian Brauner wrote: > This adds the close_range() syscall. It allows to efficiently close a range > of file descriptors up to all file descriptors of a calling task. > > The syscall came up in a recent discussion around the new mount API and >

RE: [PATCH] mm/nvdimm: Use correct #defines instead of opencoding

> -Original Message- > From: Linux-nvdimm On Behalf Of > Aneesh Kumar K.V > Sent: Tuesday, May 21, 2019 4:51 AM > Subject: Re: [PATCH] mm/nvdimm: Use correct #defines instead of > opencoding > ... > @@ -36,6 +36,9 @@ struct nd_pfn_sb { > __le32 end_trunc; > /*

Re: [PATCH v3 1/2] pid: add pidfd_open()

On Mon, May 20, 2019 at 05:56:29PM +0200, Christian Brauner wrote: > This adds the pidfd_open() syscall. It allows a caller to retrieve pollable > pidfds for a process which did not get created via CLONE_PIDFD, i.e. for a > process that is created via traditional fork()/clone() calls that is only

Re: [PATCH v2] powerpc/mm: mark more tlb functions as __always_inline

Le 21/05/2019 à 15:13, Masahiro Yamada a écrit : With CONFIG_OPTIMIZE_INLINING enabled, Laura Abbott reported error with gcc 9.1.1: arch/powerpc/mm/book3s64/radix_tlb.c: In function '_tlbiel_pid': arch/powerpc/mm/book3s64/radix_tlb.c:104:2: warning: asm operand 3 probably doesn't

[PATCH v1 15/15] crypto: talitos - use SPDX-License-Identifier

This patch drops the license text and replaces it with an SPDX-License-Identifier tag. Signed-off-by: Christophe Leroy --- drivers/crypto/talitos.c | 15 +-- drivers/crypto/talitos.h | 25 + 2 files changed, 2 insertions(+), 38 deletions(-) diff --git

[PATCH v1 14/15] crypto: talitos - use IS_ENABLED() in has_ftr_sec1()

This patch rewrites has_ftr_sec1() using IS_ENABLED() instead of #ifdefs Signed-off-by: Christophe Leroy --- drivers/crypto/talitos.h | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/crypto/talitos.h b/drivers/crypto/talitos.h index

[PATCH v1 13/15] Revert "crypto: talitos - export the talitos_submit function"

There is no other file using talitos_submit in the kernel tree, so it doesn't need to be exported nor made global. This reverts commit 865d506155b117edc7e668ced373030ce7108ce9. Signed-off-by: Christophe Leroy Fixes: 865d506155b1 ("crypto: talitos - export the talitos_submit function") ---

[PATCH v1 12/15] crypto: talitos - fix AEAD processing.

This driver is working well in 'simple cases', but as soon as more exotic SG lists are provided (dst different from src, auth part not in a single SG fragment, ...) there are wrong results, overruns, etc ... This patch cleans up the AEAD processing by: - Simplifying the location of 'out of line'

[PATCH v1 11/15] crypto: talitos - Align SEC1 accesses to 32 bits boundaries.

The MPC885 reference manual states: SEC Lite-initiated 8xx writes can occur only on 32-bit-word boundaries, but reads can occur on any byte boundary. Writing back a header read from a non-32-bit-word boundary will yield unpredictable results. In order to ensure that, cra_alignmask is set to 3

[PATCH v1 06/15] crypto: talitos - check data blocksize in ablkcipher.

When data size is not a multiple of the alg's block size, the SEC generates an error interrupt and dumps the registers. And for NULL size, the SEC does just nothing and the interrupt is awaited forever. This patch ensures the data size is correct before submitting the request to the SEC engine.

[PATCH v1 10/15] crypto: talitos - properly handle split ICV.

The driver assumes that the ICV is as a single piece in the last element of the scatterlist. This assumption is wrong. This patch ensures that the ICV is properly handled regardless of the scatterlist layout. Fixes: 9c4a79653b35 ("crypto: talitos - Freescale integrated security engine (SEC)

[PATCH v1 09/15] crypto: talitos - HMAC SNOOP NO AFEU mode requires SW icv checking.

In that mode, hardware ICV verification is not supported. Signed-off-by: Christophe Leroy Fixes: 7405c8d7ff97 ("crypto: talitos - templates for AEAD using HMAC_SNOOP_NO_AFEU") --- drivers/crypto/talitos.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH v1 08/15] crypto: talitos - Do not modify req->cryptlen on decryption.

For decrypt, req->cryptlen includes the size of the authentication part while all functions of the driver expect cryptlen to be the size of the encrypted data. As it is not expected to change req->cryptlen, this patch implements local calculation of cryptlen. Signed-off-by: Christophe Leroy

[PATCH v1 07/15] crypto: talitos - fix ECB algs ivsize

ECB's ivsize must be 0. Signed-off-by: Christophe Leroy Fixes: 5e75ae1b3cef ("crypto: talitos - add new crypto modes") --- drivers/crypto/talitos.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c index 1e5410f92166..6f6f34754ad8 100644

[PATCH v1 05/15] crypto: talitos - fix CTR alg blocksize

CTR has a blocksize of 1. Signed-off-by: Christophe Leroy Fixes: 5e75ae1b3cef ("crypto: talitos - add new crypto modes") --- drivers/crypto/talitos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c index

[PATCH v1 04/15] crypto: talitos - check AES key size

Although the HW accepts any size and silently truncates it to the correct length, the extra tests expects EINVAL to be returned when the key size is not valid. Signed-off-by: Christophe Leroy Fixes: 4de9d0b547b9 ("crypto: talitos - Add ablkcipher algorithms") --- drivers/crypto/talitos.c | 15

[PATCH v1 02/15] crypto: talitos - rename alternative AEAD algos.

The talitos driver has two ways to perform AEAD depending on the HW capability. Some HW support both. It is needed to give them different names to distingish which one it is for instance when a test fails. Signed-off-by: Christophe Leroy Fixes: 7405c8d7ff97 ("crypto: talitos - templates for AEAD

[PATCH v1 01/15] crypto: talitos - fix skcipher failure due to wrong output IV

Selftests report the following: [2.984845] alg: skcipher: cbc-aes-talitos encryption test failed (wrong output IV) on test vector 0, cfg="in-place" [2.995377] : 3d af ba 42 9d 9e b4 30 b4 22 da 80 2c 9f ac 41 [3.032673] alg: skcipher: cbc-des-talitos encryption test failed

[PATCH v1 03/15] crypto: talitos - reduce max key size for SEC1

SEC1 doesn't support SHA384/512, so it doesn't require longer keys. This patch reduces the max key size when the driver is built for SEC1 only. Signed-off-by: Christophe Leroy Fixes: 03d2c5114c95 ("crypto: talitos - Extend max key length for SHA384/512-HMAC and AEAD") ---

[PATCH v1 00/15] Fixing selftests failure on Talitos driver

Several test failures have popped up following recent changes to crypto selftests. This series fixes (most of) them. The last three patches are trivial cleanups. Christophe Leroy (15): crypto: talitos - fix skcipher failure due to wrong output IV crypto: talitos - rename alternative AEAD

Re: [PATCH 1/2] open: add close_range()

On Tue, May 21, 2019 at 03:10:11PM +0200, Florian Weimer wrote: > * Christian Brauner: > > >> Solaris has an fdwalk function: > >> > >> > >> > >> So a different way to implement this would expose a nextfd system call > > > >

Re: [PATCH 1/2] open: add close_range()

On Tue, May 21, 2019 at 03:10:11PM +0200, Florian Weimer wrote: > * Christian Brauner: > > >> Solaris has an fdwalk function: > >> > >> > >> > >> So a different way to implement this would expose a nextfd system call > > > >

[PATCH v2] powerpc/mm: mark more tlb functions as __always_inline

With CONFIG_OPTIMIZE_INLINING enabled, Laura Abbott reported error with gcc 9.1.1: arch/powerpc/mm/book3s64/radix_tlb.c: In function '_tlbiel_pid': arch/powerpc/mm/book3s64/radix_tlb.c:104:2: warning: asm operand 3 probably doesn't match constraints 104 | asm volatile(PPC_TLBIEL(%0, %4,

Re: [PATCH 1/2] open: add close_range()

* Christian Brauner: >> Solaris has an fdwalk function: >> >> >> >> So a different way to implement this would expose a nextfd system call > > Meh. If nextfd() then I would like it to be able to: > - get the nextfd(fd) >= fd

Re: [PATCH 1/2] open: add close_range()

On Tue, May 21, 2019 at 02:09:29PM +0200, Florian Weimer wrote: > * Christian Brauner: > > > +/** > > + * __close_range() - Close all file descriptors in a given range. > > + * > > + * @fd: starting file descriptor to close > > + * @max_fd: last file descriptor to close > > + * > > + * This

Re: [PATCH v7 1/1] iommu: enhance IOMMU dma mode build options

On 20/05/2019 14:59, Zhen Lei wrote: First, add build option IOMMU_DEFAULT_{LAZY|STRICT}, so that we have the opportunity to set {lazy|strict} mode as default at build time. Then put the three config options in an choice, make people can only choose one of the three at a time. The default IOMMU

Re: [PATCH 1/2] open: add close_range()

* Christian Brauner: > +/** > + * __close_range() - Close all file descriptors in a given range. > + * > + * @fd: starting file descriptor to close > + * @max_fd: last file descriptor to close > + * > + * This closes a range of file descriptors. All file descriptors > + * from @fd up to and

Re: [PATCH] misc: remove redundant 'default n' from Kconfig-s

Bartlomiej Zolnierkiewicz writes: > 'default n' is the default value for any bool or tristate Kconfig > setting so there is no need to write it explicitly. > > Also since commit f467c5640c29 ("kconfig: only write '# CONFIG_FOO > is not set' for visible symbols") the Kconfig behavior is the same >

Re: [PATCH] powerpc/powernv: Return for invalid IMC domain

Anju T Sudhakar writes: > Currently init_imc_pmu() can be failed either because > an IMC unit with invalid domain(i.e an IMC node not > supported by the kernel) is attempted a pmu-registration > or something went wrong while registering a valid IMC unit. > In both the cases kernel provides a

[PATCH 2/2] tests: add close_range() tests

This adds basic tests for the new close_range() syscall. - test that no invalid flags can be passed - test that a range of file descriptors is correctly closed - test that a range of file descriptors is correctly closed if there there are already closed file descriptors in the range - test that

[PATCH 1/2] open: add close_range()

This adds the close_range() syscall. It allows to efficiently close a range of file descriptors up to all file descriptors of a calling task. The syscall came up in a recent discussion around the new mount API and making new file descriptor types cloexec by default. During this discussion, Al

Re: [PATCH v2] powerpc/mm/hash: Fix get_region_id() for invalid addresses

On Fri, 2019-05-17 at 13:29:58 UTC, Michael Ellerman wrote: > From: "Aneesh Kumar K.V" > > Accesses by userspace to random addresses outside the user or kernel > address range will generate an SLB fault. When we handle that fault we > classify the effective address into several classes, eg.

Re: [PATCH] powerpc/mm/hash: Improve address limit checks

Michael Ellerman writes: > On Thu, 2019-05-16 at 11:50:54 UTC, "Aneesh Kumar K.V" wrote: >> Different parts of the code do the limit check by ignoring the top nibble >> of EA. ie. we do checks like >> >> if ((ea & EA_MASK) >= H_PGTABLE_RANGE) >> error >> >> This patch makes

Re: [PATCH] mm/nvdimm: Use correct #defines instead of opencoding

Dan Williams writes: > On Mon, May 13, 2019 at 9:46 PM Aneesh Kumar K.V > wrote: >> >> On 5/14/19 9:42 AM, Dan Williams wrote: >> > On Mon, May 13, 2019 at 9:05 PM Aneesh Kumar K.V >> > wrote: >> >> >> >> On 5/14/19 9:28 AM, Dan Williams wrote: >> >>> On Mon, May 13, 2019 at 7:56 PM Aneesh

[Bug 203517] WARNING: inconsistent lock state. inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage.

https://bugzilla.kernel.org/show_bug.cgi?id=203517 David Sterba (dste...@suse.com) changed: What|Removed |Added Status|NEW |RESOLVED

[PATCH][next] soc: fsl: fix spelling mistake "Firmaware" -> "Firmware"

From: Colin Ian King There is a spelling mistake in a pr_err message. Fix it. Signed-off-by: Colin Ian King --- drivers/soc/fsl/dpaa2-console.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/fsl/dpaa2-console.c b/drivers/soc/fsl/dpaa2-console.c index

Re: [PATCH] powerpc/mm: mark more tlb functions as __always_inline

On Tue, 2019-05-21 at 16:27 +0900, Masahiro Yamada wrote: > On Tue, May 21, 2019 at 3:54 PM Christophe Leroy > > powerpc accepts lines up to 90 chars, see arch/powerpc/tools/checkpatch.pl > > Ugh, I did not know this. Horrible. > > The Linux coding style should be global in the kernel tree. > No

Re: [PATCH] mm/nvdimm: Use correct #defines instead of opencoding

On Mon, May 13, 2019 at 9:46 PM Aneesh Kumar K.V wrote: > > On 5/14/19 9:42 AM, Dan Williams wrote: > > On Mon, May 13, 2019 at 9:05 PM Aneesh Kumar K.V > > wrote: > >> > >> On 5/14/19 9:28 AM, Dan Williams wrote: > >>> On Mon, May 13, 2019 at 7:56 PM Aneesh Kumar K.V > >>> wrote: > >

Re: [PATCH] powerpc/mm: mark more tlb functions as __always_inline

Masahiro Yamada writes: > On Tue, May 21, 2019 at 3:54 PM Christophe Leroy > wrote: >> Le 21/05/2019 à 08:16, Masahiro Yamada a écrit : >> > With CONFIG_OPTIMIZE_INLINING enabled, Laura Abbott reported error >> > with gcc 9.1.1: >> > >> >arch/powerpc/mm/book3s64/radix_tlb.c: In function

Re: [PATCH] powerpc/mm: mark more tlb functions as __always_inline

On Tue, May 21, 2019 at 3:54 PM Christophe Leroy wrote: > > > > Le 21/05/2019 à 08:16, Masahiro Yamada a écrit : > > With CONFIG_OPTIMIZE_INLINING enabled, Laura Abbott reported error > > with gcc 9.1.1: > > > >arch/powerpc/mm/book3s64/radix_tlb.c: In function '_tlbiel_pid': > >

Re: [PATCH] powerpc/mm: mark more tlb functions as __always_inline

On Tue, 2019-05-21 at 08:53 +0200, Christophe Leroy wrote: > powerpc accepts lines up to 90 chars, see arch/powerpc/tools/checkpatch.pl arch/powerpc/tools/checkpatch.sh

Re: [PATCH] powerpc/mm: mark more tlb functions as __always_inline

Le 21/05/2019 à 08:16, Masahiro Yamada a écrit : With CONFIG_OPTIMIZE_INLINING enabled, Laura Abbott reported error with gcc 9.1.1: arch/powerpc/mm/book3s64/radix_tlb.c: In function '_tlbiel_pid': arch/powerpc/mm/book3s64/radix_tlb.c:104:2: warning: asm operand 3 probably doesn't

[PATCH] powerpc/mm: mark more tlb functions as __always_inline

With CONFIG_OPTIMIZE_INLINING enabled, Laura Abbott reported error with gcc 9.1.1: arch/powerpc/mm/book3s64/radix_tlb.c: In function '_tlbiel_pid': arch/powerpc/mm/book3s64/radix_tlb.c:104:2: warning: asm operand 3 probably doesn't match constraints 104 | asm volatile(PPC_TLBIEL(%0, %4,