Re: [PATCH v4 07/25] pseries/fadump: move out platform specific support from generic code

2019-08-12 Thread Mahesh J Salgaonkar
On 2019-07-16 17:02:45 Tue, Hari Bathini wrote: > Move code that supports processing the crash'ed kernel's memory > preserved by firmware to platform specific callback functions. > > Signed-off-by: Hari Bathini > --- > arch/powerpc/kernel/fadump-common.h |6 >

[PATCH] powerpc: Remove empty comment

2019-08-12 Thread Jordan Niethe
Commit 2874c5fd2842 ("treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152") left an empty comment in machdep.h, as the boilerplate was the only text in the comment. Remove the empty comment. Signed-off-by: Jordan Niethe --- arch/powerpc/include/asm/machdep.h | 3 --- 1 file

Re: [PATCH 1/2] KVM: PPC: Book3S HV: Fix race in re-enabling XIVE escalation interrupts

2019-08-12 Thread Paul Mackerras
On Mon, Aug 12, 2019 at 03:07:05PM +1000, Paul Mackerras wrote: > lbz r5, VCPU_XIVE_ESC_ON(r9) > cmpwi r5, 0 > - beq 1f > + beq 4f > li r0, 0 > stb r0, VCPU_CEDED(r9) > + li r6, XIVE_ESB_SET_PQ_10 > + b 1f > +4: li

Re: [PATCH 2/2] powerpc/xive: Implement get_irqchip_state method for XIVE to fix shutdown race

2019-08-12 Thread Paul Mackerras
On Mon, Aug 12, 2019 at 10:52:11PM -0500, Lijun Pan wrote: > > > > On Aug 12, 2019, at 12:07 AM, Paul Mackerras wrote: [snip] > > +static void cleanup_single_escalation(struct kvm_vcpu *vcpu, > > + struct kvmppc_xive_vcpu *xc, int irq) > > +{ > > + struct

Re: [PATCHv4 1/2] PCI: layerscape: Add the bar_fixed_64bit property in EP driver.

2019-08-12 Thread Kishon Vijay Abraham I
On 13/08/19 8:23 AM, Xiaowei Bao wrote: > The PCIe controller of layerscape just have 4 BARs, BAR0 and BAR1 > is 32bit, BAR3 and BAR4 is 64bit, this is determined by hardware, Do you mean BAR2 instead of BAR3 here? Thanks Kishon > so set the bar_fixed_64bit with 0x14. > > Signed-off-by:

Re: [PATCH v9 1/7] powerpc/mce: Schedule work from irq_work

2019-08-12 Thread Mahesh Jagannath Salgaonkar
On 8/12/19 2:52 PM, Santosh Sivaraj wrote: > schedule_work() cannot be called from MCE exception context as MCE can > interrupt even in interrupt disabled context. > > fixes: 733e4a4c ("powerpc/mce: hookup memory_failure for UE errors") > Suggested-by: Mahesh Salgaonkar > Signed-off-by: Santosh

Re: Freeze on ppc32 MPC8248 board with 5.2 kernel

2019-08-12 Thread Christophe Leroy
Hi Doug, Le 26/07/2019 à 00:30, Doug Crawford a écrit : We have a ppc32 MPC8248 board that is working perfectly with the 4.19 kernel. We have noticed two issues with the 5.2 kernel: Have you tried 5.0 and 5.1 ? 1) If the new CONFIG_PPC_KUAP (kernel userspace access protection) is

Re: [PATCH] dmaengine: fsldma: Mark expected switch fall-through

2019-08-12 Thread Vinod Koul
On 11-08-19, 19:22, Gustavo A. R. Silva wrote: > Mark switch cases where we are expecting to fall through. > > Fix the following warning (Building: powerpc-ppa8548_defconfig powerpc): > > drivers/dma/fsldma.c: In function ‘fsl_dma_chan_probe’: > drivers/dma/fsldma.c:1165:26: warning: this

Re: [PATCH 2/2] powerpc/xive: Implement get_irqchip_state method for XIVE to fix shutdown race

2019-08-12 Thread Lijun Pan
> On Aug 12, 2019, at 12:07 AM, Paul Mackerras wrote: > > --- > arch/powerpc/include/asm/xive.h | 8 > arch/powerpc/kvm/book3s_xive.c| 31 ++ > arch/powerpc/sysdev/xive/common.c | 87 --- > 3 files changed, 103 insertions(+), 23

[PATCH v4 2/3] powerpc/spinlocks: Rename SPLPAR-only spinlocks

2019-08-12 Thread Christopher M. Riedl
The __rw_yield and __spin_yield locks only pertain to SPLPAR mode. Rename them to make this relationship obvious. Signed-off-by: Christopher M. Riedl Reviewed-by: Andrew Donnellan --- arch/powerpc/include/asm/spinlock.h | 6 -- arch/powerpc/lib/locks.c| 6 +++--- 2 files

[PATCH v4 3/3] powerpc/spinlocks: Fix oops in shared-processor spinlocks

2019-08-12 Thread Christopher M. Riedl
Booting w/ ppc64le_defconfig + CONFIG_PREEMPT results in the attached kernel trace due to calling shared-processor spinlocks while not running in an SPLPAR. Previously, the out-of-line spinlocks implementations were selected based on CONFIG_PPC_SPLPAR at compile time without a runtime

[PATCH v4 1/3] powerpc/spinlocks: Refactor SHARED_PROCESSOR

2019-08-12 Thread Christopher M. Riedl
Determining if a processor is in shared processor mode is not a constant so don't hide it behind a #define. Signed-off-by: Christopher M. Riedl Reviewed-by: Andrew Donnellan --- arch/powerpc/include/asm/spinlock.h | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-)

[PATCH v4 0/3] Fix oops in shared-processor spinlocks

2019-08-12 Thread Christopher M. Riedl
Fixes an oops when calling the shared-processor spinlock implementation from a non-SP LPAR. Also take this opportunity to refactor SHARED_PROCESSOR a bit. Reference: https://github.com/linuxppc/issues/issues/229 Changes since v3: - Replace CONFIG_BOOK3S #ifdef with CONFIG_PPC_PSERIES in

[PATCHv4 2/2] PCI: layerscape: Add CONFIG_PCI_LAYERSCAPE_EP to build EP/RC separately

2019-08-12 Thread Xiaowei Bao
Add CONFIG_PCI_LAYERSCAPE_EP to build EP/RC separately. Signed-off-by: Xiaowei Bao --- v2: - No change. v3: - modify the commit message. v4: - send the patch again with '--to'. drivers/pci/controller/dwc/Kconfig | 20 ++-- drivers/pci/controller/dwc/Makefile |3 ++- 2

[PATCHv4 1/2] PCI: layerscape: Add the bar_fixed_64bit property in EP driver.

2019-08-12 Thread Xiaowei Bao
The PCIe controller of layerscape just have 4 BARs, BAR0 and BAR1 is 32bit, BAR3 and BAR4 is 64bit, this is determined by hardware, so set the bar_fixed_64bit with 0x14. Signed-off-by: Xiaowei Bao --- v2: - Replace value 0x14 with a macro. v3: - No change. v4: - send the patch again with

RE: [EXT] Re: [PATCHv3 1/2] PCI: layerscape: Add the bar_fixed_64bit property in EP driver.

2019-08-12 Thread Xiaowei Bao
> -Original Message- > From: Lorenzo Pieralisi > Sent: 2019年8月12日 19:36 > To: Xiaowei Bao > Cc: kis...@ti.com; bhelg...@google.com; robh...@kernel.org; > mark.rutl...@arm.com; shawn...@kernel.org; Leo Li > ; a...@arndb.de; gre...@linuxfoundation.org; M.h. > Lian ; Mingkai Hu ; Roy >

Re: [PATCH v9 2/7] powerpc/mce: Fix MCE handling for huge pages

2019-08-12 Thread Santosh Sivaraj
Sasha Levin writes: > Hi, > > [This is an automated email] > > This commit has been processed because it contains a "Fixes:" tag, > fixing commit: ba41e1e1ccb9 powerpc/mce: Hookup derror (load/store) UE errors. > > The bot has tested the following trees: v5.2.8, v4.19.66. > > v5.2.8: Build OK! >

Re: [PATCH v3 11/16] powerpc/pseries/svm: Export guest SVM status to user space via sysfs

2019-08-12 Thread Thiago Jung Bauermann
Michael Ellerman writes: > Thiago Jung Bauermann writes: >> From: Ryan Grimm >> >> User space might want to know it's running in a secure VM. It can't do >> a mfmsr because mfmsr is a privileged instruction. >> >> The solution here is to create a cpu attribute: >> >>

Re: [PATCH v3 08/16] powerpc/pseries/svm: Use shared memory for LPPACA structures

2019-08-12 Thread Thiago Jung Bauermann
Michael Ellerman writes: > Thiago Jung Bauermann writes: >> From: Anshuman Khandual >> >> LPPACA structures need to be shared with the host. Hence they need to be in >> shared memory. Instead of allocating individual chunks of memory for a >> given structure from memblock, a contiguous chunk

RE: [PATCH] dmaengine: fsldma: Mark expected switch fall-through

2019-08-12 Thread Leo Li
> -Original Message- > From: Gustavo A. R. Silva > Sent: Sunday, August 11, 2019 7:22 PM > To: Leo Li ; Zhang Wei ; Vinod > Koul ; Dan Williams > Cc: linuxppc-dev@lists.ozlabs.org; dmaeng...@vger.kernel.org; linux- > ker...@vger.kernel.org; Gustavo A. R. Silva > Subject: [PATCH]

Re: [PATCH] powerpc: Avoid clang warnings around setjmp and longjmp

2019-08-12 Thread Nathan Chancellor
On Mon, Aug 12, 2019 at 07:37:51AM +0200, Christophe Leroy wrote: > > > Le 12/08/2019 à 04:32, Nathan Chancellor a écrit : > > Commit aea447141c7e ("powerpc: Disable -Wbuiltin-requires-header when > > setjmp is used") disabled -Wbuiltin-requires-header because of a warning > > about the setjmp

Re: [PATCH v2 1/3] powerpc/rtas: use device model APIs and serialization during LPM

2019-08-12 Thread Nathan Lynch
Tyrel Datwyler writes: > On 8/2/19 12:29 PM, Nathan Lynch wrote: >> diff --git a/arch/powerpc/kernel/rtas.c b/arch/powerpc/kernel/rtas.c >> index 5faf0a64c92b..05824eb4323b 100644 >> --- a/arch/powerpc/kernel/rtas.c >> +++ b/arch/powerpc/kernel/rtas.c >> @@ -871,15 +871,17 @@ static int

[Bug 204479] KASAN hit at modprobe zram

2019-08-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204479 --- Comment #18 from Christophe Leroy (christophe.le...@c-s.fr) --- The Oops occurs at 0x3c8: 3b0: 81 21 00 88 lwz r9,136(r1) 3b4: 13 67 dc c4 vxorv27,v7,v27 3b8: 7d 11 a8 ce lvx v8,r17,r21 3bc: 11 5f 5b 06

Re: [PATCH v4 06/25] pseries/fadump: define register/un-register callback functions

2019-08-12 Thread Mahesh J Salgaonkar
On 2019-07-16 17:02:38 Tue, Hari Bathini wrote: > Make RTAS calls to register and un-register for FADump. Also, update > how fadump_region contents are diplayed to provide more information. > > Signed-off-by: Hari Bathini > --- > arch/powerpc/kernel/fadump-common.h |2 >

[Bug 204479] KASAN hit at modprobe zram

2019-08-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204479 --- Comment #17 from Christophe Leroy (christophe.le...@c-s.fr) --- Created attachment 284343 --> https://bugzilla.kernel.org/attachment.cgi?id=284343=edit Disassembly of lib/raid6/altivec8.o -- You are receiving this mail because: You are on

Re: [PATCH v5 1/7] Documentation/powerpc: Ultravisor API

2019-08-12 Thread Fabiano Rosas
Claudio Carvalho writes: Some small suggestions below: > + > +* The privilege of a process is now determined by three MSR bits, > + MSR(S, HV, PR). In each of the tables below the modes are listed > + from least privilege to highest privilege. The higher privilege > + modes

Re: [PATCH v9 2/7] powerpc/mce: Fix MCE handling for huge pages

2019-08-12 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a "Fixes:" tag, fixing commit: ba41e1e1ccb9 powerpc/mce: Hookup derror (load/store) UE errors. The bot has tested the following trees: v5.2.8, v4.19.66. v5.2.8: Build OK! v4.19.66: Failed to apply! Possible

Re: [PATCH] powerpc/64e: drop stale call to smp_processor_id() which hangs SMP startup

2019-08-12 Thread Michael Ellerman
On Thu, 2019-08-08 at 12:48:26 UTC, Christophe Leroy wrote: > Santa commit ebb9d30a6a74 ("powerpc/mm: any thread in one core can be > the first to setup TLB1") removed the need to know the cpu_id in > early_init_this_mmu(), but the call to smp_processor_id() which was > marked __maybe_used

Applied "ASoC: fsl_esai: Add new compatible string for imx6ull" to the asoc tree

2019-08-12 Thread Mark Brown
The patch ASoC: fsl_esai: Add new compatible string for imx6ull has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.4 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24

Applied "ASoC: fsl_esai: Add compatible string for imx6ull" to the asoc tree

2019-08-12 Thread Mark Brown
The patch ASoC: fsl_esai: Add compatible string for imx6ull has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.4 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours)

Re: [PATCH v3 11/16] powerpc/pseries/svm: Export guest SVM status to user space via sysfs

2019-08-12 Thread Michael Ellerman
Thiago Jung Bauermann writes: > From: Ryan Grimm > > User space might want to know it's running in a secure VM. It can't do > a mfmsr because mfmsr is a privileged instruction. > > The solution here is to create a cpu attribute: > > /sys/devices/system/cpu/svm > > which will read 0 or 1 based

Re: [PATCH v3 08/16] powerpc/pseries/svm: Use shared memory for LPPACA structures

2019-08-12 Thread Michael Ellerman
Thiago Jung Bauermann writes: > From: Anshuman Khandual > > LPPACA structures need to be shared with the host. Hence they need to be in > shared memory. Instead of allocating individual chunks of memory for a > given structure from memblock, a contiguous chunk of memory is allocated > and then

Re: [PATCH v3 1/3] powerpc/spinlocks: Refactor SHARED_PROCESSOR

2019-08-12 Thread Michael Ellerman
kbuild test robot writes: > Hi "Christopher, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on linus/master] > [cannot apply to v5.3-rc4 next-20190809] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > >

Re: [PATCH 3/6] usb: add a HCD_DMA flag instead of guestimating DMA capabilities

2019-08-12 Thread Christoph Hellwig
> diff --git a/drivers/usb/host/ehci-ppc-of.c b/drivers/usb/host/ehci-ppc-of.c > index 576f7d79ad4e..9d17e0695e35 100644 > --- a/drivers/usb/host/ehci-ppc-of.c > +++ b/drivers/usb/host/ehci-ppc-of.c > @@ -31,7 +31,7 @@ static const struct hc_driver ehci_ppc_of_hc_driver = { >* generic

Re: [EXT] Re: [PATCHv3 1/2] PCI: layerscape: Add the bar_fixed_64bit property in EP driver.

2019-08-12 Thread Lorenzo Pieralisi
On Mon, Aug 12, 2019 at 10:39:00AM +, Xiaowei Bao wrote: > > > > -Original Message- > > From: Lorenzo Pieralisi > > Sent: 2019年8月12日 18:12 > > To: Xiaowei Bao ; kis...@ti.com > > Cc: bhelg...@google.com; robh...@kernel.org; mark.rutl...@arm.com; > > shawn...@kernel.org; Leo Li ;

RE: [EXT] Re: [PATCHv3 1/2] PCI: layerscape: Add the bar_fixed_64bit property in EP driver.

2019-08-12 Thread Xiaowei Bao
> -Original Message- > From: Lorenzo Pieralisi > Sent: 2019年8月12日 18:12 > To: Xiaowei Bao ; kis...@ti.com > Cc: bhelg...@google.com; robh...@kernel.org; mark.rutl...@arm.com; > shawn...@kernel.org; Leo Li ; a...@arndb.de; > gre...@linuxfoundation.org; M.h. Lian ; Mingkai > Hu ; Roy Zang

RE: [EXT] Re: [PATCHv3 2/2] PCI: layerscape: Add CONFIG_PCI_LAYERSCAPE_EP to build EP/RC separately

2019-08-12 Thread Xiaowei Bao
> -Original Message- > From: Lorenzo Pieralisi > Sent: 2019年8月12日 18:06 > To: Xiaowei Bao > Cc: bhelg...@google.com; robh...@kernel.org; mark.rutl...@arm.com; > shawn...@kernel.org; Leo Li ; kis...@ti.com; > a...@arndb.de; gre...@linuxfoundation.org; M.h. Lian > ; Mingkai Hu ; Roy Zang

Re: [PATCHv3 1/2] PCI: layerscape: Add the bar_fixed_64bit property in EP driver.

2019-08-12 Thread Lorenzo Pieralisi
First off: Trim the CC list, you CC'ed maintainers (and mailing lists) for no reasons whatsover. Then, read this: https://lore.kernel.org/linux-pci/20171026223701.ga25...@bhelgaas-glaptop.roam.corp.google.com/ and make your patches compliant please. On Fri, Jun 28, 2019 at 09:38:25AM +0800,

Re: [PATCHv3 2/2] PCI: layerscape: Add CONFIG_PCI_LAYERSCAPE_EP to build EP/RC separately

2019-08-12 Thread Lorenzo Pieralisi
On Fri, Jun 28, 2019 at 09:38:26AM +0800, Xiaowei Bao wrote: > Add CONFIG_PCI_LAYERSCAPE_EP to build EP/RC separately. > > Signed-off-by: Xiaowei Bao > --- > v2: > - No change. > v3: > - modify the commit message. > > drivers/pci/controller/dwc/Kconfig | 20 ++-- >

Re: [PATCH v4 05/25] pseries/fadump: introduce callbacks for platform specific operations

2019-08-12 Thread Mahesh J Salgaonkar
On 2019-07-16 17:02:30 Tue, Hari Bathini wrote: > Introduce callback functions for platform specific operations like > register, unregister, invalidate & such. Also, define place-holders > for the same on pSeries platform. > > Signed-off-by: Hari Bathini > --- >

[PATCH v9 7/7] powerpc: add machine check safe copy_to_user

2019-08-12 Thread Santosh Sivaraj
Use memcpy_mcsafe() implementation to define copy_to_user_mcsafe() Signed-off-by: Santosh Sivaraj --- arch/powerpc/Kconfig | 1 + arch/powerpc/include/asm/uaccess.h | 14 ++ 2 files changed, 15 insertions(+) diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig

[PATCH v9 6/7] powerpc/mce: Handle UE event for memcpy_mcsafe

2019-08-12 Thread Santosh Sivaraj
If we take a UE on one of the instructions with a fixup entry, set nip to continue execution at the fixup entry. Stop processing the event further or print it. Co-developed-by: Reza Arbab Signed-off-by: Reza Arbab Cc: Mahesh Salgaonkar Signed-off-by: Santosh Sivaraj ---

[PATCH v9 5/7] powerpc/memcpy: Add memcpy_mcsafe for pmem

2019-08-12 Thread Santosh Sivaraj
From: Balbir Singh The pmem infrastructure uses memcpy_mcsafe in the pmem layer so as to convert machine check exceptions into a return value on failure in case a machine check exception is encountered during the memcpy. The return value is the number of bytes remaining to be copied. This patch

[PATCH v9 4/7] extable: Add function to search only kernel exception table

2019-08-12 Thread Santosh Sivaraj
Certain architecture specific operating modes (e.g., in powerpc machine check handler that is unable to access vmalloc memory), the search_exception_tables cannot be called because it also searches the module exception tables if entry is not found in the kernel exception table. Cc: Thomas

[PATCH v9 3/7] powerpc/mce: Make machine_check_ue_event() static

2019-08-12 Thread Santosh Sivaraj
From: Reza Arbab The function doesn't get used outside this file, so make it static. Signed-off-by: Reza Arbab Signed-off-by: Santosh Sivaraj Reviewed-by: Nicholas Piggin --- arch/powerpc/kernel/mce.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v9 2/7] powerpc/mce: Fix MCE handling for huge pages

2019-08-12 Thread Santosh Sivaraj
From: Balbir Singh The current code would fail on huge pages addresses, since the shift would be incorrect. Use the correct page shift value returned by __find_linux_pte() to get the correct physical address. The code is more generic and can handle both regular and compound pages. Fixes:

[PATCH v9 1/7] powerpc/mce: Schedule work from irq_work

2019-08-12 Thread Santosh Sivaraj
schedule_work() cannot be called from MCE exception context as MCE can interrupt even in interrupt disabled context. fixes: 733e4a4c ("powerpc/mce: hookup memory_failure for UE errors") Suggested-by: Mahesh Salgaonkar Signed-off-by: Santosh Sivaraj Cc: sta...@vger.kernel.org # v4.15+ ---

[PATCH v9 0/7] powerpc: implement machine check safe memcpy

2019-08-12 Thread Santosh Sivaraj
During a memcpy from a pmem device, if a machine check exception is generated we end up in a panic. In case of fsdax read, this should only result in a -EIO. Avoid MCE by implementing memcpy_mcsafe. Before this patch series: ``` bash-4.4# mount -o dax /dev/pmem0 /mnt/pmem/ [ 7621.714094]

Re: [PATCH v4 03/25] powerpc/fadump: Improve fadump documentation

2019-08-12 Thread Mahesh Jagannath Salgaonkar
On 7/16/19 5:02 PM, Hari Bathini wrote: > The figures depicting FADump's (Firmware-Assisted Dump) memory layout > are missing some finer details like different memory regions and what > they represent. Improve the documentation by updating those details. > > Signed-off-by: Hari Bathini > --- >