Re: [PATCH 1/1] powerpc/kernel: Enables memory hot-remove after reboot on pseries guests

2020-03-03 Thread Leonardo Bras
Hello Bharata, thanks for this feedback! On Wed, 2020-03-04 at 10:13 +0530, Bharata B Rao wrote: > Hi, > > I tried this a few years back > (https://patchwork.ozlabs.org/patch/800142/) and didn't pursue it > further because at that time, it was felt that the approach might not > work for PowerVM

Re: [PATCH v2] ima: add a new CONFIG for loading arch-specific policies

2020-03-03 Thread Ard Biesheuvel
On Wed, 4 Mar 2020 at 03:34, Nayna Jain wrote: > > Every time a new architecture defines the IMA architecture specific > functions - arch_ima_get_secureboot() and arch_ima_get_policy(), the IMA > include file needs to be updated. To avoid this "noise", this patch > defines a new IMA Kconfig

Re: [PATCH v3 18/27] powerpc/powernv/pmem: Add controller dump IOCTLs

2020-03-03 Thread Andrew Donnellan
On 21/2/20 2:27 pm, Alastair D'Silva wrote: +static int ioctl_controller_dump_data(struct ocxlpmem *ocxlpmem, + struct ioctl_ocxl_pmem_controller_dump_data __user *uarg) +{ + struct ioctl_ocxl_pmem_controller_dump_data args; + u16 i; + u64 val; + int rc; + +

Re: [PATCH V14] mm/debug: Add tests validating architecture page table helpers

2020-03-03 Thread Christophe Leroy
Le 04/03/2020 à 02:39, Qian Cai a écrit : Below is slightly modified version of your change above and should still prevent the bug on powerpc. Will it be possible for you to re-test this ? Once confirmed, will send a patch enabling this test on powerpc64 keeping your authorship. Thank you.

Re: [PATCH v3 17/27] powerpc/powernv/pmem: Implement the Read Error Log command

2020-03-03 Thread Andrew Donnellan
On 21/2/20 2:27 pm, Alastair D'Silva wrote: From: Alastair D'Silva The read error log command extracts information from the controller's internal error log. This patch exposes this information in 2 ways: - During probe, if an error occurs & a log is available, print it to the console -

Re: [RFC 2/3] mm/vma: Introduce VM_ACCESS_FLAGS

2020-03-03 Thread Anshuman Khandual
On 03/03/2020 11:18 PM, Vlastimil Babka wrote: > On 3/2/20 7:47 AM, Anshuman Khandual wrote: >> There are many places where all basic VMA access flags (read, write, exec) >> are initialized or checked against as a group. One such example is during >> page fault. Existing vma_is_accessible()

Re: [PATCH v3 20/27] powerpc/powernv/pmem: Forward events to userspace

2020-03-03 Thread Alastair D'Silva
On Tue, 2020-03-03 at 18:02 +1100, Andrew Donnellan wrote: > On 21/2/20 2:27 pm, Alastair D'Silva wrote:> @@ -938,6 +955,51 @@ > static > int ioctl_controller_stats(struct ocxlpmem *ocxlpmem, > > return rc; > > } > > > > +static int ioctl_eventfd(struct ocxlpmem *ocxlpmem, > > +

Re: [PATCH v3 03/27] powerpc: Map & release OpenCAPI LPC memory

2020-03-03 Thread Alastair D'Silva
On Tue, 2020-03-03 at 17:10 +1100, Andrew Donnellan wrote: > On 21/2/20 2:26 pm, Alastair D'Silva wrote:> +#ifdef > CONFIG_MEMORY_HOTPLUG_SPARSE > > +u64 pnv_ocxl_platform_lpc_setup(struct pci_dev *pdev, u64 size) > > +{ > > + struct pci_controller *hose = pci_bus_to_host(pdev->bus); > > +

Re: [RFC 1/3] mm/vma: Define a default value for VM_DATA_DEFAULT_FLAGS

2020-03-03 Thread Anshuman Khandual
On 03/03/2020 10:55 PM, Vlastimil Babka wrote: > On 3/2/20 7:47 AM, Anshuman Khandual wrote: >> There are many platforms with exact same value for VM_DATA_DEFAULT_FLAGS >> This creates a default value for VM_DATA_DEFAULT_FLAGS in line with the >> existing VM_STACK_DEFAULT_FLAGS. While here,

Re: [PATCH 1/1] powerpc/kernel: Enables memory hot-remove after reboot on pseries guests

2020-03-03 Thread Bharata B Rao
On Fri, Feb 28, 2020 at 11:36 AM Leonardo Bras wrote: > > While providing guests, it's desirable to resize it's memory on demand. > > By now, it's possible to do so by creating a guest with a small base > memory, hot-plugging all the rest, and using 'movable_node' kernel > command-line parameter,

RE: [PATCH v3 15/27] powerpc/powernv/pmem: Add support for near storage commands

2020-03-03 Thread Alastair D'Silva
On Mon, 2020-03-02 at 10:42 -0800, Dan Williams wrote: > On Mon, Mar 2, 2020 at 9:59 AM Frederic Barrat > wrote: > > > > > > Le 21/02/2020 à 04:27, Alastair D'Silva a écrit : > > > From: Alastair D'Silva > > > > > > Similar to the previous patch, this adds support for near storage > > >

[PATCH v2 6/6] asm-generic/tlb: avoid potential double flush

2020-03-03 Thread Santosh Sivaraj
From: Peter Zijlstra commit 0758cd8304942292e95a0f750c374533db378b32 upstream. Aneesh reported that: tlb_flush_mmu() tlb_flush_mmu_tlbonly() tlb_flush() <-- #1 tlb_flush_mmu_free() tlb_table_flush()

[PATCH v2 5/6] mm/mmu_gather: invalidate TLB correctly on batch allocation failure and flush

2020-03-03 Thread Santosh Sivaraj
From: Peter Zijlstra commit 0ed1325967ab5f7a4549a2641c6ebe115f76e228 upstream. Architectures for which we have hardware walkers of Linux page table should flush TLB on mmu gather batch allocation failures and batch flush. Some architectures like POWER supports multiple translation modes (hash

[PATCH v2 4/6] powerpc/mmu_gather: enable RCU_TABLE_FREE even for !SMP case

2020-03-03 Thread Santosh Sivaraj
From: "Aneesh Kumar K.V" commit 12e4d53f3f04e81f9e83d6fc10edc7314ab9f6b9 upstream. Patch series "Fixup page directory freeing", v4. This is a repost of patch series from Peter with the arch specific changes except ppc64 dropped. ppc64 changes are added here because we are redoing the patch

[PATCH v2 3/6] asm-generic/tlb, arch: Invert CONFIG_HAVE_RCU_TABLE_INVALIDATE

2020-03-03 Thread Santosh Sivaraj
From: Peter Zijlstra commit 96bc9567cbe112e9320250f01b9c060c882e8619 upstream. Make issuing a TLB invalidate for page-table pages the normal case. The reason is twofold: - too many invalidates is safer than too few, - most architectures use the linux page-tables natively and would thus

[PATCH v2 2/6] asm-generic/tlb: Track which levels of the page tables have been cleared

2020-03-03 Thread Santosh Sivaraj
From: Will Deacon commit a6d60245d6d9b1caf66b0d94419988c4836980af upstream It is common for architectures with hugepage support to require only a single TLB invalidation operation per hugepage during unmap(), rather than iterating through the mapping at a PAGE_SIZE increment. Currently,

[PATCH v2 1/6] asm-generic/tlb: Track freeing of page-table directories in struct mmu_gather

2020-03-03 Thread Santosh Sivaraj
From: Peter Zijlstra commit 22a61c3c4f1379ef8b0ce0d5cb78baf3178950e2 upstream Some architectures require different TLB invalidation instructions depending on whether it is only the last-level of page table being changed, or whether there are also changes to the intermediate (directory) entries

[PATCH v2 0/6] Memory corruption may occur due to incorrent tlb flush

2020-03-03 Thread Santosh Sivaraj
The TLB flush optimisation (a46cc7a90f: powerpc/mm/radix: Improve TLB/PWC flushes) may result in random memory corruption. Any concurrent page-table walk could end up with a Use-after-Free. Even on UP this might give issues, since mmu_gather is preemptible these days. An interrupt or preempted

Re: [PATCH v3 13/27] powerpc/powernv/pmem: Read the capability registers & wait for device ready

2020-03-03 Thread Alastair D'Silva
On Mon, 2020-03-02 at 18:51 +0100, Frederic Barrat wrote: > > Le 21/02/2020 à 04:27, Alastair D'Silva a écrit : > > From: Alastair D'Silva > > > > This patch reads timeouts & firmware version from the controller, > > and > > uses those timeouts to wait for the controller to report that it is >

Re: [PATCH v3 26/27] powerpc/powernv/pmem: Expose the firmware version in sysfs

2020-03-03 Thread Alastair D'Silva
On Mon, 2020-03-02 at 18:35 +1100, Andrew Donnellan wrote: > On 21/2/20 2:27 pm, Alastair D'Silva wrote: > > From: Alastair D'Silva > > > > This information will be used by ndctl in userspace to help users > > identify > > the device. > > You should include the information from the subject line

[PATCH v2] ima: add a new CONFIG for loading arch-specific policies

2020-03-03 Thread Nayna Jain
Every time a new architecture defines the IMA architecture specific functions - arch_ima_get_secureboot() and arch_ima_get_policy(), the IMA include file needs to be updated. To avoid this "noise", this patch defines a new IMA Kconfig IMA_SECURE_AND_OR_TRUSTED_BOOT option, allowing the different

[PATCH v4 5/5] libnvdimm/region: Introduce an 'align' attribute

2020-03-03 Thread Dan Williams
The align attribute applies an alignment constraint for namespace creation in a region. Whereas the 'align' attribute of a namespace applied alignment padding via an info block, the 'align' attribute applies alignment constraints to the free space allocation. The default for 'align' is the

[PATCH v4 4/5] libnvdimm/region: Introduce NDD_LABELING

2020-03-03 Thread Dan Williams
The NDD_ALIASING flag is used to indicate where pmem capacity might alias with blk capacity and require labeling. It is also used to indicate whether the DIMM supports labeling. Separate this latter capability into its own flag so that the NDD_ALIASING flag is scoped to true aliased

[PATCH v4 3/5] libnvdimm/namespace: Enforce memremap_compat_align()

2020-03-03 Thread Dan Williams
The pmem driver on PowerPC crashes with the following signature when instantiating misaligned namespaces that map their capacity via memremap_pages(). BUG: Unable to handle kernel data access at 0xc00100040600 Faulting instruction address: 0xc0090790 NIP [c0090790]

[PATCH v4 2/5] libnvdimm/pfn: Prevent raw mode fallback if pfn-infoblock valid

2020-03-03 Thread Dan Williams
The EOPNOTSUPP return code from the pmem driver indicates that the namespace has a configuration that may be valid, but the current kernel does not support it. Expand this to all of the nd_pfn_validate() error conditions after the infoblock has been verified as self consistent. This prevents

[PATCH v4 1/5] mm/memremap_pages: Introduce memremap_compat_align()

2020-03-03 Thread Dan Williams
The "sub-section memory hotplug" facility allows memremap_pages() users like libnvdimm to compensate for hardware platforms like x86 that have a section size larger than their hardware memory mapping granularity. The compensation that sub-section support affords is being tolerant of physical

[PATCH v4 0/5] libnvdimm: Cross-arch compatible namespace alignment

2020-03-03 Thread Dan Williams
Changes since v3 [1]: - Collect Aneesh's Reviewed-by for Patch1-Patch3 - Add commentary to "libnvdimm/namespace: Enforce memremap_compat_align()" to clarify alignment validation and why start_pad is deprecated (Aneesh) [1]:

Re: [PATCH net-next 00/23] Clean driver, module and FW versions

2020-03-03 Thread David Miller
From: Leon Romanovsky Date: Sun, 1 Mar 2020 16:44:33 +0200 > From: Leon Romanovsky > > Hi, > > This is second batch of the series which removes various static versions > in favour of globaly defined Linux kernel version. > > The first part with better cover letter can be found here >

Re: [PATCH V14] mm/debug: Add tests validating architecture page table helpers

2020-03-03 Thread Qian Cai
60.419009][C8] softirqs last disabled at (2896753): [] irq_exit+0x16c/0x1d0 [ 60.419024][C8] CPU: 8 PID: 1 Comm: swapper/0 Not tainted 5.6.0-rc4-next- 20200303+ #7 [ 60.419055][C8] NIP: c103dc14 LR: c103db0c CTR: [ 60.419076][C8] REGS: c0003

[PATCH v3] powerpc: Replace setup_irq() by request_irq()

2020-03-03 Thread afzal mohammed
request_irq() is preferred over setup_irq(). Invocations of setup_irq() occur after memory allocators are ready. Per tglx[1], setup_irq() existed in olden days when allocators were not ready by the time early interrupts were initialized. Hence replace setup_irq() by request_irq(). [1]

Re: [PATCH v3 14/18] docs: powerpc: convert vcpudispatch_stats.txt to ReST

2020-03-03 Thread Michael Ellerman
Mauro Carvalho Chehab writes: > - Add a SPDX header; > - Use standard markup for document title; > - Adjust identation on lists and add blank lines where > needed; > - Add it to the powerpc index.rst file. > > Signed-off-by: Mauro Carvalho Chehab > --- > Documentation/powerpc/index.rst

[PATCH v2] powerpc/mm: Fix missing KUAP disable in flush_coherent_icache()

2020-03-03 Thread Michael Ellerman
We received a report of strange kernel faults which turned out to be due to a missing KUAP disable in flush_coherent_icache() called from flush_icache_range(). The fault looks like: Kernel attempted to access user page (7fffc30d9c00) - exploit attempt? (uid: 1009) BUG: Unable to handle

Re: [PATCH] powerpc/mm: Fix missing KUAP disable in flush_coherent_icache()

2020-03-03 Thread Michael Ellerman
Christophe Leroy writes: > Le 03/03/2020 à 13:59, Michael Ellerman a écrit : >> We received a report of strange kernel faults which turned out to be >> due to a missing KUAP disable in flush_coherent_icache() called >> from flush_icache_range(). >> >> The fault looks like: >> >>Kernel

Re: [RFC PATCH v1] powerpc/prom_init: disable XIVE in Secure VM.

2020-03-03 Thread Greg Kurz
On Tue, 3 Mar 2020 09:02:05 -0800 Ram Pai wrote: > On Tue, Mar 03, 2020 at 07:50:08AM +0100, Cédric Le Goater wrote: > > On 3/3/20 12:32 AM, David Gibson wrote: > > > On Fri, Feb 28, 2020 at 11:54:04PM -0800, Ram Pai wrote: > > >> XIVE is not correctly enabled for Secure VM in the KVM Hypervisor

Re: [PATCH v3 02/14] powerpc: Define new SRR1 bits for a future ISA version

2020-03-03 Thread Alistair Popple
On Wednesday, 26 February 2020 3:07:04 PM AEDT Jordan Niethe wrote: > Add the BOUNDARY SRR1 bit definition for when the cause of an alignment > exception is a prefixed instruction that crosses a 64-byte boundary. > Add the PREFIXED SRR1 bit definition for exceptions caused by prefixed >

Re: [PATCH v3 01/14] powerpc: Enable Prefixed Instructions

2020-03-03 Thread Alistair Popple
> But hmm, the dt_cpu_ftrs parsing should be picking those up and setting > them by default I would think (or maybe not because you don't expect > FSCR bit if OS support is not required). Right - the generic dt_cpu_ftrs didn't do the FSCR enablement which I assume is because if OS support is

Re: [PATCH] powerpc/64: BE option to use ELFv2 ABI for big endian kernels

2020-03-03 Thread Segher Boessenkool
Hi! On Tue, Mar 03, 2020 at 11:45:27AM +1000, Nicholas Piggin wrote: > Provide an option to use ELFv2 ABI for big endian builds. This works on > GCC and clang (since 2014). it is is not officially supported by the GNU > toolchain, but it can give some useful advantages of the ELFv2 ABI for > BE

RE: [RFC PATCH v1] powerpc/prom_init: disable XIVE in Secure VM.

2020-03-03 Thread Ram Pai
On Tue, Mar 03, 2020 at 08:08:51PM +0100, Cédric Le Goater wrote: > >>> 4) I'm guessing the problem with XIVE in SVM mode is that XIVE needs > >>> to write to event queues in guest memory, which would have to be > >>> explicitly shared for secure mode. That's true whether it's KVM >

Re: [PATCH] macintosh: windfarm: fix MODINFO regression

2020-03-03 Thread Wolfram Sang
> > sound/aoa/codecs/onyx.c > > sound/aoa/codecs/tas.c > > These are loaded explicitly via request_module (as snd-aoa-codec-%s). Good to know, thanks! signature.asc Description: PGP signature

Re: [EXTERNAL] Re: [RFC PATCH v1] powerpc/prom_init: disable XIVE in Secure VM.

2020-03-03 Thread Cédric Le Goater
>> BTW: I figured, I dont need this intermin patch to disable xive for >> secure VM. Just doing "svm=on xive=off" on the kernel command line is >> sufficient for now. * >> > > No it is not. If the hypervisor doesn't propose XIVE (ie. ic-mode=xive > on the QEMU command line), the kernel

Re: [EXTERNAL] Re: [RFC PATCH v1] powerpc/prom_init: disable XIVE in Secure VM.

2020-03-03 Thread Cédric Le Goater
>>> 4) I'm guessing the problem with XIVE in SVM mode is that XIVE needs >>> to write to event queues in guest memory, which would have to be >>> explicitly shared for secure mode. That's true whether it's KVM >>> or qemu accessing the guest memory, so kernel_irqchip=on/off is

Re: [PATCH] macintosh: windfarm: fix MODINFO regression

2020-03-03 Thread Andreas Schwab
On Mär 03 2020, Wolfram Sang wrote: > sound/aoa/codecs/onyx.c > sound/aoa/codecs/tas.c These are loaded explicitly via request_module (as snd-aoa-codec-%s). Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for

RE: [RFC PATCH v1] powerpc/prom_init: disable XIVE in Secure VM.

2020-03-03 Thread Ram Pai
On Tue, Mar 03, 2020 at 06:45:20PM +0100, Greg Kurz wrote: > On Tue, 3 Mar 2020 09:02:05 -0800 > Ram Pai wrote: > > > On Tue, Mar 03, 2020 at 07:50:08AM +0100, Cédric Le Goater wrote: > > > On 3/3/20 12:32 AM, David Gibson wrote: > > > > On Fri, Feb 28, 2020 at 11:54:04PM -0800, Ram Pai wrote: >

Re: [PATCH v3 18/27] powerpc/powernv/pmem: Add controller dump IOCTLs

2020-03-03 Thread Frederic Barrat
Le 21/02/2020 à 04:27, Alastair D'Silva a écrit : From: Alastair D'Silva This patch adds IOCTLs to allow userspace to request & fetch dumps of the internal controller state. This is useful during debugging or when a fatal error on the controller has occurred. Signed-off-by: Alastair

Re: [RFC 2/3] mm/vma: Introduce VM_ACCESS_FLAGS

2020-03-03 Thread Vlastimil Babka
On 3/2/20 7:47 AM, Anshuman Khandual wrote: > There are many places where all basic VMA access flags (read, write, exec) > are initialized or checked against as a group. One such example is during > page fault. Existing vma_is_accessible() wrapper already creates the notion > of VMA accessibility

Re: [RFC 1/3] mm/vma: Define a default value for VM_DATA_DEFAULT_FLAGS

2020-03-03 Thread Vlastimil Babka
On 3/2/20 7:47 AM, Anshuman Khandual wrote: > There are many platforms with exact same value for VM_DATA_DEFAULT_FLAGS > This creates a default value for VM_DATA_DEFAULT_FLAGS in line with the > existing VM_STACK_DEFAULT_FLAGS. While here, also define some more macros > with standard VMA access

RE: [RFC PATCH v1] powerpc/prom_init: disable XIVE in Secure VM.

2020-03-03 Thread Ram Pai
On Tue, Mar 03, 2020 at 07:50:08AM +0100, Cédric Le Goater wrote: > On 3/3/20 12:32 AM, David Gibson wrote: > > On Fri, Feb 28, 2020 at 11:54:04PM -0800, Ram Pai wrote: > >> XIVE is not correctly enabled for Secure VM in the KVM Hypervisor yet. > >> > >> Hence Secure VM, must always default to

Re: [RFC 02/11] perf/core: Data structure to present hazard data

2020-03-03 Thread Ravi Bangoria
On 3/2/20 8:18 PM, Mark Rutland wrote: diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h index 377d794d3105..ff252618ca93 100644 --- a/include/uapi/linux/perf_event.h +++ b/include/uapi/linux/perf_event.h @@ -142,8 +142,9 @@ enum perf_event_sample_format {

Re: [RFC 02/11] perf/core: Data structure to present hazard data

2020-03-03 Thread Ravi Bangoria
On 3/2/20 8:24 PM, Mark Rutland wrote: @@ -870,6 +871,13 @@ enum perf_event_type { * { u64 phys_addr;} && PERF_SAMPLE_PHYS_ADDR * { u64 size; *char data[size]; } && PERF_SAMPLE_AUX +*

[PATCH v3 14/18] docs: powerpc: convert vcpudispatch_stats.txt to ReST

2020-03-03 Thread Mauro Carvalho Chehab
- Add a SPDX header; - Use standard markup for document title; - Adjust identation on lists and add blank lines where needed; - Add it to the powerpc index.rst file. Signed-off-by: Mauro Carvalho Chehab --- Documentation/powerpc/index.rst | 1 + ...ispatch_stats.txt =>

Re: [PATCH] powerpc/mm: Fix missing KUAP disable in flush_coherent_icache()

2020-03-03 Thread Christophe Leroy
Le 03/03/2020 à 13:59, Michael Ellerman a écrit : We received a report of strange kernel faults which turned out to be due to a missing KUAP disable in flush_coherent_icache() called from flush_icache_range(). The fault looks like: Kernel attempted to access user page (7fffc30d9c00) -

[PATCH] powerpc/mm: Fix missing KUAP disable in flush_coherent_icache()

2020-03-03 Thread Michael Ellerman
We received a report of strange kernel faults which turned out to be due to a missing KUAP disable in flush_coherent_icache() called from flush_icache_range(). The fault looks like: Kernel attempted to access user page (7fffc30d9c00) - exploit attempt? (uid: 1009) BUG: Unable to handle

[Bug 199471] [Bisected][Regression] windfarm_pm* no longer gets automatically loaded when CONFIG_I2C_POWERMAC=y is set

2020-03-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=199471 --- Comment #19 from Wolfram Sang (w...@the-dreams.de) --- Well, yes, the lm75 code gets loaded yet it is not clear to me if the device is now created by DT or not. Well, we will see... Patch sent out: http://patchwork.ozlabs.org/patch/1248349/

[PATCH] macintosh: windfarm: fix MODINFO regression

2020-03-03 Thread Wolfram Sang
Commit af503716ac14 made sure OF devices get an OF style modalias with I2C events. It assumed all in-tree users were converted, yet it missed some Macintosh drivers. Add an OF module device table for all windfarm drivers to make them automatically load again. Fixes: af503716ac14 ("i2c: core:

Re: [PATCH v4 1/8] ASoC: dt-bindings: fsl_asrc: Change asrc-width to asrc-format

2020-03-03 Thread Mark Brown
On Tue, Mar 03, 2020 at 11:59:30AM +0800, Shengjiu Wang wrote: > On Tue, Mar 3, 2020 at 9:43 AM Rob Herring wrote: > > > - - fsl,asrc-width : Defines a mutual sample width used by DPCM Back > > > Ends. > > > + - fsl,asrc-format : Defines a mutual sample format used by DPCM Back > > > +

Re: [PATCH 2/2] powerpc/powernv: Wire up OPAL address lookups

2020-03-03 Thread Michael Ellerman
Nicholas Piggin writes: > Use ARCH_HAS_ADDRESS_LOOKUP to look up the opal symbol table. This > allows crashes and xmon debugging to print firmware symbols. > > Oops: System Reset, sig: 6 [#1] > LE PAGE_SIZE=64K MMU=Radix SMP NR_CPUS=2048 NUMA PowerNV > Modules linked in: > CPU: 0 PID: 0

Re: [PATCH] macintosh: therm_windtunnel: fix regression when instantiating devices

2020-03-03 Thread Michael Ellerman
Wolfram Sang writes: > On Tue, Feb 25, 2020 at 03:12:29PM +0100, Wolfram Sang wrote: >> Removing attach_adapter from this driver caused a regression for at >> least some machines. Those machines had the sensors described in their >> DT, too, so they didn't need manual creation of the sensor

Re: [PATCH v3 17/27] powerpc/powernv/pmem: Implement the Read Error Log command

2020-03-03 Thread Frederic Barrat
Le 21/02/2020 à 04:27, Alastair D'Silva a écrit : From: Alastair D'Silva The read error log command extracts information from the controller's internal error log. This patch exposes this information in 2 ways: - During probe, if an error occurs & a log is available, print it to the

Re: [PATCH 2/6] powerpc: kvm: no need to check return value of debugfs_create functions

2020-03-03 Thread Michael Ellerman
Greg Kroah-Hartman writes: > On Tue, Mar 03, 2020 at 08:45:23PM +1100, Michael Ellerman wrote: >> Greg Kroah-Hartman writes: >> > On Tue, Mar 03, 2020 at 06:46:23PM +1100, Michael Ellerman wrote: >> >> Greg Kroah-Hartman writes: >> >> > When calling debugfs functions, there is no need to ever

Re: eh_frame confusion

2020-03-03 Thread Michael Ellerman
"Naveen N. Rao" writes: > Rasmus Villemoes wrote: >> I'm building a ppc32 kernel, and noticed that after upgrading from gcc-7 >> to gcc-8 all object files now end up having .eh_frame section. For >> vmlinux, that's not a problem, because they all get discarded in >>

Re: [PATCH 2/6] powerpc: kvm: no need to check return value of debugfs_create functions

2020-03-03 Thread Greg Kroah-Hartman
On Tue, Mar 03, 2020 at 08:45:23PM +1100, Michael Ellerman wrote: > Greg Kroah-Hartman writes: > > On Tue, Mar 03, 2020 at 06:46:23PM +1100, Michael Ellerman wrote: > >> Greg Kroah-Hartman writes: > >> > When calling debugfs functions, there is no need to ever check the > >> > return value. The

Re: [PATCH 6/6] powerpc: powernv: no need to check return value of debugfs_create functions

2020-03-03 Thread Michael Ellerman
"Oliver O'Halloran" writes: > On Mon, Feb 10, 2020 at 12:12 AM Greg Kroah-Hartman > wrote: >> >> When calling debugfs functions, there is no need to ever check the >> return value. The function can work or not, but the code logic should >> never do something different based on this. > > For

Re: [PATCH v3 3/7] x86/mm: Thread pgprot_t through init_memory_mapping()

2020-03-03 Thread Michal Hocko
On Fri 21-02-20 11:24:59, Logan Gunthorpe wrote: > In prepartion to support a pgprot_t argument for arch_add_memory(). > > It's required to move the prototype of init_memory_mapping() seeing > the original location came before the definition of pgprot_t. > > Cc: Thomas Gleixner > Cc: Ingo

Re: [PATCH v3 2/7] mm/memory_hotplug: Rename mhp_restrictions to mhp_params

2020-03-03 Thread Michal Hocko
On Fri 21-02-20 11:24:58, Logan Gunthorpe wrote: > The mhp_restrictions struct really doesn't specify anything resembling > a restriction anymore so rename it to be mhp_params as it is a list > of extended parameters. > > Signed-off-by: Logan Gunthorpe Acked-by: Michal Hocko > --- >

Re: eh_frame confusion

2020-03-03 Thread Rasmus Villemoes
On 02/03/2020 18.32, Naveen N. Rao wrote: > Naveen N. Rao wrote: >> Michael opened a task to look into this recently and I had spent some >> time last week on this. The original commit/discussion adding >> -fno-dwarf2-cfi-asm refers to R_PPC64_REL32 relocations not being >> handled by our module

Re: [PATCH v3 1/7] mm/memory_hotplug: Drop the flags field from struct mhp_restrictions

2020-03-03 Thread Michal Hocko
On Fri 21-02-20 11:24:57, Logan Gunthorpe wrote: > This variable is not used anywhere and should therefore be removed > from the structure. > > Signed-off-by: Logan Gunthorpe > Reviewed-by: David Hildenbrand Acked-by: Michal Hocko > --- > include/linux/memory_hotplug.h | 2 -- > 1 file

Re: [PATCH 2/6] powerpc: kvm: no need to check return value of debugfs_create functions

2020-03-03 Thread Michael Ellerman
Greg Kroah-Hartman writes: > On Tue, Mar 03, 2020 at 06:46:23PM +1100, Michael Ellerman wrote: >> Greg Kroah-Hartman writes: >> > When calling debugfs functions, there is no need to ever check the >> > return value. The function can work or not, but the code logic should >> > never do something

Re: [PATCH v3 16/27] powerpc/powernv/pmem: Register a character device for userspace to interact with

2020-03-03 Thread Frederic Barrat
Le 21/02/2020 à 04:27, Alastair D'Silva a écrit : From: Alastair D'Silva This patch introduces a character device (/dev/ocxl-scmX) which further patches will use to interact with userspace. Signed-off-by: Alastair D'Silva --- arch/powerpc/platforms/powernv/pmem/ocxl.c| 116

[PATCH v2 -next] powerpc/pmac/smp: drop unnecessary volatile qualifier

2020-03-03 Thread YueHaibing
core99_l2_cache/core99_l3_cache no need to mark as volatile, just remove it. Signed-off-by: YueHaibing --- v2: remove 'volatile' qualifier --- arch/powerpc/platforms/powermac/smp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/platforms/powermac/smp.c

Re: [PATCH v2 -next] powerpc/pmac/smp: drop unnecessary volatile qualifier

2020-03-03 Thread Christophe Leroy
Le 03/03/2020 à 09:56, YueHaibing a écrit : core99_l2_cache/core99_l3_cache no need to mark as volatile, just remove it. Signed-off-by: YueHaibing Reviewed-by: Christophe Leroy --- v2: remove 'volatile' qualifier --- arch/powerpc/platforms/powermac/smp.c | 4 ++-- 1 file changed, 2

Re: [PATCH 2/6] powerpc: kvm: no need to check return value of debugfs_create functions

2020-03-03 Thread Greg Kroah-Hartman
On Tue, Mar 03, 2020 at 06:46:23PM +1100, Michael Ellerman wrote: > Greg Kroah-Hartman writes: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should > > never do something different based on this. > >