Re: [PATCH v2 3/4] powerpc/memhotplug: Make lmb size 64bit

2020-10-06 Thread Michael Ellerman
Nathan Lynch writes: > "Aneesh Kumar K.V" writes: >> @@ -322,12 +322,16 @@ static int pseries_remove_mem_node(struct device_node >> *np) >> /* >> * Find the base address and size of the memblock >> */ >> -regs = of_get_property(np, "reg", NULL); >> -if (!regs) >> +

[PATCH v2] powerpc/mm: Update tlbiel loop on POWER10

2020-10-06 Thread Aneesh Kumar K.V
With POWER10, single tlbiel instruction invalidates all the congruence class of the TLB and hence we need to issue only one tlbiel with SET=0. Signed-off-by: Aneesh Kumar K.V --- arch/powerpc/kvm/book3s_hv.c | 7 ++- arch/powerpc/kvm/book3s_hv_builtin.c | 11 ++-

Re: [PATCH v2 1/2] powerpc/rtas: Restrict RTAS requests from userspace

2020-10-06 Thread Andrew Donnellan
On 26/8/20 11:53 pm, Sasha Levin wrote: How should we proceed with this patch? mpe: I believe we came to the conclusion that we shouldn't put this in stable just yet? -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

[PATCH 2/2] powerpc/pseries/eeh: Fix use of uninitialised variable

2020-10-06 Thread Oliver O'Halloran
If the RTAS call to query the PE address for a device fails we jump the err: label where an error message is printed along with the return code. However, the printed return code is from the "ret" variable which isn't set at that point since we assigned the result to "addr" instead. Fix this by

[PATCH 1/2] powerpc/eeh: Delete eeh_pe->config_addr

2020-10-06 Thread Oliver O'Halloran
The eeh_pe->config_addr field was supposed to be removed in commit 35d64734b643 ("powerpc/eeh: Clean up PE addressing") which made it largely unused. Finish the job. Signed-off-by: Oliver O'Halloran --- mpe: the Fixes SHA is from ppc/next, fold it into that if you want. ---

Re: [PATCH v5] powerpc/powernv/elog: Fix race while processing OPAL error log event.

2020-10-06 Thread Michael Ellerman
On Tue, 6 Oct 2020 23:20:51 +1100, Michael Ellerman wrote: > Every error log reported by OPAL is exported to userspace through a > sysfs interface and notified using kobject_uevent(). The userspace > daemon (opal_errd) then reads the error log and acknowledges the error > log is saved safely to

Re: [PATCH v4] pseries/hotplug-memory: hot-add: skip redundant LMB lookup

2020-10-06 Thread Michael Ellerman
On Wed, 16 Sep 2020 09:51:22 -0500, Scott Cheloha wrote: > During memory hot-add, dlpar_add_lmb() calls memory_add_physaddr_to_nid() > to determine which node id (nid) to use when later calling __add_memory(). > > This is wasteful. On pseries, memory_add_physaddr_to_nid() finds an > appropriate

Re: [PATCH -next] powerpc/papr_scm: Fix warnings about undeclared variable

2020-10-06 Thread Michael Ellerman
On Fri, 18 Sep 2020 08:59:51 +, Wang Wensheng wrote: > Build the kernel with 'make C=2': > arch/powerpc/platforms/pseries/papr_scm.c:825:1: warning: symbol > 'dev_attr_perf_stats' was not declared. Should it be static? Applied to powerpc/next. [1/1] powerpc/papr_scm: Fix warnings about

Re: [PATCH v2 00/11] Optimization to improve CPU online/offline on Powerpc

2020-10-06 Thread Michael Ellerman
On Mon, 21 Sep 2020 15:26:42 +0530, Srikar Dronamraju wrote: > Here are some optimizations and fixes to make CPU online/offline > faster and hence result in faster bootup. > > Its based on top of my v5 coregroup support patchset. >

Re: [PATCH v2 1/9] powerpc/eeh: Rework EEH initialisation

2020-10-06 Thread Michael Ellerman
On Fri, 18 Sep 2020 19:30:42 +1000, Oliver O'Halloran wrote: > Drop the EEH register / unregister ops thing and have the platform pass the > ops structure into eeh_init() directly. This takes one initcall out of the > EEH setup path and it means we're only doing EEH setup on the platforms > which

Re: [PATCH v2 1/2] powerpc: untangle cputable mce include

2020-10-06 Thread Michael Ellerman
On Wed, 16 Sep 2020 13:02:33 +1000, Nicholas Piggin wrote: > Having cputable.h include mce.h means it pulls in a bunch of low level > headers (e.g., synch.h) which then can't use CPU_FTR_ definitions. Applied to powerpc/next. [1/2] powerpc: untangle cputable mce include

Re: [PATCH] powerpc/pseries: add new branch prediction security bits for link stack

2020-10-06 Thread Michael Ellerman
On Tue, 25 Aug 2020 17:56:12 +1000, Nicholas Piggin wrote: > The hypervisor interface has defined branch prediction security bits for > handling the link stack. Wire them up. Applied to powerpc/next. [1/1] powerpc/pseries: add new branch prediction security bits for link stack

Re: [PATCH 1/6] powerpc/64: fix irq replay missing preempt

2020-10-06 Thread Michael Ellerman
On Tue, 15 Sep 2020 21:46:45 +1000, Nicholas Piggin wrote: > Prior to commit 3282a3da25bd ("powerpc/64: Implement soft interrupt > replay in C"), replayed interrupts returned by the regular interrupt > exit code, which performs preemption in case an interrupt had set > need_resched. > > This

Re: [PATCH] powerpc: switch 85xx defconfigs from legacy ide to libata

2020-10-06 Thread Michael Ellerman
On Thu, 24 Sep 2020 06:13:10 +0200, Christoph Hellwig wrote: > Switch the 85xx defconfigs from the soon to be removed legacy ide > driver to libata. Applied to powerpc/next. [1/1] powerpc: switch 85xx defconfigs from legacy ide to libata

Re: [PATCH v2] powerpc/tm: Save and restore AMR on treclaim and trechkpt

2020-10-06 Thread Michael Ellerman
On Sat, 19 Sep 2020 12:00:25 -0300, Gustavo Romero wrote: > Althought AMR is stashed in the checkpoint area, currently we don't save > it to the per thread checkpoint struct after a treclaim and so we don't > restore it either from that struct when we trechkpt. As a consequence when > the

Re: [PATCH] powerpc: PPC_SECURE_BOOT should not require PowerNV

2020-10-06 Thread Michael Ellerman
On Thu, 24 Sep 2020 11:49:22 +1000, Daniel Axtens wrote: > In commit 61f879d97ce4 ("powerpc/pseries: Detect secure and trusted > boot state of the system.") we taught the kernel how to understand the > secure-boot parameters used by a pseries guest. > > However, CONFIG_PPC_SECURE_BOOT still

Re: [PATCH v3] pseries/hotplug-memory: hot-add: skip redundant LMB lookup

2020-10-06 Thread Michael Ellerman
On Tue, 15 Sep 2020 14:46:47 -0500, Scott Cheloha wrote: > During memory hot-add, dlpar_add_lmb() calls memory_add_physaddr_to_nid() > to determine which node id (nid) to use when later calling __add_memory(). > > This is wasteful. On pseries, memory_add_physaddr_to_nid() finds an > appropriate

Re: [PATCH v4] pseries/hotplug-memory: hot-add: skip redundant LMB lookup

2020-10-06 Thread Michael Ellerman
On Wed, 16 Sep 2020 09:51:22 -0500, Scott Cheloha wrote: > During memory hot-add, dlpar_add_lmb() calls memory_add_physaddr_to_nid() > to determine which node id (nid) to use when later calling __add_memory(). > > This is wasteful. On pseries, memory_add_physaddr_to_nid() finds an > appropriate

Re: [PATCH v2 1/2] powerpc/rtas: Restrict RTAS requests from userspace

2020-10-06 Thread Michael Ellerman
On Thu, 20 Aug 2020 14:45:12 +1000, Andrew Donnellan wrote: > A number of userspace utilities depend on making calls to RTAS to retrieve > information and update various things. > > The existing API through which we expose RTAS to userspace exposes more > RTAS functionality than we actually need,

Re: [PATCH V2] powerpc/perf: Exclude pmc5/6 from the irrelevant PMU group constraints

2020-10-06 Thread Michael Ellerman
On Mon, 21 Sep 2020 03:10:04 -0400, Athira Rajeev wrote: > PMU counter support functions enforces event constraints for group of > events to check if all events in a group can be monitored. Incase of > event codes using PMC5 and PMC6 ( 500fa and 600f4 respectively ), > not all constraints are

Re: linux-next: Fixes tag needs some work in the powerpc tree

2020-10-06 Thread Michael Ellerman
Stephen Rothwell writes: > Hi all, > > In commit > > 3b6c3adbb2fa ("powerpc/perf: Exclude pmc5/6 from the irrelevant PMU group > constraints") > > Fixes tag > > Fixes: 7ffd948 ("powerpc/perf: factor out power8 pmu functions") > > has these problem(s): > > - SHA1 should be at least 12

[powerpc:next] BUILD REGRESSION 72cdd117c449896c707fc6cfe5b90978160697d0

2020-10-06 Thread kernel test robot
allmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig x86_64 randconfig-a004-20201006 x86_64 randconfig-a002-20201006 x86_64

[powerpc:merge] BUILD SUCCESS d1def5df359f3f1882cc29d8baa5cd2a4861a6c6

2020-10-06 Thread kernel test robot
allnoconfig x86_64 randconfig-a004-20201006 x86_64 randconfig-a002-20201006 x86_64 randconfig-a001-20201006 x86_64 randconfig-a005-20201006 x86_64 randconfig-a003-20201006 x86_64 randconfig

[powerpc:next-test 76/183] arch/powerpc/kernel/vdso32/gettimeofday.S:40: Error: syntax error; found `@', expected `,'

2020-10-06 Thread kernel test robot
Hi Michael, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next-test head: 72cdd117c449896c707fc6cfe5b90978160697d0 commit: 231b232df8f67e7d37af01259c21f2a131c3911e [76/183] powerpc/64: Make VDSO32 track COMPAT on 64-bit

Re: [PATCH v3 2/2] ASoC: dt-bindings: fsl_xcvr: Add document for XCVR

2020-10-06 Thread Rob Herring
On Tue, Sep 29, 2020 at 12:19:27PM +0300, Viorel Suman (OSS) wrote: > From: Viorel Suman > > XCVR (Audio Transceiver) is a new IP module found on i.MX8MP. > > Signed-off-by: Viorel Suman > --- > .../devicetree/bindings/sound/fsl,xcvr.yaml| 103 > + > 1 file

linux-next: Fixes tag needs some work in the powerpc tree

2020-10-06 Thread Stephen Rothwell
Hi all, In commit 3b6c3adbb2fa ("powerpc/perf: Exclude pmc5/6 from the irrelevant PMU group constraints") Fixes tag Fixes: 7ffd948 ("powerpc/perf: factor out power8 pmu functions") has these problem(s): - SHA1 should be at least 12 digits long Can be fixed by setting core.abbrev

[PATCH v5] powerpc/powernv/elog: Fix race while processing OPAL error log event.

2020-10-06 Thread Michael Ellerman
From: Mahesh Salgaonkar Every error log reported by OPAL is exported to userspace through a sysfs interface and notified using kobject_uevent(). The userspace daemon (opal_errd) then reads the error log and acknowledges the error log is saved safely to disk. Once acknowledged the kernel removes

[PATCH 1/2] powerpc/32s: Rename head_32.S to head_book3s_32.S

2020-10-06 Thread Christophe Leroy
Unlike PPC64 which had a single head_64.S, PPC32 are multiple ones. There is the head_32.S, selected by default based on the value of BITS and overridden based on some CONFIG_ values. This leads to thinking that it may be selected by different types of PPC32 platform but indeed it ends up being

[PATCH 2/2] powerpc/32s: Remove #ifdef CONFIG_PPC_BOOK3S_32 in head_book3s_32.S

2020-10-06 Thread Christophe Leroy
head_book3s_32.S is only built when CONFIG_PPC_BOOK3S_32 is selected. Remove all conditions based on CONFIG_PPC_BOOK3S_32 in the file. Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/head_book3s_32.S | 15 --- 1 file changed, 15 deletions(-) diff --git

Re: linux-next: manual merge of the char-misc tree with the powerpc tree

2020-10-06 Thread Greg KH
On Tue, Oct 06, 2020 at 06:35:06PM +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the char-misc tree got a conflict in: > > drivers/misc/ocxl/Kconfig > > between commit: > > dde6f18a8779 ("ocxl: Don't return trigger page when allocating an > interrupt") > > from

[RFC PATCH] powerpc/mm: Support tlbiel set value of 1 on POWER10

2020-10-06 Thread Aneesh Kumar K.V
With POWER10, tlbiel invalidates all the congruence class of TLB and hence we need to issue only one tlbiel with SET=0. Update POWER10_TLB_SETS to 1 and use that in the rest of the code. Signed-off-by: Aneesh Kumar K.V --- arch/powerpc/include/asm/book3s/64/mmu-hash.h | 1 +

linux-next: manual merge of the char-misc tree with the powerpc tree

2020-10-06 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the char-misc tree got a conflict in: drivers/misc/ocxl/Kconfig between commit: dde6f18a8779 ("ocxl: Don't return trigger page when allocating an interrupt") from the powerpc tree and commit: 4b53a3c72116 ("ocxl: fix kconfig dependency warning for

[PATCH v4] powernv/elog: Fix the race while processing OPAL error log event.

2020-10-06 Thread Mahesh Salgaonkar
Every error log reported by OPAL is exported to userspace through a sysfs interface and notified using kobject_uevent(). The userspace daemon (opal_errd) then reads the error log and acknowledges it error log is saved safely to disk. Once acknowledged the kernel removes the respective sysfs file