[PATCH] powerpc: dts: p2020rdb: add missing peripherials

2021-01-14 Thread Pawel Dembicki
This patch adds dts entry for some peripherials: - i2c: temperature sensor ADT7461 - i2c: eeprom m24256 - i2c: eeprom at24c01 - i2c: pmic zl2006 - i2c: gpio expander - phy: reset pins for phy - dsa: switch vsc7385 It was required to adjust rgmii settings for enet0 because switch with dsa driver

[PATCH v2] Adds a new ioctl32 syscall for backwards compatibility layers

2021-01-14 Thread sonicadvance1
From: Ryan Houdek Problem presented: A backwards compatibility layer that allows running x86-64 and x86 processes inside of an AArch64 process. - CPU is emulated - Syscall interface is mostly passthrough - Some syscalls require patching or emulation depending on behaviour - Not viable

[PATCH] Adds a new ioctl32 syscall for backwards compatibility layers

2021-01-14 Thread sonicadvance1
From: Ryan Houdek Problem presented: A backwards compatibility layer that allows running x86-64 and x86 processes inside of an AArch64 process. - CPU is emulated - Syscall interface is mostly passthrough - Some syscalls require patching or emulation depending on behaviour - Not viable

Re: [PATCH] perf tools: Resolve symbols against debug file first

2021-01-14 Thread Namhyung Kim
Hello, On Thu, Jan 14, 2021 at 8:17 PM Michael Ellerman wrote: > > Namhyung Kim writes: > > On Wed, Jan 13, 2021 at 8:43 PM Jiri Slaby wrote: > >> > >> On 13. 01. 21, 11:46, Jiri Olsa wrote: > >> > On Wed, Jan 13, 2021 at 09:01:28AM +0100, Jiri Slaby wrote: > >> >> With LTO, there are symbols

[PATCH] powerpc/sstep: Fix array out of bound warning

2021-01-14 Thread Ravi Bangoria
Compiling kernel with -Warray-bounds throws below warning: In function 'emulate_vsx_store': warning: array subscript is above array bounds [-Warray-bounds] buf.d[2] = byterev_8(reg->d[1]); ~^~~ buf.d[3] = byterev_8(reg->d[0]); ~^~~ Fix it by converting local variable 'union

Re: [PATCH 5/6] powerpc/rtas: rename RTAS_RMOBUF_MAX to RTAS_USER_REGION_SIZE

2021-01-14 Thread Andrew Donnellan
On 15/1/21 9:00 am, Nathan Lynch wrote: RTAS_RMOBUF_MAX doesn't actually describe a "maximum" value in any sense. It represents the size of an area of memory set aside for user space to use as work areas for certain RTAS calls. Rename it to RTAS_USER_REGION, and express the value in terms of

Re: [PATCH 3/6] powerpc/rtas: remove ibm_suspend_me_token

2021-01-14 Thread Andrew Donnellan
On 15/1/21 9:00 am, Nathan Lynch wrote: There's not a compelling reason to cache the value of the token for the ibm,suspend-me function. Just look it up when needed in the RTAS syscall's special case for it. Signed-off-by: Nathan Lynch Reviewed-by: Andrew Donnellan ---

Re: [PATCH 2/6] powerpc/rtas-proc: remove unused RMO_READ_BUF_MAX

2021-01-14 Thread Andrew Donnellan
On 15/1/21 9:00 am, Nathan Lynch wrote: This constant is unused. Signed-off-by: Nathan Lynch A quick grep agrees. Reviewed-by: Andrew Donnellan --- arch/powerpc/kernel/rtas-proc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/powerpc/kernel/rtas-proc.c

Re: [PATCH 1/6] powerpc/rtas: improve ppc_rtas_rmo_buf_show documentation

2021-01-14 Thread Andrew Donnellan
On 15/1/21 8:59 am, Nathan Lynch wrote: Add kerneldoc for ppc_rtas_rmo_buf_show(), the callback for /proc/powerpc/rtas/rmo_buffer, explaining its expected use. Signed-off-by: Nathan Lynch Looks good. Reviewed-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra

Re: [PATCH 4/6] powerpc/rtas: move syscall filter setup into separate function

2021-01-14 Thread Andrew Donnellan
On 15/1/21 9:00 am, Nathan Lynch wrote: Reduce conditionally compiled sections within rtas_initialize() by moving the filter table initialization into its own function already guarded by CONFIG_PPC_RTAS_FILTER. No behavior change intended. Signed-off-by: Nathan Lynch Acked-by: Andrew

Re: [PATCH 4/6] powerpc/rtas: move syscall filter setup into separate function

2021-01-14 Thread Alexey Kardashevskiy
On 15/01/2021 09:00, Nathan Lynch wrote: Reduce conditionally compiled sections within rtas_initialize() by moving the filter table initialization into its own function already guarded by CONFIG_PPC_RTAS_FILTER. No behavior change intended. Signed-off-by: Nathan Lynch ---

Re: [PATCH 1/6] powerpc/rtas: improve ppc_rtas_rmo_buf_show documentation

2021-01-14 Thread Alexey Kardashevskiy
On 15/01/2021 08:59, Nathan Lynch wrote: Add kerneldoc for ppc_rtas_rmo_buf_show(), the callback for /proc/powerpc/rtas/rmo_buffer, explaining its expected use. Signed-off-by: Nathan Lynch --- arch/powerpc/kernel/rtas-proc.c | 11 ++- 1 file changed, 10 insertions(+), 1

Re: [PATCH 3/6] powerpc/rtas: remove ibm_suspend_me_token

2021-01-14 Thread Alexey Kardashevskiy
On 15/01/2021 09:00, Nathan Lynch wrote: There's not a compelling reason to cache the value of the token for the ibm,suspend-me function. Just look it up when needed in the RTAS syscall's special case for it. Signed-off-by: Nathan Lynch Reviewed-by: Alexey Kardashevskiy ---

Re: [PATCH 5/6] powerpc/rtas: rename RTAS_RMOBUF_MAX to RTAS_USER_REGION_SIZE

2021-01-14 Thread Alexey Kardashevskiy
On 15/01/2021 09:00, Nathan Lynch wrote: RTAS_RMOBUF_MAX doesn't actually describe a "maximum" value in any sense. It represents the size of an area of memory set aside for user space to use as work areas for certain RTAS calls. Rename it to RTAS_USER_REGION, and express the value in terms

Re: [PATCH 2/6] powerpc/rtas-proc: remove unused RMO_READ_BUF_MAX

2021-01-14 Thread Alexey Kardashevskiy
On 15/01/2021 09:00, Nathan Lynch wrote: This constant is unused. Signed-off-by: Nathan Lynch Reviewed-by: Alexey Kardashevskiy --- arch/powerpc/kernel/rtas-proc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/powerpc/kernel/rtas-proc.c b/arch/powerpc/kernel/rtas-proc.c

Re: [PATCH 6/6] powerpc/rtas: constrain user region allocation to RMA

2021-01-14 Thread Alexey Kardashevskiy
On 15/01/2021 09:00, Nathan Lynch wrote: Memory locations passed as arguments from the OS to RTAS usually need to be addressable in 32-bit mode and must reside in the Real Mode Area. On PAPR guests, the RMA starts at logical address 0 and is the first logical memory block reported in the

Re: [PATCH 10/18] arch: powerpc: Stop building and using oprofile

2021-01-14 Thread Viresh Kumar
On 14-01-21, 17:05, Viresh Kumar wrote: > The "oprofile" user-space tools don't use the kernel OPROFILE support > any more, and haven't in a long time. User-space has been converted to > the perf interfaces. > > This commits stops building oprofile for powerpc and removes any > reference to it

Re: [RFC PATCH v3 6/6] of: Add plumbing for restricted DMA pool

2021-01-14 Thread Claire Chang
On Fri, Jan 15, 2021 at 2:52 AM Florian Fainelli wrote: > > On 1/14/21 1:08 AM, Claire Chang wrote: > > On Wed, Jan 13, 2021 at 7:48 AM Florian Fainelli > > wrote: > >> > >> On 1/5/21 7:41 PM, Claire Chang wrote: > >>> If a device is not behind an IOMMU, we look up the device node and set > >>>

Re: [PATCH v5 00/21] ibmvfc: initial MQ development/enablement

2021-01-14 Thread Martin K. Petersen
Tyrel, > Recent updates in pHyp Firmware and VIOS releases provide new > infrastructure towards enabling Subordinate Command Response Queues > (Sub-CRQs) such that each Sub-CRQ is a channel backed by an actual > hardware queue in the FC stack on the partner VIOS. Sub-CRQs are > registered with

[powerpc:next-test] BUILD SUCCESS 6629114a7f6f21d41640cbc006c3694e65940729

2021-01-14 Thread kernel test robot
allmodconfig powerpc allnoconfig i386 randconfig-a002-20210114 i386 randconfig-a005-20210114 i386 randconfig-a006-20210114 i386 randconfig-a001-20210114 i386 randconfig-a003

[powerpc:merge] BUILD SUCCESS 56f0e929cb28f6e28e6f88d88c03b75979cf1f40

2021-01-14 Thread kernel test robot
powerpc allnoconfig i386 randconfig-a002-20210114 i386 randconfig-a005-20210114 i386 randconfig-a006-20210114 i386 randconfig-a001-20210114 i386 randconfig-a003-20210114 i386

[powerpc:fixes-test] BUILD SUCCESS 41131a5e54ae7ba5a2bb8d7b30d1818b3f5b13d2

2021-01-14 Thread kernel test robot
allmodconfig powerpc allnoconfig i386 randconfig-a002-20210114 i386 randconfig-a005-20210114 i386 randconfig-a006-20210114 i386 randconfig-a001-20210114 i386 randconfig-a003

Re: [PATCH v4 01/21] ibmvfc: add vhost fields and defaults for MQ enablement

2021-01-14 Thread Ming Lei
On Thu, Jan 14, 2021 at 11:24:35AM -0600, Brian King wrote: > On 1/13/21 7:27 PM, Ming Lei wrote: > > On Wed, Jan 13, 2021 at 11:13:07AM -0600, Brian King wrote: > >> On 1/12/21 6:33 PM, Tyrel Datwyler wrote: > >>> On 1/12/21 2:54 PM, Brian King wrote: > On 1/11/21 5:12 PM, Tyrel Datwyler

Re: [PATCH v5 02/21] powerpc/64s: move the last of the page fault handling logic to C

2021-01-14 Thread Nicholas Piggin
Excerpts from Christophe Leroy's message of January 14, 2021 11:28 pm: > > > Le 14/01/2021 à 14:17, Nicholas Piggin a écrit : >> Excerpts from Christophe Leroy's message of January 14, 2021 10:25 pm: >>> >>> >>> Le 14/01/2021 à 13:09, Nicholas Piggin a écrit : Excerpts from Nicholas

Re: [PATCH v5 00/21] ibmvfc: initial MQ development/enablement

2021-01-14 Thread Brian King
Tyrel, I think this patch series is looking pretty good. I don't think we need to wait for resolution of the can_queue issue being discussed, since that is an issue that exists prior to this patch series and this patch series doesn't make the issue any worse. Let's work that separately. Thanks,

Re: [PATCH v5 21/21] ibmvfc: provide modules parameters for MQ settings

2021-01-14 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH v5 18/21] ibmvfc: send Cancel MAD down each hw scsi channel

2021-01-14 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center

[PATCH 5/6] powerpc/rtas: rename RTAS_RMOBUF_MAX to RTAS_USER_REGION_SIZE

2021-01-14 Thread Nathan Lynch
RTAS_RMOBUF_MAX doesn't actually describe a "maximum" value in any sense. It represents the size of an area of memory set aside for user space to use as work areas for certain RTAS calls. Rename it to RTAS_USER_REGION, and express the value in terms of the number of work areas allocated.

[PATCH 0/6] powerpc/rtas: miscellaneous cleanups, user region allocation

2021-01-14 Thread Nathan Lynch
The region exposed to user space for use as work areas passed to sys_rtas() can be incorrectly allocated on radix, leading to failures in users of librtas. Correct this and clean up some of the code visited along the way. I think the cleanups should be unobjectionable and I've placed them first

[PATCH 6/6] powerpc/rtas: constrain user region allocation to RMA

2021-01-14 Thread Nathan Lynch
Memory locations passed as arguments from the OS to RTAS usually need to be addressable in 32-bit mode and must reside in the Real Mode Area. On PAPR guests, the RMA starts at logical address 0 and is the first logical memory block reported in the LPAR’s device tree. On powerpc targets with RTAS,

[PATCH 4/6] powerpc/rtas: move syscall filter setup into separate function

2021-01-14 Thread Nathan Lynch
Reduce conditionally compiled sections within rtas_initialize() by moving the filter table initialization into its own function already guarded by CONFIG_PPC_RTAS_FILTER. No behavior change intended. Signed-off-by: Nathan Lynch --- arch/powerpc/kernel/rtas.c | 23 +++ 1 file

[PATCH 3/6] powerpc/rtas: remove ibm_suspend_me_token

2021-01-14 Thread Nathan Lynch
There's not a compelling reason to cache the value of the token for the ibm,suspend-me function. Just look it up when needed in the RTAS syscall's special case for it. Signed-off-by: Nathan Lynch --- arch/powerpc/kernel/rtas.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff

[PATCH 1/6] powerpc/rtas: improve ppc_rtas_rmo_buf_show documentation

2021-01-14 Thread Nathan Lynch
Add kerneldoc for ppc_rtas_rmo_buf_show(), the callback for /proc/powerpc/rtas/rmo_buffer, explaining its expected use. Signed-off-by: Nathan Lynch --- arch/powerpc/kernel/rtas-proc.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/rtas-proc.c

[PATCH 2/6] powerpc/rtas-proc: remove unused RMO_READ_BUF_MAX

2021-01-14 Thread Nathan Lynch
This constant is unused. Signed-off-by: Nathan Lynch --- arch/powerpc/kernel/rtas-proc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/powerpc/kernel/rtas-proc.c b/arch/powerpc/kernel/rtas-proc.c index e0f8329966d6..d2b0d99824a4 100644 --- a/arch/powerpc/kernel/rtas-proc.c +++

Re: [PATCH v2 0/7] Rid W=1 warnings in Ethernet

2021-01-14 Thread Jakub Kicinski
On Thu, 14 Jan 2021 08:33:49 + Lee Jones wrote: > On Wed, 13 Jan 2021, Jakub Kicinski wrote: > > > On Wed, 13 Jan 2021 16:41:16 + Lee Jones wrote: > > > Resending the stragglers again. > > > > > > > > >

[PATCH v5 17/21] ibmvfc: add cancel mad initialization helper

2021-01-14 Thread Tyrel Datwyler
Add a helper routine for initializing a Cancel MAD. This will be useful for a channelized client that needs to send Cancel commands down every channel commands were sent for a particular LUN. Signed-off-by: Tyrel Datwyler Reviewed-by: Brian King --- drivers/scsi/ibmvscsi/ibmvfc.c | 68

[PATCH v5 10/21] ibmvfc: define Sub-CRQ interrupt handler routine

2021-01-14 Thread Tyrel Datwyler
Simple handler that calls Sub-CRQ drain routine directly. Signed-off-by: Tyrel Datwyler Reviewed-by: Brian King --- drivers/scsi/ibmvscsi/ibmvfc.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c index

[PATCH v5 18/21] ibmvfc: send Cancel MAD down each hw scsi channel

2021-01-14 Thread Tyrel Datwyler
In general the client needs to send Cancel MADs and task management commands down the same channel as the command(s) intended to cancel or abort. The client assigns cancel keys per LUN and thus must send a Cancel down each channel commands were submitted for that LUN. Further, the client then must

[PATCH v5 14/21] ibmvfc: set and track hw queue in ibmvfc_event struct

2021-01-14 Thread Tyrel Datwyler
Extract the hwq id from a SCSI command and store it in the ibmvfc_event structure to identify which Sub-CRQ to send the command down when channels are being utilized. Signed-off-by: Tyrel Datwyler Reviewed-by: Brian King --- drivers/scsi/ibmvscsi/ibmvfc.c | 5 +

[PATCH v5 20/21] ibmvfc: enable MQ and set reasonable defaults

2021-01-14 Thread Tyrel Datwyler
Turn on MQ by default and set sane values for the upper limit on hw queues for the scsi host, and number of hw scsi channels to request from the partner VIOS. Signed-off-by: Tyrel Datwyler Reviewed-by: Brian King --- drivers/scsi/ibmvscsi/ibmvfc.h | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH v5 19/21] ibmvfc: purge scsi channels after transport loss/reset

2021-01-14 Thread Tyrel Datwyler
Grab the queue and list lock for each Sub-CRQ and add any uncompleted events to the host purge list. Signed-off-by: Tyrel Datwyler Reviewed-by: Brian King --- drivers/scsi/ibmvscsi/ibmvfc.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c

[PATCH v5 21/21] ibmvfc: provide modules parameters for MQ settings

2021-01-14 Thread Tyrel Datwyler
Add the various module parameter toggles for adjusting the MQ characteristics at boot/load time as well as a device attribute for changing the client scsi channel request amount. Signed-off-by: Tyrel Datwyler --- drivers/scsi/ibmvscsi/ibmvfc.c | 75 ++

[PATCH v5 15/21] ibmvfc: send commands down HW Sub-CRQ when channelized

2021-01-14 Thread Tyrel Datwyler
When the client has negotiated the use of channels all vfcFrames are required to go down a Sub-CRQ channel or it is a protocoal violation. If the adapter state is channelized submit vfcFrames to the appropriate Sub-CRQ via the h_send_sub_crq() helper. Signed-off-by: Tyrel Datwyler Reviewed-by:

[PATCH v5 13/21] ibmvfc: advertise client support for using hardware channels

2021-01-14 Thread Tyrel Datwyler
Previous patches have plumbed the necessary Sub-CRQ interface and channel negotiation MADs to fully channelize via hardware backed queues. Advertise client support via NPIV Login capability IBMVFC_CAN_USE_CHANNELS when the client bits have MQ enabled via vhost->mq_enabled, or when channels were

[PATCH v5 12/21] ibmvfc: implement channel enquiry and setup commands

2021-01-14 Thread Tyrel Datwyler
New NPIV_ENQUIRY_CHANNEL and NPIV_SETUP_CHANNEL management datagrams (MADs) were defined in a previous patchset. If the client advertises a desire to use channels and the partner VIOS is channel capable then the client must proceed with channel enquiry to determine the maximum number of channels

[PATCH v5 16/21] ibmvfc: register Sub-CRQ handles with VIOS during channel setup

2021-01-14 Thread Tyrel Datwyler
If the ibmvfc client adapter requests channels it must submit a number of Sub-CRQ handles matching the number of channels being requested. The VIOS in its response will overwrite the actual number of channel resources allocated which may be less than what was requested. The client then must store

[PATCH v5 11/21] ibmvfc: map/request irq and register Sub-CRQ interrupt handler

2021-01-14 Thread Tyrel Datwyler
Create an irq mapping for the hw_irq number provided from phyp firmware. Request an irq assigned our Sub-CRQ interrupt handler. Unmap these irqs at Sub-CRQ teardown. Signed-off-by: Tyrel Datwyler Reviewed-by: Brian King --- drivers/scsi/ibmvscsi/ibmvfc.c | 25 + 1 file

[PATCH v5 03/21] ibmvfc: init/free event pool during queue allocation/free

2021-01-14 Thread Tyrel Datwyler
The event pool and CRQ used to be separate entities of the adapter host structure and as such were allocated and freed independently of each other. Recent work as defined a generic queue structure with an event pool specific to each queue. As such the event pool for each queue shouldn't be

[PATCH v5 09/21] ibmvfc: add handlers to drain and complete Sub-CRQ responses

2021-01-14 Thread Tyrel Datwyler
The logic for iterating over the Sub-CRQ responses is similiar to that of the primary CRQ. Add the necessary handlers for processing those responses. Signed-off-by: Tyrel Datwyler Reviewed-by: Brian King --- drivers/scsi/ibmvscsi/ibmvfc.c | 86 ++ 1 file

[PATCH v5 05/21] ibmvfc: define hcall wrapper for registering a Sub-CRQ

2021-01-14 Thread Tyrel Datwyler
Sub-CRQs are registred with firmware via a hypercall. Abstract that interface into a simpler helper function. Signed-off-by: Tyrel Datwyler Reviewed-by: Brian King --- drivers/scsi/ibmvscsi/ibmvfc.c | 14 ++ 1 file changed, 14 insertions(+) diff --git

[PATCH v5 08/21] ibmvfc: add Sub-CRQ IRQ enable/disable routine

2021-01-14 Thread Tyrel Datwyler
Each Sub-CRQ has its own interrupt. A hypercall is required to toggle the IRQ state. Provide the necessary mechanism via a helper function. Signed-off-by: Tyrel Datwyler Reviewed-by: Brian King --- drivers/scsi/ibmvscsi/ibmvfc.c | 20 1 file changed, 20 insertions(+) diff

[PATCH v5 07/21] ibmvfc: add alloc/dealloc routines for SCSI Sub-CRQ Channels

2021-01-14 Thread Tyrel Datwyler
Allocate a set of Sub-CRQs in advance. During channel setup the client and VIOS negotiate the number of queues the VIOS supports and the number that the client desires to request. Its possible that the final channel resources allocated is less than requested, but the client is still responsible

[PATCH v5 04/21] ibmvfc: add size parameter to ibmvfc_init_event_pool

2021-01-14 Thread Tyrel Datwyler
With the upcoming addition of Sub-CRQs the event pool size may vary per-queue. Add a size parameter to ibmvfc_init_event_pool such that different size event pools can be requested by ibmvfc_alloc_queue. Signed-off-by: Tyrel Datwyler Reviewed-by: Brian King --- drivers/scsi/ibmvscsi/ibmvfc.c |

[PATCH v5 06/21] ibmvfc: add Subordinate CRQ definitions

2021-01-14 Thread Tyrel Datwyler
Subordinate Command Response Queues (Sub CRQ) are used in conjunction with the primary CRQ when more than one queue is needed by the virtual IO adapter. Recent phyp firmware versions support Sub CRQ's with ibmvfc adapters. This feature is a prerequisite for supporting multiple hardware backed

[PATCH v5 01/21] ibmvfc: add vhost fields and defaults for MQ enablement

2021-01-14 Thread Tyrel Datwyler
Introduce several new vhost fields for managing MQ state of the adapter as well as initial defaults for MQ enablement. Signed-off-by: Tyrel Datwyler Reviewed-by: Brian King --- drivers/scsi/ibmvscsi/ibmvfc.c | 8 drivers/scsi/ibmvscsi/ibmvfc.h | 9 + 2 files changed, 17

[PATCH v5 00/21] ibmvfc: initial MQ development/enablement

2021-01-14 Thread Tyrel Datwyler
Recent updates in pHyp Firmware and VIOS releases provide new infrastructure towards enabling Subordinate Command Response Queues (Sub-CRQs) such that each Sub-CRQ is a channel backed by an actual hardware queue in the FC stack on the partner VIOS. Sub-CRQs are registered with the firmware via

[PATCH v5 02/21] ibmvfc: move event pool init/free routines

2021-01-14 Thread Tyrel Datwyler
The next patch in this series reworks the event pool allocation calls to happen within the individual queue allocation routines instead of as independent calls. Move the init/free routines earlier in ibmvfc.c to prevent undefined reference errors when calling these functions from the queue

Re: [PATCH v2 0/7] Rid W=1 warnings in Ethernet

2021-01-14 Thread Lee Jones
On Thu, 14 Jan 2021, Jakub Kicinski wrote: > On Thu, 14 Jan 2021 08:33:49 + Lee Jones wrote: > > On Wed, 13 Jan 2021, Jakub Kicinski wrote: > > > > > On Wed, 13 Jan 2021 16:41:16 + Lee Jones wrote: > > > > Resending the stragglers again. > > > >

Re: [PATCH] spi: fsl: Fix driver breakage when SPI_CS_HIGH is not set in spi->mode

2021-01-14 Thread Mark Brown
On Thu, 14 Jan 2021 13:09:37 + (UTC), Christophe Leroy wrote: > Commit 766c6b63aa04 ("spi: fix client driver breakages when using GPIO > descriptors") broke fsl spi driver. > > As now we fully rely on gpiolib for handling the polarity of > chip selects, the driver shall not alter the GPIO

[PATCH 1/3] tty: hvcs: Drop unnecessary if block

2021-01-14 Thread Uwe Kleine-König
If hvcs_probe() succeeded dev_set_drvdata() is called with a non-NULL value, and if hvcs_probe() failed hvcs_remove() isn't called. So there is no way dev_get_drvdata() can return NULL in hvcs_remove() and the check can just go away. Signed-off-by: Uwe Kleine-König --- drivers/tty/hvc/hvcs.c |

[PATCH 3/3] tty: vcc: Drop impossible to hit WARN_ON

2021-01-14 Thread Uwe Kleine-König
vcc_get() returns the port that has provided port->index. As the port that is about to be removed isn't removed yet this trivially will find this port. So simplify the call to not assign an identical value to the port pointer and drop the warning that is never hit. Signed-off-by: Uwe Kleine-König

[PATCH 0/3] tty: some cleanups in remove functions

2021-01-14 Thread Uwe Kleine-König
Hello, while working on changing the prototype of struct vio_driver::remove to return void I noticed a few exit paths in such callbacks that return an error code. This is a bad thing because the return value is ignored (which is the motivation to make it void) and the corresponding device then

[PATCH 2/3] tty: vcc: Drop unnecessary if block

2021-01-14 Thread Uwe Kleine-König
If vcc_probe() succeeded dev_set_drvdata() is called with a non-NULL value, and if vcc_probe() failed vcc_remove() isn't called. So there is no way dev_get_drvdata() can return NULL in vcc_remove() and the check can just go away. Signed-off-by: Uwe Kleine-König --- drivers/tty/vcc.c | 3 --- 1

Re: [PATCH v4 01/21] ibmvfc: add vhost fields and defaults for MQ enablement

2021-01-14 Thread Brian King
On 1/13/21 7:27 PM, Ming Lei wrote: > On Wed, Jan 13, 2021 at 11:13:07AM -0600, Brian King wrote: >> On 1/12/21 6:33 PM, Tyrel Datwyler wrote: >>> On 1/12/21 2:54 PM, Brian King wrote: On 1/11/21 5:12 PM, Tyrel Datwyler wrote: > Introduce several new vhost fields for managing MQ state of

Re: [RFC PATCH v3 6/6] of: Add plumbing for restricted DMA pool

2021-01-14 Thread Florian Fainelli
On 1/14/21 1:08 AM, Claire Chang wrote: > On Wed, Jan 13, 2021 at 7:48 AM Florian Fainelli wrote: >> >> On 1/5/21 7:41 PM, Claire Chang wrote: >>> If a device is not behind an IOMMU, we look up the device node and set >>> up the restricted DMA when the restricted-dma-pool is presented. >>> >>>

Re: [PATCH v5 03/21] powerpc: remove arguments from fault handler functions

2021-01-14 Thread Christophe Leroy
Le 13/01/2021 à 08:31, Nicholas Piggin a écrit : Make mm fault handlers all just take the pt_regs * argument and load DAR/DSISR from that. Make those that return a value return long. This is done to make the function signatures match other handlers, which will help with a future patch to add

Re: SPI not working on 5.10 and 5.11, bisected to 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors")

2021-01-14 Thread Mark Brown
On Thu, Jan 14, 2021 at 02:42:26PM +0100, Christophe Leroy wrote: > Le 14/01/2021 à 14:22, Mark Brown a écrit : > > For GPIO chipselects you should really fix the driver to just hand the > > GPIO off to the core rather than trying to implement this itself, that > > will avoid driver specific

Re: SPI not working on 5.10 and 5.11, bisected to 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors")

2021-01-14 Thread Christophe Leroy
Le 14/01/2021 à 14:22, Mark Brown a écrit : For GPIO chipselects you should really fix the driver to just hand the GPIO off to the core rather than trying to implement this itself, that will avoid driver specific differences like this. IIUC, it is not trivial as it requires implementing

Re: [PATCH v5 02/21] powerpc/64s: move the last of the page fault handling logic to C

2021-01-14 Thread Christophe Leroy
Le 14/01/2021 à 14:17, Nicholas Piggin a écrit : Excerpts from Christophe Leroy's message of January 14, 2021 10:25 pm: Le 14/01/2021 à 13:09, Nicholas Piggin a écrit : Excerpts from Nicholas Piggin's message of January 14, 2021 1:24 pm: Excerpts from Christophe Leroy's message of

Re: SPI not working on 5.10 and 5.11, bisected to 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors")

2021-01-14 Thread Mark Brown
On Thu, Jan 14, 2021 at 01:33:50PM +0100, Christophe Leroy wrote: > Le 14/01/2021 à 12:59, Mark Brown a écrit : > > On Thu, Jan 14, 2021 at 12:27:42PM +0100, Christophe Leroy wrote: > > > Today I have in the DTS the CS GPIOs declared as ACTIVE_LOW. > > > If I declare them as ACTIVE_HIGH instead,

Re: [PATCH v5 02/21] powerpc/64s: move the last of the page fault handling logic to C

2021-01-14 Thread Nicholas Piggin
Excerpts from Christophe Leroy's message of January 14, 2021 10:25 pm: > > > Le 14/01/2021 à 13:09, Nicholas Piggin a écrit : >> Excerpts from Nicholas Piggin's message of January 14, 2021 1:24 pm: >>> Excerpts from Christophe Leroy's message of January 14, 2021 12:12 am: Le

[PATCH] spi: fsl: Fix driver breakage when SPI_CS_HIGH is not set in spi->mode

2021-01-14 Thread Christophe Leroy
Commit 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors") broke fsl spi driver. As now we fully rely on gpiolib for handling the polarity of chip selects, the driver shall not alter the GPIO value anymore when SPI_CS_HIGH is not set in spi->mode. Fixes: 766c6b63aa04

Re: KVM on POWER8 host lock up since 10d91611f426 ("powerpc/64s: Reimplement book3s idle code in C")

2021-01-14 Thread Nicholas Piggin
Excerpts from Michal Suchánek's message of January 14, 2021 10:40 pm: > On Mon, Oct 19, 2020 at 02:50:51PM +1000, Nicholas Piggin wrote: >> Excerpts from Nicholas Piggin's message of October 19, 2020 11:00 am: >> > Excerpts from Michal Suchánek's message of October 17, 2020 6:14 am: >> >> On Mon,

Re: KVM on POWER8 host lock up since 10d91611f426 ("powerpc/64s: Reimplement book3s idle code in C")

2021-01-14 Thread Michal Suchánek
On Mon, Oct 19, 2020 at 02:50:51PM +1000, Nicholas Piggin wrote: > Excerpts from Nicholas Piggin's message of October 19, 2020 11:00 am: > > Excerpts from Michal Suchánek's message of October 17, 2020 6:14 am: > >> On Mon, Sep 07, 2020 at 11:13:47PM +1000, Nicholas Piggin wrote: > >>> Excerpts

Re: SPI not working on 5.10 and 5.11, bisected to 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors")

2021-01-14 Thread Christophe Leroy
Le 14/01/2021 à 12:59, Mark Brown a écrit : On Thu, Jan 14, 2021 at 12:27:42PM +0100, Christophe Leroy wrote: Today I have in the DTS the CS GPIOs declared as ACTIVE_LOW. If I declare them as ACTIVE_HIGH instead, then I also have to set spi-cs-high property, otherwise

Re: [PATCH v5 02/21] powerpc/64s: move the last of the page fault handling logic to C

2021-01-14 Thread Christophe Leroy
Le 14/01/2021 à 13:09, Nicholas Piggin a écrit : Excerpts from Nicholas Piggin's message of January 14, 2021 1:24 pm: Excerpts from Christophe Leroy's message of January 14, 2021 12:12 am: Le 13/01/2021 à 08:31, Nicholas Piggin a écrit : The page fault handling still has some complex

Re: [PATCH v5 02/21] powerpc/64s: move the last of the page fault handling logic to C

2021-01-14 Thread Nicholas Piggin
Excerpts from Nicholas Piggin's message of January 14, 2021 1:24 pm: > Excerpts from Christophe Leroy's message of January 14, 2021 12:12 am: >> >> >> Le 13/01/2021 à 08:31, Nicholas Piggin a écrit : >>> The page fault handling still has some complex logic particularly around >>> hash table

Re: SPI not working on 5.10 and 5.11, bisected to 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors")

2021-01-14 Thread Mark Brown
On Thu, Jan 14, 2021 at 12:27:42PM +0100, Christophe Leroy wrote: > Today I have in the DTS the CS GPIOs declared as ACTIVE_LOW. > If I declare them as ACTIVE_HIGH instead, then I also have to set > spi-cs-high property, otherwise of_gpio_flags_quirks() is not happy and > forces the GPIO ACTIVE

[PATCH 11/18] arch: powerpc: Remove oprofile

2021-01-14 Thread Viresh Kumar
The previous commit already disabled building oprofile, lets remove the oprofile directory now. Suggested-by: Christoph Hellwig Suggested-by: Linus Torvalds Signed-off-by: Viresh Kumar --- arch/powerpc/oprofile/Makefile | 19 - arch/powerpc/oprofile/backtrace.c | 120

[PATCH 10/18] arch: powerpc: Stop building and using oprofile

2021-01-14 Thread Viresh Kumar
The "oprofile" user-space tools don't use the kernel OPROFILE support any more, and haven't in a long time. User-space has been converted to the perf interfaces. This commits stops building oprofile for powerpc and removes any reference to it from directories in arch/powerpc/ apart from

Re: SPI not working on 5.10 and 5.11, bisected to 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors")

2021-01-14 Thread Christophe Leroy
Le 13/01/2021 à 13:33, Mark Brown a écrit : On Wed, Jan 13, 2021 at 09:49:12AM +0100, Christophe Leroy wrote: With commit 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors") reverted, it is back to work: ... What shall I do ? I would guess that there's an

Re: [PATCH] perf tools: Resolve symbols against debug file first

2021-01-14 Thread Michael Ellerman
Namhyung Kim writes: > On Wed, Jan 13, 2021 at 8:43 PM Jiri Slaby wrote: >> >> On 13. 01. 21, 11:46, Jiri Olsa wrote: >> > On Wed, Jan 13, 2021 at 09:01:28AM +0100, Jiri Slaby wrote: >> >> With LTO, there are symbols like these: >> >>

Re: [RFC PATCH v3 6/6] of: Add plumbing for restricted DMA pool

2021-01-14 Thread Claire Chang
On Wed, Jan 13, 2021 at 7:48 AM Florian Fainelli wrote: > > On 1/5/21 7:41 PM, Claire Chang wrote: > > If a device is not behind an IOMMU, we look up the device node and set > > up the restricted DMA when the restricted-dma-pool is presented. > > > > Signed-off-by: Claire Chang > > --- > >

Re: [RFC PATCH v3 2/6] swiotlb: Add restricted DMA pool

2021-01-14 Thread Claire Chang
On Wed, Jan 13, 2021 at 8:42 PM Christoph Hellwig wrote: > > > +#ifdef CONFIG_SWIOTLB > > + struct io_tlb_mem *dma_io_tlb_mem; > > #endif > > Please add a new config option for this code instead of always building > it when swiotlb is enabled. > > > +static int

Re: [PATCH v2 0/7] Rid W=1 warnings in Ethernet

2021-01-14 Thread Lee Jones
On Wed, 13 Jan 2021, Jakub Kicinski wrote: > On Wed, 13 Jan 2021 16:41:16 + Lee Jones wrote: > > Resending the stragglers again. > > > > > > This set is part of a larger effort attempting to clean-up W=1