[PATCH] powerpc64/idle: Fix SP offsets when saving GPRs

2021-01-29 Thread Christopher M. Riedl
The idle entry/exit code saves/restores GPRs in the stack "red zone" (Protected Zone according to PowerPC64 ELF ABI v2). However, the offset used for the first GPR is incorrect and overwrites the back chain - the Protected Zone actually starts below the current SP. In practice this is probably not

Re: [PATCH] powerpc: remove unneeded semicolons

2021-01-29 Thread Chengyang Fan
Although they are harmless, I think we should keep the consistency of kernel coding style. Thanks On 2021/1/29 19:48, Michael Ellerman wrote: Chengyang Fan writes: Remove superfluous semicolons after function definitions. Is there a good reason why? I realise they're superfluous, but

Re: [PATCH 04/13] module: use RCU to synchronize find_module

2021-01-29 Thread Thiago Jung Bauermann
Christoph Hellwig writes: > On Thu, Jan 28, 2021 at 05:50:56PM -0300, Thiago Jung Bauermann wrote: >> > struct module *find_module(const char *name) >> > { >> > - module_assert_mutex(); >> >> Does it make sense to replace the assert above with the warn below >> (untested)? >> >>

Re: [PATCH] vio: make remove callback return void

2021-01-29 Thread Lijun Pan
On Wed, Jan 27, 2021 at 6:41 PM Uwe Kleine-König wrote: > > The driver core ignores the return value of struct bus_type::remove() > because there is only little that can be done. To simplify the quest to > make this function return void, let struct vio_driver::remove() return > void, too. All

Re: [PATCH] vio: make remove callback return void

2021-01-29 Thread Tyrel Datwyler
On 1/27/21 1:50 PM, Uwe Kleine-König wrote: > The driver core ignores the return value of struct bus_type::remove() > because there is only little that can be done. To simplify the quest to > make this function return void, let struct vio_driver::remove() return > void, too. All users already

Re: [PATCH v2] tpm: ibmvtpm: fix error return code in tpm_ibmvtpm_probe()

2021-01-29 Thread Stefan Berger
On 1/29/21 12:35 PM, Jarkko Sakkinen wrote: On Mon, Jan 25, 2021 at 08:47:53PM -0500, Stefan Berger wrote: From: Stefan Berger Return error code -ETIMEDOUT rather than '0' when waiting for the rtce_buf to be set has timed out. Fixes: d8d74ea3c002 ("tpm: ibmvtpm: Wait for buffer to be set

Re: [PATCH v2] tpm: ibmvtpm: fix error return code in tpm_ibmvtpm_probe()

2021-01-29 Thread Jarkko Sakkinen
On Mon, Jan 25, 2021 at 08:47:53PM -0500, Stefan Berger wrote: > From: Stefan Berger > > Return error code -ETIMEDOUT rather than '0' when waiting for the > rtce_buf to be set has timed out. > > Fixes: d8d74ea3c002 ("tpm: ibmvtpm: Wait for buffer to be set before > proceeding") > Reported-by:

[PATCH AUTOSEL 4.4 2/2] scsi: ibmvfc: Set default timeout to avoid crash during migration

2021-01-29 Thread Sasha Levin
From: Brian King [ Upstream commit 764907293edc1af7ac857389af9dc858944f53dc ] While testing live partition mobility, we have observed occasional crashes of the Linux partition. What we've seen is that during the live migration, for specific configurations with large amounts of memory, slow

[PATCH AUTOSEL 4.9 3/4] scsi: ibmvfc: Set default timeout to avoid crash during migration

2021-01-29 Thread Sasha Levin
From: Brian King [ Upstream commit 764907293edc1af7ac857389af9dc858944f53dc ] While testing live partition mobility, we have observed occasional crashes of the Linux partition. What we've seen is that during the live migration, for specific configurations with large amounts of memory, slow

[PATCH AUTOSEL 4.14 6/8] scsi: ibmvfc: Set default timeout to avoid crash during migration

2021-01-29 Thread Sasha Levin
From: Brian King [ Upstream commit 764907293edc1af7ac857389af9dc858944f53dc ] While testing live partition mobility, we have observed occasional crashes of the Linux partition. What we've seen is that during the live migration, for specific configurations with large amounts of memory, slow

[PATCH AUTOSEL 4.19 09/12] selftests/powerpc: Only test lwm/stmw on big endian

2021-01-29 Thread Sasha Levin
From: Michael Ellerman [ Upstream commit dd3a44c06f7b4f14e90065bf05d62c255b20005f ] Newer binutils (>= 2.36) refuse to assemble lmw/stmw when building in little endian mode. That breaks compilation of our alignment handler test: /tmp/cco4l14N.s: Assembler messages: /tmp/cco4l14N.s:1440:

[PATCH AUTOSEL 4.19 08/12] scsi: ibmvfc: Set default timeout to avoid crash during migration

2021-01-29 Thread Sasha Levin
From: Brian King [ Upstream commit 764907293edc1af7ac857389af9dc858944f53dc ] While testing live partition mobility, we have observed occasional crashes of the Linux partition. What we've seen is that during the live migration, for specific configurations with large amounts of memory, slow

[PATCH AUTOSEL 5.4 14/19] selftests/powerpc: Only test lwm/stmw on big endian

2021-01-29 Thread Sasha Levin
From: Michael Ellerman [ Upstream commit dd3a44c06f7b4f14e90065bf05d62c255b20005f ] Newer binutils (>= 2.36) refuse to assemble lmw/stmw when building in little endian mode. That breaks compilation of our alignment handler test: /tmp/cco4l14N.s: Assembler messages: /tmp/cco4l14N.s:1440:

[PATCH AUTOSEL 5.4 10/19] scsi: ibmvfc: Set default timeout to avoid crash during migration

2021-01-29 Thread Sasha Levin
From: Brian King [ Upstream commit 764907293edc1af7ac857389af9dc858944f53dc ] While testing live partition mobility, we have observed occasional crashes of the Linux partition. What we've seen is that during the live migration, for specific configurations with large amounts of memory, slow

[PATCH AUTOSEL 5.10 28/41] selftests/powerpc: Only test lwm/stmw on big endian

2021-01-29 Thread Sasha Levin
From: Michael Ellerman [ Upstream commit dd3a44c06f7b4f14e90065bf05d62c255b20005f ] Newer binutils (>= 2.36) refuse to assemble lmw/stmw when building in little endian mode. That breaks compilation of our alignment handler test: /tmp/cco4l14N.s: Assembler messages: /tmp/cco4l14N.s:1440:

[PATCH AUTOSEL 5.10 18/41] scsi: ibmvfc: Set default timeout to avoid crash during migration

2021-01-29 Thread Sasha Levin
From: Brian King [ Upstream commit 764907293edc1af7ac857389af9dc858944f53dc ] While testing live partition mobility, we have observed occasional crashes of the Linux partition. What we've seen is that during the live migration, for specific configurations with large amounts of memory, slow

Re: [PATCH 04/13] module: use RCU to synchronize find_module

2021-01-29 Thread Miroslav Benes
On Thu, 28 Jan 2021, Christoph Hellwig wrote: > Allow for a RCU-sched critical section around find_module, following > the lower level find_module_all helper, and switch the two callers > outside of module.c to use such a RCU-sched critical section instead > of module_mutex. That's a nice idea.

Re: [PATCH 03/13] module: unexport find_module and module_mutex

2021-01-29 Thread Miroslav Benes
On Thu, 28 Jan 2021, Christoph Hellwig wrote: > find_module is not used by modular code any more, and random driver code > has no business calling it to start with. > > Signed-off-by: Christoph Hellwig Reviewed-by: Miroslav Benes M

Re: [PATCH 04/13] module: use RCU to synchronize find_module

2021-01-29 Thread Petr Mladek
On Thu 2021-01-28 19:14:12, Christoph Hellwig wrote: > Allow for a RCU-sched critical section around find_module, following > the lower level find_module_all helper, and switch the two callers > outside of module.c to use such a RCU-sched critical section instead > of module_mutex. > >

Re: [PATCH 05/13] kallsyms: refactor {,module_}kallsyms_on_each_symbol

2021-01-29 Thread Petr Mladek
On Thu 2021-01-28 19:14:13, Christoph Hellwig wrote: > Require an explicit call to module_kallsyms_on_each_symbol to look > for symbols in modules instead of the call from kallsyms_on_each_symbol, > and acquire module_mutex inside of module_kallsyms_on_each_symbol instead > of leaving that up to

Re: [PATCH] powerpc/fault: fix wrong KUAP fault for IO_URING

2021-01-29 Thread Christophe Leroy
+Aneesh Le 29/01/2021 à 07:52, Zorro Lang a écrit : On Thu, Jan 28, 2021 at 03:44:21PM +0100, Christophe Leroy wrote: Le 28/01/2021 à 15:42, Jens Axboe a écrit : On 1/28/21 6:52 AM, Zorro Lang wrote: On Wed, Jan 27, 2021 at 08:06:37PM -0700, Jens Axboe wrote: On 1/27/21 8:13 PM, Zorro

Re: [PATCH] powerpc: remove unneeded semicolons

2021-01-29 Thread Michael Ellerman
Chengyang Fan writes: > Remove superfluous semicolons after function definitions. Is there a good reason why? I realise they're superfluous, but they're also harmless as far as I'm aware. cheers > arch/powerpc/include/asm/book3s/32/mmu-hash.h | 2 +- >

Re: [PATCH 1/2] powerpc/vdso: fix unnecessary rebuilds of vgettimeofday.o

2021-01-29 Thread Michael Ellerman
Masahiro Yamada writes: > On Thu, Dec 24, 2020 at 2:12 AM Masahiro Yamada wrote: >> >> vgettimeofday.o is unnecessarily rebuilt. Adding it to 'targets' is not >> enough to fix the issue. Kbuild is correctly rebuilding it because the >> command line is changed. >> >> PowerPC builds each vdso

Re: [PATCH 0/3] sched: Task priority related cleanups

2021-01-29 Thread Peter Zijlstra
On Thu, Jan 28, 2021 at 02:10:37PM +0100, Dietmar Eggemann wrote: > Dietmar Eggemann (3): > sched: Remove MAX_USER_RT_PRIO > sched: Remove USER_PRIO, TASK_USER_PRIO and MAX_USER_PRIO > sched/core: Update task_prio() function header Thanks!

Re: [PATCH v2] powerpc/sstep: Fix array out of bound warning

2021-01-29 Thread Naveen N. Rao
On 2021/01/29 12:47PM, Ravi Bangoria wrote: > Compiling kernel with -Warray-bounds throws below warning: > > In function 'emulate_vsx_store': > warning: array subscript is above array bounds [-Warray-bounds] > buf.d[2] = byterev_8(reg->d[1]); > ~^~~ > buf.d[3] =

Re: [PATCH] cxl: Simplify bool conversion

2021-01-29 Thread Frederic Barrat
On 29/01/2021 09:25, Yang Li wrote: Fix the following coccicheck warning: ./drivers/misc/cxl/sysfs.c:181:48-53: WARNING: conversion to bool not needed here Reported-by: Abaci Robot Signed-off-by: Yang Li --- Thanks! Acked-by: Frederic Barrat drivers/misc/cxl/sysfs.c | 2 +- 1