Re: [PATCH v2 net-next] ethernet: ucc_geth: Use kmemdup() rather than kmalloc+memcpy

2021-05-23 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 24 May 2021 09:07:01 +0800 you wrote: > Issue identified with Coccinelle. > > Signed-off-by: YueHaibing > --- > v2: keep kmemdup oneline > > drivers/net/ethernet/freescale/ucc_geth.c | 3 +-- > 1 file changed,

Re: [PATCH 1/1] powerpc/ps3: Fix error return code in ps3_register_devices()

2021-05-23 Thread Leizhen (ThunderTown)
On 2021/5/24 4:15, Geoff Levand wrote: > Hi, > > On 5/20/21 5:20 AM, Michael Ellerman wrote: >> Zhen Lei writes: >>> When call ps3_start_probe_thread() failed, further initialization should >>> be stopped and the returned error code should be propagated. > ... >>> ---

Re: [PATCH v2 net-next] ethernet: ucc_geth: Use kmemdup() rather than kmalloc+memcpy

2021-05-23 Thread Andrew Lunn
On Mon, May 24, 2021 at 09:07:01AM +0800, YueHaibing wrote: > Issue identified with Coccinelle. > > Signed-off-by: YueHaibing Reviewed-by: Andrew Lunn Andrew

[PATCH v2 net-next] ethernet: ucc_geth: Use kmemdup() rather than kmalloc+memcpy

2021-05-23 Thread YueHaibing
Issue identified with Coccinelle. Signed-off-by: YueHaibing --- v2: keep kmemdup oneline drivers/net/ethernet/freescale/ucc_geth.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c index

Re: [PATCH net-next] ethernet: ucc_geth: Use kmemdup() rather than kmalloc+memcpy

2021-05-23 Thread YueHaibing
On 2021/5/23 22:26, Andrew Lunn wrote: > On Sun, May 23, 2021 at 03:29:37PM +0200, Christophe Leroy wrote: >> YueHaibing a écrit : >> >>> Issue identified with Coccinelle. >>> >>> Signed-off-by: YueHaibing >>> --- >>> drivers/net/ethernet/freescale/ucc_geth.c | 4 ++-- >>> 1 file changed, 2

[powerpc:merge] BUILD SUCCESS 8dbbcb8a8856c6b4e56ae705218d8dad1f9cf1e9

2021-05-23 Thread kernel test robot
allmodconfig powerpc allnoconfig i386 randconfig-a001-20210523 i386 randconfig-a002-20210523 i386 randconfig-a003-20210523 i386 randconfig-a004-20210523 i386 randconfig-a001-20210524 i386

[powerpc:fixes-test] BUILD SUCCESS b49f9d9b0e428909796b4a7e7f1049f489859e0f

2021-05-23 Thread kernel test robot
randconfig-a001-20210523 i386 randconfig-a005-20210523 i386 randconfig-a002-20210523 i386 randconfig-a003-20210523 i386 randconfig-a004-20210523 i386 randconfig-a006-20210523 i386 randconfig-a001

Re: [PATCH 1/1] powerpc/ps3: Fix error return code in ps3_register_devices()

2021-05-23 Thread Geoff Levand
Hi, On 5/20/21 5:20 AM, Michael Ellerman wrote: > Zhen Lei writes: >> When call ps3_start_probe_thread() failed, further initialization should >> be stopped and the returned error code should be propagated. ... >> --- a/arch/powerpc/platforms/ps3/device-init.c >> >> result =

Re: [PATCH 12/26] bcache: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Coly Li
On 5/21/21 1:51 PM, Christoph Hellwig wrote: > Convert the bcache driver to use the blk_alloc_disk and blk_cleanup_disk > helpers to simplify gendisk and request_queue allocation. > > Signed-off-by: Christoph Hellwig Acked-by: Coly Li Thanks. Coly Li > --- > drivers/md/bcache/super.c | 15

Re: [GIT PULL] Please pull powerpc/linux.git powerpc-5.13-4 tag

2021-05-23 Thread pr-tracker-bot
The pull request you sent on Sun, 23 May 2021 20:31:42 +1000: > https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git > tags/powerpc-5.13-4 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/28ceac6959e1db015729c52ec74e0a4ff496c2b8 Thank you! --

Re: [PATCH] KVM: PPC: Book3S HV: Fix reverse map real-mode address lookup with huge vmalloc

2021-05-23 Thread Christophe Leroy
Nicholas Piggin a écrit : real_vmalloc_addr() does not currently work for huge vmalloc, which is what the reverse map can be allocated with for radix host, hash guest. Add huge page awareness to the function. Fixes: 8abddd968a30 ("powerpc/64s/radix: Enable huge vmalloc mappings")

[PATCH] KVM: PPC: Book3S HV: Fix reverse map real-mode address lookup with huge vmalloc

2021-05-23 Thread Nicholas Piggin
real_vmalloc_addr() does not currently work for huge vmalloc, which is what the reverse map can be allocated with for radix host, hash guest. Add huge page awareness to the function. Fixes: 8abddd968a30 ("powerpc/64s/radix: Enable huge vmalloc mappings") Signed-off-by: Nicholas Piggin ---

Re: [PATCH net-next] ethernet: ucc_geth: Use kmemdup() rather than kmalloc+memcpy

2021-05-23 Thread Andrew Lunn
On Sun, May 23, 2021 at 03:29:37PM +0200, Christophe Leroy wrote: > YueHaibing a écrit : > > > Issue identified with Coccinelle. > > > > Signed-off-by: YueHaibing > > --- > > drivers/net/ethernet/freescale/ucc_geth.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff

Re: [PATCH] KVM: PPC: Book3S HV: Save host FSCR in the P7/8 path

2021-05-23 Thread Nicholas Piggin
Excerpts from Nicholas Piggin's message of May 23, 2021 10:21 pm: > Similar to commit 25edcc50d76c ("KVM: PPC: Book3S HV: Save and restore > FSCR in the P9 path"), ensure the P7/8 path saves and restores the host > FSCR. The logic explained in that patch actually applies there to the > old path

Re: [PATCH net-next] ethernet: ucc_geth: Use kmemdup() rather than kmalloc+memcpy

2021-05-23 Thread Christophe Leroy
YueHaibing a écrit : Issue identified with Coccinelle. Signed-off-by: YueHaibing --- drivers/net/ethernet/freescale/ucc_geth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c

[PATCH] KVM: PPC: Book3S HV: Save host FSCR in the P7/8 path

2021-05-23 Thread Nicholas Piggin
Similar to commit 25edcc50d76c ("KVM: PPC: Book3S HV: Save and restore FSCR in the P9 path"), ensure the P7/8 path saves and restores the host FSCR. The logic explained in that patch actually applies there to the old path well: a context switch can be made before kvmppc_vcpu_run_hv restores the

Re: [PATCH V2 1/1] powerpc/perf: Fix PMU callbacks to clear pending PMI before resetting an overflown PMC

2021-05-23 Thread Athira Rajeev
> On 17-May-2021, at 8:50 AM, Nicholas Piggin wrote: > > Sorry I missed this :( > > Excerpts from Athira Rajeev's message of April 20, 2021 1:01 pm: >> Running perf fuzzer showed below in dmesg logs: >> "Can't find PMC that caused IRQ" >> >> This means a PMU exception happened, but none of

Re: [PATCH] powerpc/udbg_hvc: retry putc on -EAGAIN

2021-05-23 Thread Michael Ellerman
Greg KH writes: > On Fri, May 14, 2021 at 04:44:22PM -0500, Nathan Lynch wrote: >> hvterm_raw_put_chars() calls hvc_put_chars(), which may return -EAGAIN >> when the underlying hcall returns a "busy" status, but udbg_hvc_putc() >> doesn't handle this. When using xmon on a PowerVM guest, this can

[GIT PULL] Please pull powerpc/linux.git powerpc-5.13-4 tag

2021-05-23 Thread Michael Ellerman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Linus, Please pull some more powerpc fixes for 5.13. It's not obvious from the diff, but the seccomp_bpf.c change is entirely inside a __powerpc__ ifdef. cheers The following changes since commit d07f6ca923ea0927a1024dfccafc5b53b61cfecc:

Re: [PATCH 26/26] block: unexport blk_alloc_queue

2021-05-23 Thread Hannes Reinecke
On 5/21/21 7:51 AM, Christoph Hellwig wrote: blk_alloc_queue is just an internal helper now, unexport it and remove it from the public header. Signed-off-by: Christoph Hellwig --- block/blk-core.c | 1 - block/blk.h| 2 ++ include/linux/blkdev.h | 1 - 3 files changed, 2

Re: [PATCH 25/26] null_blk: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
On 5/21/21 7:51 AM, Christoph Hellwig wrote: Convert the null_blk driver to use the blk_alloc_disk and blk_cleanup_disk helpers to simplify gendisk and request_queue allocation. Note that the blk-mq mode is left with its own allocations scheme, to be handled later. Signed-off-by: Christoph

Re: [PATCH 24/26] xpram: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
On 5/21/21 7:51 AM, Christoph Hellwig wrote: Convert the xpram driver to use the blk_alloc_disk and blk_cleanup_disk helpers to simplify gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/s390/block/xpram.c | 26 +- 1 file changed, 9

Re: [PATCH 23/26] dcssblk: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
On 5/21/21 7:51 AM, Christoph Hellwig wrote: Convert the dcssblk driver to use the blk_alloc_disk and blk_cleanup_disk helpers to simplify gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/s390/block/dcssblk.c | 26 -- 1 file changed,

Re: [PATCH 22/26] ps3vram: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
On 5/21/21 7:51 AM, Christoph Hellwig wrote: Convert the ps3vram driver to use the blk_alloc_disk and blk_cleanup_disk helpers to simplify gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/ps3vram.c | 31 --- 1 file changed,

Re: [PATCH 21/26] n64cart: convert to blk_alloc_disk

2021-05-23 Thread Hannes Reinecke
On 5/21/21 7:51 AM, Christoph Hellwig wrote: Convert the n64cart driver to use the blk_alloc_disk helper to simplify gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/n64cart.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) Reviewed-by:

Re: [PATCH 20/26] simdisk: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
On 5/21/21 7:51 AM, Christoph Hellwig wrote: Convert the simdisk driver to use the blk_alloc_disk and blk_cleanup_disk helpers to simplify gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- arch/xtensa/platforms/iss/simdisk.c | 29 +++-- 1

Re: [PATCH 19/26] nfblock: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
On 5/21/21 7:51 AM, Christoph Hellwig wrote: Convert the nfblock driver to use the blk_alloc_disk and blk_cleanup_disk helpers to simplify gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- arch/m68k/emu/nfblock.c | 20 +--- 1 file changed, 5

Re: [PATCH 18/26] nvme-multipath: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
On 5/21/21 7:51 AM, Christoph Hellwig wrote: Convert the nvme-multipath driver to use the blk_alloc_disk and blk_cleanup_disk helpers to simplify gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/nvdimm/pmem.c | 1 - drivers/nvme/host/multipath.c |

Re: [PATCH 17/26] nvdimm-pmem: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
On 5/21/21 7:51 AM, Christoph Hellwig wrote: Convert the nvdimm-pmem driver to use the blk_alloc_disk and blk_cleanup_disk helpers to simplify gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/nvdimm/pmem.c | 15 +-- 1 file changed, 5

Re: [PATCH 16/26] nvdimm-btt: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
On 5/21/21 7:51 AM, Christoph Hellwig wrote: Convert the nvdimm-btt driver to use the blk_alloc_disk and blk_cleanup_disk helpers to simplify gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/nvdimm/btt.c | 24 +++- drivers/nvdimm/btt.h |

Re: [PATCH 15/26] nvdimm-blk: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
On 5/21/21 7:51 AM, Christoph Hellwig wrote: Convert the nvdimm-blk driver to use the blk_alloc_disk and blk_cleanup_disk helpers to simplify gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/nvdimm/blk.c | 26 ++ 1 file changed, 6

Re: [PATCH 14/26] md: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
On 5/21/21 7:51 AM, Christoph Hellwig wrote: Convert the md driver to use the blk_alloc_disk and blk_cleanup_disk helpers to simplify gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/md/md.c | 25 + 1 file changed, 9 insertions(+),

Re: [PATCH 13/26] dm: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
On 5/21/21 7:51 AM, Christoph Hellwig wrote: Convert the dm driver to use the blk_alloc_disk and blk_cleanup_disk helpers to simplify gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/md/dm.c | 16 +++- 1 file changed, 7 insertions(+), 9

Re: [PATCH 12/26] bcache: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
On 5/21/21 7:51 AM, Christoph Hellwig wrote: Convert the bcache driver to use the blk_alloc_disk and blk_cleanup_disk helpers to simplify gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/md/bcache/super.c | 15 --- 1 file changed, 4

Re: [PATCH 11/26] lightnvm: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
On 5/21/21 7:51 AM, Christoph Hellwig wrote: Convert the lightnvm driver to use the blk_alloc_disk and blk_cleanup_disk helpers to simplify gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/lightnvm/core.c | 23 +-- 1 file changed, 5

Re: [PATCH 10/26] zram: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
On 5/21/21 7:51 AM, Christoph Hellwig wrote: Convert the zram driver to use the blk_alloc_disk and blk_cleanup_disk helpers to simplify gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/zram/zram_drv.c | 19 --- 1 file changed, 4

Re: [PATCH 09/26] rsxx: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
On 5/21/21 7:50 AM, Christoph Hellwig wrote: Convert the rsxx driver to use the blk_alloc_disk and blk_cleanup_disk helpers to simplify gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/rsxx/dev.c | 39 +-

[PATCH net-next] ethernet: ucc_geth: Use kmemdup() rather than kmalloc+memcpy

2021-05-23 Thread YueHaibing
Issue identified with Coccinelle. Signed-off-by: YueHaibing --- drivers/net/ethernet/freescale/ucc_geth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c index

Re: [PATCH 08/26] pktcdvd: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
On 5/21/21 7:50 AM, Christoph Hellwig wrote: Convert the pktcdvd driver to use the blk_alloc_disk and blk_cleanup_disk helpers to simplify gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/pktcdvd.c | 11 --- 1 file changed, 4 insertions(+), 7

Re: [PATCH 07/26] drbd: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
On 5/21/21 7:50 AM, Christoph Hellwig wrote: Convert the drbd driver to use the blk_alloc_disk and blk_cleanup_disk helpers to simplify gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/drbd/drbd_main.c | 23 --- 1 file changed, 8

Re: [PATCH 06/26] brd: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
On 5/21/21 7:50 AM, Christoph Hellwig wrote: Convert the brd driver to use the blk_alloc_disk and blk_cleanup_disk helpers to simplify gendisk and request_queue allocation. This also allows to remove the request_queue pointer in struct request_queue, and to simplify the initialization as

Re: [PATCH 05/26] block: add blk_alloc_disk and blk_cleanup_disk APIs

2021-05-23 Thread Hannes Reinecke
On 5/21/21 7:50 AM, Christoph Hellwig wrote: Add two new APIs to allocate and free a gendisk including the request_queue for use with BIO based drivers. This is to avoid boilerplate code in drivers. Signed-off-by: Christoph Hellwig --- block/genhd.c | 35

Re: [PATCH 04/26] block: add a flag to make put_disk on partially initalized disks safer

2021-05-23 Thread Hannes Reinecke
On 5/21/21 7:50 AM, Christoph Hellwig wrote: Add a flag to indicate that __device_add_disk did grab a queue reference so that disk_release only drops it if we actually had it. This sort out one of the major pitfals with partially initialized gendisk that pitfalls a lot

Re: [PATCH 03/26] block: automatically enable GENHD_FL_EXT_DEVT

2021-05-23 Thread Hannes Reinecke
On 5/21/21 7:50 AM, Christoph Hellwig wrote: Automatically set the GENHD_FL_EXT_DEVT flag for all disks allocated without an explicit number of minors. This is what all new block drivers should do, so make sure it is the default without boilerplate code. Signed-off-by: Christoph Hellwig ---

Re: [PATCH 02/26] block: move the DISK_MAX_PARTS sanity check into __device_add_disk

2021-05-23 Thread Hannes Reinecke
On 5/21/21 7:50 AM, Christoph Hellwig wrote: Keep this together with the first place that actually looks at ->minors and prepare for not passing a minors argument to alloc_disk. Signed-off-by: Christoph Hellwig --- block/genhd.c | 13 ++--- 1 file changed, 6 insertions(+), 7

Re: [PATCH 01/26] block: refactor device number setup in __device_add_disk

2021-05-23 Thread Hannes Reinecke
On 5/21/21 7:50 AM, Christoph Hellwig wrote: Untangle the mess around blk_alloc_devt by moving the check for the used allocation scheme into the callers. Signed-off-by: Christoph Hellwig --- block/blk.h | 4 +- block/genhd.c | 96