Le 23/07/2021 à 22:31, Geoff Levand a écrit :
Fixes several DMA mapping problems with the PS3's gelic network driver:
* Change from checking the return value of dma_map_single to using the
dma_mapping_error routine.
* Use the correct buffer length when mapping the RX skb.
*
Le 23/07/2021 à 22:31, Geoff Levand a écrit :
Add new helper routine gelic_work_to_card that converts a work_struct
to a gelic_card.
Signed-off-by: Geoff Levand
Commit 3ffdbef9f86f ("net/ps3_gelic: Add new routine gelic_work_to_card") has no obvious style
problems and is ready for
Le 23/07/2021 à 22:31, Geoff Levand a écrit :
In an effort to make the PS3 gelic driver easier to maintain, rename
the gelic_card_init_chain parameter 'no' to 'descr_count'.
Signed-off-by: Geoff Levand
CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#40: FILE:
Le 23/07/2021 à 22:31, Geoff Levand a écrit :
Put the common code for unmaping a link into its own routine,
gelic_unmap_link, and add some debugging checks.
Signed-off-by: Geoff Levand
CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#31: FILE:
Le 23/07/2021 à 22:31, Geoff Levand a écrit :
In an effort to make the PS3 gelic driver easier to maintain, change the
gelic_card_enable_rxdmac routine to use the optimizer to remove
debug code.
Signed-off-by: Geoff Levand
WARNING:VSPRINTF_SPECIFIER_PX: Using vsprintf specifier '%px'
Le 23/07/2021 à 22:31, Geoff Levand a écrit :
In an effort to make the PS3 gelic driver easier to maintain, add
a definition for the vlan_id structure.
Signed-off-by: Geoff Levand
Commit 4298d9fdc87f ("net/ps3_gelic: Add vlan_id structure") has no obvious style problems and is
ready for
Le 23/07/2021 à 22:31, Geoff Levand a écrit :
Add a new preprocessor macro BUG_ON_DEBUG, that expands to BUG_ON when
the preprocessor macro DEBUG is defined, or to WARN_ON when DEBUG is not
defined. Also, replace all occurrences of BUG_ON with BUG_ON_DEBUG.
CHECK:MACRO_ARG_REUSE: Macro
Le 23/07/2021 à 22:31, Geoff Levand a écrit :
In an effort to make the PS3 gelic driver easier to maintain, cleanup the
the driver source file formatting to be more consistent.
WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG()
or BUG_ON()
Le 23/07/2021 à 22:31, Geoff Levand a écrit :
In an effort to make the PS3 gelic driver easier to maintain, add a
local variable dev to those routines that use the device structure that
makes the use the device structure more consistent.
Signed-off-by: Geoff Levand
Running checkpatch
Le 23/07/2021 à 22:31, Geoff Levand a écrit :
In an effort to make the PS3 gelic driver easier to maintain, create two
new structures, struct gelic_hw_regs and struct gelic_chain_link, and
replace the corresponding members of struct gelic_descr with the new
structures.
struct gelic_hw_regs
On 2021-08-04, Daniel Thompson wrote:
> On Wed, Aug 04, 2021 at 02:12:22PM +0200, Petr Mladek wrote:
>> On Wed 2021-08-04 12:31:59, Daniel Thompson wrote:
>> > On Tue, Aug 03, 2021 at 05:36:32PM +0206, John Ogness wrote:
>> > > On 2021-08-03, Daniel Thompson wrote:
>> > > > On Tue, Aug 03, 2021
On Wed, 4 Aug 2021, Christophe Leroy wrote:
>
> This patch is related to the bisect you did that pointed to 4c0104a83fc3
> ("powerpc/32: Dismantle EXC_XFER_STD/LITE/TEMPLATE")
>
> I think maybe the starting point should be to (manually) apply the patch
> on top of that commit in order to
We shouldn't need legacy ptys, and disabling the option improves boot
time by about 0.5 seconds.
Signed-off-by: Anton Blanchard
---
diff --git a/arch/powerpc/configs/microwatt_defconfig
b/arch/powerpc/configs/microwatt_defconfig
index a08b739123da..ebc90aefbc0c 100644
---
https://bugzilla.kernel.org/show_bug.cgi?id=213961
--- Comment #7 from Elimar Riesebieter (riese...@lxtec.de) ---
Created attachment 298205
--> https://bugzilla.kernel.org/attachment.cgi?id=298205=edit
dmesg dump with KALLSYMS enabled
--
You may reply to this email to add a comment.
You are
https://bugzilla.kernel.org/show_bug.cgi?id=213961
--- Comment #6 from Elimar Riesebieter (riese...@lxtec.de) ---
Created attachment 298203
--> https://bugzilla.kernel.org/attachment.cgi?id=298203=edit
config with KALLSYMS enabled
--
You may reply to this email to add a comment.
You are
https://bugzilla.kernel.org/show_bug.cgi?id=213961
--- Comment #5 from Elimar Riesebieter (riese...@lxtec.de) ---
Configuring KALLSYMS doesn't give the function names
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are watching the assignee of the bug.
Running an SMP kernel on an UP platform not prepared for it,
I encountered the following OOPS:
BUG: Kernel NULL pointer dereference on read at 0x0034
Faulting instruction address: 0xc0a04110
Oops: Kernel access of bad area, sig: 11 [#1]
BE PAGE_SIZE=4K SMP
On Tue 2021-08-03 17:36:32, John Ogness wrote:
> On 2021-08-03, Daniel Thompson wrote:
> > On Tue, Aug 03, 2021 at 03:18:54PM +0206, John Ogness wrote:
> >> kgdb makes use of its own cpulock (@dbg_master_lock, @kgdb_active)
> >> during cpu roundup. This will conflict with the printk cpulock.
> >
On Wed 2021-08-04 12:31:59, Daniel Thompson wrote:
> On Tue, Aug 03, 2021 at 05:36:32PM +0206, John Ogness wrote:
> > On 2021-08-03, Daniel Thompson wrote:
> > > On Tue, Aug 03, 2021 at 03:18:54PM +0206, John Ogness wrote:
> > >> kgdb makes use of its own cpulock (@dbg_master_lock, @kgdb_active)
On Wed, 4 Aug 2021 11:37:24 +1000
Jordan Niethe wrote:
> This is the same as commit acdad8fb4a15 ("powerpc: Force inlining of
> mmu_has_feature to fix build failure") but for radix_enabled(). The
> config in the linked bugzilla causes the following build failure:
> [...]
> The code relies on
On Wed, Aug 04, 2021 at 02:12:22PM +0200, Petr Mladek wrote:
> On Wed 2021-08-04 12:31:59, Daniel Thompson wrote:
> > On Tue, Aug 03, 2021 at 05:36:32PM +0206, John Ogness wrote:
> > > On 2021-08-03, Daniel Thompson wrote:
> > > > On Tue, Aug 03, 2021 at 03:18:54PM +0206, John Ogness wrote:
> > >
Excerpts from Christophe Leroy's message of August 4, 2021 11:28 pm:
>
>
> Le 04/08/2021 à 13:36, Nicholas Piggin a écrit :
>> Excerpts from Christophe Leroy's message of August 4, 2021 4:21 pm:
>>> Hi Nic,
>>>
>>> I think I'll need your help on that one.
>>>
>>> Le 04/08/2021 à 08:07,
When using kprobe on powerpc booke series processor, Oops happens
as show bellow:
[ 35.861352] Oops: Exception in kernel mode, sig: 5 [#1]
[ 35.861676] BE PAGE_SIZE=4K SMP NR_CPUS=24 QEMU e500
[ 35.861905] Modules linked in:
[ 35.862144] CPU: 0 PID: 76 Comm: sh Not tainted
https://bugzilla.kernel.org/show_bug.cgi?id=213961
--- Comment #4 from Christophe Leroy (christophe.le...@csgroup.eu) ---
Thanks, unfortunately the info is still not usable because we don't have
function names in the dump:
[ 15.810083] Call Trace:
[ 15.810090] [f2b6dc30] [c1022318]
Hi Christophe,
On Wed, 2021-08-04 at 07:52 +0200, Christophe Leroy wrote:
> Le 07/07/2021 à 07:55, Christophe Leroy a écrit :
> > 32 bits BOOKE have special interrupts for debug and other
> > critical events.
>
> Were you able to test this patch ?
I tested it three weeks ago and it works like a
https://bugzilla.kernel.org/show_bug.cgi?id=213961
--- Comment #3 from Elimar Riesebieter (riese...@lxtec.de) ---
Created attachment 298197
--> https://bugzilla.kernel.org/attachment.cgi?id=298197=edit
.config
--
You may reply to this email to add a comment.
You are receiving this mail
https://bugzilla.kernel.org/show_bug.cgi?id=213961
--- Comment #2 from Elimar Riesebieter (riese...@lxtec.de) ---
Created attachment 298195
--> https://bugzilla.kernel.org/attachment.cgi?id=298195=edit
dmesg dump
--
You may reply to this email to add a comment.
You are receiving this mail
Le 04/08/2021 à 13:36, Nicholas Piggin a écrit :
Excerpts from Christophe Leroy's message of August 4, 2021 4:21 pm:
Hi Nic,
I think I'll need your help on that one.
Le 04/08/2021 à 08:07, Christophe Leroy a écrit :
Le 04/08/2021 à 06:04, Finn Thain a écrit :
Hi Finn!
On Tue, 3 Aug
Excerpts from Christophe Leroy's message of August 4, 2021 4:21 pm:
> Hi Nic,
>
> I think I'll need your help on that one.
>
> Le 04/08/2021 à 08:07, Christophe Leroy a écrit :
>>
>>
>> Le 04/08/2021 à 06:04, Finn Thain a écrit :
Hi Finn!
>>> On Tue, 3 Aug 2021, Christophe Leroy wrote:
>>>
>
On Tue, Aug 03, 2021 at 05:36:32PM +0206, John Ogness wrote:
> On 2021-08-03, Daniel Thompson wrote:
> > On Tue, Aug 03, 2021 at 03:18:54PM +0206, John Ogness wrote:
> >> kgdb makes use of its own cpulock (@dbg_master_lock, @kgdb_active)
> >> during cpu roundup. This will conflict with the printk
On 04/08/21 15:31, Srikar Dronamraju wrote:
> * Srikar Dronamraju [2021-07-23 20:09:14]:
>
>> * Valentin Schneider [2021-07-13 17:32:14]:
>>
>> > On 12/07/21 18:18, Srikar Dronamraju wrote:
>> > > Hi Valentin,
>> > >
>> > >> On 01/07/21 09:45, Srikar Dronamraju wrote:
>> > >> > @@ -1891,12
* Srikar Dronamraju [2021-07-23 20:09:14]:
> * Valentin Schneider [2021-07-13 17:32:14]:
>
> > On 12/07/21 18:18, Srikar Dronamraju wrote:
> > > Hi Valentin,
> > >
> > >> On 01/07/21 09:45, Srikar Dronamraju wrote:
> > >> > @@ -1891,12 +1894,30 @@ void sched_init_numa(void)
> > >> > void
Excerpts from Christophe Leroy's message of August 4, 2021 6:37 pm:
>
>
> Le 04/08/2021 à 10:08, Nicholas Piggin a écrit :
>> Excerpts from Christophe Leroy's message of August 4, 2021 3:27 pm:
>>> In those hot functions that are called at every interrupt, any saved
>>> cycle is worth it.
>>>
Le 04/08/2021 à 10:08, Nicholas Piggin a écrit :
Excerpts from Christophe Leroy's message of August 4, 2021 3:27 pm:
In those hot functions that are called at every interrupt, any saved
cycle is worth it.
interrupt_exit_user_prepare() and interrupt_exit_kernel_prepare() are
called from
Excerpts from Christophe Leroy's message of August 4, 2021 3:27 pm:
> In those hot functions that are called at every interrupt, any saved
> cycle is worth it.
>
> interrupt_exit_user_prepare() and interrupt_exit_kernel_prepare() are
> called from three places:
> - From entry_32.S
> - From
On Wed, Aug 04, 2021 at 04:39:44PM +1000, Nicholas Piggin wrote:
> For that matter, I wonder if we shouldn't do something like this
> (untested) so the low level batch flush has visibility to the high
> level flush range.
>
> x86 could use this too AFAIKS, just needs to pass the range a bit
>
Nicholas Piggin writes:
> Excerpts from Aneesh Kumar K.V's message of August 4, 2021 12:37 am:
>> With shared mapping, even though we are unmapping a large range, the kernel
>> will force a TLB flush with ptl lock held to avoid the race mentioned in
>> commit 1cf35d47712d ("mm: split
Excerpts from Nicholas Piggin's message of August 4, 2021 3:14 pm:
> Excerpts from Aneesh Kumar K.V's message of August 4, 2021 12:37 am:
>> With shared mapping, even though we are unmapping a large range, the kernel
>> will force a TLB flush with ptl lock held to avoid the race mentioned in
>>
Le 04/08/2021 à 02:34, Finn Thain a écrit :
On Tue, 3 Aug 2021, Christophe Leroy wrote:
Looks like the memory errors are linked to KUAP (Kernel Userspace Access
Protection). Based on the places the problems happen, I don't think
there are any invalid access, so there must be something
Hi Nic,
I think I'll need your help on that one.
Le 04/08/2021 à 08:07, Christophe Leroy a écrit :
Le 04/08/2021 à 06:04, Finn Thain a écrit :
On Tue, 3 Aug 2021, Christophe Leroy wrote:
...
[ cut here ]
kernel BUG at arch/powerpc/kernel/interrupt.c:49!
Oops:
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git
next-test
branch HEAD: c09f799bf0fdc0eeb44db87df07a7a9632c3420c pseries/drmem: update
LMBs after LPM
elapsed time: 1007m
configs tested: 100
configs skipped: 3
The following configs have been built successfully.
Le 04/08/2021 à 06:04, Finn Thain a écrit :
On Tue, 3 Aug 2021, Christophe Leroy wrote:
When a DSI (Data Storage Interrupt) is taken while in NAP mode, r11
doesn't survive the call to power_save_ppc32_restore().
So use r1 instead of r11 as they both contain the virtual stack pointer
at
42 matches
Mail list logo
