Re: [PATCH v1 0/5] Implement livepatch on PPC32

2021-12-13 Thread Christophe Leroy
Le 14/12/2021 à 07:09, Christophe Leroy a écrit : Le 13/12/2021 à 20:46, Steven Rostedt a écrit : On Mon, 13 Dec 2021 19:33:47 + Christophe Leroy wrote: STill the same Oops, below Unfortunately, I don't have a PPC machine (32 nor 64 bit) to help debug this. I will look more

Re: [BUG] mtd: cfi_cmdset_0002: write regression since v4.17-rc1

2021-12-13 Thread Thorsten Leemhuis
[TLDR: adding this regression to regzbot; most of this mail is compiled from a few templates paragraphs some of you might have seen already.] Hi, this is your Linux kernel regression tracker speaking. Top-posting for once, to make this easy accessible to everyone. Thanks for the report. Adding

Re: [PATCH v1 0/5] Implement livepatch on PPC32

2021-12-13 Thread Christophe Leroy
Le 13/12/2021 à 20:46, Steven Rostedt a écrit : > On Mon, 13 Dec 2021 19:33:47 + > Christophe Leroy wrote: > >> STill the same Oops, below > > Unfortunately, I don't have a PPC machine (32 nor 64 bit) to help debug > this. > > >> I will look more closely tomorrow. > > OK, thanks. >

[Bug 215217] Kernel fails to boot at an early stage when built with GCC_PLUGIN_LATENT_ENTROPY=y (PowerMac G4 3,6)

2021-12-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215217 --- Comment #11 from Christophe Leroy (christophe.le...@csgroup.eu) --- Ok, so that's not enough, must be something else. I guess you are right next step should be analysis of the image. zImage however can hardly be used for that. Could you

Re: [PATCH]selftests/powerpc: skip tests for unavailable mitigations.

2021-12-13 Thread Nageswara Sastry
On 13/12/21 10:12 pm, Sachin Sant wrote: Mitigation patching test iterates over a set of mitigations irrespective of whether a certain mitigation is supported/available in the kernel. This causes following messages on a kernel where some mitigations are unavailable: Spawned threads

[Bug 215217] Kernel fails to boot at an early stage when built with GCC_PLUGIN_LATENT_ENTROPY=y (PowerMac G4 3,6)

2021-12-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215217 --- Comment #10 from Erhard F. (erhar...@mailbox.org) --- Created attachment 300015 --> https://bugzilla.kernel.org/attachment.cgi?id=300015=edit kernel zImage (5.16-rc5 + CFLAGS_setup_32.o/early_32.o +=... , PowerMac G4 DP) Unfortunately

Re: [PATCH 3/4] ASoC: fsl-asoc-card: Add optional dt property for setting mclk-id

2021-12-13 Thread Ariel D'Alessandro
Hi Rob, On 12/13/21 5:37 PM, Rob Herring wrote: > On Fri, Dec 03, 2021 at 10:49:29AM -0300, Ariel D'Alessandro wrote: >> Sound cards may allow using different main clock inputs. In the generic >> fsl-asoc-card driver, these values are hardcoded for each specific card >> configuration. >> >> Let's

Re: [PATCH 0/4] fsl-asoc-card: Add optional dt property for setting mclk-id

2021-12-13 Thread Ariel D'Alessandro
Hi Rob, Thanks for the review. On 12/13/21 5:35 PM, Rob Herring wrote: > On Fri, Dec 03, 2021 at 10:49:26AM -0300, Ariel D'Alessandro wrote: >> This is a follow up of patchset: >> >> [RFC patch 0/5] Support BCLK input clock in tlv320aic31xx > > Link? Link to the datasheet?

Re: [PATCH 3/4] ASoC: fsl-asoc-card: Add optional dt property for setting mclk-id

2021-12-13 Thread Rob Herring
On Fri, Dec 03, 2021 at 10:49:29AM -0300, Ariel D'Alessandro wrote: > Sound cards may allow using different main clock inputs. In the generic > fsl-asoc-card driver, these values are hardcoded for each specific card > configuration. > > Let's make it more flexible, allowing setting mclk-id from

Re: [PATCH 1/4] dt-bindings: sound: Rename tlv320aic31xx-micbias as tlv320aic31xx

2021-12-13 Thread Rob Herring
On Fri, 03 Dec 2021 10:49:27 -0300, Ariel D'Alessandro wrote: > Let's use a more generic name, so other definitions for tlv320aic31xx > can be included. > > Signed-off-by: Ariel D'Alessandro > --- > .../devicetree/bindings/sound/tlv320aic31xx.txt | 2 +- >

Re: [PATCH 0/4] fsl-asoc-card: Add optional dt property for setting mclk-id

2021-12-13 Thread Rob Herring
On Fri, Dec 03, 2021 at 10:49:26AM -0300, Ariel D'Alessandro wrote: > This is a follow up of patchset: > > [RFC patch 0/5] Support BCLK input clock in tlv320aic31xx Link? > Sound cards may allow using different main clock inputs. In the generic > fsl-asoc-card driver, these values are

Re: [PATCH] PCI/AER: potential dereference of null pointer

2021-12-13 Thread Bjorn Helgaas
On Mon, Dec 13, 2021 at 11:57:52AM -0800, Rajat Jain wrote: > Hello > > On Sat, Dec 11, 2021 at 9:54 AM Bjorn Helgaas wrote: > > > > [+cc Rajat, author of aer_stats: > > db89ccbe52c7 ("PCI/AER: Define aer_stats structure for AER capable devices" > > 81aa5206f9a7 ("PCI/AER: Add sysfs attributes

Re: [PATCH v1 0/5] Implement livepatch on PPC32

2021-12-13 Thread Steven Rostedt
On Mon, 13 Dec 2021 19:33:47 + Christophe Leroy wrote: > STill the same Oops, below Unfortunately, I don't have a PPC machine (32 nor 64 bit) to help debug this. > I will look more closely tomorrow. OK, thanks. -- Steve

Re: [PATCH v1 0/5] Implement livepatch on PPC32

2021-12-13 Thread Christophe Leroy
Le 13/12/2021 à 19:54, Steven Rostedt a écrit : > On Mon, 13 Dec 2021 17:50:52 + > Christophe Leroy wrote: > >> @@ -958,6 +942,12 @@ unsigned long prepare_ftrace_return(unsigned long >> parent, unsigned long ip, >>out: >> return parent; >>} >> + >> +void

Re: [PATCH v1 0/5] Implement livepatch on PPC32

2021-12-13 Thread Steven Rostedt
On Mon, 13 Dec 2021 17:50:52 + Christophe Leroy wrote: > @@ -958,6 +942,12 @@ unsigned long prepare_ftrace_return(unsigned long > parent, unsigned long ip, > out: > return parent; > } > + > +void ftrace_graph_func(unsigned long ip, unsigned long parent_ip, > +

Re: [PATCH v2] of/fdt: Rework early_init_dt_scan_memory() to call directly

2021-12-13 Thread Rob Herring
On Mon, Dec 13, 2021 at 6:47 AM Michael Ellerman wrote: > > Rob Herring writes: > > Use of the of_scan_flat_dt() function predates libfdt and is discouraged > > as libfdt provides a nicer set of APIs. Rework > > early_init_dt_scan_memory() to be called directly and use libfdt. > ... > > diff

Re: [PATCH v2 2/6] powerpc/kexec_file: Add KEXEC_SIG support.

2021-12-13 Thread Michal Suchánek
Hello, On Sun, Dec 12, 2021 at 07:46:53PM -0500, Nayna wrote: > > On 11/25/21 13:02, Michal Suchanek wrote: > > Copy the code from s390x > > > > Signed-off-by: Michal Suchanek > > --- > > arch/powerpc/Kconfig| 11 +++ > > arch/powerpc/kexec/elf_64.c | 36

Re: [PATCH v2 6/6] module: Move duplicate mod_check_sig users code to mod_parse_sig

2021-12-13 Thread Michal Suchánek
Hello, On Tue, Dec 07, 2021 at 05:10:34PM +0100, Philipp Rudo wrote: > Hi Michal, > > On Thu, 25 Nov 2021 19:02:44 +0100 > Michal Suchanek wrote: > > > Multiple users of mod_check_sig check for the marker, then call > > mod_check_sig, extract signature length, and remove the signature. > > >

[BUG] mtd: cfi_cmdset_0002: write regression since v4.17-rc1

2021-12-13 Thread Ahmad Fatoum
Hi, I've been investigating a breakage on a PowerPC MPC8313: The SoC is connected via the "Enhanced Local Bus Controller" to a 8-bit-parallel S29GL064N flash, which is represented as a memory-mapped cfi-flash. The regression began in v4.17-rc1 with dfeae1073583 ("mtd: cfi_cmdset_0002: Change

Re: [PATCH v1 0/5] Implement livepatch on PPC32

2021-12-13 Thread Christophe Leroy
Le 13/12/2021 à 18:33, Steven Rostedt a écrit : > On Mon, 13 Dec 2021 17:30:48 + > Christophe Leroy wrote: > >> Thanks, I will try that. >> >> I can't find ftrace_graph_func() in s390. Does it mean that s390 doesn't >> have a working function tracer anymore ? >> >> I see your commit

Re: [PATCH v1 0/5] Implement livepatch on PPC32

2021-12-13 Thread Steven Rostedt
On Mon, 13 Dec 2021 17:30:48 + Christophe Leroy wrote: > Thanks, I will try that. > > I can't find ftrace_graph_func() in s390. Does it mean that s390 doesn't > have a working function tracer anymore ? > > I see your commit 0c0593b45c9b4 ("x86/ftrace: Make function graph use > ftrace

Re: [PATCH v1 0/5] Implement livepatch on PPC32

2021-12-13 Thread Christophe Leroy
Le 13/12/2021 à 18:15, Steven Rostedt a écrit : > On Mon, 13 Dec 2021 14:39:15 + > Christophe Leroy wrote: > >>> Note, you can implement this first, (I looked over the patches and they >>> seem fine) and then update both ppc64 and ppc32 to implement >>> DYNAMIC_FTRACE_WITH_ARGS. >>> >>

Re: ppc64le STRICT_MODULE_RWX and livepatch apply_relocate_add() crashes

2021-12-13 Thread Joe Lawrence
On 12/13/21 11:36 AM, Christophe Leroy wrote: > > > Le 13/12/2021 à 15:47, Joe Lawrence a écrit : >> On 12/13/21 2:42 AM, Christophe Leroy wrote: >>> >>> Hello Joe, >>> >>> I'm implementing LIVEPATCH on PPC32 and I wanted to test with >>> STRICT_MODULE_RWX enabled so I took your branch as

Re: [PATCH v1 0/5] Implement livepatch on PPC32

2021-12-13 Thread Steven Rostedt
On Mon, 13 Dec 2021 14:39:15 + Christophe Leroy wrote: > > Note, you can implement this first, (I looked over the patches and they > > seem fine) and then update both ppc64 and ppc32 to implement > > DYNAMIC_FTRACE_WITH_ARGS. > > > > I tried to activate DYNAMIC_FTRACE_WITH_ARGS on PPC32.

[PATCH]selftests/powerpc: skip tests for unavailable mitigations.

2021-12-13 Thread Sachin Sant
Mitigation patching test iterates over a set of mitigations irrespective of whether a certain mitigation is supported/available in the kernel. This causes following messages on a kernel where some mitigations are unavailable: Spawned threads enabling/disabling mitigations ... cat:

[Bug 215217] Kernel fails to boot at an early stage when built with GCC_PLUGIN_LATENT_ENTROPY=y (PowerMac G4 3,6)

2021-12-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215217 --- Comment #9 from Christophe Leroy (christophe.le...@csgroup.eu) --- Erhard, were you able to redo the test with DISABLE_LATENT_ENTROPY_PLUGIN also disabled for early_32.o ? If you can try with it disabled for both early_32.o and setup_32.o

Re: ppc64le STRICT_MODULE_RWX and livepatch apply_relocate_add() crashes

2021-12-13 Thread Christophe Leroy
Le 13/12/2021 à 15:47, Joe Lawrence a écrit : > On 12/13/21 2:42 AM, Christophe Leroy wrote: >> >> Hello Joe, >> >> I'm implementing LIVEPATCH on PPC32 and I wanted to test with >> STRICT_MODULE_RWX enabled so I took your branch as suggested, but I'm >> getting the following errors on build.

Re: ppc64le STRICT_MODULE_RWX and livepatch apply_relocate_add() crashes

2021-12-13 Thread Joe Lawrence
On 12/13/21 2:42 AM, Christophe Leroy wrote: > > Hello Joe, > > I'm implementing LIVEPATCH on PPC32 and I wanted to test with > STRICT_MODULE_RWX enabled so I took your branch as suggested, but I'm > getting the following errors on build. What shall I do ? > >CALL

Re: [PATCH v2 0/2] kdump: simplify code

2021-12-13 Thread Matthew Wilcox
On Mon, Dec 13, 2021 at 08:30:33AM +, David Laight wrote: > From: Matthew Wilcox > > Sent: 12 December 2021 11:48 > > > > On Sat, Dec 11, 2021 at 05:53:46PM +, David Laight wrote: > > > From: Tiezhu Yang > > > > Sent: 11 December 2021 03:33 > > > > > > > > v2: > > > > -- add

Re: [PATCH v1 0/5] Implement livepatch on PPC32

2021-12-13 Thread Christophe Leroy
Le 28/10/2021 à 15:35, Steven Rostedt a écrit : > On Thu, 28 Oct 2021 14:24:00 +0200 > Christophe Leroy wrote: > >> This series implements livepatch on PPC32. >> >> This is largely copied from what's done on PPC64. >> >> Christophe Leroy (5): >>livepatch: Fix build failure on 32 bits

Re: [patch V3 27/35] PCI/MSI: Use __msi_get_virq() in pci_get_vector()

2021-12-13 Thread Jason Gunthorpe
On Fri, Dec 10, 2021 at 11:19:25PM +0100, Thomas Gleixner wrote: > From: Thomas Gleixner > > Use msi_get_vector() and handle the return value to be compatible. > > No functional change intended. > > Signed-off-by: Thomas Gleixner > Reviewed-by: Greg Kroah-Hartman > --- > V2: Handle the INTx

Re: [patch V3 26/35] genirq/msi: Provide interface to retrieve Linux interrupt number

2021-12-13 Thread Jason Gunthorpe
On Fri, Dec 10, 2021 at 11:19:23PM +0100, Thomas Gleixner wrote: > From: Thomas Gleixner > > This allows drivers to retrieve the Linux interrupt number instead of > fiddling with MSI descriptors. > > msi_get_virq() returns the Linux interrupt number or 0 in case that there > is no entry for the

Re: [patch V3 25/35] powerpc/pseries/msi: Let core code check for contiguous entries

2021-12-13 Thread Jason Gunthorpe
On Fri, Dec 10, 2021 at 11:19:22PM +0100, Thomas Gleixner wrote: > From: Thomas Gleixner > > Set the domain info flag and remove the check. > > Signed-off-by: Thomas Gleixner > Reviewed-by: Greg Kroah-Hartman > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: "Cédric Le Goater" >

Re: [patch V3 06/35] powerpc/pseries/msi: Use PCI device properties

2021-12-13 Thread Jason Gunthorpe
On Fri, Dec 10, 2021 at 11:18:52PM +0100, Thomas Gleixner wrote: > From: Thomas Gleixner > > instead of fiddling with MSI descriptors. > > Signed-off-by: Thomas Gleixner > Cc: Michael Ellerman > Cc: linuxppc-dev@lists.ozlabs.org > --- > V3: Use pci_dev->msix_enabled - Jason > --- >

Re: [patch V3 05/35] powerpc/cell/axon_msi: Use PCI device property

2021-12-13 Thread Jason Gunthorpe
On Fri, Dec 10, 2021 at 11:18:51PM +0100, Thomas Gleixner wrote: > From: Thomas Gleixner > > instead of fiddling with MSI descriptors. > > Signed-off-by: Thomas Gleixner > Cc: Arnd Bergmann > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: linuxppc-dev@lists.ozlabs.org > --- > V3:

Re: [patch V3 04/35] genirq/msi: Use PCI device property

2021-12-13 Thread Jason Gunthorpe
On Fri, Dec 10, 2021 at 11:18:49PM +0100, Thomas Gleixner wrote: > From: Thomas Gleixner > > to determine whether this is MSI or MSIX instead of consulting MSI > descriptors. > > Signed-off-by: Thomas Gleixner > --- > V2: Use PCI device property - Jason > --- > kernel/irq/msi.c | 17

Re: [patch V3 03/35] x86/apic/msi: Use PCI device MSI property

2021-12-13 Thread Jason Gunthorpe
On Fri, Dec 10, 2021 at 11:18:47PM +0100, Thomas Gleixner wrote: > From: Thomas Gleixner > > instead of fiddling with MSI descriptors. > > Signed-off-by: Thomas Gleixner > --- > V3: Use pci_dev->msix_enabled - Jason > --- > arch/x86/kernel/apic/msi.c |5 + > 1 file changed, 1

Re: [patch V3 02/35] x86/pci/XEN: Use PCI device property

2021-12-13 Thread Jason Gunthorpe
On Fri, Dec 10, 2021 at 11:18:46PM +0100, Thomas Gleixner wrote: > From: Thomas Gleixner > > instead of fiddling with MSI descriptors. > > Signed-off-by: Thomas Gleixner > Cc: Juergen Gross > Cc: xen-de...@lists.xenproject.org > --- > V3: Use pci_dev->msix_enabled. > --- > arch/x86/pci/xen.c

Re: [patch V3 01/35] PCI/MSI: Set pci_dev::msi[x]_enabled early

2021-12-13 Thread Jason Gunthorpe
On Fri, Dec 10, 2021 at 11:18:44PM +0100, Thomas Gleixner wrote: > There are quite some places which retrieve the first MSI descriptor to > evaluate whether the setup is for MSI or MSI-X. That's required because > pci_dev::msi[x]_enabled is only set when the setup completed successfully. > >

Re: [PATCH v4 06/10] powerpc/mm: Use generic_get_unmapped_area() and call it from arch_get_unmapped_area()

2021-12-13 Thread Michael Ellerman
Christophe Leroy writes: > Use the generic version of arch_get_unmapped_area() which > is now available at all time instead of its copy > radix__arch_get_unmapped_area() > > Instead of setting mm->get_unmapped_area() to either > arch_get_unmapped_area() or generic_get_unmapped_area(), > always

Re: [PATCH v2] of/fdt: Rework early_init_dt_scan_memory() to call directly

2021-12-13 Thread Michael Ellerman
Rob Herring writes: > Use of the of_scan_flat_dt() function predates libfdt and is discouraged > as libfdt provides a nicer set of APIs. Rework > early_init_dt_scan_memory() to be called directly and use libfdt. ... > diff --git a/arch/powerpc/kernel/prom.c b/arch/powerpc/kernel/prom.c > index

Re: [PATCH v4 05/25] reboot: Warn if restart handler has duplicated priority

2021-12-13 Thread Geert Uytterhoeven
On Fri, Dec 10, 2021 at 8:14 PM Rafael J. Wysocki wrote: > On Fri, Dec 10, 2021 at 8:04 PM Dmitry Osipenko wrote: > > 10.12.2021 21:27, Rafael J. Wysocki пишет: > > > On Mon, Nov 29, 2021 at 12:34 PM Dmitry Osipenko wrote: > > >> 29.11.2021 03:26, Michał Mirosław пишет: > > >>> On Mon, Nov 29,

[PATCH] arch: powerpc: add missing of_node_put before break

2021-12-13 Thread Qing Wang
From: Wang Qing Fix following coccicheck warning: WARNING: Function "for_each_node_by_name" should have of_node_put() before return. Early exits from for_each_node_by_name should decrement the node reference counter. Signed-off-by: Wang Qing --- arch/powerpc/platforms/powermac/smp.c | 4

RE: [PATCH v2 0/2] kdump: simplify code

2021-12-13 Thread David Laight
From: Matthew Wilcox > Sent: 12 December 2021 11:48 > > On Sat, Dec 11, 2021 at 05:53:46PM +, David Laight wrote: > > From: Tiezhu Yang > > > Sent: 11 December 2021 03:33 > > > > > > v2: > > > -- add copy_to_user_or_kernel() in lib/usercopy.c > > > -- define userbuf as bool type > > > >