Re:

2022-04-22 Thread Nicholas Piggin
Excerpts from Thomas Gleixner's message of April 23, 2022 1:53 am: > On Wed, Apr 13 2022 at 15:11, Nicholas Piggin wrote: >> So we traced the problem down to possibly a misunderstanding between >> decrementer clock event device and core code. >> >> The decrementer is only oneshot*ish*. It

Re: [PATCH] net: unexport csum_and_copy_{from,to}_user

2022-04-22 Thread Jakub Kicinski
On Thu, 21 Apr 2022 09:04:40 +0200 Christoph Hellwig wrote: > csum_and_copy_from_user and csum_and_copy_to_user are exported by > a few architectures, but not actually used in modular code. Drop > the exports. > > Signed-off-by: Christoph Hellwig Judging by the To: I presume the intention is

Re: [PATCH v4 1/2] PCI/AER: Disable AER service when link is in L2/L3 ready, L2 and L3 state

2022-04-22 Thread Bjorn Helgaas
[+cc Rafael, linux-pm; sorry forgot this last time] On Fri, Apr 22, 2022 at 05:24:36PM -0500, Bjorn Helgaas wrote: > On Fri, Apr 08, 2022 at 11:31:58PM +0800, Kai-Heng Feng wrote: > > On Intel Alder Lake platforms, Thunderbolt entering D3cold can cause > > some errors reported by AER: > > [

Re: [PATCH v4 2/2] PCI/PM: Fix pci_pm_suspend_noirq() to disable PTM

2022-04-22 Thread Bjorn Helgaas
[+cc other folks interested in PTM from https://lore.kernel.org/r/20220408153159.106741-1-kai.heng.f...@canonical.com] On Thu, Apr 14, 2022 at 07:54:02PM +0200, Rafael J. Wysocki wrote: > On 3/25/2022 8:50 PM, Rajvi Jingar wrote: > > For the PCIe devices (like nvme) that do not go into D3 state

Re: [PATCH v4 1/2] PCI/AER: Disable AER service when link is in L2/L3 ready, L2 and L3 state

2022-04-22 Thread Bjorn Helgaas
[+cc Rajvi, David] On Fri, Apr 08, 2022 at 11:31:58PM +0800, Kai-Heng Feng wrote: > On Intel Alder Lake platforms, Thunderbolt entering D3cold can cause > some errors reported by AER: > [ 30.100211] pcieport :00:1d.0: AER: Uncorrected (Non-Fatal) error > received: :00:1d.0 > [

Re: [PATCH] powerpc/pci: Remove useless null check before call of_node_put()

2022-04-22 Thread Tyrel Datwyler
On 4/20/22 19:52, Haowen Bai wrote: > No need to add null check before call of_node_put(), since the > implementation of of_node_put() has done it. > > Signed-off-by: Haowen Bai > --- > arch/powerpc/kernel/pci_dn.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH 0/7] Remove unused SLOW_DOWN_IO

2022-04-22 Thread Jakub Kicinski
On Fri, 15 Apr 2022 14:08:10 -0500 Bjorn Helgaas wrote: > From: Bjorn Helgaas > > Only alpha, ia64, powerpc, and sh define SLOW_DOWN_IO, and there are no > actual uses of it. The few references to it are in situations that are > themselves unused. Remove them all. > > It should be safe to

Re:

2022-04-22 Thread Thomas Gleixner
On Wed, Apr 13 2022 at 15:11, Nicholas Piggin wrote: > So we traced the problem down to possibly a misunderstanding between > decrementer clock event device and core code. > > The decrementer is only oneshot*ish*. It actually needs to either be > reprogrammed or shut down otherwise it just

[PATCH] timers/nohz: Low-res tick handler switch to ONESHOT_STOPPED if tick stops

2022-04-22 Thread Nicholas Piggin
When tick_nohz_stop_tick() stops the tick, the the clock event device is not put into ONESHOT_STOPPED mode. This can lead to spurious timer interrupts with some clock event device drivers that don't shut down entirely after firing. Eliminate these by putting the device into ONESHOT_STOPPED mode

Re: [PATCH -next v4 1/7] x86, powerpc: fix function define in copy_mc_to_user

2022-04-22 Thread Michael Ellerman
Tong Tiangen writes: > x86/powerpc has it's implementation of copy_mc_to_user but not use #define > to declare. > > This may cause problems, for example, if other architectures open > CONFIG_ARCH_HAS_COPY_MC, but want to use copy_mc_to_user() outside the > architecture, the code add to

Re: [PATCH] misc: ocxl: fix possible double free in ocxl_file_register_afu

2022-04-22 Thread Michael Ellerman
Frederic Barrat writes: > On 21/04/2022 00:54, Michael Ellerman wrote: >> Hangyu Hua writes: >>> info_release() will be called in device_unregister() when info->dev's >>> reference count is 0. So there is no need to call ocxl_afu_put() and >>> kfree() again. >> >> Double frees are often

Re: [PATCH v1 06/22] powerpc/ftrace: Inline ftrace_modify_code()

2022-04-22 Thread Michael Ellerman
"Naveen N. Rao" writes: > Christophe Leroy wrote: >> Inlining ftrace_modify_code(), it increases a bit the >> size of ftrace code but brings 5% improvment on ftrace >> activation. >> >> Signed-off-by: Christophe Leroy >> --- >> arch/powerpc/kernel/trace/ftrace.c | 2 +- >> 1 file changed, 1

Re: [PATCH] macintosh: macio_asic: fix resource_size.cocci warnings

2022-04-22 Thread Michael Ellerman
Yihao Han writes: > drivers/macintosh/macio_asic.c:219:26-29: WARNING: > Suspicious code. resource_size is maybe missing with res > drivers/macintosh/macio_asic.c:221:26-29: WARNING: > Suspicious code. resource_size is maybe missing with res > > Use resource_size function on resource object