Re: [PATCH] powerpc/prom_init: Add memset as valid external symbol if CONFIG_KASAN=y

Le 19/06/2022 à 08:45, Christophe Leroy a écrit : Le 19/06/2022 à 05:52, Guenter Roeck a écrit : If CONFIG_KASAN=y, powerpc:allmodconfig fails to build with the following error. Error: External symbol 'memset' referenced from prom_init.c The problem was introduced with commit 41b7a347bf14

Re: [PATCH] powerpc/prom_init: Add memset as valid external symbol if CONFIG_KASAN=y

Le 19/06/2022 à 05:52, Guenter Roeck a écrit : > If CONFIG_KASAN=y, powerpc:allmodconfig fails to build with the following > error. > > Error: External symbol 'memset' referenced from prom_init.c > > The problem was introduced with commit 41b7a347bf14 ("powerpc: Book3S > 64-bit outline-only KAS

Re: [PATCH] powerpc/interrupt: Put braces around empty body in an 'if' statement

On Sun, Jun 19, 2022 at 11:13 AM Randy Dunlap wrote: > > > > On 6/18/22 20:11, Souptick Joarder wrote: > > From: "Souptick Joarder (HPE)" > > > > Kernel test robot throws warning -> > > > > arch/powerpc/kernel/interrupt.c: > > In function 'interrupt_exit_kernel_prepare': > > > >>> arch/powerpc/ke

Re: [PATCH] powerpc/interrupt: Put braces around empty body in an 'if' statement

Le 19/06/2022 à 05:11, Souptick Joarder a écrit : > From: "Souptick Joarder (HPE)" > > Kernel test robot throws warning -> > > arch/powerpc/kernel/interrupt.c: > In function 'interrupt_exit_kernel_prepare': > >>> arch/powerpc/kernel/interrupt.c:542:55: warning: suggest > braces around empty b

Re: [PATCH] powerpc/interrupt: Put braces around empty body in an 'if' statement

On 6/18/22 20:11, Souptick Joarder wrote: > From: "Souptick Joarder (HPE)" > > Kernel test robot throws warning -> > > arch/powerpc/kernel/interrupt.c: > In function 'interrupt_exit_kernel_prepare': > >>> arch/powerpc/kernel/interrupt.c:542:55: warning: suggest > braces around empty body in

[PATCH] powerpc/prom_init: Add memset as valid external symbol if CONFIG_KASAN=y

If CONFIG_KASAN=y, powerpc:allmodconfig fails to build with the following error. Error: External symbol 'memset' referenced from prom_init.c The problem was introduced with commit 41b7a347bf14 ("powerpc: Book3S 64-bit outline-only KASAN support"). So far, with CONFIG_KASAN=y, only __memset was ac

[PATCH] powerpc/interrupt: Put braces around empty body in an 'if' statement

From: "Souptick Joarder (HPE)" Kernel test robot throws warning -> arch/powerpc/kernel/interrupt.c: In function 'interrupt_exit_kernel_prepare': >> arch/powerpc/kernel/interrupt.c:542:55: warning: suggest braces around empty body in an 'if' statement [-Wempty-body] 542 | CT

[powerpc:fixes-test] BUILD SUCCESS 7bc08056a6dabc3a1442216daf527edf61ac24b6

tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git fixes-test branch HEAD: 7bc08056a6dabc3a1442216daf527edf61ac24b6 powerpc/rtas: Allow ibm,platform-dump RTAS call with null buffer address elapsed time: 723m configs tested: 114 configs skipped: 94 The following con

Re: [PATCH] tty: serial: Fix refcount leak bug in ucc_uart.c

On Sat, Jun 18, 2022 at 1:09 AM Liang He wrote: > > In soc_info(), of_find_node_by_type() will return a node pointer > with refcount incremented. We should use of_node_put() when it is > not used anymore. > > Signed-off-by: Liang He Acked-by: Timur Tabi

Re:Re: [PATCH] powerpc: kernel: Change the order of of_node_put()

At 2022-06-18 16:48:26, "Christophe Leroy" wrote: > > >Le 18/06/2022 à 10:03, Liang He a écrit : >> >> >> >> >> >> 在 2022-06-18 15:13:13，"Christophe Leroy" 写道： >>> >>> >>> Le 17/06/2022 à 13:26, Liang He a écrit : In add_pcspkr(), it is better to call of_node_put() after the '

Re: [PATCH -next v5 6/8] arm64: add support for machine check error safe

On Sat, Jun 18, 2022 at 05:18:55PM +0800, Tong Tiangen wrote: > 在 2022/6/17 16:55, Mark Rutland 写道: > > On Sat, May 28, 2022 at 06:50:54AM +, Tong Tiangen wrote: > > > +static bool arm64_do_kernel_sea(unsigned long addr, unsigned int esr, > > > + struct pt_regs *reg

Re: [PATCH -next v5 2/8] arm64: extable: make uaaccess helper use extable type EX_TYPE_UACCESS_ERR_ZERO

On Sat, Jun 18, 2022 at 04:42:06PM +0800, Tong Tiangen wrote: > > > > diff --git a/arch/arm64/include/asm/asm-extable.h > > > > b/arch/arm64/include/asm/asm-extable.h > > > > index 56ebe183e78b..9c94ac1f082c 100644 > > > > --- a/arch/arm64/include/asm/asm-extable.h > > > > +++ b/arch/arm64/include/

Re: [PATCH -next v5 7/8] arm64: add uaccess to machine check safe

On Sat, Jun 18, 2022 at 05:27:45PM +0800, Tong Tiangen wrote: > > > 在 2022/6/17 17:06, Mark Rutland 写道: > > On Sat, May 28, 2022 at 06:50:55AM +, Tong Tiangen wrote: > > > If user access fail due to hardware memory error, only the relevant > > > processes are affected, so killing the user pro

Re: [PATCH] powerpc: kernel: Change the order of of_node_put()

Le 18/06/2022 à 10:03, Liang He a écrit : > > > > > > 在 2022-06-18 15:13:13，"Christophe Leroy" 写道： >> >> >> Le 17/06/2022 à 13:26, Liang He a écrit : >>> In add_pcspkr(), it is better to call of_node_put() after the >>> 'if(!np)' check. >> >> Why is it better ? >> >> >> >> /** >> * of_nod

Re:Re: [PATCH] powerpc: kernel: Change the order of of_node_put()

在 2022-06-18 15:13:13，"Christophe Leroy" 写道： > > >Le 17/06/2022 à 13:26, Liang He a écrit : >> In add_pcspkr(), it is better to call of_node_put() after the >> 'if(!np)' check. > >Why is it better ? > > > >/** > * of_node_put() - Decrement refcount of a node > * @node: Node to dec refco

Re: [PATCH] powerpc: powernv: Fix refcount leak bug in opal-powercap

Le 17/06/2022 à 07:42, Liang He a écrit : At 2022-06-17 13:01:27, "Christophe JAILLET" wrote: Le 17/06/2022 à 06:20, Liang He a écrit : In opal_powercap_init(), of_find_compatible_node() will return a node pointer with refcount incremented. We should use of_node_put() in fail path or when

[PATCH] powerpc: perf: Fix refcount leak bug in imc-pmu.c

In update_events_in_group(), of_find_node_by_phandle() will return a node pointer with refcount incremented. We should use of_node_put() in fail path or when it is not used anymore. Signed-off-by: Liang He --- arch/powerpc/perf/imc-pmu.c | 10 -- 1 file changed, 8 insertions(+), 2 deleti

Re: [PATCH] powerpc: kernel: Change the order of of_node_put()

Le 17/06/2022 à 13:26, Liang He a écrit : > In add_pcspkr(), it is better to call of_node_put() after the > 'if(!np)' check. Why is it better ? /** * of_node_put() - Decrement refcount of a node * @node: Node to dec refcount, NULL is supported to simplify writing of * c