On 19/07/2022 04:09, Jason Gunthorpe wrote:
On Thu, Jul 14, 2022 at 06:18:22PM +1000, Alexey Kardashevskiy wrote:
+/*
+ * A simple iommu_ops to allow less cruft in generic VFIO code.
+ */
+static bool spapr_tce_iommu_capable(enum iommu_cap cap)
+{
+ switch (cap) {
+ case IOMMU_CA
Comments inline.
Reviewed-by: Greg Joyce
From: Nayna Jain
Sent: Tuesday, July 12, 2022 7:59 PM
To: linuxppc-dev@lists.ozlabs.org
Cc: Michael Ellerman ; Benjamin Herrenschmidt
; Paul Mackerras ; George Wilson
; Gregory Joyce ; Nayna Jain
Subject: [PATCH 1/2]
Tested-by: Greg Joyce
From: Nayna Jain
Sent: Tuesday, July 12, 2022 7:59 PM
To: linuxppc-dev@lists.ozlabs.org
Cc: Michael Ellerman ; Benjamin Herrenschmidt
; Paul Mackerras ; George Wilson
; Gregory Joyce ; Nayna Jain
Subject: [PATCH 1/2] powerpc/pseries: de
On Mon, Jul 18, 2022 at 3:12 PM Segher Boessenkool
wrote:
>
> Assembler language is unforgiving. It isn't easy to write, and most
> mistakes will not be diagnosed. If the assmbler language makes it
> easier to read the code, that makes it more likely correct code will be
> written, and that corr
On Mon, Jul 18, 2022 at 12:06:52PM -0700, Linus Torvalds wrote:
> On Sun, Jul 17, 2022 at 9:41 PM Michael Ellerman wrote:
> > > li 4,254 #,
> >
> > Here we load 254 into r4, which is the 2nd parameter to memset (c).
>
> I love how even powerpc people know that "4" is bogus
On Sun, Jul 17, 2022 at 9:41 PM Michael Ellerman wrote:
>
> > li 4,254 #,
>
> Here we load 254 into r4, which is the 2nd parameter to memset (c).
I love how even powerpc people know that "4" is bogus, and have to
make it clear that it means "r4".
I don't understand why th
On Mon, Jul 18, 2022 at 6:44 AM Michael Ellerman wrote:
>
> With GCC 12, allmodconfig enables CONFIG_INIT_STACK_ALL_PATTERN, which
> causes the compiler to emit memset calls to initialise on-stack
> variables with a pattern.
Ahh, and that explains why "volatile" made no difference. That did
seem
On Thu, Jul 14, 2022 at 06:18:22PM +1000, Alexey Kardashevskiy wrote:
> +/*
> + * A simple iommu_ops to allow less cruft in generic VFIO code.
> + */
> +static bool spapr_tce_iommu_capable(enum iommu_cap cap)
> +{
> + switch (cap) {
> + case IOMMU_CAP_CACHE_COHERENCY:
I would add a remark
On Thu, Jul 14, 2022 at 06:18:21PM +1000, Alexey Kardashevskiy wrote:
> The following patches are going to add dependency/use of iommu_ops which
> is initialized in subsys_initcall as well.
>
> This moves pciobios_init() to the next initcall level.
>
> This should not cause behavioral change.
>
On Thu, Jul 14, 2022 at 06:18:20PM +1000, Alexey Kardashevskiy wrote:
> PPC64 IOMMU API defines iommu_table_group_ops which handles DMA windows
> for PEs: control the ownership, create/set/unset a table the hardware
> for dynamic DMA windows (DDW). VFIO uses the API to implement support
> on POWER.
On Mon, Jul 18, 2022 at 2:44 PM Michael Ellerman wrote:
>
> With GCC 12 allmodconfig prom_init fails to build:
>
> Error: External symbol 'memset' referenced from prom_init.c
> make[2]: *** [arch/powerpc/kernel/Makefile:204:
> arch/powerpc/kernel/prom_init_check] Error 1
>
>
> Reported-by:
On Mon, Jul 18, 2022 at 01:52:38PM +1000, Michael Ellerman wrote:
> Segher Boessenkool writes:
> > Can't we simply have a small simple implementation of these functions in
> > arch/powerpc/boot/? This stuff is not performance-critical, and this is
> > not the first time we hit these problems.
>
The double `when' is duplicated in line 1069, remove one.
Signed-off-by: Jason Wang
---
drivers/ps3/ps3-lpm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ps3/ps3-lpm.c b/drivers/ps3/ps3-lpm.c
index 65512b6cc6fd..200ad8751860 100644
--- a/drivers/ps3/ps3-lpm.c
+++
With GCC 12 allmodconfig prom_init fails to build:
Error: External symbol 'memset' referenced from prom_init.c
make[2]: *** [arch/powerpc/kernel/Makefile:204:
arch/powerpc/kernel/prom_init_check] Error 1
The allmodconfig build enables KASAN, so all calls to memset in
prom_init should be conv
Hey again,
On Tue, Jul 12, 2022 at 01:24:46AM +0200, Jason A. Donenfeld wrote:
> These are two small cleanups for -next. This v5 rebases on the latest
> git master, as some whitespace was added that made v4 no longer apply.
>
> Jason A. Donenfeld (2):
> powerpc/powernv: rename remaining rng pow
"Jason A. Donenfeld" writes:
> When RDRAND was introduced, there was much discussion on whether it
> should be trusted and how the kernel should handle that. Initially, two
> mechanisms cropped up, CONFIG_ARCH_RANDOM, a compile time switch, and
> "nordrand", a boot-time switch.
...
>
> arch/arm/i
> Fix it by removing the xfs_buf_init/terminate wrappers that just
> allocate and destroy the xfs_buf slab, and move them to the same
> place that all the other slab caches are set up and destroyed.
>
> Reported-by: Sachin Sant
> Fixes: 298f34224506 ("xfs: lockless buffer lookup")
> Signed-off-
The double `is' is duplicated in line 110, remove one.
Signed-off-by: Jason Wang
---
arch/powerpc/sysdev/cpm2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/sysdev/cpm2.c b/arch/powerpc/sysdev/cpm2.c
index 3f130312b6e9..915f4d3991c3 100644
--- a/arch/powerpc/s
Hello!
I tested in my AmigaOne X5000 (QuorIQ 5020/5040) a combined Sata3/USB3 pcie
controller board from Delock
(https://www.delock.de/produkt/89389/merkmale.html?setLanguage=en). The ASM
1042, ASM 1061 and ASM 1182 chipsets are used on this board.
The Sata controller seems to work without iss
The double `that' is duplicated in line 1604, remove one.
Signed-off-by: Jason Wang
---
arch/powerpc/kvm/book3s_64_mmu_hv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c
b/arch/powerpc/kvm/book3s_64_mmu_hv.c
index 514fd45c1994..73c6db20c
The double `that' is duplicated in line 1604, remove one.
Signed-off-by: Jason Wang
---
arch/powerpc/kvm/book3s_64_mmu_hv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c
b/arch/powerpc/kvm/book3s_64_mmu_hv.c
index 514fd45c1994..73c6db20c
Since commit 87c78b612f4f ("powerpc: Fix all occurences of "the the"")
fixed "the the", there's now a steady stream of patches fixing other
duplicate words.
Just fix them all at once, to save the overhead of dealing with
individual patches for each case.
This leaves a few cases of "that that", wh
On Mon, Jul 18, 2022 at 6:33 AM Christoph Hellwig wrote:
>
> On Sun, Jul 17, 2022 at 12:34:52PM +0900, Stafford Horne wrote:
> > The generic pci.h header now only provides a definition of
> > pci_get_legacy_ide_irq which is used by architectures that support PNP.
> > Of the architectures that use
On Mon, Jul 18, 2022 at 2:41 AM Stafford Horne wrote:
> The generic pci.h header now only provides a definition of
> pci_get_legacy_ide_irq which is used by architectures that support PNP.
> Of the architectures that use asm-generic/pci.h this is only x86.
>
> This patch removes the old pci.h in o
On Mon, Jul 18, 2022 at 12:01:53PM +0530, Sachin Sant wrote:
> While running xfstests (specifically xfs/435) on a IBM Power server booted
> with
> 5.19.0-rc6-next-20220715 following warnings are seen:
>
>
> [ 110.954136] XFS (sdb2): Unmounting Filesystem
> [ 110.968860] XFS (sdb1): Unmounting
The double `the' in line 807 is duplicated, remove one.
Signed-off-by: Jason Wang
---
arch/powerpc/platforms/pseries/vas.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/pseries/vas.c
b/arch/powerpc/platforms/pseries/vas.c
index 91e7eda0606c..7e6e6dd2
From: Michael Ellerman
> Sent: 18 July 2022 05:41
...
> So we're memsetting all of args to 254, not zero.
>
> That's happening because allmodconfig with gcc 12 enables
> CONFIG_INIT_STACK_ALL_PATTERN, whereas gcc 11 doesn't.
I can't help feeling it would be better if that generated
a call to a me
27 matches
Mail list logo
