Re: [PATCH v3 2/3] mm/migrate_device.c: Copy pte dirty bit to page

2022-08-25 Thread Huang, Ying
Alistair Popple writes: > Peter Xu writes: > >> On Fri, Aug 26, 2022 at 08:21:44AM +1000, Alistair Popple wrote: >>> >>> Peter Xu writes: >>> >>> > On Wed, Aug 24, 2022 at 01:03:38PM +1000, Alistair Popple wrote: >>> >> migrate_vma_setup() has a fast path in migrate_vma_collect_pmd() that >>>

Re: [PATCH v3 2/3] mm/migrate_device.c: Copy pte dirty bit to page

2022-08-25 Thread Alistair Popple
Peter Xu writes: > On Fri, Aug 26, 2022 at 08:21:44AM +1000, Alistair Popple wrote: >> >> Peter Xu writes: >> >> > On Wed, Aug 24, 2022 at 01:03:38PM +1000, Alistair Popple wrote: >> >> migrate_vma_setup() has a fast path in migrate_vma_collect_pmd() that >> >> installs migration entries

Re: [PATCH v3 1/3] mm/migrate_device.c: Flush TLB while holding PTL

2022-08-25 Thread Huang, Ying
Alistair Popple writes: > "Huang, Ying" writes: > >> Alistair Popple writes: >> >>> When clearing a PTE the TLB should be flushed whilst still holding the >>> PTL to avoid a potential race with madvise/munmap/etc. For example >>> consider the following sequence: >>> >>> CPU0

Re: [PATCH v2 1/2] mm/migrate_device.c: Copy pte dirty bit to page

2022-08-25 Thread Peter Xu
On Fri, Aug 26, 2022 at 08:09:28AM +1000, Alistair Popple wrote: > > I looked at some of the callers, it seems not all of them are ready to > > handle that (__kvmppc_svm_page_out() or svm_migrate_vma_to_vram()). Is it > > safe? Do the callers need to always properly handle that (unless the > >

Re: [PATCH v3 2/3] mm/migrate_device.c: Copy pte dirty bit to page

2022-08-25 Thread Peter Xu
On Fri, Aug 26, 2022 at 08:21:44AM +1000, Alistair Popple wrote: > > Peter Xu writes: > > > On Wed, Aug 24, 2022 at 01:03:38PM +1000, Alistair Popple wrote: > >> migrate_vma_setup() has a fast path in migrate_vma_collect_pmd() that > >> installs migration entries directly if it can lock the

Re: [PATCH] powerpc: align syscall table for ppc32

2022-08-25 Thread Michael Ellerman
Masahiro Yamada writes: > On Thu, Aug 25, 2022 at 4:53 PM Michael Ellerman wrote: >> >> Masahiro Yamada writes: >> > Christophe Leroy reported that commit 7b4537199a4a ("kbuild: link >> > symbol CRCs at final link, removing CONFIG_MODULE_REL_CRCS") broke >> > mpc85xx_defconfig +

Re: [PATCH v3 1/3] mm/migrate_device.c: Flush TLB while holding PTL

2022-08-25 Thread Alistair Popple
"Huang, Ying" writes: > Alistair Popple writes: > >> When clearing a PTE the TLB should be flushed whilst still holding the >> PTL to avoid a potential race with madvise/munmap/etc. For example >> consider the following sequence: >> >> CPU0 CPU1 >>

Re: [PATCH v3 2/3] mm/migrate_device.c: Copy pte dirty bit to page

2022-08-25 Thread Alistair Popple
Peter Xu writes: > On Wed, Aug 24, 2022 at 01:03:38PM +1000, Alistair Popple wrote: >> migrate_vma_setup() has a fast path in migrate_vma_collect_pmd() that >> installs migration entries directly if it can lock the migrating page. >> When removing a dirty pte the dirty bit is supposed to be

Re: [PATCH v2 1/2] mm/migrate_device.c: Copy pte dirty bit to page

2022-08-25 Thread Alistair Popple
Peter Xu writes: > On Thu, Aug 25, 2022 at 11:24:03AM +1000, Alistair Popple wrote: >> By the way it's still an optimisation because in most cases we can avoid >> calling try_to_migrate() and walking the rmap altogether if we install >> the migration entries here. But I agree the comment is

Re: [PATCH] MAINTAINERS: Remove myself as EEH maintainer

2022-08-25 Thread Bjorn Helgaas
On Sat, Aug 20, 2022 at 10:17:41AM +1000, Michael Ellerman wrote: > Bjorn Helgaas writes: > > On Sat, Aug 06, 2022 at 06:53:01PM +1000, Russell Currey wrote: > >> I haven't touched EEH in a long time I don't have much knowledge of the > >> subsystem at this point either, so it's misleading to

Re: [PATCH] compiler-gcc.h: Remove ancient workaround for gcc PR 58670

2022-08-25 Thread Segher Boessenkool
Hi! On Thu, Aug 25, 2022 at 04:00:52PM +0530, Naveen N. Rao wrote: > This is causing a build issue on ppc64le with a new patch replacing use > of unreachable() with __builtin_unreachable() in __WARN_FLAGS(): > https://lore.kernel.org/linuxppc-dev/20220808114908.240813-2...@linux.ibm.com/ What

Re: [PATCH v2 1/2] mm/migrate_device.c: Copy pte dirty bit to page

2022-08-25 Thread Peter Xu
On Thu, Aug 25, 2022 at 11:24:03AM +1000, Alistair Popple wrote: > By the way it's still an optimisation because in most cases we can avoid > calling try_to_migrate() and walking the rmap altogether if we install > the migration entries here. But I agree the comment is misleading. There's one

Re: [PATCH] i2c: pasemi: Add IRQ support for Apple Silicon

2022-08-25 Thread Christian Zigotzky
On 23 August 2022 at 03:50 am, Michael Ellerman wrote: Arminder Singh writes: This is the first time I'm interacting with the Linux mailing lists, so please don't eviscerate me *too much* if I get the formatting wrong. Of course I'm always willing to take criticism and improve my formatting in

Re: [PATCH v2 1/2] mm/migrate_device.c: Copy pte dirty bit to page

2022-08-25 Thread Peter Xu
On Thu, Aug 25, 2022 at 10:42:41AM +1000, Alistair Popple wrote: > > Peter Xu writes: > > > On Wed, Aug 24, 2022 at 04:25:44PM -0400, Peter Xu wrote: > >> On Wed, Aug 24, 2022 at 11:56:25AM +1000, Alistair Popple wrote: > >> > >> Still I don't know whether there'll be any side effect of having

Re: [PATCH] powerpc: align syscall table for ppc32

2022-08-25 Thread Masahiro Yamada
On Thu, Aug 25, 2022 at 4:53 PM Michael Ellerman wrote: > > Masahiro Yamada writes: > > Christophe Leroy reported that commit 7b4537199a4a ("kbuild: link > > symbol CRCs at final link, removing CONFIG_MODULE_REL_CRCS") broke > > mpc85xx_defconfig + CONFIG_RELOCATABLE=y. > > > > LD

Re: [PATCH] compiler-gcc.h: Remove ancient workaround for gcc PR 58670

2022-08-25 Thread Uros Bizjak
On Thu, Aug 25, 2022 at 12:30 PM Naveen N. Rao wrote: > > Uros Bizjak wrote: > > The workaround for 'asm goto' miscompilation introduces a compiler > > barrier quirk that inhibits many useful compiler optimizations. For > > example, __try_cmpxchg_user compiles to: > > > >11375: 41 8b 4d

[PATCH] fsl/dpio: fix repeated words in comments

2022-08-25 Thread Jilin Yuan
Delete the redundant word 'to'. Signed-off-by: Jilin Yuan --- drivers/soc/fsl/dpio/dpio-service.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/fsl/dpio/dpio-service.c b/drivers/soc/fsl/dpio/dpio-service.c index 1d2b27e3ea63..5315e01624c7 100644 ---

Re: [PATCH] i2c: pasemi: Add IRQ support for Apple Silicon

2022-08-25 Thread Arnd Bergmann
On Sat, Aug 20, 2022 at 9:45 PM Arminder Singh wrote: > > I also fixed a quick checkpatch warning on line 303. "i ++" is now "i++". In general, anything that is mentioned in the changelog as "also done this" is worth splitting into a separate patch, or dropping from the patch, to make reviewing

[Bug 216368] do_IRQ: stack overflow at boot during btrfs handling on a PowerMac G5 11,2

2022-08-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216368 --- Comment #5 from Erhard F. (erhar...@mailbox.org) --- (In reply to The Linux kernel's regression tracker (Thorsten Leemhuis) from comment #4) > Did anyone forward this to the Btrfs team? if so: where? If not I guess I > can do that. I added

Re: [PATCH] compiler-gcc.h: Remove ancient workaround for gcc PR 58670

2022-08-25 Thread Christophe Leroy
Le 25/08/2022 à 12:30, Naveen N. Rao a écrit : > Uros Bizjak wrote: >> The workaround for 'asm goto' miscompilation introduces a compiler >> barrier quirk that inhibits many useful compiler optimizations. For >> example, __try_cmpxchg_user compiles to: >> >>    11375:    41 8b 4d 00 

[Bug 216368] do_IRQ: stack overflow at boot during btrfs handling on a PowerMac G5 11,2

2022-08-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216368 The Linux kernel's regression tracker (Thorsten Leemhuis) (regressi...@leemhuis.info) changed: What|Removed |Added

Re: [PATCH] compiler-gcc.h: Remove ancient workaround for gcc PR 58670

2022-08-25 Thread Naveen N. Rao
Uros Bizjak wrote: The workaround for 'asm goto' miscompilation introduces a compiler barrier quirk that inhibits many useful compiler optimizations. For example, __try_cmpxchg_user compiles to: 11375: 41 8b 4d 00 mov0x0(%r13),%ecx 11379: 41 8b 02

[PATCH 1/5] serial: ucc_uart: Remove custom frame size calculation

2022-08-25 Thread Ilpo Järvinen
The number of bits can be calculated using tty_get_frame_size(), no need for the driver to do it on its own. Also remove a comment on number of bits that doesn't match the code nor the comment on ucc_uart_pram's rx_length ("minus 1" part differs). That comment seems a verbatim copy of that in

Re: [PATCH] powerpc/pci: Enable PCI domains in /proc when PCI bus numbers are not unique

2022-08-25 Thread Pali Rohár
On Thursday 25 August 2022 17:49:28 Michael Ellerman wrote: > Pali Rohár writes: > > On 32-bit powerpc systems with more PCIe controllers and more PCI domains, > > where on more PCI domains are same PCI numbers, when kernel is compiled > > with CONFIG_PROC_FS=y and

Re: [PATCH 2/2] powerpc/rtas: Fix RTAS MSR[HV] handling for Cell

2022-08-25 Thread Michael Ellerman
Jordan Niethe writes: > On Wed, 2022-08-24 at 22:04 +1000, Michael Ellerman wrote: >> Jordan Niethe writes: >> > On Tue, 2022-08-23 at 21:59 +1000, Michael Ellerman wrote: >> > > The semi-recent changes to MSR handling when entering RTAS (firmware) >> > > cause crashes on IBM Cell machines. An

Re: [PATCH] powerpc: align syscall table for ppc32

2022-08-25 Thread Michael Ellerman
Masahiro Yamada writes: > Christophe Leroy reported that commit 7b4537199a4a ("kbuild: link > symbol CRCs at final link, removing CONFIG_MODULE_REL_CRCS") broke > mpc85xx_defconfig + CONFIG_RELOCATABLE=y. > > LD vmlinux > SYSMAP System.map > SORTTAB vmlinux > CHKREL

Re: [PATCH] powerpc/pci: Enable PCI domains in /proc when PCI bus numbers are not unique

2022-08-25 Thread Michael Ellerman
Pali Rohár writes: > On 32-bit powerpc systems with more PCIe controllers and more PCI domains, > where on more PCI domains are same PCI numbers, when kernel is compiled > with CONFIG_PROC_FS=y and CONFIG_PPC_PCI_BUS_NUM_DOMAIN_DEPENDENT=y > options, kernel prints "proc_dir_entry 'pci/01' already

[PATCH linux-next] powerpc/pseries/vas: Remove the unneeded result variable

2022-08-25 Thread cgel . zte
From: ye xingchen Return the value vas_register_coproc_api() directly instead of storing it in another redundant variable. Reported-by: Zeal Robot Signed-off-by: ye xingchen --- arch/powerpc/platforms/pseries/vas.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git

Re: [PATCH v4 01/20] powerpc: Remove asmlinkage from syscall handler definitions

2022-08-25 Thread Andrew Donnellan
On Wed, 2022-08-24 at 12:05 +1000, Rohan McLure wrote: > The asmlinkage macro has no special meaning in powerpc, and prior to > this patch is used sporadically on some syscall handler definitions. > On > architectures that do not define asmlinkage, it resolves to extern > "C" > for C++ compilers