Re: [PATCH] powerpc/math_emu/efp: Include module.h

2022-08-31 Thread Christophe Leroy
Le 31/08/2022 à 17:20, Nathan Chancellor a écrit : > When building with a recent version of clang, there are a couple of > errors around the call to module_init(): > >arch/powerpc/math-emu/math_efp.c:927:1: error: type specifier missing, > defaults to 'int'; ISO C99 and later do not

Re: [PATCH v2] powerpc: Fix irq_soft_mask_set() and irq_soft_mask_return() with sanitizer

2022-08-31 Thread Christophe Leroy
Le 01/09/2022 à 00:45, Segher Boessenkool a écrit : > Hi! > > On Tue, Aug 30, 2022 at 09:10:02AM +, Christophe Leroy wrote: >> Le 30/08/2022 à 11:01, Nicholas Piggin a écrit : >>> On Tue Aug 30, 2022 at 3:24 PM AEST, Christophe Leroy wrote: > This is still slightly concerning to me. Is

Re: [PATCH] powerpc/pci: Enable PCI domains in /proc when PCI bus numbers are not unique

2022-08-31 Thread Michael Ellerman
Pali Rohár writes: > On Thursday 25 August 2022 17:49:28 Michael Ellerman wrote: >> Pali Rohár writes: >> > On 32-bit powerpc systems with more PCIe controllers and more PCI domains, >> > where on more PCI domains are same PCI numbers, when kernel is compiled >> > with CONFIG_PROC_FS=y and

Re: [PATCH] Revert "powerpc/irq: Don't open code irq_soft_mask helpers"

2022-08-31 Thread Michael Ellerman
Christophe Leroy writes: > Le 31/08/2022 à 15:10, Michael Ellerman a écrit : >> This reverts commit ef5b570d3700fbb8628a58da0487486ceeb713cd. >> >> Zhouyi reported that commit is causing crashes when running rcutorture >> with KASAN enabled: >> >>BUG: using smp_processor_id() in preemptible

Re: [PATCH v5] livepatch: Clear relocation targets on a module removal

2022-08-31 Thread Michael Ellerman
Joe Lawrence writes: > On Thu, Sep 01, 2022 at 08:30:44AM +1000, Michael Ellerman wrote: >> Joe Lawrence writes: ... > > Hi Michael, > > While we're on the topic of klp-relocations and Power, I saw a similar > access problem when writing (late) relocations into > .data..ro_after_init. I'm not

[powerpc:merge] BUILD SUCCESS d30b91b37ef543f5eca88f7335374404c78a07ab

2022-08-31 Thread kernel test robot
-20220831 m68k allmodconfig x86_64randconfig-a006 x86_64rhel-8.3-kselftests i386 allyesconfig x86_64 rhel-8.3-syz i386 randconfig-a016 x86_64

[powerpc:next-test] BUILD SUCCESS 3fe3a16489c3d45bdd9d5a7e2d13f2fbbd236cbf

2022-08-31 Thread kernel test robot
randconfig-r043-20220831 x86_64randconfig-a002 arm allyesconfig arm64allyesconfig x86_64randconfig-a004 s390 randconfig-r044-20220831 x86_64

[powerpc:fixes-test] BUILD SUCCESS 10da3c652aed277864100a16e8c9d0fc89b484cc

2022-08-31 Thread kernel test robot
virt_defconfig powerpcwarp_defconfig armmulti_v7_defconfig arm64alldefconfig s390 randconfig-r044-20220831 arc randconfig-r043-20220831 riscvrandconfig-r042

Re: [PATCH v5] livepatch: Clear relocation targets on a module removal

2022-08-31 Thread Joe Lawrence
On Thu, Sep 01, 2022 at 08:30:44AM +1000, Michael Ellerman wrote: > Joe Lawrence writes: > > On Tue, Aug 30, 2022 at 11:53:13AM -0700, Song Liu wrote: > >> From: Miroslav Benes > >> > >> Josh reported a bug: > >> > >> When the object to be patched is a module, and that module is > >>

Re: [PATCH v5] livepatch: Clear relocation targets on a module removal

2022-08-31 Thread Joe Lawrence
On Wed, Aug 31, 2022 at 03:48:26PM -0700, Song Liu wrote: > On Wed, Aug 31, 2022 at 3:30 PM Michael Ellerman wrote: > > > > Joe Lawrence writes: > > > On Tue, Aug 30, 2022 at 11:53:13AM -0700, Song Liu wrote: > > >> From: Miroslav Benes > > >> > > >> Josh reported a bug: > > >> > > >> When

[PATCH] selftests/powerpc: Skip 4PB test on 4K PAGE_SIZE systems

2022-08-31 Thread Michael Ellerman
Systems using the hash MMU with a 4K page size don't support 4PB address space, so skip the test because the bug it tests for can't be triggered. Signed-off-by: Michael Ellerman --- tools/testing/selftests/powerpc/mm/large_vm_gpr_corruption.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH] powerpc/configs: Properly enable PAPR_SCM in pseries_defconfig

2022-08-31 Thread Michael Ellerman
My commit to add PAPR_SCM to pseries_defconfig failed to add the required dependencies, meaning the driver doesn't get built. Add the required LIBNVDIMM=m. Fixes: d6481a7195df ("powerpc/configs: Add PAPR_SCM to pseries_defconfig") Signed-off-by: Michael Ellerman ---

Re: [PATCH linux-next] crypto: nx: remove redundant variable rc

2022-08-31 Thread Breno Leitao
On Wed, Aug 31, 2022 at 02:02:48PM +, cgel@gmail.com wrote: > From: Jinpeng Cui > > Return value directly from set_msg_len() instead of > getting value from redundant variable rc. > > Reported-by: Zeal Robot > Signed-off-by: Jinpeng Cui Reviewed-by: Breno Leitao > --- >

Re: [PATCH v5] livepatch: Clear relocation targets on a module removal

2022-08-31 Thread Song Liu
On Wed, Aug 31, 2022 at 3:30 PM Michael Ellerman wrote: > > Joe Lawrence writes: > > On Tue, Aug 30, 2022 at 11:53:13AM -0700, Song Liu wrote: > >> From: Miroslav Benes > >> > >> Josh reported a bug: > >> > >> When the object to be patched is a module, and that module is > >> rmmod'ed and

Re: [PATCH v2] powerpc: Fix irq_soft_mask_set() and irq_soft_mask_return() with sanitizer

2022-08-31 Thread Segher Boessenkool
Hi! On Tue, Aug 30, 2022 at 09:10:02AM +, Christophe Leroy wrote: > Le 30/08/2022 à 11:01, Nicholas Piggin a écrit : > > On Tue Aug 30, 2022 at 3:24 PM AEST, Christophe Leroy wrote: > >>> This is still slightly concerning to me. Is there any guarantee that the > >>> compiler would not use a

Re: [PATCH v5] livepatch: Clear relocation targets on a module removal

2022-08-31 Thread Michael Ellerman
Joe Lawrence writes: > On Tue, Aug 30, 2022 at 11:53:13AM -0700, Song Liu wrote: >> From: Miroslav Benes >> >> Josh reported a bug: >> >> When the object to be patched is a module, and that module is >> rmmod'ed and reloaded, it fails to load with: >> >> module: x86/modules: Skipping

Re: [PATCH v5] livepatch: Clear relocation targets on a module removal

2022-08-31 Thread Joe Lawrence
On Wed, Aug 31, 2022 at 10:05:43AM -0700, Song Liu wrote: > On Wed, Aug 31, 2022 at 1:01 AM Christophe Leroy > wrote: > > > > > > > > Le 30/08/2022 à 20:53, Song Liu a écrit : > > > From: Miroslav Benes > > > > > > Josh reported a bug: > > > > > >When the object to be patched is a module,

Re: [RFC PATCH 2/2] fs/xattr: wire up syscalls

2022-08-31 Thread Richard Guy Briggs
On 2022-08-30 17:28, Christian Göttsche wrote: > Enable the new added extended attribute related syscalls. > > Signed-off-by: Christian Göttsche I can't speak to the completeness of the arch list, but I'm glad to see the audit attr change bits in there. > --- > TODO: > - deprecate

Re: [PATCH v5] livepatch: Clear relocation targets on a module removal

2022-08-31 Thread Joe Lawrence
On Tue, Aug 30, 2022 at 11:53:13AM -0700, Song Liu wrote: > From: Miroslav Benes > > Josh reported a bug: > > When the object to be patched is a module, and that module is > rmmod'ed and reloaded, it fails to load with: > > module: x86/modules: Skipping invalid relocation target,

Re: [PATCH] cpuidle: move from strlcpy with unused retval to strscpy

2022-08-31 Thread Rafael J. Wysocki
On Thu, Aug 18, 2022 at 11:00 PM Wolfram Sang wrote: > > Follow the advice of the below link and prefer 'strscpy' in this > subsystem. Conversion is 1:1 because the return value is not used. > Generated by a coccinelle script. > > Link: >

Re: [PATCH v2 16/16] objtool/powerpc: Add --mcount specific implementation

2022-08-31 Thread Segher Boessenkool
On Wed, Aug 31, 2022 at 12:50:07PM +, Christophe Leroy wrote: > Le 29/08/2022 à 07:52, Sathvika Vasireddy a écrit : > > + opcode = insn >> 26; > > + > > + switch (opcode) { > > + case 18: /* bl */ > > case 18 is more than 'bl', it includes also 'b'. > In both cases, the calculation of

Re: [PATCH v5] livepatch: Clear relocation targets on a module removal

2022-08-31 Thread Christophe Leroy
Le 31/08/2022 à 19:05, Song Liu a écrit : > On Wed, Aug 31, 2022 at 1:01 AM Christophe Leroy > wrote: >> >> >> >> Le 30/08/2022 à 20:53, Song Liu a écrit : >>> From: Miroslav Benes >>> >>> Josh reported a bug: >>> >>> When the object to be patched is a module, and that module is >>>

Re: [PATCH v5] livepatch: Clear relocation targets on a module removal

2022-08-31 Thread Song Liu
On Wed, Aug 31, 2022 at 1:01 AM Christophe Leroy wrote: > > > > Le 30/08/2022 à 20:53, Song Liu a écrit : > > From: Miroslav Benes > > > > Josh reported a bug: > > > >When the object to be patched is a module, and that module is > >rmmod'ed and reloaded, it fails to load with: > > > >

[PATCH] powerpc/math_emu/efp: Include module.h

2022-08-31 Thread Nathan Chancellor
When building with a recent version of clang, there are a couple of errors around the call to module_init(): arch/powerpc/math-emu/math_efp.c:927:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]

[PATCH linux-next] crypto: nx: remove redundant variable rc

2022-08-31 Thread cgel . zte
From: Jinpeng Cui Return value directly from set_msg_len() instead of getting value from redundant variable rc. Reported-by: Zeal Robot Signed-off-by: Jinpeng Cui --- drivers/crypto/nx/nx-aes-ccm.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git

Re: [PATCH] powerpc/64s: add pte_needs_flush and huge_pmd_needs_flush

2022-08-31 Thread Christophe Leroy
Le 31/08/2022 à 14:26, Nicholas Piggin a écrit : > Allow PTE changes to avoid flushing the TLB when access permissions are > being relaxed, the dirty bit is being set, and the accessed bit is being > changed. > > Relaxing access permissions and setting dirty and accessed bits do not > require a

Re: [PATCH] powerpc: move from strlcpy with unused retval to strscpy

2022-08-31 Thread Michael Ellerman
On Thu, 18 Aug 2022 22:59:46 +0200, Wolfram Sang wrote: > Follow the advice of the below link and prefer 'strscpy' in this > subsystem. Conversion is 1:1 because the return value is not used. > Generated by a coccinelle script. > > Applied to powerpc/next. [1/1] powerpc: move from strlcpy with

Re: [PATCH] macintosh: move from strlcpy with unused retval to strscpy

2022-08-31 Thread Michael Ellerman
On Thu, 18 Aug 2022 23:00:26 +0200, Wolfram Sang wrote: > Follow the advice of the below link and prefer 'strscpy' in this > subsystem. Conversion is 1:1 because the return value is not used. > Generated by a coccinelle script. > > Applied to powerpc/next. [1/1] macintosh: move from strlcpy

Re: [PATCH 0/2] spi: remove "spidev" nodes from DTs

2022-08-31 Thread Michael Ellerman
On Wed, 24 Aug 2022 10:21:27 +0200, Wolfram Sang wrote: > There were two DTs left specifying "spidev" directly. Remove them. > > Wolfram Sang (2): > ARM: dts: stm32: argon: remove spidev node > powerpc/82xx: remove spidev node from mgcoge > > arch/arm/boot/dts/stm32mp157c-emstamp-argon.dtsi

Re: [PATCH v4 1/2] powerpc/mm: Support execute-only memory on the Radix MMU

2022-08-31 Thread Michael Ellerman
On Wed, 17 Aug 2022 15:06:39 +1000, Russell Currey wrote: > Add support for execute-only memory (XOM) for the Radix MMU by using an > execute-only mapping, as opposed to the RX mapping used by powerpc's > other MMUs. > > The Hash MMU already supports XOM through the execute-only pkey, > which is

Re: [PATCH] powerpc: Update ISA versions to mention e5500/e6500

2022-08-31 Thread Michael Ellerman
On Wed, 3 Aug 2022 16:32:28 +1000, Michael Ellerman wrote: > Add the NXP (nee Freescale) e5500 and e6500 to the ISA versions > documentation. > > Applied to powerpc/next. [1/1] powerpc: Update ISA versions to mention e5500/e6500

Re: [PATCH] powerpc: Move patch sites out of asm-prototypes.h

2022-08-31 Thread Michael Ellerman
On Thu, 18 Aug 2022 15:06:59 +1000, Michael Ellerman wrote: > The definitions for the patch sites etc. don't belong in > asm-prototypes.h, they are not EXPORT'ed asm symbols. > > Move them into sections.h which is traditionally used for asm symbols. > > Applied to powerpc/next. [1/1] powerpc:

Re: [PATCH] powerpc/boot: Drop unused dummy.c

2022-08-31 Thread Michael Ellerman
On Fri, 19 Aug 2022 21:05:56 +1000, Michael Ellerman wrote: > The last use of dummy.c was dropped in commit 2bf118197cb4 ("[POWERPC] > Create a "wrapper" script and use it in arch/powerpc/boot"). > > Applied to powerpc/next. [1/1] powerpc/boot: Drop unused dummy.c

Re: [PATCH] powerpc/boot: Convert more files to use SPDX tags

2022-08-31 Thread Michael Ellerman
On Fri, 19 Aug 2022 21:04:30 +1000, Michael Ellerman wrote: > These files are all plain GPL 2.0, with a second sentence about being > licensed as-is. > > Similar to the rule in commit 577b61cee5b2 ("treewide: Replace GPLv2 > boilerplate/reference with SPDX - gpl-2.0_398.RULE"). > > > [...]

Re: [PATCH] powerpc/microwatt: Add LiteX MMC driver

2022-08-31 Thread Michael Ellerman
On Thu, 4 Aug 2022 11:27:08 +0930, Joel Stanley wrote: > Enable the LiteX MMC device and it's dependency the common clock > framework. > > Applied to powerpc/next. [1/1] powerpc/microwatt: Add LiteX MMC driver https://git.kernel.org/powerpc/c/0b9e534fcbf0a45e2ba08467de08a848a99ba2d6

Re: [PATCH] powerpc/vdso: Don't map VDSO at a fixed address on PPC32

2022-08-31 Thread Michael Ellerman
On Thu, 18 Aug 2022 19:31:25 +0200, Christophe Leroy wrote: > PPC64 removed default mapping address from VDSO in > commit 30d0b3682887 ("powerpc: Move 64bit VDSO to improve context > switch performance"). > > Do like PPC64 and let get_unmapped_area() place the VDSO mapping > at the address it

Re: [PATCH] powerpc: Remove stale declarations in mmu_decl.h

2022-08-31 Thread Michael Ellerman
On Fri, 19 Aug 2022 16:23:43 +0200, Christophe Leroy wrote: > rtas_size and rtas_data are not used anymore since at least > commit 7c8c6b9776fb ("powerpc: Merge lmb.c and make MM initialization > use it.") > > Remove them. > > Since commit 4b74a35fc7e9 ("powerpc/32s: Make Hash var static") > the

Re: [PATCH] powerpc/fsl_booke: Make calc_cam_sz() static

2022-08-31 Thread Michael Ellerman
On Fri, 19 Aug 2022 16:26:49 +0200, Christophe Leroy wrote: > calc_cam_sz() is used only in fsl_book3e.c, make it static. > > Applied to powerpc/next. [1/1] powerpc/fsl_booke: Make calc_cam_sz() static https://git.kernel.org/powerpc/c/f7d5f00702e2da656b2a8f975fdaa0d48329de36 cheers

Re: [PATCH] Revert "powerpc/irq: Don't open code irq_soft_mask helpers"

2022-08-31 Thread Christophe Leroy
Le 31/08/2022 à 15:10, Michael Ellerman a écrit : > This reverts commit ef5b570d3700fbb8628a58da0487486ceeb713cd. > > Zhouyi reported that commit is causing crashes when running rcutorture > with KASAN enabled: > >BUG: using smp_processor_id() in preemptible [] code: >

Re: [PATCH] powerpc: align syscall table for ppc32

2022-08-31 Thread Michael Ellerman
On Sun, 21 Aug 2022 01:51:29 +0900, Masahiro Yamada wrote: > Christophe Leroy reported that commit 7b4537199a4a ("kbuild: link > symbol CRCs at final link, removing CONFIG_MODULE_REL_CRCS") broke > mpc85xx_defconfig + CONFIG_RELOCATABLE=y. > > LD vmlinux > SYSMAP System.map >

Re: [PATCH 1/2] Revert "powerpc: Remove unused FW_FEATURE_NATIVE references"

2022-08-31 Thread Michael Ellerman
On Tue, 23 Aug 2022 21:59:51 +1000, Michael Ellerman wrote: > This reverts commit 79b74a68486765a4fe685ac4069bc71366c538f5. > > It broke booting on IBM Cell machines when the kernel is also built with > CONFIG_PPC_PS3=y. > > That's because FW_FEATURE_NATIVE_ALWAYS = 0 does have an important >

Re: [PATCH] powerpc/pci: Enable PCI domains in /proc when PCI bus numbers are not unique

2022-08-31 Thread Michael Ellerman
On Sat, 20 Aug 2022 13:51:13 +0200, Pali Rohár wrote: > On 32-bit powerpc systems with more PCIe controllers and more PCI domains, > where on more PCI domains are same PCI numbers, when kernel is compiled > with CONFIG_PROC_FS=y and CONFIG_PPC_PCI_BUS_NUM_DOMAIN_DEPENDENT=y > options, kernel

Re: [PATCH v3] powerpc/papr_scm: Fix nvdimm event mappings

2022-08-31 Thread Michael Ellerman
On Thu, 4 Aug 2022 13:18:52 +0530, Kajol Jain wrote: > Commit 4c08d4bbc089 ("powerpc/papr_scm: Add perf interface support") > added performance monitoring support for papr-scm nvdimm devices via > perf interface. Commit also added an array in papr_scm_priv > structure called "nvdimm_events_map",

[PATCH] Revert "powerpc/irq: Don't open code irq_soft_mask helpers"

2022-08-31 Thread Michael Ellerman
This reverts commit ef5b570d3700fbb8628a58da0487486ceeb713cd. Zhouyi reported that commit is causing crashes when running rcutorture with KASAN enabled: BUG: using smp_processor_id() in preemptible [] code: rcu_torture_rea/100 caller is rcu_preempt_deferred_qs_irqrestore+0x74/0xed0

Re: [PATCH v2 16/16] objtool/powerpc: Add --mcount specific implementation

2022-08-31 Thread Christophe Leroy
Le 29/08/2022 à 07:52, Sathvika Vasireddy a écrit : > This patch enables objtool --mcount on powerpc, and > adds implementation specific to powerpc. > > Signed-off-by: Sathvika Vasireddy > --- > arch/powerpc/Kconfig | 1 + > tools/objtool/arch/powerpc/decode.c

[PATCH] powerpc/64s: add pte_needs_flush and huge_pmd_needs_flush

2022-08-31 Thread Nicholas Piggin
Allow PTE changes to avoid flushing the TLB when access permissions are being relaxed, the dirty bit is being set, and the accessed bit is being changed. Relaxing access permissions and setting dirty and accessed bits do not require a flush because the MMU will re-load the PTE and notice the

Re: [PATCH] KVM: fix repeated words in comments

2022-08-31 Thread Christophe Leroy
Le 31/08/2022 à 02:44, Jilin Yuan a écrit : > Delete the redundant word 'that'. > > Signed-off-by: Jilin Yuan This change was already proposed and rejected here : https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20220724062920.1551-1-wangjia...@cdjrlc.com/ Please study history before

[PATCH 3/3] powerpc/32: Remove wii_memory_fixups()

2022-08-31 Thread Christophe Leroy
wii_memory_fixups() is not called anymore, remove it. Also remove left-overs in mmu_decl.h which were forgotten by commit 160985f3025b ("powerpc/wii: remove wii_mmu_mapin_mem2()") Signed-off-by: Christophe Leroy --- arch/powerpc/mm/mmu_decl.h | 8

[PATCH 1/3] powerpc/32: Drop a stale comment about reservation of gigantic pages

2022-08-31 Thread Christophe Leroy
A comment about the reservation of gigantic pages was left in MMU_init() after commit 79cc38ded1e1 ("powerpc/mm/hugetlb: Add support for reserving gigantic huge pages via kernel command line") Remove it. Signed-off-by: Christophe Leroy --- arch/powerpc/mm/init_32.c | 4 1 file changed, 4

[PATCH 2/3] powerpc/32: Allow fragmented physical memory

2022-08-31 Thread Christophe Leroy
Since commit 9e849f231c3c ("powerpc/mm/32s: use generic mmu_mapin_ram() for all blocks.") it is possible to map all blocks as RAM on any PPC32. Remove related restrictions. And remove call to wii_memory_fixups() which doesn't do anything else than checks since commit 160985f3025b ("powerpc/wii:

[PATCH] USB: FHCI: Switch to GPIO descriptors

2022-08-31 Thread Linus Walleij
This driver for the PPC Freescale SoC is using device tree accessors and imperative GPIO semantics control using the old GPIO API, switch it over to use GPIO descriptors. Cc: Li Yang Cc: linuxppc-dev@lists.ozlabs.org Cc: Zhao Qiang Cc: Guilherme Maciel Ferreira Signed-off-by: Linus Walleij

[PATCH v3 1/3] dt-bindings: reset: syscon-reboot: Add priority property

2022-08-31 Thread Pali Rohár
This new optional priority property allows to specify custom priority level of reset device. Prior this change priority level was hardcoded to 192 and not possible to specify or change. Specifying other value is needed for some boards. Default level when not specified stays at 192 as before.

[PATCH v3 2/3] power: reset: syscon-reboot: Add support for specifying priority

2022-08-31 Thread Pali Rohár
Read new optional device tree property priority for specifying priority level of reset handler. Default value is 192 as before. Signed-off-by: Pali Rohár --- drivers/power/reset/syscon-reboot.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[PATCH v3 3/3] powerpc: dts: turris1x.dts: Set lower priority for CPLD syscon-reboot

2022-08-31 Thread Pali Rohár
Due to CPLD firmware bugs, set CPLD syscon-reboot priority level to 64 (between rstcr and watchdog) to ensure that rstcr's global-utilities reset method which is preferred stay as default one, and to ensure that CPLD syscon-reboot is more preferred than watchdog reset method. Fixes: 0531a4abd1c6

Re: [PATCH v5] livepatch: Clear relocation targets on a module removal

2022-08-31 Thread Christophe Leroy
Le 30/08/2022 à 20:53, Song Liu a écrit : > From: Miroslav Benes > > Josh reported a bug: > >When the object to be patched is a module, and that module is >rmmod'ed and reloaded, it fails to load with: > >module: x86/modules: Skipping invalid relocation target, existing value is

Re: [PATCH v2 1/3] dt-bindings: reset: syscon-reboot: Add priority property

2022-08-31 Thread Krzysztof Kozlowski
On 31/08/2022 10:36, Pali Rohár wrote: > On Wednesday 31 August 2022 10:31:22 Krzysztof Kozlowski wrote: >> On 31/08/2022 02:00, Pali Rohár wrote: >>> This new optional priority property allows to specify custom priority level >>> of reset device. Default level was always 192. >> >> You still did

Re: [PATCH v2 1/3] dt-bindings: reset: syscon-reboot: Add priority property

2022-08-31 Thread Pali Rohár
On Wednesday 31 August 2022 10:31:22 Krzysztof Kozlowski wrote: > On 31/08/2022 02:00, Pali Rohár wrote: > > This new optional priority property allows to specify custom priority level > > of reset device. Default level was always 192. > > You still did not explain why do we need this. You only

Re: [PATCH v2 1/3] dt-bindings: reset: syscon-reboot: Add priority property

2022-08-31 Thread Arnd Bergmann
On Wed, Aug 31, 2022, at 1:00 AM, Pali Rohár wrote: > a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml > b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml > index da2509724812..4c8b0d0a0111 100644 > ---

Re: [PATCH v2 1/3] dt-bindings: reset: syscon-reboot: Add priority property

2022-08-31 Thread Krzysztof Kozlowski
On 31/08/2022 02:00, Pali Rohár wrote: > This new optional priority property allows to specify custom priority level > of reset device. Default level was always 192. You still did not explain why do we need this. You only explained what you did here, which is obvious and visible from the diff.

Re: [PATCH v2 02/16] powerpc: override __ALIGN() and __ALIGN_STR() macros

2022-08-31 Thread Michael Ellerman
"Nicholas Piggin" writes: > On Mon Aug 29, 2022 at 3:52 PM AEST, Sathvika Vasireddy wrote: >> Powerpc instructions must be word-aligned. Currently, >> there is an alignment of 16 bytes (by default), and it is >> much more than what is required for powerpc (4 bytes). >> >> The default expansion of