Re: usb.c:undefined reference to `qe_immr'

2023-01-10 Thread Michael Ellerman
;> head: 5a41237ad1d4b62008f93163af1d9b1da90729d8 >> commit: 7b4537199a4a8480b8c3ba37a2d44765ce76cd9b kbuild: link symbol CRCs at >> final link, removing CONFIG_MODULE_REL_CRCS >> date: 8 months ago >> config: powerpc-randconfig-r026-20230110 >> compiler: powerpc-

Re: [PATCH v2 11/13] tty/serial: Call ->dtr_rts() parameter active consistently

2023-01-10 Thread Jiri Slaby
On 10. 01. 23, 13:02, Ilpo Järvinen wrote: Convert various parameter names for ->dtr_rts() and related functions from onoff, on, and raise to active. Much better. Signed-off-by: Ilpo Järvinen Reviewed-by: Jiri Slaby -- js suse labs

Re: [PATCH 1/2] powerpc/64s/radix: Fix crash with unaligned relocated kernel

2023-01-10 Thread Sachin Sant
> On 10-Jan-2023, at 6:17 PM, Michael Ellerman wrote: > > If a relocatable kernel is loaded at an address that is not 2MB aligned > and told not to relocate to zero, the kernel can crash due to > mark_rodata_ro() incorrectly changing some read-write data to read-only. > > Scenarios where the

Re: [PATCH v2] net: wan: Add checks for NULL. If uhdlc_priv_tsa != 1 then utdm is not initialized. And if ret != NULL then goto undo_uhdlc_init, where utdm is dereferenced. Same if dev == NULL.

2023-01-10 Thread Jakub Kicinski
On Tue, 10 Jan 2023 14:47:45 +0300 Esina Ekaterina wrote: > Subject: [PATCH v2] net: wan: Add checks for NULL. If uhdlc_priv_tsa != 1 > then utdm is not initialized. And if ret != NULL then goto undo_uhdlc_init, > where utdm is dereferenced. Same if dev == NULL. > > Found by Linux Verification

Re: [PATCH v2 7/7] powerpc/pseries: Implement secvars for dynamic secure boot

2023-01-10 Thread Andrew Donnellan
On Fri, 2023-01-06 at 21:49 +1100, Michael Ellerman wrote: > > > diff --git a/arch/powerpc/platforms/pseries/Kconfig > > b/arch/powerpc/platforms/pseries/Kconfig > > index a3b4d99567cb..94e08c405d50 100644 > > --- a/arch/powerpc/platforms/pseries/Kconfig > > +++

Re: [PATCH 08/41] mm: introduce CONFIG_PER_VMA_LOCK

2023-01-10 Thread Suren Baghdasaryan
On Tue, Jan 10, 2023 at 4:39 PM Davidlohr Bueso wrote: > > On Mon, 09 Jan 2023, Suren Baghdasaryan wrote: > > >This configuration variable will be used to build the support for VMA > >locking during page fault handling. > > > >This is enabled by default on supported architectures with SMP and MMU

Re: [PATCH 08/41] mm: introduce CONFIG_PER_VMA_LOCK

2023-01-10 Thread Davidlohr Bueso
On Mon, 09 Jan 2023, Suren Baghdasaryan wrote: This configuration variable will be used to build the support for VMA locking during page fault handling. This is enabled by default on supported architectures with SMP and MMU set. The architecture support is needed since the page fault handler

Re: [PATCH 2/4] dt-bindings: usb: Convert multiple "usb-ohci" bindings to DT schema

2023-01-10 Thread Rob Herring
On Tue, Jan 10, 2023 at 5:18 PM Rob Herring wrote: > > "usb-ohci" is another "generic" OHCI controller compatible string used by > several platforms. Add it to the generic-ohci.yaml schema and remove all > the old binding docs. > > Marvell pxa-usb.txt has "usb-ohci" in the example, but actual

[PATCH 2/4] dt-bindings: usb: Convert multiple "usb-ohci" bindings to DT schema

2023-01-10 Thread Rob Herring
"usb-ohci" is another "generic" OHCI controller compatible string used by several platforms. Add it to the generic-ohci.yaml schema and remove all the old binding docs. Marvell pxa-usb.txt has "usb-ohci" in the example, but actual users don't, so drop it. Signed-off-by: Rob Herring ---

[PATCH 4/4] dt-bindings: usb: Convert Nuvoton EHCI to DT schema

2023-01-10 Thread Rob Herring
The Nuvoton EHCI binding is just some compatible strings, so add it to the generic-ehci.yaml schema. Signed-off-by: Rob Herring --- .../devicetree/bindings/usb/generic-ehci.yaml| 2 ++ .../devicetree/bindings/usb/npcm7xx-usb.txt | 20 2 files changed, 2

[PATCH 3/4] dt-bindings: usb: Convert Marvell Orion EHCI to DT schema

2023-01-10 Thread Rob Herring
The Marvell Orion EHCI binding is just some compatible strings, so add it to the generic-ehci.yaml schema. Signed-off-by: Rob Herring --- .../devicetree/bindings/usb/ehci-orion.txt | 22 -- .../devicetree/bindings/usb/generic-ehci.yaml | 2 ++ 2 files changed,

[PATCH 1/4] dt-bindings: usb: Remove obsolete brcm,bcm3384-usb.txt

2023-01-10 Thread Rob Herring
The "brcm,bcm3384-ohci" and "brcm,bcm3384-ehci" compatibles are already documented in generic-ohci.yaml and generic-ehci.yaml, respectively, so remove the old txt binding. Signed-off-by: Rob Herring --- Documentation/devicetree/bindings/usb/brcm,bcm3384-usb.txt | 11 --- 1 file changed,

[PATCH 0/4] dt-bindings: usb: Convert some more simple OHCI/EHCI bindings

2023-01-10 Thread Rob Herring
.txt | 2 +- .../devicetree/bindings/usb/spear-usb.txt | 35 -- 10 files changed, 32 insertions(+), 142 deletions(-) --- base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2 change-id: 20230110-dt-usb-1c637752a83b Best regards, -- Rob Herring

Re: [powerpc] Boot failure kernel BUG at mm/usercopy.c:102

2023-01-10 Thread Sachin Sant
>> [ 0.445046] Code: 392990f8 4814 3d02ffe9 390827f0 7d074378 7d094378 >> 7c661b78 3c62ffe7 f9610060 386319f0 4bca6935 6000 <0fe0> >> 7c0802a6 >> [ 0.445061] ---[ end trace ]— >> Git bisect points to following patch: >> commit

Re: [PATCH 41/41] mm: replace rw_semaphore with atomic_t in vma_lock

2023-01-10 Thread Suren Baghdasaryan
On Tue, Jan 10, 2023 at 12:04 AM Vlastimil Babka wrote: > > On 1/9/23 21:53, Suren Baghdasaryan wrote: > > rw_semaphore is a sizable structure of 40 bytes and consumes > > considerable space for each vm_area_struct. However vma_lock has > > two important specifics which can be used to replace

Re: [PATCH net-next 2/7] PCI: Remove PCI IDs used by the Sun Cassini driver

2023-01-10 Thread Anirudh Venkataramanan
On 1/10/2023 7:26 AM, Bjorn Helgaas wrote: On Fri, Jan 06, 2023 at 02:00:15PM -0800, Anirudh Venkataramanan wrote: The previous patch removed the Cassini driver (drivers/net/ethernet/sun). With this, PCI_DEVICE_ID_NS_SATURN and PCI_DEVICE_ID_SUN_CASSINI are unused. Remove them. Cc: Leon

Re: [powerpc] Boot failure kernel BUG at mm/usercopy.c:102

2023-01-10 Thread Mathieu Desnoyers
On 2023-01-10 05:42, Sachin Sant wrote: 6.2.0-rc3-next-20230109 fails to boot on powerpc with following: [ 0.444834] [ cut here ] [ 0.444838] kernel BUG at mm/usercopy.c:102! [ 0.444842] Oops: Exception in kernel mode, sig: 5 [#1] [ 0.444845] LE PAGE_SIZE=64K MMU=Radix

Re: [PATCH net-next 2/7] PCI: Remove PCI IDs used by the Sun Cassini driver

2023-01-10 Thread Bjorn Helgaas
On Fri, Jan 06, 2023 at 02:00:15PM -0800, Anirudh Venkataramanan wrote: > The previous patch removed the Cassini driver (drivers/net/ethernet/sun). > With this, PCI_DEVICE_ID_NS_SATURN and PCI_DEVICE_ID_SUN_CASSINI are > unused. Remove them. > > Cc: Leon Romanovsky > Signed-off-by: Anirudh

Re: [PATCH 06/14] powerpc/vdso: Remove unused '-s' flag from ASFLAGS

2023-01-10 Thread Nathan Chancellor
On Tue, Jan 10, 2023 at 05:45:23AM -0600, Segher Boessenkool wrote: > On Mon, Jan 09, 2023 at 05:51:23PM -0700, Nathan Chancellor wrote: > > So for this patch, I have > > > > When clang's -Qunused-arguments is dropped from KBUILD_CPPFLAGS, it > > warns: > > > > clang-16: error: argument

Re: [Intel-gfx] [RFC DO NOT MERGE] treewide: use __xchg in most obvious places

2023-01-10 Thread Andy Shevchenko
On Tue, Jan 10, 2023 at 01:46:37PM +0100, Andrzej Hajda wrote: > On 10.01.2023 12:07, Andy Shevchenko wrote: > > On Tue, Jan 10, 2023 at 11:53:06AM +0100, Andrzej Hajda wrote: ... > > > + return __xchg(_chain->p_prod_elem, > > > + (void *)(((u8 *)p_chain->p_prod_elem) + > > >

[PATCH 1/2] powerpc/64s/radix: Fix crash with unaligned relocated kernel

2023-01-10 Thread Michael Ellerman
If a relocatable kernel is loaded at an address that is not 2MB aligned and told not to relocate to zero, the kernel can crash due to mark_rodata_ro() incorrectly changing some read-write data to read-only. Scenarios where the misalignment can occur are when the kernel is loaded by kdump or using

[PATCH 2/2] powerpc/64s/radix: Fix RWX mapping with relocated kernel

2023-01-10 Thread Michael Ellerman
If a relocatable kernel is loaded at a non-zero address and told not to relocate to zero (kdump or RELOCATABLE_TEST), the mapping of the interrupt code at zero is left with RWX permissions. That is a security weakness, and leads to a warning at boot if CONFIG_DEBUG_WX is enabled: powerpc/mm:

Re: [Intel-gfx] [RFC DO NOT MERGE] treewide: use __xchg in most obvious places

2023-01-10 Thread Andrzej Hajda
On 10.01.2023 12:07, Andy Shevchenko wrote: On Tue, Jan 10, 2023 at 11:53:06AM +0100, Andrzej Hajda wrote: This patch tries to show usability of __xchg helper. It is not intended to be merged, but I can convert it to proper patchset if necessary. There are many more places where __xchg can be

[PATCH v2 11/13] tty/serial: Call ->dtr_rts() parameter active consistently

2023-01-10 Thread Ilpo Järvinen
Convert various parameter names for ->dtr_rts() and related functions from onoff, on, and raise to active. Signed-off-by: Ilpo Järvinen --- drivers/char/pcmcia/synclink_cs.c | 6 +++--- drivers/mmc/core/sdio_uart.c | 6 +++--- drivers/staging/greybus/uart.c| 4 ++--

[PATCH v2 07/13] tty: Convert ->dtr_rts() to take bool argument

2023-01-10 Thread Ilpo Järvinen
Convert the raise/on parameter in ->dtr_rts() to bool through the callchain. The parameter is used like bool. In USB serial, there remains a few implicit bool -> larger type conversions because some devices use u8 in their control messages. In moxa_tiocmget(), dtr variable was reused for line

Re: [PATCH 06/14] powerpc/vdso: Remove unused '-s' flag from ASFLAGS

2023-01-10 Thread Segher Boessenkool
On Mon, Jan 09, 2023 at 05:51:23PM -0700, Nathan Chancellor wrote: > So for this patch, I have > > When clang's -Qunused-arguments is dropped from KBUILD_CPPFLAGS, it > warns: > > clang-16: error: argument unused during compilation: '-s' > [-Werror,-Wunused-command-line-argument] > >

[PATCH v2] net: wan: Add checks for NULL. If uhdlc_priv_tsa != 1 then utdm is not initialized. And if ret != NULL then goto undo_uhdlc_init, where utdm is dereferenced. Same if dev == NULL.

2023-01-10 Thread Esina Ekaterina
Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Esina Ekaterina v2: Add check for NULL for unmap_si_regs --- drivers/net/wan/fsl_ucc_hdlc.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/wan/fsl_ucc_hdlc.c

Re: [RFC DO NOT MERGE] treewide: use __xchg in most obvious places

2023-01-10 Thread Andy Shevchenko
On Tue, Jan 10, 2023 at 11:53:06AM +0100, Andrzej Hajda wrote: > This patch tries to show usability of __xchg helper. > It is not intended to be merged, but I can convert > it to proper patchset if necessary. > > There are many more places where __xchg can be used. > This demo shows the most

[RFC DO NOT MERGE] treewide: use __xchg in most obvious places

2023-01-10 Thread Andrzej Hajda
This patch tries to show usability of __xchg helper. It is not intended to be merged, but I can convert it to proper patchset if necessary. There are many more places where __xchg can be used. This demo shows the most spectacular cases IMHO: - previous value is returned from function, - temporary

[powerpc] Boot failure kernel BUG at mm/usercopy.c:102

2023-01-10 Thread Sachin Sant
6.2.0-rc3-next-20230109 fails to boot on powerpc with following: [ 0.444834] [ cut here ] [ 0.444838] kernel BUG at mm/usercopy.c:102! [ 0.444842] Oops: Exception in kernel mode, sig: 5 [#1] [ 0.444845] LE PAGE_SIZE=64K MMU=Radix SMP NR_CPUS=2048 NUMA pSeries [ 0.444849]

Re: [PATCH] net-wan: Add check for NULL for utdm in ucc_hdlc_probe

2023-01-10 Thread Екатерина Есина
    -Original Message- From: Christophe To: Ekaterina ; Zhao Cc: lvc-project ; netdev ; linux-kernel ; Eric ; Jakub ; Paolo ; linuxppc-dev ; David Date: Monday, 9 January 2023 6:49 PM MSK Subject: Re: [PATCH] net-wan: Add check for NULL for utdm in ucc_hdlc_probe Le

Re: [PATCH 15/15] backlight: backlight: Drop the deprecated fb_blank property

2023-01-10 Thread Lee Jones
On Mon, 09 Jan 2023, Sam Ravnborg wrote: > Hi Daniel. > > On Mon, Jan 09, 2023 at 11:06:35AM +, Daniel Thompson wrote: > > On Sat, Jan 07, 2023 at 07:26:29PM +0100, Sam Ravnborg via B4 Submission > > Endpoint wrote: > > > From: Sam Ravnborg > > > > > > With all users gone remove the

Re: usb.c:undefined reference to `qe_immr'

2023-01-10 Thread Randy Dunlap
9b1da90729d8 > commit: 7b4537199a4a8480b8c3ba37a2d44765ce76cd9b kbuild: link symbol CRCs at > final link, removing CONFIG_MODULE_REL_CRCS > date: 8 months ago > config: powerpc-randconfig-r026-20230110 > compiler: powerpc-linux-gcc (GCC) 12.1.0 > reproduce (this is a W=1 build): > wget > http

Re: [PATCH v1 06/10] powerpc/bpf: Perform complete extra passes to update addresses

2023-01-10 Thread Naveen N. Rao
Christophe Leroy wrote: Le 13/12/2022 à 11:23, Naveen N. Rao a écrit : Christophe Leroy wrote: BPF core calls the jit compiler again for an extra pass in order to properly set subprog addresses. Unlike other architectures, powerpc only updates the addresses during that extra pass. It means

Re: [PATCH v2] powerpc/pseries: fix potential memory leak in init_cpu_associativity()

2023-01-10 Thread Naveen N. Rao
Wang Yufen wrote: If the vcpu_associativity alloc memory successfully but the pcpu_associativity fails to alloc memory, the vcpu_associativity memory leaks. Fixes: d62c8deeb6e6 ("powerpc/pseries: Provide vcpu dispatch statistics") Signed-off-by: Wang Yufen ---

Re: [PATCH v2 04/10] powerpc/8xx: Use a larger CPM1 command check mask

2023-01-10 Thread Christophe Leroy
Le 06/01/2023 à 17:37, Herve Codina a écrit : > The CPM1 command mask is defined for use with the standard > CPM1 command register as described in the user's manual: >0 |13|47|8 11|12 14| 15| >RST|- |OPCODE|CH_NUM| -|FLG| > > In the QMC extension the

Re: [PATCH v2 08/10] dt-bindings: sound: Add support for QMC audio

2023-01-10 Thread Herve Codina
Hi Krzysztof, On Sun, 8 Jan 2023 16:16:24 +0100 Krzysztof Kozlowski wrote: > On 06/01/2023 17:37, Herve Codina wrote: > > The QMC (QUICC mutichannel controller) is a controller > > present in some PowerQUICC SoC such as MPC885. > > The QMC audio is an ASoC component that uses the QMC > >

Re: [PATCH v2] hvc/xen: lock console list traversal

2023-01-10 Thread Juergen Gross
On 30.11.22 17:36, Roger Pau Monne wrote: The currently lockless access to the xen console list in vtermno_to_xencons() is incorrect, as additions and removals from the list can happen anytime, and as such the traversal of the list to get the private console data for a given termno needs to

Re: [PATCH v2 05/10] dt-bindings: soc: fsl: cpm_qe: Add QMC controller

2023-01-10 Thread Herve Codina
Hi Krzysztof, On Sun, 8 Jan 2023 16:14:47 +0100 Krzysztof Kozlowski wrote: [...] > > + > > + interrupts: > > +description: SCC interrupt line in the CPM interrupt controller > > Missing constraints. 'maxItems: 1' will be added in v3 > > > + > > + fsl,cpm-command: > > +$ref:

Re: [PATCH v2 01/10] dt-bindings: soc: fsl: cpm_qe: Add TSA controller

2023-01-10 Thread Herve Codina
Hi Krzysztof, On Sun, 8 Jan 2023 16:10:38 +0100 Krzysztof Kozlowski wrote: [...] > > + '#size-cells': > > +const: 0 > > + > > +patternProperties: > > + "^tdm@[0-1]$": > > Use consistent quotes - either ' or " Ok, I will change on v3. I will also change them on the other bindings

Re: [PATCH 41/41] mm: replace rw_semaphore with atomic_t in vma_lock

2023-01-10 Thread Vlastimil Babka
On 1/9/23 21:53, Suren Baghdasaryan wrote: > rw_semaphore is a sizable structure of 40 bytes and consumes > considerable space for each vm_area_struct. However vma_lock has > two important specifics which can be used to replace rw_semaphore > with a simpler structure: > 1. Readers never wait. They