[PATCH v6 26/27] PCI/AER: Forward RCH downstream port-detected errors to the CXL.mem dev handler

2023-06-21 Thread Terry Bowman
From: Robert Richter In Restricted CXL Device (RCD) mode a CXL device is exposed as an RCiEP, but CXL downstream and upstream ports are not enumerated and not visible in the PCIe hierarchy. [1] Protocol and link errors from these non-enumerated ports are signaled as internal AER errors, either

Re: [PATCH 01/79] fs: add ctime accessors infrastructure

2023-06-21 Thread Damien Le Moal
On 6/21/23 23:45, Jeff Layton wrote: > struct timespec64 has unused bits in the tv_nsec field that can be used > for other purposes. In future patches, we're going to change how the > inode->i_ctime is accessed in certain inodes in order to make use of > them. In order to do that safely though,

Re: [PATCH v2 05/12] powerpc: add pte_free_defer() for pgtables sharing page

2023-06-21 Thread Hugh Dickins
On Tue, 20 Jun 2023, Jason Gunthorpe wrote: > On Tue, Jun 20, 2023 at 12:54:25PM -0700, Hugh Dickins wrote: > > On Tue, 20 Jun 2023, Jason Gunthorpe wrote: > > > On Tue, Jun 20, 2023 at 12:47:54AM -0700, Hugh Dickins wrote: > > > > Add powerpc-specific pte_free_defer(), to call pte_free() via > >

Re: [PATCH 02/79] spufs: switch to new ctime accessors

2023-06-21 Thread Jeremy Kerr
Hi Jeff, > In later patches, we're going to change how the ctime.tv_nsec field is > utilized. Switch to using accessor functions instead of raw accesses > of inode->i_ctime. s/utilized/used/ :D All looks good on the spufs change: Acked-by: Jeremy Kerr (also, thanks for including the

Re: [PATCH v2 6/6] watchdog/hardlockup: Define HARDLOCKUP_DETECTOR_ARCH

2023-06-21 Thread Doug Anderson
Hi, On Wed, Jun 21, 2023 at 6:08 AM Michael Ellerman wrote: > > Petr Mladek writes: > > The HAVE_ prefix means that the code could be enabled. Add another > > variable for HAVE_HARDLOCKUP_DETECTOR_ARCH without this prefix. > > It will be set when it should be built. It will make it compatible >

[PATCH] powerpc: Move arch_trigger_cpumask_backtrace from nmi.h to irq.h

2023-06-21 Thread Douglas Anderson
The powerpc architecture was the only one that defined arch_trigger_cpumask_backtrace() in asm/nmi.h instead of asm/irq.h. Move it to be consistent. This fixes compile time errors introduced by commit 7ca8fe94aa92 ("watchdog/hardlockup: define HARDLOCKUP_DETECTOR_ARCH"). That commit caused to

Re: [PATCH v2 12/13] s390/kexec: refactor for kernel/Kconfig.kexec

2023-06-21 Thread Mimi Zohar
On Wed, 2023-06-21 at 07:00 +0200, Alexander Gordeev wrote: > AFAICT the MODULE_SIG_FORMAT dependency was introduced with commit > c8424e776b09 ("MODSIGN: Export module signature definitions") and > in fact was not necessary, since s390 did/does not use mod_check_sig() > anyway. So the

Re: [PATCH 00/79] fs: new accessors for inode->i_ctime

2023-06-21 Thread Jeff Layton
On Wed, 2023-06-21 at 15:21 -0400, Steven Rostedt wrote: > On Wed, 21 Jun 2023 10:45:05 -0400 > Jeff Layton wrote: > > > Most of this conversion was done via coccinelle, with a few of the more > > non-standard accesses done by hand. There should be no behavioral > > changes with this set. That

Re: [PATCH 00/79] fs: new accessors for inode->i_ctime

2023-06-21 Thread Steven Rostedt
On Wed, 21 Jun 2023 10:45:05 -0400 Jeff Layton wrote: > Most of this conversion was done via coccinelle, with a few of the more > non-standard accesses done by hand. There should be no behavioral > changes with this set. That will come later, as we convert individual > filesystems to use

Re: [PATCH 01/79] fs: add ctime accessors infrastructure

2023-06-21 Thread Jeff Layton
On Wed, 2023-06-21 at 14:19 -0400, Tom Talpey wrote: > On 6/21/2023 2:01 PM, Jeff Layton wrote: > > On Wed, 2023-06-21 at 13:29 -0400, Tom Talpey wrote: > > > On 6/21/2023 10:45 AM, Jeff Layton wrote: > > > > struct timespec64 has unused bits in the tv_nsec field that can be used > > > > for other

Re: [PATCH 15/17] perf tests task_analyzer: fix bad substitution ${$1}

2023-06-21 Thread Aditya Gupta
Hello Namhyung, On 21/06/23 20:53, Namhyung Kim wrote: Hello Aditya, On Wed, Jun 21, 2023 at 3:05 AM Aditya Gupta wrote: Hello Namhyung, On 21/06/23 06:18, Namhyung Kim wrote: ... $ sudo ./perf test -v task 114: perf script task-analyzer tests : --- start

Re: [PATCH 01/79] fs: add ctime accessors infrastructure

2023-06-21 Thread Tom Talpey
On 6/21/2023 2:01 PM, Jeff Layton wrote: On Wed, 2023-06-21 at 13:29 -0400, Tom Talpey wrote: On 6/21/2023 10:45 AM, Jeff Layton wrote: struct timespec64 has unused bits in the tv_nsec field that can be used for other purposes. In future patches, we're going to change how the inode->i_ctime is

Re: [PATCH 01/79] fs: add ctime accessors infrastructure

2023-06-21 Thread Jeff Layton
On Wed, 2023-06-21 at 13:29 -0400, Tom Talpey wrote: > On 6/21/2023 10:45 AM, Jeff Layton wrote: > > struct timespec64 has unused bits in the tv_nsec field that can be used > > for other purposes. In future patches, we're going to change how the > > inode->i_ctime is accessed in certain inodes in

Re: [PATCH 01/79] fs: add ctime accessors infrastructure

2023-06-21 Thread Tom Talpey
On 6/21/2023 10:45 AM, Jeff Layton wrote: struct timespec64 has unused bits in the tv_nsec field that can be used for other purposes. In future patches, we're going to change how the inode->i_ctime is accessed in certain inodes in order to make use of them. In order to do that safely though,

Re: [PATCH v2 12/13] s390/kexec: refactor for kernel/Kconfig.kexec

2023-06-21 Thread Eric DeVolder
On 6/21/23 00:00, Alexander Gordeev wrote: On Mon, Jun 19, 2023 at 10:58:00AM -0400, Eric DeVolder wrote: Hi Eric, The kexec and crash kernel options are provided in the common kernel/Kconfig.kexec. Utilize the common options and provide the ARCH_SUPPORTS_ and ARCH_SELECTS_ entries to

Re: [PATCH 01/79] fs: add ctime accessors infrastructure

2023-06-21 Thread Jan Kara
On Wed 21-06-23 10:45:06, Jeff Layton wrote: > struct timespec64 has unused bits in the tv_nsec field that can be used > for other purposes. In future patches, we're going to change how the > inode->i_ctime is accessed in certain inodes in order to make use of > them. In order to do that safely

[PATCH 79/79] fs: rename i_ctime field to __i_ctime

2023-06-21 Thread Jeff Layton
Now that everything in-tree is converted to use the accessor functions, rename the i_ctime field in the inode to make its accesses more self-documenting. Signed-off-by: Jeff Layton --- include/linux/fs.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 01/79] fs: add ctime accessors infrastructure

2023-06-21 Thread Jeff Layton
struct timespec64 has unused bits in the tv_nsec field that can be used for other purposes. In future patches, we're going to change how the inode->i_ctime is accessed in certain inodes in order to make use of them. In order to do that safely though, we'll need to eradicate raw accesses of the

[PATCH 00/79] fs: new accessors for inode->i_ctime

2023-06-21 Thread Jeff Layton
I've been working on a patchset to change how the inode->i_ctime is accessed in order to give us conditional, high-res timestamps for the ctime and mtime. struct timespec64 has unused bits in it that we can use to implement this. In order to do that however, we need to wrap all accesses of

Re: [PATCH 09/11] sysctl: Remove the end element in sysctl table arrays

2023-06-21 Thread Joel Granados
On Wed, Jun 21, 2023 at 04:15:46PM +0300, Jani Nikula wrote: > On Wed, 21 Jun 2023, Joel Granados wrote: > > On Wed, Jun 21, 2023 at 02:16:55PM +0300, Jani Nikula wrote: > >> On Wed, 21 Jun 2023, Joel Granados wrote: > >> > Remove the empty end element from all the arrays that are passed to the

Re: [PATCH 09/11] sysctl: Remove the end element in sysctl table arrays

2023-06-21 Thread Jani Nikula
On Wed, 21 Jun 2023, Joel Granados wrote: > On Wed, Jun 21, 2023 at 02:16:55PM +0300, Jani Nikula wrote: >> On Wed, 21 Jun 2023, Joel Granados wrote: >> > Remove the empty end element from all the arrays that are passed to the >> > register sysctl calls. In some files this means reducing the

Re: [PATCH 09/11] sysctl: Remove the end element in sysctl table arrays

2023-06-21 Thread Joel Granados
On Wed, Jun 21, 2023 at 02:16:55PM +0300, Jani Nikula wrote: > On Wed, 21 Jun 2023, Joel Granados wrote: > > Remove the empty end element from all the arrays that are passed to the > > register sysctl calls. In some files this means reducing the explicit > > array size by one. Also make sure that

Re: [PATCH 09/11] sysctl: Remove the end element in sysctl table arrays

2023-06-21 Thread Jani Nikula
On Wed, 21 Jun 2023, Joel Granados wrote: > Remove the empty end element from all the arrays that are passed to the > register sysctl calls. In some files this means reducing the explicit > array size by one. Also make sure that we are using the size in > ctl_table_header instead of evaluating

[PATCH 09/11] sysctl: Remove the end element in sysctl table arrays

2023-06-21 Thread Joel Granados
Remove the empty end element from all the arrays that are passed to the register sysctl calls. In some files this means reducing the explicit array size by one. Also make sure that we are using the size in ctl_table_header instead of evaluating the .procname element. Signed-off-by: Joel Granados

[PATCH 07/11] sysctl: Add size to register_sysctl

2023-06-21 Thread Joel Granados
In order to remove the end element from the ctl_table struct arrays, we explicitly define the size when registering the targes. We add a size argument to register_sysctl and change all the callers to pass the ARRAY_SIZE of their table arg. Signed-off-by: Joel Granados --- arch/arm/kernel/isa.c

Re: [PATCH v2 12/13] s390/kexec: refactor for kernel/Kconfig.kexec

2023-06-21 Thread Alexander Gordeev
On Mon, Jun 19, 2023 at 10:58:00AM -0400, Eric DeVolder wrote: Hi Eric, > The kexec and crash kernel options are provided in the common > kernel/Kconfig.kexec. Utilize the common options and provide > the ARCH_SUPPORTS_ and ARCH_SELECTS_ entries to recreate the > equivalent set of KEXEC and

Re: [PATCH v2 08/16] mm/vmemmap: Improve vmemmap_can_optimize and allow architectures to override

2023-06-21 Thread Joao Martins
On 16/06/2023 12:08, Aneesh Kumar K.V wrote: > dax vmemmap optimization requires a minimum of 2 PAGE_SIZE area within > vmemmap such that tail page mapping can point to the second PAGE_SIZE area. > Enforce that in vmemmap_can_optimize() function. > > Architectures like powerpc also want to enable

Re: [PATCH v2 13/13] sh/kexec: refactor for kernel/Kconfig.kexec

2023-06-21 Thread Eric DeVolder
On 6/19/23 13:21, John Paul Adrian Glaubitz wrote: Acked-by: John Paul Adrian Glaubitz Thank you! eric

Re: [PATCH v2 08/13] mips/kexec: refactor for kernel/Kconfig.kexec

2023-06-21 Thread Eric DeVolder
On 6/20/23 07:52, Thomas Bogendoerfer wrote: Acked-by: Thomas Bogendoerfer Thank you! eric

Re: [PATCH v2 02/13] x86/kexec: refactor for kernel/Kconfig.kexec

2023-06-21 Thread Baoquan He
On 06/20/23 at 07:56am, Eric DeVolder wrote: > > > On 6/20/23 03:21, Baoquan He wrote: > > Hi Eric, > > > > On 06/19/23 at 10:57am, Eric DeVolder wrote: > > .. > > > +config ARCH_SUPPORTS_KEXEC > > > + def_bool y > > > -config ARCH_HAS_KEXEC_PURGATORY > > > - def_bool KEXEC_FILE > > >

Re: [PATCH v2 08/13] mips/kexec: refactor for kernel/Kconfig.kexec

2023-06-21 Thread Thomas Bogendoerfer
On Mon, Jun 19, 2023 at 10:57:56AM -0400, Eric DeVolder wrote: > The kexec and crash kernel options are provided in the common > kernel/Kconfig.kexec. Utilize the common options and provide > the ARCH_SUPPORTS_ and ARCH_SELECTS_ entries to recreate the > equivalent set of KEXEC and CRASH options.

Re: [PATCH v2 02/13] x86/kexec: refactor for kernel/Kconfig.kexec

2023-06-21 Thread Eric DeVolder
On 6/20/23 03:21, Baoquan He wrote: Hi Eric, On 06/19/23 at 10:57am, Eric DeVolder wrote: .. +config ARCH_SUPPORTS_KEXEC + def_bool y -config ARCH_HAS_KEXEC_PURGATORY - def_bool KEXEC_FILE +config ARCH_SUPPORTS_KEXEC_FILE + def_bool X86_64 && CRYPTO &&

Re: [PATCH v2 02/13] x86/kexec: refactor for kernel/Kconfig.kexec

2023-06-21 Thread Baoquan He
Hi Eric, On 06/19/23 at 10:57am, Eric DeVolder wrote: .. > +config ARCH_SUPPORTS_KEXEC > + def_bool y > > -config ARCH_HAS_KEXEC_PURGATORY > - def_bool KEXEC_FILE > +config ARCH_SUPPORTS_KEXEC_FILE > + def_bool X86_64 && CRYPTO && CRYPTO_SHA256 .. > +config

Re: [PATCH v2 2/2] mm/mmu_gather: send tlb_remove_table_smp_sync IPI only to MM CPUs

2023-06-21 Thread Nadav Amit
> > On Jun 20, 2023, at 7:46 AM, Yair Podemsky wrote: > > @@ -1525,7 +1525,7 @@ static void collapse_and_free_pmd(struct mm_struct *mm, > struct vm_area_struct *v > addr + HPAGE_PMD_SIZE); > mmu_notifier_invalidate_range_start(); > pmd =

Re: [PATCH v2 2/2] mm/mmu_gather: send tlb_remove_table_smp_sync IPI only to MM CPUs

2023-06-21 Thread Dave Hansen
On 6/20/23 07:46, Yair Podemsky wrote: > -void tlb_remove_table_sync_one(void) > +#ifdef CONFIG_ARCH_HAS_CPUMASK_BITS > +#define REMOVE_TABLE_IPI_MASK mm_cpumask(mm) > +#else > +#define REMOVE_TABLE_IPI_MASK cpu_online_mask > +#endif /* CONFIG_ARCH_HAS_CPUMASK_BITS */ > + > +void

Re: [PATCH 02/79] spufs: switch to new ctime accessors

2023-06-21 Thread Jan Kara
On Wed 21-06-23 10:45:15, Jeff Layton wrote: > In later patches, we're going to change how the ctime.tv_nsec field is > utilized. Switch to using accessor functions instead of raw accesses of > inode->i_ctime. > > Signed-off-by: Jeff Layton Looks good to me. Feel free to add: Reviewed-by: Jan

Re: [PATCH 15/17] perf tests task_analyzer: fix bad substitution ${$1}

2023-06-21 Thread Namhyung Kim
Hello Aditya, On Wed, Jun 21, 2023 at 3:05 AM Aditya Gupta wrote: > > Hello Namhyung, > > On 21/06/23 06:18, Namhyung Kim wrote: > > Hello, > > > > On Tue, Jun 13, 2023 at 1:06 PM Arnaldo Carvalho de Melo > > wrote: > >> Em Tue, Jun 13, 2023 at 10:11:43PM +0530, Athira Rajeev escreveu: > >>>

[PATCH] objtool: Make 'sec-address' always on

2023-06-21 Thread Christophe Leroy
Most of the time objtool warnings are useless without the absolute address within the section. Today there is --sec-address option to get it printed, but that option is nowhere used and requires a change in Makefile to use it. Having the address inside the section at all time in addition to the

Re: [kvm-unit-tests v4 02/12] powerpc: Add some checking to exception handler install

2023-06-21 Thread Thomas Huth
On 08/06/2023 09.58, Nicholas Piggin wrote: Check to ensure exception handlers are not being overwritten or invalid exception numbers are used. Signed-off-by: Nicholas Piggin --- Since v3: - Simplified code as suggested by Thomas. lib/powerpc/processor.c | 10 +++--- 1 file changed, 7

Re: [kvm-unit-tests v4 01/12] powerpc: Report instruction address and MSR in unhandled exception error

2023-06-21 Thread Thomas Huth
On 08/06/2023 09.58, Nicholas Piggin wrote: Signed-off-by: Nicholas Piggin --- Since v3: - New patch lib/powerpc/processor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/powerpc/processor.c b/lib/powerpc/processor.c index ec85b9d8..05b4b04f 100644 ---

[PATCH 02/79] spufs: switch to new ctime accessors

2023-06-21 Thread Jeff Layton
In later patches, we're going to change how the ctime.tv_nsec field is utilized. Switch to using accessor functions instead of raw accesses of inode->i_ctime. Signed-off-by: Jeff Layton --- arch/powerpc/platforms/cell/spufs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH v2 6/6] watchdog/hardlockup: Define HARDLOCKUP_DETECTOR_ARCH

2023-06-21 Thread Michael Ellerman
Petr Mladek writes: > The HAVE_ prefix means that the code could be enabled. Add another > variable for HAVE_HARDLOCKUP_DETECTOR_ARCH without this prefix. > It will be set when it should be built. It will make it compatible > with the other hardlockup detectors. > > The change allows to clean up

Re: [PATCH] powerpc/ptrace: Split gpr32_set_common

2023-06-21 Thread kernel test robot
Hi Christophe, kernel test robot noticed the following build warnings: [auto build test WARNING on powerpc/next] [also build test WARNING on powerpc/fixes linus/master v6.4-rc7 next-20230621] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [PATCH] powerpc/ptrace: Split gpr32_set_common

2023-06-21 Thread kernel test robot
Hi Christophe, kernel test robot noticed the following build errors: [auto build test ERROR on powerpc/next] [also build test ERROR on powerpc/fixes linus/master v6.4-rc7 next-20230621] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

[PATCH] powerpc/reg: Remove #ifdef around mtspr macro

2023-06-21 Thread Christophe Leroy
That ifdef was introduced by commit 1458dd951f7c ("powerpc/8xx: Handle CPU6 ERRATA directly in mtspr() macro") and left over by commit 2a45addd21de ("powerpc/8xx: Remove CPU6 ERRATA Workaround") Remove it. Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/reg.h | 2 -- 1 file

[PATCH] powerpc/kuap: KUAP enabling/disabling functions must be __always_inline

2023-06-21 Thread Christophe Leroy
Objtool reports following warnings: arch/powerpc/kernel/signal_32.o: warning: objtool: __prevent_user_access.constprop.0+0x4 (.text+0x4): redundant UACCESS disable arch/powerpc/kernel/signal_32.o: warning: objtool: user_access_begin+0x2c (.text+0x4c): return with UACCESS enabled

[PATCH] powerpc/step: Mark __copy_mem_out() and __emulate_dcbz() __always_inline

2023-06-21 Thread Christophe Leroy
objtool reports two folliwng warnings: arch/powerpc/lib/sstep.o: warning: objtool: copy_mem_out+0x3c (.text+0x30c): call to __copy_mem_out() with UACCESS enabled arch/powerpc/lib/sstep.o: warning: objtool: emulate_dcbz+0x70 (.text+0x4dc): call to __emulate_dcbz() with UACCESS enabled

[PATCH] powerpc/ptrace: Split gpr32_set_common

2023-06-21 Thread Christophe Leroy
objtool report the following warning: arch/powerpc/kernel/ptrace/ptrace-view.o: warning: objtool: gpr32_set_common+0x23c (.text+0x860): redundant UACCESS disable gpr32_set_common() conditionnaly opens and closes UACCESS based on whether kbuf point is NULL or not. This is wackelig. Split

Re: [PATCH 15/17] perf tests task_analyzer: fix bad substitution ${$1}

2023-06-21 Thread Aditya Gupta
Hello Namhyung, On 21/06/23 06:18, Namhyung Kim wrote: Hello, On Tue, Jun 13, 2023 at 1:06 PM Arnaldo Carvalho de Melo wrote: Em Tue, Jun 13, 2023 at 10:11:43PM +0530, Athira Rajeev escreveu: This issue due to ${$1} caused all function calls to give error in `find_str_or_fail` line, and so

[PATCH 20/22] tools/perf/tests: Fix the shellcheck wanrings in lib/waiting.sh

2023-06-21 Thread Athira Rajeev
Running shellcheck in "lib/waiting.sh" generates below warning: In ./tools/perf/tests/shell/lib/waiting.sh line 1: # SPDX-License-Identifier: GPL-2.0 ^-- SC2148 (error): Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. Fix this by adding shebang

[PATCH 17/22] tools/perf/tests: Fix shellcheck warnings for thread_loop_check_tid_10.sh

2023-06-21 Thread Athira Rajeev
Fix the shellcheck warnings for thread_loop_check_tid_10.sh In ./tools/perf/tests/shell/coresight/thread_loop_check_tid_10.sh line 8: . $(dirname $0)/../lib/coresight.sh ^---^ SC2046 (warning): Quote this to prevent word splitting. Add quotes to prevent word splitting which

[PATCH 21/22] tools/perf/trace: Fix x86_arch_prctl.sh to address shellcheck warnings

2023-06-21 Thread Athira Rajeev
Running shellcheck on x86_arch_prctl.sh generates below warning: In ./tools/perf/trace/beauty/x86_arch_prctl.sh line 10: local idx=$1 ^---^ SC3043 (warning): In POSIX sh, 'local' is undefined. In ./tools/perf/trace/beauty/x86_arch_prctl.sh line 11: local prefix=$2

[PATCH 22/22] tools/perf/arch/x86: Fix syscalltbl.sh to address shellcheck warnings

2023-06-21 Thread Athira Rajeev
Running shellcheck on syscalltbl.sh generates below warning: In ./tools/perf/arch/x86/entry/syscalls/syscalltbl.sh line 27: while read nr abi name entry compat; do ^-^ SC2034 (warning): abi appears unused. Verify use (or export if used externally).

[PATCH 19/22] tools/perf/tests: Fix shellcheck warnings for lib/probe_vfs_getname.sh

2023-06-21 Thread Athira Rajeev
Running shellcheck on probe_vfs_getname fails with below warning: In ./tools/perf/tests/shell/lib/probe_vfs_getname.sh line 1: # Arnaldo Carvalho de Melo , 2017 ^-- SC2148 (error): Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. In

[PATCH 18/22] tools/perf/tests: Fix shellcheck warnings for unroll_loop_thread_10.sh

2023-06-21 Thread Athira Rajeev
Fix the shellcheck warnings for unroll_loop_thread_10.sh Add quotes to prevent word splitting which are caused by unquoted command expansions. Signed-off-by: Athira Rajeev --- tools/perf/tests/shell/coresight/unroll_loop_thread_10.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 16/22] tools/perf: Fix shellcheck issue for check-headers.sh script

2023-06-21 Thread Athira Rajeev
From: Kajol Jain Running shellcheck on check-headers.sh generates below warning: In check-headers.sh line 126: check_2 "tools/$file" "$file" $* ^-- SC2048 (warning): Use "$@" (with quotes) to prevent whitespace problems. In check-headers.sh line 134:

[PATCH 15/22] tools/perf/trace: Fix shellcheck issue for arch_errno_names.sh script

2023-06-21 Thread Athira Rajeev
From: Kajol Jain Running shellcheck on arch_errno_names.sh generates below warning: In arch_errno_names.sh line 20: local arch="$1" ^^ SC3043 (warning): In POSIX sh, 'local' is undefined. .. In arch_errno_names.sh line 61: local arch ^^

[PATCH 14/22] tools/perf/tests: Fix shellcheck warning for probe.sh shell script

2023-06-21 Thread Athira Rajeev
From: Kajol Jain Running shellcheck on probe.sh throws below warning: In lib/probe.sh line 1: ^-- SC2148 (error): Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. Fixed the warnings by adding shell directive. Signed-off-by: Athira Rajeev Signed-off-by:

[PATCH 13/22] tools/perf/tests: Fix shellcheck warning for coresight.sh shell script

2023-06-21 Thread Athira Rajeev
From: Kajol Jain Running shellcheck on coresight.sh throws below warning: In lib/coresight.sh line 1: ^-- SC2148 (error): Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. In lib/coresight.sh line 13: PERFRECOPT="$PERFRECMEM -e cs_etm//u" ^^

[PATCH 12/22] tools/perf/tests: Fix shellcheck warning for memcpy_thread_16k_10.sh shell script

2023-06-21 Thread Athira Rajeev
From: Kajol Jain Running shellcheck on memcpy_thread_16k_10.sh throws below warning: In memcpy_thread_16k_10.sh line 8: . $(dirname $0)/../lib/coresight.sh ^---^ SC2046 (warning): Quote this to prevent word splitting. Fixed the warning by adding quotes to avoid word splitting.

[PATCH 11/22] tools/perf/tests: Fix shellcheck warning for asm_pure_loop.sh shell script

2023-06-21 Thread Athira Rajeev
From: Kajol Jain Running shellcheck on asm_pure_loop.sh throws below warning: In coresight/asm_pure_loop.sh line 8: . $(dirname $0)/../lib/coresight.sh ^---^ SC2046 (warning): Quote this to prevent word splitting. Fixed the warning by adding quotes to avoid word splitting.

[PATCH 10/22] tools/perf/tests: Fix shellcheck issues in tests/shell/stat+shadow_stat.sh tetscase

2023-06-21 Thread Athira Rajeev
Running shellcheck on stat+shadow_stat.sh generates below warning: In tests/shell/stat+shadow_stat.sh line 48: while read cpu num evt hash ipc rest ^--^ SC2034 (warning): hash appears unused. Verify use (or export if used externally). This variable is

[PATCH 09/22] tools/perf/tests: Fix shellcheck issue for stat_bpf_counters.sh testcase

2023-06-21 Thread Athira Rajeev
Running shellcheck on stat_bpf_counter.sh generates below warning: In tests/shell/stat_bpf_counters.sh line 34: if [ "$base_cycles" == "&1 | awk '/cycles/ {print $1}') -if [ "$bpf_cycles" == "

[PATCH 08/22] tools/perf/tests: fix shellcheck warning for test_perf_data_converter_json.sh testcase

2023-06-21 Thread Athira Rajeev
Running shellcheck on test_perf_data_converter_json.sh throws below warning: In tests/shell/test_perf_data_converter_json.sh line 42: if [ $(cat "${result}" | wc -l) -gt "0" ] ; then ^^ SC2046 (warning): Quote this to prevent word splitting.

[PATCH 07/22] tools/perf/tests: Fix unused variable references in stat+csv_summary.sh testcase

2023-06-21 Thread Athira Rajeev
Running shellcheck on stat+csv_summary.sh throws below warnings: In tests/shell/stat+csv_summary.sh line 26: while read num event run pct ^-^ SC2034 (warning): num appears unused. Verify use (or export if used externally). ^---^ SC2034 (warning): event

[PATCH 06/22] tools/perf/tests: fix test_arm_spe_fork.sh signal case issues

2023-06-21 Thread Athira Rajeev
Running shellcheck -S on test_arm_spe_fork.sh throws below warnings: In tests/shell/test_arm_spe_fork.sh line 25: trap cleanup_files exit term int ^--^ SC3049 (warning): In POSIX sh, using lower/mixed case for signal names is undefined. ^--^

[PATCH 05/22] tools/perf/tests: Fix shellcheck issue for stat_bpf_counters_cgrp.sh testcase

2023-06-21 Thread Athira Rajeev
From: Kajol Jain Running shellcheck on lock_contention.sh generates below warning: In stat_bpf_counters_cgrp.sh line 28: if [ -d /sys/fs/cgroup/system.slice -a -d /sys/fs/cgroup/user.slice ]; then ^-- SC2166 (warning): Prefer [ p ] && [ q ]

[PATCH 04/22] tools/perf/tests: Fix shellcheck issue for lock_contention.sh testcase

2023-06-21 Thread Athira Rajeev
From: Kajol Jain Running shellcheck on lock_contention.sh generates below warning: In tests/shell/lock_contention.sh line 24: if [ `id -u` != 0 ]; then ^-^ SC2046 (warning): Quote this to prevent word splitting. In tests/shell/lock_contention.sh line 160: local

[PATCH 03/22] tools/perf/tests: Fix shellcheck warning for record_offcpu.sh testcase

2023-06-21 Thread Athira Rajeev
From: Kajol Jain Running shellcheck on record_offcpu.sh throws below warning: In tests/shell/record_offcpu.sh line 13: trap - exit term int ^--^ SC3049 (warning): In POSIX sh, using lower/mixed case for signal names is undefined. ^--^ SC3049 (warning): In POSIX sh,

[PATCH 02/22] tools/perf/tests: Fix shellcheck warning for probe_vfs_getname.sh testcase

2023-06-21 Thread Athira Rajeev
From: Kajol Jain Running shellcheck on probe_vfs_getname.sh throws below warning: In tests/shell/probe_vfs_getname.sh line 7: . $(dirname $0)/lib/probe.sh ^---^ SC2046 (warning): Quote this to prevent word splitting. In tests/shell/probe_vfs_getname.sh line 11: . $(dirname

[PATCH 01/22] tools/perf/tests: Fix shellcheck warnings for trace+probe_vfs_getname.sh

2023-06-21 Thread Athira Rajeev
From: Akanksha J N Running shellcheck -S on probe_vfs_getname.sh, throws below warnings: Before fix: $ shellcheck -S warning trace+probe_vfs_getname.sh In trace+probe_vfs_getname.sh line 13: . $(dirname $0)/lib/probe.sh ^---^ SC2046 (warning): Quote this to

[PATCH 00/22] tools/perf: Fix shellcheck coding/formatting issues of perf tool shell scripts

2023-06-21 Thread Athira Rajeev
Patchset covers a set of fixes for coding/formatting issues observed while running shellcheck tool on the perf shell scripts. This cleanup is a pre-requisite to include a build option for shellcheck discussed here: https://www.spinics.net/lists/linux-perf-users/msg25553.html First set of patches

Re: [PATCH v2 0/2] send tlb_remove_table_smp_sync IPI only to necessary CPUs

2023-06-21 Thread Peter Zijlstra
On Tue, Jun 20, 2023 at 05:46:16PM +0300, Yair Podemsky wrote: > Currently the tlb_remove_table_smp_sync IPI is sent to all CPUs > indiscriminately, this causes unnecessary work and delays notable in > real-time use-cases and isolated cpus. > By limiting the IPI to only be sent to cpus referencing

Re: [PATCH] KVM: PPC: remove unneeded variable

2023-06-21 Thread Thomas Huth
On 14/06/2023 07.58, baomingtong...@208suo.com wrote: fix the following coccicheck warning: arch/powerpc/kvm/book3s_pr.c:424:5-6: Unneeded variable: "r". Signed-off-by: Mingtong Bao ---  arch/powerpc/kvm/book3s_pr.c | 5 ++---  1 file changed, 2 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 02/16] powerpc/book3s64/mm: mmu_vmemmap_psize is used by radix

2023-06-21 Thread Aneesh Kumar K V
On 6/21/23 9:38 AM, Michael Ellerman wrote: > "Aneesh Kumar K.V" writes: >> This should not be within CONFIG_PPC_64S_HASHS_MMU. We use mmu_vmemmap_psize >> on radix while mapping the vmemmap area. >> >> Signed-off-by: Aneesh Kumar K.V >> --- >> arch/powerpc/mm/book3s64/radix_pgtable.c | 2 -- >>