Re: (subset) [PATCH v4 00/15] powerpc/objtool: uaccess validation for PPC32 (v4)

2023-07-20 Thread Michael Ellerman
Michael Ellerman writes: > On Tue, 11 Jul 2023 18:08:26 +0200, Christophe Leroy wrote: >> This series adds UACCESS validation for PPC32. It includes >> a dozen of changes to objtool core. >> >> It applies on top of series "Cleanup/Optimise KUAP (v3)" >>

Re: [PATCH v2 1/9] vgacon: rework Kconfig dependencies

2023-07-20 Thread Michael Ellerman
Arnd Bergmann writes: > From: Arnd Bergmann > > The list of dependencies here is phrased as an opt-out, but this is missing > a lot of architectures that don't actually support VGA consoles, and some > of the entries are stale: > > - powerpc used to support VGA consoles in the old arch/ppc

Re: [PATCH v6 2/3] PCI/AER: Disable AER interrupt on suspend

2023-07-20 Thread Kai-Heng Feng
On Tue, Jul 18, 2023 at 7:17 PM Bjorn Helgaas wrote: > > [+cc Rafael] > > On Fri, May 12, 2023 at 08:00:13AM +0800, Kai-Heng Feng wrote: > > PCIe services that share an IRQ with PME, such as AER or DPC, may cause a > > spurious wakeup on system suspend. To prevent this, disable the AER > >

Re: [PATCH] kdump fix

2023-07-20 Thread kernel test robot
Hi Mahesh, kernel test robot noticed the following build errors: [auto build test ERROR on linus/master] [also build test ERROR on v6.5-rc2 next-20230720] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented

[powerpc:merge] BUILD SUCCESS b33ef67081f836e80773e2cec99592e78091bace

2023-07-20 Thread kernel test robot
successfully. More configs may be tested in the coming days. tested configs: alphaallyesconfig gcc alpha defconfig gcc alpharandconfig-r011-20230720 gcc alpharandconfig-r022-20230720 gcc alpha

[powerpc:next-test] BUILD SUCCESS 9be3d0283c583c521b6fb67500bdea532b4f0d45

2023-07-20 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next-test branch HEAD: 9be3d0283c583c521b6fb67500bdea532b4f0d45 powerpc/64: Enable accelerated crypto algorithms in defconfig elapsed time: 798m configs tested: 2 configs skipped: 158 The following configs have

[powerpc:fixes-test] BUILD SUCCESS 106ea7ffd56b0f9454cd4f625474967f12ac4dbd

2023-07-20 Thread kernel test robot
gcc arc defconfig gcc arm allmodconfig gcc arm allyesconfig gcc arm defconfig gcc arm randconfig-r035-20230720 clang arm s3c6400_defconfig g

Re: [PATCH 4/4] powerpc/64s/radix: combine final TLB flush and lazy tlb mm shootdown IPIs

2023-07-20 Thread Nicholas Piggin
On Tue Jul 18, 2023 at 12:54 PM AEST, Michael Ellerman wrote: > Nicholas Piggin writes: > > This performs lazy tlb mm shootdown when doing the exit TLB flush when > > all mm users go away and user mappings are removed, which avoids having > > to do the lazy tlb mm shootdown IPIs on the final

Re: [RFC PATCH v11 12/29] KVM: Add KVM_CREATE_GUEST_MEMFD ioctl() for guest-specific backing memory

2023-07-20 Thread Xiaoyao Li
On 7/19/2023 7:44 AM, Sean Christopherson wrote: @@ -5134,6 +5167,16 @@ static long kvm_vm_ioctl(struct file *filp, case KVM_GET_STATS_FD: r = kvm_vm_ioctl_get_stats_fd(kvm); break; + case KVM_CREATE_GUEST_MEMFD: { + struct

Re: [RFC PATCH v11 12/29] KVM: Add KVM_CREATE_GUEST_MEMFD ioctl() for guest-specific backing memory

2023-07-20 Thread Isaku Yamahata
On Tue, Jul 18, 2023 at 04:44:55PM -0700, Sean Christopherson wrote: > +static int kvm_gmem_release(struct inode *inode, struct file *file) > +{ > + struct kvm_gmem *gmem = file->private_data; > + struct kvm_memory_slot *slot; > + struct kvm *kvm = gmem->kvm; > + unsigned long

Re: [RFC PATCH v11 08/29] KVM: Introduce per-page memory attributes

2023-07-20 Thread Sean Christopherson
On Thu, Jul 20, 2023, Isaku Yamahata wrote: > On Thu, Jul 20, 2023 at 04:09:12PM +0800, > Yuan Yao wrote: > > > On Tue, Jul 18, 2023 at 04:44:51PM -0700, Sean Christopherson wrote: > > > @@ -2301,4 +2305,14 @@ static inline void kvm_account_pgtable_pages(void > > > *virt, int nr) > > > /* Max

Re: [PATCH] kdump fix

2023-07-20 Thread kernel test robot
Hi Mahesh, kernel test robot noticed the following build errors: [auto build test ERROR on linus/master] [also build test ERROR on v6.5-rc2 next-20230720] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented

Re: [RFC PATCH v11 08/29] KVM: Introduce per-page memory attributes

2023-07-20 Thread Isaku Yamahata
On Thu, Jul 20, 2023 at 04:09:12PM +0800, Yuan Yao wrote: > On Tue, Jul 18, 2023 at 04:44:51PM -0700, Sean Christopherson wrote: > > From: Chao Peng > > > > In confidential computing usages, whether a page is private or shared is > > necessary information for KVM to perform operations like page

Re: [PATCH v2 2/9] vgacon: rework screen_info #ifdef checks

2023-07-20 Thread Khalid Aziz
On 7/19/23 6:39 AM, Arnd Bergmann wrote: From: Arnd Bergmann On non-x86 architectures, the screen_info variable is generally only used for the VGA console where supported, and in some cases the EFI framebuffer or vga16fb. Now that we have a definite list of which architectures actually use it

Re: [PATCH v2 6/9] vgacon: clean up global screen_info instances

2023-07-20 Thread Khalid Aziz
On 7/19/23 6:39 AM, Arnd Bergmann wrote: From: Arnd Bergmann To prepare for completely separating the VGA console screen_info from the one used in EFI/sysfb, rename the vgacon instances and make them local as much as possible. ia64 and arm both have confurations with vgacon and efi, but the

Re: [PATCH v2 1/9] vgacon: rework Kconfig dependencies

2023-07-20 Thread Khalid Aziz
On 7/19/23 6:39 AM, Arnd Bergmann wrote: From: Arnd Bergmann The list of dependencies here is phrased as an opt-out, but this is missing a lot of architectures that don't actually support VGA consoles, and some of the entries are stale: - powerpc used to support VGA consoles in the old

Re: [PATCH v2 5/9] vgacon: remove screen_info dependency

2023-07-20 Thread Khalid Aziz
On 7/19/23 6:39 AM, Arnd Bergmann wrote: From: Arnd Bergmann The vga console driver is fairly self-contained, and only used by architectures that explicitly initialize the screen_info settings. Chance every instance that picks the vga console by setting conswitchp to call a function instead,

Re: [RFC PATCH v11 12/29] KVM: Add KVM_CREATE_GUEST_MEMFD ioctl() for guest-specific backing memory

2023-07-20 Thread Sean Christopherson
On Thu, Jul 20, 2023, Xiaoyao Li wrote: > On 7/19/2023 7:44 AM, Sean Christopherson wrote: > > @@ -5134,6 +5167,16 @@ static long kvm_vm_ioctl(struct file *filp, > > case KVM_GET_STATS_FD: > > r = kvm_vm_ioctl_get_stats_fd(kvm); > > break; > > + case

[PATCH v4 2/2] PCI: layerscape: Add the workaround for lost link capabilities during reset.

2023-07-20 Thread Frank Li
From: Xiaowei Bao A workaround for the issue where the PCI Express Endpoint (EP) controller loses the values of the Maximum Link Width and Supported Link Speed from the Link Capabilities Register, which initially configured by the Reset Configuration Word (RCW) during a link-down or hot reset

[PATCH v4 1/2] PCI: layerscape: Add support for Link down notification

2023-07-20 Thread Frank Li
Add support to pass Link down notification to Endpoint function driver so that the LINK_DOWN event can be processed by the function. Acked-by: Manivannan Sadhasivam Signed-off-by: Frank Li --- Change from v2 to v4 - none Change from v1 to v2 drivers/pci/controller/dwc/pci-layerscape-ep.c | 1

Re: [PATCH v2] powerpc/512x: lpbfifo: Convert to platform remove callback returning void

2023-07-20 Thread Michael Ellerman
On Tue, 11 Jul 2023 16:31:45 +0200, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a

Re: [PATCH] powerpc/crypto: Add gitignore for generated P10 AES/GCM .S files

2023-07-20 Thread Michael Ellerman
On Thu, 13 Jul 2023 14:21:45 +1000, Russell Currey wrote: > aesp10-ppc.S and ghashp10-ppc.S are autogenerated and not tracked by > git, so they should be ignored. This is doing the same as the P8 files > in drivers/crypto/vmx/.gitignore but for the P10 files in > arch/powerpc/crypto. > >

Re: (subset) [PATCH v4 00/15] powerpc/objtool: uaccess validation for PPC32 (v4)

2023-07-20 Thread Michael Ellerman
On Tue, 11 Jul 2023 18:08:26 +0200, Christophe Leroy wrote: > This series adds UACCESS validation for PPC32. It includes > a dozen of changes to objtool core. > > It applies on top of series "Cleanup/Optimise KUAP (v3)" > https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=363368=* >

Re: [PATCH] Revert "powerpc/64s: Remove support for ELFv1 little endian userspace"

2023-07-20 Thread Michael Ellerman
On Wed, 19 Jul 2023 17:18:21 +1000, Andrew Donnellan wrote: > This reverts commit 606787fed7268feb256957872586370b56af697a. > > ELFv1 with LE has never been a thing, and people who try to make ELFv1 LE > binaries are maniacs who need to be stopped, but unfortunately there are > ELFv1 LE binaries

Re: [PATCH v5] Revert "powerpc/bug: Provide better flexibility to WARN_ON/__WARN_FLAGS() with asm goto"

2023-07-20 Thread Michael Ellerman
On Wed, 12 Jul 2023 23:45:02 +1000, Michael Ellerman wrote: > This partly reverts commit 1e688dd2a3d6759d416616ff07afc4bb836c4213. > > That commit aimed at optimising the code around generation of > WARN_ON/BUG_ON but this leads to a lot of dead code erroneously > generated by GCC. > > That dead

Re: [PATCH v2] powerpc/pseries/vas: Hold mmap_mutex after mmap lock during window close

2023-07-20 Thread Michael Ellerman
On Sun, 16 Jul 2023 03:05:06 -0700, Haren Myneni wrote: > Commit 8ef7b9e1765a ("powerpc/pseries/vas: Close windows with DLPAR > core removal") unmaps the window paste address and issues HCALL to > close window in the hypervisor for migration or DLPAR core removal > events. So holds mmap_mutex and

Re: [PATCH] powerpc/kasan: Disable KCOV in KASAN code

2023-07-20 Thread Michael Ellerman
On Mon, 10 Jul 2023 14:41:43 +1000, Benjamin Gray wrote: > As per the generic KASAN code in mm/kasan, disable KCOV with > KCOV_INSTRUMENT := n in the makefile. > > This fixes a ppc64 boot hang when KCOV and KASAN are enabled. > kasan_early_init() gets called before a PACA is initialised, but the

[PATCH] floppy: ERROR: that open brace { should be on the previous line

2023-07-20 Thread zhangyongle001
Fix twoce occurrences of the checkpatch.pl error: ERROR: that open brace { should be on the previous line Signed-off-by: zhangyongle --- arch/powerpc/include/asm/floppy.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/include/asm/floppy.h

Re: [PATCH 00/13] mm: jit/text allocator

2023-07-20 Thread Mike Rapoport
On Mon, Jun 05, 2023 at 11:09:34AM +0100, Mark Rutland wrote: > On Mon, Jun 05, 2023 at 12:20:40PM +0300, Mike Rapoport wrote: > > On Fri, Jun 02, 2023 at 10:35:09AM +0100, Mark Rutland wrote: > > > On Thu, Jun 01, 2023 at 02:14:56PM -0400, Kent Overstreet wrote: > > > > On Thu, Jun 01, 2023 at

[PATCH v3 5/5] mmu_notifiers: Rename invalidate_range notifier

2023-07-20 Thread Alistair Popple
There are two main use cases for mmu notifiers. One is by KVM which uses mmu_notifier_invalidate_range_start()/end() to manage a software TLB. The other is to manage hardware TLBs which need to use the invalidate_range() callback because HW can establish new TLB entries at any time. Hence using

[PATCH v3 4/5] mmu_notifiers: Don't invalidate secondary TLBs as part of mmu_notifier_invalidate_range_end()

2023-07-20 Thread Alistair Popple
Secondary TLBs are now invalidated from the architecture specific TLB invalidation functions. Therefore there is no need to explicitly notify or invalidate as part of the range end functions. This means we can remove mmu_notifier_invalidate_range_end_only() and some of the ptep_*_notify()

[PATCH v3 3/5] mmu_notifiers: Call invalidate_range() when invalidating TLBs

2023-07-20 Thread Alistair Popple
The invalidate_range() is going to become an architecture specific mmu notifier used to keep the TLB of secondary MMUs such as an IOMMU in sync with the CPU page tables. Currently it is called from separate code paths to the main CPU TLB invalidations. This can lead to a secondary TLB not getting

[PATCH v3 2/5] mmu_notifiers: Fixup comment in mmu_interval_read_begin()

2023-07-20 Thread Alistair Popple
The comment in mmu_interval_read_begin() refers to a function that doesn't exist and uses the wrong call-back name. The op for mmu interval notifiers is mmu_interval_notifier_ops->invalidate() so fix the comment up to reflect that. Signed-off-by: Alistair Popple --- mm/mmu_notifier.c | 4 ++--

[PATCH v3 0/5] Invalidate secondary IOMMU TLB on permission upgrade

2023-07-20 Thread Alistair Popple
The main change is to move secondary TLB invalidation mmu notifier callbacks into the architecture specific TLB flushing functions. This makes secondary TLB invalidation mostly match CPU invalidation while still allowing efficient range based invalidations based on the existing TLB batching code.

[PATCH v3 1/5] arm64/smmu: Use TLBI ASID when invalidating entire range

2023-07-20 Thread Alistair Popple
The ARM SMMU has a specific command for invalidating the TLB for an entire ASID. Currently this is used for the IO_PGTABLE API but not for ATS when called from the MMU notifier. The current implementation of notifiers does not attempt to invalidate such a large address range, instead walking each

Re: Kernel Crash Dump (kdump) broken with 6.5

2023-07-20 Thread Sachin Sant
> On 19-Jul-2023, at 11:33 PM, Mahesh J Salgaonkar wrote: > > On 2023-07-18 23:19:23 Tue, Michael Ellerman wrote: >> Mahesh J Salgaonkar writes: >>> On 2023-07-17 20:15:53 Mon, Sachin Sant wrote: Kdump seems to be broken with 6.5 for ppc64le. [ 14.200412] systemd[1]: Starting

Re: [RFC PATCH v11 08/29] KVM: Introduce per-page memory attributes

2023-07-20 Thread Yuan Yao
On Tue, Jul 18, 2023 at 04:44:51PM -0700, Sean Christopherson wrote: > From: Chao Peng > > In confidential computing usages, whether a page is private or shared is > necessary information for KVM to perform operations like page fault > handling, page zapping etc. There are other potential use

[PATCH] mm: book3s32: add require space around that '?' and ':'

2023-07-20 Thread hanyu001
Fix below checkpatch errors: ./arch/powerpc/mm/book3s32/tlb.c:102: ERROR: spaces required around that '?' (ctx:VxW) ./arch/powerpc/mm/book3s32/tlb.c:102: ERROR: spaces required around that ':' (ctx:VxW) Signed-off-by: Yu Han --- arch/powerpc/mm/book3s32/tlb.c | 2 +- 1 file changed, 1

[PATCH] embedded6xx: holly: use seq_puts instead of seq_printf

2023-07-20 Thread hanyu001
Fix checkpatch WARNINGS: /platforms/embedded6xx/holly.c:199: WARNING: Prefer seq_puts to seq_printf /platforms/embedded6xx/holly.c:200: WARNING: Prefer seq_puts to seq_printf Signed-off-by: Yu Han --- arch/powerpc/platforms/embedded6xx/holly.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH] powernv: vas-trace: remove space after '('

2023-07-20 Thread hanyu001
Fix below checkpatch errors: /platforms/powernv/vas-trace.h:ERROR:space prohibited after that open parenthesis '(' /platforms/powernv/vas-trace.h:ERROR:space prohibited after that open parenthesis '(' /platforms/powernv/vas-trace.h:ERROR:space prohibited after that open parenthesis '('