Re: [PATCH v4 2/5] fs: Add fchmodat2()

2023-07-28 Thread dal...@libc.org
On Fri, Jul 28, 2023 at 08:43:58AM +, David Laight wrote: > > > FWIW, I agree with Christian that these behaviours are not ideal (and > > I'm working on a series that might allow for these things to be properly > > blocked in the future) but there's also the consistency argument -- I > >

Re: [RFC PATCH v11 06/29] KVM: Introduce KVM_SET_USER_MEMORY_REGION2

2023-07-28 Thread Sean Christopherson
On Fri, Jul 28, 2023, Quentin Perret wrote: > On Tuesday 18 Jul 2023 at 16:44:49 (-0700), Sean Christopherson wrote: > > --- a/include/uapi/linux/kvm.h > > +++ b/include/uapi/linux/kvm.h > > @@ -95,6 +95,16 @@ struct kvm_userspace_memory_region { > > __u64 userspace_addr; /* start of the

Re: [PATCH v3 1/2] powerpc/mm: Cleanup memory block size probing

2023-07-28 Thread Reza Arbab
On Fri, Jul 28, 2023 at 04:05:55PM +0530, Aneesh Kumar K.V wrote: --- a/arch/powerpc/mm/init_64.c +++ b/arch/powerpc/mm/init_64.c [snip] + /* +* "ibm,coherent-device-memory with linux,usable-memory = 0 +* Force 256MiB block size. Work around for GPUs on P9 PowerNV +

Re: [PATCH V2 00/26] tools/perf: Fix shellcheck coding/formatting issues of perf tool shell scripts

2023-07-28 Thread Arnaldo Carvalho de Melo
Em Tue, Jul 25, 2023 at 11:20:37AM +0530, Athira Rajeev escreveu: > > > > On 20-Jul-2023, at 10:48 AM, kajoljain wrote: > > > > > > > > On 7/20/23 10:42, Athira Rajeev wrote: > >> > >> > >>> On 19-Jul-2023, at 11:16 PM, Ian Rogers wrote: > >>> > >>> On Tue, Jul 18, 2023 at 11:17 PM

Re: [PATCH 1/1] perf tests task_analyzer: Check perf build options for libtraceevent support

2023-07-28 Thread Arnaldo Carvalho de Melo
Em Fri, Jul 28, 2023 at 09:01:11AM -0700, Ian Rogers escreveu: > On Fri, Jul 28, 2023 at 7:54 AM Arnaldo Carvalho de Melo > wrote: > > > > Em Tue, Jul 25, 2023 at 11:46:49AM +0530, Aditya Gupta escreveu: > > > Currently we depend on output of 'perf record -e "sched:sched_switch"', to > > > check

[linux-next:master] BUILD REGRESSION d7b3af5a77e8d8da28f435f313e069aea5bcf172

2023-07-28 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: d7b3af5a77e8d8da28f435f313e069aea5bcf172 Add linux-next specific files for 20230728 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202307080722.psque5e5-...@intel.com https

Re: [PATCH] ASoC: fsl_micfil: refactor deprecated strncpy

2023-07-28 Thread Mark Brown
On Thu, 27 Jul 2023 22:26:41 +, Justin Stitt wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings [1]. > > A suitable replacement is `strscpy` [2] due to the fact that it > guarantees NUL-termination on its destination buffer argument which is > _not_ always the case

Re: [RFC PATCH v11 10/29] mm: Add AS_UNMOVABLE to mark mapping as completely unmovable

2023-07-28 Thread Paolo Bonzini
On 7/28/23 18:02, Vlastimil Babka wrote: There's even a comment to that effect later on in the function: Hmm, well spotted. But it wouldn't be so great if we now had to lock every inspected page (and not just dirty pages), just to check the AS_ bit. But I wonder if this is leftover from

Re: [RFC PATCH v11 10/29] mm: Add AS_UNMOVABLE to mark mapping as completely unmovable

2023-07-28 Thread Vlastimil Babka
On 7/25/23 14:51, Matthew Wilcox wrote: > On Tue, Jul 25, 2023 at 01:24:03PM +0300, Kirill A . Shutemov wrote: >> On Tue, Jul 18, 2023 at 04:44:53PM -0700, Sean Christopherson wrote: >> > diff --git a/mm/compaction.c b/mm/compaction.c >> > index dbc9f86b1934..a3d2b132df52 100644 >> > ---

Re: [PATCH 1/1] perf tests task_analyzer: Check perf build options for libtraceevent support

2023-07-28 Thread Ian Rogers
On Fri, Jul 28, 2023 at 7:54 AM Arnaldo Carvalho de Melo wrote: > > Em Tue, Jul 25, 2023 at 11:46:49AM +0530, Aditya Gupta escreveu: > > Currently we depend on output of 'perf record -e "sched:sched_switch"', to > > check whether perf was built with libtraceevent support. > > > > Instead, a more

Re: [RFC PATCH v2 4/7] media: v4l2: Add audio capture and output support

2023-07-28 Thread Mark Brown
On Fri, Jul 28, 2023 at 07:59:33AM +, Tomasz Figa wrote: > On Tue, Jul 25, 2023 at 02:12:17PM +0800, Shengjiu Wang wrote: > > + case VFL_TYPE_AUDIO: > > + name_base = "audio"; > I think it was mentioned before that "audio" could be confusing. Wasn't > there actually some other

Re: Login broken with old userspace (was Re: [PATCH v2] selinux: introduce an initial SID for early boot processes)

2023-07-28 Thread Paul Moore
On Fri, Jul 28, 2023 at 9:24 AM Christian Göttsche wrote: > > On Fri, 28 Jul 2023 at 15:14, Ondrej Mosnacek wrote: > > > > On Fri, Jul 28, 2023 at 1:52 PM Stephen Smalley > > wrote: > > > > > > On Fri, Jul 28, 2023 at 7:36 AM Ondrej Mosnacek > > > wrote: > > > > > > > > On Fri, Jul 28, 2023

Re: [PATCH 1/1] perf tests task_analyzer: Check perf build options for libtraceevent support

2023-07-28 Thread Arnaldo Carvalho de Melo
Em Tue, Jul 25, 2023 at 11:46:49AM +0530, Aditya Gupta escreveu: > Currently we depend on output of 'perf record -e "sched:sched_switch"', to > check whether perf was built with libtraceevent support. > > Instead, a more straightforward approach can be to check the build options, > using 'perf

Re: [PATCH v4 00/10] Introduce SMT level and add PowerPC support

2023-07-28 Thread Thomas Gleixner
On Fri, Jul 28 2023 at 14:23, Rui Zhang wrote: > On Fri, 2023-07-28 at 09:40 +0200, Thomas Gleixner wrote: >> On Sun, Jul 09 2023 at 15:25, Rui Zhang wrote: >> > I ran into a boot hang regression with latest upstream code, and it >> > took me a while to bisect the offending commit and workaround

Re: [PATCH v4 00/10] Introduce SMT level and add PowerPC support

2023-07-28 Thread Zhang, Rui
Hi, Thomas, On Fri, 2023-07-28 at 09:40 +0200, Thomas Gleixner wrote: > Rui! > > On Sun, Jul 09 2023 at 15:25, Rui Zhang wrote: > > I ran into a boot hang regression with latest upstream code, and it > > took me a while to bisect the offending commit and workaround it. > > Where is the bug

[PATCH v3] hwrng: Explicitly include correct DT includes

2023-07-28 Thread Rob Herring
The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it was merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result,

Re: Login broken with old userspace (was Re: [PATCH v2] selinux: introduce an initial SID for early boot processes)

2023-07-28 Thread Christian Göttsche
On Fri, 28 Jul 2023 at 15:14, Ondrej Mosnacek wrote: > > On Fri, Jul 28, 2023 at 1:52 PM Stephen Smalley > wrote: > > > > On Fri, Jul 28, 2023 at 7:36 AM Ondrej Mosnacek wrote: > > > > > > On Fri, Jul 28, 2023 at 4:12 AM Michael Ellerman > > > wrote: > > > > > > > > Ondrej Mosnacek writes: >

Re: Login broken with old userspace (was Re: [PATCH v2] selinux: introduce an initial SID for early boot processes)

2023-07-28 Thread Ondrej Mosnacek
On Fri, Jul 28, 2023 at 1:52 PM Stephen Smalley wrote: > > On Fri, Jul 28, 2023 at 7:36 AM Ondrej Mosnacek wrote: > > > > On Fri, Jul 28, 2023 at 4:12 AM Michael Ellerman > > wrote: > > > > > > Ondrej Mosnacek writes: > > > > Currently, SELinux doesn't allow distinguishing between kernel

Re: Login broken with old userspace (was Re: [PATCH v2] selinux: introduce an initial SID for early boot processes)

2023-07-28 Thread Stephen Smalley
On Fri, Jul 28, 2023 at 7:36 AM Ondrej Mosnacek wrote: > > On Fri, Jul 28, 2023 at 4:12 AM Michael Ellerman wrote: > > > > Ondrej Mosnacek writes: > > > Currently, SELinux doesn't allow distinguishing between kernel threads > > > and userspace processes that are started before the policy is

RE: [PATCH v4 2/5] fs: Add fchmodat2()

2023-07-28 Thread David Laight
... > FWIW, I agree with Christian that these behaviours are not ideal (and > I'm working on a series that might allow for these things to be properly > blocked in the future) but there's also the consistency argument -- I > don't think fchownat() is much safer to allow in this way than >

Re: [PATCH] ASoC: fsl_micfil: refactor deprecated strncpy

2023-07-28 Thread Shengjiu Wang
On Fri, Jul 28, 2023 at 6:26 AM Justin Stitt wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings [1]. > > A suitable replacement is `strscpy` [2] due to the fact that it > guarantees NUL-termination on its destination buffer argument which is > _not_ always the case

Re: [PATCH 2/3] ASoC: fsl_micfil: Add fsl_micfil_check_version function

2023-07-28 Thread Shengjiu Wang
On Thu, Jul 27, 2023 at 11:15 AM Chancel Liu wrote: > fsl_micfil_check_version can help to parse the version info in VERID > and PARAM registers. Since the two registers are added only on i.MX93 > platform, a member flag called check_version is introduced to soc data > structure which indicates

Re: [PATCH v2 1/1] ASoC: imx-audmux: fix return value checks of clk_prepare_enable()

2023-07-28 Thread Shengjiu Wang
On Sat, Jul 22, 2023 at 8:38 PM Yuanjun Gong wrote: > check the return value of clk_prepare_enable(), and if > clk_prepare_enable() gets an unexpected return value, > imx_audmux_suspend() and imx_audmux_resume() should return > the error value. > > please use the ./scripts/get_maintainer.pl to

Re: Login broken with old userspace (was Re: [PATCH v2] selinux: introduce an initial SID for early boot processes)

2023-07-28 Thread Ondrej Mosnacek
On Fri, Jul 28, 2023 at 4:12 AM Michael Ellerman wrote: > > Ondrej Mosnacek writes: > > Currently, SELinux doesn't allow distinguishing between kernel threads > > and userspace processes that are started before the policy is first > > loaded - both get the label corresponding to the kernel SID.

[PATCH v3 2/2] powerpc/mm: Add memory_block_size as a kernel parameter

2023-07-28 Thread Aneesh Kumar K.V
Certain devices can possess non-standard memory capacities, not constrained to multiples of 1GB. Provide a kernel parameter so that we can map the device memory completely on memory hotplug. Restrict memory_block_size value to a power of 2 value similar to LMB size. The memory block size should

Re: [PATCH] powerpc: Use shared font data

2023-07-28 Thread Dr. David Alan Gilbert
* Michael Ellerman (m...@ellerman.id.au) wrote: > li...@treblig.org writes: > > From: "Dr. David Alan Gilbert" > > > > PowerPC has a 'btext' font used for the console which is almost identical > > to the shared font_sun8x16, so use it rather than duplicating the data. > > > > They were actually

[PATCH v3 1/2] powerpc/mm: Cleanup memory block size probing

2023-07-28 Thread Aneesh Kumar K.V
Parse the device tree in early init to find the memory block size to be used by the kernel. Consolidate the memory block size device tree parsing to one helper and use that on both powernv and pseries. We still want to use machine-specific callback because on all machine types other than powernv

[PATCH v6 12/13 -fix] powerpc/book3s64/radix: Remove mmu_vmemmap_psize

2023-07-28 Thread Aneesh Kumar K.V
>From 2d37f0570983bfa710e73a6485e178658e8f4b38 Mon Sep 17 00:00:00 2001 From: "Aneesh Kumar K.V" Date: Fri, 28 Jul 2023 14:47:46 +0530 Subject: [PATCH] powerpc/mm: Fix kernel build error arch/powerpc/mm/init_64.c:201:15: error: no previous prototype for function '__vmemmap_populate'

[PATCH v6 10/13 -fix2] powerpc/book3s64/vmemmap: Switch radix to use a different vmemmap handling function

2023-07-28 Thread Aneesh Kumar K.V
>From a3f49a79ffa78a7de736af77e13fdbb272c9f221 Mon Sep 17 00:00:00 2001 From: "Aneesh Kumar K.V" Date: Fri, 28 Jul 2023 15:36:53 +0530 Subject: [PATCH] powerpc/mm: Fix kernel build error MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit CC

Re: [RFC PATCH 00/21] crypto: consolidate and clean up compression APIs

2023-07-28 Thread Herbert Xu
On Fri, Jul 28, 2023 at 12:03:23PM +0200, Ard Biesheuvel wrote: > > Fair enough. But my point remains: this requires a lot of boilerplate > on the part of the driver, and it would be better if we could do this > in the acomp generic layer. Absolutely. If the hardware can't support

Re: [RFC PATCH 00/21] crypto: consolidate and clean up compression APIs

2023-07-28 Thread Ard Biesheuvel
On Fri, 28 Jul 2023 at 11:59, Herbert Xu wrote: > > On Fri, Jul 28, 2023 at 11:57:42AM +0200, Ard Biesheuvel wrote: > > > > So will IPcomp be able to simply assign those pages to the SKB afterwards? > > Yes that is the idea. The network stack is very much in love with > SG lists :) > Fair

Re: [RFC PATCH 00/21] crypto: consolidate and clean up compression APIs

2023-07-28 Thread Herbert Xu
On Fri, Jul 28, 2023 at 11:57:42AM +0200, Ard Biesheuvel wrote: > > So will IPcomp be able to simply assign those pages to the SKB afterwards? Yes that is the idea. The network stack is very much in love with SG lists :) Thanks, -- Email: Herbert Xu Home Page:

Re: [RFC PATCH 00/21] crypto: consolidate and clean up compression APIs

2023-07-28 Thread Ard Biesheuvel
On Fri, 28 Jul 2023 at 11:56, Herbert Xu wrote: > > On Tue, Jul 18, 2023 at 02:58:26PM +0200, Ard Biesheuvel wrote: > > > > Patch #2 removes the support for on-the-fly allocation of destination > > buffers and scatterlists from the Intel QAT driver. This is never used, > > and not even

Re: [RFC PATCH 00/21] crypto: consolidate and clean up compression APIs

2023-07-28 Thread Herbert Xu
On Tue, Jul 18, 2023 at 02:58:26PM +0200, Ard Biesheuvel wrote: > > Patch #2 removes the support for on-the-fly allocation of destination > buffers and scatterlists from the Intel QAT driver. This is never used, > and not even implemented by all drivers (the HiSilicon ZIP driver does > not support

Re: [RFC PATCH v11 06/29] KVM: Introduce KVM_SET_USER_MEMORY_REGION2

2023-07-28 Thread Quentin Perret
On Tuesday 18 Jul 2023 at 16:44:49 (-0700), Sean Christopherson wrote: > --- a/include/uapi/linux/kvm.h > +++ b/include/uapi/linux/kvm.h > @@ -95,6 +95,16 @@ struct kvm_userspace_memory_region { > __u64 userspace_addr; /* start of the userspace allocated memory */ > }; > > +/* for

[PATCH 1/1] Remove CONFIG_NET_CLS_TCINDEX

2023-07-28 Thread Petr Vorel
CONFIG_NET_CLS_TCINDEX has been removed in 8c710f75256b in v6.3-rc1, remove it's definition from configs. Fixes: 8c710f75256b ("net/sched: Retire tcindex classifier") Signed-off-by: Petr Vorel --- arch/arm/configs/ixp4xx_defconfig | 1 - arch/mips/configs/gpr_defconfig | 1

Re: [RFC PATCH v2 4/7] media: v4l2: Add audio capture and output support

2023-07-28 Thread Tomasz Figa
Hi Shengjiu, On Tue, Jul 25, 2023 at 02:12:17PM +0800, Shengjiu Wang wrote: > Audio signal processing has the requirement for memory to > memory similar as Video. > > This patch is to add this support in v4l2 framework, defined > new buffer type V4L2_BUF_TYPE_AUDIO_CAPTURE and >

Re: [PATCH v4 00/10] Introduce SMT level and add PowerPC support

2023-07-28 Thread Thomas Gleixner
Laurent, Michael! On Wed, Jul 05 2023 at 16:51, Laurent Dufour wrote: > I'm taking over the series Michael sent previously [1] which is smartly > reviewing the initial series I sent [2]. This series is addressing the > comments sent by Thomas and me on the Michael's one. Thanks for getting this

Re: [PATCH v4 00/10] Introduce SMT level and add PowerPC support

2023-07-28 Thread Thomas Gleixner
Rui! On Sun, Jul 09 2023 at 15:25, Rui Zhang wrote: > I ran into a boot hang regression with latest upstream code, and it > took me a while to bisect the offending commit and workaround it. Where is the bug report and the analysis? And what's the workaround? Thanks, tglx