Re: [PATCH] macintosh/ams: linux/platform_device.h is needed

2023-08-29 Thread Christophe Leroy
Le 30/08/2023 à 00:58, Randy Dunlap a écrit : > ams.h uses struct platform_device, so the header should be used > to prevent build errors: > > drivers/macintosh/ams/ams-input.c: In function 'ams_input_enable': > drivers/macintosh/ams/ams-input.c:68:45: error: invalid use of undefined type >

[PATCH] powerpc/configs: Set more PPC debug configs

2023-08-29 Thread Benjamin Gray
Add more config options that wouldn't be done by the generic debug config in kernel/configs/debug.config CONFIG_JUMP_LABEL_FEATURE_CHECK_DEBUG Adds an initialized check on each (cpu|mmu)_has_feature() CONFIG_PPC_IRQ_SOFT_MASK_DEBUG Adds some extra checks around IRQ mask

Re: [PATCH] crypto: vmx: Improved AES/XTS performance of 6-way unrolling for ppc.

2023-08-29 Thread Michael Ellerman
Danny Tsen writes: > Improve AES/XTS performance of 6-way unrolling for PowerPC up > to 17% with tcrypt. This is done by using one instruction, > vpermxor, to replace xor and vsldoi. > > This patch has been tested with the kernel crypto module tcrypt.ko and > has passed the selftest. The patch

Re: [PATCH v2 08/92] fs: new helper: simple_rename_timestamp

2023-08-29 Thread Jeff Layton
On Wed, 2023-08-30 at 01:19 +0100, Al Viro wrote: > On Wed, Jul 05, 2023 at 02:58:11PM -0400, Jeff Layton wrote: > > > + * POSIX mandates that the old and new parent directories have their ctime > > and > > + * mtime updated, and that inodes of @old_dentry and @new_dentry (if any), > > have > >

Re: [PATCH v2 08/92] fs: new helper: simple_rename_timestamp

2023-08-29 Thread Al Viro
On Wed, Jul 05, 2023 at 02:58:11PM -0400, Jeff Layton wrote: > + * POSIX mandates that the old and new parent directories have their ctime > and > + * mtime updated, and that inodes of @old_dentry and @new_dentry (if any), > have > + * their ctime updated. APPLICATION USAGE Some

Re: [RFC PATCH v2 0/7] Add audio support in v4l2 framework

2023-08-29 Thread Shengjiu Wang
On Fri, Aug 25, 2023 at 10:15 PM Hans Verkuil wrote: > > On 25/08/2023 15:54, Takashi Iwai wrote: > > On Fri, 25 Aug 2023 05:46:43 +0200, > > Shengjiu Wang wrote: > >> > >> On Fri, Aug 25, 2023 at 4:21 AM Mark Brown wrote: > >>> > >>> On Thu, Aug 24, 2023 at 07:03:09PM +0200, Takashi Iwai wrote:

Re: Recent Power changes and stack_trace_save_tsk_reliable?

2023-08-29 Thread Michael Ellerman
Joe Lawrence writes: > Hi ppc-dev list, > > We noticed that our kpatch integration tests started failing on ppc64le > when targeting the upstream v6.4 kernel, and then confirmed that the > in-tree livepatching kselftests similarly fail, too. From the kselftest > results, it appears that

Re: linux-next: manual merge of the net-next tree with the powerpc tree

2023-08-29 Thread Stephen Rothwell
Hi all, On Fri, 18 Aug 2023 11:17:07 +1000 Stephen Rothwell wrote: > > Today's linux-next merge of the net-next tree got a conflict in: > > drivers/net/ethernet/freescale/fs_enet/fs_enet.h > > between commit: > > 60bc069c433f ("powerpc/include: Remove unneeded #include ") > > from the

[PATCH] macintosh/ams: linux/platform_device.h is needed

2023-08-29 Thread Randy Dunlap
ams.h uses struct platform_device, so the header should be used to prevent build errors: drivers/macintosh/ams/ams-input.c: In function 'ams_input_enable': drivers/macintosh/ams/ams-input.c:68:45: error: invalid use of undefined type 'struct platform_device' 68 | input->dev.parent =

Re: [PATCH v2 0/2] kbuild: Show Kconfig fragments in "help"

2023-08-29 Thread Nicolas Schier
On Tue, Aug 29, 2023 at 11:57:19PM +0900 Masahiro Yamada wrote: > On Tue, Aug 29, 2023 at 3:55 PM Nicolas Schier wrote: > > > > On Mon 28 Aug 2023 16:17:07 GMT, Michael Ellerman wrote: > > > Masahiro Yamada writes: > > > > On Sat, Aug 26, 2023 at 4:55 AM Kees Cook wrote: > > > >> > > > >> Hi, >

Re: [PATCH] perf test: Skip perf bench breakpoint run if no breakpoints available

2023-08-29 Thread Ian Rogers
On Wed, Aug 23, 2023 at 4:00 AM Naveen N Rao wrote: > > Hi Kajol, > > On Wed Aug 23, 2023 at 1:21 PM IST, Kajol Jain wrote: > > Based on commit 7d54a4acd8c1 ("perf test: Skip watchpoint > > tests if no watchpoints available"), hardware breakpoints > > are not available for power9 platform and

[PATCH] crypto: vmx: Improved AES/XTS performance of 6-way unrolling for ppc.

2023-08-29 Thread Danny Tsen
Improve AES/XTS performance of 6-way unrolling for PowerPC up to 17% with tcrypt. This is done by using one instruction, vpermxor, to replace xor and vsldoi. This patch has been tested with the kernel crypto module tcrypt.ko and has passed the selftest. The patch is also tested with

Recent Power changes and stack_trace_save_tsk_reliable?

2023-08-29 Thread Joe Lawrence
Hi ppc-dev list, We noticed that our kpatch integration tests started failing on ppc64le when targeting the upstream v6.4 kernel, and then confirmed that the in-tree livepatching kselftests similarly fail, too. From the kselftest results, it appears that livepatch transitions are no longer

Re: [PATCH v2 0/2] kbuild: Show Kconfig fragments in "help"

2023-08-29 Thread Masahiro Yamada
On Tue, Aug 29, 2023 at 3:55 PM Nicolas Schier wrote: > > On Mon 28 Aug 2023 16:17:07 GMT, Michael Ellerman wrote: > > Masahiro Yamada writes: > > > On Sat, Aug 26, 2023 at 4:55 AM Kees Cook wrote: > > >> > > >> Hi, > > >> > > >> This is my series to show *.config targets in the "help" target

Re: [PATCH] kbuild: single-quote the format string of printf

2023-08-29 Thread Nicolas Schier
On Tue 29 Aug 2023 20:35:31 GMT, Masahiro Yamada wrote: > Use single-quotes to avoid escape sequences (\\n). > > Signed-off-by: Masahiro Yamada > --- Is this really necessary? Testing w/ GNU Make 4.3, bash 5.2.15 or dash 0.5.12-6 and a stupid Makefile snippet I cannot see any difference

Re: crypto: powerpc/chacha20,poly1305-p10 - Add dependency on VSX

2023-08-29 Thread Michael Ellerman
Herbert Xu writes: > On Fri, Aug 25, 2023 at 07:44:32PM +0800, kernel test robot wrote: >> >> All errors (new ones prefixed by >>): >> >>In file included from arch/powerpc/crypto/poly1305-p10-glue.c:19: > > ... > >> ae3a197e3d0bfe3 David Howells2012-03-28 75 >> ae3a197e3d0bfe3 David

[PATCH] kbuild: single-quote the format string of printf

2023-08-29 Thread Masahiro Yamada
Use single-quotes to avoid escape sequences (\\n). Signed-off-by: Masahiro Yamada --- Makefile | 8 arch/powerpc/Makefile | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index 87a9eef3fb4b..d09600f7a036 100644 --- a/Makefile +++

Re: [RFC v2 1/2] powerpc/cpuidle: cpuidle wakeup latency based on IPI and timer events

2023-08-29 Thread Srikar Dronamraju
* Aboorva Devarajan [2023-08-28 11:45:29]: > From: Pratik R. Sampat > > Introduce a mechanism to fire directed IPIs from a source CPU to a > specified target CPU and measure the time incurred on waking up the > target CPU in response. > > Also, introduce a mechanism to queue a hrtimer on a

[PATCH] kbuild: dummy-tools: -mprofile-kernel is not limited to little endian

2023-08-29 Thread Michal Suchanek
Fixes: aec0ba7472a7 ("powerpc/64: Use -mprofile-kernel for big endian ELFv2 kernels") Signed-off-by: Michal Suchanek --- scripts/dummy-tools/gcc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/dummy-tools/gcc b/scripts/dummy-tools/gcc index 1db1889f6d81..ebb34d016e5f

Re: [PATCH 0/3] Fix preemption errors in watchpoints

2023-08-29 Thread Benjamin Gray
On 29/8/23 4:34 pm, Benjamin Gray wrote: When enabling debug config options relating to preemption, several bugs appear in the kernel log. With this series applied, the breakpoint code no longer prints bugs when running the powerpc/ptrace selftests. Benjamin Gray (3): powerpc/watchpoints:

[PATCH 3/3] powerpc/watchpoints: Annotate atomic context in more places

2023-08-29 Thread Benjamin Gray
It can be easy to miss that the notifier mechanism invokes the callbacks in an atomic context, so add some comments to that effect on the two handlers we register here. Signed-off-by: Benjamin Gray --- arch/powerpc/kernel/hw_breakpoint.c | 9 + 1 file changed, 9 insertions(+) diff

[PATCH 0/3] Fix preemption errors in watchpoints

2023-08-29 Thread Benjamin Gray
When enabling debug config options relating to preemption, several bugs appear in the kernel log. With this series applied, the breakpoint code no longer prints bugs when running the powerpc/ptrace selftests. Benjamin Gray (3): powerpc/watchpoints: Disable preemption in thread_change_pc()

[PATCH 2/3] powerpc/watchpoint: Disable pagefaults when getting user instruction

2023-08-29 Thread Benjamin Gray
This is called in an atomic context, so is not allowed to sleep if a user page needs to be faulted in and has nowhere it can be deferred to. The pagefault_disabled() function is documented as preventing user access methods from sleeping. In practice the page will be mapped in nearly always

[PATCH 1/3] powerpc/watchpoints: Disable preemption in thread_change_pc()

2023-08-29 Thread Benjamin Gray
thread_change_pc() uses CPU local data, so must be protected from swapping CPUs while it is reading the breakpoint struct. The error is more noticeable after 1e60f3564bad ("powerpc/watchpoints: Track perf single step directly on the breakpoint"), which added an unconditional __this_cpu_read()

Re: [PATCH v2 0/2] kbuild: Show Kconfig fragments in "help"

2023-08-29 Thread Nicolas Schier
On Mon 28 Aug 2023 16:17:07 GMT, Michael Ellerman wrote: > Masahiro Yamada writes: > > On Sat, Aug 26, 2023 at 4:55 AM Kees Cook wrote: > >> > >> Hi, > >> > >> This is my series to show *.config targets in the "help" target so these > >> various topics can be more easily discoverd. > >> > >> v2: