Re: [PATCH] KVM: PPC: Book3S HV: Fix L2 guest reboot failure due to empty 'arch_compat'

2024-01-23 Thread Aneesh Kumar K . V
Amit Machhiwal writes: > Currently, rebooting a pseries nested qemu-kvm guest (L2) results in > below error as L1 qemu sends PVR value 'arch_compat' == 0 via > ppc_set_compat ioctl. This triggers a condition failure in > kvmppc_set_arch_compat() resulting in an EINVAL. > > qemu-system-ppc64: Unab

Re: [PATCH v1 01/11] arm/pgtable: define PFN_PTE_SHIFT on arm and arm64

2024-01-23 Thread Aneesh Kumar K . V
David Hildenbrand writes: >>> If high bits are used for something else, then we might produce a garbage PTE on overflow, but that shouldn't really matter I concluded for folio_pte_batch() purposes, we'd not detect "belongs to this folio batch" either way. >>> >>> Exactly

Re: [PATCH v1 01/11] arm/pgtable: define PFN_PTE_SHIFT on arm and arm64

2024-01-23 Thread Aneesh Kumar K . V
David Hildenbrand writes: > On 23.01.24 12:38, Ryan Roberts wrote: >> On 23/01/2024 11:31, David Hildenbrand wrote: > >> If high bits are used for >> something else, then we might produce a garbage PTE on overflow, but that >> shouldn't really matter I concluded for folio_pte_batc

[PATCH linux-next v3 14/14] loongarch, crash: wrap crash dumping code into crash related ifdefs

2024-01-23 Thread Baoquan He
Now crash codes under kernel/ folder has been split out from kexec code, crash dumping can be separated from kexec reboot in config items on loongarch with some adjustments. Here use IS_ENABLED(CONFIG_CRASH_RESERVE) check to decide if compiling in the crashkernel reservation code. Signed-off-by:

[PATCH linux-next v3 13/14] arm, crash: wrap crash dumping code into crash related ifdefs

2024-01-23 Thread Baoquan He
Now crash codes under kernel/ folder has been split out from kexec code, crash dumping can be separated from kexec reboot in config items on arm with some adjustments. Here use CONFIG_CRASH_RESERVE ifdef to replace CONFIG_KEXEC ifdef. Signed-off-by: Baoquan He --- v2->v3: - Fix the lkp reported

[PATCH linux-next v3 12/14] riscv, crash: wrap crash dumping code into crash related ifdefs

2024-01-23 Thread Baoquan He
Now crash codes under kernel/ folder has been split out from kexec code, crash dumping can be separated from kexec reboot in config items on risc-v with some adjustments. Here wrap up crash dumping codes with CONFIG_CRASH_DUMP ifdeffery, and use IS_ENABLED(CONFIG_CRASH_RESERVE) check to decide if

[PATCH linux-next v3 11/14] mips, crash: wrap crash dumping code into crash related ifdefs

2024-01-23 Thread Baoquan He
Now crash codes under kernel/ folder has been split out from kexec code, crash dumping can be separated from kexec reboot in config items on mips with some adjustments. Here use IS_ENABLED(CONFIG_CRASH_RESERVE) check to decide if compiling in the crashkernel reservation code. Signed-off-by: Baoqu

[PATCH linux-next v3 10/14] sh, crash: wrap crash dumping code into crash related ifdefs

2024-01-23 Thread Baoquan He
Now crash codes under kernel/ folder has been split out from kexec code, crash dumping can be separated from kexec reboot in config items on SuperH with some adjustments. wrap up crash dumping codes with CONFIG_CRASH_DUMP ifdeffery, and use IS_ENABLED(CONFIG_CRASH_RESERVE) check to decide if compi

[PATCH linux-next v3 09/14] s390, crash: wrap crash dumping code into crash related ifdefs

2024-01-23 Thread Baoquan He
Now crash codes under kernel/ folder has been split out from kexec code, crash dumping can be separated from kexec reboot in config items on s390 with some adjustments. Here wrap up crash dumping codes with CONFIG_CRASH_DUMP ifdeffery. Signed-off-by: Baoquan He --- arch/s390/kernel/kexec_elf.c

[PATCH linux-next v3 08/14] ppc, crash: enforce KEXEC and KEXEC_FILE to select CRASH_DUMP

2024-01-23 Thread Baoquan He
In PowerPC, the crash dumping and kexec reboot share code in arch_kexec_locate_mem_hole(), in which struct crash_mem is used. Here enfoce enforce KEXEC and KEXEC_FILE to select CRASH_DUMP for now. Signed-off-by: Baoquan He --- arch/powerpc/Kconfig | 5 + 1 file changed, 5 insertions(+) dif

[PATCH linux-next v3 07/14] arm64, crash: wrap crash dumping code into crash related ifdefs

2024-01-23 Thread Baoquan He
Now crash codes under kernel/ folder has been split out from kexec code, crash dumping can be separated from kexec reboot in config items on arm64 with some adjustments. Here wrap up crash dumping codes with CONFIG_CRASH_DUMP ifdeffery. Signed-off-by: Baoquan He --- arch/arm64/include/asm/kexec

[PATCH linux-next v3 06/14] x86, crash: wrap crash dumping code into crash related ifdefs

2024-01-23 Thread Baoquan He
Now crash codes under kernel/ folder has been split out from kexec code, crash dumping can be separated from kexec reboot in config items on x86 with some adjustments. Here, also change some ifdefs or IS_ENABLED() check to more appropriate ones, e,g - #ifdef CONFIG_KEXEC_CORE -> #ifdef CONFIG_CRA

[PATCH linux-next v3 05/14] crash: clean up kdump related config items

2024-01-23 Thread Baoquan He
By splitting CRASH_RESERVE and VMCORE_INFO out from CRASH_CORE, cleaning up the dependency of FA_DMUMP on CRASH_DUMP, and moving crash codes from kexec_core.c to crash_core.c, now we can rearrange CRASH_DUMP to depend on KEXEC_CORE, and make CRASH_DUMP select CRASH_RESERVE and VMCORE_INFO. KEXEC_C

[PATCH linux-next v3 04/14] crash: split crash dumping code out from kexec_core.c

2024-01-23 Thread Baoquan He
Currently, KEXEC_CORE select CRASH_CORE automatically because crash codes need be built in to avoid compiling error when building kexec code even though the crash dumping functionality is not enabled. E.g CONFIG_CRASH_CORE=y CONFIG_KEXEC_CORE=y CONFIG_KEXEC=y CONFIG_KEXEC_FILE=

[PATCH linux-next v3 03/14] crash: remove dependency of FA_DUMP on CRASH_DUMP

2024-01-23 Thread Baoquan He
In kdump kernel, /proc/vmcore is an elf file mapping the crashed kernel's old memory content. Its elf header is constructed in 1st kernel and passed to kdump kernel via elfcorehdr_addr. Config CRASH_DUMP enables the code of 1st kernel's old memory accessing in different architectures. Currently, c

[PATCH linux-next v3 02/14] crash: split vmcoreinfo exporting code out from crash_core.c

2024-01-23 Thread Baoquan He
Now move the relevant codes into separate files: kernel/crash_reserve.c, include/linux/crash_reserve.h. And add config item CRASH_RESERVE to control its enabling. And also update the old ifdeffery of CONFIG_CRASH_CORE, including of and config item dependency on CRASH_CORE accordingly. And also

[PATCH linux-next v3 01/14] kexec: split crashkernel reservation code out from crash_core.c

2024-01-23 Thread Baoquan He
Both kdump and fa_dump of ppc rely on crashkernel reservation. Move the relevant codes into separate files: crash_reserve.c, include/linux/crash_reserve.h. And also add config item CRASH_RESERVE to control its enabling of the codes. And update config items which has relationship with crashkernel r

[PATCH linux-next v3 00/14] Split crash out from kexec and clean up related config items

2024-01-23 Thread Baoquan He
Motivation: = Previously, LKP reported a building error. When investigating, it can't be resolved reasonablly with the present messy kdump config items. https://lore.kernel.org/oe-kbuild-all/202312182200.ka7mzifq-...@intel.com/ The kdump (crash dumping) related config items could cau

[PATCH 2/2] powerpc/perf: Power11 Performance Monitoring support

2024-01-23 Thread Madhavan Srinivasan
Base enablement patch to register performance monitoring hardware support for Power11. Patch introduce the raw event encoding format, defines the supported list of events, config fields for the event attributes and their corresponding bit values which are exported via sysfs. Signed-off-by: Madhava

[PATCH 1/2] powerpc: Add Power11 architected and raw mode

2024-01-23 Thread Madhavan Srinivasan
reg.h is updated with Power11 pvr. pvr_mask value of 0x0F07 means we are arch v3.1 compliant. This is used by phyp and kvm when booting as a pseries guest to detect and enable the appropriate hwcap, facility bits and PMU related fields. Copied fields from Power10 table entry and added relevant

Re: [PATCH v4 2/2] soc: fsl: qbman: Use raw spinlock for cgr_lock

2024-01-23 Thread Sean Anderson
On 1/8/24 11:19, Sean Anderson wrote: > cgr_lock may be locked with interrupts already disabled by > smp_call_function_single. As such, we must use a raw spinlock to avoid > problems on PREEMPT_RT kernels. Although this bug has existed for a > while, it was not apparent until commit ef2a8d5478b9 ("

Re: [PATCH v1 00/11] mm/memory: optimize fork() with PTE-mapped THP

2024-01-23 Thread Ryan Roberts
On 23/01/2024 20:14, David Hildenbrand wrote: > On 23.01.24 20:43, Ryan Roberts wrote: >> On 23/01/2024 19:33, David Hildenbrand wrote: >>> On 23.01.24 20:15, Ryan Roberts wrote: On 22/01/2024 19:41, David Hildenbrand wrote: > Now that the rmap overhaul[1] is upstream that provides a clean

Re: [PATCH v1 00/11] mm/memory: optimize fork() with PTE-mapped THP

2024-01-23 Thread David Hildenbrand
On 23.01.24 20:43, Ryan Roberts wrote: On 23/01/2024 19:33, David Hildenbrand wrote: On 23.01.24 20:15, Ryan Roberts wrote: On 22/01/2024 19:41, David Hildenbrand wrote: Now that the rmap overhaul[1] is upstream that provides a clean interface for rmap batching, let's implement PTE batching du

Re: [PATCH v1 00/11] mm/memory: optimize fork() with PTE-mapped THP

2024-01-23 Thread Ryan Roberts
On 23/01/2024 19:33, David Hildenbrand wrote: > On 23.01.24 20:15, Ryan Roberts wrote: >> On 22/01/2024 19:41, David Hildenbrand wrote: >>> Now that the rmap overhaul[1] is upstream that provides a clean interface >>> for rmap batching, let's implement PTE batching during fork when processing >>> P

Re: [PATCH v1 00/11] mm/memory: optimize fork() with PTE-mapped THP

2024-01-23 Thread David Hildenbrand
On 23.01.24 20:15, Ryan Roberts wrote: On 22/01/2024 19:41, David Hildenbrand wrote: Now that the rmap overhaul[1] is upstream that provides a clean interface for rmap batching, let's implement PTE batching during fork when processing PTE-mapped THPs. This series is partially based on Ryan's pr

Re: [PATCH v1 00/11] mm/memory: optimize fork() with PTE-mapped THP

2024-01-23 Thread Ryan Roberts
On 22/01/2024 19:41, David Hildenbrand wrote: > Now that the rmap overhaul[1] is upstream that provides a clean interface > for rmap batching, let's implement PTE batching during fork when processing > PTE-mapped THPs. > > This series is partially based on Ryan's previous work[2] to implement > co

[PATCH 4/4] net: wan: fsl_qmc_hdlc: Add framer support

2024-01-23 Thread Herve Codina
Add framer support in the fsl_qmc_hdlc driver in order to be able to signal carrier changes to the network stack based on the framer status Also use this framer to provide information related to the E1/T1 line interface on IF_GET_IFACE and configure the line interface according to IF_IFACE_{E1,T1}

[PATCH 1/4] net: wan: Add support for QMC HDLC

2024-01-23 Thread Herve Codina
The QMC HDLC driver provides support for HDLC using the QMC (QUICC Multichannel Controller) to transfer the HDLC data. Signed-off-by: Herve Codina Reviewed-by: Christophe Leroy Acked-by: Jakub Kicinski --- drivers/net/wan/Kconfig| 12 + drivers/net/wan/Makefile | 1 + drivers/

[PATCH 2/4] MAINTAINERS: Add the Freescale QMC HDLC driver entry

2024-01-23 Thread Herve Codina
After contributing the driver, add myself as the maintainer for the Freescale QMC HDLC driver. Signed-off-by: Herve Codina --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8d1052fa6a69..15cd3a8e5866 100644 --- a/MAINTAINERS +++ b/MAINTAIN

[PATCH 0/4] Add support for QMC HDLC

2024-01-23 Thread Herve Codina
Hi, This series introduces the QMC HDLC support. Patches were previously sent as part of a full feature series and were previously reviewed in that context: "Add support for QMC HDLC, framer infrastructure and PEF2256 framer" [1] In order to ease the merge, the full feature series has been split

[PATCH 3/4] net: wan: fsl_qmc_hdlc: Add runtime timeslots changes support

2024-01-23 Thread Herve Codina
QMC channels support runtime timeslots changes but nothing is done at the QMC HDLC driver to handle these changes. Use existing IFACE ioctl in order to configure the timeslots to use. Signed-off-by: Herve Codina Reviewed-by: Christophe Leroy Acked-by: Jakub Kicinski --- drivers/net/wan/fsl_qm

Re: [PATCH v1 01/11] arm/pgtable: define PFN_PTE_SHIFT on arm and arm64

2024-01-23 Thread Ryan Roberts
On 23/01/2024 15:01, Matthew Wilcox wrote: > On Tue, Jan 23, 2024 at 10:34:21AM +, Ryan Roberts wrote: >>> +#define PFN_PTE_SHIFT PAGE_SHIFT >> >> I think this is buggy. And so is the arm64 implementation of set_ptes(). It >> works fine for 48-bit output address, but for 52-bit OAs

Re: [PATCH v1 01/11] arm/pgtable: define PFN_PTE_SHIFT on arm and arm64

2024-01-23 Thread Matthew Wilcox
On Tue, Jan 23, 2024 at 10:34:21AM +, Ryan Roberts wrote: > > +#define PFN_PTE_SHIFT PAGE_SHIFT > > I think this is buggy. And so is the arm64 implementation of set_ptes(). It > works fine for 48-bit output address, but for 52-bit OAs, the high bits are > not > kept contigously,

Re: [PATCH v1 10/11] mm/memory: ignore dirty/accessed/soft-dirty bits in folio_pte_batch()

2024-01-23 Thread Ryan Roberts
On 23/01/2024 14:13, David Hildenbrand wrote: >>> Although now I'm wondering if there is a race here... What happens if a >>> page in >>> the parent becomes dirty after you have checked it but before you write >>> protect >>> it? Isn't that already a problem with the current non-batched version?

Re: Build regressions/improvements in v6.8-rc1

2024-01-23 Thread Arnd Bergmann
On Tue, Jan 23, 2024, at 12:45, Geert Uytterhoeven wrote: >> 68 error regressions: > >> + /kisskb/src/arch/powerpc/sysdev/udbg_memcons.c: error: no previous >> prototype for 'memcons_getc' [-Werror=missing-prototypes]: => 80:5 >> + /kisskb/src/arch/powerpc/sysdev/udbg_memcons.c: error: no prev

Re: [PATCH v1 10/11] mm/memory: ignore dirty/accessed/soft-dirty bits in folio_pte_batch()

2024-01-23 Thread David Hildenbrand
Although now I'm wondering if there is a race here... What happens if a page in the parent becomes dirty after you have checked it but before you write protect it? Isn't that already a problem with the current non-batched version? Why do we even to preserve dirty in the child for private mappings?

Re: [PATCH v1 10/11] mm/memory: ignore dirty/accessed/soft-dirty bits in folio_pte_batch()

2024-01-23 Thread David Hildenbrand
On 23.01.24 14:42, Ryan Roberts wrote: On 23/01/2024 13:06, David Hildenbrand wrote: On 23.01.24 13:25, Ryan Roberts wrote: On 22/01/2024 19:41, David Hildenbrand wrote: Let's ignore these bits: they are irrelevant for fork, and will likely be irrelevant for upcoming users such as page unmappi

Re: [PATCH v1 10/11] mm/memory: ignore dirty/accessed/soft-dirty bits in folio_pte_batch()

2024-01-23 Thread Ryan Roberts
On 23/01/2024 13:06, David Hildenbrand wrote: > On 23.01.24 13:25, Ryan Roberts wrote: >> On 22/01/2024 19:41, David Hildenbrand wrote: >>> Let's ignore these bits: they are irrelevant for fork, and will likely >>> be irrelevant for upcoming users such as page unmapping. >>> >>> Signed-off-by: Davi

Re: [PATCH v1 10/11] mm/memory: ignore dirty/accessed/soft-dirty bits in folio_pte_batch()

2024-01-23 Thread David Hildenbrand
On 23.01.24 13:25, Ryan Roberts wrote: On 22/01/2024 19:41, David Hildenbrand wrote: Let's ignore these bits: they are irrelevant for fork, and will likely be irrelevant for upcoming users such as page unmapping. Signed-off-by: David Hildenbrand --- mm/memory.c | 10 -- 1 file chang

[PATCH 2/2] powerpc: 85xx: mark local functions static

2024-01-23 Thread Arnd Bergmann
From: Arnd Bergmann These functions are either used in only one file and can just be makde static or need an #include statement to avoid a warning: arch/powerpc/platforms/85xx/mpc8536_ds.c:30:13: error: no previous prototype for 'mpc8536_ds_pic_init' [-Werror=missing-prototypes] arch/powerpc/pl

[PATCH 1/2] powerpc: udbg_memcons: mark functions static

2024-01-23 Thread Arnd Bergmann
From: Arnd Bergmann ppc64_book3e_allmodconfig has one more driver that triggeres a few missing-prototypes warnings: arch/powerpc/sysdev/udbg_memcons.c:44:6: error: no previous prototype for 'memcons_putc' [-Werror=missing-prototypes] arch/powerpc/sysdev/udbg_memcons.c:57:5: error: no previous p

Re: [PATCH v1 11/11] mm/memory: ignore writable bit in folio_pte_batch()

2024-01-23 Thread Ryan Roberts
On 22/01/2024 19:42, David Hildenbrand wrote: > ... and conditionally return to the caller if any pte except the first one > is writable. fork() has to make sure to properly write-protect in case any > PTE is writable. Other users (e.g., page unmaping) won't care. > > Signed-off-by: David Hildenbr

Re: [PATCH v1 09/11] mm/memory: optimize fork() with PTE-mapped THP

2024-01-23 Thread Ryan Roberts
On 23/01/2024 12:19, David Hildenbrand wrote: > [...] > >> >> I wrote some documentation for this (based on Matthew's docs for set_ptes() >> in >> my version. Perhaps it makes sense to add it here, given this is overridable >> by >> the arch. >> >> /** >>   * wrprotect_ptes - Write protect a con

Re: [PATCH v1 10/11] mm/memory: ignore dirty/accessed/soft-dirty bits in folio_pte_batch()

2024-01-23 Thread Ryan Roberts
On 22/01/2024 19:41, David Hildenbrand wrote: > Let's ignore these bits: they are irrelevant for fork, and will likely > be irrelevant for upcoming users such as page unmapping. > > Signed-off-by: David Hildenbrand > --- > mm/memory.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletio

Re: [PATCH v1 09/11] mm/memory: optimize fork() with PTE-mapped THP

2024-01-23 Thread David Hildenbrand
[...] I wrote some documentation for this (based on Matthew's docs for set_ptes() in my version. Perhaps it makes sense to add it here, given this is overridable by the arch. /** * wrprotect_ptes - Write protect a consecutive set of pages. * @mm: Address space that the pages are mapped int

Re: [PATCH] powerpc/6xx: set High BAT Enable flag on G2 cores

2024-01-23 Thread Matthias Schiffer
On Fri, 2024-01-19 at 13:53 +, Christophe Leroy wrote: > > Le 19/01/2024 à 14:41, Matthias Schiffer a écrit : > > > > > > Thinking about it once more, can we do even more simple ? > > > > > > Why do we need that __setup_cpu_g2() at all ? > > > > > > You could just add the following into __s

Re: [PATCH v1 09/11] mm/memory: optimize fork() with PTE-mapped THP

2024-01-23 Thread Ryan Roberts
On 22/01/2024 19:41, David Hildenbrand wrote: > Let's implement PTE batching when consecutive (present) PTEs map > consecutive pages of the same large folio, and all other PTE bits besides > the PFNs are equal. > > We will optimize folio_pte_batch() separately, to ignore some other > PTE bits. Thi

Re: [PATCH v1 01/11] arm/pgtable: define PFN_PTE_SHIFT on arm and arm64

2024-01-23 Thread David Hildenbrand
On 23.01.24 12:48, Christophe Leroy wrote: Le 23/01/2024 à 12:38, Ryan Roberts a écrit : On 23/01/2024 11:31, David Hildenbrand wrote: If high bits are used for something else, then we might produce a garbage PTE on overflow, but that shouldn't really matter I concluded for folio_pte_batch(

Re: [PATCH v1 01/11] arm/pgtable: define PFN_PTE_SHIFT on arm and arm64

2024-01-23 Thread Christophe Leroy
Le 23/01/2024 à 12:38, Ryan Roberts a écrit : > On 23/01/2024 11:31, David Hildenbrand wrote: > If high bits are used for > something else, then we might produce a garbage PTE on overflow, but that > shouldn't really matter I concluded for folio_pte_batch() purposes, we'd >

Re: Build regressions/improvements in v6.8-rc1

2024-01-23 Thread Geert Uytterhoeven
On Tue, 23 Jan 2024, Geert Uytterhoeven wrote: Below is the list of build error/warning regressions/improvements in v6.8-rc1[1] compared to v6.7[2]. Summarized: - build errors: +68/-18 - build warnings: +129/-1487 Happy fixing! ;-) Thanks to the linux-next team for providing the build servic

Re: [PATCH v1 01/11] arm/pgtable: define PFN_PTE_SHIFT on arm and arm64

2024-01-23 Thread Ryan Roberts
On 23/01/2024 11:33, David Hildenbrand wrote: > On 23.01.24 12:17, Ryan Roberts wrote: >> On 23/01/2024 11:02, David Hildenbrand wrote: >>> On 23.01.24 11:48, David Hildenbrand wrote: On 23.01.24 11:34, Ryan Roberts wrote: > On 22/01/2024 19:41, David Hildenbrand wrote: >> We want to m

Re: [PATCH v1 01/11] arm/pgtable: define PFN_PTE_SHIFT on arm and arm64

2024-01-23 Thread David Hildenbrand
On 23.01.24 12:38, Ryan Roberts wrote: On 23/01/2024 11:31, David Hildenbrand wrote: If high bits are used for something else, then we might produce a garbage PTE on overflow, but that shouldn't really matter I concluded for folio_pte_batch() purposes, we'd not detect "belongs to this folio ba

Re: [PATCH v1 01/11] arm/pgtable: define PFN_PTE_SHIFT on arm and arm64

2024-01-23 Thread Ryan Roberts
On 23/01/2024 11:31, David Hildenbrand wrote: >>> If high bits are used for something else, then we might produce a garbage PTE on overflow, but that shouldn't really matter I concluded for folio_pte_batch() purposes, we'd not detect "belongs to this folio batch" either wa

Re: [PATCH v1 01/11] arm/pgtable: define PFN_PTE_SHIFT on arm and arm64

2024-01-23 Thread David Hildenbrand
On 23.01.24 12:17, Ryan Roberts wrote: On 23/01/2024 11:02, David Hildenbrand wrote: On 23.01.24 11:48, David Hildenbrand wrote: On 23.01.24 11:34, Ryan Roberts wrote: On 22/01/2024 19:41, David Hildenbrand wrote: We want to make use of pte_next_pfn() outside of set_ptes(). Let's simpliy defi

Re: [PATCH v1 01/11] arm/pgtable: define PFN_PTE_SHIFT on arm and arm64

2024-01-23 Thread David Hildenbrand
If high bits are used for something else, then we might produce a garbage PTE on overflow, but that shouldn't really matter I concluded for folio_pte_batch() purposes, we'd not detect "belongs to this folio batch" either way. Exactly. Maybe it's likely cleaner to also have a custom pte_next

Re: [PATCH v1 01/11] arm/pgtable: define PFN_PTE_SHIFT on arm and arm64

2024-01-23 Thread Ryan Roberts
On 23/01/2024 11:02, David Hildenbrand wrote: > On 23.01.24 11:48, David Hildenbrand wrote: >> On 23.01.24 11:34, Ryan Roberts wrote: >>> On 22/01/2024 19:41, David Hildenbrand wrote: We want to make use of pte_next_pfn() outside of set_ptes(). Let's simpliy define PFN_PTE_SHIFT, required

Re: [PATCH v1 01/11] arm/pgtable: define PFN_PTE_SHIFT on arm and arm64

2024-01-23 Thread Christophe Leroy
Le 23/01/2024 à 12:08, Ryan Roberts a écrit : > On 23/01/2024 10:48, David Hildenbrand wrote: >> On 23.01.24 11:34, Ryan Roberts wrote: >>> On 22/01/2024 19:41, David Hildenbrand wrote: We want to make use of pte_next_pfn() outside of set_ptes(). Let's simpliy define PFN_PTE_SHIFT, requ

Re: [PATCH v1 01/11] arm/pgtable: define PFN_PTE_SHIFT on arm and arm64

2024-01-23 Thread Christophe Leroy
Le 23/01/2024 à 11:48, David Hildenbrand a écrit : > On 23.01.24 11:34, Ryan Roberts wrote: >> On 22/01/2024 19:41, David Hildenbrand wrote: >>> We want to make use of pte_next_pfn() outside of set_ptes(). Let's >>> simpliy define PFN_PTE_SHIFT, required by pte_next_pfn(). >>> >>> Signed-off-by:

Re: [PATCH v1 01/11] arm/pgtable: define PFN_PTE_SHIFT on arm and arm64

2024-01-23 Thread Ryan Roberts
On 23/01/2024 10:48, David Hildenbrand wrote: > On 23.01.24 11:34, Ryan Roberts wrote: >> On 22/01/2024 19:41, David Hildenbrand wrote: >>> We want to make use of pte_next_pfn() outside of set_ptes(). Let's >>> simpliy define PFN_PTE_SHIFT, required by pte_next_pfn(). >>> >>> Signed-off-by: David H

Re: [PATCH v1 01/11] arm/pgtable: define PFN_PTE_SHIFT on arm and arm64

2024-01-23 Thread David Hildenbrand
On 23.01.24 11:48, David Hildenbrand wrote: On 23.01.24 11:34, Ryan Roberts wrote: On 22/01/2024 19:41, David Hildenbrand wrote: We want to make use of pte_next_pfn() outside of set_ptes(). Let's simpliy define PFN_PTE_SHIFT, required by pte_next_pfn(). Signed-off-by: David Hildenbrand ---

Re: [PATCH v1 01/11] arm/pgtable: define PFN_PTE_SHIFT on arm and arm64

2024-01-23 Thread David Hildenbrand
On 23.01.24 11:34, Ryan Roberts wrote: On 22/01/2024 19:41, David Hildenbrand wrote: We want to make use of pte_next_pfn() outside of set_ptes(). Let's simpliy define PFN_PTE_SHIFT, required by pte_next_pfn(). Signed-off-by: David Hildenbrand --- arch/arm/include/asm/pgtable.h | 2 ++ arc

Re: [PATCH v1 08/11] mm/memory: pass PTE to copy_present_pte()

2024-01-23 Thread Ryan Roberts
On 22/01/2024 19:41, David Hildenbrand wrote: > We already read it, let's just forward it. > > This patch is based on work by Ryan Roberts. > > Signed-off-by: David Hildenbrand Reviewed-by: Ryan Roberts > --- > mm/memory.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > d

Re: [PATCH v1 07/11] mm/memory: factor out copying the actual PTE in copy_present_pte()

2024-01-23 Thread Ryan Roberts
On 22/01/2024 19:41, David Hildenbrand wrote: > Let's prepare for further changes. > > Signed-off-by: David Hildenbrand Reviewed-by: Ryan Roberts > --- > mm/memory.c | 60 - > 1 file changed, 32 insertions(+), 28 deletions(-) > > diff --git

Re: [PATCH v1 01/11] arm/pgtable: define PFN_PTE_SHIFT on arm and arm64

2024-01-23 Thread Ryan Roberts
On 22/01/2024 19:41, David Hildenbrand wrote: > We want to make use of pte_next_pfn() outside of set_ptes(). Let's > simpliy define PFN_PTE_SHIFT, required by pte_next_pfn(). > > Signed-off-by: David Hildenbrand > --- > arch/arm/include/asm/pgtable.h | 2 ++ > arch/arm64/include/asm/pgtable.h

Re: [PATCH v15 5/5] powerpc: add crash memory hotplug support

2024-01-23 Thread Hari Bathini
On 11/01/24 4:21 pm, Sourabh Jain wrote: Extend the arch crash hotplug handler, as introduced by the patch title ("powerpc: add crash CPU hotplug support"), to also support memory add/remove events. Elfcorehdr describes the memory of the crash kernel to capture the kernel; hence, it needs to

Re: [PATCH v15 4/5] powerpc: add crash CPU hotplug support

2024-01-23 Thread Hari Bathini
On 11/01/24 4:21 pm, Sourabh Jain wrote: Due to CPU/Memory hotplug or online/offline events, the elfcorehdr (which describes the CPUs and memory of the crashed kernel) and FDT (Flattened Device Tree) of kdump image becomes outdated. Consequently, attempting dump collection with an outdated elf

Re: [PATCH v7 1/3] powerpc: make fadump resilient with memory add/remove events

2024-01-23 Thread Hari Bathini
On 11/01/24 7:39 pm, Sourabh Jain wrote: Due to changes in memory resources caused by either memory hotplug or online/offline events, the elfcorehdr, which describes the CPUs and memory of the crashed kernel to the kernel that collects the dump (known as second/fadump kernel), becomes outdated

[PATCH] dt-bindings: soc: fsl: narrow regex for unit address to hex numbers

2024-01-23 Thread Krzysztof Kozlowski
Regular expression used to match the unit address part should not allow non-hex numbers. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/soc/fsl/fsl,layerscape-dcfg.yaml| 2 +- .../devicetree/bindings/soc/fsl/fsl,layerscape-scfg.yaml| 2 +- 2 files changed, 2 inser