Re: [PATCH 2/3] tools/erf/util/annotate: Set register_char and memory_ref_char for powerpc

2024-03-09 Thread Segher Boessenkool
All instructions with a primary opcode from 32 to 63 are memory insns, and no others. It's trivial to see whether it is a load or store, too (just bit 3 of the insn). Trying to parse disassembled code is much harder, and you easily make some mistakes here. On Sat, Mar 09, 2024 at 12:55:12PM

Re: [PATCH 01/19] vdso: Consolidate vdso_calc_delta()

2024-03-09 Thread John Stultz
On Fri, Mar 8, 2024 at 5:15 AM Adrian Hunter wrote: > > Consolidate vdso_calc_delta(), in preparation for further simplification. > > Suggested-by: Thomas Gleixner > Signed-off-by: Adrian Hunter > --- > arch/powerpc/include/asm/vdso/gettimeofday.h | 17 ++--- >

Re: [PATCH 3/3] tools/perf/arch/powerc: Add get_arch_regnum for powerpc

2024-03-09 Thread Christophe Leroy
Le 09/03/2024 à 08:25, Athira Rajeev a écrit : > The function get_dwarf_regnum() returns a DWARF register number > from a register name string. This calls arch specific function > get_arch_regnum to return register number for corresponding arch. > Add mappings for register name to register

Re: [PATCH 1/3] tools/perf/arch/powerpc: Add load/store in powerpc annotate instructions for data type profling

2024-03-09 Thread Christophe Leroy
Le 09/03/2024 à 08:25, Athira Rajeev a écrit : > Add powerpc instruction nmemonic table to associate load/store > instructions with move_ops. mov_ops is used to identify mem_type > to associate instruction with data type and offset. Also initialize > and allocate arch specific fields for