hack that should help. I've not tested this,
and it's not yet signed-off-by. Let me know if this helps.
From 16708fa247c0dd34aa55d78166d65e463f9be6d6 Mon Sep 17 00:00:00 2001
Message-Id:
16708fa247c0dd34aa55d78166d65e463f9be6d6.1324015123.git.amit.s...@redhat.com
From: Amit Shah amit.s
at linux-ppc can be of help.
On Thu, Dec 8, 2011 at 4:08 AM, Amit Shah amit.s...@redhat.com wrote:
On (Tue) 06 Dec 2011 [09:05:38], Miche Baker-Harvey wrote:
Amit,
Ah, indeed. I am not using MSI-X, so virtio_pci::vp_try_to_find_vqs()
calls vp_request_intx() and sets up an interrupt callback
On (Tue) 06 Dec 2011 [09:05:38], Miche Baker-Harvey wrote:
Amit,
Ah, indeed. I am not using MSI-X, so virtio_pci::vp_try_to_find_vqs()
calls vp_request_intx() and sets up an interrupt callback. From
there, when an interrupt occurs, the stack looks something like this:
On (Tue) 29 Nov 2011 [09:50:41], Miche Baker-Harvey wrote:
Good grief! Sorry for the spacing mess-up! Here's a resend with
reformatting.
Amit,
We aren't using either QEMU or kvmtool, but we are using KVM. All
So it's a different userspace? Any chance this different userspace is
causing
Hi,
On (Mon) 28 Nov 2011 [15:40:41], Miche Baker-Harvey wrote:
Amit,
You said that the work would be serialized due to port additions
being on work items on the same workqueue. I'm not seeing that.
You leave a lot of questions unanswered. What's your environment?
Are you hot-plugging
On (Thu) 17 Nov 2011 [10:57:37], Miche Baker-Harvey wrote:
Rusty, Michael, Stephen, et al,
Thanks for your comments on these patches.
For what I'm trying to do, all three patches are necessary, but maybe
I'm going about it the wrong way. Your input would be appreciated.
I'm in no way
On (Wed) 23 Nov 2011 [16:08:52], Amit Shah wrote:
With this setup, with and without patches, I can spawn two consoles
via:
/sbin/agetty /dev/hvc0 9600 vt100
/sbin/agetty /dev/hvc1 9600 vt100
(Strange thing is, the second one gives a 'password incorrect' error
on login attempts, while
On (Wed) 23 Nov 2011 [15:06:04], Sasha Levin wrote:
On Wed, 2011-11-23 at 18:26 +0530, Amit Shah wrote:
On (Wed) 23 Nov 2011 [16:08:52], Amit Shah wrote:
With this setup, with and without patches, I can spawn two consoles
via:
/sbin/agetty /dev/hvc0 9600 vt100
/sbin/agetty /dev
On (Fri) 11 Nov 2011 [14:57:20], Rusty Russell wrote:
On Tue, 08 Nov 2011 13:44:58 -0800, Miche Baker-Harvey mi...@google.com
wrote:
Some modifications of vtermno were not done under the spinlock.
Moved assignment from vtermno and increment of vtermno together,
putting both under the
On (Wed) 02 Nov 2011 [15:19:06], Miche Baker-Harvey wrote:
This patchset applies to linux-next/next-2002.
Did you forget to send out the patches? I don't see anything on any
of the lists nor my inbox.
Amit
___
Linuxppc-dev mailing
On (Wed) 27 Apr 2011 [14:31:29], Rusty Russell wrote:
On Wed, 20 Apr 2011 22:36:10 +0530, Amit Shah amit.s...@redhat.com wrote:
On (Wed) 20 Apr 2011 [07:34:35], Greg KH wrote:
Care to either create this patch, or resend your original one, if you
want it applied?
Rusty has the other
On (Wed) 27 Apr 2011 [17:09:34], Greg KH wrote:
On Wed, Apr 27, 2011 at 12:01:47PM +0530, Amit Shah wrote:
On (Wed) 27 Apr 2011 [14:31:29], Rusty Russell wrote:
On Wed, 20 Apr 2011 22:36:10 +0530, Amit Shah amit.s...@redhat.com
wrote:
On (Wed) 20 Apr 2011 [07:34:35], Greg KH wrote
On (Mon) 28 Mar 2011 [11:52:05], Milton Miller wrote:
On Fri, 25 Mar 2011 about 14:17:14 +0530, Amit Shah wrote:
On (Thu) 24 Mar 2011 [08:58:04], Milton Miller wrote:
On Thu, 24 Mar 2011 07:29:58 -, Amit Shah wrote:
hvc_open() can be called without having any backing device
On (Wed) 20 Apr 2011 [07:34:35], Greg KH wrote:
On Wed, Apr 20, 2011 at 06:03:30PM +0530, Amit Shah wrote:
On (Mon) 28 Mar 2011 [11:52:05], Milton Miller wrote:
On Fri, 25 Mar 2011 about 14:17:14 +0530, Amit Shah wrote:
On (Thu) 24 Mar 2011 [08:58:04], Milton Miller wrote:
On Thu
On (Thu) 24 Mar 2011 [08:58:04], Milton Miller wrote:
On Thu, 24 Mar 2011 07:29:58 -, Amit Shah wrote:
hvc_open() can be called without having any backing device. This
results in a call to hvc_kick() which calls wake_up_process on a NULL
pointer.
How is hvc_open called without
without having a
console backend.
CC: sta...@kernel.org
Signed-off-by: Amit Shah amit.s...@redhat.com
---
drivers/tty/hvc/hvc_console.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c
index e9cba13..b2cb5cc
On (Fri) Jun 11 2010 [09:13:49], John Kacur wrote:
I was just listing patches that Thomas could potentially include
in the real-time kernel which is currently based on 2.6.33.5
There's a fix to this patch: 320718ee074acce5ffced6506cb51af1388942aa
that you might want to include as well.
When using multiport, we'll use control messages. Ensure we don't
accidentally update port 0 size on config interrupts.
Signed-off-by: Amit Shah amit.s...@redhat.com
CC: Christian Borntraeger borntrae...@de.ibm.com
CC: linuxppc-...@ozlabs.org
CC: Kusanagi Kouichi sl...@ac.auone-net.jp
The VIRTIO_CONSOLE_RESIZE control message sent to us by the host now
contains the new {rows, cols} values for the console. This ensures each
console port gets its own size, and we don't depend on the config-space
rows and cols values at all now.
Signed-off-by: Amit Shah amit.s...@redhat.com
CC
is taken from that
of the last config-space update instead of fetching it afresh from the
config space.
Also add a helper to update the size in the console struct as we'll need
to use the same code to update the size via control messages when
multiport support is enabled.
Signed-off-by: Amit Shah
-by: Amit Shah amit.s...@redhat.com
The patch below changes things to call tty_kref_put once for every
hvc_close call, and with that my machine boots fine.
Signed-off-by: Anton Blanchard an...@samba.org
___
Linuxppc-dev mailing list
Linuxppc-dev
On (Fri) Mar 26 2010 [14:43:56], Sachin Sant wrote:
And this suggests that hvc_kick() is called before hvc_task is
initialised, ie, before hvc_init() is called.
Does this help?
Hi Amit,
I too ran into this issue as reported by Anton. Unfortunately in my
case the following suggested
On (Fri) Mar 26 2010 [17:12:22], Sachin Sant wrote:
Amit Shah wrote:
On (Fri) Mar 26 2010 [14:43:56], Sachin Sant wrote:
And this suggests that hvc_kick() is called before hvc_task is
initialised, ie, before hvc_init() is called.
Does this help?
Hi Amit,
I too ran
On (Fri) Mar 26 2010 [11:52:33], Alan Cox wrote:
mount: can't find /root/proc in /etc/fstab or /etc/mtab
/sbin/smart_agetty: can not determine 'console' speed
OK, this gets even murkier. I don't know why taking a few krefs modifies
hvc_console behaviour to such an extent.
On (Fri) Mar 26 2010 [10:30:31], Anton Blanchard wrote:
Hi,
And this suggests that hvc_kick() is called before hvc_task is
initialised, ie, before hvc_init() is called.
Does this help?
Looks good, tests OK on my POWER5 box. Thanks!
Tested-by: Anton Blanchard an...@samba.org
On (Wed) Mar 24 2010 [21:04:08], Amit Shah wrote:
Hello,
When multiple hvc console ports are initialised and used via the
virtio_console driver, I can interact with only the first console, the
2nd one doesn't respond.
If I call hvc_kick() even if hvc_poll() returns 0, the 2nd console
On (Wed) Mar 24 2010 [21:45:44], Benjamin Herrenschmidt wrote:
On Sun, 2010-03-21 at 08:04 +1100, Benjamin Herrenschmidt wrote:
On Fri, 2010-03-19 at 08:18 -0700, Greg Kroah-Hartman wrote:
From: Amit Shah amit.s...@redhat.com
Alan pointed out a race in the code where hvc_remove
On (Sun) Mar 21 2010 [10:07:25], Amit Shah wrote:
On (Sun) Mar 21 2010 [08:04:39], Benjamin Herrenschmidt wrote:
On Fri, 2010-03-19 at 08:18 -0700, Greg Kroah-Hartman wrote:
From: Amit Shah amit.s...@redhat.com
Alan pointed out a race in the code where hvc_remove is invoked
On (Wed) Mar 24 2010 [11:37:21], Alan Cox wrote:
On Sun, 21 Mar 2010 08:04:39 +1100
Benjamin Herrenschmidt b...@kernel.crashing.org wrote:
On Fri, 2010-03-19 at 08:18 -0700, Greg Kroah-Hartman wrote:
From: Amit Shah amit.s...@redhat.com
Alan pointed out a race in the code where
Hello,
When multiple hvc console ports are initialised and used via the
virtio_console driver, I can interact with only the first console, the
2nd one doesn't respond.
If I call hvc_kick() even if hvc_poll() returns 0, the 2nd console
becomes responsive.
I've checked that hvc_poll() receives
On (Mon) Mar 22 2010 [18:45:47], François Diakhate wrote:
Hi all,
As far as I can see, early_put_chars is not used by virtio_console
because it checks whether there is a port available before using it.
If I understand correctly, this makes it useless because once we have
a port, we can use
On (Mon) Mar 22 2010 [18:45:47], François Diakhate wrote:
Hi all,
As far as I can see, early_put_chars is not used by virtio_console
because it checks whether there is a port available before using it.
If I understand correctly, this makes it useless because once we have
a port, we can use
On (Sun) Mar 21 2010 [08:04:39], Benjamin Herrenschmidt wrote:
On Fri, 2010-03-19 at 08:18 -0700, Greg Kroah-Hartman wrote:
From: Amit Shah amit.s...@redhat.com
Alan pointed out a race in the code where hvc_remove is invoked. The
recent virtio_console work is the first user of hvc_remove
NULL-...
This patch adds some tty krefs and also converts to using tty_vhangup().
Reported-by: Alan Cox a...@lxorguk.ukuu.org.uk
Signed-off-by: Amit Shah amit.s...@redhat.com
CC: Alan Cox a...@lxorguk.ukuu.org.uk
CC: linuxppc-...@ozlabs.org
CC: Rusty Russell ru
NULL-...
This patch adds some tty krefs and also converts to using tty_vhangup().
Reported-by: Alan Cox a...@lxorguk.ukuu.org.uk
Signed-off-by: Amit Shah amit.s...@redhat.com
CC: Alan Cox a...@lxorguk.ukuu.org.uk
CC: linuxppc-...@ozlabs.org
CC: Rusty Russell ru
On (Wed) Mar 03 2010 [15:55:22], Alan Cox wrote:
On Wed, 3 Mar 2010 20:59:48 +0530
Amit Shah amit.s...@redhat.com wrote:
Alan pointed out a race in the code where hvc_remove is invoked. The
recent virtio_console work is the first user of hvc_remove().
Looks better to me.
Thanks, Alan
NULL-...
This patch adds some tty krefs and also converts to using tty_vhangup()
before putting the tty kref.
Reported-by: Alan Cox a...@lxorguk.ukuu.org.uk
Signed-off-by: Amit Shah amit.s...@redhat.com
CC: Alan Cox a...@lxorguk.ukuu.org.uk
CC: linuxppc
From: Rusty Russell ru...@rustcorp.com.au
This is nicer for modern R/O protection. And noone needs it non-const, so
constify the callers as well.
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
Signed-off-by: Amit Shah amit.s...@redhat.com
To: Christian Borntraeger borntrae...@de.ibm.com
Cc
Virtio consoles can be hotplugged, so hvc_alloc gets called from
multiple sites: from the initial probe() routine as well as later on
from workqueue handlers which aren't __devinit code.
So, drop the __devinit annotation for hvc_alloc.
Signed-off-by: Amit Shah amit.s...@redhat.com
Cc: linuxppc
From: Rusty Russell ru...@rustcorp.com.au
This is nicer for modern R/O protection. And noone needs it non-const, so
constify the callers as well.
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
Signed-off-by: Amit Shah amit.s...@redhat.com
To: Christian Borntraeger borntrae...@de.ibm.com
Cc
Virtio consoles can be hotplugged, so hvc_alloc gets called from
multiple sites: from the initial probe() routine as well as later on
from workqueue handlers which aren't __devinit code.
So, drop the __devinit annotation for hvc_alloc.
Signed-off-by: Amit Shah amit.s...@redhat.com
Cc: linuxppc
From: Rusty Russell ru...@rustcorp.com.au
This is nicer for modern R/O protection. And noone needs it non-const, so
constify the callers as well.
Signed-off-by: Rusty Russell ru...@rustcorp.com.au
Signed-off-by: Amit Shah amit.s...@redhat.com
To: Christian Borntraeger borntrae...@de.ibm.com
Cc
The virtio console, which uses hvc, will get the ability to hot-unplug
ports. Export hvc_remove so that virtio_console can disassociate with
hvc.
Signed-off-by: Amit Shah amit.s...@redhat.com
Cc: linuxppc-...@ozlabs.org
---
drivers/char/hvc_console.c |1 +
1 files changed, 1 insertions(+), 0
On (Thu) Aug 27 2009 [14:07:03], Benjamin Herrenschmidt wrote:
On Wed, 2009-08-26 at 21:15 +0530, Amit Shah wrote:
- Convert hvc's usage of spinlocks to mutexes. I've no idea how this
will play out; I'm no expert here. But I did try doing this and so far
it all looks OK
On (Thu) Aug 27 2009 [15:04:45], Michael Ellerman wrote:
On Wed, 2009-08-26 at 21:15 +0530, Amit Shah wrote:
[cc'ing some people who have made some commits in hvc_console.c]
On (Wed) Aug 26 2009 [16:57:18], Amit Shah wrote:
On (Tue) Aug 25 2009 [11:47:20], Amit Shah wrote
[cc'ing some people who have made some commits in hvc_console.c]
On (Wed) Aug 26 2009 [16:57:18], Amit Shah wrote:
On (Tue) Aug 25 2009 [11:47:20], Amit Shah wrote:
Hello all,
Here is a new iteration of the patch series that implements a
transport for guest and host communications
46 matches
Mail list logo
