Re: [lm-sensors] [PATCH] hwmon: (tmp421) Add nfactor support (2nd attempt)

2010-07-21 Thread Andre Prendel
On Tue, Jul 20, 2010 at 08:59:52AM -0700, Guenter Roeck wrote: On Tue, Jul 20, 2010 at 11:09:53AM -0400, Andre Prendel wrote: On Thu, May 20, 2010 at 09:35:56PM +0200, Andre Prendel wrote: On Thu, May 20, 2010 at 03:07:05PM -0400, Jeff Angielski wrote: In any event, here it is again

Re: [lm-sensors] [PATCH] hwmon: (tmp421) Add nfactor support (2nd attempt)

2010-07-20 Thread Andre Prendel
On Thu, May 20, 2010 at 09:35:56PM +0200, Andre Prendel wrote: On Thu, May 20, 2010 at 03:07:05PM -0400, Jeff Angielski wrote: In any event, here it is again: Acked-by: Andre Prendel andre.pren...@gmx.de Hi Jeff, I'de suggest to resend the patch with my acked-by to the lm-sensors list

Re: [lm-sensors] [PATCH] hwmon: (tmp421) Add nfactor support (2nd attempt)

2010-06-18 Thread Andre Prendel
On Thu, May 20, 2010 at 09:35:56PM +0200, Andre Prendel wrote: On Thu, May 20, 2010 at 03:07:05PM -0400, Jeff Angielski wrote: On 05/20/2010 02:50 PM, Andre Prendel wrote: You made a careless mistake, see below. Please fix this and resend the patch again. Then I added my Acked

Re: [lm-sensors] [PATCH] hwmon: (tmp421) Add nfactor support (2nd attempt)

2010-05-20 Thread Andre Prendel
On Wed, May 19, 2010 at 01:13:04PM -0400, Jeff Angielski wrote: On 05/19/2010 03:26 AM, Andre Prendel wrote: Ok, so there is only one remaining task :) Please update the documentation under Documentation/hwmon/tmp421. Then you will get my Acked-by. Documentation is updated in this patch

Re: [lm-sensors] [PATCH] hwmon: (tmp421) Add nfactor support (2nd attempt)

2010-05-20 Thread Andre Prendel
On Thu, May 20, 2010 at 03:07:05PM -0400, Jeff Angielski wrote: On 05/20/2010 02:50 PM, Andre Prendel wrote: You made a careless mistake, see below. Please fix this and resend the patch again. Then I added my Acked-by and I think Jean will schedule the patch for 2.6.35 (after another review

Re: [lm-sensors] [PATCH] hwmon: (tmp421) Add nfactor support (2nd attempt)

2010-05-19 Thread Andre Prendel
On Tue, May 18, 2010 at 10:35:21AM -0400, Jeff Angielski wrote: On 05/18/2010 07:38 AM, Andre Prendel wrote: I'd prefer starting i with 0 and as condition i data-channels - 1. for (i = 0; i data-channels -1; i++) { data-nfactor[i] = i2c_smbus_read_byte_data(client

Re: [lm-sensors] [PATCH] hwmon: (tmp421) Add nfactor support (2nd attempt)

2010-05-18 Thread Andre Prendel
On Mon, May 17, 2010 at 04:30:24PM -0400, Jeff Angielski wrote: Here is a second attempt at a patch to add nfactor support to the tmp421 driver. Hi Jeff, only a few minor issues, see below. This includes the changes as suggested by Andre Prendel, the original driver author. From

Re: [PATCH] hwmon: (tmp421) Add nfactor support.

2010-05-11 Thread Andre Prendel
On Mon, May 10, 2010 at 10:43:07AM -0400, Jeff Angielski wrote: Hi Jeff, A few comments below. Add support for reading and writing the n-factor correction registers. This is needed to compensate for the characteristics of a particular sensor hanging off of the remote channels.