Re: [PATCH v2 1/2] maple_tree: Disable mas_wr_append() when other readers are possible

On Sep 12 2023, Liam R. Howlett wrote: > * Andreas Schwab [230912 14:15]: >> Any news? This is still broken. > > I have a proposed fix. I seem to have caused a pre-existing problem to > show up. Please see if the attached works for you, and I'll send it > to a lot of peop

Re: [PATCH v2 1/2] maple_tree: Disable mas_wr_append() when other readers are possible

Any news? This is still broken. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v2 1/2] maple_tree: Disable mas_wr_append() when other readers are possible

On Aug 31 2023, Michael Ellerman wrote: > Andreas Schwab writes: >> This breaks booting on ppc32: > > Does enabling CONFIG_DEBUG_ATOMIC_SLEEP fix the crash? Yes, it does. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9D

Re: [PATCH v2 1/2] maple_tree: Disable mas_wr_append() when other readers are possible

[c0b09f90] c0988aa0 early_irq_init+0x64/0x8c [c0b09fa0] c097a5a4 start_kernel+0x5b4/0x7b0 [c0b09ff0] 3dc0 mon> -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v4 2/5] fs: Add fchmodat2()

ave. > > That can't be allowed. IIUC, fchmodat2(fd, "", m, AT_EMPTY_PATH) is equivalent to fchmod(fd, m). With that, new architectures only need to implement the fchmodat2 syscall to cover all chmod variants. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578

Re: [PATCH v8 1/3] riscv: Introduce CONFIG_RELOCATABLE

BLE > +CFLAGS_alternative.o += -fno-pie > +CFLAGS_cpufeature.o += -fno-pie > +endif >  ifdef CONFIG_KASAN >  KASAN_SANITIZE_alternative.o := n >  KASAN_SANITIZE_cpufeature.o := n I can confirm that this fixes the crash. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerp

Re: [PATCH v8 1/3] riscv: Introduce CONFIG_RELOCATABLE

On Mai 09 2023, Alexandre Ghiti wrote: > On 5/9/23 21:07, Andreas Schwab wrote: >> That does not work with UEFI booting: >> >> Loading Linux 6.4.0-rc1-1.g668187d-default ... >> Loading initial ramdisk ... >> Unhandled exception: Instruction access

Re: [PATCH v8 1/3] riscv: Introduce CONFIG_RELOCATABLE

[0xdaa82000:0xdcc2afff] -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH 06/14] powerpc/vdso: Remove unused '-s' flag from ASFLAGS

nlinedocs/gcc/Link-Options.html#index-s Most assembler flags are unrelated to the flags passed to the compiler driver, and -s is no exception. POSIX has nothing to say about the sub-commands of the compiler anyway. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 25

Re: [PATCH] powerpc: Fix a wrong version calculation issue in ld_version

computed version. It just means that it's a snapshot from after the 2.37 release, so it should be treated like 2.37 (no further releases has been made from this branch). -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now

[PATCH] powerpc/32: fix syscall wrappers with 64-bit arguments

ot;) Fixes: e23750623835 ("powerpc/32: fix syscall wrappers with 64-bit arguments of unaligned register-pairs") Signed-off-by: Andreas Schwab --- arch/powerpc/include/asm/syscalls.h | 7 +++ arch/powerpc/kernel/sys_ppc32.c | 13 - arch/powerpc/kernel/sysca

[PATCH] asm-generic: compat: fix compat_arg_u64 and compat_arg_u64_dual

The macros are defined backwards. Fixes: 43d5de2b67d7 ("asm-generic: compat: Support BE for long long args in 32-bit ABIs") Signed-off-by: Andreas Schwab --- include/asm-generic/compat.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/asm-generic/compat.h

Re: [PATCH v6 21/25] powerpc: Provide syscall wrapper

On Okt 30 2022, Arnd Bergmann wrote: > On Sun, Oct 30, 2022, at 16:34, Andreas Schwab wrote: >> This breaks powerpc32. The fallocate syscall misinterprets its >> arguments. > > It was fixed in Nope. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47

Re: [PATCH 1/2] powerpc/32: fix syscall wrappers with 64-bit arguments of unaligned register-pairs

e64 Doesn't that lack entries for SPU? Likewise for all other former common syscalls in this patch. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v6 21/25] powerpc: Provide syscall wrapper

It probably breaks every syscall with a 64-bit argument. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v6 21/25] powerpc: Provide syscall wrapper

This breaks powerpc32. The fallocate syscall misinterprets its arguments. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: Fwd: Fwd: X stopped working with 5.14 on iBook

I don't use debian. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: Fwd: Fwd: X stopped working with 5.14 on iBook

On Nov 04 2021, Finn Thain wrote: > Does your Xorg installation use --enable-suid-wrapper, Andreas? Doesn't look like. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: Fwd: Fwd: X stopped working with 5.14 on iBook

okay > d3ccc9781560~ + CONFIG_USER_NS=y --> okay > d3ccc9781560~ + CONFIG_USER_NS=n --> okay On my iBook G4, X is working alright with 5.15 and CONFIG_USER_NS=y. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1

Re: [PATCH] powerpc/syscalls: Remove __NR__exit

On Aug 23 2021, Christophe Leroy wrote: > __NR_exit is nowhere used. On most architectures it was removed by ITYM __NR__exit, which is what you are removing. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "

Re: Possible regression by ab037dd87a2f (powerpc/vdso: Switch VDSO to generic C implementation.)

build_log/openSUSE:Factory:PowerPC/go1.13/standard/ppc64 https://build.opensuse.org/package/live_build_log/openSUSE:Factory:PowerPC/go1.14/standard/ppc64 Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for someth

Re: [PATCH 4/4] powerpc/32: Avoid #ifdef nested with FTR_SECTION on booke syscall entry

On Jun 04 2021, Christophe Leroy wrote: > On booke, SYSCALL_ENTRY macro nests an FTR_SECTION with a That sentence lacks an Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v3] powerpc/64: Option to use ELFv2 ABI for big-endian kernels

Should this add a tag to the module vermagic? Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH] powerpc/64s: power4 nap fixup in C

On Apr 05 2021, Nicholas Piggin wrote: > I worked it out. There was a window where it could take another > interrupt before the first one adjusts the nip. > > I managed to trigger it in qemu and this version fixed it. Works for me as well. Andreas. -- Andreas Schwab, sch...@li

Re: [PATCH] powerpc/64s: power4 nap fixup in C

On Mär 29 2021, Andreas Schwab wrote: > On Mär 29 2021, Christophe Leroy wrote: > >> Le 29/03/2021 à 10:33, Benjamin Herrenschmidt a écrit : >>> On Fri, 2021-03-12 at 11:20 +1000, Nicholas Piggin wrote: >>>> >>>> +static inlin

Re: [PATCH] powerpc/64s: power4 nap fixup in C

On Mär 29 2021, Andreas Schwab wrote: > On Mär 29 2021, Michael Ellerman wrote: > >> Nicholas Piggin writes: >>> There is no need for this to be in asm, use the new intrrupt entry wrapper. >>> >>> Signed-off-by: Nicholas Piggin >>> --- >>&

Re: [PATCH] powerpc/64s: power4 nap fixup in C

gt;> problem with QEMU. > > It still prevents my G5 from booting. I see differing failures. What's common is that there is a pause of about 60 seconds before the crash occurs. It looks like the crash occurs in power4_idle_nap+0x30/0x34. Unfortuately, the BootX console is too small to s

Re: [PATCH] powerpc/64s: power4 nap fixup in C

_book3s.S > @@ -209,4 +209,8 @@ _GLOBAL(power4_idle_nap) > mtmsrd r7 > isync > b 1b > + > + .globl power4_idle_nap_return > +power4_idle_nap_return: > + blr > #endif The problem is not the definition, it is the reference. In C, a function symbol always

Re: [PATCH 2/4] exec: remove compat_do_execve

On Mär 26 2021, Christoph Hellwig wrote: > Just call compat_do_execve instead. ITYM compat_do_execveat here. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v3 11/17] riscv: Convert to GENERIC_CMDLINE

OMMAND_LINE_SIZE); > + cmdline_build(boot_command_line, NULL, COMMAND_LINE_SIZE); > pr_info("Forcing kernel command line to: %s\n", boot_command_line); Shouldn't that message become conditional in some way? Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerp

Re: [RFC PATCH v1] powerpc: Enable KFENCE for PPC32

acro 'pr_err' >>233 | pr_err("Invalid free of 0x%p (in kfence-#%zd):\n", (void >> *)address, >>| ^~ >> >> Christophe > > No this is not expected. Is 'signed size_t' != 'long int' on ppc32? If you want to format a ptrdiff_t you should use %td. Andreas. --

[PATCH] powerpc/vdso: fix clock_gettime_fallback for vdso32

the 32-bit vdso. Signed-off-by: Andreas Schwab --- arch/powerpc/include/asm/vdso/gettimeofday.h | 8 1 file changed, 8 insertions(+) diff --git a/arch/powerpc/include/asm/vdso/gettimeofday.h b/arch/powerpc/include/asm/vdso/gettimeofday.h index 81671aa365b3..a26c12df2c9a 100644

Re: [PATCH v14 6/9] powerpc/vdso: Prepare for switching VDSO to generic C implementation.

rn do_syscall_2(__NR_gettimeofday, (unsigned long)_tv, (unsigned > long)_tz); > +} > + > +static __always_inline > +int clock_gettime_fallback(clockid_t _clkid, struct __kernel_timespec *_ts) > +{ > + return do_syscall_2(__NR_clock_gettime, _clkid, (unsigned long)_ts); Doesn't that need to be __NR_clock_gettime64 for ppc32? > +} > + > +static __always_inline > +int clock_getres_fallback(clockid_t _clkid, struct __kernel_timespec *_ts) > +{ > + return do_syscall_2(__NR_clock_getres, _clkid, (unsigned long)_ts); And here __NR_clock_getres_time64? Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH] powerpc/32s: Use relocation offset when setting early hash table

write into Hash in early_hash_table(). >> >> Reported-by: Erhard Furtner >> Reported-by: Andreas Schwab >> Fixes: 69a1593abdbc ("powerpc/32s: Setup the early hash table at all time.") >> Signed-off-by: Christophe Leroy > > Tested-by: Serge Belyshev Works

Re: [PATCH] powerpc: Use asm_goto_volatile for put_user()

With that patch the kernel is working again. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH] powerpc/32s: Setup the early hash table at all time.

On Nov 03 2020, Christophe Leroy wrote: > Would you mind checking that with that patch reverted, you are able to > boot a kernel built with CONFIG_KASAN ? That doesn't exist. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E78

Re: [PATCH] powerpc/32s: Setup the early hash table at all time.

On Nov 03 2020, Christophe Leroy wrote: > I tried again on QEMU with both pmac32_defconfig and your config, and it > boots. Isn't it quite naïve to think that qemu provides an adequate test environment for such lowlevel stuff? Andreas. -- Andreas Schwab, sch...@linux-m68k.org G

Re: [PATCH] powerpc/32s: Setup the early hash table at all time.

# # Automatically generated file; DO NOT EDIT. # Linux/powerpc 5.10.0-rc1 Kernel Configuration # CONFIG_CC_VERSION_TEXT="gcc-4.9 (SUSE Linux) 4.9.3" CONFIG_CC_IS_GCC=y CONFIG_GCC_VERSION=40903 CONFIG_LD_VERSION=23501 CONFIG_CLANG_VERSION=0 CONFIG_CC_CAN_LINK=y CONFIG_CC_CAN_LINK_STATIC=y

Re: [PATCH] powerpc/32s: Setup the early hash table at all time.

On Okt 30 2020, Michael Ellerman wrote: > Andreas Schwab writes: >> On Okt 01 2020, Christophe Leroy wrote: >> >>> At the time being, an early hash table is set up when >>> CONFIG_KASAN is selected. >>> >>> There is nothing wrong with sett

Re: [PATCH] powerpc/32s: Setup the early hash table at all time.

ce to early_hash[]. This > reference is removed by MMU_init_hw_patch() before init memory is > freed. This breaks booting on the iBook G4. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH 1/3] powerpc/uaccess: Switch __put_user_size_allowed() to __put_user_asm_goto()

# # Automatically generated file; DO NOT EDIT. # Linux/powerpc 5.10.0-rc1 Kernel Configuration # CONFIG_CC_VERSION_TEXT="gcc-4.9 (SUSE Linux) 4.9.3" CONFIG_CC_IS_GCC=y CONFIG_GCC_VERSION=40903 CONFIG_LD_VERSION=23501 CONFIG_CLANG_VERSION=0 CONFIG_CC_CAN_LINK=y CONFIG_CC_CAN_LINK_STATIC=y

Re: [PATCH 1/3] powerpc/uaccess: Switch __put_user_size_allowed() to __put_user_asm_goto()

On Okt 28 2020, Michael Ellerman wrote: > What config and compiler are you using? gcc 4.9. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH 1/3] powerpc/uaccess: Switch __put_user_size_allowed() to __put_user_asm_goto()

On Okt 28 2020, Andreas Schwab wrote: > On Sep 04 2020, Christophe Leroy wrote: > >> __put_user_asm_goto() provides more flexibility to GCC and avoids using >> a local variable to tell if the write succeeded or not. >> GCC can then avoid implementing a cmp in the fa

Re: [PATCH 1/3] powerpc/uaccess: Switch __put_user_size_allowed() to __put_user_asm_goto()

n failure in __libc_fork (THREAD_GETMEM (self, tid) != ppid). Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v2] powerpc: fix EDEADLOCK redefinition error in uapi/asm/errno.h

On Sep 17 2020, Arnd Bergmann wrote: > The errno man page says they are supposed to be synonyms, > and glibc defines it that way, while musl uses the numbers > from the kernel. glibc also uses whatever the kernel defines. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fi

Re: [PATCH] powerpc/32s: Fix module loading failure when VMALLOC_END is over 0xf0000000

; Use (ALIGN(VMALLOC_END, SZ_256M) - 1) which will have > value 0x and will be suitable for the comparison. > > Reported-by: Andreas Schwab > Signed-off-by: Christophe Leroy > Fixes: c49643319715 ("powerpc/32s: Only leave NX unset on segments used for > modules"

Re: [PATCH v2 3/6] powerpc/32s: Only leave NX unset on segments used for modules

<3d20c08b> 3d40c086 9421ffe0 8129106c ---[ end trace 85a98cc836109871 ]--- Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v2] powerpc: select ARCH_HAS_MEMBARRIER_SYNC_CORE

onising > + * (which rfi is) to support ARCH_HAS_MEMBARRIER_SYNC_CORE without additional > + * additional synchronisation instructions. s/additonal// Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v2 2/2] powerpc/configs: replace deprecated riva/nvidia with nouveau

000:f0:10.0 failed with error -22 Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH] macintosh: windfarm: fix MODINFO regression

On Mär 03 2020, Wolfram Sang wrote: > sound/aoa/codecs/onyx.c > sound/aoa/codecs/tas.c These are loaded explicitly via request_module (as snd-aoa-codec-%s). Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 &q

Re: vmlinux ELF header sometimes corrupt

, and always in exactly this way with the first 52 > bytes having been wiped. Note that the size of the ELF header (Elf32_Ehdr) is 52 bytes. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: Call for report - G5/PPC970 status

On Dez 12 2019, Romain Dolbeau wrote: > Can you share your kernel config, compiler version, and other details? I'm using 4K pages, in case that matters, and gcc 4.8. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA A

Re: Call for report - G5/PPC970 status

On Dez 11 2019, Romain Dolbeau wrote: > Same question to anyone else with a G5 / PPC970 - what is it and does > it boot recent PPC64 Linux kernel ? My PowerMac7,3 (DP 2.0GHz) can boot 5.5-rc1 without issues. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 757

Re: passing NULL to clock_getres (VDSO): terminated by unexpected signal 11

On Okt 20 2019, Thomas Gleixner wrote: > But for the sake of making a non-sensical specification happy we can add a > NULL pointer check for this. The interesting question is what should be > returned in this case. 0 if the clock id is valid, EINVAL otherwise. Andreas. -- Andreas Sc

Re: passing NULL to clock_getres (VDSO): terminated by unexpected signal 11

res is NULL, the clock resolution is not returned.". Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: passing NULL to clock_getres (VDSO): terminated by unexpected signal 11

X requires it to work. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: passing NULL to clock_getres (VDSO): terminated by unexpected signal 11

On Okt 20 2019, Christophe Leroy wrote: > Le 19/10/2019 à 21:18, Andreas Schwab a écrit : >> On Okt 19 2019, Christophe Leroy wrote: >> >>> Hi Nathan, >>> >>> While trying to switch powerpc VDSO to C version of gettimeofday(), I'm >>>

Re: passing NULL to clock_getres (VDSO): terminated by unexpected signal 11

g at commit a9446a906f52 ("lib/vdso/32: Remove inconsistent NULL > pointer checks"), it seems that signal 11 is expected when passing NULL > pointer. > > Any plan to fix vdsotest ? Passing NULL to clock_getres is valid, and required to return successfully if the clock id is vali

Re: [PATCH -next] ASoC: fsl_mqs: fix old-style function declaration

On Okt 11 2019, YueHaibing wrote: > gcc warn about this: > > sound/soc/fsl/fsl_mqs.c:146:1: warning: > static is not at beginning of declaration [-Wold-style-declaration] It's not a function, though. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB

Re: [PATCH 2/6] powerpc/64s/radix: tidy up TLB flushing code

as errors make[4]: *** [arch/powerpc/mm/book3s64/pgtable.o] Error 1 Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v12 01/12] lib: introduce copy_struct_{to, from}_user helpers

ler must have already > + * checked access_ok(p, size). > + */ > +static int __memzero_user(void __user *p, size_t s) > +{ > + const char zeros[BUFFER_SIZE] = {}; Perhaps make that static? Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: 5.2.7 kernel doesn't boot on G5

On Aug 16 2019, Christian Marillat wrote: > On 15 août 2019 19:50, christophe leroy wrote: > > [...] > >> Can you test with latest stable version, ie 5.2.8 ? > > Built from my G5 with make-kpkg and still doesn't boot : FWIW, 5.2.0 is working fine on my G5 (PowerMac7,3)

Re: [RFC PATCH v2 02/12] powerpc/ptrace: drop unnecessary #ifdefs CONFIG_PPC64

On Jun 28 2019, Christophe Leroy wrote: > Le 28/06/2019 à 18:36, Andreas Schwab a écrit : >> On Jun 28 2019, Christophe Leroy wrote: >> >>> diff --git a/arch/powerpc/include/uapi/asm/ptrace.h >>> b/arch/powerpc/include/uapi/asm/ptrace.h >>&g

Re: [RFC PATCH v2 02/12] powerpc/ptrace: drop unnecessary #ifdefs CONFIG_PPC64

(not used at present) */ > + union { > + unsigned long softe;/* Soft enabled/disabled */ > + unsigned long mq; /* 601 only (not used at present) */ > /* Used on APUS to hold IPL value. */ > -#endif > + }; A

Re: [PATCH 0/1] PPC32: fix ptrace() access to FPU registers

Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

[PATCH] powerpc/mm/32s: fix condition that is always true

Move a misplaced paren that makes the condition always true. Fixes: 63b2bc619565 ("powerpc/mm/32s: Use BATs for STRICT_KERNEL_RWX") Signed-off-by: Andreas Schwab --- arch/powerpc/mm/pgtable_32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/mm/pgta

Re: [PATCH] powerpc/32s: fix suspend/resume when IBATs 4-7 are used

: Error: invalid bat number arch/powerpc/kernel/swsusp_32.S:157: Error: invalid bat number make[3]: *** [arch/powerpc/kernel/swsusp_32.o] Error 1 Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something compl

Re: [PATCH v5 13/16] powerpc/mm/32s: Use BATs for STRICT_KERNEL_RWX

nd/resume works. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v5 13/16] powerpc/mm/32s: Use BATs for STRICT_KERNEL_RWX

On Jun 16 2019, christophe leroy wrote: > If any of registers IBATs 4 to 7 are used Nope. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v5 13/16] powerpc/mm/32s: Use BATs for STRICT_KERNEL_RWX

On Jun 16 2019, christophe leroy wrote: > Le 15/06/2019 à 14:28, Andreas Schwab a écrit : >> On Feb 21 2019, Christophe Leroy wrote: >> >>> diff --git a/arch/powerpc/mm/pgtable_32.c b/arch/powerpc/mm/pgtable_32.c >>> index a000768a5cc9..6e56a6240bfa 100644 >&

Re: [PATCH] powerpc/mm/32s: only use MMU to mark initmem NX if STRICT_KERNEL_RWX

On Jun 15 2019, Christophe Leroy wrote: > Andreas Schwab a écrit : > >> If STRICT_KERNEL_RWX is disabled, never use the MMU to mark initmen >> nonexecutable. > > I dont understand, can you elaborate ? It breaks suspend. > This area is mapped with BATs so using chan

[PATCH] powerpc/mm/32s: only use MMU to mark initmem NX if STRICT_KERNEL_RWX

If STRICT_KERNEL_RWX is disabled, never use the MMU to mark initmen nonexecutable. Also move a misplaced paren that makes the condition always true. Fixes: 63b2bc619565 ("powerpc/mm/32s: Use BATs for STRICT_KERNEL_RWX") Signed-off-by: Andreas Schwab --- arch/powerpc/mm/pgtable_32.c |

Re: [PATCH v5 13/16] powerpc/mm/32s: Use BATs for STRICT_KERNEL_RWX

initmem_nx(void) > unsigned long numpages = PFN_UP((unsigned long)_einittext) - >PFN_DOWN((unsigned long)_sinittext); > > - change_page_attr(page, numpages, PAGE_KERNEL); > + if (v_block_mapped((unsigned long)_stext) + 1) That is always true. And

Re: [PATCH v5 13/16] powerpc/mm/32s: Use BATs for STRICT_KERNEL_RWX

This breaks suspend (or resume) on the iBook G4. no_console_suspend doesn't give any clues, the display just stays dark. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [BISECTED REGRESSION] b43legacy broken on G4 PowerBook

orted 0x%llx\n", > mask, dev->dma_mask, > + dma_supported(dev, mask)); None of the format directives match the type of the arguments. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH] [RFC] Remove bdflush syscall stub

On Mai 28 2019, Cyril Hrubis wrote: > I've tested the patch on i386. Before the patch calling bdflush() with > attempt to tune a variable returned 0 and after the patch the syscall > fails with EINVAL. Should be ENOSYS, doesn't it? Andreas. -- Andreas Schwab, sch...@linux-m68k.or

Re: powerpc/mm: Only define MAX_PHYSMEM_BITS in SPARSEMEM configurations

vs SPARSEMEM on a G5. Configuring with SPARSEMEM saves about 32Mb of memory. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: powerpc/mm: Only define MAX_PHYSMEM_BITS in SPARSEMEM configurations

On Mär 24 2019, Ben Hutchings wrote: > Presumably you have CONFIG_PPC_BOOK3S_64 enabled and CONFIG_SPARSEMEM > disabled? Was this configuration actually usable? Why not? Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E78

Re: powerpc/mm: Only define MAX_PHYSMEM_BITS in SPARSEMEM configurations

x/slab.h:15, from ./include/linux/crypto.h:24, from ./include/crypto/algapi.h:15, from ./include/crypto/internal/hash.h:16, from arch/powerpc/crypto/md5-glue.c:15: ./arch/powerpc/include/asm/book3s/64/mmu-hash.h:584:6: error: "MAX_PHYS

Re: [PATCH] powerpc/64s: Fix possible corruption on big endian due to pgd/pud_present()

On Feb 14 2019, Michael Ellerman wrote: > The fix is simple, we need to convert the result of the bitwise && to > an int before returning it. Alternatively, the return type could be changed to bool, so that the compiler does the right thing by itself. Andreas. -- Andreas Schwab

Re: [PATCH 01/11] powerpc: remove dead ifdefs in

On Feb 13 2019, Christoph Hellwig wrote: > __KERNEL__ is never not defined for non-uapi headers, and GENERIC_CSUM "... never not ... non-..." That's a bit too negative, I think. :-) Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 19

Re: [PATCH] powerpc: use PTRRELOC during early init

On Okt 03 2018, Christophe LEROY wrote: > Did you try my proposed fix https://patchwork.ozlabs.org/patch/977195/ ? That works as well. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something co

[PATCH] powerpc: use PTRRELOC during early init

This fixes a crash on powerpc32 when using global data during early init without relocating its address. Fixes: 51c3c62b58 (powerpc: Avoid code patching freed init sections) Signed-off-by: Andreas Schwab --- arch/powerpc/lib/code-patching.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH v4] powerpc: Avoid code patching freed init sections

On Sep 14 2018, Michael Neuling wrote: > This stops us from doing code patching in init sections after they've > been freed. This breaks booting on PowerBook6,7, crashing very early. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 255

Re: Oops running iptables -F OUTPUT

U_DYNAMIC_RESERVE, > + atom_size, pcpu_cpu_distance, > pcpu_fc_alloc, pcpu_fc_free); > if (rc < 0) > panic("cannot initialize percpu area (err=%d)", rc); That didn't help. Andreas. -- Andreas S

Oops running iptables -F OUTPUT

4807e1 41e20010 7c210b78 [ 91.139752] ---[ end trace f5d1d5431651845d ]--- Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH] Revert "net: pskb_trim_rcsum() and CHECKSUM_COMPLETE are friends"

0 06 40 20 01 0a 62 17 11 88 01 00 00 ... .@ ..b.. [ 662.659780] raw data: 0020: 00 00 00 00 0a 38 20 01 0a 62 17 11 88 01 00 00 .8 ..b.. [ 662.659783] raw data: 0030: 00 00 00 00 00 07 9a 18 00 16 c1 9a 7e ea ea 44 ~..D [ 662.659785] raw data: 0040:

Re: [PATCH] Revert "net: pskb_trim_rcsum() and CHECKSUM_COMPLETE are friends"

5f 30 52 3f ea 70 9b .[a_0R?.p. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH 1/3] powerpc: mac: fix rtc read functions

hink the right fix is to change nowtime in pmu_set_rtc_time and cuda_set_rtc_time back to unsigned int (or to u32). Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH] Revert "net: pskb_trim_rcsum() and CHECKSUM_COMPLETE are friends"

mdiff = skb_checksum(skb, len, skb->len - len, 0); > > - skb->csum = csum_sub(skb->csum, > -skb_checksum(skb, len, delta, 0)); > + skb->csum = csum_block_sub(skb->csum, csumdiff, len); > } > ret

Re: [PATCH] Revert "net: pskb_trim_rcsum() and CHECKSUM_COMPLETE are friends"

skb->csum = csum_unfold(csum); > + skb->ip_summed = CHECKSUM_COMPLETE; > + } > skb->protocol = eth_type_trans(skb, gp->dev); > > napi_gro_receive(>napi, skb); That doesn't change anything. An

Re: [PATCH] Revert "net: pskb_trim_rcsum() and CHECKSUM_COMPLETE are friends"

On Jun 16 2018, Mathieu Malaterre wrote: > That's odd since it seems to only affect g4+sungem user. None of the > ppc64 seems to be having it. I'm also seeing it on a PowerMac G5. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF7

Re: [PATCH v2 08/12] macintosh/via-pmu68k: Don't load driver on unsupported hardware

On Jun 09 2018, Finn Thain wrote: > There is no ABI issue AFAIK. The value of pmu_kind is visible to userland > only on powerpc. /dev/pmu and /proc/pmu/* do not exist on m68k. Then why are PMU_68K_V1 and PMU_68K_V2 defined in the first place? Andreas. -- Andreas Schwab, sch...

Re: [PATCH v2 08/12] macintosh/via-pmu68k: Don't load driver on unsupported hardware

t;> }; > > Is this enum used by any user space code? If so, perhaps rather leave the > PMU_68K_V1 in there to avoid upsetting that? It also changes the value of PMU_68K_V2, which is an ABI break. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: ppc32: semctl fails

Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."

Re: 32-bit powerpc, aty128fb: vmap allocation for size 135168 failed

M header signature: expecting 0xaa55, got 0x1110 I think these messages are harmless and expected. This device has no x86 option ROM but a OpenFirmware one. This is likely unrelated to the sddm crash. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 0

Re: [PATCH] powerpc: fix invalid use of register expressions

This fixes another invalid use of register expressions. Signed-off-by: Andreas Schwab <sch...@linux-m68k.org> --- arch/powerpc/kernel/l2cr_6xx.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/l2cr_6xx.S b/arch/powerpc/kernel/l2cr_6xx.S

Re: 4.13-rc3: Unrecoverable exception 4100

On Aug 07 2017, Michael Ellerman <m...@ellerman.id.au> wrote: > Ah of course. Not sure why I haven't seen it in any of my testing :/ It took me a whole gcc bootstrap to trigger it. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3

[PATCH] powerpc: fix invalid use of register expressions

binutils >= 2.26 now warns about misuse of register expressions in assembler operands that are actually literals, for example: arch/powerpc/kernel/entry_64.S:535: Warning: invalid register expression Signed-off-by: Andreas Schwab <sch...@linux-m68k.org> --- arch/powerpc/include/asm/

Re: 4.13-rc3: Unrecoverable exception 4100

No, this is really a 4.13-rc1 regression. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."

  1   2   3   4   >