ely non-obvious.
>
> Reorder everthing so common helpers, MSI and MSI-X specific functions are
> grouped together.
s/everthing/everything/
> Suggested-by: Thomas Gleixner
> Signed-off-by: Ahmed S. Darwish
> Signed-off-by: Thomas Gleixner
Acked-by: Bjorn Helgaas
I assume
cial PCI/MSI howto.
>
> Signed-off-by: Ahmed S. Darwish
> Signed-off-by: Thomas Gleixner
Acked-by: Bjorn Helgaas
> ---
> Documentation/PCI/msi-howto.rst | 10 ++
> 1 file changed, 10 insertions(+)
> ---
> --- a/Documentation/PCI/msi-howto.rst
> +++ b/Docume
n.
>
> Signed-off-by: Ahmed S. Darwish
> Signed-off-by: Thomas Gleixner
Acked-by: Bjorn Helgaas
> diff --git a/drivers/pci/msi/api.c b/drivers/pci/msi/api.c
> index ee9ed5ccd94d..8d1cf6db9bd7 100644
> --- a/drivers/pci/msi/api.c
> +++ b/drivers/pci/msi/api.c
> @@ -
e.
>
> Signed-off-by: Ahmed S. Darwish
> Signed-off-by: Thomas Gleixner
Acked-by: Bjorn Helgaas
> ---
> drivers/pci/msi/api.c | 12
> drivers/pci/msi/msi.c | 14 +-
> drivers/pci/msi/msi.h | 3 +++
> 3 files changed, 16 insertions(+), 13 deletions(-)
e.
>
> Signed-off-by: Ahmed S. Darwish
> Signed-off-by: Thomas Gleixner
Acked-by: Bjorn Helgaas
Trivial question below.
> ---
> drivers/pci/msi/api.c | 24
> drivers/pci/msi/msi.c | 14 +-
> drivers/pci/msi/msi.h | 1 +
> 3 fil
e.
>
> Signed-off-by: Ahmed S. Darwish
> Signed-off-by: Thomas Gleixner
Acked-by: Bjorn Helgaas
> ---
> drivers/pci/msi/api.c | 20
> drivers/pci/msi/msi.c | 20
> 2 files changed, 20 insertions(+), 20 deletions(-)
> ---
> dif
e.
>
> Signed-off-by: Ahmed S. Darwish
> Signed-off-by: Thomas Gleixner
Acked-by: Bjorn Helgaas
> ---
> drivers/pci/msi/api.c | 15 +++
> drivers/pci/msi/msi.c | 13 -
> 2 files changed, 15 insertions(+), 13 deletions(-)
> ---
> diff --git a/
file.
>
> Signed-off-by: Ahmed S. Darwish
> Signed-off-by: Thomas Gleixner
Acked-by: Bjorn Helgaas
> ---
> drivers/pci/msi/api.c | 23 +++
> drivers/pci/msi/msi.c | 24
> 2 files changed, 23 insertions(+), 24 deletions(-)
>
rnel-doc reference
> pci_alloc_irq_vectors() documentation added in parent commit.
>
> Signed-off-by: Ahmed S. Darwish
> Signed-off-by: Thomas Gleixner
Acked-by: Bjorn Helgaas
One question below.
> ---
> drivers/pci/msi/api.c | 59 ++
r and add
> proper kernel doc to it.
>
> Signed-off-by: Ahmed S. Darwish
> Signed-off-by: Thomas Gleixner
Acked-by: Bjorn Helgaas
Two nits below.
> ---
> drivers/pci/msi/api.c | 33 +
> include/linux/pci.h | 17 +
> 2 fi
e.
>
> Signed-off-by: Ahmed S. Darwish
> Signed-off-by: Thomas Gleixner
Acked-by: Bjorn Helgaas
> ---
> drivers/pci/msi/api.c | 32
> drivers/pci/msi/msi.c | 30 --
> drivers/pci/msi/msi.h | 3 +++
> 3 fil
gt; Signed-off-by: Ahmed S. Darwish
> Signed-off-by: Thomas Gleixner
Acked-by: Bjorn Helgaas
Nit: suggest "disentangle" or "untangle" for "distangle" here and in
subsequent patches.
> ---
> drivers/pci/msi/api.c | 23 +++
> drive
ned-off-by: Ahmed S. Darwish
> Signed-off-by: Thomas Gleixner
Acked-by: Bjorn Helgaas
> ---
> drivers/pci/msi/Makefile | 3 +--
> drivers/pci/msi/api.c| 37 +
> drivers/pci/msi/msi.c| 22 +-
> drivers/pci/msi
off-by: Ahmed S. Darwish
> Signed-off-by: Thomas Gleixner
Acked-by: Bjorn Helgaas
> ---
> drivers/pci/msi/msi.c | 61 +--
> drivers/pci/msi/msi.h | 83
> +---
> 2 files changed, 74 inserti
On Fri, Nov 11, 2022 at 02:54:42PM +0100, Thomas Gleixner wrote:
> From: Ahmed S. Darwish
>
> Follow the style of
>
> Signed-off-by: Ahmed S. Darwish
> Signed-off-by: Thomas Gleixner
Acked-by: Bjorn Helgaas
> ---
> drivers/pci/msi/msi.h |8
> 1
On Fri, Nov 11, 2022 at 02:54:37PM +0100, Thomas Gleixner wrote:
> From: Ahmed S. Darwish
>
> Let the core do the freeing of descriptors and just keep it around for the
> legacy case.
>
> Signed-off-by: Ahmed S. Darwish
> Signed-off-by: Thomas Gleixner
Ac
On Fri, Nov 11, 2022 at 02:54:35PM +0100, Thomas Gleixner wrote:
> From: Ahmed S. Darwish
>
> Set the bus token in the msi_domain_info structure and let the core code
> handle the update.
>
> Signed-off-by: Ahmed S. Darwish
> Signed-off-by: Thomas Gleixner
Ac
enables PCI_MSI_IRQ_DOMAIN which in turn selects
> GENERIC_MSI_IRQ_DOMAIN. So all the dependencies on PCI_MSI_IRQ_DOMAIN are
> just an indirection to PCI_MSI.
>
> Match the reality and just admit that PCI_MSI requires
> GENERIC_MSI_IRQ_DOMAIN.
>
> Signed-off-by: Thomas Gleixner
On Mon, Oct 31, 2022 at 10:39:49AM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas
>
> Many host controller drivers #include even though they
> don't need it. Remove the unnecessary #includes.
>
> v2: https://lore.kernel.org/r/20221025185147.665365-1-helg...@kerne
From: Bjorn Helgaas
Many host controller drivers #include even though they
don't need it. Remove the unnecessary #includes.
Signed-off-by: Bjorn Helgaas
---
drivers/pci/controller/cadence/pci-j721e.c | 1 -
drivers/pci/controller/dwc/pci-layerscape.c | 1 -
drivers/pci/controller/dwc
From: Bjorn Helgaas
pci-xgene-msi.c uses irq_domain_add_linear() and related interfaces, so it
needs but doesn't include it directly; it relies on the
fact that includes it.
But pci-xgene-msi.c *doesn't* need itself. Include
directly to remove this implicit dependency so a future
patch can
From: Bjorn Helgaas
pci-mvebu.c uses irq_domain_add_linear() and related interfaces but relies
on but doesn't include it directly; it relies on the
fact that includes it.
Include directly to remove this implicit dependency.
Signed-off-by: Bjorn Helgaas
Acked-by: Thomas Petazzoni
From: Bjorn Helgaas
pcie-microchip-host.c uses irq_domain_add_linear() and related interfaces,
so it needs but doesn't include it directly; it relies
on the fact that includes it.
But pcie-microchip-host.c *doesn't* need itself. Include
directly to remove this implicit dependency so
From: Bjorn Helgaas
pcie-altera-msi.c uses irq_domain_add_linear() and related interfaces, so
it needs but doesn't include it directly; it relies on
the fact that includes it.
But pcie-altera-msi.c *doesn't* need itself. Include
directly to remove this implicit dependency so a future
patch
From: Bjorn Helgaas
Many host controller drivers #include even though they
don't need it. Remove the unnecessary #includes.
v2: https://lore.kernel.org/r/20221025185147.665365-1-helg...@kernel.org/
v1: https://lore.kernel.org/r/20221019195452.37606-1-helg...@kernel.org/
Changes from v2 to v3
From: Bjorn Helgaas
Many host controller drivers #include even though they
don't need it. Remove the unnecessary #includes.
Signed-off-by: Bjorn Helgaas
---
drivers/pci/controller/cadence/pci-j721e.c | 1 -
drivers/pci/controller/dwc/pci-layerscape.c | 1 -
drivers/pci/controller/dwc
From: Bjorn Helgaas
pci-mvebu.c uses irq_domain_add_linear() and related interfaces but relies
on but doesn't include it directly; it relies on the
fact that includes it.
Include directly to remove this implicit dependency.
Signed-off-by: Bjorn Helgaas
---
drivers/pci/controller/pci
From: Bjorn Helgaas
pcie-microchip-host.c uses irq_domain_add_linear() and related interfaces,
so it needs but doesn't include it directly; it relies
on the fact that includes it.
But pcie-microchip-host.c *doesn't* need itself. Include
directly to remove this implicit dependency so
From: Bjorn Helgaas
Many host controller drivers #include even though they
don't need it. Remove the unnecessary #includes.
v1: https://lore.kernel.org/all/20221019195452.37606-1-helg...@kernel.org/
Changes from v1 to v2:
- Include explicitly in altera-msi and microchip,
which don't
From: Bjorn Helgaas
pcie-altera-msi.c uses irq_domain_add_linear() and related interfaces, so
it needs but doesn't include it directly; it relies on
the fact that includes it.
But pcie-altera-msi.c *doesn't* need itself. Include
directly to remove this implicit dependency so a future
patch
-20221020]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url:
> https://github.com/intel-lab-lkp/linux/commi
On Thu, Oct 20, 2022 at 08:41:01AM -0500, Bjorn Helgaas wrote:
> On Thu, Oct 20, 2022 at 04:09:37PM +0800, kernel test robot wrote:
> > Hi Bjorn,
> >
> > I love your patch! Yet something to improve:
> >
> > [auto build test ERROR on helgaas-pci/next]
> >
[+cc Pali, heads-up for trivial addition of to
pci-mvebu.c]
On Thu, Oct 20, 2022 at 08:20:25AM +0100, Conor Dooley wrote:
> On Thu, Oct 20, 2022 at 03:08:50PM +0800, kernel test robot wrote:
> > Hi Bjorn,
> >
> > I love your patch! Yet something to improve:
> >
> > >>
-20221020]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url:
> https://github.com/intel-lab-lkp/linux/commi
From: Bjorn Helgaas
Many host controller drivers #include even though they
don't need it. Remove the unnecessary #includes.
Signed-off-by: Bjorn Helgaas
---
drivers/pci/controller/cadence/pci-j721e.c | 1 -
drivers/pci/controller/dwc/pci-layerscape.c | 1 -
drivers/pci/controller/dwc
On Wed, Jul 27, 2022 at 09:32:51AM +0800, Kai-Heng Feng wrote:
> PCIe service that shares IRQ with PME may cause spurious wakeup on
> system suspend.
>
> PCIe Base Spec 5.0, section 5.2 "Link State Power Management" states
> that TLP and DLLP transmission is disabled for a Link in L2/L3 Ready
>
On Wed, Jul 27, 2022 at 09:32:52AM +0800, Kai-Heng Feng wrote:
> PCIe service that shares IRQ with PME may cause spurious wakeup on
> system suspend.
>
> Since AER is conditionally disabled in previous patch, also apply the
> same condition to disable DPC which depends on AER to work.
>
> PCIe
On Mon, Sep 26, 2022 at 10:01:55PM +0800, Zhuo Chen wrote:
> On 9/23/22 5:08 AM, Bjorn Helgaas wrote:
> > On Fri, Sep 02, 2022 at 02:16:33AM +0800, Zhuo Chen wrote:
> > > When state is pci_channel_io_frozen in pcie_do_recovery(),
> > > the severity is fatal and fat
On Mon, Sep 26, 2022 at 10:16:23PM +0800, Zhuo Chen wrote:
> On 9/23/22 5:50 AM, Bjorn Helgaas wrote:
> > On Fri, Sep 02, 2022 at 02:16:34AM +0800, Zhuo Chen wrote:
> > > Statements clearing AER error status in aer_enable_rootport() has the
> > > same function as pci_ae
On Mon, Sep 26, 2022 at 09:30:48PM +0800, Zhuo Chen wrote:
> On 9/23/22 4:02 AM, Bjorn Helgaas wrote:
> > On Mon, Sep 12, 2022 at 01:09:05AM +0800, Zhuo Chen wrote:
> > > On 9/12/22 12:22 AM, Serge Semin wrote:
> > > > On Fri, Sep 02, 2022 at 02:
On Fri, Sep 02, 2022 at 02:16:34AM +0800, Zhuo Chen wrote:
> Statements clearing AER error status in aer_enable_rootport() has the
> same function as pci_aer_raw_clear_status(). So we replace them, which
> has no functional changes.
>
> Signed-off-by: Zhuo Chen
> ---
> drivers/pci/pcie/aer.c |
On Fri, Sep 02, 2022 at 02:16:33AM +0800, Zhuo Chen wrote:
> When state is pci_channel_io_frozen in pcie_do_recovery(),
> the severity is fatal and fatal status should be cleared.
> So we add pci_aer_clear_fatal_status().
Seems sensible to me. Did you find this by code inspection or by
debugging
On Mon, Sep 12, 2022 at 01:09:05AM +0800, Zhuo Chen wrote:
> On 9/12/22 12:22 AM, Serge Semin wrote:
> > On Fri, Sep 02, 2022 at 02:16:32AM +0800, Zhuo Chen wrote:
> > > Status bits for ERR_NONFATAL errors only are cleared in
> > > pci_aer_clear_nonfatal_status(), but we want clear uncorrectable
>
On Sat, Aug 20, 2022 at 10:17:41AM +1000, Michael Ellerman wrote:
> Bjorn Helgaas writes:
> > On Sat, Aug 06, 2022 at 06:53:01PM +1000, Russell Currey wrote:
> >> I haven't touched EEH in a long time I don't have much knowledge of the
> >> subsystem at this point
6085301.25142-1-rus...@russell.cc
Signed-off-by: Russell Currey
Signed-off-by: Bjorn Helgaas
diff --git a/MAINTAINERS b/MAINTAINERS
index f60dfac7661c..51def5ac9462 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -15696,8 +15696,8 @@ F: drivers/pci/endpoint/
F: tools/pci/
PCI ENHANCED
On Sat, Jul 23, 2022 at 06:49:41AM +0900, Stafford Horne wrote:
> The definition of the pci header function pci_get_legacy_ide_irq is only
> used in platforms that support PNP. So many of the architecutres where
> it is defined do not use it. This also means we can remove
> asm-generic/pci.h as
On Mon, May 09, 2022 at 06:14:41PM +, Mohamed Khalfella wrote:
> PCI AER stats counters sysfs attributes need to iterate over
> stats counters instead of stats names. Also, added a build
> time check to make sure all counters have entries in strings
> array.
>
> Fixes: 0678e3109a3c ("PCI/AER:
On Wed, Jul 06, 2022 at 12:43:04PM +0200, Pali Rohár wrote:
> Function pci_device_from_OF_node() is used only in powermac code.
> So hide it from all other platforms as it is unsed.
s/unsed/unused/ (same typo in 3/5 patch)
These are for the powerpc folks, so I'm just kibbitzing here.
>
On Tue, Jun 21, 2022 at 10:27:31AM +0800, Kai-Heng Feng wrote:
> On Mon, Apr 18, 2022 at 10:41 AM Sathyanarayanan Kuppuswamy
> wrote:
> > On 4/8/22 8:31 AM, Kai-Heng Feng wrote:
> > > On Intel Alder Lake platforms, Thunderbolt entering D3cold can cause
> > > some errors reported by AER:
> > > [
On Mon, Jun 20, 2022 at 12:41:20PM +0200, Clément Léger wrote:
> The alloclags are always set to GFP_KERNEL so remove this specific flag.
> Moreover, this function is going to be based on one that does not
> provides passing gfp flags, so be prepared for this.
s/alloclags/allocflags/
s/provides
On Thu, Jun 09, 2022 at 08:05:26PM +0200, Pali Rohár wrote:
> On Thursday 09 June 2022 12:10:22 Bjorn Helgaas wrote:
> > On Thu, Jun 09, 2022 at 06:27:25PM +0200, Pali Rohár wrote:
> > > On Thursday 09 June 2022 11:22:55 Bjorn Helgaas wrote:
> > > > [+cc G
On Thu, Jun 09, 2022 at 06:27:25PM +0200, Pali Rohár wrote:
> On Thursday 09 June 2022 11:22:55 Bjorn Helgaas wrote:
> > [+cc Guilherme, Michael, Ben (author of 63a72284b159 and PPC folks), thread:
> > https://lore.kernel.org/r/20220504175718.29011-1-p...@kernel.org]
> >
>
[+cc Guilherme, Michael, Ben (author of 63a72284b159 and PPC folks), thread:
https://lore.kernel.org/r/20220504175718.29011-1-p...@kernel.org]
On Fri, May 06, 2022 at 12:33:02AM +0200, Pali Rohár wrote:
> On Thursday 05 May 2022 15:10:01 Tyrel Datwyler wrote:
> > On 5/5/22 02:31, Pali Rohár
On Wed, Jun 01, 2022 at 09:40:24AM +0200, Christoph Hellwig wrote:
> When a device is already unplugged by pciehp by the time that the AER
> handler is invoked, the PCIe device will lready be in the
> pci_channel_io_perm_failure state. In that case we should simply
> return
On Fri, Jun 03, 2022 at 10:12:47PM +, Mohamed Khalfella wrote:
> Is there any chance for this to land in 5.19?
Too late for v5.19, since the merge window will end in a couple days.
Remind me again if you don't see it in -next by v5.20-rc5 or so.
> On 5/10/22 14:17, Mohamed Khalfella wrote:
>
On Wed, May 11, 2022 at 05:29:45PM -0700, Sathyanarayanan Kuppuswamy wrote:
>
>
> On 5/11/22 4:40 PM, Bjorn Helgaas wrote:
> > On Mon, Apr 18, 2022 at 03:02:37PM +, Kuppuswamy Sathyanarayanan wrote:
> > > Currently the aer_irq() handler returns IRQ_NON
On Mon, Apr 18, 2022 at 03:02:37PM +, Kuppuswamy Sathyanarayanan wrote:
> Currently the aer_irq() handler returns IRQ_NONE for cases without bits
> PCI_ERR_ROOT_UNCOR_RCV or PCI_ERR_ROOT_COR_RCV are set. But this
> assumption is incorrect.
>
> Consider a scenario where aer_irq() is triggered
On Mon, Apr 18, 2022 at 03:02:37PM +, Kuppuswamy Sathyanarayanan wrote:
> Currently the aer_irq() handler returns IRQ_NONE for cases without bits
> PCI_ERR_ROOT_UNCOR_RCV or PCI_ERR_ROOT_COR_RCV are set. But this
> assumption is incorrect.
>
> Consider a scenario where aer_irq() is triggered
[+cc Rajat]
On Mon, May 09, 2022 at 06:14:41PM +, Mohamed Khalfella wrote:
> PCI AER stats counters sysfs attributes need to iterate over
> stats counters instead of stats names.
Thanks for catching this; it definitely looks like a real issue! I
guess you're probably seeing junk in the
On Thu, May 05, 2022 at 07:39:42PM +0200, Arnd Bergmann wrote:
> On Thu, May 5, 2022 at 6:10 PM Bjorn Helgaas wrote:
> > On Wed, May 04, 2022 at 11:31:28PM +0200, Arnd Bergmann wrote:
> > >
> > > The main goal is to avoid c), which is what happens on s390, but
>
On Wed, May 04, 2022 at 11:31:28PM +0200, Arnd Bergmann wrote:
> On Wed, May 4, 2022 at 11:08 PM Bjorn Helgaas wrote:
> > On Fri, Apr 29, 2022 at 03:49:59PM +0200, Niklas Schnelle wrote:
> > > We introduce a new HAS_IOPORT Kconfig option to indicate support for
> > > I
On Fri, Apr 29, 2022 at 03:49:59PM +0200, Niklas Schnelle wrote:
> We introduce a new HAS_IOPORT Kconfig option to indicate support for
> I/O Port access. In a future patch HAS_IOPORT=n will disable compilation
> of the I/O accessor functions inb()/outb() and friends on architectures
> which can
On Thu, Apr 28, 2022 at 05:31:38PM -0500, Nathan Lynch wrote:
> Bjorn Helgaas writes:
> > On Tue, Apr 26, 2022 at 11:07:39PM +0530, Mahesh Salgaonkar wrote:
> >> +/*
> >> + * RTAS call get-sensor-state(DR_ENTITY_SENSE) return values as per PAPR:
> >> + *
On Tue, Apr 26, 2022 at 11:07:39PM +0530, Mahesh Salgaonkar wrote:
> When certain PHB HW failure causes phyp to recover PHB, it marks the PE
> state as temporarily unavailable until recovery is complete. This also
> triggers an EEH handler in Linux which needs to notify drivers, and perform
>
On Mon, Apr 25, 2022 at 11:32:54AM -0700, David E. Box wrote:
> On Sat, 2022-04-23 at 10:01 -0500, Bjorn Helgaas wrote:
> > On Sat, Apr 23, 2022 at 12:43:14AM +, Jingar, Rajvi wrote:
> > > > -Original Message-
> > > > From: Bjorn Helgaas
> >
On Fri, Apr 22, 2022 at 10:48:28AM -0700, Jakub Kicinski wrote:
> On Fri, 15 Apr 2022 14:08:10 -0500 Bjorn Helgaas wrote:
> > From: Bjorn Helgaas
> >
> > Only alpha, ia64, powerpc, and sh define SLOW_DOWN_IO, and there are no
> > actual uses of it. The few referen
On Sat, Apr 23, 2022 at 12:43:14AM +, Jingar, Rajvi wrote:
> > -Original Message-
> > From: Bjorn Helgaas
> > On Thu, Apr 14, 2022 at 07:54:02PM +0200, Rafael J. Wysocki wrote:
> > > On 3/25/2022 8:50 PM, Rajvi Jingar wrote:
> > > > For the
[+cc Rafael, linux-pm; sorry forgot this last time]
On Fri, Apr 22, 2022 at 05:24:36PM -0500, Bjorn Helgaas wrote:
> On Fri, Apr 08, 2022 at 11:31:58PM +0800, Kai-Heng Feng wrote:
> > On Intel Alder Lake platforms, Thunderbolt entering D3cold can cause
> > some errors
[+cc other folks interested in PTM from
https://lore.kernel.org/r/20220408153159.106741-1-kai.heng.f...@canonical.com]
On Thu, Apr 14, 2022 at 07:54:02PM +0200, Rafael J. Wysocki wrote:
> On 3/25/2022 8:50 PM, Rajvi Jingar wrote:
> > For the PCIe devices (like nvme) that do not go into D3 state
[+cc Rajvi, David]
On Fri, Apr 08, 2022 at 11:31:58PM +0800, Kai-Heng Feng wrote:
> On Intel Alder Lake platforms, Thunderbolt entering D3cold can cause
> some errors reported by AER:
> [ 30.100211] pcieport :00:1d.0: AER: Uncorrected (Non-Fatal) error
> received: :00:1d.0
> [
From: Bjorn Helgaas
Remove unused __SLOW_DOWN_IO and SLOW_DOWN_IO definitions.
Signed-off-by: Bjorn Helgaas
---
arch/alpha/include/asm/io.h | 4
1 file changed, 4 deletions(-)
diff --git a/arch/alpha/include/asm/io.h b/arch/alpha/include/asm/io.h
index c9cb554fbe54..338dd24400bd 100644
From: Bjorn Helgaas
Remove unused __SLOW_DOWN_IO and SLOW_DOWN_IO definitions.
Signed-off-by: Bjorn Helgaas
---
arch/ia64/include/asm/io.h | 4
1 file changed, 4 deletions(-)
diff --git a/arch/ia64/include/asm/io.h b/arch/ia64/include/asm/io.h
index 6d93b923b379..1069e1730b2e 100644
From: Bjorn Helgaas
Remove unused SLOW_DOWN_IO definition.
Signed-off-by: Bjorn Helgaas
---
arch/powerpc/include/asm/io.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/powerpc/include/asm/io.h b/arch/powerpc/include/asm/io.h
index fee979d3a1aa..c5a5f7c9b231 100644
--- a/arch
From: Bjorn Helgaas
Signed-off-by: Bjorn Helgaas
---
drivers/atm/nicstarmac.c | 5 -
drivers/net/ethernet/dec/tulip/winbond-840.c | 2 --
drivers/net/ethernet/natsemi/natsemi.c | 2 --
3 files changed, 9 deletions(-)
diff --git a/drivers/atm/nicstarmac.c b
From: Bjorn Helgaas
io.h defines SLOW_DOWN_IO only when CONF_SLOWDOWN_IO is defined, but
CONF_SLOWDOWN_IO is never defined and is in fact explicitly undefined.
Remove SLOW_DOWN_IO and related code.
N.B. 37b7a97884ba ("sh: machvec IO death.") went to some trouble to add
CONF_S
From: Bjorn Helgaas
atp.h is included only by atp.c, which does not use eeprom_delay(). Remove
the unused definition.
Signed-off-by: Bjorn Helgaas
---
drivers/net/ethernet/realtek/atp.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/net/ethernet/realtek/atp.h
b/drivers/net
From: Bjorn Helgaas
lmc_var.h is included only by files in drivers/net/wan/lmc/, and none of
them uses DELAY(). Remove the unused definition and related comments.
Signed-off-by: Bjorn Helgaas
---
drivers/net/wan/lmc/lmc_main.c | 8
drivers/net/wan/lmc/lmc_var.h | 8
2
From: Bjorn Helgaas
Only alpha, ia64, powerpc, and sh define SLOW_DOWN_IO, and there are no
actual uses of it. The few references to it are in situations that are
themselves unused. Remove them all.
It should be safe to apply these independently and in any order. The only
place SLOW_DOWN_IO
On Sat, Apr 02, 2022 at 12:11:56PM +0200, Christophe Leroy wrote:
> powerpc's asm/prom.h brings some headers that it doesn't
> need itself.
>
> In order to clean it up, first add missing headers in
> users of asm/prom.h
>
> Signed-off-by: Christophe Leroy
I tidied the subject line to match
On Thu, Mar 10, 2022 at 09:51:13AM +0100, Christophe Leroy wrote:
> Le 13/07/2021 à 02:25, Krzysztof Wilczyński a écrit :
> > The pcie_reset_state_t type has been introduced in the commit
> > f7bdd12d234d ("pci: New PCI-E reset API") along with the enum
> > pcie_reset_state, but it has never been
On Mon, Mar 14, 2022 at 09:21:46AM -0700, Eric Badger wrote:
> On Sun, Mar 13, 2022 at 02:43:14PM -0700, Raj, Ashok wrote:
> > On Sun, Mar 13, 2022 at 02:52:20PM -0500, Bjorn Helgaas wrote:
> > > On Fri, Mar 11, 2022 at 02:58:07AM +, Kuppuswamy Sathyanarayanan
> > &g
On Fri, Mar 11, 2022 at 02:58:07AM +, Kuppuswamy Sathyanarayanan wrote:
> Currently the aer_irq() handler returns IRQ_NONE for cases without bits
> PCI_ERR_ROOT_UNCOR_RCV or PCI_ERR_ROOT_COR_RCV are set. But this
> assumption is incorrect.
>
> Consider a scenario where aer_irq() is triggered
On Thu, Mar 10, 2022 at 06:09:51PM +, Christophe Leroy wrote:
>
>
> Le 10/03/2022 à 17:52, Bjorn Helgaas a écrit :
> > On Wed, Mar 09, 2022 at 06:44:35PM +0100, Christophe Leroy wrote:
> >> Today drivers/pci/controller/pci-xgene.c defines SZ_1T
> >>
&
33942bf.1642752946.git.christophe.le...@csgroup.eu
> Signed-off-by: Christophe Leroy
> Signed-off-by: Lorenzo Pieralisi
> Reviewed-by: Krzysztof Wilczyński
> Acked-by: Bjorn Helgaas
> Cc: Toan Le
> Cc: linux-...@vger.kernel.org
> ---
> This patch is already in linux-next but not
I guess this needs to go with the [2/2] patch, since it also uses
SZ_1T.
Acked-by: Bjorn Helgaas
> ---
> drivers/pci/controller/pci-xgene.c | 1 -
> include/linux/sizes.h | 2 ++
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/
On Mon, Dec 13, 2021 at 11:57:52AM -0800, Rajat Jain wrote:
> Hello
>
> On Sat, Dec 11, 2021 at 9:54 AM Bjorn Helgaas wrote:
> >
> > [+cc Rajat, author of aer_stats:
> > db89ccbe52c7 ("PCI/AER: Define aer_stats structure for AER capable devices"
> > 8
[+cc Rajat, author of aer_stats:
db89ccbe52c7 ("PCI/AER: Define aer_stats structure for AER capable devices"
81aa5206f9a7 ("PCI/AER: Add sysfs attributes to provide AER stats and
breakdown"]
On Thu, Dec 09, 2021 at 05:45:56PM +0800, Jiasheng Jiang wrote:
> he return value of kzalloc() needs to
On Mon, Dec 06, 2021 at 11:28:00PM +0100, Thomas Gleixner wrote:
> The irqdomain code already returns the information. Move the loop to the
> legacy code.
>
> Signed-off-by: Thomas Gleixner
> Tested-by: Juergen Gross
> Reviewed-by: Jason Gunthorpe
Acked-by: Bjorn Helgaas
oss
> Reviewed-by: Jason Gunthorpe
Acked-by: Bjorn Helgaas# PCI
> ---
> drivers/pci/msi/irqdomain.c | 13 -
> include/linux/msi.h |5 +
> kernel/irq/msi.c| 29 +
> 3 files changed, 26 insertions(+), 21 de
On Mon, Dec 06, 2021 at 11:27:57PM +0100, Thomas Gleixner wrote:
> No users outside of that file.
>
> Signed-off-by: Thomas Gleixner
> Tested-by: Juergen Gross
> Reviewed-by: Jason Gunthorpe
Acked-by: Bjorn Helgaas
> ---
> drivers/pci/msi/irqdomain.c |5 +++--
&
On Mon, Dec 06, 2021 at 11:27:56PM +0100, Thomas Gleixner wrote:
> It's only required for PCI/MSI. So no point in having it in every struct
> device.
>
> Signed-off-by: Thomas Gleixner
Acked-by: Bjorn Helgaas
> ---
> V2: New patch
> ---
> drivers/base/core.c|
esciptors/descriptors/
> Store the mapping in struct pci_dev and free it after freeing the MSI-X
> descriptors.
>
> Signed-off-by: Thomas Gleixner
> Tested-by: Juergen Gross
> Reviewed-by: Jason Gunthorpe
Acked-by: Bjorn Helgaas
> ---
> drivers/pci/msi/msi.c | 18
On Mon, Dec 06, 2021 at 11:27:52PM +0100, Thomas Gleixner wrote:
> Move the irqdomain specific code into it's own file.
s/it's/its/
> Signed-off-by: Thomas Gleixner
> Tested-by: Juergen Gross
> Reviewed-by: Jason Gunthorpe
Acked-by: Bjorn Helgaas
> ---
> drivers/pci/msi/
On Mon, Dec 06, 2021 at 11:27:51PM +0100, Thomas Gleixner wrote:
> Split out the non irqdomain code into its own file.
>
> Signed-off-by: Thomas Gleixner
> Tested-by: Juergen Gross
> Reviewed-by: Jason Gunthorpe
Acked-by: Bjorn Helgaas
> ---
> V2: Add proper includes
On Mon, Dec 06, 2021 at 11:27:49PM +0100, Thomas Gleixner wrote:
> These functions are required even when CONFIG_PCI_MSI is not set. Move them
> to their own file.
>
> Signed-off-by: Thomas Gleixner
> Tested-by: Juergen Gross
> Reviewed-by: Jason Gunthorpe
Acked
nthorpe
Acked-by: Bjorn Helgaas
> ---
> Documentation/driver-api/pci/pci.rst |2
> drivers/pci/Makefile |3
> drivers/pci/msi.c| 1532
> ---
> drivers/pci/msi/Makefile
Gunthorpe
Acked-by: Bjorn Helgaas
> ---
> drivers/pci/msi.c |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- a/drivers/pci/msi.c
> +++ b/drivers/pci/msi.c
> @@ -642,8 +642,8 @@ static void msix_update_entries(struct p
> {
> struct msi_de
On Mon, Dec 06, 2021 at 11:27:44PM +0100, Thomas Gleixner wrote:
> Get rid of the pile of unneeded includes which accumulated over time.
>
> Signed-off-by: Thomas Gleixner
> Tested-by: Juergen Gross
> Reviewed-by: Jason Gunthorpe
Acked-by: Bjorn Helgaas
Nice, thanks!
>
-by: Juergen Gross
> Reviewed-by: Jason Gunthorpe
> Cc: x...@kernel.org
> Cc: xen-de...@lists.xenproject.org
> Cc: Christian Borntraeger
> Cc: Heiko Carstens
Acked-by: Bjorn Helgaas# PCI
> ---
> arch/s390/pci/pci_irq.c |4 +-
> arch/x86/include/a
On Mon, Dec 06, 2021 at 11:27:36PM +0100, Thomas Gleixner wrote:
> instead of fiddling with msi descriptors.
>
> Signed-off-by: Thomas Gleixner
> Tested-by: Juergen Gross
> Reviewed-by: Jason Gunthorpe
Acked-by: Bjorn Helgaas
s/msi/MSI/ above if you have a chance. Nice
101 - 200 of 857 matches
Mail list logo
