Re: [PATCH] misc: ibmvsm: Fix wrong assignment of return code

2018-08-07 Thread Bryant G. Ly
On 8/7/18 7:28 AM, Michael Ellerman wrote: > "Bryant G. Ly" writes: > >> From: "Bryant G. Ly" >> >> Currently the assignment is flipped and rc is always 0. > If you'd left rc uninitialised at the start of the function the compil

[PATCH] misc: ibmvsm: Fix wrong assignment of return code

2018-08-06 Thread Bryant G. Ly
From: "Bryant G. Ly" Currently the assignment is flipped and rc is always 0. Signed-off-by: Bryant G. Ly Reviewed-by: Bradley Warrum --- drivers/misc/ibmvmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/ibmvmc.c b/drivers/misc/ibmvmc.c ind

Re: [PATCH v3 1/1] powerpc/pseries: fix EEH recovery of some IOV devices

2018-07-30 Thread Bryant G. Ly
file changed, 17 insertions(+), 8 deletions(-) > > diff --git a/arch/powerpc/platforms/pseries/setup.c > b/arch/powerpc/platforms/pseries/setup.c > index b55ad4286dc7..0a9e4243ae1d 100644 > --- a/arch/powerpc/platforms/pseries/setup.c > +++ b/arch/powerpc/platforms/pseries/setup.c > @@ -645,6 +645,15 @@ void of_pci_parse_iov_addrs(struct pci_dev *dev, const > int *indexes) > } > } Reviewed-by: Bryant G. Ly

Re: [PATCH v2 1/1] powerpc/pseries: fix EEH recovery of some IOV devices

2018-05-30 Thread Bryant G. Ly
gt; - if (!indexes) > - return; > - /* Assign the addresses from device tree*/ > - of_pci_parse_iov_addrs(pdev, indexes); > + if (indexes) > + of_pci_parse_iov_addrs(pdev, indexes); > + else > + pseries_disable_sriov_resources(pdev); > } > > static resource_size_t pseries_pci_iov_resource_alignment(struct pci_dev > *pdev, Acked-by: Bryant G. Ly

[PATCH v2 1/1] misc: IBM Virtual Management Channel Driver (VMC)

2018-04-25 Thread Bryant G. Ly
Virtual Management Channel Virtual Adapter on the PowerPC platform. It provides a character device which allows for both request/response and async message support through the /dev/ibmvmc node. Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> Reviewed-by: Steven Royer

[PATCH v2 0/1] misc: IBM Virtual Management Channel Driver (VMC)

2018-04-25 Thread Bryant G. Ly
changes in documentation per request from Randy. - Clarified Documentation based upon Linus Walleij's comments - Fixed kbuild warning in regards to unititialized use of rc Bryant G. Ly (1): misc: IBM Virtual Management Channel Driver (VMC) Documentation/ioctl/ioctl-number.txt |1

Re: [PATCH v1 1/1] misc: IBM Virtual Management Channel Driver

2018-04-23 Thread Bryant G. Ly
On 4/23/18 2:53 PM, Greg KH wrote: > On Mon, Apr 23, 2018 at 11:38:18AM -0700, Randy Dunlap wrote: >> On 04/23/18 07:46, Bryant G. Ly wrote: >>> This driver is a logical device which provides an >>> interface between the hypervisor and a management >>> partitio

[PATCH v1 1/1] misc: IBM Virtual Management Channel Driver

2018-04-23 Thread Bryant G. Ly
/ibmvmc node. Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> Reviewed-by: Steven Royer <sero...@linux.vnet.ibm.com> Reviewed-by: Adam Reznechek <adrez...@linux.vnet.ibm.com> Tested-by: Taylor Jakobson <tjak...@us.ibm.com> Tested-by: Brad Warrum <bwar...@us.ibm.

[PATCH v1 0/1] misc: IBM Virtual Management Channel Driver

2018-04-23 Thread Bryant G. Ly
instead of pr_dbg - Change to misc class - Fixed memory barrier usages - Addressed styling, checkpatch, renaming of functions - General fixes to the driver to make it more inline with existing upstream drivers. Bryant G. Ly (1): misc: IBM Virtual Management Channel Driver Documentation/ioctl

[PATCH] tty:hvcs: Move Assignment for hvcsd->port.count

2018-04-02 Thread Bryant G. Ly
Move the assignment out of hvcsd->port.count from within the if () block so this patch fixes it. It is bad practice to have assignments within an if () block. Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> --- drivers/tty/hvc/hvcs.c | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [PATCH] PCI/AER: Move pci_uevent_ers() out of pci.h

2018-02-23 Thread Bryant G. Ly
On 2/22/18 10:10 PM, Michael Ellerman wrote: > Bjorn Helgaas <helg...@kernel.org> writes: > >> On Thu, Feb 08, 2018 at 09:05:45AM -0600, Bryant G. Ly wrote: >>> On 2/8/18 6:20 AM, Michael Ellerman wrote: >>> >>>> There's no reason pci_uevent_ers()

Re: [PATCH] PCI/AER: Add a null check before eeh_ops->notify_resume callback.

2018-02-22 Thread Bryant G. Ly
v_traverse+0x98/0x170 > eeh_handle_normal_event+0x3f4/0x650 > eeh_handle_event+0x188/0x380 > eeh_event_handler+0x208/0x210 > kthread+0x168/0x1b0 > ret_from_kernel_thread+0x5c/0xb4 > > Cc: Bryant G. Ly <bryan...@linux.vnet.ibm.com> > Fixes: 856e1eb9bdd4("PCI/AER: Add

[PATCH] powerpc/eeh: Add conditional check on notify_resume

2018-02-15 Thread Bryant G. Ly
Juan J. Alvarez <jjalv...@linux.vnet.ibm.com> Reviewed-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> Tested-by: Carol L. Soto <cls...@us.ibm.com> --- arch/powerpc/kernel/eeh_driver.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/

Re: [PATCH] PCI/AER: Move pci_uevent_ers() out of pci.h

2018-02-08 Thread Bryant G. Ly
| 38 +++--- > 2 files changed, 39 insertions(+), 35 deletions(-) Looks good, thanks for fixing it! Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> -Bryant

Re: [PATCH v4 3/7] platforms/pseries: Set eeh_pe of EEH_PE_VF type

2018-01-24 Thread Bryant G. Ly
On 1/23/18 7:14 PM, Michael Ellerman wrote: > "Bryant G. Ly" <bryan...@linux.vnet.ibm.com> writes: > >> To correctly use EEH code one has to make >> sure that the EEH_PE_VF is set for dynamic created >> VFs. Therefore this patch allocates an eeh_pe of

Re: [PATCH v4 0/7] SR-IOV Enablement on PowerVM

2018-01-17 Thread Bryant G. Ly
Mike Ellerman/Ben, Do you know if we can make 4.16 with this? -Bryant On 1/5/18 10:45 AM, Bryant G. Ly wrote: > This patch series will enable SR-IOV on PowerVM. A specific set of > lids for PFW/PHYP is required. They are planned to release with > 920 at the moment. > > F

[PATCH v4 1/7] platform/pseries: Update VF config space after EEH

2018-01-05 Thread Bryant G. Ly
Add EEH platform operations for pseries to update VF config space. With this change after EEH, the VF will have updated config space for pseries platform. Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> Signed-off-by: Juan J. Alvarez <jjalv...@linux.vnet.ibm.com> ---

[PATCH v4 3/7] platforms/pseries: Set eeh_pe of EEH_PE_VF type

2018-01-05 Thread Bryant G. Ly
To correctly use EEH code one has to make sure that the EEH_PE_VF is set for dynamic created VFs. Therefore this patch allocates an eeh_pe of eeh type EEH_PE_VF and associates PE with parent. Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> Signed-off-by: Juan J. Alvarez

[PATCH v4 6/7] pseries/pci: Associate PEs to VFs in configure SR-IOV

2018-01-05 Thread Bryant G. Ly
After initial validation of SR-IOV resources, firmware will associate PEs to the dynamic VFs created within this call. This patch adds the association of PEs to the PF array of PE numbers indexed by VF. Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> Signed-off-by: Juan J. A

[PATCH v4 4/7] powerpc/kernel Add EEH operations to notify resume

2018-01-05 Thread Bryant G. Ly
. Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> Signed-off-by: Juan J. Alvarez <jjalv...@linux.vnet.ibm.com> --- arch/powerpc/include/asm/eeh.h | 1 + arch/powerpc/platforms/powernv/eeh-powernv.c | 3 +- arch/powerpc/platforms/pseries/eeh_ps

[PATCH v4 2/7] linux/pci: Add uevents in AER and EEH error/resume

2018-01-05 Thread Bryant G. Ly
-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> Signed-off-by: Juan J. Alvarez <jjalv...@linux.vnet.ibm.com> Acked-by: Bjorn Helgaas <bhelg...@google.com> --- arch/powerpc/kernel/eeh_driver.c | 6 ++ drivers/pci/pcie/aer/aerdrv_core.c | 3 +++ include/linux/pci.h

[PATCH v4 0/7] SR-IOV Enablement on PowerVM

2018-01-05 Thread Bryant G. Ly
and change log per Bjorn's comments and fixed Alexey's comments Bryant G. Ly (7): platform/pseries: Update VF config space after EEH linux/pci: Add uevents in AER and EEH error/resume platforms/pseries: Set eeh_pe of EEH_PE_VF type powerpc/kernel Add EEH operations to notify resume powerpc

[PATCH v4 7/7] pseries/setup: Add Initialization of VF Bars

2018-01-05 Thread Bryant G. Ly
When enabling SR-IOV in pseries platform, the VF bar properties for a PF are reported on the device node in the device tree. This patch adds the IOV Bar resources to Linux structures from the device tree for later use when configuring SR-IOV by PF driver. Signed-off-by: Bryant G. Ly <br

[PATCH v4 5/7] powerpc/kernel: Add EEH notify resume sysfs

2018-01-05 Thread Bryant G. Ly
Introduce a method for notify resume to be called from sysfs. In this patch one can now call notify resume from sysfs when is supported by platform. Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> Signed-off-by: Juan J. Alvarez <jjalv...@linux.vnet.ibm.com> --- arch/po

[PATCH v3 5/7] powerpc/kernel: Add EEH notify resume sysfs

2018-01-03 Thread Bryant G. Ly
Introduce a method for notify resume to be called from sysfs. In this patch one can now call notify resume from sysfs when is supported by platform. Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> Signed-off-by: Juan J. Alvarez <jjalv...@linux.vnet.ibm.com> --- arch/po

[PATCH v3 6/7] pseries/pci: Associate PEs to VFs in configure SR-IOV

2018-01-03 Thread Bryant G. Ly
After initial validation of SR-IOV resources, firmware will associate PEs to the dynamic VFs created within this call. This patch adds the association of PEs to the PF array of PE numbers indexed by VF. Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> Signed-off-by: Juan J. A

[PATCH v3 1/7] platform/pseries: Update VF config space after EEH

2018-01-03 Thread Bryant G. Ly
Add EEH platform operations for pseries to update VF config space. With this change after EEH, the VF will have updated config space for pseries platform. Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> Signed-off-by: Juan J. Alvarez <jjalv...@linux.vnet.ibm.com> ---

[PATCH v3 7/7] pseries/setup: Add Initialization of VF Bars

2018-01-03 Thread Bryant G. Ly
When enabling SR-IOV in pseries platform, the VF bar properties for a PF are reported on the device node in the device tree. This patch adds the IOV Bar resources to Linux structures from the device tree for later use when configuring SR-IOV by PF driver. Signed-off-by: Bryant G. Ly <br

[PATCH v3 4/7] powerpc/kernel Add EEH operations to notify resume

2018-01-03 Thread Bryant G. Ly
. Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> Signed-off-by: Juan J. Alvarez <jjalv...@linux.vnet.ibm.com> --- arch/powerpc/include/asm/eeh.h | 1 + arch/powerpc/platforms/powernv/eeh-powernv.c | 3 +- arch/powerpc/platforms/pseries/eeh_ps

[PATCH v3 3/7] platforms/pseries: Set eeh_pe of EEH_PE_VF type

2018-01-03 Thread Bryant G. Ly
To correctly use EEH code one has to make sure that the EEH_PE_VF is set for dynamic created VFs. Therefore this patch allocates an eeh_pe of eeh type EEH_PE_VF and associates PE with parent. Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> Signed-off-by: Juan J. Alvarez

[PATCH v3 2/7] powerpc/kernel: Add uevents in EEH error/resume

2018-01-03 Thread Bryant G. Ly
G. Ly <bryan...@linux.vnet.ibm.com> Signed-off-by: Juan J. Alvarez <jjalv...@linux.vnet.ibm.com> --- arch/powerpc/kernel/eeh_driver.c | 8 ++-- drivers/pci/pcie/aer/aerdrv_core.c | 3 +++ include/linux/pci.h| 36 3 files

[PATCH v3 0/7] SR-IOV Enablement on PowerVM

2018-01-03 Thread Bryant G. Ly
the tests. This patch depends on the three patches: 988fc3ba5653278a8c14d6ccf687371775930d2b dae7253f9f78a731755ca20c66b2d2c40b86baea 608c0d8804ef3ca4cda8ec6ad914e47deb283d7b v1 - Initial Patch v2 - Addressed Alexey and Russell's comments v3 - Unify the call of .error_detected() Bryant G. Ly (7

[PATCH v2 7/7] pseries/setup: Add Initialization of VF Bars

2017-12-18 Thread Bryant G. Ly
When enabling SR-IOV in pseries platform, the VF bar properties for a PF are reported on the device node in the device tree. This patch adds the IOV Bar resources to Linux structures from the device tree for later use when configuring SR-IOV by PF driver. Signed-off-by: Bryant G. Ly <br

[PATCH v2 6/7] pseries/pci: Associate PEs to VFs in configure SR-IOV

2017-12-18 Thread Bryant G. Ly
After initial validation of SR-IOV resources, firmware will associate PEs to the dynamic VFs created within this call. This patch adds the association of PEs to the PF array of PE numbers indexed by VF. Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> Signed-off-by: Juan J. A

[PATCH v2 1/7] platform/pseries: Update VF config space after EEH

2017-12-18 Thread Bryant G. Ly
Add EEH platform operations for pseries to update VF config space. With this change after EEH, the VF will have updated config space for pseries platform. Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> Signed-off-by: Juan J. Alvarez <jjalv...@linux.vnet.ibm.com> ---

[PATCH v2 5/7] powerpc/kernel: Add EEH notify resume sysfs

2017-12-18 Thread Bryant G. Ly
Introduce a method for notify resume to be called from sysfs. In this patch one can now call notify resume from sysfs when is supported by platform. Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> Signed-off-by: Juan J. Alvarez <jjalv...@linux.vnet.ibm.com> --- arch/po

[PATCH v2 2/7] powerpc/kernel: Add uevents in EEH error/resume

2017-12-18 Thread Bryant G. Ly
G. Ly <bryan...@linux.vnet.ibm.com> Signed-off-by: Juan J. Alvarez <jjalv...@linux.vnet.ibm.com> --- arch/powerpc/kernel/eeh_driver.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/powerpc/kernel/eeh_driver.c b/arch/powerpc/kernel/eeh_driver.c index 3c0fa99c5533..

[PATCH v2 3/7] platforms/pseries: Set eeh_pe of EEH_PE_VF type

2017-12-18 Thread Bryant G. Ly
To correctly use EEH code one has to make sure that the EEH_PE_VF is set for dynamic created VFs. Therefore this patch allocates an eeh_pe of eeh type EEH_PE_VF and associates PE with parent. Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> Signed-off-by: Juan J. Alvarez

[PATCH v2 4/7] powerpc/kernel Add EEH operations to notify resume

2017-12-18 Thread Bryant G. Ly
. Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> Signed-off-by: Juan J. Alvarez <jjalv...@linux.vnet.ibm.com> --- arch/powerpc/include/asm/eeh.h | 1 + arch/powerpc/kernel/eeh_driver.c | 3 + arch/powerpc/platforms/powernv/eeh-powernv.c | 3 +-

[PATCH v1 0/7] SR-IOV Enablement on PowerVM

2017-12-18 Thread Bryant G. Ly
the tests. This patch depends on the three patches: 988fc3ba5653278a8c14d6ccf687371775930d2b dae7253f9f78a731755ca20c66b2d2c40b86baea 608c0d8804ef3ca4cda8ec6ad914e47deb283d7b v1 - Initial Patch v2 - Addressed Alexey and Russell's comments Bryant G. Ly (7): platform/pseries: Update VF config space after

Re: [PATCH v1 2/7] powerpc/kernel: Add uevents in EEH error/resume

2017-12-18 Thread Bryant G. Ly
On 12/17/17 9:54 PM, Alexey Kardashevskiy wrote: > On 14/12/17 02:32, Bryant G. Ly wrote: >> Devices can go offline when EEH is reported. This patch adds >> a change to the kernel object and lets udev know of error. >> When device resumes a change is also set reportin

[PATCH v1 2/7] powerpc/kernel: Add uevents in EEH error/resume

2017-12-13 Thread Bryant G. Ly
G. Ly <bryan...@linux.vnet.ibm.com> Signed-off-by: Juan J. Alvarez <jjalv...@linux.vnet.ibm.com> --- arch/powerpc/kernel/eeh_driver.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/eeh_driver.c b/arch/powerpc/kernel/eeh_driver.c index

[PATCH v1 6/7] pseries/pci: Associate PEs to VFs in configure SR-IOV

2017-12-13 Thread Bryant G. Ly
After initial validation of SR-IOV resources, firmware will associate PEs to the dynamic VFs created within this call. This patch adds the association of PEs to the PF array of PE numbers indexed by VF. Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> Signed-off-by: Juan J. A

[PATCH v1 7/7] pseries/setup: Add Initialization of VF Bars

2017-12-13 Thread Bryant G. Ly
When enabling SR-IOV in pseries platform, the VF bar properties for a PF are reported on the device node in the device tree. This patch adds the IOV Bar resources to Linux structures from the device tree for later use when configuring SR-IOV by PF driver. Signed-off-by: Bryant G. Ly <br

[PATCH v1 4/7] powerpc/kernel Add EEH operations to notify resume

2017-12-13 Thread Bryant G. Ly
. Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> Signed-off-by: Juan J. Alvarez <jjalv...@linux.vnet.ibm.com> --- arch/powerpc/include/asm/eeh.h | 1 + arch/powerpc/kernel/eeh_driver.c | 4 ++ arch/powerpc/platforms/powernv/eeh-powernv.c |

[PATCH v1 5/7] powerpc/kernel: Add EEH notify resume sysfs

2017-12-13 Thread Bryant G. Ly
Introduce a method for notify resume to be called from sysfs. In this patch one can now call notify resume from sysfs when is supported by platform. Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> Signed-off-by: Juan J. Alvarez <jjalv...@linux.vnet.ibm.com> --- arch/po

[PATCH v1 3/7] platforms/pseries: Set eeh_pe of EEH_PE_VF type

2017-12-13 Thread Bryant G. Ly
To correctly use EEH code one has to make sure that the EEH_PE_VF is set for dynamic created VFs. Therefore this patch allocates an eeh_pe of eeh type EEH_PE_VF and associates PE with parent. Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> Signed-off-by: Juan J. Alvarez

[PATCH v1 1/7] platform/pseries: Update VF config space after EEH

2017-12-13 Thread Bryant G. Ly
Add EEH platform operations for pseries to update VF config space. With this change after EEH, the VF will have updated config space for pseries platform. Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> Signed-off-by: Juan J. Alvarez <jjalv...@linux.vnet.ibm.com> ---

[PATCH v1 0/7] SR-IOV Enablement on PowerVM

2017-12-13 Thread Bryant G. Ly
the tests. This patch depends on the three patches: 988fc3ba5653278a8c14d6ccf687371775930d2b dae7253f9f78a731755ca20c66b2d2c40b86baea 608c0d8804ef3ca4cda8ec6ad914e47deb283d7b Bryant G. Ly (7): platform/pseries: Update VF config space after EEH powerpc/kernel: Add uevents in EEH error/resume

Re: [PATCH v5 0/3] Prepartion for SR-IOV PowerVM Enablement

2017-12-08 Thread Bryant G. Ly
On 12/8/17 12:03 AM, Alexey Kardashevskiy wrote: > On 06/12/17 02:13, Bryant G. Ly wrote: >> >> On 12/4/17 7:24 PM, Alexey Kardashevskiy wrote: >>> On 05/12/17 02:08, Bryant G. Ly wrote: >>>> On 12/2/17 7:45 PM, Alexey Kardashevskiy wrote: >>>>&g

Re: [PATCH v5 0/3] Prepartion for SR-IOV PowerVM Enablement

2017-12-05 Thread Bryant G. Ly
On 12/4/17 7:24 PM, Alexey Kardashevskiy wrote: > On 05/12/17 02:08, Bryant G. Ly wrote: >> >> On 12/2/17 7:45 PM, Alexey Kardashevskiy wrote: >>> On 10/11/17 01:00, Bryant G. Ly wrote: >>>> v1 - Initial patch >>>> v2 - Addressed Bjorn's comment o

Re: [PATCH v5 0/3] Prepartion for SR-IOV PowerVM Enablement

2017-12-04 Thread Bryant G. Ly
On 12/2/17 7:45 PM, Alexey Kardashevskiy wrote: > On 10/11/17 01:00, Bryant G. Ly wrote: >> v1 - Initial patch >> v2 - Addressed Bjorn's comment on creating a highly platform >> dependent global exported symbol. >> v3 - Based patch off linux-ppc/mas

Re: [PATCH v5 0/3] Prepartion for SR-IOV PowerVM Enablement

2017-11-29 Thread Bryant G. Ly
On 11/9/17 8:00 AM, Bryant G. Ly wrote: > v1 - Initial patch > v2 - Addressed Bjorn's comment on creating a highly platform > dependent global exported symbol. > v3 - Based patch off linux-ppc/master > v4 - Using the sriov-drivers_autoprobe mechanism per Bjorn's reque

Re: [PATCH] ibmveth: Kernel crash LSO offload flag toggle

2017-11-15 Thread Bryant G. Ly
On 11/14/17 8:47 PM, Daniel Axtens wrote: > Hi Bryant, > > This looks a bit better, but... > >> The following patch ensures that the bounce_buffer is not null >> prior to using it within skb_copy_from_linear_data. > How would this occur? > > Looking at ibmveth.c, I see bounce_buffer being freed

[PATCH] ibmveth: Kernel crash LSO offload flag toggle

2017-11-14 Thread Bryant G. Ly
914564] [c000feab3f30] [c004563c] start_secondary+0x33c/0x360 [76563.914572] [c000feab3f90] [c0008b6c] start_secondary_prolog+0x10/0x14 Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> Signed-off-by: Sivakumar Krishnasamy <ks...@linux.vnet.ibm.com> Cc: <s

Re: [PATCH] ibmveth: Kernel crash LSO offload flag toggle

2017-11-14 Thread Bryant G. Ly
On 11/13/17 7:07 PM, Daniel Axtens wrote: > Hi Bryant, > > A few things: > > 1) The commit message could probably be trimmed, especially the stack > traces. Yes, I can trim it. > 2) What exactly are you changing and why does it fix the issue? I > couldn't figure that out from the commit

[PATCH] ibmveth: Kernel crash LSO offload flag toggle

2017-11-13 Thread Bryant G. Ly
Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> Cc: <sta...@vger.kernel.org> # 4.14+ --- drivers/net/ethernet/ibm/ibmveth.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/i

[PATCH v5 3/3] PCI/IOV: Add pci_vf_drivers_autoprobe() interface

2017-11-09 Thread Bryant G. Ly
Add a pci_vf_drivers_autoprobe() interface. Setting autoprobe to false on the PF prevents drivers from binding to VFs when they are enabled. Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> Signed-off-by: Juan J. Alvarez <jjalv...@linux.vnet.ibm.com> Acked-by: Bjorn He

[PATCH v5 2/3] pseries: Add PSeries SR-IOV Machine dependent calls

2017-11-09 Thread Bryant G. Ly
Add calls for PSeries platform to configure/deconfigure SR-IOV. Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> Signed-off-by: Juan J. Alvarez <jjalv...@us.ibm.com> --- arch/powerpc/platforms/pseries/eeh_pseries.c | 24 +++ arch/powerpc/platforms/p

[PATCH v5 0/3] Prepartion for SR-IOV PowerVM Enablement

2017-11-09 Thread Bryant G. Ly
v1 - Initial patch v2 - Addressed Bjorn's comment on creating a highly platform dependent global exported symbol. v3 - Based patch off linux-ppc/master v4 - Using the sriov-drivers_autoprobe mechanism per Bjorn's request v5 - Fixed comments and commit message Bryant G. Ly (3): powerpc

[PATCH v5 1/3] powerpc/kernel: Separate SR-IOV Calls

2017-11-09 Thread Bryant G. Ly
SR-IOV can now be enabled in PowerNV platforms and Pseries platforms. Therefore, the appropriate calls were moved to machine dependent code instead of definition at compile time. Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> Signed-off-by: Juan J. Alvarez <jjalv...@u

Re: [PATCH v4 3/3] pci/iov: Expose VF drivers Auto Probe Globally

2017-10-31 Thread Bryant G. Ly
Add linuxppc-dev@lists.ozlabs.org On 10/31/17 9:47 AM, Bryant G. Ly wrote: > When SR-IOV is supported in pci_dev struct the > member variable drivers_autoprobe controls the > VF drivers auto probe functionality. This > patch exposes a gloabal function to be used > if needed w

Re: [PATCH v4 2/3] pseries: Add PSeries SR-IOV Machine dependent calls

2017-10-31 Thread Bryant G. Ly
Add linuxppc-dev@lists.ozlabs.org On 10/31/17 9:47 AM, Bryant G. Ly wrote: > Add calls for PSeries platform to configure/deconfigure > SR-IOV. > > Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> > Signed-off-by: Juan J. Alvarez <jjalv...@us.ibm.com> >

Re: [PATCH v4 1/3] powerpc/kernel: Separate SR-IOV Calls

2017-10-31 Thread Bryant G. Ly
Add linuxppc-dev@lists.ozlabs.org On 10/31/17 9:47 AM, Bryant G. Ly wrote: > SR-IOV can now be enabled in PowerNV platforms and Pseries > platforms. Therefore, the appropriate calls were moved to > machine dependent code instead of definition at compile time. > > Signed-off-b

Re: [PATCH v4 0/3] Prepartion for SR-IOV PowerVM Enablement

2017-10-31 Thread Bryant G. Ly
Add linuxppc-dev@lists.ozlabs.org On 10/31/17 9:47 AM, Bryant G. Ly wrote: > v1 - Initial patch > v2 - Addressed Bjorn's comment on creating a highly platform > dependent global exported symbol. > v3 - Based patch off linux-ppc/master > v4 - Using the sriov-drivers_autoprob

Re: [PATCH v3 2/2] pseries/eeh: Add Pseries pcibios_bus_add_device

2017-10-17 Thread Bryant G. Ly
Adding Juan back into the cc: jjalv...@linux.vnet.ibm.com On 10/16/17 10:38 PM, Michael Ellerman wrote: > "Bryant G. Ly" <bryan...@linux.vnet.ibm.com> writes: >> On 10/12/17 1:29 PM, Bjorn Helgaas wrote: > ... >>> If that's the case, how to you ever bind a dr

Re: [PATCH v3 2/2] pseries/eeh: Add Pseries pcibios_bus_add_device

2017-10-13 Thread Bryant G. Ly
-0500, Bryant G. Ly wrote: On 10/12/17 1:29 PM, Bjorn Helgaas wrote: On Thu, Oct 12, 2017 at 03:09:53PM +1100, Michael Ellerman wrote: Bjorn Helgaas <helg...@kernel.org> writes: On Fri, Sep 22, 2017 at 09:19:28AM -0500, Bryant G. Ly wrote: This patch adds the machine de

Re: [PATCH v3 2/2] pseries/eeh: Add Pseries pcibios_bus_add_device

2017-10-12 Thread Bryant G. Ly
On 10/12/17 1:29 PM, Bjorn Helgaas wrote: On Thu, Oct 12, 2017 at 03:09:53PM +1100, Michael Ellerman wrote: Bjorn Helgaas <helg...@kernel.org> writes: On Fri, Sep 22, 2017 at 09:19:28AM -0500, Bryant G. Ly wrote: This patch adds the machine dependent call for pcibios_bus_add_device,

Re: [PATCH v1 1/3] powerpc/kernel: Split up pci_bus_add_device

2017-09-22 Thread Bryant G. Ly
On 9/21/17 3:43 PM, Bjorn Helgaas wrote: On Mon, Sep 18, 2017 at 02:26:49PM -0500, Bryant G. Ly wrote: When enabling SR-IOV one might want to have their own version of starting device drivers for the VFs. This patch allows for SR-IOV callers to use pci_bus_add_virtfn_device instead of generic

[PATCH v3 2/2] pseries/eeh: Add Pseries pcibios_bus_add_device

2017-09-22 Thread Bryant G. Ly
drivers to load immediately, due to firmware loading the device node when VF device is assigned to the logical partition. This patch will depend on the patch linked below, which is under review. https://patchwork.kernel.org/patch/9882915/ Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.

[PATCH v3 0/2] Prepartion for SR-IOV PowerVM Enablement

2017-09-22 Thread Bryant G. Ly
- Addressed Bjorn's comment on creating a highly platform dependent global exported symbol. v3 - Based patch off linux-ppc/master Bryant G. Ly (2): powerpc/kernel: Separate SR-IOV Calls pseries/eeh: Add Pseries pcibios_bus_add_device arch/powerpc/include/asm/machdep.h | 7

[PATCH v3 1/2] powerpc/kernel: Separate SR-IOV Calls

2017-09-22 Thread Bryant G. Ly
SR-IOV can now be enabled in PowerNV platforms and Pseries platforms. Therefore, the appropriate calls were moved to machine dependent code instead of definition at compile time. Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> Signed-off-by: Juan J. Alvarez <jjalv...@u

[PATCH v2 2/2] pseries/eeh: Add Pseries pcibios_bus_add_device

2017-09-22 Thread Bryant G. Ly
drivers to load immediately, due to firmware loading the device node when VF device is assigned to the logical partition. This patch will depend on the patch linked below, which is under review. https://patchwork.kernel.org/patch/9882915/ Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.

[PATCH v2 1/2] powerpc/kernel: Separate SR-IOV Calls

2017-09-22 Thread Bryant G. Ly
SR-IOV can now be enabled in PowerNV platforms and Pseries platforms. Therefore, the appropriate calls were moved to machine dependent code instead of definition at compile time. Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> Signed-off-by: Juan J. Alvarez <jjalv...@u

[PATCH v2 0/2] Prepartion for SR-IOV PowerVM Enablement

2017-09-22 Thread Bryant G. Ly
This patch series is to prepare for enabling SR-IOV on pseries. It separates the calls to be machine dependent and does not change any current functionality. This patch which is currently in review is a dependency: https://patchwork.kernel.org/patch/9882915/ Bryant G. Ly (2): powerpc/kernel

[PATCH v1 3/3] powerpc/kernel: Separate SR-IOV Calls

2017-09-18 Thread Bryant G. Ly
SR-IOV can now be enabled in PowerNV platforms and Pseries platforms. Therefore, the appropriate calls were moved to machine dependent code instead of definition at compile time. Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> Signed-off-by: Juan J. Alvarez <jjalv...@u

[PATCH v1 2/3] pseries: Override pci_bus_match_virtfn_driver

2017-09-18 Thread Bryant G. Ly
For Powervm SR-IOV (Pseries) enablement we dont want to match the virtual function's device drivers since firmware plans to load the device node in the device tree dynamically when Novalink assigns the VF to a partition. Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> Sign

[PATCH v1 1/3] powerpc/kernel: Split up pci_bus_add_device

2017-09-18 Thread Bryant G. Ly
the sriov_configure sysfs call will not load the device driver as firmware will load the device node when the VF device is assigned to the logical partition. So we needed a way to overwrite the way device driver matching is done for virtual functions on powervm. Signed-off-by: Bryant G. Ly <br

[PATCH v1 0/3] Prepartion for SR-IOV PowerVM Enablement

2017-09-18 Thread Bryant G. Ly
This patch series is to prepare for enabling SR-IOV on pseries. It separates the calls to be machine dependent and does not change any current functionality. Bryant G. Ly (3): powerpc/kernel: Split up pci_bus_add_device pseries: Override pci_bus_match_virtfn_driver powerpc/kernel: Separate

Re: [PATCH] powerpc/kernel: Change retrieval of pci_dn

2017-08-29 Thread Bryant G. Ly
On 8/29/17 1:20 AM, Sam Bobroff wrote: On Mon, Aug 28, 2017 at 11:05:03AM -0500, Bryant G. Ly wrote: For a PCI device it's pci_dn can be retrieved from pdev->dev.archdata.firmware_data, PCI_DN(devnode), or parent's list. Thus, we should just use the generic function pci_get_pdn_by_devfn to

Re: [PATCH] powerpc/kernel: Change retrieval of pci_dn

2017-08-29 Thread Bryant G. Ly
On 8/29/17 1:33 AM, Michael Ellerman wrote: "Bryant G. Ly" <bryan...@linux.vnet.ibm.com> writes: For a PCI device it's pci_dn can be retrieved from pdev->dev.archdata.firmware_data, PCI_DN(devnode), or parent's list. Thus, we should just use the generic function pci_get_

[PATCH] powerpc/kernel: Change retrieval of pci_dn

2017-08-29 Thread Bryant G. Ly
For a PCI device it's pci_dn can be retrieved from pdev->dev.archdata.firmware_data, PCI_DN(devnode), or parent's list. Thus, we should just use the existing function pci_get_pdn_by_devfn to get the pci_dn. Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> Reviewed-by: Sa

[PATCH] powerpc/kernel: Change retrieval of pci_dn

2017-08-28 Thread Bryant G. Ly
For a PCI device it's pci_dn can be retrieved from pdev->dev.archdata.firmware_data, PCI_DN(devnode), or parent's list. Thus, we should just use the generic function pci_get_pdn_by_devfn to get the pci_dn. Signed-off-by: Bryant G. Ly <b...@us.ibm.com> --- arch/powerpc/kernel/rtas_p