Re: [PATCH v4 06/10] soc: fsl: cmp1: Add support for QMC

2023-02-15 Thread Christophe Leroy
Le 15/02/2023 à 13:45, kernel test robot a écrit : > Hi Herve, > > I love your patch! Yet something to improve: > > [auto build test ERROR on broonie-sound/for-next] > [also build test ERROR on robh/for-next powerpc/next powerpc/fixes > linus/master v6.2-rc8 next-20230215] > [If your patch is

Re: [PATCH v7 7/7] powerpc: mm: Support page table check

2023-02-14 Thread Christophe Leroy
in commit 3fee229a8eb9 ("riscv/mm: enable > ARCH_SUPPORTS_PAGE_TABLE_CHECK") > arm64 in commit 42b2547137f5 ("arm64/mm: enable > ARCH_SUPPORTS_PAGE_TABLE_CHECK") > x86_64 in commit d283d422c6c4 ("x86: mm: add x86_64 support for page table > check") > > Signe

Re: [PATCH v7 6/7] powerpc: mm: Add p{te,md,ud}_user_accessible_page helpers

2023-02-14 Thread Christophe Leroy
plement missing pud_user definitions for both Book3S/nohash 64-bit > systems, and pmd_user for Book3S/nohash 32-bit systems. > > Signed-off-by: Rohan McLure Reviewed-by: Christophe Leroy > --- > V2: Provide missing pud_user implementations, use p{u,m}d_is_leaf. > V3: Provide missi

Re: [PATCH v7 4/7] powerpc: mm: Implement p{m,u,4}d_leaf on all platforms

2023-02-14 Thread Christophe Leroy
3E-64, pmd_leaf for all Book3E > and Book3S-64 platforms, with a catch-all definition for p4d_leaf. > > Signed-off-by: Rohan McLure Reviewed-by: Christophe Leroy > --- > v5: Split patch that replaces p{m,u,4}d_is_leaf into two patches, first > replacing callsites and afterwa

Re: [PATCH v7 3/7] powerpc: mm: Replace p{u,m,4}d_is_leaf with p{u,m,4}_leaf

2023-02-14 Thread Christophe Leroy
gt; A future patch will implement p{u,m,4}_leaf stubs on all platforms so > that they may be referenced in generic code. > > Signed-off-by: Rohan McLure Reviewed-by: Christophe Leroy > --- > V4: New patch > V5: Previously replaced stub definition for *_is_leaf with *_leaf. Do &g

Re: [PATCH v7 1/7] powerpc: mm: Separate set_pte, set_pte_at for internal, external use

2023-02-14 Thread Christophe Leroy
sanitiser. Having this distinction allows for set_pte_at to > instrumented, but set_pte not to be, permitting for uninstrumented > internal mappings. This distinction in names is also present in x86. > > Signed-off-by: Rohan McLure Reviewed-by: Christophe Leroy > --- > v6: new patch

Re: [PATCH v2 12/24] powerpc/cpu: Mark start_secondary_resume() __noreturn

2023-02-13 Thread Christophe Leroy
Le 14/02/2023 à 08:05, Josh Poimboeuf a écrit : > start_secondary_resume() doesn't return. Annotate it as such. By > extension this also makes arch_cpu_idle_dead() noreturn. > > Acked-by: Michael Ellerman (powerpc) > Signed-off-by: Josh Poimboeuf Reviewed-

Re: [PATCH v6 7/7] powerpc: mm: Support page table check

2023-02-13 Thread Christophe Leroy
Le 14/02/2023 à 02:59, Rohan McLure a écrit : > On creation and clearing of a page table mapping, instrument such calls > by invoking page_table_check_pte_set and page_table_check_pte_clear > respectively. These calls serve as a sanity check against illegal > mappings. Please also explaing the c

Re: [PATCH v6 2/7] powerpc/64s: mm: Introduce __pmdp_collapse_flush with mm_struct argument

2023-02-13 Thread Christophe Leroy
Le 14/02/2023 à 02:59, Rohan McLure a écrit : > pmdp_collapse_flush has references in generic code with just three > parameters, due to the choice of mm context being implied by the vm_area > context parameter. > > Define __pmdp_collapse_flush to accept an additional mm_struct * > parameter, wit

Re: [PATCH v6 1/7] powerpc: mm: Separate set_pte, set_pte_at for internal, external use

2023-02-13 Thread Christophe Leroy
Le 14/02/2023 à 02:59, Rohan McLure a écrit : > Produce separate symbols for set_pte, which is to be used in > arch/powerpc for reassignment of pte's, and set_pte_at, used in generic > code. > > The reason for this distinction is to support the Page Table Check > sanitiser. Having this distincti

Re: [PATCH v2 3/8] powerpc/85xx: p2020: Move all P2020 machine descriptions to p2020.c

2023-02-13 Thread Christophe Leroy
Le 13/02/2023 à 21:15, Pali Rohár a écrit : > On Monday 13 February 2023 20:05:09 Christophe Leroy wrote: >> Le 24/12/2022 à 22:14, Pali Rohár a écrit : >>> +#ifdef CONFIG_MPC85xx_RDB >>> +static void __init mpc85xx_rdb_pic_init(void) >>> +{ >>&

Re: [PATCH v2 0/8] powerpc/85xx: p2020: Create one unified machine description

2023-02-13 Thread Christophe Leroy
Le 13/02/2023 à 21:11, Pali Rohár a écrit : > On Monday 13 February 2023 19:58:15 Christophe Leroy wrote: >> Le 09/02/2023 à 01:15, Pali Rohár a écrit : >>>> >>>> This patch moves all p2020 boards from mpc85xx_rdb.c and mpc85xx_ds.c >>>> files into ne

Re: [PATCH v2] powerpc/machdep: warn when machine_is() used too early

2023-02-13 Thread Christophe Leroy
orted file:line indicates exactly what went > wrong. > > checkpatch complains about __attribute__((weak)) in the patch, so > change that to __weak, and align the line continuations as well. > > Signed-off-by: Nathan Lynch Reviewed-by: Christophe Leroy > --- > Prompted

Re: [PATCH v2 6/8] powerpc/85xx: p2020: Define just one machine description

2023-02-13 Thread Christophe Leroy
Le 24/12/2022 à 22:14, Pali Rohár a écrit : > Combine machine descriptions and code of all P2020 boards into just one > generic unified P2020 machine description. This allows kernel to boot on > any P2020-based board with P2020 DTS file without need to patch kernel and > define a new machine desc

Re: [PATCH v2 4/8] powerpc/85xx: p2020: Move i8259 code into own function

2023-02-13 Thread Christophe Leroy
Le 24/12/2022 à 22:14, Pali Rohár a écrit : > Splits mpic and i8259 initialization codes into separate functions. > > Signed-off-by: Pali Rohár > --- > arch/powerpc/platforms/85xx/p2020.c | 37 - > 1 file changed, 21 insertions(+), 16 deletions(-) > > diff --git

Re: [PATCH v2 3/8] powerpc/85xx: p2020: Move all P2020 machine descriptions to p2020.c

2023-02-13 Thread Christophe Leroy
Le 24/12/2022 à 22:14, Pali Rohár a écrit : > This moves machine descriptions and all related code for all P2020 boards > into new p2020.c source file. This change also copies helper static > functions from other mpc85xx*.c files into p2020.c, which are required for > machine descriptions. This i

Re: [PATCH v2 0/8] powerpc/85xx: p2020: Create one unified machine description

2023-02-13 Thread Christophe Leroy
Le 09/02/2023 à 01:15, Pali Rohár a écrit : >> >> This patch moves all p2020 boards from mpc85xx_rdb.c and mpc85xx_ds.c >> files into new p2020.c file, and plus it copies all helper functions >> which p2020 boards requires. This patch does not introduce any new code >> or functional change. It sh

Re: [PATCH] powerpc/machdep: warn when machine_is() used too early

2023-02-10 Thread Christophe Leroy
Le 11/02/2023 à 00:56, Nathan Lynch via B4 Submission Endpoint a écrit : > From: Nathan Lynch > > machine_is() can't provide correct results before probe_machine() has > run. Warn when it's used too early in boot. > > Signed-off-by: Nathan Lynch > --- > Prompted by my attempts to do some pser

Re: Bug: Write fault blocked by KUAP! (kernel 6.2-rc6, Talos II)

2023-02-08 Thread Christophe Leroy
Le 03/02/2023 à 03:45, Nicholas Piggin a écrit : > On Fri Feb 3, 2023 at 12:02 PM AEST, Benjamin Gray wrote: >> On Fri, 2023-02-03 at 00:46 +0100, Erhard F. wrote: >>> Happened during boot: >>> >>> [...] >>> Creating 6 MTD partitions on "flash@0": >>> 0x-0x0400 : "PNOR" >>> 0x

Re: [PATCH 1/3] powerpc/code-patching: Add generic memory patching

2023-02-08 Thread Christophe Leroy
Le 07/02/2023 à 02:56, Benjamin Gray a écrit : > patch_instruction() is designed for patching instructions in otherwise > readonly memory. Other consumers also sometimes need to patch readonly > memory, so have abused patch_instruction() for arbitrary data patches. > > This is a problem on ppc64

Re: [PATCH v4 7/7] powerpc: kcsan: Add KCSAN Support

2023-02-08 Thread Christophe Leroy
Le 08/02/2023 à 04:22, Rohan McLure a écrit : > Enable HAVE_ARCH_KCSAN on all powerpc platforms, permitting use of the > kernel concurrency sanitiser through the CONFIG_KCSAN_* kconfig options. > KCSAN requires compiler builtins __atomic_* 64-bit values, and so only > report support on PPC64. Co

Re: [PATCH v4 1/7] kcsan: Add atomic builtin stubs for 32-bit systems

2023-02-08 Thread Christophe Leroy
Le 08/02/2023 à 04:21, Rohan McLure a écrit : > KCSAN instruments calls to atomic builtins, and will in turn call these > builtins itself. As such, architectures supporting KCSAN must have > compiler support for these atomic primitives. > > Since 32-bit systems are unlikely to have 64-bit compil

Re: [PATCH v3 5/5] powerpc: kcsan: Add KCSAN Support

2023-02-06 Thread Christophe Leroy
Le 06/02/2023 à 03:18, Rohan McLure a écrit : > Enable HAVE_ARCH_KCSAN on all powerpc platforms, permitting use of the > kernel concurrency sanitiser through the CONFIG_KCSAN_* kconfig options. > KCSAN requires compiler builtins __atomic_* 64-bit values, and so only > report support on PPC64. >

Re: [PATCH v3 0/5] powerpc: Add KCSAN support

2023-02-06 Thread Christophe Leroy
Le 06/02/2023 à 03:17, Rohan McLure a écrit : > Add Kernel Concurrency Sanitiser support for PPC64. Doing so involves > exclusion of a number of compilation units from instrumentation, as was > done with KASAN. > > KCSAN uses watchpoints on memory accesses to enforce the semantics of > the Linux

Re: [PATCH v2 15/16] objtool/powerpc: Enable objtool to be built on ppc

2023-02-04 Thread Christophe Leroy
Le 04/02/2023 à 12:55, Christophe Leroy a écrit : Hi, Le 04/02/2023 à 09:30, Randy Dunlap a écrit : On 2/4/23 00:21, Randy Dunlap wrote: On 2/4/23 00:19, Randy Dunlap wrote: Hi-- On 8/29/22 23:41, Christophe Leroy wrote: Le 29/08/2022 à 07:52, Sathvika Vasireddy a écrit : This

Re: [PATCH v2 15/16] objtool/powerpc: Enable objtool to be built on ppc

2023-02-04 Thread Christophe Leroy
Hi, Le 04/02/2023 à 09:30, Randy Dunlap a écrit : > > > On 2/4/23 00:21, Randy Dunlap wrote: >> >> >> On 2/4/23 00:19, Randy Dunlap wrote: >>> Hi-- >>> >>> On 8/29/22 23:41, Christophe Leroy wrote: >>>> >>>> >&g

Re: [PATCH v1 3/5] powerpc/64: Replace -mcpu=e500mc64 by -mcpu=e5500

2023-02-03 Thread Christophe Leroy
Le 02/02/2023 à 00:46, Pali Rohár a écrit : > On Tuesday 20 December 2022 21:15:08 Pali Rohár wrote: >> On Monday 19 December 2022 19:45:58 Christophe Leroy wrote: >>> E500MC64 is a processor pre-dating E5500 that has never been >>> commercialised. Use -mcpu=e5500 f

Re: [PATCH 1/2] powerpc/64: Set default CPU in Kconfig

2023-02-03 Thread Christophe Leroy
Le 03/02/2023 à 18:58, Pali Rohár a écrit : > On Wednesday 01 February 2023 09:29:45 Nick Desaulniers wrote: >> On Wed, Feb 1, 2023 at 3:41 AM Christophe Leroy >> wrote: >>> >>> >>> >>> Le 01/02/2023 à 12:31, Naresh Kamboju a écrit : >>

[PATCH] powerpc: Disable CPU unknown by CLANG when CC_IS_CLANG

2023-02-02 Thread Christophe Leroy
, pwr9, power10, pwr10, powerpc, ppc, ppc32, powerpc64, ppc64, powerpc64le, ppc64le, futur Disable other ones when CC_IS_CLANG. Signed-off-by: Christophe Leroy --- arch/powerpc/platforms/Kconfig.cputype | 8 1 file changed, 8 insertions(+) diff --git a/arch/powerpc/platforms

Re: [PATCH 1/2] powerpc/64: Set default CPU in Kconfig

2023-02-01 Thread Christophe Leroy
Le 01/02/2023 à 12:31, Naresh Kamboju a écrit : > Following build regression started from next-20230131. > > Regressions found on powerpc: > >build/clang-nightly-tqm8xx_defconfig >build/clang-nightly-ppc64e_defconfig > > > make --silent --keep-going --jobs=8 > O=/home/tuxbuild/.cache

Re: [PATCH 0/7] hvcs: Various hvcs device hotplug fixes

2023-02-01 Thread Christophe Leroy
Le 30/01/2023 à 23:43, Brian King a écrit : > This patch series fixes a number of issues with hotplugging > hvcs devices including memory leaks as well as, the inability > to reconnect to a console device after it has been hot added > back, since it was not getting cleaned up properly on the > ho

Re: [PATCH] powerpc/tlb: Implement book3s/32/tlbflush.h local_flush_tlb_page_psize

2023-02-01 Thread Christophe Leroy
Le 31/01/2023 à 22:58, Benjamin Gray a écrit : > On Tue, 2023-01-31 at 06:33 +0000, Christophe Leroy wrote: >> I still think it is not the correct fix. You are putting the problem >> under the carpet instead of fixing it. There are many other places >> where >&g

[PATCH v2 6/9] powerpc/bpf: Only pad length-variable code at initial pass

2023-02-01 Thread Christophe Leroy
Now that two real additional passes are performed in case of extra pass requested by BPF core, padding is not needed anymore except during initial pass done before memory allocation to count maximum possible program size. So, only do the padding when 'image' is NULL. Signed-off-by:

[PATCH v2 4/9] powerpc/bpf/32: BPF prog is never called with more than one arg

2023-02-01 Thread Christophe Leroy
BPF progs are never called with more than one argument, plus the tail call count as a second argument when needed. So, no need to retrieve 9th and 10th argument (5th 64 bits argument) from the stack in prologue. Signed-off-by: Christophe Leroy --- arch/powerpc/net/bpf_jit_comp32.c | 6

[PATCH v2 8/9] powerpc/bpf/32: introduce a second source register for ALU operations

2023-02-01 Thread Christophe Leroy
r6,r30,-12 74: 7c bd 01 d4 addme r5,r29 Signed-off-by: Christophe Leroy --- arch/powerpc/net/bpf_jit_comp32.c | 350 -- 1 file changed, 183 insertions(+), 167 deletions(-) diff --git a/arch/powerpc/net/bpf_jit_comp32.c b/arch/powerpc/net/bpf_jit_comp32.c

[PATCH v2 5/9] powerpc/bpf: Perform complete extra passes to update addresses

2023-02-01 Thread Christophe Leroy
. In order to avoid waste of space, and waste of CPU time on powerpc processors on which the NOP instruction is not 0-cycle, perform two real additional passes. Signed-off-by: Christophe Leroy --- arch/powerpc/net/bpf_jit.h| 2 +- arch/powerpc/net/bpf_jit_comp.c | 91

[PATCH v2 9/9] powerpc/bpf/32: perform three operands ALU operations

2023-02-01 Thread Christophe Leroy
directly. 70: 30 de ff f4 addic r6,r30,-12 74: 7c bd 01 d4 addme r5,r29 Signed-off-by: Christophe Leroy --- arch/powerpc/net/bpf_jit_comp32.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/powerpc/net/bpf_jit_comp32.c b/arch/powerpc/net/bpf_jit_comp32

[PATCH v2 7/9] powerpc/bpf/32: Optimise some particular const operations

2023-02-01 Thread Christophe Leroy
Simplify multiplications and divisions with constants when the constant is 1 or -1. When the constant is a power of 2, replace them by bit shits. Signed-off-by: Christophe Leroy --- arch/powerpc/net/bpf_jit_comp32.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions

[PATCH v2 3/9] powerpc/bpf/32: Only set a stack frame when necessary

2023-02-01 Thread Christophe Leroy
e for that. Just like PPC64, implement bpf_has_stack_frame() and only sets the frame when needed. The difference with PPC64 is that PPC32 doesn't have a redzone, so the stack is required as soon as non volatile registers are used or when tail call count is set up. Signed-off-by: Christophe L

[PATCH v2 2/9] powerpc/bpf/32: No need to zeroise r4 when not doing tail call

2023-02-01 Thread Christophe Leroy
r4 is cleared at function entry and used as tail call count. But when the function does not perform tail call, r4 is ignored, so no need to clear it. Replace it by a NOP in that case. Signed-off-by: Christophe Leroy --- arch/powerpc/net/bpf_jit_comp32.c | 5 - 1 file changed, 4 insertions

[PATCH v2 1/9] powerpc: Remove __kernel_text_address() in show_instructions()

2023-02-01 Thread Christophe Leroy
y additional check before dumping instructions. Do the same and remove __kernel_text_address() in show_instructions(). Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/process.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/process.c b/arch/power

Re: [PATCH v1 06/10] powerpc/bpf: Perform complete extra passes to update addresses

2023-01-31 Thread Christophe Leroy
Le 10/01/2023 à 09:44, Naveen N. Rao a écrit : > Christophe Leroy wrote: >> >> >> Le 13/12/2022 à 11:23, Naveen N. Rao a écrit : >>> Christophe Leroy wrote: >>>> BPF core calls the jit compiler again for an extra pass in order >>>> to

Re: [PATCH] powerpc/tlb: Implement book3s/32/tlbflush.h local_flush_tlb_page_psize

2023-01-30 Thread Christophe Leroy
Le 31/01/2023 à 03:58, Benjamin Gray a écrit : > The commit introducing this function implemented it as a build bug on this > platform to make the compiler happy, as the only use in the code is guarded > behind a radix_enabled() conditional. > > GCC recognises that cpu_has_feature(MMU_FTR_TYPE_R

Re: [PATCH] powerpc/tlb: Remove BUILD_BUG for book3s/32/tlbflush.h local_flush_tlb_page_psize

2023-01-26 Thread Christophe Leroy
Le 26/01/2023 à 23:30, Benjamin Gray a écrit : > On Wed, 2023-01-25 at 09:43 +0000, Christophe Leroy wrote: > >> By the way, are you should the problem is really BUILD_BUG() ? >> Looking >> at your patch I would think that the problem is because it is "static >&

Re: [PATCH] powerpc/kasan/book3s_64: warn when running with hash MMU

2023-01-25 Thread Christophe Leroy
Le 11/10/2022 à 12:25, Christophe Leroy a écrit : Le 11/10/2022 à 12:00, Michael Ellerman a écrit : Nathan Lynch writes: Michael Ellerman writes: Christophe Leroy writes: + KASAN list Le 06/10/2022 à 06:10, Michael Ellerman a écrit : Nathan Lynch writes: kasan is known to crash

[PATCH] kasan: Fix Oops due to missing calls to kasan_arch_is_ready()

2023-01-25 Thread Christophe Leroy
n shadow mem end ]--- So, also verify KASAN readiness before allocating and poisoning shadow mem for VMAs. Reported-by: Nathan Lynch Suggested-by: Michael Ellerman Signed-off-by: Christophe Leroy --- mm/kasan/common.c | 3 +++ mm/kasan/generic.c | 7 ++- mm/kasan/shadow.c | 12 +

Re: [RFC 0/3] Asynchronous EEH recovery

2023-01-25 Thread Christophe Leroy
Hi, Le 15/09/2022 à 12:15, Ganesh a écrit : > On 9/2/22 05:49, Jason Gunthorpe wrote: > >> On Tue, Aug 16, 2022 at 08:57:13AM +0530, Ganesh Goudar wrote: >>> Hi, >>> >>> EEH reocvery is currently serialized and these patches shorten >>> the time taken for EEH recovery by making the recovery to ru

Re: [PATCH] powerpc/tlb: Remove BUILD_BUG for book3s/32/tlbflush.h local_flush_tlb_page_psize

2023-01-25 Thread Christophe Leroy
Le 24/01/2023 à 22:54, Benjamin Gray a écrit : > Converts the BUILD_BUG to a WARN to allow building with a low/unoptimised > compiler. No no no no. Please don't do that. That approach is used everywhere in the kernel, why should it be a problem only for local_flush_tlb_page_psize() and not eve

Re: [PATCH v3] powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage

2023-01-25 Thread Christophe Leroy
Le 22/01/2023 à 12:19, Pali Rohár a écrit : > On Saturday 24 December 2022 18:44:52 Pali Rohár wrote: >> On Thursday 08 December 2022 19:57:39 Christophe Leroy wrote: >>> Le 08/12/2022 à 20:16, Pali Rohár a écrit : >>>> On Sunday 28 August 2022 17:43:53 Christop

[PATCH 2/2] powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage

2023-01-24 Thread Christophe Leroy
werpc/32: Don't always pass -mcpu=powerpc to the compiler"). Fixes: 40a75584e526 ("powerpc/boot: Build wrapper for an appropriate CPU") Cc: sta...@vger.kernel.org # 446cda1b21d9 ("powerpc/32: Don't always pass -mcpu=powerpc to the compiler") Signed-off-by: Pal

[PATCH 1/2] powerpc/64: Set default CPU in Kconfig

2023-01-24 Thread Christophe Leroy
Pali Rohár Tested-by: Pali Rohár Signed-off-by: Christophe Leroy Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/3fd60c2d8a28668a42b766b18362a526ef47e757.1670420281.git.christophe.le...@csgroup.eu --- arch/powerpc/Makefile | 22 +-

Re: [PATCH v2 0/8] powerpc/85xx: p2020: Create one unified machine description

2023-01-23 Thread Christophe Leroy
Le 22/01/2023 à 12:16, Pali Rohár a écrit : > Hello! Do you have any comments for this patch series? I think patches 1 and 2 could be a single patch. I'm having hard time understanding how things are built. Patch 3 introduces 273 lines of new code in a file named p2020.c while only removing

[PATCH] powerpc: Check !irq instead of irq == NO_IRQ and remove NO_IRQ

2023-01-23 Thread Christophe Leroy
/21/221 . He re-iterated the same view recently in https://lkml.org/lkml/2022/10/12/622 So test !irq instead of tesing irq == NO_IRQ. All other usage of NO_IRQ for powerpc were remove in previous cycle so time has come to remove NO_IRQ completely for powerpc. Signed-off-by: Christophe Leroy

Re: [PATCH v2] of: Fix of platform build on powerpc due to bad of disaply code

2023-01-19 Thread Christophe Leroy
Le 19/01/2023 à 10:53, Michal Suchanek a écrit : > The commit 2d681d6a23a1 ("of: Make of framebuffer devices unique") > breaks build because of wrong argument to snprintf. That certainly > avoids the runtime error but is not the intended outcome. > > Also use standard device name format of-displ

Re: [PATCH v2 1/2] powerpc/ps3: Change updateboltedpp panic to info

2023-01-16 Thread Christophe Leroy
Le 16/01/2023 à 21:08, Geoff Levand a écrit : > Hi, > > On 1/15/23 16:06, Michael Ellerman wrote: >> Geoff Levand writes: >>> On 1/9/23 09:41, Christophe Leroy wrote: >>>> >>>> >>>> Le 03/01/2023 à 18:51, Geoff Levand a écrit : &g

Re: usb.c:undefined reference to `qe_immr'

2023-01-11 Thread Christophe Leroy
Le 11/01/2023 à 17:01, Randy Dunlap a écrit : > > > On 1/10/23 23:39, Michael Ellerman wrote: >> Randy Dunlap writes: >>> [adding Cc's] >>> >>> >>> On 1/9/23 23:59, kernel test robot wrote: Hi Masahiro, FYI, the error/warning still remains. tree: https://git.kernel.o

Re: [PATCH v2 06/10] soc: fsl: qe: Add support for QMC

2023-01-11 Thread Christophe Leroy
Le 11/01/2023 à 16:40, Herve Codina a écrit : > Hi Christophe, > On Wed, 11 Jan 2023 13:58:03 +0000 > Christophe Leroy wrote: > >> Le 06/01/2023 à 17:37, Herve Codina a écrit : >>> The QMC (QUICC Multichannel Controller) is available on some >>> PowerQU

Re: [PATCH v2 02/10] soc: fsl: qe: Add support for TSA

2023-01-11 Thread Christophe Leroy
Le 11/01/2023 à 16:06, Herve Codina a écrit : > Hi Christophe, > > On Wed, 11 Jan 2023 13:47:23 + > Christophe Leroy wrote: > >> Le 06/01/2023 à 17:37, Herve Codina a écrit : >>> The TSA (Time Slot Assigner) is available in some >>> PowerQUICC SoC su

Re: [PATCH v2 06/10] soc: fsl: qe: Add support for QMC

2023-01-11 Thread Christophe Leroy
Le 06/01/2023 à 17:37, Herve Codina a écrit : > The QMC (QUICC Multichannel Controller) is available on some > PowerQUICC SoC such as the MPC885 or MPC866. Same, that's QMC for CPM for the time being, should that be made clear in the subject ? QE also has QMC and this driver might be used for

Re: [PATCH v2 02/10] soc: fsl: qe: Add support for TSA

2023-01-11 Thread Christophe Leroy
Le 06/01/2023 à 17:37, Herve Codina a écrit : > The TSA (Time Slot Assigner) is available in some > PowerQUICC SoC such as the MPC885 or MPC866. > > Its purpose is to route some TDM time-slots to other > internal serial controllers. Is the subject correct ? As far as I understand this patch add

Re: [PATCH v2 04/10] powerpc/8xx: Use a larger CPM1 command check mask

2023-01-10 Thread Christophe Leroy
oth the > standard CH_NUM field and the QMC extension CHANNEL_NUMBER > field. > > Signed-off-by: Herve Codina Acked-by: Christophe Leroy (As maintainer of LINUX FOR POWERPC EMBEDDED PPC8XX) > --- > arch/powerpc/platforms/8xx/cpm1.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH 02/15] video: fbdev: atyfb: Introduce backlight_get_brightness()

2023-01-09 Thread Christophe Leroy
Le 07/01/2023 à 19:26, Sam Ravnborg via B4 Submission Endpoint a écrit : > From: Sam Ravnborg > > Introduce backlight_get_brightness() to simplify logic > and avoid direct access to backlight properties. When I read 'introduce' I understand that you are adding a new function. In fact backligh

Re: [PATCH v2 1/2] powerpc/ps3: Change updateboltedpp panic to info

2023-01-09 Thread Christophe Leroy
Le 03/01/2023 à 18:51, Geoff Levand a écrit : > Commit fdacae8a84024474afff234bdd1dbe19ad597a10 (powerpc: Activate > CONFIG_STRICT_KERNEL_RWX by default) causes ps3_hpte_updateboltedpp() > to be called. Change the panic statment in ps3_hpte_updateboltedpp() > to a pr_info statement so that bootu

Re: [PATCH] net-wan: Add check for NULL for utdm in ucc_hdlc_probe

2023-01-09 Thread Christophe Leroy
Le 23/12/2022 à 15:32, Ekaterina Esina a écrit : > [Vous ne recevez pas souvent de courriers de ees...@astralinux.ru. Découvrez > pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] > > If uhdlc_priv_tsa != 1 then utdm is not initialized. > And if ret != NULL then goto

Re: [PATCH v12 0/6] implement getrandom() in vDSO

2022-12-20 Thread Christophe Leroy
Hi Jason, Le 12/12/2022 à 19:53, Jason A. Donenfeld a écrit : > Changes v11->v12: > > - In order to avoid mlock()ing pages, and the related rlimit and fork >inheritance issues there, Introduce VM_DROPPABLE to prevent swapping >while meeting the cache-like requirements of v

Re: [PATCH] tools/objtool: tolerate STT_NOTYPE symbols at end of section

2022-12-20 Thread Christophe Leroy
Le 20/12/2022 à 11:13, Nicholas Piggin a écrit : > Hand-written asm often contains non-function symbols in executable > sections. _end symbols for finding the size of instruction blocks > for runtime processing is one such usage. > > optprobe_template_end is one example that causes the warning:

[PATCH v1 1/5] powerpc/64: Set default CPU in Kconfig

2022-12-20 Thread Christophe Leroy
CC 12 (unrecognized opcode: `wrteei')") Fixes: d6b551b8f90c ("powerpc/64e: Fix build failure with GCC 12 (unrecognized opcode: `wrteei')") Reported-by: Pali Rohár Tested-by: Pali Rohár Signed-off-by: Christophe Leroy --- arch/powerpc/Makefile | 22 ++

[PATCH v1 2/5] powerpc: Pass correct CPU reference to assembler

2022-12-20 Thread Christophe Leroy
l,-a64 -mabi=elfv1 -mcpu=e500mc64 -mabi=elfv1 -mbig-endian-Wl,-soname=linux-vdso64.so.1 -D__VDSO64__ -s -c -o arch/powerpc/kernel/vdso/gettimeofday-64.o arch/powerpc/kernel/vdso/gettimeofday.S Reported-by: Jan-Benedict Glaw Signed-off-by: Christophe Leroy --- v3: Remove -Wa,-mXXX completery as

[PATCH v1 4/5] powerpc: Remove cpu-as-y completely

2022-12-20 Thread Christophe Leroy
ecting the compiler to automatically pass the proper options and instructions based on -mcpu=power4 Signed-off-by: Christophe Leroy --- arch/powerpc/Makefile | 12 1 file changed, 12 deletions(-) diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile index 0f9f291895cb..7e67f939a

[PATCH v1 5/5] powerpc/epapr: Don't use wrteei on non booke

2022-12-20 Thread Christophe Leroy
wrteei is only for booke. Use the standard mfmsr/ori/mtmsr when non booke. Reported-by: Jan-Benedict Glaw Signed-off-by: Christophe Leroy --- Not sure this is needed at all, the commit that introduced the code says it is for e500, but there's no such limitation in Kconfig. Maybe we s

[PATCH v1 3/5] powerpc/64: Replace -mcpu=e500mc64 by -mcpu=e5500

2022-12-20 Thread Christophe Leroy
E500MC64 is a processor pre-dating E5500 that has never been commercialised. Use -mcpu=e5500 for E5500 core. More details at https://gcc.gnu.org/PR108149 Signed-off-by: Christophe Leroy --- arch/powerpc/platforms/Kconfig.cputype | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v1 06/10] powerpc/bpf: Perform complete extra passes to update addresses

2022-12-19 Thread Christophe Leroy
Le 13/12/2022 à 11:23, Naveen N. Rao a écrit : > Christophe Leroy wrote: >> BPF core calls the jit compiler again for an extra pass in order >> to properly set subprog addresses. >> >> Unlike other architectures, powerpc only updates the addresses >> during tha

Re: [PATCH] [Backport for 4.14] perf script python: Remove explicit shebang from tests/attr.c

2022-12-19 Thread Christophe Leroy
Le 19/12/2022 à 13:18, Greg KH a écrit : > On Fri, Dec 16, 2022 at 12:38:12PM +0100, Christophe Leroy wrote: >> From: Tony Jones >> >> [Upstream commit d72eadbc1d2866fc047edd4535ffb0298fe240be] >> >> tests/attr.c invokes attr.py via an explicit invocation o

Re: [PATCH] boot: simple_alloc: check after increasing memory allocation

2022-12-18 Thread Christophe Leroy
Le 19/12/2022 à 03:18, Li zeming a écrit : > The pointer new adds judgment and should help with program robustness. This text is not understandable. Do you mean: simple_malloc() will return NULL when there is now enough memory left. Check pointer 'new' before using it to copy the old data. >

Re: [PATCH v2] powerpc: Pass correct CPU reference to assembler

2022-12-16 Thread Christophe Leroy
CC Joel for the -many subject. Le 16/12/2022 à 18:18, Segher Boessenkool a écrit : > Hi! > > On Fri, Dec 16, 2022 at 09:35:50AM +0100, Christophe Leroy wrote: >> The problem comes from the fact that CONFIG_PPC_E500MC is selected for >> both the e500mc (32 bits) and the

[PATCH] [Backport for 4.14] perf script python: Remove explicit shebang from tests/attr.c

2022-12-16 Thread Christophe Leroy
: Christophe Leroy --- tools/perf/tests/attr.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/perf/tests/attr.py b/tools/perf/tests/attr.py index 6c68435585c7..3e07eee33b10 100644 --- a/tools/perf/tests/attr.py +++ b/tools/perf/tests/attr.py @@ -1,4 +1,3 @@ -#! /usr/bin/env python # SPDX

Re: [PATCH] powerpc: Pass correct CPU reference to assembler

2022-12-16 Thread Christophe Leroy
Le 16/12/2022 à 09:38, Jan-Benedict Glaw a écrit : > On Fri, 2022-12-16 16:07:25 +0800, kernel test robot wrote: >> Hi Christophe, >> >> I love your patch! Yet something to improve: > > [...] > >> If you fix the issue, kindly add following tag where applicable >> | Reported-by: kernel test rob

[PATCH v2] powerpc: Pass correct CPU reference to assembler

2022-12-16 Thread Christophe Leroy
endian -Wl,-soname=linux-vdso64.so.1 -D__VDSO64__ -s -c -o arch/powerpc/kernel/vdso/gettimeofday-64.o arch/powerpc/kernel/vdso/gettimeofday.S Reported-by: Jan-Benedict Glaw Signed-off-by: Christophe Leroy --- v2: When target cpu is powerpc, the option to be used is -mppc Commit 825eada7717c is in

[PATCH] powerpc: Pass correct CPU reference to assembler

2022-12-15 Thread Christophe Leroy
endian -Wl,-soname=linux-vdso64.so.1 -D__VDSO64__ -s -c -o arch/powerpc/kernel/vdso/gettimeofday-64.o arch/powerpc/kernel/vdso/gettimeofday.S Reported-by: Jan-Benedict Glaw Signed-off-by: Christophe Leroy --- Commit 825eada7717c is in powerpc/next-test branch. Make sure the SHA doesn't ch

Re: Mass-building defconfigs: many fail with assembler errors

2022-12-14 Thread Christophe Leroy
Le 15/12/2022 à 07:49, Christophe Leroy a écrit : > > > Le 14/12/2022 à 15:45, Jan-Benedict Glaw a écrit : >> On Tue, 2022-12-13 14:49:20 +1100, Michael Ellerman >> wrote: >> [...] >>> Both treeboot-akebono.c and treeboot-currituck.c are for 476 so should

Re: Mass-building defconfigs: many fail with assembler errors

2022-12-14 Thread Christophe Leroy
Le 14/12/2022 à 15:45, Jan-Benedict Glaw a écrit : > On Tue, 2022-12-13 14:49:20 +1100, Michael Ellerman > wrote: > [...] >> Both treeboot-akebono.c and treeboot-currituck.c are for 476 so should >> probably be built with -mcpu=476. eg: >> >> diff --git a/arch/powerpc/boot/Makefile b/arch/power

Re: [PATCH] [BACKPORT FOR 4.14] libtraceevent: Fix build with binutils 2.35

2022-12-14 Thread Christophe Leroy
Le 13/12/2022 à 21:25, Segher Boessenkool a écrit : > On Tue, Dec 13, 2022 at 07:03:07PM +0100, Christophe Leroy wrote: >> In binutils 2.35, 'nm -D' changed to show symbol versions along with >> symbol names, with the usual @@ separator. > > 2.37 instead? And --w

[PATCH] spi: fsl_spi: Don't change speed while chipselect is active

2022-12-14 Thread Christophe Leroy
eported-by: Herve Codina Fixes: 64ca1a034f00 ("spi: fsl_spi: Convert to transfer_one") Cc: sta...@vger.kernel.org Signed-off-by: Christophe Leroy Tested-by: Herve Codina --- drivers/spi/spi-fsl-spi.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --g

Re: [PATCH] powerpc/64: Implement arch_within_stack_frames

2022-12-14 Thread Christophe Leroy
Le 14/12/2022 à 12:48, Christophe Leroy a écrit : Le 14/12/2022 à 12:39, Nicholas Piggin a écrit : On Wed Dec 14, 2022 at 6:39 PM AEST, Christophe Leroy wrote: Le 14/12/2022 à 05:42, Nicholas Miehlbradt a écrit : Walks the stack when copy_{to,from}_user address is in the stack to

Re: [PATCH] powerpc/64: Implement arch_within_stack_frames

2022-12-14 Thread Christophe Leroy
Le 14/12/2022 à 12:39, Nicholas Piggin a écrit : > On Wed Dec 14, 2022 at 6:39 PM AEST, Christophe Leroy wrote: >> >> >> Le 14/12/2022 à 05:42, Nicholas Miehlbradt a écrit : >>> Walks the stack when copy_{to,from}_user address is in the stack to >>>

Re: [PATCH] powerpc/64: Implement arch_within_stack_frames

2022-12-14 Thread Christophe Leroy
Le 14/12/2022 à 05:42, Nicholas Miehlbradt a écrit : > Walks the stack when copy_{to,from}_user address is in the stack to > ensure that the object being copied is entirely within a single stack > frame. > > Substatially similar to the x86 implementation except using the back > chain to traverse

[PATCH] [BACKPORT FOR 4.14] libtraceevent: Fix build with binutils 2.35

2022-12-13 Thread Christophe Leroy
suffix if present. Signed-off-by: Ben Hutchings Tested-by: Salvatore Bonaccorso Reviewed-by: Steven Rostedt Cc: linux-trace-de...@vger.kernel.org Cc: sta...@vger.kernel.org Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Christophe Leroy --- tools/lib/traceevent/Makefile | 2 +- 1 file

[PATCH] [REBASED for 4.14] once: add DO_ONCE_SLOW() for sleepable contexts

2022-12-13 Thread Christophe Leroy
From: Eric Dumazet [ Upstream commit 62c07983bef9d3e78e71189441e1a470f0d1e653 ] Christophe Leroy reported a ~80ms latency spike happening at first TCP connect() time. This is because __inet_hash_connect() uses get_random_once() to populate a perturbation table which became quite big after

Re: [RFC PATCH] Syscall tracing on PPC64_ELF_ABI_V1 without KALLSYMS_ALL

2022-12-12 Thread Christophe Leroy
king to make all opd symbols available to kallsyms but > that doesn't impact ftrace syscall tracing. > > Cc: Michael Ellerman > Cc: Christophe Leroy > Cc: Mathieu Desnoyers > Signed-off-by: Michael Jeanson > --- > include/asm-generic/sections.h | 14 ++ &g

Re: [PATCH v1 5/5] powerpc/64e: Fix build failure with GCC 12 (unrecognized opcode: `wrteei')

2022-12-11 Thread Christophe Leroy
Le 11/12/2022 à 18:32, Pali Rohár a écrit : > On Monday 11 July 2022 16:19:33 Christophe Leroy wrote: >> With GCC 12, corenet64_smp_defconfig leads to the following build errors: >> >>CC arch/powerpc/kernel/irq.o >> {standard input}: Assembler messages: >

Re: [Bug 214913] [xfstests generic/051] BUG: Kernel NULL pointer dereference on read at 0x00000108 NIP [c0000000000372e4] tm_cgpr_active+0x14/0x40

2022-12-11 Thread Christophe Leroy
Le 12/12/2022 à 04:52, Nicholas Piggin a écrit : > On Sun Dec 11, 2022 at 11:19 PM AEST, wrote: >> https://bugzilla.kernel.org/show_bug.cgi?id=214913 >> >> --- Comment #7 from Zorro Lang (zl...@redhat.com) --- >> (In reply to Michael Ellerman from comment #5) >>> Sorry I don't have any idea whic

Re: [PATCH v6] livepatch: Clear relocation targets on a module removal

2022-12-09 Thread Christophe Leroy
Le 09/12/2022 à 19:30, Song Liu a écrit : > On Fri, Dec 9, 2022 at 4:55 AM Miroslav Benes wrote: >> >> Hi, >> >> first thank you for taking over and I also appologize for not replying >> much sooner. >> >> On Thu, 1 Sep 2022, Song Liu wrote: >> >>> From: Miroslav Benes >>> >>> Josh reported a b

Re: [PATCH v3] powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage

2022-12-08 Thread Christophe Leroy
Le 08/12/2022 à 20:16, Pali Rohár a écrit : > On Sunday 28 August 2022 17:43:53 Christophe Leroy wrote: >> Le 28/08/2022 à 19:41, Pali Rohár a écrit : >>> On Sunday 28 August 2022 17:39:25 Christophe Leroy wrote: >>>> Le 28/08/2022 à 19:33, Christophe Leroy a écri

Re: [PATCH] powerpc/ftrace: fix syscall tracing on PPC64_ELF_ABI_V1

2022-12-07 Thread Christophe Leroy
Le 07/12/2022 à 16:18, Mathieu Desnoyers a écrit : > On 2022-12-06 21:09, Michael Ellerman wrote: >> Mathieu Desnoyers writes: >>> On 2022-12-05 17:50, Michael Ellerman wrote: >>> IMHO the second option would be better because it does not increase the >>> kernel image size as much as KALLSYMS_AL

Re: [PATCH 0/7] powerpc/85xx: p2020: Create one unified machine description

2022-12-07 Thread Christophe Leroy
Le 04/12/2022 à 11:54, Pali Rohár a écrit : > On Friday 19 August 2022 21:15:50 Pali Rohár wrote: >> This patch series unifies all P2020 boards and machine descriptions into >> one generic unified P2020 machine description. With this generic machine >> description, kernel can boot on any P2020-ba

Re: [PATCH 3/7] powerpc/85xx: p2020: Move all P2020 machine descriptions to p2020.c

2022-12-07 Thread Christophe Leroy
Le 26/09/2022 à 12:26, Pali Rohár a écrit : > On Monday 26 September 2022 10:17:26 Christophe Leroy wrote: >> Le 26/09/2022 à 11:53, Pali Rohár a écrit : >>> On Monday 26 September 2022 09:48:02 Christophe Leroy wrote: >>>> Le 19/08/2022 à 21:15, Pali Rohár a éc

Re: [PATCH mm-unstable RFC 17/26] powerpc/mm: support __HAVE_ARCH_PTE_SWP_EXCLUSIVE on 32bit book3s

2022-12-07 Thread Christophe Leroy
ng yet > unused LSB 2 / MSB 29. There seems to be no real reason why that bit cannot > be used, and reusing it avoids having to steal one bit from the swap > offset. > > While at it, mask the type in __swp_entry(). > > Cc: Michael Ellerman > Cc: Nicholas Piggin > Cc

Re: [PATCH v3] powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage

2022-12-07 Thread Christophe Leroy
Le 26/11/2022 à 17:30, Pali Rohár a écrit : > On Wednesday 02 November 2022 14:05:35 Christophe Leroy wrote: >> Le 01/11/2022 à 23:12, Pali Rohár a écrit : >>> On Sunday 09 October 2022 13:06:52 Pali Rohár wrote: >>>> On Monday 29 August 2022 10:54:51 Pali Rohár wr

[PATCH v1] powerpc/64: Set default CPU in Kconfig

2022-12-07 Thread Christophe Leroy
st ensure his compiler has the requested capability. Therefore, remove hidden fallback, instead offer user the possibility to say he wants to use toolchain default. Reported-by: Pali Rohár Signed-off-by: Christophe Leroy --- arch/powerpc/Makefile | 22 +- arch/pow

Re: [PATCH] powerpc/ftrace: fix syscall tracing on PPC64_ELF_ABI_V1

2022-12-06 Thread Christophe Leroy
Le 06/12/2022 à 15:38, Mathieu Desnoyers a écrit : > On 2022-12-05 17:50, Michael Ellerman wrote: >> Michael Jeanson writes: >>> On 2022-12-05 15:11, Michael Jeanson wrote: >>> Michael Jeanson writes: In v5.7 the powerpc syscall entry/exit logic was rewritten in C, on PPC6

<    8   9   10   11   12   13   14   15   16   17   >