file removal issue in tools/testing/selftests/powerpc/mm/tlbie_test.c

2023-06-15 Thread Colin King (gmail)
Hi, Static analysis with cppcheck has found an issue in the following commit: commit 047e6575aec71d75b765c22111820c4776cd1c43 Author: Aneesh Kumar K.V Date: Tue Sep 24 09:22:53 2019 +0530 powerpc/mm: Fixup tlbie vs mtpidr/mtlpidr ordering issue on POWER9 The issue in

[PATCH] powerpc: Fix spelling mistake "mesages" -> "messages" in Kconfig

2021-07-04 Thread Colin King
From: Colin Ian King There is a spelling mistake in the Kconfig text. Fix it. Signed-off-by: Colin Ian King --- arch/powerpc/platforms/ps3/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/ps3/Kconfig b/arch/powerpc/platforms/ps3/Kconfig index

[PATCH][next] ASoC: fsl: fsl_easrc: Fix uninitialized variable st2_mem_alloc

2021-03-03 Thread Colin King
From: Colin Ian King A previous cleanup commit removed the ininitialization of st2_mem_alloc. Fix this by restoring the original behaviour by initializing it to zero. Addresses-Coverity: ("Uninitialized scalar variable") Fixes: e80382fe721f ("ASoC: fsl: fsl_easrc: remove useless assignments")

[PATCH][next] scsi: ibmvfc: Fix spelling mistake "succeded" -> "succeeded"

2021-01-18 Thread Colin King
From: Colin Ian King There is a spelling mistake in a ibmvfc_dbg debug message. Fix it. Signed-off-by: Colin Ian King --- drivers/scsi/ibmvscsi/ibmvfc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c index

[PATCH] powerpc/44x: fix spelling mistake in Kconfig "varients" -> "variants"

2020-12-16 Thread Colin King
From: Colin Ian King There is a spelling mistake in the Kconfig help text. Fix it. Signed-off-by: Colin Ian King --- arch/powerpc/platforms/44x/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/44x/Kconfig b/arch/powerpc/platforms/44x/Kconfig

[PATCH] powerpc: fix spelling mistake in Kconfig "seleted" -> "selected"

2020-12-07 Thread Colin King
From: Colin Ian King There is a spelling mistake in the help text of the Kconfig. Fix it. Signed-off-by: Colin Ian King --- arch/powerpc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index 8fb61a285c76..4010bae52351

[PATCH][V2] macintosh: windfarm: remove detatch debug containing spelling mistakes

2020-08-06 Thread Colin King
From: Colin Ian King There are spelling mistakes in two debug messages. As recommended by Wolfram Sang, these can be removed as there is plenty of debug in the driver core. Signed-off-by: Colin Ian King --- V2: remove the debug rather than fixing the spelling ---

[PATCH] usb: gadget: fix spelling mistake "Dectected" -> "Detected"

2020-08-05 Thread Colin King
From: Colin Ian King There is a spelling mistake in a literal string. Fix it. Signed-off-by: Colin Ian King --- drivers/usb/gadget/udc/fsl_udc_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/fsl_udc_core.c

[PATCH] macintosh: windfarm: fix spelling mistake "detatch" -> "detach"

2020-08-05 Thread Colin King
From: Colin Ian King There are spelling mistakes in DBG messages. Fix them. Signed-off-by: Colin Ian King --- drivers/macintosh/windfarm_lm75_sensor.c | 2 +- drivers/macintosh/windfarm_lm87_sensor.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] powerpc/oprofile: fix spelling mistake "contex" -> "context"

2020-08-04 Thread Colin King
From: Colin Ian King There is a spelling mistake in a pr_debug message. Fix it. Signed-off-by: Colin Ian King --- arch/powerpc/oprofile/cell/spu_task_sync.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/oprofile/cell/spu_task_sync.c

[PATCH][next] ASoC: fsl_easrc: fix spelling mistake "prefitler" -> "prefilter"

2020-04-23 Thread Colin King
From: Colin Ian King There is a spelling mistake in a deb_dbg message, fix it. Signed-off-by: Colin Ian King --- sound/soc/fsl/fsl_easrc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/fsl_easrc.c b/sound/soc/fsl/fsl_easrc.c index 233f26ff885c..97658e1f4989

[PATCH] soc: fsl: qe: clean up an indentation issue

2020-03-27 Thread Colin King
From: Colin Ian King There is a statement that not indented correctly, remove the extraneous space. Signed-off-by: Colin Ian King --- drivers/soc/fsl/qe/ucc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/fsl/qe/ucc.c b/drivers/soc/fsl/qe/ucc.c index

[PATCH][next] soc: fsl: dpio: fix dereference of pointer p before null check

2020-02-21 Thread Colin King
From: Colin Ian King Pointer p is currently being dereferenced before it is null checked on a memory allocation failure check. Fix this by checking if p is null before dereferencing it. Addresses-Coverity: ("Dereference before null check") Fixes: 3b2abda7d28c ("soc: fsl: dpio: Replace QMAN

[PATCH] net/wan/fsl_ucc_hdlc: fix out of bounds write on array utdm_info

2020-01-14 Thread Colin King
From: Colin Ian King Array utdm_info is declared as an array of MAX_HDLC_NUM (4) elements however up to UCC_MAX_NUM (8) elements are potentially being written to it. Currently we have an array out-of-bounds write error on the last 4 elements. Fix this by making utdm_info UCC_MAX_NUM elements in

[PATCH] serial: ucc_uart: remove redundant assignment to pointer bdp

2019-12-19 Thread Colin King
From: Colin Ian King The variable bdp is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/tty/serial/ucc_uart.c |

[PATCH][next] soc: fsl: fix spelling mistake "Firmaware" -> "Firmware"

2019-05-21 Thread Colin King
From: Colin Ian King There is a spelling mistake in a pr_err message. Fix it. Signed-off-by: Colin Ian King --- drivers/soc/fsl/dpaa2-console.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/fsl/dpaa2-console.c b/drivers/soc/fsl/dpaa2-console.c index

[PATCH][next] KVM: PPC: Book3S HV: XIVE: fix spelling mistake "acessing" -> "accessing"

2019-05-02 Thread Colin King
From: Colin Ian King There is a spelling mistake in a pr_err message, fix it. Signed-off-by: Colin Ian King --- arch/powerpc/kvm/book3s_xive_native.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kvm/book3s_xive_native.c

[PATCH][next] powerpc/mm: fix spelling mistake "Outisde" -> "Outside"

2019-04-23 Thread Colin King
From: Colin Ian King There are several identical spelling mistakes in warning messages, fix these. Signed-off-by: Colin Ian King --- arch/powerpc/mm/hash_utils_64.c | 4 ++-- arch/powerpc/mm/pgtable-hash64.c | 2 +- arch/powerpc/mm/pgtable-radix.c | 6 +++--- arch/powerpc/mm/pgtable_64.c

[PATCH][next] ASoC: fsl: fix spelling mistake: "missign" -> "missing"

2019-03-28 Thread Colin King
From: Colin Ian King There is a spelling mistake in a dev_err message. Fix this. Signed-off-by: Colin Ian King --- sound/soc/fsl/imx-audmix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/imx-audmix.c b/sound/soc/fsl/imx-audmix.c index

[PATCH] hotplug/drc-info: ininitialize fndit to zero

2019-03-16 Thread Colin King
From: Colin Ian King Currently variable fndit is not initialized and contains a garbage value, later it is set to 1 if a drc entry is found. Ensure fndit is not containing garbage by initializing it to zero. Also remove an extraneous space at the end of an sprintf call. Detected by static

[PATCH][next] ptp_qoriq: don't pass a large struct by value but instead pass it by reference

2019-02-19 Thread Colin King
From: Colin Ian King Passing the struct ptp_clock_info caps by parameter is passing over 130 bytes of data by value on the stack. Optimize this by passing it by reference instead. Also shinks the object code size: Before: textdata bss dec hex filename 125962160 64

[PATCH][next] soc: fsl: dpio: fix memory leak of a struct qbman on error exit path

2019-02-19 Thread Colin King
From: Colin Ian King Currently the error check for a null reg leaks a struct qbman that was allocated earlier. Fix this by kfree'ing p on the error exit path. Signed-off-by: Colin Ian King --- drivers/soc/fsl/dpio/qbman-portal.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH] Documentation: fix spelling mistake, EACCESS -> EACCES

2018-10-26 Thread Colin King
From: Colin Ian King Trivial fix to a spelling mistake of the error access name EACCESS, rename to EACCES Signed-off-by: Colin Ian King --- Documentation/filesystems/spufs.txt | 2 +- Documentation/gpu/drm-uapi.rst | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH] fsl: remove redundant pointer 'priv'

2018-08-29 Thread Colin King
From: Colin Ian King Pointer 'priv' is being assigned but is never used hence it is redundant and can be removed. Cleans up clang warning: variable 'priv' set but not used [-Wunused-but-set-variable] Signed-off-by: Colin Ian King --- drivers/soc/fsl/dpio/dpio-driver.c | 3 --- 1 file

[PATCH] powerpc/powermac: fix spelling mistake "Usupported" -> "Unsupported"

2018-05-30 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in bootx_printf message text. Signed-off-by: Colin Ian King --- arch/powerpc/platforms/powermac/bootx_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/powermac/bootx_init.c

[PATCH] powerpc-opal: fix spelling mistake "Uniterrupted" -> "Uninterrupted"

2018-05-26 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in hmi_error_types text Signed-off-by: Colin Ian King --- arch/powerpc/platforms/powernv/opal-hmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] powerpc: fix spelling mistake: "Discharching" -> "Discharging"

2018-05-18 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in battery_charging array Signed-off-by: Colin Ian King --- arch/powerpc/kernel/rtas-proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] macintosh/windfarm: fix spelling mistake: "ttarged" -> "ttarget"

2018-05-10 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in debug messages of a structure field name Signed-off-by: Colin Ian King --- drivers/macintosh/windfarm_pm121.c | 2 +- drivers/macintosh/windfarm_pm81.c | 2 +-

[PATCH] crypto: nx: fix spelling mistake: "seqeunce" -> "sequence"

2018-05-09 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in CSB_ERR error message text Signed-off-by: Colin Ian King --- drivers/crypto/nx/nx-842-powernv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] net: ethernet: ucc: fix spelling mistake: "tx-late-collsion" -> "tx-late-collision"

2018-04-28 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in tx_fw_stat_gstrings text Signed-off-by: Colin Ian King --- drivers/net/ethernet/freescale/ucc_geth_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] powerpc: fix spelling mistake: "Usupported" -> "Unsupported"

2018-03-30 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in bootx_printf message text Signed-off-by: Colin Ian King --- arch/powerpc/platforms/powermac/bootx_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] ocxl: fix signed comparison with less than zero

2018-01-30 Thread Colin King
From: Colin Ian King Currently the comparison of used < 0 is always false because uses is a size_t. Fix this by making used a ssize_t type. Detected by Coccinelle: drivers/misc/ocxl/file.c:320:6-10: WARNING: Unsigned expression compared with zero: used < 0 Fixes:

[PATCH] powerpc/xmon: use ARRAY_SIZE on various array sizing calculations

2017-12-07 Thread Colin King
From: Colin Ian King Use the ARRAY_SIZE macro on several arrays to determine their size. Improvement suggested by coccinelle. Signed-off-by: Colin Ian King --- arch/powerpc/xmon/ppc-opc.c | 12 1 file changed, 4 insertions(+), 8

[PATCH] USB: gadget: udc: fix spelling mistake "unexpect" -> "unexpected"

2017-11-24 Thread Colin King
From: Colin Ian King Trival fix to spelling mistake in ERR message Signed-off-by: Colin Ian King --- drivers/usb/gadget/udc/fsl_udc_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH][V2] crypto/nx: fix spelling mistake: "availavle" -> "available"

2017-11-14 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in pr_err error message text. Also fix spelling mistake in proceeding comment. Signed-off-by: Colin Ian King --- drivers/crypto/nx/nx-842-powernv.c | 4 ++-- 1 file changed, 2

[PATCH] crypto/nx: fix spelling mistake: "availavle" -> "available"

2017-11-14 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in pr_err error message text Signed-off-by: Colin Ian King --- drivers/crypto/nx/nx-842-powernv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] ASoC: fsl_spdif: make const arrays rate static

2017-09-03 Thread Colin King
From: Colin Ian King Don't populate the const arrays rate on the stack, instead make them static. Makes the object code smaller by 220 bytes: Before: textdata bss dec hex filename 243859776 128 3428985f1 sound/soc/fsl/fsl_spdif.o

[PATCH] powerpc/pseries: fix spelling mistake: "Attemping" -> "Attempting"

2017-06-04 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in pr_debug message Signed-off-by: Colin Ian King --- arch/powerpc/platforms/pseries/hotplug-cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] fsl_udc_core: fix spelling mistake: "Dectected" -> "Detected"

2017-05-14 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in seq_printf text Signed-off-by: Colin Ian King --- drivers/usb/gadget/udc/fsl_udc_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] drivers/tty/hvc: fix spelling mistake: "missmanaged" -> "mismanaged"

2017-04-22 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in printk message Signed-off-by: Colin Ian King --- drivers/tty/hvc/hvcs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/tty/hvc/hvcs.c

[PATCH] powerpc/xive: fix spelling mistake: "initialize"

2017-04-18 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in pr_info message. Signed-off-by: Colin Ian King --- arch/powerpc/sysdev/xive/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] ps3_gelic: fix spelling mistake in debug message

2016-11-12 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake "unmached" to "unmatched" in debug message. Signed-off-by: Colin Ian King --- drivers/net/ethernet/toshiba/ps3_gelic_wireless.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] soc/fsl: fix spelling mistakes in critical error messages

2016-11-12 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake "uncommited" to "uncommitted" in critical error messages. Signed-off-by: Colin Ian King --- drivers/soc/fsl/qbman/bman.c | 2 +- drivers/soc/fsl/qbman/qman.c | 2 +- 2 files changed, 2

[PATCH] powerpc/pseries: fix spelling mistake: "Attemping" -> "Attempting"

2016-10-24 Thread Colin King
From: Colin Ian King trivial fix to spelling mistake in pr_debug message Signed-off-by: Colin Ian King --- arch/powerpc/platforms/pseries/hotplug-cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] net: ps3_gelic: Add missing \n to end of deb_dbg message

2016-10-04 Thread Colin King
From: Colin Ian King Trival fix, dev_dbg message is missing a \n, so add it. Signed-off-by: Colin Ian King --- drivers/net/ethernet/toshiba/ps3_gelic_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] powerpc/32: add missing \n at end of printk warning message

2016-09-12 Thread Colin King
From: Colin Ian King The message is missing a \n, add it. Signed-off-by: Colin Ian King --- arch/powerpc/mm/init_32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/mm/init_32.c b/arch/powerpc/mm/init_32.c

[PATCH] ASoC: fsl_esai: fix spelling mistake "Transmition" -> "Transmission"

2016-09-02 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistakes in dev_dbg messages Signed-off-by: Colin Ian King --- sound/soc/fsl/fsl_esai.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/fsl/fsl_esai.c

[PATCH] net: ucc_geth: fix spelling mistake "propperty" -> "property"

2016-08-28 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in dev_warn message. Signed-off-by: Colin Ian King --- drivers/net/ethernet/freescale/ucc_geth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] powerpc/ps3: fix spelling mistake in function name

2016-08-28 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in dev_warn message and remove extraneous trailing whitespace at end of the message. Signed-off-by: Colin Ian King --- arch/powerpc/platforms/ps3/device-init.c | 2 +- 1 file changed, 1

[PATCH] wan/fsl_ucc_hdlc: fix spelling mistake "prameter" -> "parameter"

2016-08-28 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in dev_err message. Signed-off-by: Colin Ian King --- drivers/net/wan/fsl_ucc_hdlc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wan/fsl_ucc_hdlc.c

[PATCH] ASoC: fsl_spdif: fix spelling mistake: "receivce" -> "receive"

2016-06-28 Thread Colin King
From: Colin Ian King trivial fix to spelling mistake in dev_err message Signed-off-by: Colin Ian King --- sound/soc/fsl/fsl_spdif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/fsl_spdif.c

[PATCH][V2] powerpc/fadump: trivial fix of spelling mistake, clean up message

2016-06-27 Thread Colin King
From: Colin Ian King Fix trivial spelling mistake "rgistration". Also use pr_err instead of printk and unsplit the string to keep it all on one line. Signed-off-by: Colin Ian King --- arch/powerpc/kernel/fadump.c | 6 +++--- 1 file changed,

[PATCH] powerpc/fadump: trivial fix of spelling mistake, clean up message

2016-06-24 Thread Colin King
From: Colin Ian King trivial fix to spelling mistake "rgistration" and minor clean up of the printk error message Signed-off-by: Colin Ian King --- arch/powerpc/kernel/fadump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] powerpc/powernv: spelling mistake: "Retrived" -> "Retrieved"

2016-06-23 Thread Colin King
From: Colin Ian King trivial fix to spelling mistake in pr_debug message Signed-off-by: Colin Ian King --- arch/powerpc/platforms/powernv/opal-memory-errors.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] powerpc/pseries/hvcserver: don't memset pi_buff if it is null

2015-10-08 Thread Colin King
From: Colin Ian King pi_buff is being memset before it is sanity checked. Move the memset after the null pi_buff sanity check to avoid an oops. Signed-off-by: Colin Ian King --- arch/powerpc/platforms/pseries/hvcserver.c | 2 +- 1 file

[PATCH] ps3-vuart: BUG_ON on null drv before dereferencing it on dev_dbg

2015-09-01 Thread Colin King
From: Colin Ian King On the unlikely event that drv is null, the current code will perform a null pointer dereference with it when printing a dev_dbg message. Instead, the BUG_ON check on drv should be performed before we emit the dev_dbg message. Signed-off-by: Colin

[PATCH] cxl: remove redundant increment of hwirq

2015-02-01 Thread Colin King
From: Colin Ian King colin.k...@canonical.com Recent commit 80fa93fce37d3490f (cxl: Name interrupts in /proc/interrupt) introduced a redundant increment of hwirq which is not used or even initialised at the point it is incremented. Detected by cppcheck: [drivers/misc/cxl/irq.c:439]: (error)

[PATCH] cxl: remove redundant increment of hwirq

2015-01-08 Thread Colin King
From: Colin Ian King colin.k...@canonical.com hwirq has not been initialized, however it is being incremented and also not being referenced in a loop. This error was detected with cppcheck: [drivers/misc/cxl/irq.c:439]: (error) Uninitialized variable: hwirq Commit 80fa93fce37d (cxl: Name