Re: [PATCH] powerpc/vio: use simple dummy struct device as bus parent

On Fri, Sep 27, 2019 at 2:19 PM Greg Kroah-Hartman wrote: > > On Fri, Sep 27, 2019 at 09:04:02AM -0400, Dan Streetman wrote: > > The dummy vio_bus_device creates the /sys/devices/vio directory, which > > contains real vio devices under it; since it represents itself a

Re: [PATCH] powerpc/vio: use simple dummy struct device as bus parent

On Sat, Sep 28, 2019 at 3:41 AM Greg Kroah-Hartman wrote: > > On Fri, Sep 27, 2019 at 03:48:49PM -0400, Dan Streetman wrote: > > On Fri, Sep 27, 2019 at 2:19 PM Greg Kroah-Hartman > > wrote: > > > > > > On Fri, Sep 27, 2019 at 09:04:02AM -0400, Da

Re: [PATCH] powerpc/vio: use simple dummy struct device as bus parent

On Fri, Sep 27, 2019 at 2:19 PM Greg Kroah-Hartman wrote: > > On Fri, Sep 27, 2019 at 09:04:02AM -0400, Dan Streetman wrote: > > The dummy vio_bus_device creates the /sys/devices/vio directory, which > > contains real vio devices under it; since it represents itself a

[PATCH] powerpc/vio: use simple dummy struct device as bus parent

in udevadm to ignore ENODEV errors, but the vio driver should still be fixed. This patch changes the arch/powerpc/platform/pseries/vio.c 'dummy' parent device into a real dummy device with no .bus, so its uevent file will stop returning ENODEV and simply do nothing and return 0. Signed-off-by: Dan

Re: [PATCH] crypto: nx-842: Delete an error message for a failed memory allocation in nx842_pseries_init()

is issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Reviewed-by: Dan Streetman <ddstr...@ieee.org> > --- > drivers/crypto/nx/nx-842-pseries.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletio

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

On Sun, Sep 3, 2017 at 4:32 AM, Haren Myneni <ha...@linux.vnet.ibm.com> wrote: > On 09/02/2017 09:17 AM, Dan Streetman wrote: >> On Sat, Sep 2, 2017 at 4:40 AM, Haren Myneni <ha...@linux.vnet.ibm.com> >> wrote: >>> On 08/29/2017 06:58 AM, Dan Streetman wrote:

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

On Sat, Sep 2, 2017 at 4:40 AM, Haren Myneni <ha...@linux.vnet.ibm.com> wrote: > On 08/29/2017 06:58 AM, Dan Streetman wrote: >> On Sat, Jul 22, 2017 at 1:01 AM, Haren Myneni <ha...@linux.vnet.ibm.com> >> wrote: >>> >>> This patch adds P9 N

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

On Fri, Sep 1, 2017 at 7:29 AM, Michael Ellerman <m...@ellerman.id.au> wrote: > Hi Dan, > > Thanks for reviewing this series. > > Dan Streetman <ddstr...@ieee.org> writes: >> On Tue, Aug 29, 2017 at 5:54 PM, Haren Myneni <ha...@linux.vnet.ibm.com> >>

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

On Thu, Aug 31, 2017 at 3:44 AM, Haren Myneni <ha...@linux.vnet.ibm.com> wrote: > Thanks MIchael and Dan for your review comments. > > > On 08/29/2017 06:32 AM, Dan Streetman wrote: >> On Mon, Aug 28, 2017 at 7:25 PM, Michael Ellerman <m...@ellerman.id.au> >&g

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

On Tue, Aug 29, 2017 at 5:54 PM, Haren Myneni <ha...@linux.vnet.ibm.com> wrote: > On 08/29/2017 02:23 PM, Benjamin Herrenschmidt wrote: >> On Tue, 2017-08-29 at 09:58 -0400, Dan Streetman wrote: >>>> + >>>> + ret = -EINVAL; >&

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

Support for PowerPC Nest (NX) compression acceleration. This > diff --git a/drivers/crypto/nx/nx-842-powernv.c > b/drivers/crypto/nx/nx-842-powernv.c > index c0dd4c7e17d3..13089a0b9dfa 100644 > --- a/drivers/crypto/nx/nx-842-powernv.c > +++ b/drivers/crypto/nx/nx-842-powern

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

On Mon, Aug 28, 2017 at 7:25 PM, Michael Ellerman wrote: > Hi Haren, > > Some comments inline ... > > Haren Myneni writes: > >> diff --git a/drivers/crypto/nx/nx-842-powernv.c >> b/drivers/crypto/nx/nx-842-powernv.c >> index

Re: [PATCH v3 02/10] Move GET_FIELD/SET_FIELD to vas.h

vers > and skiboot. For consistency switch the order of parameters in > SET_FIELD to match the order in skiboot. > > Signed-off-by: Sukadev Bhattiprolu <suka...@linux.vnet.ibm.com> Reviewed-by: Dan Streetman <ddstr...@ieee.org> also, can you change the MAINTAINERS f

Re: [PATCH v2 02/10] Move GET_FIELD/SET_FIELD to vas.h

.vnet.ibm.com> Reviewed-by: Dan Streetman <dan.street...@canonical.com> > --- > arch/powerpc/include/asm/vas.h | 8 > drivers/crypto/nx/nx-842-powernv.c | 1 + > drivers/crypto/nx/nx-842.h | 5 - > 3 files changed, 9 insertions(+), 5 deletions(-) > &

Re: crypto/nx842: Ignore queue overflow informative error

On Sun, Dec 6, 2015 at 2:46 AM, Haren Myneni wrote: > > NX842 coprocessor sets bit 3 if queue is overflow. It is just for > information to the user. So the driver prints this informative message > and ignores it. > > Signed-off-by: Haren Myneni > >

Re: crypto/nx842: Ignore queue overflow informative error

On Sun, Dec 6, 2015 at 5:57 PM, Daniel Axtens wrote: > Haren Myneni writes: > >> NX842 coprocessor sets bit 3 if queue is overflow. It is just for >> information to the user. So the driver prints this informative message >> and ignores it. > > What

Re: [PATCH 5/6] [RFC] crypto/testmgr: add null test for 842 algorithm

On Mon, Jul 13, 2015 at 8:05 PM, Nishanth Aravamudan n...@linux.vnet.ibm.com wrote: On 13.07.2015 [17:05:36 -0700], Nishanth Aravamudan wrote: On 04.07.2015 [15:24:53 +0800], Herbert Xu wrote: On Thu, Jul 02, 2015 at 03:41:19PM -0700, Nishanth Aravamudan wrote: Currently, when the

Re: [PATCH 6/6] nx-842-platform: if NX842 platform drivers are not modules, don't try to load them

...@linux.vnet.ibm.com Cc: Dan Streetman ddstr...@us.ibm.com Cc: Herbert Xu herb...@gondor.apana.org.au Cc: David S. Miller da...@davemloft.net Cc: linux-cry...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Ugh, I think this whole thing is redundant. The whole point of the crypto API is to allow

[PATCH 06/10] drivers/crypto/nx: add NX-842 platform frontend driver

-off-by: Dan Streetman ddstr...@ieee.org --- MAINTAINERS| 2 +- drivers/crypto/Kconfig | 10 +-- drivers/crypto/nx/Kconfig | 35 ++--- drivers/crypto/nx/Makefile | 4 +- drivers/crypto/nx/nx-842-pseries.c | 57 +++ drivers

[PATCHv3 00/10] add 842 hw compression for PowerNV platform

name 842, and different driver names, 842-generic and 842-nx Dan Streetman (10): powerpc: export of_get_ibm_chip_id function powerpc: Add ICSWX instruction lib: add software 842 compression/decompression crypto: change 842 alg to use software drivers/crypto/nx: rename nx-842.c to nx-842

[PATCH 08/10] drivers/crypto/nx: add PowerNV platform NX-842 driver

Add driver for NX-842 hardware on the PowerNV platform. This allows the use of the 842 compression hardware coprocessor on the PowerNV platform. Signed-off-by: Dan Streetman ddstr...@ieee.org --- drivers/crypto/nx/Kconfig | 10 + drivers/crypto/nx/Makefile | 2 + drivers

[PATCH 05/10] drivers/crypto/nx: rename nx-842.c to nx-842-pseries.c

-off-by: Dan Streetman ddstr...@ieee.org --- drivers/crypto/nx/Makefile |2 +- drivers/crypto/nx/nx-842-pseries.c | 1603 drivers/crypto/nx/nx-842.c | 1603 3 files changed, 1604 insertions(+), 1604

[PATCH 01/10] powerpc: export of_get_ibm_chip_id function

Export the of_get_ibm_chip_id() function. This will be used by the PowerNV NX-842 driver. Signed-off-by: Dan Streetman ddstr...@ieee.org --- arch/powerpc/kernel/prom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/kernel/prom.c b/arch/powerpc/kernel/prom.c index 308c5e1

[PATCH 04/10] crypto: change 842 alg to use software

/decompression library. Signed-off-by: Dan Streetman ddstr...@ieee.org --- MAINTAINERS| 1 + crypto/842.c | 174 - crypto/Kconfig | 7 +-- 3 files changed, 41 insertions(+), 141 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 116af01

[PATCH 10/10] drivers/crypto/nx: add hardware 842 crypto comp alg

-by: Dan Streetman ddstr...@ieee.org --- drivers/crypto/nx/Kconfig | 10 + drivers/crypto/nx/Makefile| 2 + drivers/crypto/nx/nx-842-crypto.c | 585 ++ 3 files changed, 597 insertions(+) create mode 100644 drivers/crypto/nx/nx-842-crypto.c diff

[PATCH 03/10] lib: add software 842 compression/decompression

patch to provide a full software 842 compression and decompression crypto interface. Signed-off-by: Dan Streetman ddstr...@ieee.org --- MAINTAINERS | 2 + include/linux/sw842.h| 12 + lib/842/842.h| 127 ++ lib/842/842_compress.c | 626

[PATCH 07/10] drivers/crypto/nx: add nx842 constraints

the 842 hardware requires buffers to meet specific constraints that vary based on platform - for example, the pSeries max length is much lower than the PowerNV max length. Signed-off-by: Dan Streetman ddstr...@ieee.org --- drivers/crypto/nx/nx-842-pseries.c | 10 ++ drivers/crypto/nx/nx-842.c

[PATCH 02/10] powerpc: Add ICSWX instruction

for communication with the NX-842 coprocessor on a PowerNV system. Signed-off-by: Dan Streetman ddstr...@ieee.org --- arch/powerpc/include/asm/icswx.h | 184 ++ arch/powerpc/include/asm/ppc-opcode.h | 13 +++ 2 files changed, 197 insertions(+) create mode

[PATCH 09/10] drivers/crypto/nx: simplify pSeries nx842 driver

if any hardware 842 driver fails. Signed-off-by: Dan Streetman ddstr...@ieee.org --- drivers/crypto/nx/nx-842-pseries.c | 779 - 1 file changed, 153 insertions(+), 626 deletions(-) diff --git a/drivers/crypto/nx/nx-842-pseries.c b/drivers/crypto/nx/nx-842

Re: [PATCH 10/10] drivers/crypto/nx: add hardware 842 crypto comp alg

On Wed, May 6, 2015 at 11:12 PM, Herbert Xu herb...@gondor.apana.org.au wrote: On Wed, May 06, 2015 at 12:51:06PM -0400, Dan Streetman wrote: Add crypto compression alg for 842 hardware compression and decompression. This crypto compression alg is named nx842 to indicate it uses hardware

[PATCH 08/10] drivers/crypto/nx: add PowerNV platform NX-842 driver

Add driver for NX-842 hardware on the PowerNV platform. This allows the use of the 842 compression hardware coprocessor on the PowerNV platform. Signed-off-by: Dan Streetman ddstr...@ieee.org --- drivers/crypto/nx/Kconfig | 10 + drivers/crypto/nx/Makefile | 2 + drivers

[PATCH 09/10] drivers/crypto/nx: simplify pSeries nx842 driver

if any hardware 842 driver fails. Signed-off-by: Dan Streetman ddstr...@ieee.org --- drivers/crypto/nx/nx-842-pseries.c | 779 - 1 file changed, 153 insertions(+), 626 deletions(-) diff --git a/drivers/crypto/nx/nx-842-pseries.c b/drivers/crypto/nx/nx-842

[PATCH 01/10] powerpc: export of_get_ibm_chip_id function

Export the of_get_ibm_chip_id() function. This will be used by the PowerNV NX-842 driver. Signed-off-by: Dan Streetman ddstr...@ieee.org --- arch/powerpc/kernel/prom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/kernel/prom.c b/arch/powerpc/kernel/prom.c index 308c5e1

[PATCH 07/10] drivers/crypto/nx: add nx842 constraints

the 842 hardware requires buffers to meet specific constraints that vary based on platform - for example, the pSeries max length is much lower than the PowerNV max length. Signed-off-by: Dan Streetman ddstr...@ieee.org --- drivers/crypto/nx/nx-842-pseries.c | 10 ++ drivers/crypto/nx/nx-842.c

[PATCHv2 00/10] add 842 hw compression for PowerNV platform

since the last patch series; I didn't list specific differences since there are so many. Dan Streetman (10): powerpc: export of_get_ibm_chip_id function powerpc: Add ICSWX instruction lib: add software 842 compression/decompression crypto: change 842 alg to use software drivers/crypto/nx

[PATCH 06/10] drivers/crypto/nx: add NX-842 platform frontend driver

-off-by: Dan Streetman ddstr...@ieee.org --- MAINTAINERS| 2 +- drivers/crypto/Kconfig | 10 +-- drivers/crypto/nx/Kconfig | 35 ++--- drivers/crypto/nx/Makefile | 4 +- drivers/crypto/nx/nx-842-pseries.c | 57 +++ drivers

[PATCH 03/10] lib: add software 842 compression/decompression

patch to provide a full software 842 compression and decompression crypto interface. Signed-off-by: Dan Streetman ddstr...@ieee.org --- MAINTAINERS | 2 + include/linux/sw842.h| 12 + lib/842/842.h| 127 ++ lib/842/842_compress.c | 626

[PATCH 10/10] drivers/crypto/nx: add hardware 842 crypto comp alg

the + * GNU General Public License for more details. + * + * Copyright (C) IBM Corporation, 2011-2015 + * + * Original Authors: Robert Jennings r...@linux.vnet.ibm.com + * Seth Jennings sjenn...@linux.vnet.ibm.com + * + * Rewrite: Dan Streetman ddstr...@ieee.org

[PATCH 04/10] crypto: change 842 alg to use software

/decompression library. Since users of the 842 alg expected hardware compression, the name of this software-only alg is changed to sw842; the new hardware 842 crypto compression alg will be aliased to 842 in a later patch. Signed-off-by: Dan Streetman ddstr...@ieee.org --- MAINTAINERS| 1 + crypto/842

[PATCH 05/10] drivers/crypto/nx: rename nx-842.c to nx-842-pseries.c

-off-by: Dan Streetman ddstr...@ieee.org --- drivers/crypto/nx/Makefile |2 +- drivers/crypto/nx/nx-842-pseries.c | 1603 drivers/crypto/nx/nx-842.c | 1603 3 files changed, 1604 insertions(+), 1604

[PATCH 02/10] powerpc: Add ICSWX instruction

for communication with the NX-842 coprocessor on a PowerNV system. Signed-off-by: Dan Streetman ddstr...@ieee.org --- arch/powerpc/include/asm/icswx.h | 184 ++ arch/powerpc/include/asm/ppc-opcode.h | 13 +++ 2 files changed, 197 insertions(+) create mode

Re: [PATCH 09/11] crypto: remove LZO fallback from crypto 842

On Wed, Apr 8, 2015 at 10:38 AM, Herbert Xu herb...@gondor.apana.org.au wrote: On Wed, Apr 08, 2015 at 10:28:23AM -0400, Dan Streetman wrote: So, the sw implementation is only for decompression; there's no sw compression implementation in these patches. As a general rule we don't add any

Re: [PATCH 09/11] crypto: remove LZO fallback from crypto 842

On Wed, Apr 8, 2015 at 10:16 AM, Herbert Xu herb...@gondor.apana.org.au wrote: On Tue, Apr 07, 2015 at 01:34:28PM -0400, Dan Streetman wrote: Update the crypto 842 driver to no longer fallback to LZO if the 842 hardware is unavailable. Simplify the crpypto 842 driver to remove all headers

Re: [PATCH 11/11] crypto: add crypto compression sefltest

On Wed, Apr 8, 2015 at 10:16 AM, Herbert Xu herb...@gondor.apana.org.au wrote: On Tue, Apr 07, 2015 at 01:34:30PM -0400, Dan Streetman wrote: Add configurable module to perform self-tests on any crypto compression driver. This allows testing any crypto compression driver with any input buffer

[PATCH] devicetree: add ibm-nx-powernv details

Add a devicetree description for property nodes for the NX Coprocessor in an IBM PowerPC processor. Signed-off-by: Dan Streetman ddstr...@ieee.org --- Is this the right location/naming for this file? And did I get the content format right? Should this file be called ibm-nx-opal.txt instead

[PATCH 04/11] drivers/crypto/nx: move nx-842.c to nx-842-pseries.c

-off-by: Dan Streetman ddstr...@ieee.org --- drivers/crypto/nx/Makefile |2 +- drivers/crypto/nx/nx-842-pseries.c | 1603 drivers/crypto/nx/nx-842.c | 1603 3 files changed, 1604 insertions(+), 1604

[PATCH 05/11] drivers/crypto/nx: add NX-842 platform frontend driver

Add NX-842 frontend that allows using either the pSeries platform or PowerNV platform driver for the NX-842 hardware. Update the MAINTAINERS file to include the new filenames. Signed-off-by: Dan Streetman ddstr...@ieee.org --- MAINTAINERS| 2 +- crypto/842.c

[PATCH 08/11] drivers/crypto/nx: simplify pSeries nx842 driver

-off-by: Dan Streetman ddstr...@ieee.org --- drivers/crypto/nx/nx-842-pseries.c | 779 - 1 file changed, 153 insertions(+), 626 deletions(-) diff --git a/drivers/crypto/nx/nx-842-pseries.c b/drivers/crypto/nx/nx-842-pseries.c index 3773e36..0b7bad3 100644

[PATCH 07/11] drivers/crypto/nx: add PowerNV platform NX-842 driver

Add driver for NX-842 hardware on the PowerNV platform. This allows the use of the 842 compression hardware coprocessor on the PowerNV platform. Signed-off-by: Dan Streetman ddstr...@ieee.org --- drivers/crypto/nx/Kconfig | 10 + drivers/crypto/nx/Makefile | 2 + drivers

[PATCH 03/11] crypto: add software 842 decompression

function is required by later patches that update the crypto 842 driver to fall back to software 842 decompression if the NX-842 hardware fails and/or returns an error. Signed-off-by: Dan Streetman ddstr...@ieee.org --- MAINTAINERS | 2 + include/linux/sw842.h| 7 + lib/842

[PATCH 01/11] powerpc: export of_get_ibm_chip_id function

Export the of_get_ibm_chip_id() function. This will be used by the PowerNV NX-842 driver. Signed-off-by: Dan Streetman ddstr...@ieee.org --- arch/powerpc/kernel/prom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/kernel/prom.c b/arch/powerpc/kernel/prom.c index b8e15c6

[PATCH 11/11] crypto: add crypto compression sefltest

by the compressor during compression or decompression will end the test and be logged. Signed-off-by: Dan Streetman ddstr...@ieee.org --- crypto/Kconfig | 9 + crypto/Makefile| 1 + crypto/comp_selftest.c | 928 + 3 files changed, 938

[PATCH 00/11] add 842 hw compression for PowerNV platform

variable alignment and length buffers, multiple threads, and can calculate the throughput. Dan Streetman (11): powerpc: export of_get_ibm_chip_id function powerpc: Add ICSWX instruction crypto: add software 842 decompression drivers/crypto/nx: move nx-842.c to nx-842-pseries.c drivers/crypto/nx

[PATCH 02/11] powerpc: Add ICSWX instruction

for communication with the NX-842 coprocessor on a PowerNV system. Signed-off-by: Dan Streetman ddstr...@ieee.org --- arch/powerpc/include/asm/icswx.h | 184 ++ arch/powerpc/include/asm/ppc-opcode.h | 13 +++ 2 files changed, 197 insertions(+) create mode

[PATCH 06/11] drivers/crypto/nx: add nx842 constraints

the 842 hardware requires buffers to meet specific constraints that vary based on platform - for example, the pSeries max length is much lower than the PowerNV max length. These constraints are used by a later patch that improves the crypto 842 driver. Signed-off-by: Dan Streetman ddstr...@ieee.org

[PATCH 09/11] crypto: remove LZO fallback from crypto 842

/decompression. The user of the crypto 842 driver can fallback to another format if desired. Signed-off-by: Dan Streetman ddstr...@ieee.org --- crypto/842.c | 139 - crypto/Kconfig | 4 +- 2 files changed, 29 insertions(+), 114 deletions

Re: [PATCH] mm: vmscan: do not throttle based on pfmemalloc reserves if node has no reclaimable zones

on this call to pfmemalloc_watermark_ok() and thus seems like a reasonable additional condition. With this change, the afore-mentioned 16M hugepage allocation succeeds and correctly round-robins between Nodes 1 and 3. Signed-off-by: Nishanth Aravamudan n...@linux.vnet.ibm.com Reviewed-by: Dan

Re: [PATCH linux-next] Documentation: Build mic/mpssd only for x86_64

On Fri, Dec 5, 2014 at 1:18 PM, Ashutosh Dixit ashutosh.di...@intel.com wrote: On Thu, Dec 04 2014 at 07:27:06 PM, Dan Streetman ddstr...@ieee.org wrote: On Thu, Dec 4, 2014 at 4:27 PM, Ashutosh Dixit ashutosh.di...@intel.com wrote: mic/mpssd along with MIC drivers are currently only usable

Re: [PATCH linux-next] Documentation: Build mic/mpssd only for x86_64

the point of leaving the htole16() et. al. functions in mpssd.c? Shouldn't they be removed? Reported-by: Daniel Borkmann dbork...@redhat.com Reported-by: Dan Streetman ddstr...@gmail.com Suggested-by: Peter Foley pefol...@pefoley.com Signed-off-by: Ashutosh Dixit ashutosh.di...@intel.com

[PATCH] powerpc: use device_online/offline() instead of cpu_up/down()

/removed using dlpar operations; without this patch, the /sys/devices/system/cpu/cpuN/online nodes do not correctly show the online state of added/removed cpus. Signed-off-by: Dan Streetman ddstr...@ieee.org Cc: Nathan Fontenot nf...@linux.vnet.ibm.com --- Previous discussion for this: https

Re: [PATCH] drivers/crypto/nx: prevent oops on module exit

Yep, I own the driver now, I'll send a maintainers patch. On Thu, Oct 16, 2014 at 6:52 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Fri, 2014-10-17 at 09:43 +1100, Michael Ellerman wrote: On Thu, 2014-10-16 at 15:30 -0400, Dan Streetman wrote: Check old_devdata-dev in nx-842

[PATCH] MAINTAINERS: nx-842 driver maintainer change

Change maintainer of nx-842 compression coprocessor driver to Dan Streetman. Signed-off-by: Dan Streetman ddstr...@ieee.org Cc: Nathan Fontenot nf...@linux.vnet.ibm.com --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index b0f17d5

[PATCH] drivers/crypto/nx: prevent oops on module exit

Check old_devdata-dev in nx-842 driver before accessing it, as on systems without any nx-842 hardware, the -dev will never be set. Currently, the module will cause an oops during unload since old_devdata-dev is null. Signed-off-by: Dan Streetman ddstr...@ieee.org --- Also Seth and Rob, you guys