On 2021-06-10 07:52, Lijun Pan wrote:
On Thu, Jun 10, 2021 at 7:56 AM Wang Hai wrote:
Convert list_for_each() to list_for_each_entry() where
applicable. This simplifies the code.
Reported-by: Hulk Robot
Signed-off-by: Wang Hai
---
Acked-by: Lijun Pan
Reviewed-by: Dany Madden
On 2021-05-04 12:31, Lijun Pan wrote:
On Tue, May 4, 2021 at 2:27 PM Lijun Pan wrote:
On Tue, May 4, 2021 at 2:14 PM Dany Madden wrote:
>
> When ibmvnic gets a FATAL error message from the vnicserver, it marks
> the Command Respond Queue (CRQ) inactive and resets the adapter. If thi
.
Fixes: ed651a10875f ("ibmvnic: Updated reset handling")
Signed-off-by: Dany Madden
Reviewed-by: Rick Lindsley
Reviewed-by: Sukadev Bhattiprolu
---
Changes in V2:
- Update description to clarify background for the patch
- Include Reviewed-by tags
Changes in V3:
- Add comment above the c
On 2021-04-22 19:26, Rick Lindsley wrote:
On 4/22/21 10:21 AM, Michal Suchánek wrote:
Merging do_reset and do_hard_reset might be a good code cleanup which
is
out of the scope of this fix.
I agree, on both points. Accepting the patch, and improving the reset
path are not in conflict with
.
Fixes: ed651a10875f ("ibmvnic: Updated reset handling")
Signed-off-by: Dany Madden
Reviewed-by: Rick Lindsley
Reviewed-by: Sukadev Bhattiprolu
---
Changes in V2:
- Update description to clarify background for the patch
- Include Reviewed-by tags
---
drivers/net/ethernet/ibm/ibm
On 2021-01-20 22:20, Lijun Pan wrote:
Returning -EBUSY in ibmvnic_remove() does not actually hold the
removal procedure since driver core doesn't care for the return
value (see __device_release_driver() in drivers/base/dd.c
calling dev->bus->remove()) though vio_bus_remove
(in
On 2021-01-17 02:12, Uwe Kleine-König wrote:
Hello,
while working on some cleanup I stumbled over a problem in the
ibmvnic's
remove callback. Since commit
7d7195a026ba ("ibmvnic: Do not process device remove during
device reset")
there is the following code in the remove callback:
Inconsistent login with the vnicserver is causing the device to be
removed. This does not give the device a chance to recover from error
state. This patch schedules a FATAL reset instead to bring the adapter
up.
Fixes: 032c5e82847a2 ("Driver for IBM System i/p VNIC protocol")
Signed-of
ine for setting adapter
link state")
Signed-off-by: Dany Madden
---
drivers/net/ethernet/ibm/ibmvnic.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c
b/drivers/net/ethernet/ibm/ibmvnic.c
index a17856be2828..d6b2686aed0f 1006
is if we get a PARITALSUCCESS response
from the partner.
Fixes: 032c5e82847a2 ("Driver for IBM System i/p VNIC protocol")
Signed-off-by: Dany Madden
Signed-off-by: Sukadev Bhattiprolu
---
drivers/net/ethernet/ibm/ibmvnic.c | 18 --
1 file changed, 12 insertions(+), 6 deletion
Reset timeout is going off right after adapter reset. This patch ensures
that timeout is scheduled if it has been 5 seconds since the last reset.
5 seconds is the default watchdog timeout.
Fixes: ed651a10875f1 ("ibmvnic: Updated reset handling")
Signed-off-by: Dany Madden
---
d
From: Sukadev Bhattiprolu
If after ibmvnic sends a LOGIN it gets a FAILOVER, it is possible that
the worker thread will start reset process and free the login response
buffer before it gets a (now stale) LOGIN_RSP. The ibmvnic tasklet will
then try to access the login response buffer and crash.
free_all_rwi().
Fixes: ed651a10875f1 ("ibmvnic: Updated reset handling")
Signed-off-by: Dany Madden
---
drivers/net/ethernet/ibm/ibmvnic.c | 22 +++---
1 file changed, 3 insertions(+), 19 deletions(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c
b/drivers/net/et
scrq->msgs could be NULL during device reset, causing Linux to crash.
So, check before memset scrq->msgs.
Fixes: c8b2ad0a4a901 ("ibmvnic: Sanitize entire SCRQ buffer on reset")
Signed-off-by: Dany Madden
Signed-off-by: Lijun Pan
---
drivers/net/ethernet/ib
From: Sukadev Bhattiprolu
If auto-priority failover is enabled, the backing device needs time
to settle if hard resetting fails for any reason. Add a delay of 60
seconds before retrying the hard-reset.
Fixes: 2770a7984db5 ("ibmvnic: Introduce hard reset recovery")
Signed-off-by: Sukadev
et so
linkwatch_event can run")
Fixes: 2770a7984db58 ("ibmvnic: Introduce hard reset recovery")
Signed-off-by: Dany Madden
---
drivers/net/ethernet/ibm/ibmvnic.c | 67 --
1 file changed, 36 insertions(+), 31 deletions(-)
diff --git a/drivers/net/ether
"ibmvnic: remove free_all_rwi function" into
ibmvnic: stop free_all_rwi on failed reset.
Dany Madden (7):
ibmvnic: handle inconsistent login with reset
ibmvnic: stop free_all_rwi on failed reset
ibmvnic: avoid memset null scrq msgs
ibmvnic: restore adapter state on failed reset
This reverts commit 16b5f5ce351f8709a6b518cc3cbf240c378305bf
where it restructures do_reset. There are patches being tested that
would require major rework if this is committed first.
We will resend this after the other patches have been applied.
Signed-off-by: Dany Madden
---
drivers/net
Update supporters for IBM Power SRIOV Virtual NIC Device Driver.
Thomas Falcon is moving on to other works. Dany Madden, Lijun Pan
and Sukadev Bhattiprolu are the current supporters.
Signed-off-by: Dany Madden
---
MAINTAINERS | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff
to safe handle NULL pointer case.
Signed-off-by: Mingming Cao
Signed-off-by: Dany Madden
---
drivers/net/ethernet/ibm/ibmvnic.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c
b/drivers/net/ethernet/ibm/ibmvnic.c
index
to safe handle NULL pointer case.
Signed-off-by: Mingming Cao
Signed-off-by: Dany Madden
---
drivers/net/ethernet/ibm/ibmvnic.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c
b/drivers/net/ethernet/ibm/ibmvnic.c
index
and reset_rx_pools to safe handle NULL pointer case.
Signed-off-by: Mingming Cao
Signed-off-by: Dany Madden
---
drivers/net/ethernet/ibm/ibmvnic.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c
b/drivers/net/ethernet/ibm/ibmvnic.c
index
Continue the reset path when partner adapter is not ready or H_CLOSED is
returned from reset crq. This patch allows the CRQ init to proceed to
establish a valid CRQ for traffic to flow after reset.
Signed-off-by: Dany Madden
---
drivers/net/ethernet/ibm/ibmvnic.c | 9 +++--
1 file changed
23 matches
Mail list logo