Re: [PATCH v12 13/14] mm/vmalloc: Hugepage vmalloc mappings

2021-02-19 Thread Ding Tianhong
On 2021/2/19 15:45, Nicholas Piggin wrote: > Excerpts from Ding Tianhong's message of February 19, 2021 1:45 pm: >> Hi Nicholas: >> >> I met some problem for this patch, like this: >> >> kva = vmalloc(3*1024k); >> >> remap_vmalloc_range(xxx, kva, xxx) >> >> It failed because that the check for page

Re: [PATCH v12 13/14] mm/vmalloc: Hugepage vmalloc mappings

2021-02-18 Thread Ding Tianhong
Hi Nicholas: I met some problem for this patch, like this: kva = vmalloc(3*1024k); remap_vmalloc_range(xxx, kva, xxx) It failed because that the check for page_count(page) is null so return, it break the some logic for current modules. because the new huge page is not valid for composed page.

Re: [PATCH v12 01/14] ARM: mm: add missing pud_page define to 2-level page tables

2021-02-02 Thread Ding Tianhong
On 2021/2/2 19:47, Ding Tianhong wrote: > On 2021/2/2 19:13, Russell King - ARM Linux admin wrote: >> On Tue, Feb 02, 2021 at 09:05:02PM +1000, Nicholas Piggin wrote: >>> diff --git a/arch/arm/include/asm/pgtable.h b/arch/arm/include/asm/pgtable.h >>> index c02f24

Re: [PATCH v12 01/14] ARM: mm: add missing pud_page define to 2-level page tables

2021-02-02 Thread Ding Tianhong
On 2021/2/2 19:13, Russell King - ARM Linux admin wrote: > On Tue, Feb 02, 2021 at 09:05:02PM +1000, Nicholas Piggin wrote: >> diff --git a/arch/arm/include/asm/pgtable.h b/arch/arm/include/asm/pgtable.h >> index c02f24400369..d63a5bb6bd0c 100644 >> --- a/arch/arm/include/asm/pgtable.h >> +++ b/arc

Re: [PATCH v11 01/13] mm/vmalloc: fix HUGE_VMAP regression by enabling huge pages in vmalloc_to_page

2021-01-27 Thread Ding Tianhong
On 2021/1/26 12:44, Nicholas Piggin wrote: > vmalloc_to_page returns NULL for addresses mapped by larger pages[*]. > Whether or not a vmap is huge depends on the architecture details, > alignments, boot options, etc., which the caller can not be expected > to know. Therefore HUGE_VMAP is a regressi

Re: [PATCH v11 12/13] mm/vmalloc: Hugepage vmalloc mappings

2021-01-26 Thread Ding Tianhong
On 2021/1/26 17:47, Nicholas Piggin wrote: > Excerpts from Ding Tianhong's message of January 26, 2021 4:59 pm: >> On 2021/1/26 12:45, Nicholas Piggin wrote: >>> Support huge page vmalloc mappings. Config option HAVE_ARCH_HUGE_VMALLOC >>> enables support on architectures that define HAVE_ARCH_HUGE_

Re: [PATCH v11 12/13] mm/vmalloc: Hugepage vmalloc mappings

2021-01-25 Thread Ding Tianhong
On 2021/1/26 12:45, Nicholas Piggin wrote: > Support huge page vmalloc mappings. Config option HAVE_ARCH_HUGE_VMALLOC > enables support on architectures that define HAVE_ARCH_HUGE_VMAP and > supports PMD sized vmap mappings. > > vmalloc will attempt to allocate PMD-sized pages if allocating PMD si

Re: [PATCH v11 05/13] mm: HUGE_VMAP arch support cleanup

2021-01-25 Thread Ding Tianhong
Reviewed-by: Ding Tianhong On 2021/1/26 12:45, Nicholas Piggin wrote: > This changes the awkward approach where architectures provide init > functions to determine which levels they can provide large mappings for, > to one where the arch is queried for each call. > > This r

Re: [PATCH v9 05/12] mm: HUGE_VMAP arch support cleanup

2021-01-04 Thread Ding Tianhong
On 2020/12/5 14:57, Nicholas Piggin wrote: > This changes the awkward approach where architectures provide init > functions to determine which levels they can provide large mappings for, > to one where the arch is queried for each call. > > This removes code and indirection, and allows constant-fo

Re: [PATCH v9 11/12] mm/vmalloc: Hugepage vmalloc mappings

2020-12-25 Thread Ding Tianhong
> +again: > + size = PAGE_ALIGN(size); > + area = __get_vm_area_node(size, align, VM_ALLOC | VM_UNINITIALIZED | > vm_flags, start, end, node, gfp_mask, caller); > if (!area) > goto fail; > > - addr = __vmalloc_area_node(area, gfp_mas

[PATCH v3.6 01/19] net: freescale: remove unused compare_addr()

2014-01-07 Thread Ding Tianhong
The function did not be used any more, so remove it. Cc: Li Yang Cc: net...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Ding Tianhong --- drivers/net/ethernet/freescale/ucc_geth.c | 5 - 1 file changed, 5 deletions(-) diff --git a

[PATCH v3.5 01/19] net: freescale: remove unused compare_addr()

2013-12-26 Thread Ding Tianhong
The function did not be used any more, so remove it. Cc: Li Yang Cc: net...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Ding Tianhong --- drivers/net/ethernet/freescale/ucc_geth.c | 5 - 1 file changed, 5 deletions(-) diff --git a

[PATCH v3 01/19] net: freescale: remove unused compare_addr()

2013-12-24 Thread Ding Tianhong
The function did not be used any more, so remove it. Cc: Li Yang Cc: net...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Ding Tianhong --- drivers/net/ethernet/freescale/ucc_geth.c | 5 - 1 file changed, 5 deletions(-) diff --git a

[PATCH v2 02/20] net: freescale: slight optimization of addr compare

2013-12-24 Thread Ding Tianhong
The function did not be used any more, so remove it. Cc: Li Yang Cc: net...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Ding Tianhong --- drivers/net/ethernet/freescale/ucc_geth.c | 5 - 1 file changed, 5 deletions(-) diff --git a

[PATCH 02/21] net: freescale: slight optimization of addr compare

2013-12-22 Thread Ding Tianhong
Use the recently added and possibly more efficient ether_addr_equal_unaligned to instead of memcmp. Cc: Li Yang Cc: net...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Ding Tianhong --- drivers/net/ethernet/freescale/ucc_geth.c | 2 +- 1