Re: [PATCH 0/3] Update LLVM Phabricator and Bugzilla links

2024-01-11 Thread Fangrui Song
gt; > Nathan Chancellor > > > > Excellent! Thanks for doing this. I spot checked a handful I was > familiar with and everything looks good to me. > > Reviewed-by: Kees Cook > > -- > Kees Cook > These reviews.llvm.org links would definitely be kept like https://

Re: [PATCH v8 1/3] riscv: Introduce CONFIG_RELOCATABLE

2023-03-23 Thread Fangrui Song
On Wed, Mar 22, 2023 at 11:26 AM Nick Desaulniers wrote: > > On Fri, Feb 24, 2023 at 7:58 AM Björn Töpel wrote: > > > > Alexandre Ghiti writes: > > > > > +cc linux-kbuild, llvm, Nathan, Nick > > > > > > On 2/15/23 15:36, Alexandre Ghiti wrote: > > >> From: Alexandre Ghiti > > >> > > > I tried

Re: [PATCH v2] vdso: Improve cmd_vdso_check to check all dynamic relocations

2023-03-10 Thread Fangrui Song
On 2023-03-10, Vincenzo Frascino wrote: Hi Fangrui, Apologize for the delay, I totally missed that you had a new version of your patch since it was threaded with the old one. Thank you! No worries. On 12/21/22 23:51, Fangrui Song wrote: The actual intention is that no dynamic relocation

[PATCH v3] vdso: Improve cmd_vdso_check to check all dynamic relocations

2023-03-10 Thread Fangrui Song
motivated by the arm64 port missing R_AARCH64_RELATIVE.) Signed-off-by: Fangrui Song Reviewed-by: Christophe Leroy Reviewed-by: Vincenzo Frascino # for vDSO, aarch64 Tested-by: Vincenzo Frascino # for aarch64 --- Changes from v2: * rebase Changes from v3: * Add a comment before `include $(srctree

Re: [PATCH v2] vdso: Improve cmd_vdso_check to check all dynamic relocations

2023-03-08 Thread Fangrui Song
On Fri, Jan 27, 2023 at 3:19 PM Fangrui Song wrote: > On Thu, Dec 29, 2022 at 11:22 AM Palmer Dabbelt > wrote: > > > > On Wed, 21 Dec 2022 15:51:47 PST (-0800), mask...@google.com wrote: > > > The actual intention is that no dynamic relocation exists. However, > s

Re: [PATCH v2] vdso: Improve cmd_vdso_check to check all dynamic relocations

2023-01-27 Thread Fangrui Song
> With the change, we can remove ARCH_REL_TYPE_ABS. ARCH_REL_TYPE_ABS is a > > bit misnomer as ports may check RELAVETIVE/GLOB_DAT/JUMP_SLOT which are > > not called "absolute relocations". (The patch is motivated by the arm64 > > port missing R_AARCH64

[PATCH v2] vdso: Improve cmd_vdso_check to check all dynamic relocations

2022-12-21 Thread Fangrui Song
motivated by the arm64 port missing R_AARCH64_RELATIVE.) Signed-off-by: Fangrui Song Reviewed-by: Christophe Leroy --- Change from v1: * rebase after 8ac3b5cd3e0521d92f9755e90d140382fc292510 (lib/vdso: use "grep -E" instead of "egrep") * change the commit message to mention an exa

Re: [PATCH] vdso: Improve cmd_vdso_check to check all dynamic relocations

2022-12-18 Thread Fangrui Song
On Sun, Dec 4, 2022 at 8:58 AM Christophe Leroy wrote: > > > > Le 04/12/2022 à 05:50, Fangrui Song a écrit : > > On Mon, Nov 14, 2022 at 4:46 PM Fangrui Song wrote: > >> > >> On 2022-11-14, Christophe Leroy wrote: > >>> > >>> > >&

Re: [PATCH] vdso: Improve cmd_vdso_check to check all dynamic relocations

2022-12-03 Thread Fangrui Song
On Mon, Nov 14, 2022 at 4:46 PM Fangrui Song wrote: > > On 2022-11-14, Christophe Leroy wrote: > > > > > >Le 28/09/2022 à 07:25, Fangrui Song a écrit : > >> On Sat, Sep 10, 2022 at 12:53 AM Fangrui Song wrote: > >>> > >>> On 20

Re: [PATCH] vdso: Improve cmd_vdso_check to check all dynamic relocations

2022-11-14 Thread Fangrui Song
On 2022-11-14, Christophe Leroy wrote: Le 28/09/2022 à 07:25, Fangrui Song a écrit : On Sat, Sep 10, 2022 at 12:53 AM Fangrui Song wrote: On 2022-08-30, Fangrui Song wrote: The actual intention is that no dynamic relocation exists. However, some GNU ld ports produce unneeded R_*_NONE

Re: [PATCH] vdso: Improve cmd_vdso_check to check all dynamic relocations

2022-09-27 Thread Fangrui Song
On Sat, Sep 10, 2022 at 12:53 AM Fangrui Song wrote: > > On 2022-08-30, Fangrui Song wrote: > >The actual intention is that no dynamic relocation exists. However, some > >GNU ld ports produce unneeded R_*_NONE. (If a port is not care enough to > >determine the exact .rel[a

Re: [PATCH] vdso: Improve cmd_vdso_check to check all dynamic relocations

2022-09-10 Thread Fangrui Song
On 2022-08-30, Fangrui Song wrote: The actual intention is that no dynamic relocation exists. However, some GNU ld ports produce unneeded R_*_NONE. (If a port is not care enough to determine the exact .rel[a].dyn size, the trailing zeros become R_*_NONE relocations. E.g. powerpc64le ld

[PATCH] vdso: Improve cmd_vdso_check to check all dynamic relocations

2022-08-30 Thread Fangrui Song
rt missing R_AARCH64_RELATIVE.) While here, replace "egrep" with "grep" as "egrep" is deprecated in GNU grep 3.7. Signed-off-by: Fangrui Song --- arch/arm/vdso/Makefile| 3 --- arch/arm64/kernel/vdso/Makefile | 3 --- arch/arm64/kernel/vdso32/

Re: [PATCH] ppc: add "-z notext" flag to disable diagnostic

2021-08-13 Thread Fangrui Song
On 2021-08-14, Daniel Axtens wrote: Bill Wendling writes: The "-z notext" flag disables reporting an error if DT_TEXTREL is set on PPC with CONFIG=kdump: ld.lld: error: can't create dynamic relocation R_PPC64_ADDR64 against local symbol in readonly segment; recompile object files with

[PATCH] Replace __toc_start + 0x8000 with .TOC.

2021-03-07 Thread Fangrui Song
with CONFIG_PPC_OF_BOOT_TRAMPOLINE=y is bootable with LLD. There is still an untriaged issue with Alexey's configuration. Link: https://github.com/ClangBuiltLinux/linux/issues/1318 Reported-by: Alexey Kardashevskiy Signed-off-by: Fangrui Song --- arch/powerpc/boot/crt0.S| 2 +- arch/powerpc/boot