Re: [PATCH 1/1] usb: gadget: Don't attempt to dequeue requests for a disabled USB endpoint on Freescale hardware

2012-10-26 Thread Felipe Balbi
Hi, On Thu, Oct 25, 2012 at 02:36:24AM +0200, Laurent Pinchart wrote: > Hi Felipe, > > On Monday 22 October 2012 13:56:01 Felipe Balbi wrote: > > On Mon, Oct 22, 2012 at 12:47:21PM +0200, Laurent Pinchart wrote: > > > On Monday 22 October 2012 03:33:19 Li Yang-R58472 wr

Re: [PATCH 1/1] usb: gadget: Don't attempt to dequeue requests for a disabled USB endpoint on Freescale hardware

2012-10-22 Thread Felipe Balbi
Hi, On Mon, Oct 22, 2012 at 12:47:21PM +0200, Laurent Pinchart wrote: > Hi, > > On Monday 22 October 2012 03:33:19 Li Yang-R58472 wrote: > > On Saturday, October 20, 2012 1:37 AM Felipe Balbi wrote: > > > On Fri, Oct 19, 2012 at 06:19:26PM +0100, Simon Haggett wrote: >

Re: [PATCH 5/7] usb: gadget: fsl_udc: postpone freeing current dTD

2012-10-22 Thread Felipe Balbi
Hi, On Sat, Oct 20, 2012 at 09:12:27PM +0200, Christoph Fritz wrote: > On Fri, 2012-10-19 at 13:44 +0300, Felipe Balbi wrote: > > > I thought about this too but wasn't able to use chipidea with > > > MXC_EHCI_INTERNAL_PHY as it's called in fsl_udc. > > &

Re: [PATCH 1/1] usb: gadget: Don't attempt to dequeue requests for a disabled USB endpoint on Freescale hardware

2012-10-22 Thread Felipe Balbi
On Mon, Oct 22, 2012 at 03:33:19AM +, Li Yang-R58472 wrote: > > > > -Original Message- > > From: Felipe Balbi [mailto:ba...@ti.com] > > Sent: Saturday, October 20, 2012 1:37 AM > > To: Simon Haggett > > Cc: Li Yang-R58472; Felipe Bal

Re: [PATCH 1/1] usb: gadget: Don't attempt to dequeue requests for a disabled USB endpoint on Freescale hardware

2012-10-19 Thread Felipe Balbi
Hi, On Fri, Oct 19, 2012 at 06:19:26PM +0100, Simon Haggett wrote: > Some gadget drivers may attempt to dequeue requests for an endpoint that has > already been disabled. For example, in the UVC gadget driver, > uvc_function_set_alt() > will call usb_ep_disable() when alt setting 0 is selected. W

Re: [PATCH 5/7] usb: gadget: fsl_udc: postpone freeing current dTD

2012-10-19 Thread Felipe Balbi
Hi, On Fri, Oct 19, 2012 at 12:46:48PM +0200, Christoph Fritz wrote: > On Fri, 2012-10-19 at 13:30 +0300, Felipe Balbi wrote: > > On Fri, Oct 19, 2012 at 12:24:43PM +0200, Christoph Fritz wrote: > > > USB controller may access a wrong address for the dTD (endpoint transfer >

Re: [PATCH 5/7] usb: gadget: fsl_udc: postpone freeing current dTD

2012-10-19 Thread Felipe Balbi
On Fri, Oct 19, 2012 at 12:24:43PM +0200, Christoph Fritz wrote: > USB controller may access a wrong address for the dTD (endpoint transfer > descriptor) and then hang. This happens a lot when doing tests with > g_ether module and iperf, a tool for measuring maximum TCP and UDP > bandwidth. > > Th

Re: [PATCH 4/7] usb: gadget: fsl_udc: drop ARCH dependency

2012-10-19 Thread Felipe Balbi
On Fri, Oct 19, 2012 at 12:24:42PM +0200, Christoph Fritz wrote: > Drop the big-/little-endian helpers and make use of generic > writel()/readl() routines. > > Signed-off-by: Christoph Fritz > --- > drivers/usb/gadget/fsl_udc_core.c | 331 > + > 1 files chan

Re: [PATCH 3/7] usb: gadget: fsl_udc: convert to new ulc style

2012-10-19 Thread Felipe Balbi
Hi, typo on Subject. Should be udc, not ulc. On Fri, Oct 19, 2012 at 12:24:41PM +0200, Christoph Fritz wrote: > Convert to new UDC style registration and remove > global 'udc_controller' pointer. > > Signed-off-by: Christoph Fritz > --- > drivers/usb/gadget/fsl_udc_core.c | 289 > +++

Re: [PATCH 2/7] usb: gadget: fsl_udc: protect fsl_pullup() with spin_lock

2012-10-19 Thread Felipe Balbi
Hi, On Fri, Oct 19, 2012 at 12:24:40PM +0200, Christoph Fritz wrote: > This patch reworks fsl_pullup() against the background of switching over > to udc_start()/udc_stop() style: > > Protect function fsl_pullup() with a spin_lock. Also set vbus_active as > default to true. This prevents disabling

Re: [PATCH 1/7] usb: gadget: fsl_udc: simplify driver init

2012-10-19 Thread Felipe Balbi
Hi, On Fri, Oct 19, 2012 at 12:24:39PM +0200, Christoph Fritz wrote: > To initialize this driver use 'module_platform_driver' instead > of '__init' and '__exit'. > > Signed-off-by: Christoph Fritz > --- > drivers/usb/gadget/fsl_udc_core.c | 37 > +++-- > 1 fil

Re: [PATCH] usb: gadget: fsl_udc_core: do not immediatly prime STATUS for IN xfer

2012-09-10 Thread Felipe Balbi
On Thu, Sep 06, 2012 at 05:27:42PM +0300, Felipe Balbi wrote: > Hi, > > On Thu, Sep 06, 2012 at 04:27:12PM +0200, Enrico Scholz wrote: > > Felipe Balbi writes: > > > > >> > Because the fsl_udc_core driver shares one 'status_req' object for the >

Re: [PATCH] usb: gadget: fsl_udc_core: remove mapped flag

2012-09-06 Thread Felipe Balbi
On Thu, Sep 06, 2012 at 04:32:28PM +0200, Enrico Scholz wrote: > Chen Peter-B29397 writes: > > > If the class driver has already mapped this address, the req->req.dma is not > > DMA_ADDR_INVALID either, in this case, the dma_sync_single_for_cpu is > > enough. > > ok; forget the patch then. fair

Re: [PATCH] usb: gadget: fsl_udc_core: do not immediatly prime STATUS for IN xfer

2012-09-06 Thread Felipe Balbi
Hi, On Thu, Sep 06, 2012 at 04:27:12PM +0200, Enrico Scholz wrote: > Felipe Balbi writes: > > >> > Because the fsl_udc_core driver shares one 'status_req' object for the > >> > complete ep0 control transfer, it is not possible to prime the final >

Re: [PATCH] usb: gadget: fsl_udc_core: do not immediatly prime STATUS for IN xfer

2012-09-06 Thread Felipe Balbi
On Wed, Sep 05, 2012 at 02:10:39AM +, Chen Peter-B29397 wrote: > > > > > Because the fsl_udc_core driver shares one 'status_req' object for the > > complete ep0 control transfer, it is not possible to prime the final > > STATUS phase immediately after the IN transaction. E.g. ch9getstatus()

Re: [PATCH] usb: gadget: fsl_udc_core: remove mapped flag

2012-09-05 Thread Felipe Balbi
Hi, On Tue, Sep 04, 2012 at 07:24:59PM +0200, Enrico Scholz wrote: > The 'mapped' flag in 'struct fsl_req' flag is redundant with checking > for 'req.dma != DMA_ADDR_INVALID' and it was also set to a wrong value you should not be using DMA_ADDR_INVALID anymore. Use the generic map/unmap routines

Re: [PATCH 5/5] usb: gadget: composite: parse dt overrides

2012-07-02 Thread Felipe Balbi
Hi, On Tue, Jun 26, 2012 at 11:27:13AM -0300, Alexandre Pereira da Silva wrote: > Grab the devicetree node properties to override VendorId, ProductId, > bcdDevice, Manucacturer, Product and SerialNumber > > Signed-off-by: Alexandre Pereira da Silva I need Grant's acked-by to queue this one. --

Re: [PATCH v2] usb: fsl_udc: errata - postpone freeing current dTD

2012-06-04 Thread Felipe Balbi
On Mon, Jun 04, 2012 at 01:30:24PM +0200, Christoph Fritz wrote: > Hi, > > On Mon, 2012-05-21 at 22:04 +0300, Felipe Balbi wrote: > > On Mon, May 21, 2012 at 08:57:22AM +0200, Christoph Fritz wrote: > > > USB controller may access a wrong address for the dTD (endpoint t

Re: [PATCH v2] usb: fsl_udc: errata - postpone freeing current dTD

2012-05-21 Thread Felipe Balbi
Hi, On Mon, May 21, 2012 at 08:57:22AM +0200, Christoph Fritz wrote: > USB controller may access a wrong address for the dTD (endpoint transfer > descriptor) and then hang. This happens a lot when doing tests with > g_ether module and iperf, a tool for measuring maximum TCP and UDP > bandwidth. >

Re: [PATCH v2 01/19] mxc_udc: add workaround for ENGcm09152 for i.MX25

2011-12-13 Thread Felipe Balbi
Hi, On Tue, Dec 13, 2011 at 03:09:37PM +0100, Eric BĂ©nard wrote: > this patch gives the possibility to workaround bug ENGcm09152 > on i.MX25 when the hardware workaround is also implemented on > the board. > It covers the workaround described on page 42 of the following Errata, > titled "USB: UTMI

Re: [PATCH v2] usb/fsl_udc: fix dequeuing a request in progress

2011-11-24 Thread Felipe Balbi
On Wed, Nov 23, 2011 at 08:12:56PM +0800, Li Yang wrote: > The original implementation of dequeuing a request in progress > is not correct. Change to use a correct process and also clean > up the related functions a little bit. > > Signed-off-by: Li Yang > Cc: Peter Chen applied, thanks -- b

Re: [PATCH v2] USB: fsl_udc_core: use usb_endpoint_xfer_isoc to judge ISO XFER

2011-11-24 Thread Felipe Balbi
On Tue, Nov 22, 2011 at 09:55:45AM +0800, Peter Chen wrote: > Some ISO gadgets, like audio, has SYNC attribute as well as > USB_ENDPOINT_XFER_ISOC for their bmAttributes at ISO endpoint > descriptor. So, it needs to use usb_endpoint_xfer_isoc to judge > ISO XFER. > > Signed-off-by: Peter Chen ap

Re: [PATCH] usb/fsl_udc: fix dequeuing a request in progress

2011-11-24 Thread Felipe Balbi
On Wed, Nov 23, 2011 at 08:20:54AM +, Li Yang-R58472 wrote: > >Leo, I have debugged this issue at my board just now, the reason of > >failure is we only have one ep struct for ep0, so when talking about ep0, > >it always pointers to udc->ep[0]. So even we initialize the current qh > >address fo

Re: [PATCH] USB: fsl_udc_core: Use (&) instead of (==) to compare ISO XFER

2011-11-24 Thread Felipe Balbi
On Tue, Nov 22, 2011 at 02:26:24AM +0100, Michal Nazarewicz wrote: > >On Tue, 22 Nov 2011 02:15:21 +0100, Peter Chen > >wrote: > >>@@ -877,7 +877,7 @@ fsl_ep_queue(struct usb_ep *_ep, struct usb_request > >>*_req, gfp_t gfp_flags) > >>VDBG("%s, bad ep", __func__); > >>ret

Re: [PATCH 00/14] Modifications for DWC OTG since v13

2011-08-31 Thread Felipe Balbi
Hi, (you did not add Greg in Cc, he's the USB maintainer. You also didn't Cc myself as maintainer of the gadget framework) On Tue, Aug 30, 2011 at 05:27:47PM +0530, Pratyush Anand wrote: > These patches are based on:http://patchwork.ozlabs.org/patch/89560/ > After not getting any reply from devel

Re: [PATCH] usb:gadget: use min_t() macro instead of min()

2011-06-13 Thread Felipe Balbi
Hi, On Mon, Jun 13, 2011 at 03:03:44PM -0400, Alan Stern wrote: > > > The change I suggested involved replacing two typecasts with a single > > > min_t. All (or almost all) the places this patch touches currently > > > contain only one typecast, so the motivation for changing them is a lot > > >

Re: [PATCH] usb:gadget: use min_t() macro instead of min()

2011-06-13 Thread Felipe Balbi
Hi, On Mon, Jun 13, 2011 at 02:52:34PM +0300, Tanya Brokhman wrote: > > On Sun, Jun 12, 2011 at 02:14:46PM +0300, Tatyana Brokhman wrote: > > > Signed-off-by: Tatyana Brokhman > > > > I need a sensible commit log for this. Why do we need to change all > > min() to min_t() ? > > > > Actually, A

Re: [PATCH] usb:gadget: use min_t() macro instead of min()

2011-06-13 Thread Felipe Balbi
Hi, On Sun, Jun 12, 2011 at 02:14:46PM +0300, Tatyana Brokhman wrote: > Signed-off-by: Tatyana Brokhman I need a sensible commit log for this. Why do we need to change all min() to min_t() ? -- balbi signature.asc Description: Digital signature __

Re: [PATCH v10 03/10] USB/ppc4xx: Add Synopsys DWC OTG Core Interface Layer (CIL)

2011-04-05 Thread Felipe Balbi
On Tue, Apr 05, 2011 at 12:38:03PM +0530, Keshava Munegowda wrote: > > -Original Message- > > From: Sergei Shtylyov [mailto:sshtyl...@mvista.com] > > Sent: Saturday, April 02, 2011 12:26 AM > > To: Tirumala Marri > > Cc: Keshava Munegowda; linux-...@vger.kernel.org; > linuxppc-dev@lists.ozl

Re: [PATCH v13 08/10] USB ppc4xx: Add Synopsys DWC OTG PCD interrupt function

2011-04-04 Thread Felipe Balbi
On Sun, Apr 03, 2011 at 04:17:13PM -0700, tma...@apm.com wrote: > +void start_next_request(struct pcd_ep *ep) this will probably cause namespace clashes at some point. prepent with dwc_ or make it static. -- balbi ___ Linuxppc-dev mailing list Linuxppc

Re: [PATCH v13 09/10] USB ppc4xx: Add Synopsys DWC OTG driver kernel configuration and Makefile

2011-04-04 Thread Felipe Balbi
On Sun, Apr 03, 2011 at 04:17:24PM -0700, tma...@apm.com wrote: > From: Tirumala Marri > > Add Synopsys DesignWare HS USB OTG driver kernel configuration. > Synopsys OTG driver may operate in host only, device only, or OTG mode. > The driver also allows user configure the core to use its interna

Re: [PATCH v13 07/10] USB/ppc4xx: Add Synopsys DWC OTG PCD function

2011-04-04 Thread Felipe Balbi
Hi, On Sun, Apr 03, 2011 at 04:17:10PM -0700, tma...@apm.com wrote: > +static const struct usb_gadget_ops dwc_otg_pcd_ops = { > + .get_frame = dwc_otg_pcd_get_frame, > + .wakeup = dwc_otg_pcd_wakeup, > + /* not selfpowered */ will you really have a board running this top operating sys

Re: [PATCH v13 03/10] USB/ppc4xx: Add Synopsys DWC OTG Core Interface Layer (CIL)

2011-04-04 Thread Felipe Balbi
Hi, On Sun, Apr 03, 2011 at 04:16:53PM -0700, tma...@apm.com wrote: > +const char *op_state_str(enum usb_otg_state state) please don't introduce yet another version of this. Make the ones available generic. Place a static inline const char *otg_state_string(struct otg_transceiver *x) on include/l

Re: [PATCH v13 02/10] USB/ppc4xx: Add Synopsys DWC OTG driver framework

2011-04-04 Thread Felipe Balbi
On Sun, Apr 03, 2011 at 04:16:50PM -0700, tma...@apm.com wrote: > From: Tirumala Marri > > Platform probing is in dwc_otg_apmppc.c. > Driver parameter and parameter checking are in dwc_otg_param.c. > > Signed-off-by: Tirumala R Marri > Signed-off-by: Fushen Chen > Signed-off-by: Mark Miesfeld

Re: [PATCH V5 2/9] Add Synopsys DesignWare HS USB OTG driver framework.

2010-10-20 Thread Felipe Balbi
On Wed, Oct 20, 2010 at 07:42:45PM -0500, Fushen Chen wrote: Platform probing is in dwc_otg_apmppc.c. Driver parameter and parameter checking are in dwc_otg_param.c. Signed-off-by: Fushen Chen Signed-off-by: Mark Miesfeld --- drivers/usb/dwc_otg/dwc_otg_apmppc.c | 394 ++ drive

Re: [PATCH V5 1/9] Add Synopsys DesignWare HS USB OTG Control and Status Register (CSR).

2010-10-20 Thread Felipe Balbi
Hi, On Wed, Oct 20, 2010 at 07:42:44PM -0500, Fushen Chen wrote: Control and Status Register (CSR) are classified as follows: - Core Global Registers - Device Mode Registers - Device Global Registers - Device Endpoint Specific Registers - Host Mode Registers - Host Global Registers - Host Port C

<    1   2