On Wed, 10 Apr 2024, Michael Ellerman wrote:
> >
> > Could we do something similar, write a message at boottime when the
> > CXL driver gets probed ?
>
> Yeah, I think so.
>
> There's still the problem that people tend not to look at dmesg until
> something breaks, but at least we can try
g/all/1078874617.9746.36.camel@gaston/
Acked-by: Michael Ellerman (powerpc)
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Finn Thain
---
Changed since v1:
- Reworked commit log according to comments from Andy Shevchenko.
Changed since v2:
- Added Acked-by and Cc tags.
-
On Fri, 5 Apr 2024, Michael Ellerman wrote:
> I assume you have tested this on an actual pmac, as well as qemu?
>
I tested the patched driver and its console functionality using Zilog SCC
hardware in a Mac IIci, as well as QEMU's q800 virtual machine.
That should suffice from a code coverage
On Fri, 5 Apr 2024, Michael Ellerman wrote:
> >> > > ---
> >> > (here is a good location for Cc:)
> >>
> >> Documentation/process/submitting-patches.rst indicats that it should
> >> be above the "---" separator together with Acked-by etc. Has this
> >> convention changed recently?
>
> The
com/vivier/qemu-m68k/issues/44
Link: https://lore.kernel.org/all/1078874617.9746.36.camel@gaston/
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Finn Thain
---
Changed since v1:
- Reworked commit log according to comments from Andy Shevchenko.
---
drivers/tty/seri
On Thu, 4 Apr 2024, Andy Shevchenko wrote:
>
> > > > ---
> > > (here is a good location for Cc:)
> >
> > Documentation/process/submitting-patches.rst indicats that it should
> > be above the "---" separator together with Acked-by etc. Has this
> > convention changed recently?
>
> I see, I
ges
since v6.8.
> > Link: https://github.com/vivier/qemu-m68k/issues/44
> > Link: https://lore.kernel.org/all/1078874617.9746.36.camel@gaston/
>
> Missed Fixes tag?
>
Would this be ok: Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
I have to ask because some reviewers do
st_acpi_subsys_init+0x0/0x8
[ 14.56] [<0063991e>] console_on_rootfs+0x0/0x60
[ 14.56] [<00638410>] _sinittext+0x410/0xadc
[ 14.56]
Cc: Benjamin Herrenschmidt
Cc: Michael Ellerman
Cc: Nicholas Piggin
Cc: Christophe Leroy
Cc: "Aneesh Kumar K.V"
Cc: "Nave
On Wed, 1 Nov 2023, Arnd Bergmann wrote:
>
> If we had not removed all localtalk support already, ipddp might have
> been used to bridge between a pre-ethernet mac running macip and an IP
> based AFP server (netatalk or time machine). Without localtalk support,
> that is not all that
On Wed, 31 May 2023, Geert Uytterhoeven wrote:
> On Wed, May 31, 2023 at 2:50 PM Michael Ellerman wrote:
> > The powerpc section has a "F:" entry for drivers/macintosh, matching
> > all files in or below drivers/macintosh. That is correct for the most
> > part, but there are a couple of
On Sun, 8 May 2022, I wrote:
>
> That suggests to me that we need a "bool CONFIG_WARINGS_INTO_ERRORS" to
> control -Werror, which could be disabled for .config files (like make
> allmodconfig) where it is not helping.
>
I just noticed that we already have CONFIG_WERROR. So perhaps
Hi Arnd,
On Sat, 7 May 2022, Arnd Bergmann wrote:
> On Sat, May 7, 2022 at 2:01 AM Finn Thain wrote:
> > On Fri, 6 May 2022, Niklas Schnelle wrote:
> > > On Fri, 2022-05-06 at 19:12 +1000, Finn Thain wrote:
> > > > On Thu, 5 May 2022, Bjorn Helgaas wrote:
>
On Fri, 6 May 2022, Niklas Schnelle wrote:
> On Fri, 2022-05-06 at 19:12 +1000, Finn Thain wrote:
> >
> > On Thu, 5 May 2022, Bjorn Helgaas wrote:
> >
> > > On Thu, May 05, 2022 at 07:39:42PM +0200, Arnd Bergmann wrote:
> > > > On Thu, M
On Thu, 5 May 2022, Bjorn Helgaas wrote:
> On Thu, May 05, 2022 at 07:39:42PM +0200, Arnd Bergmann wrote:
> > On Thu, May 5, 2022 at 6:10 PM Bjorn Helgaas wrote:
> > > On Wed, May 04, 2022 at 11:31:28PM +0200, Arnd Bergmann wrote:
> > > >
> > > > The main goal is to avoid c), which is what
test robot
Signed-off-by: Finn Thain
---
Changed since v1:
- Adopted IS_ENABLED to avoid an ifdef as suggested by Christophe.
- Added the ADB_PMU_EVENT symbol as suggested by Geert, though this
adds a new Kconfig symbol for little gain AFAICS.
---
drivers/macintosh/Kconfig | 4
On Thu, 7 Apr 2022, Christophe Leroy wrote:
> Le 07/04/2022 à 05:16, Randy Dunlap a écrit :
> >
> >
> > On 4/6/22 19:37, Randy Dunlap wrote:
> >> When CONFIG_INPUT=m, the input_*() family of functions is not
> >> available to builtin drivers.
> >>
> >> When CONFIG_RTC_CLASS is not set,
On Wed, 6 Apr 2022, Randy Dunlap wrote:
> When CONFIG_RTC_CLASS is not set, rtc_tm_to_time64() is not defined.
>
> ...
>
> m68k-linux-ld: drivers/macintosh/via-pmu.o: in function `pmu_set_rtc_time':
> drivers/macintosh/via-pmu.c:1758: undefined reference to `rtc_tm_to_time64'
> m68k-linux-ld:
)
^~
Add some #ifdefs to avoid unused code warnings when CONFIG_PROC_FS is
disabled.
Cc: Randy Dunlap
Cc: Christophe Leroy
Reported-by: Randy Dunlap
Suggested-by: Christophe Leroy
Signed-off-by: Finn Thain
---
Changed since v1:
- Simplified to take advantage of the fact
Please disregard. I'll send v2 with corrected commit log entry.
)
^~
Rearrange some code and add some #ifdefs to avoid unused code warnings
when CONFIG_PROC_FS is disabled.
Reported-by: Randy Dunlap
Cc: Randy Dunlap
Cc: Christophe Leroy
Signed-off-by: Finn Thain
---
drivers/macintosh/via-pmu.c | 4
1 file changed, 4 insertions(+)
diff
On Mon, 21 Mar 2022, Christophe Leroy wrote:
> Le 21/03/2022 à 09:50, Finn Thain a écrit :
> > Hi Christophe,
> >
> > On Mon, 21 Mar 2022, Finn Thain wrote:
> >
> >> On Mon, 21 Mar 2022, Christophe Leroy wrote:
> >>
> >>> Le 19/03/2022 à
On Mon, 21 Mar 2022, Geert Uytterhoeven wrote:
> On Mon, Mar 21, 2022 at 9:29 AM Finn Thain wrote:
> > On Mon, 21 Mar 2022, Christophe Leroy wrote:
> > > Le 21/03/2022 à 05:30, Finn Thain a écrit :
> > > > drivers/macintosh/via-pmu-event.o: In function `via_pmu_e
Hi Christophe,
On Mon, 21 Mar 2022, Finn Thain wrote:
> On Mon, 21 Mar 2022, Christophe Leroy wrote:
>
> > Le 19/03/2022 à 08:20, Finn Thain a écrit :
> > > drivers/macintosh/via-pmu.c:897:12: warning: 'pmu_battery_proc_show'
> > > defined but not used [-Wunuse
On Mon, 21 Mar 2022, Christophe Leroy wrote:
> Le 19/03/2022 à 08:20, Finn Thain a écrit :
> > drivers/macintosh/via-pmu.c:897:12: warning: 'pmu_battery_proc_show'
> > defined but not used [-Wunused-function]
> > static int pmu_battery_proc_show(struct
On Mon, 21 Mar 2022, Christophe Leroy wrote:
>
>
> Le 21/03/2022 à 05:30, Finn Thain a écrit :
> > drivers/macintosh/via-pmu-event.o: In function `via_pmu_event':
> > via-pmu-event.c:(.text+0x44): undefined reference to `input_event'
> > via-pmu-event.c:(.text
: Randy Dunlap
Signed-off-by: Finn Thain
---
This is equivalent to the patch I sent a couple of days ago. This one
is slightly longer and adds a new symbol so that Kconfig logic can been
used instead of Makefile logic in case reviewers prefer that.
---
drivers/macintosh/Kconfig | 5 +
drivers
On Sat, 19 Mar 2022, Geert Uytterhoeven wrote:
> On Sat, Mar 19, 2022 at 5:23 AM Finn Thain wrote:
> > drivers/macintosh/via-pmu-event.o: In function `via_pmu_event':
> > via-pmu-event.c:(.text+0x44): undefined reference to `input_event'
> > via-pmu-event.c:(.text+0x68)
)
^~
Rearrange some code and add some #ifdefs to avoid unused code warnings
when CONFIG_PROC_FS is disabled.
Reported-by: Randy Dunlap
Cc: Randy Dunlap
Signed-off-by: Finn Thain
---
drivers/macintosh/via-pmu.c | 61 ++---
1 file changed, 36
On Fri, 18 Mar 2022, Randy Dunlap wrote:
>
> Hi Finn,
> It builds without those reported errors, but I do see these warnings
> since the robot-supplied .config file has:
> # CONFIG_PROC_FS is not set
>
>
> CC drivers/macintosh/via-pmu.o
> ../drivers/macintosh/via-pmu.c:897:12: warning:
Signed-off-by: Finn Thain
---
drivers/macintosh/Makefile | 5 -
drivers/macintosh/via-pmu.c | 2 ++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/macintosh/Makefile b/drivers/macintosh/Makefile
index 49819b1b6f20..eaf28b1c272f 100644
--- a/drivers/macintosh/Makefile
+++ b
On Wed, 10 Nov 2021, Christophe Leroy wrote:
> Le 10/11/2021 à 00:47, Finn Thain a écrit :
>
> > Christophe, I hope this change is the one you wanted to see upstream
> > (?). If it is acceptable please add your signed-off-by tag.
>
> I'm on holidays, I was planing
W35czDIaeQ=@protonmail.com/
Fixes: 887f3ceb51cd ("powerpc/signal32: Convert do_setcontext[_tm]() to user
access block")
Fixes: d3ccc9781560 ("powerpc/signal: Use __get_user() to copy sigset_t")
Reported-and-tested-by: Stan Johnson
Signed-off-by: Finn Thain
---
Christophe, I hope thi
On Thu, 4 Nov 2021, Christophe Leroy wrote:
> Le 02/11/2021 à 03:20, Finn Thain a écrit :
> > Hi Christopher,
> >
> > After many builds and tests, Stan and I were able to determine that this
> > regression only affects builds with CONFIG_USER_NS=y. Tha
On Wed, 3 Nov 2021, Andreas Schwab wrote:
> On Nov 02 2021, Finn Thain wrote:
>
> > After many builds and tests, Stan and I were able to determine that this
> > regression only affects builds with CONFIG_USER_NS=y. That is,
> >
> > d3ccc9781560 + CONFIG_USER_NS
you help fix this regression?
Regards,
Finn
On Fri, 22 Oct 2021, Christophe Leroy wrote:
> ...
> >
> > Forwarded Message
> > Subject: Fwd: X stopped working with 5.14 on iBook
> > Date: Fri, 22 Oct 2021 11:35:21 -0600
> > From: Stan Johnson
>
This patch prevents the following sparse warning.
arch/powerpc/kernel/tau_6xx.c:199:1: sparse: sparse: symbol 'tau_work'
was not declared. Should it be static?
Reported-by: kernel test robot
Signed-off-by: Finn Thain
---
arch/powerpc/kernel/tau_6xx.c | 2 +-
1 file changed, 1 insertion(+), 1
On Fri, 6 Aug 2021, Stan Johnson wrote:
> $ egrep '(CONFIG_PPC_KUAP|CONFIG_VMAP_STACK)' .config
> CONFIG_PPC_KUAP=y
> CONFIG_PPC_KUAP_DEBUG=y
> CONFIG_VMAP_STACK=y
> $ strings vmlinux | fgrep "Linux version"
> Linux version 5.13.0-pmac-4-g63e3756d1bd ...
> $ cp vmlinux
On Fri, 6 Aug 2021, Christophe Leroy wrote:
>
> I have cooked a tentative fix for that KUAP stuff.
> Could you try the branch 'bugtest' at https://github.com/chleroy/linux.git
>
Thanks, Christophe.
Stan, please test the following build.
$ git remote add chleroy-linux
On Fri, 6 Aug 2021, Christophe Leroy wrote:
> > > > >
> > > > > Can you check if they DO NOT happen at preceding commit c16728835~
> > > > >
> > >
> > > $ git checkout c16728835~
> > > Previous HEAD position was c16728835eec powerpc/32: Manage KUAP in C
> > > HEAD is now at 0b45359aa2df
(Christophe, you've seen some of this before, however there are new
results added at the end. I've Cc'd the mailing lists this time.)
On Wed, 4 Aug 2021, Stan Johnson wrote:
> On 8/4/21 8:41 PM, Finn Thain wrote:
>
> >
> > $ curl
> > https://lore.kernel.org/lkml
On Wed, 4 Aug 2021, Christophe Leroy wrote:
>
> This patch is related to the bisect you did that pointed to 4c0104a83fc3
> ("powerpc/32: Dismantle EXC_XFER_STD/LITE/TEMPLATE")
>
> I think maybe the starting point should be to (manually) apply the patch
> on top of that commit in order to
On Tue, 3 Aug 2021, Stan Johnson wrote:
> Attached you will find the following six files:
>
> 1) config-5.13-patched_VMAP.txt
> 2) config-5.13-patched_NO_VMAP.txt
> 3) pb3400c-console-5.13-patched_VMAP.txt (using config 1)
> 4) pb3400c-console-5.13-patched_NO_VMAP.txt (using config 2)
> 5)
On Tue, 3 Aug 2021, Christophe Leroy wrote:
> When a DSI (Data Storage Interrupt) is taken while in NAP mode, r11
> doesn't survive the call to power_save_ppc32_restore().
>
> So use r1 instead of r11 as they both contain the virtual stack pointer
> at that point.
>
> Re
On Tue, 3 Aug 2021, Christophe Leroy wrote:
>
> Looks like the memory errors are linked to KUAP (Kernel Userspace Access
> Protection). Based on the places the problems happen, I don't think
> there are any invalid access, so there must be something wrong in the
> KUAP logic, probably
On Tue, 3 Aug 2021, Stan Johnson wrote:
>
> I'm not sure of the issue you are referencing. If it's the Wallstreet
> issue, I believe we were waiting to hear back from you regarding the
> memory errors that crop up with CONFIG_VMAP_STACK=y and mem >464M.
> Finn, if that is not correct, please
On Mon, 2 Aug 2021, LEROY Christophe wrote:
> Le 01/08/2021 à 03:21, Finn Thain a écrit :
> > On Sat, 31 Jul 2021, Christophe Leroy wrote:
> >
> > > >
> > > > Stan Johnson contacted me about a regression in mainline that he
> > > > observed on
On Sun, 1 Aug 2021, Stan Johnson wrote:
> >
> >> Could you try without CONFIG_VMAP_STACK
> >>
> >
> > Stan, would you please test the following build:
> >
> > $ git checkout v5.13
> > $ cp ../dot-config-powermac-5.13 .config
> > $ scripts/config -d CONFIG_VMAP_STACK
> > $ make ARCH=powerpc
On Sat, 31 Jul 2021, Christophe Leroy wrote:
> >
> > Stan Johnson contacted me about a regression in mainline that he
> > observed on his G3 Powerbooks. Using 'git bisect' we determined that
> > this patch was the cause of the regression, i.e. commit 4c0104a83fc3
> > ("powerpc/32: Dismantle
Hi Christophe,
On Fri, 12 Mar 2021, Christophe Leroy wrote:
> In order to get more control in exception prolog, dismantle all non
> standard exception macros, finishing with EXC_XFER_STD and EXC_XFER_LITE
> and EXC_XFER_TEMPLATE.
>
> Also remove transfer_to_handler_full and ret_from_except
oju
Fixes: b1c6a0a10bfa ("powerpc/tau: Convert from timer to workqueue")
Signed-off-by: Finn Thain
---
Changed since v1:
- Improved commit log message.
---
arch/powerpc/kernel/tau_6xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/tau_6xx.c b
oju
Fixes: b1c6a0a10bfa ("powerpc/tau: Convert from timer to workqueue")
Signed-off-by: Finn Thain
---
arch/powerpc/kernel/tau_6xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/tau_6xx.c b/arch/powerpc/kernel/tau_6xx.c
index 6c31af7f4fa8.
On Thu, 18 Mar 2021, Christoph Hellwig wrote:
> Hi all,
>
> we've been trying to get rid of the legacy ide driver for a while now,
> and finally scheduled a removal for 2021, which is three month old now.
>
> In general distros and most defconfigs have switched to libata long ago,
> but there
On Mon, 4 Jan 2021, Bart Van Assche wrote:
> On 6/16/20 7:07 PM, Finn Thain wrote:
> > On Tue, 16 Jun 2020, Bart Van Assche wrote:
> >> As far as I know the sbp driver only has had one user ever and that
> >> user is no longer user the sbp driver.
> >
> >
ingly.
Cc: Michael Ellerman
Cc: Benjamin Herrenschmidt
Cc: Joshua Thompson
Cc: linuxppc-dev@lists.ozlabs.org
Cc: linux-m...@lists.linux-m68k.org
Signed-off-by: Finn Thain
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 867157311dc8..e8
On Fri, 4 Dec 2020, Geert Uytterhoeven wrote:
> Hi Finn,
>
> On Fri, Nov 20, 2020 at 5:54 AM Finn Thain wrote:
> > The behaviour of the IOP firmware is not well documented but we do know
> > that IOP message reply data can be used to issue new ADB commands.
> > Use
On Fri, 4 Dec 2020, Geert Uytterhoeven wrote:
> Hi Finn,
>
> On Fri, Nov 20, 2020 at 5:54 AM Finn Thain wrote:
> > A recent patch incorrectly altered the adb-iop state machine behaviour
> > and introduced a regression that can appear intermittently as a
> > malf
uot;driver core: platform: Clarify that IRQ 0 is
invalid")
Reported-by: Laurent Vivier
Signed-off-by: Finn Thain
---
Changed since v1:
- Add a comment to explain the need for the global structs.
- Expand the commit log to better explain the intention of the patch.
---
arch/m68k/mac/config.c
On Fri, 20 Nov 2020, Geert Uytterhoeven wrote:
> Hi Finn,
>
> On Fri, Nov 20, 2020 at 5:51 AM Finn Thain wrote:
> > Don't add platform resources that won't be used. This avoids a
> > recently-added warning from the driver core, that can show up on a
> > multi-platfo
-macii driver. This poll command is addressed to
that device which last received a Talk command (explicit or otherwise).
Cc: Joshua Thompson
Fixes: fa3b5a9929fc ("macintosh/adb-iop: Implement idle -> sending state
transition")
Tested-by: Stan Johnson
Signed-off-by: Finn Thain
Stan Johnson
Signed-off-by: Finn Thain
---
drivers/macintosh/adb-iop.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/macintosh/adb-iop.c b/drivers/macintosh/adb-iop.c
index 6b26b6a2c463..0ee327249150 100644
--- a/drivers/macintosh/adb-iop.c
+++ b/drivers/
a...@vger.kernel.org # v5.8+
References: commit a85a6c86c25b ("driver core: platform: Clarify that IRQ 0 is
invalid")
Reported-by: Laurent Vivier
Signed-off-by: Finn Thain
---
The global platform_device structs provide the equivalent of a direct
search of the OpenFirmware tree, for platfor
On Thu, 22 Oct 2020, Geert Uytterhoeven wrote:
>
> Thanks for your patch...
>
You're welcome.
> I can't say I'm a fan of this...
>
Sorry.
>
> The real issue is this "extern struct platform_device scc_a_pdev,
> scc_b_pdev", circumventing the driver framework.
>
> Can we get rid of that?
On Wed, 21 Oct 2020, Laurent Vivier wrote:
> Le 21/10/2020 à 01:43, Finn Thain a écrit :
>
> > Laurent, can we avoid the irq == 0 warning splat like this?
> >
> > diff --git a/drivers/tty/serial/pmac_zilog.c
> > b/drivers/tty/serial/pmac_zilog.c
> > ind
On Tue, 20 Oct 2020, Brad Boyer wrote:
>
> Wouldn't it be better to rearrange this code to only run if the devices
> are present? This is a macio driver on pmac and a platform driver on
> mac, so shouldn't it be possible to only run this code when the
> appropriate entries are present in the
On Sat, 19 Sep 2020, Arnd Bergmann wrote:
> On Sat, Sep 19, 2020 at 6:21 PM Andy Lutomirski wrote:
> > On Fri, Sep 18, 2020 at 8:16 AM Christoph Hellwig wrote:
> > > On Fri, Sep 18, 2020 at 02:58:22PM +0100, Al Viro wrote:
> > > > Said that, why not provide a variant that would take an explicit
an Johnson
Signed-off-by: Finn Thain
---
arch/powerpc/kernel/tau_6xx.c | 65 +-
arch/powerpc/platforms/Kconfig | 9 ++---
2 files changed, 26 insertions(+), 48 deletions(-)
diff --git a/arch/powerpc/kernel/tau_6xx.c b/arch/powerpc/kernel/tau_6xx.c
index 614
According to Freescale's documentation, MPC74XX processors have an
erratum that prevents the TAU interrupt from working, so don't try to
use it when running on those processors.
Fixes: 1da177e4c3f41 ("Linux-2.6.12-rc2")
Tested-by: Stan Johnson
Signed-off-by: Finn Thain
---
arch/powe
34a886e47819c2eb ]---
Don't call on_each_cpu() from a timer callback, call it from a worker
thread instead.
Fixes: 1da177e4c3f41 ("Linux-2.6.12-rc2")
Tested-by: Stan Johnson
Signed-off-by: Finn Thain
---
arch/powerpc/kernel/tau_6xx.c | 38 +--
1 file cha
because tau_timeout() does so.
Fixes: 1da177e4c3f41 ("Linux-2.6.12-rc2")
Tested-by: Stan Johnson
Signed-off-by: Finn Thain
---
arch/powerpc/kernel/tau_6xx.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/arch/powerpc/kernel/tau_6xx.c b/arch/powerpc/kernel/tau_6xx.c
index 268
, there is also a factor of 266 that has to be
applied to this value on certain parts i.e. speed sort above 266 MHz.)
Always use the maximum cycle count, as recommended by the Datasheet.
Fixes: 1da177e4c3f41 ("Linux-2.6.12-rc2")
Tested-by: Stan Johnson
Signed-off-by: Finn Thain
---
ar
This patch series fixes various bugs in the Thermal Assist Unit driver.
It was tested on 266 MHz and 292 MHz PowerBook G3 laptops.
Finn Thain (5):
powerpc/tau: Use appropriate temperature sample interval
powerpc/tau: Convert from timer to workqueue
powerpc/tau: Remove duplicated
On Sun, 9 Aug 2020, Guenter Roeck wrote:
> Hi,
>
> On Sun, Jun 28, 2020 at 02:23:12PM +1000, Finn Thain wrote:
> > The interrupt handler should be excluded when accessing the
> > autopoll_devs variable.
> >
>
> I am quite baffled by this patch. Othe
On Sun, 9 Aug 2020, Guenter Roeck wrote:
> Hi,
>
> On Sun, Jun 28, 2020 at 02:23:12PM +1000, Finn Thain wrote:
> > Poll the most recently polled device by default, rather than the lowest
> > device address that happens to be enabled in autopoll_devs. This improves
>
On Mon, 20 Jul 2020, Masahiro Yamada wrote:
>
> I got a similar report before.
>
> I'd like to know whether or not
> this is the same issue as fixed by
> 7883a14339299773b2ce08dcfd97c63c199a9289
>
The problem can be observed with 3d77e6a8804ab ("Linux 5.7").
So it appears that 7883a14339299
On Sun, 24 Nov 2019, Masahiro Yamada wrote:
> Collect the ignored patterns to is_ignored_symbol().
>
> Signed-off-by: Masahiro Yamada
This commit (887df76de67f5) caused a regression in my powerpc builds as it
causes symbol names to disappear from backtraces:
[ cut here
by the driver. Drop the extra state to simplify the code.
Fixes: 1da177e4c3f41 ("Linux-2.6.12-rc2") # v5.0+
Tested-by: Stan Johnson
Signed-off-by: Finn Thain
---
drivers/macintosh/via-macii.c | 70 ++-
1 file changed, 28 insertions(+), 42 deletions(-)
The function prototype correctly specifies the 'static' storage class.
Let the function definition match the declaration for better readability.
Signed-off-by: Finn Thain
---
drivers/macintosh/via-macii.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/macintosh/via
+'.
Finn Thain (9):
macintosh/via-macii: Access autopoll_devs when inside lock
macintosh/via-macii: Poll the device most likely to respond
macintosh/via-macii: Handle /CTLR_IRQ signal correctly
macintosh/via-macii: Remove read_done state
macintosh/via-macii: Handle poll replies correctly
The adb_request struct can be stored on the stack because the request
is synchronous and is completed before the function returns.
Tested-by: Stan Johnson
Signed-off-by: Finn Thain
---
drivers/macintosh/via-macii.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
Tested-by: Stan Johnson
Signed-off-by: Finn Thain
---
drivers/macintosh/via-macii.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/macintosh/via-macii.c b/drivers/macintosh/via-macii.c
index e143ddb81de34..447273967e1e8 100644
--- a/drivers/macintosh/via-macii.c
Tested-by: Stan Johnson
Signed-off-by: Finn Thain
---
drivers/macintosh/via-macii.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/macintosh/via-macii.c b/drivers/macintosh/via-macii.c
index 8d5ef77b4a435..e143ddb81de34 100644
--- a/drivers/macintosh/via
e from polling or autopolling,
so call adb_input() with the autopoll parameter set to 1.
Fixes: d95fd5fce88f0 ("m68k: Mac II ADB fixes") # v5.0+
Tested-by: Stan Johnson
Signed-off-by: Finn Thain
---
drivers/macintosh/via-macii.c | 20 ++--
1 file changed, 18 insertions
: 1da177e4c3f41 ("Linux-2.6.12-rc2") # v5.0+
Reported-by: Mark Cave-Ayland
Tested-by: Stan Johnson
Signed-off-by: Finn Thain
---
drivers/macintosh/via-macii.c | 166 --
1 file changed, 97 insertions(+), 69 deletions(-)
diff --git a/drivers/macintosh/via
;m68k: Mac II ADB fixes") # v5.0+
Tested-by: Stan Johnson
Signed-off-by: Finn Thain
---
drivers/macintosh/via-macii.c | 99 +++
1 file changed, 53 insertions(+), 46 deletions(-)
diff --git a/drivers/macintosh/via-macii.c b/drivers/macintosh/via-macii.c
index 6aa
The interrupt handler should be excluded when accessing the autopoll_devs
variable.
Fixes: d95fd5fce88f0 ("m68k: Mac II ADB fixes") # v5.0+
Tested-by: Stan Johnson
Signed-off-by: Finn Thain
---
drivers/macintosh/via-macii.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletion
On Tue, 16 Jun 2020, Martin K. Petersen wrote:
>
> However, keeping code around is not free.
Right. And removing code isn't free either, if it forces people to find
workarounds.
> Core interfaces change frequently. Nobody enjoys having to tweak host
> templates for 50 devices they have
On Tue, 16 Jun 2020, Martin K. Petersen wrote:
> > I haven't used this driver for a long time, but I still own PowerMacs
> > with firewire, and I know I'm not the only one.
>
I need to correct what I wrote above. I recall that years ago, when I
needed to share storage from my Linux box to my
On Tue, 16 Jun 2020, Bart Van Assche wrote:
>
> As far as I know the sbp driver only has had one user ever and that user
> is no longer user the sbp driver.
So, you estimate the userbase at zero. Can you give a confidence level?
Actual measurement is hard because when end users encounter
On Mon, 15 Jun 2020, Chris Boot wrote:
> On 15/06/2020 00:28, Finn Thain wrote:
> > On Sun, 14 Jun 2020, Chris Boot wrote:
> >
> >> I expect that if someone finds this useful it can stick around (but
> >> that's not my call).
> >
> > Who's call i
On Sun, 14 Jun 2020, Chris Boot wrote:
> I expect that if someone finds this useful it can stick around (but
> that's not my call).
Who's call is that? If the patch had said "From: Martin K. Petersen" and
"This driver is being removed because it has the following defects..."
that would be
On Sat, 13 Jun 2020, Chris Boot wrote:
> I no longer have the time to maintain this subsystem nor the hardware to
> test patches with.
Then why not patch MAINTAINERS, and orphan it, as per usual practice?
$ git log --oneline MAINTAINERS | grep -i orphan
> It also doesn't appear to have any
On Mon, 1 Jun 2020, Geert Uytterhoeven wrote:
> >
> > Sure, it could be absorbed by both asm/mac_iop.h and
> > drivers/macintosh/adb-iop.c [...]
>
> asm/mac_iop.h doesn't include asm/adb_iop.h (at least not in my tree,
> but perhaps you have plans to change that?), so there's only a single
>
On Sun, 31 May 2020, Geert Uytterhoeven wrote:
> Hi Finn,
>
> On Sun, May 31, 2020 at 1:20 AM Finn Thain wrote:
> > The adb_driver.autopoll method is needed during ADB bus scan and device
> > address assignment. Implement this method so that the IOP's list of
> > devi
' was not
declared. Should it be static?
drivers/macintosh/adb-iop.c:241:5: warning: symbol 'adb_iop_reset_bus' was not
declared. Should it be static?
Cc: Joshua Thompson
Tested-by: Stan Johnson
Signed-off-by: Finn Thain
---
drivers/macintosh/adb-iop.c | 14 +++---
1 file changed, 7 insertions(+), 7
On leaving the 'sending' state, proceed to the 'idle' state if no reply is
expected. Drop redundant test for adb_iop_state == sending && current_req.
Cc: Joshua Thompson
Tested-by: Stan Johnson
Signed-off-by: Finn Thain
---
drivers/macintosh/adb-iop.c | 7 +++
1 file changed, 3 in
Drop the redundant local_irq_save/restore() from adb_iop_start() because
the caller has to do it anyway. This is the pattern used in via-macii.
Cc: Joshua Thompson
Tested-by: Stan Johnson
Signed-off-by: Finn Thain
---
drivers/macintosh/adb-iop.c | 13 +
1 file changed, 5
This algorithm is slightly shorter and avoids the surprising
adb_iop_start() call in adb_iop_poll().
Cc: Joshua Thompson
Tested-by: Stan Johnson
Signed-off-by: Finn Thain
---
drivers/macintosh/adb-iop.c | 21 -
1 file changed, 8 insertions(+), 13 deletions(-)
diff --git
This patch improves comment style and corrects some misunderstandings
in the text.
Cc: Joshua Thompson
Tested-by: Stan Johnson
Signed-off-by: Finn Thain
---
drivers/macintosh/adb-iop.c | 29 +
1 file changed, 13 insertions(+), 16 deletions(-)
diff --git a/drivers
Cc: Joshua Thompson
Tested-by: Stan Johnson
Signed-off-by: Finn Thain
---
drivers/macintosh/adb-iop.c | 29 -
1 file changed, 29 deletions(-)
diff --git a/drivers/macintosh/adb-iop.c b/drivers/macintosh/adb-iop.c
index fca31640e3ef..ce28ff40fb9c 100644
in the driver, plus
a few clean-ups.
Finn Thain (8):
macintosh/adb-iop: Remove dead and redundant code
macintosh/adb-iop: Correct comment text
macintosh/adb-iop: Adopt bus reset algorithm from via-macii driver
macintosh/adb-iop: Access current_req and adb_iop_state when inside
lock
1 - 100 of 522 matches
Mail list logo
