Re: [PATCH 02/28] staging: android: ion: use vmap instead of vm_map_ram

2020-04-08 Thread Hillf Danton
On Wed, 8 Apr 2020 13:59:00 +0200 > > vm_map_ram can keep mappings around after the vm_unmap_ram. Using that > with non-PAGE_KERNEL mappings can lead to all kinds of aliasing issues. > > Signed-off-by: Christoph Hellwig > --- > drivers/staging/android/ion/ion_heap.c | 4 ++-- > 1 file

Re: Oops (request_key_auth_describe) while running cve-2016-7042 from LTP

2019-09-02 Thread Hillf Danton
> > Hi Hillf, > > Would you like to me to put you down as the author of this patch? If so, I'll > need a Signed-off-by from you. > Signed-off-by: Hillf Danton

Re: Oops (request_key_auth_describe) while running cve-2016-7042 from LTP

2019-08-31 Thread Hillf Danton
David Howells wrote: >> 1, callee has no pre defined duty to help caller in general; they should not >> try to do anything, however, to help their callers in principle due to >> limited info on their hands IMO. > > Ah, no. It's entirely reasonable for an API to specify that one of its > methods

Re: Oops (request_key_auth_describe) while running cve-2016-7042 from LTP

2019-08-31 Thread Hillf Danton
David Howells wrote: > > Hillf Danton wrote: > > > - struct request_key_auth *rka = dereference_key_rcu(key); > > + struct request_key_auth *rka; > > + > > + rcu_read_lock(); > > + rka = dereference_key_rcu(key); > > This shouldn't help as the

Re: Oops (request_key_auth_describe) while running cve-2016-7042 from LTP

2019-08-30 Thread Hillf Danton
On Fri, 30 Aug 2019 12:18:07 +0530 Sachin Sant wrote: > > [ 8074.351033] BUG: Kernel NULL pointer dereference at 0x0038 > [ 8074.351046] Faulting instruction address: 0xc04ddf30 > [ 8074.351052] Oops: Kernel access of bad area, sig: 11 [#1] > [ 8074.351056] LE PAGE_SIZE=64K MMU=Hash

Re: [PATCH 1/2] mm: move vma_is_anonymous check within pmd_move_must_withdraw

2016-11-07 Thread Hillf Danton
On Monday, November 07, 2016 4:35 PM Aneesh Kumar K.V > > Architectures like ppc64 want to use page table deposit/withraw > even with huge pmd dax entries. Allow arch to override the > vma_is_anonymous check by moving that to pmd_move_must_withdraw > function > > Signed-off-by: Aneesh Kumar K.V

Re: [PATCH] mm/hugetlb: Use the right pte val for compare in hugetlb_cow

2016-10-18 Thread Hillf Danton
> on ppc64 such pte_same check returned wrong result, resulting in us > taking an additional fault on ppc64. > > Fixes: 6a119eae942c ("powerpc/mm: Add a _PAGE_PTE bit") > > Reported-by: Jan Stancek <jstan...@redhat.com> > Signed-off-by: Aneesh Kumar K.V <a