;
void*platform_data;
+ struct dev_archdata *archdata;
int irq;
};
No objection from me:
Acked-by: Jean Delvare [EMAIL PROTECTED]
Let me know if I should push this patch upstream myself.
--
Jean Delvare
with this or the second patch? Can we merge them?
I do not have the time to review these patches (and, honestly, have no
interest in them.) So I will not merge them but I have no objection to
them being merged by somebody else.
--
Jean Delvare
___
Linuxppc
*/
-#define I2C_NAME_SIZE20
+#define I2C_NAME_SIZE23
#define I2C_MODULE_PREFIX i2c:
struct i2c_device_id {
--
Jean Delvare
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
linux/of_device.h
#include sound/pcm.h
#include linux/list.h
No objection from me, go ahead.
--
Jean Delvare
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
of the i2c subsystem) with Cc to the i2c list.
--
Jean Delvare
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
.
--
Jean Delvare
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Hi David,
On Tue, 15 Jul 2008 09:31:29 -0600, David Hubbard wrote:
On Tue, Jul 15, 2008 at 2:36 AM, Jean Delvare [EMAIL PROTECTED] wrote:
I always assumed that there was no way to know in advance if a
Super-I/O (LPC) chip was present or not, let alone the exact model of
the chip. The I/O
Hi Wolfgang,
On Wed, 16 Jul 2008 11:12:50 +0200, Wolfgang Grandegger wrote:
Jean Delvare wrote:
For hwmon chips, probing only occurs if the i2c adapter accepts to be
probed, by setting the I2C_CLASS_HWMON flag in i2c_adapter.class. If
you do not want a given i2c bus to be probed, then do
On Wed, 16 Jul 2008 11:50:15 +0200, Wolfgang Grandegger wrote:
Jean Delvare wrote:
The problem is that at this point in time, only a couple hwmon drivers
have been converted to new-style i2c. So, dropping the I2C_CLASS_HWMON
would break most systems.
I have a set of patches converting
to use a template for
struct i2c_adapter. This structure is relatively large compared to the
few fields you need to set. If you insist on having a template, it
should at least be marked either const or __initdata.
--
Jean Delvare
___
Linuxppc-dev mailing
On Wed, 16 Jul 2008 10:18:26 -0400, Jon Smirl wrote:
On 7/16/08, Grant Likely [EMAIL PROTECTED] wrote:
On Wed, Jul 16, 2008 at 12:10:59PM +0200, Jean Delvare wrote:
On Wed, 16 Jul 2008 11:50:15 +0200, Wolfgang Grandegger wrote:
Jean Delvare wrote:
Yep, as probing might
Hi Milton,
On Mon, 14 Jul 2008 12:09:03 -0500, Milton Miller wrote:
On Jul 14, 2008, at 2:59 AM, Jean Delvare wrote:
Well, there are two approaches to the problem. The first approach
(which I think Jim took in his patches? I don't really remember) is to
simply solve the problem
driver is a good way to go -- it fits with the way
the platform bus does things. Also, Jim's patches are almost there
already.
Good.
--
Jean Delvare
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc
not familiar with
it, but overall Jon appears to be right. Listing individual chips in
id_table is the standard way to go. That's even the very reason why we
decided to add this id_table to i2c_driver, instead of matching on the
driver name as we were doing before.
--
Jean Delvare
with PNP BIOS reservations,
etc. Milton, will you write a patch?
--
Jean Delvare
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
mode\n,
dev-fast_mode ? fast (400 kHz) : standard (100 kHz));
Looks OK. As I already have patches touching
drivers/i2c/busses/i2c-ibm_iic.c in my tree, I'm taking this patch
also. I will push it upstream during the 2.6.27 merge window.
Thanks,
--
Jean Delvare
it from your tree and merge it through mine?
Sure, no problem. It's done now, the patch is yours.
--
Jean Delvare
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
On Wed, 2 Jul 2008 15:33:43 +0200, Wolfram Sang wrote:
Hi Jean,
On Tue, Jul 01, 2008 at 06:14:44PM +0200, Jean Delvare wrote:
Applied, after fixing the patch so that it applies, fixing it again so
that it is correct in the polling case, and fixing it again to make it
pass checkpatch.pl
Friedrich and Paul Mackerras I guess. Would be nice to have a
MAINTAINERS entry for OF...
--
Jean Delvare
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
(fsl_i2c_driver);
+ of_unregister_platform_driver(mpc_i2c_driver);
}
module_init(fsl_i2c_init);
Applied, after fixing the patch so that it applies, fixing it again so
that it is correct in the polling case, and fixing it again to make it
pass checkpatch.pl.
--
Jean Delvare
On Tue, 1 Jul 2008 11:12:58 -0400, Jon Smirl wrote:
On 7/1/08, Jean Delvare [EMAIL PROTECTED] wrote:
I'm fine with this patch. In particular, exporting i2c_bus_type is OK.
It was un-exported only because it had no user left, but it can be
exported again if needed.
Another solution
On Tue, 1 Jul 2008 12:29:29 -0400, Jon Smirl wrote:
On 7/1/08, Jean Delvare [EMAIL PROTECTED] wrote:
Hi Jon,
On Mon, 30 Jun 2008 19:01:28 -0400, Jon Smirl wrote:
Add the of_find_i2c_device_by_node function. This allows you to
follow a reference in the device to an i2c device node
On Tue, 1 Jul 2008 12:38:05 -0400, Jon Smirl wrote:
On 7/1/08, Jean Delvare [EMAIL PROTECTED] wrote:
On Tue, 1 Jul 2008 11:12:58 -0400, Jon Smirl wrote:
On 7/1/08, Jean Delvare [EMAIL PROTECTED] wrote:
I'm fine with this patch. In particular, exporting i2c_bus_type is OK
On Tue, 1 Jul 2008 10:45:18 -0600, Grant Likely wrote:
On Tue, Jul 01, 2008 at 06:29:49PM +0200, Jean Delvare wrote:
On Tue, 1 Jul 2008 11:12:58 -0400, Jon Smirl wrote:
On 7/1/08, Jean Delvare [EMAIL PROTECTED] wrote:
I'm fine with this patch. In particular, exporting i2c_bus_type is OK
or not - otherwise all
user-space apps need to learn about both naming conversions.
Unsurprisingly, no other subsystem does what you propose.
--
Jean Delvare
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
On Tue, 1 Jul 2008 13:27:57 -0400, Jon Smirl wrote:
On 7/1/08, Jean Delvare [EMAIL PROTECTED] wrote:
On Tue, 1 Jul 2008 13:00:08 -0400, Jon Smirl wrote:
On 7/1/08, Grant Likely [EMAIL PROTECTED] wrote:
My preference is for things like of_spi and of_i2c to go with the
related
Hi Jon, Grant,
On Sat, 28 Jun 2008 22:49:40 -0600, Grant Likely wrote:
On Sat, Jun 28, 2008 at 10:05:28PM -0400, Jon Smirl wrote:
On 6/25/08, Jean Delvare [EMAIL PROTECTED] wrote:
i2c-adap = mpc_ops;
- i2c-adap.nr = pdev-id;
i2c_set_adapdata(i2c-adap, i2c
On Sun, 29 Jun 2008 00:58:12 -0600, Grant Likely wrote:
On Sun, Jun 29, 2008 at 08:31:43AM +0200, Jean Delvare wrote:
Hi Jon, Grant,
On Sat, 28 Jun 2008 22:49:40 -0600, Grant Likely wrote:
On Sat, Jun 28, 2008 at 10:05:28PM -0400, Jon Smirl wrote:
The driver was previously
On Sun, 29 Jun 2008 12:24:39 -0400, Sean MacLennan wrote:
On Sun, 29 Jun 2008 09:17:25 +0200
Jean Delvare [EMAIL PROTECTED] wrote:
Ah, OK. If you use i2c_new_device() then it's alright.
Correct.
I have done the same thing for the i2c-ibm_iic.c driver. Jean, I think
you will like
in it.
While mentioning Jochen's version of the patch: it was deleting 123
lines from arch/powerpc/sysdev/fsl_soc.c. Yours doesn't. Should it?
http://lists.lm-sensors.org/pipermail/i2c/2008-April/003314.html
--
Jean Delvare
___
Linuxppc-dev mailing list
Linuxppc
);
}
module_init(fsl_i2c_init);
This adds to Wolfram's comments about missing devinit/devexit tags
which were correct and should be addressed.
--
Jean Delvare
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
, },
- { .compatible = ibm,iic-440grx, },
+ { .compatible = ibm,iic, },
{}
};
OK, I can take this in my tree, unless it depends on arch-specific
patches which have not hit mainline yet. I guess this is 2.6.27
material?
--
Jean Delvare
Hi Ben,
On Fri, 06 Jun 2008 14:16:23 +1000, Benjamin Herrenschmidt wrote:
On Thu, 2008-06-05 at 09:48 +0200, Jean Delvare wrote:
As far as I am concerned, it's really up to the maintainers and users
of this platform. All I am asking for is that you do not call
i2c_add_numbered_adapter
. The following is a quote from Jean Delvare from a
I added Jean to CC now.
post from 8/2/16 4:31:
I don't like this static index thing much. Can't you just make the
index OF property mandatory? Mixing ways to number things can become
very confusing. In particular as you are using dev-idx later
: Maintained
+
FREESCALE DMA DRIVER
P: Li Yang
M: [EMAIL PROTECTED]
Applied, thanks.
--
Jean Delvare
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
-ibm_iic adapters?
--
Jean Delvare
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
++
3 files changed, 756 insertions(+), 0 deletions(-)
create mode 100644 drivers/i2c/busses/i2c-cpm.c
Changes since last version:
- change bus-frequency - clock-frequency to comply to OF standard.
Applied, thanks. And thanks a lot to Wolfram for the review :)
--
Jean Delvare
On Thu, 29 May 2008 17:52:26 +0200, Jean Delvare wrote:
On Wed, 21 May 2008 18:39:42 +0200, Jochen Friedrich wrote:
This driver uses the port of 2.4 code from Vitaly Bordug
[EMAIL PROTECTED] and the actual algorithm used by the i2c
driver of the DBox code on cvs.tuxboc.org from Felix Domke
failure
path instead of patch? But well, I assume typos in this section do not
matter much anyhow as they are not imported into git. Am I right, Jean?
Yes you are.
--
Jean Delvare
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org
Hi Jon,
On Fri, 2 May 2008 10:23:01 -0400, Jon Smirl wrote:
On 2/19/08, Jean Delvare [EMAIL PROTECTED] wrote:
i2c-irq = platform_get_irq(pdev, 0);
- if (i2c-irq 0) {
+ if (i2c-irq NO_IRQ) {
I am skeptical about this one. Can platform_get_irq() really return
platform_device *pdev)
i2c_del_adapter(i2c-adap);
platform_set_drvdata(pdev, NULL);
- if (i2c-irq != 0)
+ if (i2c-irq != NO_IRQ)
free_irq(i2c-irq, i2c);
iounmap(i2c-base);
--
Jean Delvare
___
Linuxppc-dev
On Fri, 2 May 2008 13:19:44 -0400, Jon Smirl wrote:
I attached the diff file. I had forgot that I renamed the file so it
wasn't getting compiled. I compiled it this time. I've made too many
other changes to it to test this version on my current hardware.
Applied, thanks.
--
Jean Delvare
Hi Kay,
On Mon, 28 Apr 2008 18:16:17 +0200, Kay Sievers wrote:
On Mon, 2008-04-28 at 17:40 +0200, Jean Delvare wrote:
Why would i2c device modaliases ever contain multiple strings? A device
can't have multiple names, can it?
Like ACPI/PNP devices, which can have several compat id's, which
this evening. The more testing it
gets, the better. Thanks to Wolfram and Jochen for yesterday's test
reports!
--
Jean Delvare
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
-by: Jean Delvare [EMAIL PROTECTED]
Cc: Jochen Friedrich [EMAIL PROTECTED]
Cc: Jon Smirl [EMAIL PROTECTED]
Cc: Kay Sievers [EMAIL PROTECTED]
---
Documentation/i2c/writing-clients |3 +
drivers/gpio/pca953x.c |3 +
drivers/gpio/pcf857x.c |3
with, they'll have their own
patch later.
Signed-off-by: Jean Delvare [EMAIL PROTECTED]
Cc: Jon Smirl [EMAIL PROTECTED]
Cc: Jochen Friedrich [EMAIL PROTECTED]
---
arch/arm/mach-at91/board-csb337.c |3 -
arch/arm/mach-at91/board-dk.c |3 -
arch/arm/mach-at91/board-eb9200.c
Hi Jon,
On Tue, 29 Apr 2008 08:16:13 -0400, Jon Smirl wrote:
On 4/29/08, Jean Delvare [EMAIL PROTECTED] wrote:
Based on earlier work by Jon Smirl and Jochen Friedrich.
+/* Looks like: i2c:S */
+static int do_i2c_entry(const char *filename, struct i2c_device_id *id
with, they'll have their own
patch later.
Signed-off-by: Jean Delvare [EMAIL PROTECTED]
Cc: Jon Smirl [EMAIL PROTECTED]
Cc: Jochen Friedrich [EMAIL PROTECTED]
Cc: Kay Sievers [EMAIL PROTECTED]
---
arch/arm/mach-at91/board-csb337.c |3 -
arch/arm/mach-at91/board-dk.c |3 -
arch
-by: Jean Delvare [EMAIL PROTECTED]
Cc: Jochen Friedrich [EMAIL PROTECTED]
Cc: Jon Smirl [EMAIL PROTECTED]
Cc: Kay Sievers [EMAIL PROTECTED]
---
One thing I am still not happy with is that the aliases created have a
trailing *:
$ /sbin/modinfo lm90
filename: /lib/modules/2.6.25-git11/kernel/drivers
Hi Kay,
On Mon, 28 Apr 2008 17:07:25 +0200, Kay Sievers wrote:
On Mon, 2008-04-28 at 11:39 +0200, Jean Delvare wrote:
One thing I am still not happy with is that the aliases created have a
trailing *:
$ /sbin/modinfo lm90
filename: /lib/modules/2.6.25-git11/kernel/drivers/hwmon
Hi Jon,
On Mon, 28 Apr 2008 10:43:35 -0400, Jon Smirl wrote:
On 4/28/08, Jean Delvare [EMAIL PROTECTED] wrote:
One thing I am still not happy with is that the aliases created have a
trailing *:
$ /sbin/modinfo lm90
filename: /lib/modules/2.6.25-git11/kernel/drivers/hwmon/lm90
updated patches for review and testing as soon as I
am done.
--
Jean Delvare
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
, Jean Delvare wrote:
--- linux-2.6.24-rc8.orig/drivers/rtc/rtc-ds1307.c 2008-01-20
17:26:58.0 +0100
+++ linux-2.6.24-rc8/drivers/rtc/rtc-ds1307.c 2008-01-20
19:03:48.0 +0100
@@ -102,42 +102,36 @@ struct chip_desc {
charname[9];
unsigned
Hi Jochen,
On Fri, 11 Apr 2008 16:07:35 +0200, Jochen Friedrich wrote:
Based on earlier work by Jon Smirl and Jean Delvare.
This patch allows new-style i2c chip drivers to have alias names using
the official kernel aliasing system and MODULE_DEVICE_TABLE(). At this
point, the old i2c driver
Hi Jon,
On Tue, 19 Feb 2008 17:42:21 +0100, Jean Delvare wrote:
On Mon, 21 Jan 2008 15:07:40 -0500, Jon Smirl wrote:
Alter the mpc i2c driver to use the NO_IRQ symbol instead of
the constant zero when checking for valid interrupts. NO_IRQ=-1
on ppc and NO_IRQ=0 on powerpc so the checks
life these days so I just don't know when
I will find the time an energy to go through this huge patch set.
--
Jean Delvare
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Hi Laurent,
On Tue, 22 Apr 2008 16:11:56 +0200, Laurent Pinchart wrote:
Hi Jean,
On Saturday 19 April 2008 18:43, Jochen Friedrich wrote:
Jean Delvare wrote:
I'm not sure. I didn't have the time to look at it myself, but I am
under the impression that the powerpc folks are tired
On Wed, 23 Apr 2008 14:12:37 +0200, Laurent Pinchart wrote:
On Wednesday 23 April 2008 13:16, Jean Delvare wrote:
I still don't know exactly what happened there... I think I saw some
OpenFirmware i2c patches go upstream yesterday? But not the ones
listed below, which I thought they depended
and
sparc64 trees so that loosening the dependency doesn't break anything.
As far as I can see it's only a matter of changing one line in a
Kconfig file, that's not exactly difficult to do it in the right order.
Thanks,
--
Jean Delvare
___
Linuxppc-dev mailing
on this
during the last 2 weeks, hopefully I will fine some time to experiment
again soon. As I underlined before, my patch set affects no less than 5
subsystems with different needs and expectations, it's no trivial
change.
--
Jean Delvare
___
Linuxppc-dev
)
+{
+ of_unregister_platform_driver(cpm_i2c_driver);
+}
+
+module_init(cpm_i2c_init);
+module_exit(cpm_i2c_exit);
+
+MODULE_AUTHOR(Dan Malek [EMAIL PROTECTED]);
Why not your own name?
+MODULE_DESCRIPTION(I2C-Bus adapter routines for CPM boards);
+MODULE_LICENSE(GPL);
--
Jean Delvare
comments, I
can push your 2 i2c-ibm_iic patches to -mm.
Thanks,
--
Jean Delvare
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Hi Jon,
On Fri, 25 Jan 2008 12:16:46 -0500, Jon Smirl wrote:
Any final objections to this patch? Jean can you pick it up?
Sorry for the delay, I'll review your patch right now. Note that the
driver is really named pcf8563 not pfc8563.
--
Jean Delvare
= i2c_get_clientdata(client);
-
- if (rtc)
- rtc_device_unregister(rtc);
-
- if ((err = i2c_detach_client(client)))
- return err;
-
- kfree(pcf8563);
-
- return 0;
}
static int __init pcf8563_init(void)
--
Jean Delvare
On Tue, 19 Feb 2008 10:17:43 -0500, Jon Smirl wrote:
On 2/19/08, Jean Delvare [EMAIL PROTECTED] wrote:
Hi Jon,
On Mon, 21 Jan 2008 15:09:01 -0500, Jon Smirl wrote:
Convert pfc8563 i2c driver from old style to new style.
Let's just forget about this patch until the dynamic module
);
iounmap(i2c-base);
The rest looks good.
--
Jean Delvare
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
On Tue, 19 Feb 2008 17:24:50 +0100, Alessandro Zummo wrote:
On Tue, 19 Feb 2008 16:10:20 +0100
Jean Delvare [EMAIL PROTECTED] wrote:
Hi Jon,
On Mon, 21 Jan 2008 15:09:01 -0500, Jon Smirl wrote:
Convert pfc8563 i2c driver from old style to new style.
Signed-off-by: Jon Smirl
Hi Arnd,
On Tue, 19 Feb 2008 23:55:16 +0100, Arnd Bergmann wrote:
On Tuesday 19 February 2008, Stefan Roese wrote:
On Tuesday 19 February 2008, Jean Delvare wrote:
With this Kconfig change, make menuconfig lets me select the
i2c-ibm_iic driver on x86_64, but it fails to build horribly
been
taken.
Thanks,
--
Jean Delvare
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
++;
tmp++;
--
Jean Delvare
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
this
would solve this particular problem.
It wouldn't, but at least I could NAK it or make it CONFIG_X86 :-)
The same could be done for user-space (or at the /dev/port level.)
--
Jean Delvare
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
Hi Sean,
On Sat, 16 Feb 2008 15:54:14 -0500, Sean MacLennan wrote:
Jean Delvare wrote:
Hi Sean,
On Fri, 15 Feb 2008 23:11:12 -0500, Sean MacLennan wrote:
Here is the of platform patch. I removed the retries and removed the
spaces used for spacing.
Cheers,
Sean
Signed
On Fri, 15 Feb 2008 23:07:21 -0500, Sean MacLennan wrote:
Jean Delvare wrote:
Please split your patch into logical parts:
* Whitespace and coding-style cleanups
* Other cleanups (e.g. changing the log levels)
* Add OF support
Here is the first patch with everything except
as the original
code does, you wouldn't have to duplicate the module_init and
module_exit statements.
+#endif
Please add a comment saying what this #endif corresponds to.
Note that I cannot test the code so I am relying on the linuxppc-dev
folks to test it.
--
Jean Delvare
to the target architecture and hardware. So Jochen did the right
thing by sending this patch to Scott at first.
--
Jean Delvare
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
(adap_node, node) {
instead and you don't need to initialise node above.
+static struct of_device_id cpm_i2c_match[] = {
const?
Do you have an updated patch addressing Stephen's comment?
Note: you'd rather send updates of this patch to the i2c list rather
than LKML.
Thanks,
--
Jean Delvare
i2c development,
subscribing was a good idea anyway.)
--
Jean Delvare
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
in parallel.
--
Jean Delvare
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Based on earlier work by Jon Smirl.
This patch allows new-style i2c chip drivers to have alias names using
the official kernel aliasing system and MODULE_DEVICE_TABLE(). At this
point, the old i2c driver binding scheme (driver_name/type) is still
supported.
Signed-off-by: Jean Delvare [EMAIL
. Thus I will revert this part for the time being, if any
change is really needed with regards to interrupts in this driver,
please send a separate patch. But please double-check first, as I said
above it's trickier than it looks.
--
Jean Delvare
? As a matter of fact, I did not apply Jon's patch
to module-init-tools, and modinfo shows me module aliases properly
for i2c drivers that call MODULE_DEVICE_TABLE():
$ /sbin/modinfo lm90
filename: /lib/modules/2.6.24-rc7-git4/kernel/drivers/hwmon/lm90.ko
author: Jean Delvare [EMAIL
On Mon, 14 Jan 2008 18:08:16 +0100 (CET), Geert Uytterhoeven wrote:
On Mon, 14 Jan 2008, Jean Delvare wrote:
I thought that the module aliases were generated by
scripts/mod/modpost? As a matter of fact, I did not apply Jon's patch
Sorry, you're right. Too early in the morning
On Mon, 14 Jan 2008 20:38:28 +0100, Kay Sievers wrote:
On Jan 14, 2008 6:50 PM, Jean Delvare [EMAIL PROTECTED] wrote:
I am under the impression that modules.*map are the old way to get
automatic driver loading and aliases are the new way to do the same.
But maybe that's just me.
Right
On Mon, 17 Dec 2007 21:39:37 -0500, Jon Smirl wrote:
Follow on to: Series to add device tree naming to i2c
Teach module-init-tools about the i2c subsystem.
Can you please explain what this patch does and why it is needed?
--
Jean Delvare
given that it is only temporary.
--
Jean Delvare
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Hi Jon,
On Sat, 12 Jan 2008 11:00:31 -0500, Jon Smirl wrote:
On 1/12/08, Jean Delvare wrote:
What I meant is that the translation from Open Firmware device name to
Linux device name could happen in different ways. Making module aliases
out of the is one possibility but this is not the only
On Sun, 13 Jan 2008 10:14:14 -0500, Jon Smirl wrote:
On 1/13/08, Jean Delvare [EMAIL PROTECTED] wrote:
On Mon, 17 Dec 2007 21:39:37 -0500, Jon Smirl wrote:
Follow on to: Series to add device tree naming to i2c
Teach module-init-tools about the i2c subsystem.
Can you please explain
On Sun, 13 Jan 2008 11:24:29 -0500, Jon Smirl wrote:
On 1/13/08, Jean Delvare wrote:
On Sat, 12 Jan 2008 11:26:34 -0500, Jon Smirl wrote:
IMHO, driver_name/type should be removed in new style drivers and
replaced with aliases on all platforms since aliases are the standard
kernel
On Sun, 13 Jan 2008 11:26:07 -0500, Jon Smirl wrote:
On 1/13/08, Jean Delvare [EMAIL PROTECTED] wrote:
On Sun, 13 Jan 2008 10:14:14 -0500, Jon Smirl wrote:
On 1/13/08, Jean Delvare [EMAIL PROTECTED] wrote:
On Mon, 17 Dec 2007 21:39:37 -0500, Jon Smirl wrote:
Follow on to: Series
Hi Jon,
On Sun, 13 Jan 2008 13:01:06 -0500, Jon Smirl wrote:
On 1/13/08, Jean Delvare wrote:
On Sun, 13 Jan 2008 11:24:29 -0500, Jon Smirl wrote:
The kernel automatically exposes modalias as a sysfs attribute so the
string must be recorded further down in the driver support layers
On Sun, 13 Jan 2008 13:50:46 -0500, Jon Smirl wrote:
On 1/13/08, Jean Delvare [EMAIL PROTECTED] wrote:
The eeprom case might be a bit confusing because that i2c driver
supports a single device type, so the driver name is the same as the
device name. Take a look at the hwmon/lm90 driver
Hi Jon,
On Fri, 11 Jan 2008 20:20:15 +0100, Jean Delvare wrote:
+{
+ /* only powerpc drivers implement the id_table,
+* it is empty on other platforms */
+ if (id) {
+ while (id-name[0]) {
+ if (strcmp(client-driver_name, id-name) == 0
On Fri, 11 Jan 2008 15:16:57 -0500, Jon Smirl wrote:
On 1/11/08, Jean Delvare [EMAIL PROTECTED] wrote:
Secondly, it promotes OF device names as acceptable aliases. This I
don't think I agree with. While I see some value in moving the OF name
- Linux name translation to the drivers
that were raised on the way, I
can start reviewing the latest iteration of your patches. I'll also do
some testing, although I have no powerpc stuff here, but at least I
want to make sure that there are no regressions introduced by your
patches on x86.
--
Jean Delvare
i2c_device_id), i2c,
+ do_i2c_entry, mod);
free(zeros);
}
--
Jean Delvare
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
On Fri, 11 Jan 2008 10:52:56 -0500, Jon Smirl wrote:
On 1/11/08, Jean Delvare wrote:
Now that I have read all the previous versions of this patch series
and, more importantly, all objections that were raised on the way, I
can start reviewing the latest iteration of your patches. I'll also
On Thu, 10 Jan 2008 09:14:26 -0500, Jon Smirl wrote:
What is the review status of this series, should I post it again?
No please! /o\
I'll go through your numerous past posts now, stay tuned.
--
Jean Delvare
___
Linuxppc-dev mailing list
Linuxppc
if compiled in.
Are there any further objections to this patch? Can it all go in
through the powerpc trees or do the i2c people want to send it on?
I am on vacation until January 4th. I will review your patchset the week
following my return.
Thanks for your patience,
--
Jean Delvare
On Fri, 2 Nov 2007 23:12:43 +0100, Jean Delvare wrote:
Hi Adrian,
On Thu, 1 Nov 2007 00:03:58 +0100, Adrian Bunk wrote:
This patch contains the scheduled removal of legacy I2C RTC drivers with
replacement drivers.
(...)
Documentation/feature-removal-schedule.txt |7
arch
.
--
Jean Delvare
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
101 - 200 of 209 matches
Mail list logo
