Re: ppc/sata-fsl: orphan config value: CONFIG_MPC8315_DS

2013-04-30 Thread Jeff Garzik
On 04/30/2013 02:41 AM, Anthony Foiani wrote: Apologies for resurrecting a very old thread, but... On 05/30/2012 02:14 PM, Anthony Foiani wrote: Maybe someone who knows devtree really well could crank that out in a few minutes... but I'm not that person. :) Well, I wasn't last year, but

Re: [PATCH] fsl/sata: create a sysfs entry for rx water mark

2013-04-03 Thread Jeff Garzik
On 03/04/2013 02:20 AM, Qiang Liu wrote: Support config RX WATER MARK via sysfs when running at run-time; A wrokaround for fix the exception happened to some WD HDD, found on WD3000HLFS-01G6U1, WD3000HLFS-01G6U0, some SSD disks. The read performance is also regression (about 30%) when use

Re: [PATCH 1/1] Add support 2 SATA ports for Maui and change filename from sata_dwc_460ex.c to sata_dwc_4xx.c

2012-04-13 Thread Jeff Garzik
On 04/13/2012 03:18 AM, Thang Nguyen wrote: Thanks Jeff and Sergei, As your suggestion, I will separate the patch into smaller patches and support more features on the SATA DWC driver. The patches I intend to do on the SATA DWC are as below: - Support hardreset: currently the hardreset is not

Re: [PATCH 1/1] Add support 2 SATA ports for Maui and change filename from sata_dwc_460ex.c to sata_dwc_4xx.c

2012-04-12 Thread Jeff Garzik
On 04/03/2012 07:56 AM, Sergei Shtylyov wrote: Hello. On 03-04-2012 14:12, Thang Q. Nguyen wrote: Signed-off-by: Thang Q. Nguyentqngu...@apm.com --- Changes for v2: - Use git rename feature to change the driver to the newname and for easier review. arch/powerpc/boot/dts/bluestone.dts | 21

Re: [PATCH V3] fsl-sata: add support for interrupt coalsecing feature

2012-03-02 Thread Jeff Garzik
On 02/28/2012 09:54 PM, Liu Qiang-B32616 wrote: Hi Jeff, Do you plan to apply it to upstream, or any suggestions? Thanks. This patch has been in libata-dev (and thus linux-next) for about 2 weeks... ___ Linuxppc-dev mailing list

Re: [PATCH V2] fsl-sata: I/O load balancing

2012-02-10 Thread Jeff Garzik
On 01/19/2012 09:19 PM, qiang@freescale.com wrote: From: Qiang Liuqiang@freescale.com Reduce interrupt signals through reset Interrupt Coalescing Control Reg. Provide dynamic method to adjust interrupt signals and timer ticks by sysfs. It is a tradeoff for different applications.

Re: [PATCH][SDK v1.2] sata: I/O load balancing

2012-01-17 Thread Jeff Garzik
On 01/13/2012 04:57 AM, Liu Qiang-B32616 wrote: No, I didn't test small file. I think this won't affect system load. I can have a test and describe the result in next patch. Please do... ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org

Re: [PATCH] libata/sas: only set FROZEN flag if new EH is supported

2011-06-21 Thread Jeff Garzik
On 06/21/2011 04:30 PM, Brian King wrote: Looks good to me. Jeff/Tejun - any issues with merging this? Looks good here too -- though of course we want to move towards purging old-EH paths :) Queued... ___ Linuxppc-dev mailing list

Re: known working sata_sil24.c setup on powerpc platforms?

2011-04-06 Thread Jeff Garzik
On 04/06/2011 01:48 PM, Moffett, Kyle D wrote: On Apr 06, 2011, at 13:00, Leon Woestenberg wrote: after investigating problems with sata_sil24.c on a freescale p2020 soc, I wonder if this driver works on powerpc at all? Does anyone know of a working setup of sata_sil24 on a big endian powerpc

Re: [PATCH][v3] driver/FSL SATA:Fix wrong Device Error Register usage

2011-03-14 Thread Jeff Garzik
On 03/09/2011 02:17 AM, Prabhakar Kushwaha wrote: When a single device error is detected, the device under the error is indicated by the error bit set in the DER. There is a one to one mapping between register bit and devices on Port multiplier(PMP) i.e. bit 0 represents PMP device 0 and bit 1

Re: [PATCH #upstream-fixes] pata_mpc52xx: inherit from ata_bmdma_port_ops

2011-01-18 Thread Jeff Garzik
On 01/09/2011 05:48 PM, Tejun Heo wrote: pata_mpc52xx supports BMDMA but inherits ata_sff_port_ops which triggers BUG_ON() when a DMA command is issued. Fix it. Signed-off-by: Tejun Heot...@kernel.org Reported-by: Roman Fietzeroman.fie...@telemotive.de Cc: Sergei Shtylyovsshtyl...@mvista.com

Re: [PATCH] ATA: Add FSL sata v2 controller support

2011-01-18 Thread Jeff Garzik
(of_device_is_compatible call). Acked-by: Jeff Garzik jgar...@redhat.com ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH RESEND] pata_mpc52xx: driver needs BMDMA

2010-12-24 Thread Jeff Garzik
On 12/22/2010 10:50 AM, Wolfram Sang wrote: Found by this build-error if BMDMA is disabled: drivers/ata/pata_mpc52xx.c: In function 'mpc52xx_ata_init_one': drivers/ata/pata_mpc52xx.c:662: error: 'ata_bmdma_interrupt' undeclared (first use in this function) ... Move the Kconfig entry to the

Re: [PATCH v2]460EX on-chip SATA driverresubmisison

2010-07-14 Thread Jeff Garzik
On 07/06/2010 07:06 AM, Rupjyoti Sarmah wrote: This patch enables the on-chip DWC SATA controller of the AppliedMicro processor 460EX. Signed-off-by: Rupjyoti Sarmahrsar...@appliedmicro.com Signed-off-by: Mark Miesfeldmmiesf...@appliedmicro.com Signed-off-by: Prodyut

Re: [PATCH v1]460EX on-chip SATA driverresubmisison

2010-06-30 Thread Jeff Garzik
On 06/30/2010 02:47 PM, Wolfgang Denk wrote: Dear Rupjyoti Sarmah, In message3b928476b2fffdcf0694e5436e8a4...@mail.gmail.com you wrote: I took the mainline kernel v2.6.35-rc3 and downloaded using the git download link. I created the patch on 6/24/2010 after doing a git pull. I don;t think

Re: [PATCH]460EX on-chip SATA driver Kernel 2.6.33 resubmission

2010-05-14 Thread Jeff Garzik
On 05/05/2010 01:57 PM, Rupjyoti Sarmah wrote: +static void clear_interrupt_bit(struct sata_dwc_device *hsdev, u32 bit) +{ + out_le32(hsdev-sata_dwc_regs-intpr, +in_le32(hsdev-sata_dwc_regs-intpr)); +} + +static u32 qcmd_tag_to_mask(u8 tag) +{ + return 0x0001

Re: [PATCH] 460EX on-chip SATA driverkernel 2.6.33 resubmission : 02

2010-04-06 Thread Jeff Garzik
On 04/06/2010 07:41 AM, Rupjyoti Sarmah wrote: General comment: remove inline and let the compiler select those functions that need it. +struct sata_dwc_host_priv { + + void __iomem *scr_addr_sstatus; + u32 sata_dwc_sactive_issued; + u32 sata_dwc_sactive_queued; +

Re: [PATCH] 460EX on-chip SATA driverkernel 2.6.33 resubmission : 01

2010-03-17 Thread Jeff Garzik
On 03/17/2010 08:03 AM, Stefan Roese wrote: Hi Rup, On Wednesday 17 March 2010 05:23:16 Rupjyoti Sarmah wrote: This patch enables the on-chip DWC SATA controller of the AppliedMicro processor 460EX. Apart from the other comments, did you take a look at the latest version of this driver in

Re: [PATCH 21/37] drivers/ata: use .dev.of_node instead of .node in struct of_device

2010-03-11 Thread Jeff Garzik
On 03/11/2010 01:31 PM, Sergei Shtylyov wrote: Hello. Grant Likely wrote: .node is being removed Signed-off-by: Grant Likely grant.lik...@secretlab.ca --- drivers/ata/pata_macio.c | 2 +- drivers/ata/pata_of_platform.c | 2 +- drivers/ide/pmac.c | 10 +- 3 files changed, 7

Re: [PATCH] pata_mpc52xx: optimizing code size by change of ATA timing data types

2010-03-01 Thread Jeff Garzik
On 02/16/2010 02:41 PM, Grant Likely wrote: [cc'd linux-kernel, linux-ide and Jeff Garzik] Hi Roman. you should use ./scripts/get_maintainer.pl to make sure you're cc'ing the right people when posting patches. You should repost so that Jeff has a copy of the patch to pick up (and add my acked

Re: [PATCH 5/5] libata/drivers: Add pata_macio, driver Apple PowerMac/PowerBook IDE controller

2009-12-03 Thread Jeff Garzik
On 12/01/2009 07:36 PM, Benjamin Herrenschmidt wrote: This is a libata driver for the macio IDE controller used on most Apple PowerMac and PowerBooks. It's a libata equivalent of drivers/ide/ppc/pmac.c It supports all the features of its predecessor, including mediabay hotplug and

Re: [PATCH 4/5] libata/sff: Use ops-bmdma_stop instead of ata_bmdma_stop()

2009-12-02 Thread Jeff Garzik
to carry this in your tree as well. git should be able to sort it out. Acked-by: Jeff Garzik jgar...@redhat.com ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] sata_fsl: Split hard and soft reset

2009-11-19 Thread Jeff Garzik
On 10/16/2009 12:44 PM, Anton Vorontsov wrote: From: Jiang Yutangb14...@freescale.com Split sata_fsl_softreset() into hard and soft resets to make error-handling more efficient device and PMP detection more reliable. Also includes fix for PMP support, driver tested with Sil3726, Sil4726 Exar

Re: [PATCH][v3] Add asynchronous notification support

2009-11-19 Thread Jeff Garzik
On 07/01/2009 11:29 AM, ashish kalra wrote: Enable device hot-plug support on Port multiplier fan-out ports v3 fixes whitespace/identation issues Signed-off-by: Ashish Kalra ashish.ka...@freescale.com --- drivers/ata/sata_fsl.c | 15 ++- 1 files changed, 10 insertions(+), 5

Re: [PATCH] sata_fsl: Split hard and soft reset

2009-11-16 Thread Jeff Garzik
On 11/05/2009 10:02 AM, Kumar Gala wrote: On Oct 16, 2009, at 11:44 AM, Anton Vorontsov wrote: From: Jiang Yutang b14...@freescale.com Split sata_fsl_softreset() into hard and soft resets to make error-handling more efficient device and PMP detection more reliable. Also includes fix for

Re: [PATCH 1/1] ata/sata_sil24: MSI support, disabled by default

2009-11-16 Thread Jeff Garzik
On 11/16/2009 01:19 AM, Vivek Mahajan wrote: The following patch adds MSI support. Some platforms may have broken MSI, so those are defaulted to use legacy PCI interrupts. Signed-off-by: Vivek Mahajanvivek.maha...@freescale.com --- drivers/ata/sata_sil24.c |9 + 1 files changed,

Re: [PATCH 1/1] ata/sata_sil24: MSI support, disabled by default

2009-11-16 Thread Jeff Garzik
On 11/17/2009 01:59 AM, Mahajan Vivek-B08308 wrote: From: Grant Grundler [mailto:grund...@google.com] Sent: Monday, November 16, 2009 11:08 PM +static int sata_sil24_msi;/* Disable MSI */ +module_param_named(msi, sata_sil24_msi, bool, S_IRUGO); +MODULE_PARM_DESC(msi, Enable MSI (Default:

Re: [RESEND][PATCH] sata_fsl: hard and soft reset split

2009-09-11 Thread Jeff Garzik
On 06/29/2009 09:26 AM, ashish kalra wrote: Split sata_fsl_softreset() into hard and soft resets to make error-handling more efficient device and PMP detection more reliable. Also includes fix for PMP support, driver tested with Sil3726, Sil4726 Exar PMP controllers. Signed-off-by: Ashish

Re: [PATCH][sata_fsl] Defer non-ncq commands when ncq commands active

2009-09-08 Thread Jeff Garzik
On 07/29/2009 12:03 PM, ashish kalra wrote: From: Ashish Kalra ashish.ka...@freescale.com Date: Wed, 29 Jul 2009 21:15:49 +0530 Fix for non-ncq ncq commands causing timeouts when both are issued simultaneously to the same device. Signed-off-by: Ashish Kalra ashish.ka...@freescale.com ---

Re: [PATCH] sata_fsl: Add power mgmt support

2009-06-23 Thread Jeff Garzik
Kumar Gala wrote: From: Dave Liu dave...@freescale.com Signed-off-by: Dave Liu dave...@freescale.com Signed-off-by: Liu Yu yu@freescale.com Signed-off-by: Kumar Gala ga...@kernel.crashing.org --- drivers/ata/sata_fsl.c | 35 +++ 1 files changed, 35

Re: [PATCH v3] sata_fsl: Fix compile warnings

2009-05-15 Thread Jeff Garzik
Kumar Gala wrote: We we build with dma_addr_t as a 64-bit quantity we get: drivers/ata/sata_fsl.c: In function 'sata_fsl_fill_sg': drivers/ata/sata_fsl.c:340: warning: format '%x' expects type 'unsigned int', but argument 4 has type 'dma_addr_t' Signed-off-by: Kumar Gala

Re: [PATCH 1/3 v3] Added support for Designware SATA controller driver

2009-05-11 Thread Jeff Garzik
Feng Kan wrote: Signed-off-by: Feng Kan f...@amcc.com Signed-off-by: Mark Miesfeld miesf...@gmail.com --- drivers/ata/Kconfig| 10 + drivers/ata/Makefile |1 + drivers/ata/sata_dwc.c | 2053 3 files changed, 2064 insertions(+), 0

Re: [PATCH 1/2] Add support for Designware SATA controller driver

2009-05-01 Thread Jeff Garzik
Feng Kan wrote: Signed-off-by: Feng Kan f...@amcc.com --- drivers/ata/Kconfig| 76 +- drivers/ata/Makefile |1 + drivers/ata/sata_dwc.c | 2047 3 files changed, 2091 insertions(+), 33 deletions(-) create mode 100644

Re: [PATCH 1/2] Add support for Designware SATA controller driver

2009-05-01 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: Patch 2/2 is just adding the device-tree bits to the platform for this driver to match against, so it's no big deal. However, Feng, we already mentioned that you do a lot of unrelated changes to the Kconfig file that shouldn't be part of this patch, just add the

Re: [PATCH 1/2] Added support for Designware SATA controller driver

2009-05-01 Thread Jeff Garzik
Wolfgang Denk wrote: Dear Feng Kan, In message 1241211767-32697-1-git-send-email-f...@amcc.com you wrote: This adds support for the Designware SATA controller. Signed-off-by: Feng Kan f...@amcc.com Signed-off-by: Mark Miesfeld miesf...@gmail.com --- drivers/ata/Kconfig| 10 +

Re: ahci: drop intx manipulation on msi enable breaks ULI M1575

2009-04-08 Thread Jeff Garzik
Michael Ellerman wrote: On Tue, 2009-04-07 at 19:36 -0500, Timur Tabi wrote: On Tue, Apr 7, 2009 at 6:57 PM, Tejun Heo t...@kernel.org wrote: Hmmm... that means intx isn't set by default. I'm not sure what is the right thing to do here. I think it's something which should be handled by the

Re: ahci: drop intx manipulation on msi enable breaks ULI M1575

2009-04-08 Thread Jeff Garzik
Michael Ellerman wrote: On Wed, 2009-04-08 at 23:23 -0500, Kumar Gala wrote: On Apr 8, 2009, at 6:53 PM, Michael Ellerman wrote: On Wed, 2009-04-08 at 17:15 -0500, Timur Tabi wrote: On Wed, Apr 8, 2009 at 4:31 PM, Tejun Heo t...@kernel.org wrote: Hmmm... for now, I think it would be best to

Re: [PATCH 2/2] powerpc/mpc5200: Add MDMA/UDMA support to MPC5200 ATA driver

2008-11-14 Thread Jeff Garzik
ACK ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] ehea: Fix some whitespace issues

2008-11-05 Thread Jeff Garzik
Hannes Hering wrote: This patch removes some trailing whitespaces and spaces before tabs. Signed-off-by: Hannes Hering [EMAIL PROTECTED] --- diff -Nurp -X dontdiff linux-2.6.28-rc3/drivers/net/ehea/ehea.h patched_kernel/drivers/net/ehea/ehea.h --- linux-2.6.28-rc3/drivers/net/ehea/ehea.h

Re: [PATCH 1/2] gianfar: Fix race in TBI/SerDes configuration

2008-10-30 Thread Jeff Garzik
Trent Piepho wrote: The init_phy() function attaches to the PHY, then configures the SerDes-TBI link (in SGMII mode). The TBI is on the MDIO bus with the PHY (sort of) and is accessed via the gianfar's MDIO registers, using the functions gfar_local_mdio_read/write(), which don't do any locking.

Re: [PATCH] ehea: Add hugepage detection

2008-10-27 Thread Jeff Garzik
Thomas Klein wrote: All kernel memory which is used for kernel/hardware data transfer must be registered with firmware using memory regions. 16GB hugepages may not be part of a memory region due to firmware restrictions. This patch modifies the walk_memory_resource callback fn to filter

Re: [PATCH] ibm_newemac: Fix typo in flow control config option

2008-10-27 Thread Jeff Garzik
Josh Boyer wrote: The recent build fix for ibm_newemac has a typo in the config option #ifdef used for disabling flow control. This corrects it to the proper Kconfig option name. Reported-by: Christoph Hellwig [EMAIL PROTECTED] Signed-off-by: Josh Boyer [EMAIL PROTECTED] --- diff --git

Re: [PATCH] igb: add IGB_DCA instead of selecting INTEL_IOATDMA

2008-10-21 Thread Jeff Garzik
Jeff Kirsher wrote: Add a bool IGB_DCA defined to y if IGB and DCA are enabled, but IGB isn't y while DCA=m. And thus remove the need to select INTEL_IOATDMA when IGB is enabled, so that non-x86 architectures can build the igb driver. Based on work/patch from Brice Goglin [EMAIL PROTECTED]

Re: [PATCH] ibm_newemac: Fix new MAL feature handling

2008-10-20 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: On Thu, 2008-10-16 at 10:38 -0400, Josh Boyer wrote: On Thu, Oct 16, 2008 at 03:56:50PM +1100, Benjamin Herrenschmidt wrote: drivers/net/ibm_newemac/mal.c: In function 'mal_txeob': drivers/net/ibm_newemac/mal.c:284: error: implicit declaration of function

Re: [PATCH] ehea: Fix memory hotplug support

2008-10-16 Thread Jeff Garzik
Hannes Hering wrote: This patch implements the memory notifier to update the busmap instantly instead of rebuilding the whole map. This is necessary because walk_memory_resource provides different information than required during memory hotplug. Signed-off-by: Hannes Hering [EMAIL PROTECTED]

Re: [PATCH] pata_platform struct resource signness fix

2008-09-28 Thread Jeff Garzik
Anton Vorontsov wrote: On Thu, Sep 25, 2008 at 06:40:59PM +0800, Li Yang wrote: On Thu, Sep 25, 2008 at 4:54 PM, Wang Jian [EMAIL PROTECTED] wrote: The alternative fix can be. This one is better as 0 is defined as 'invalid irq' for all architectures. Added linux-ide and Anton to cc. Thanks

Re: [PATCH 1/2] ehea: fix phyp debugging typo

2008-09-13 Thread Jeff Garzik
Sebastien Dugue wrote: Fix typo in ehea_h_query_ehea() which prevents building when DEBUG is on. Signed-off-by: Sebastien Dugue [EMAIL PROTECTED] --- drivers/net/ehea/ehea_phyp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/ehea/ehea_phyp.c

Re: [PATCH 2/2] ehea: fix mutex and spinlock use

2008-09-13 Thread Jeff Garzik
Sebastien Dugue wrote: Looks like to me that the ehea_fw_handles.lock mutex and the ehea_bcmc_regs.lock spinlock are taken much longer than necessary and could as well be pushed inside the functions that need them (ehea_update_firmware_handles() and ehea_update_bcmc_registrations()) rather

Re: [PATCH 1/3] ibm_newemac: Allow the no flow control EMAC feature to work

2008-09-13 Thread Jeff Garzik
Josh Boyer wrote: Some PowerPC 40x chips have errata that force us not to use the integrated flow control. We have the feature defined, but it currently can't be used because it is never added to EMAC_FTRS_POSSIBLE. This adds a Kconfig option for affected platforms to select and puts the

Re: [PATCH] ibm_newemac: Add support for GPCS, SGMII and M88E1112 PHY

2008-09-13 Thread Jeff Garzik
Victor Gallardo wrote: This patch adds GPCS, SGMII and M88E1112 PHY support for the AMCC PPC460GT/EX processors. Signed-off-by: Victor Gallardo [EMAIL PROTECTED] --- drivers/net/ibm_newemac/core.c | 40 +++ drivers/net/ibm_newemac/core.h |3 +

Re: [PATCH 1/2] ehea: Fix DLPAR memory handling

2008-09-13 Thread Jeff Garzik
Hannes Hering wrote: The ehea busmap must be allocated only once in the first of many calls of the ehea_create_busmap_callback. Signed-off-by: Hannes Hering [EMAIL PROTECTED] --- diff -Nurp -X dontdiff linux-2.6.27-rc5/drivers/net/ehea/ehea_qmr.c patched_kernel/drivers/net/ehea/ehea_qmr.c ---

Re: [PATCH 2/2] ehea: Enable DLPAR memory remove

2008-09-13 Thread Jeff Garzik
Hannes Hering wrote: This patch adds the capability flag to the capability list for dynamic LPAR memory remove to enable this feature. Signed-off-by: Hannes Hering [EMAIL PROTECTED] --- diff -Nurp -X dontdiff linux-2.6.27-rc5/drivers/net/ehea/ehea.h patched_kernel/drivers/net/ehea/ehea.h ---

Re: [PATCH] ibm_newemac: MAL[12]_IER_EVENTS definition: 2x *_OTE - *_DE

2008-09-03 Thread Jeff Garzik
roel kluin wrote: MAL[12]_IER_EVENTS definitions have MAL_IER_OTE twice but lack MAL_IER_DE Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- drivers/net/ibm_newemac/mal.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ibm_newemac/mal.h

Re: [PATCH] ibm_newemac: Don't call dev_mc_add() before device is registered

2008-08-27 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: We must not call dev_mc_add() from within our HW configure which happens before we initialize and register the netdev. Do it in open() instead. Thanks to Sebastian Siewior for tracking it down. Signed-off-by: Benjamin Herrenschmidt [EMAIL PROTECTED] --- This

Re: [PATCH] gianfar: Call gfar_halt_nodisable() from gfar_halt().

2008-08-14 Thread Jeff Garzik
Scott Wood wrote: gfar_halt() was factored out into halting and disabling by commit d87eb12785c14de1586e3bad86ca2c0991300339, as the suspend() method only wants to do the former. However, the call to gfar_halt_nodisable() from gfar_halt() apparently got lost during the patch respin process.

Re: [PATCH] net/fs_enet: remove redundant messages for performance

2008-08-07 Thread Jeff Garzik
Li Yang wrote: Currently when we do a packet flood to the Ethernet port, the console reports error every time when a packet is dropped. This is too redundant and cost performance. Remove message for this type of event. Signed-off-by: Li Yang [EMAIL PROTECTED] ---

Re: [PATCH 2/3] gianfar: Magic Packet and suspend/resume support.

2008-08-07 Thread Jeff Garzik
Scott Wood wrote: Signed-off-by: Scott Wood [EMAIL PROTECTED] --- Documentation/powerpc/booting-without-of.txt |5 +- arch/powerpc/sysdev/fsl_soc.c|3 + drivers/net/gianfar.c| 118 +- drivers/net/gianfar.h

Re: [PATCH] powerpc/ibmveth: fix multiple errors with dma_mapping_error conversion

2008-07-30 Thread Jeff Garzik
Stephen Rothwell wrote: The addition of an argument to dma_mapping_error() in commit 8d8bb39b9eba32dd70e87fd5ad5c5dd4ba118e06 dma-mapping: add the device argument to dma_mapping_error() left a bit of fallout: drivers/net/ibmveth.c:263: error: too few arguments to function 'dma_mapping_error'

Re: [PATCH] fs_enet: Remove unused fields in the fs_mii_bb_platform_info structure.

2008-07-22 Thread Jeff Garzik
Laurent Pinchart wrote: The mdio_port, mdio_bit, mdc_port and mdc_bit fields in the fs_mii_bb_platform_info structure are left-overs from the move to the Phy Abstraction Layer subsystem. They are not used anymore and can be safely removed. Signed-off-by: Laurent Pinchart [EMAIL PROTECTED] ---

Re: [PATCH 2/2] fs_enet: MDIO on GPIO support

2008-07-18 Thread Jeff Garzik
Kumar Gala wrote: On Jul 18, 2008, at 4:26 AM, Laurent Pinchart wrote: On Thursday 26 June 2008, Vitaly Bordug wrote: On Thu, 26 Jun 2008 13:21:23 +0200 Laurent Pinchart [EMAIL PROTECTED] wrote: There should be no dependencies. When the OF GPIO support is not selected linux/of_gpio.h will

Re: [PATCH v2] ibm_newemac: Add MII mode support to the EMAC RGMII bridge.

2008-07-10 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: On Tue, 2008-07-08 at 08:03 -0700, Grant Erickson wrote: This patch adds support to the RGMII handler in the EMAC driver for the MII PHY mode such that device tree entries of the form `phy-mode = mii;' are recognized and handled appropriately. While logically, in

Re: [PATCH 1/3] ehea: fix might sleep problem

2008-07-04 Thread Jeff Garzik
Jan-Bernd Themann wrote: A mutex has to be replaced by spinlocks as it can be called from a context which does not allow sleeping. The kzalloc flag GFP_KERNEL has to be replaced by GFP_ATOMIC for the same reason. Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED] applied 1-3 to 2.6.26

Re: [PATCH v3] ibm_newemac: Fixes kernel crashes when speed of cable connected changes

2008-07-04 Thread Jeff Garzik
Stefan Roese wrote: From: Sathya Narayanan [EMAIL PROTECTED] The descriptor pointers were not initialized to NIL values, so it was poiniting to some random addresses which was completely invalid. This fix takes care of initializing the descriptor to NIL values and clearing the valid descriptors

Re: [PATCH v2] ibm_newemac: Fixes entry of short packets

2008-07-04 Thread Jeff Garzik
Stefan Roese wrote: From: Sathya Narayanan [EMAIL PROTECTED] Short packets has to be discarded by the driver. So this patch addresses the issue of discarding the short packets of size lesser then ethernet header size. Signed-off-by: Sathya Narayanan [EMAIL PROTECTED] Signed-off-by: Stefan

Re: [PATCHv2] fs_enet: restore promiscuous and multicast settings in restart()

2008-07-04 Thread Jeff Garzik
Laurent Pinchart wrote: The restart() function is called when the link state changes and resets multicast and promiscuous settings. This patch restores those settings at the end of restart(). Signed-off-by: Laurent Pinchart [EMAIL PROTECTED] --- drivers/net/fs_enet/mac-fcc.c |3 +++ 1

Re: [PATCH 01/12] pata_mpc52xx: use linux/of_platform.h instead of asm

2008-06-27 Thread Jeff Garzik
Stephen Rothwell wrote: Signed-off-by: Stephen Rothwell [EMAIL PROTECTED] --- drivers/ata/pata_mpc52xx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) I am not sure who wants to take this. diff --git a/drivers/ata/pata_mpc52xx.c b/drivers/ata/pata_mpc52xx.c index

Re: [PATCH 06/12] net: use linux/of_{device,platform}.h instead of asm

2008-06-26 Thread Jeff Garzik
Stephen Rothwell wrote: Signed-off-by: Stephen Rothwell [EMAIL PROTECTED] --- drivers/net/fs_enet/fs_enet-main.c |2 +- drivers/net/fs_enet/mac-scc.c |2 +- drivers/net/fs_enet/mii-fec.c |2 +- drivers/net/ibm_newemac/core.h |2 +- drivers/net/ucc_geth.c

Re: [PATCH V2] ibm_newemac: Fixes kernel crashes when speed of cable connected changes

2008-06-26 Thread Jeff Garzik
Stefan Roese wrote: From: Sathya Narayanan [EMAIL PROTECTED] The descriptor pointers were not initialized to NIL values, so it was poiniting to some random addresses which was completely invalid. This fix takes care of initializing the descriptor to NIL values and clearing the valid descriptors

Re: [PATCH 2/2] fs_enet: MDIO on GPIO support

2008-06-18 Thread Jeff Garzik
Laurent Pinchart wrote: Hi Scott, On Monday 16 June 2008 18:34, Scott Wood wrote: On Mon, Jun 16, 2008 at 10:57:02AM +0200, Laurent Pinchart wrote: On Monday 26 May 2008 11:53, Laurent Pinchart wrote: Port the fs_enet driver to support the MDIO on GPIO driver for PHY access in addition to

Re: [PATCH] ibm_newemac: select CRC32 in Kconfig

2008-06-17 Thread Jeff Garzik
Josh Boyer wrote: The ibm_newemac driver requires ether_crc to be defined. Apparently it is possible to generate a .config without CONFIG_CRC32 set which causes the following link errors if IBM_NEW_EMAC is selected: LD .tmp_vmlinux1 drivers/built-in.o: In function `emac_hash_mc':

Re: [PATCH] ibm_emac: Remove the ibm_emac driver

2008-06-17 Thread Jeff Garzik
Josh Boyer wrote: The arch/ppc sub-tree has been removed in the powerpc git tree. The old ibm_emac driver is no longer used by anything as a result of this. This removes it, leaving the ibm_newemac driver as the proper driver to use for PowerPC boards with the EMAC hardware. Signed-off-by:

Re: [PATCH 1/2] fs_enet: fix checkpatch.pl problems

2008-06-17 Thread Jeff Garzik
John Rigby wrote: Fixed all errors and warnings that checkpatch.pl reports if this was a new submission. Also changed instances of fec_t to struct fec in mac-fec.c and mii-fec.c. This is in preparation of adding MPC5121 support. Signed-off-by: John Rigby [EMAIL PROTECTED] ---

Re: [PATCH 10/19] [repost] powerpc: move get_longbusy_msecs out of ehca/ehea

2008-06-13 Thread Jeff Garzik
Brian King wrote: Jeff, Regarding the patches Rob just posted here, we'd like to just take them through the powerpc tree with your sign off since they are part of a Power platform feature we are enabling. Thanks, Brian Robert Jennings wrote: From: Robert Jennings [EMAIL PROTECTED] In

Re: [PATCH][2.6.26] ehea: set mac address fix

2008-06-10 Thread Jeff Garzik
Jan-Bernd Themann wrote: eHEA has to call firmware functions in order to change the mac address of a logical port. This patch checks if the logical port is up when calling the register / deregister mac address calls. If the port is down these firmware calls would fail and are therefore not

Re: [PATCH] [POWERPC] 85xx: MPC85xx MDS - Unconditionally select PHYLIB for board fixups

2008-06-06 Thread Jeff Garzik
Kumar Gala wrote: The MPC85xx MDS board requires some board level tweaks of the PHYs that either the eTSEC (gianfar) or UCC ethernet controllers are connected to. Its possible to build the phylib as a module, however this breaks the board level fix ups because phy_read and phy_write are not

Re: [PATCH 2/3] [2.6.26] ehea: Add dependency to Kconfig

2008-06-03 Thread Jeff Garzik
Badari Pulavarty wrote: It would be nice to get this resolved for 2.6.26 -- this new dependency causes working 2.6.25 configs to effectively fail (by deselecting CONFIG_EHEA during make oldconfig). When everybody else is happy, I'm happy :) ___

Re: [PATCH 2/2] ehea: remove dependency on MEMORY_HOTPLUG

2008-06-03 Thread Jeff Garzik
Nathan Lynch wrote: Now that walk_memory_resource() is available regardless of MEMORY_HOTPLUG's setting, this dependency is not needed. Signed-off-by: Nathan Lynch [EMAIL PROTECTED] --- drivers/net/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [PATCH] phylib: Don't allow core of phylib to build as a module

2008-06-02 Thread Jeff Garzik
Kumar Gala wrote: The core portions of the phylib aren't capable of being used as a module. This isn't really any different than something like i2c in that the bus driver and core need to be built into the kernel. Signed-off-by: Kumar Gala [EMAIL PROTECTED] --- Jeff, please consider this for

Re: [PATCH] phylib: Don't allow core of phylib to build as a module

2008-06-02 Thread Jeff Garzik
Kumar Gala wrote: On Jun 2, 2008, at 11:03 AM, Jeff Garzik wrote: Kumar Gala wrote: The core portions of the phylib aren't capable of being used as a module. This isn't really any different than something like i2c in that the bus driver and core need to be built into the kernel. Signed-off

Re: [PATCH] phylib: Don't allow core of phylib to build as a module

2008-06-02 Thread Jeff Garzik
Kumar Gala wrote: On Jun 2, 2008, at 11:39 AM, Jeff Garzik wrote: Kumar Gala wrote: On Jun 2, 2008, at 11:03 AM, Jeff Garzik wrote: Kumar Gala wrote: The core portions of the phylib aren't capable of being used as a module. This isn't really any different than something like i2c

Re: [PATCH] phylib: Don't allow core of phylib to build as a module

2008-06-02 Thread Jeff Garzik
Andy Fleming wrote: I'm partial to the select-it-if-you-need-it paradigm. AFAICS this can all be solved by the platform Kconfig ensuring that phylib=y Jeff ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org

Re: [PATCH] Add port multiplier (PMP) support in sata_fsl driver

2008-05-30 Thread Jeff Garzik
Kumar Gala wrote: From: Ashish Kalra [EMAIL PROTECTED] PMP support for sata_fsl driver. Signed-off-by: Ashish Kalra [EMAIL PROTECTED] --- Jeff, The following commit (4c9bf4e799ce06a7378f1196587084802a414c03): libata: replace tf_read with qc_fill_rtf for non-SFF drivers Broke the sata_fsl.c

Re: [PATCH 1/2] net: OpenFirmware GPIO based MDIO bitbang driver

2008-05-30 Thread Jeff Garzik
Laurent Pinchart wrote: This patch adds an MDIO bitbang driver that uses the GPIO library and its OF bindings to access the bus I/Os. Signed-off-by: Laurent Pinchart [EMAIL PROTECTED] --- Documentation/powerpc/booting-without-of.txt | 21 +++ drivers/net/phy/Kconfig |

Re: [PATCH 1/1] ehea: Fix use after free on reboot

2008-05-22 Thread Jeff Garzik
Brian King wrote: Fixes the following use after free oops: ehea: Reboot: freeing all eHEA resources Unable to handle kernel paging request for data at address 0x6b6b6b6b6b6b6c5b Faulting instruction address: 0xd0354488 cpu 0x0: Vector: 300 (Data Access) at [c0002ec6f310] pc:

Re: [PATCH 4/6] drivers/net/fs_enet: remove null pointer dereference

2008-05-22 Thread Jeff Garzik
Julia Lawall wrote: From: Julia Lawall [EMAIL PROTECTED] The following code appears in the function fs_init_instance in the file drivers/net/fs_enet/fs_enet-main.c. if (fep-ops == NULL) { printk(KERN_ERR DRV_MODULE_NAME : %s No matching ops found

Re: [PATCH 1/3] [2.6.26] memory: Introduce exports for memory notifiers

2008-05-12 Thread Jeff Garzik
Hannes Hering wrote: This patch introduces two exports to allow modules to use memory notifiers. Signed-off-by: Hannes Hering [EMAIL PROTECTED] --- diff --git a/drivers/base/memory.c b/drivers/base/memory.c index 8ce6de5..937e825 100644 --- a/drivers/base/memory.c +++ b/drivers/base/memory.c

Re: [PATCH 1/3] [NET] uli526x: initialize the hardware prior to requesting interrupts

2008-05-06 Thread Jeff Garzik
Anton Vorontsov wrote: The firmware on MPC8610HPCD boards enables ULI ethernet and leaves it in some funky state before booting Linux. For drivers, it's always good idea to (re)initialize the hardware prior to requesting interrupts. This patch fixes the following oops: Oops: Kernel access of

Re: [PATCH] Delete unused fec_8xx net driver

2008-05-06 Thread Jeff Garzik
Becky Bruce wrote: This driver has been superseded by fs_enet and is no longer in use. Signed-off-by: Becky Bruce [EMAIL PROTECTED] I cannot make an informed judgement on this. ACK, and pass through platform tree, if all platform peeps are happy.

Re: [PATCH] devres: support addresses greater than an unsigned long via dev_ioremap

2008-04-29 Thread Jeff Garzik
Tejun Heo wrote: Kumar Gala wrote: Use a resource_size_t instead of unsigned long since some arch's are capable of having ioremap deal with addresses greater than the size of a unsigned long. Signed-off-by: Kumar Gala [EMAIL PROTECTED] Acked-by: Tejun Heo [EMAIL PROTECTED] Fine with me,

Re: [PATCH 1/6] ibm_newemac: Fix problem with jumbo frame support and EMAC V4.patch

2008-04-25 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: From: Stefan Roese [EMAIL PROTECTED] This fixes the jumbo frame support on EMAC V4 systems. Now the correct bit is set depending on the EMAC version configured. Tested on Kilauea (405EX) and Canyonlands (460EX). Signed-off-by: Stefan Roese [EMAIL PROTECTED]

[PATCH 04/15] [PPC] minor irq handler cleanups

2008-04-18 Thread Jeff Garzik
is to prepare for the patchset in jgarzik/misc-2.6.git#irq-remove, that explores removal of the never-used 'irq' argument in each interrupt handler. Signed-off-by: Jeff Garzik [EMAIL PROTECTED] --- arch/ppc/8xx_io/fec.c|3 +-- arch/ppc/platforms/sbc82xx.c |4 +++- 2 files changed, 4

Re: [PATCH] natsemi: fix MMIO for PPC 44x platforms

2008-04-16 Thread Jeff Garzik
Sergei Shtylyov wrote: The driver stores the PCI resource address into 'unsigned long' variable before calling ioremap() on it. This warrants a kernel oops when the registers are accessed on PPC 44x platforms which (being 32-bit) have PCI memory space mapped beyond 4 GB. The arch/ppc/ kernel

Re: [PATCH] natsemi: fix for PPC 44x platforms

2008-04-12 Thread Jeff Garzik
Sergei Shtylyov wrote: The driver stores the the PCI resource address into 'unsigned long' variable before calling ioremap() on it. This warrants kernel oops when the registers are accessed on PPC 44x platforms which (being 32-bit) have PCI memory space mapped beyond 4 GB. The arch/ppc/ kernel

Re: [PATCH] ehea: Fix DLPAR memory add support

2008-04-12 Thread Jeff Garzik
Thomas Klein wrote: This patch fixes two weaknesses in send/receive packet handling which may lead to kernel panics during DLPAR memory add operations. Signed-off-by: Thomas Klein [EMAIL PROTECTED] applied ___ Linuxppc-dev mailing list

Re: [PATCH 1/2] ibm_newemac: PowerPC 440GX EMAC PHY clock workaround

2008-04-12 Thread Jeff Garzik
Josh Boyer wrote: On Fri, 28 Mar 2008 22:18:25 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: Valentine Barshak wrote: The PowerPC 440GX Taishan board fails to reset EMAC3 (reset timeout error) if there's no link. Because of that it fails to find PHY chip. The older ibm_emac driver had

Re: [PATCH] fs_enet: Don't call NAPI functions when NAPI is not used.

2008-04-11 Thread Jeff Garzik
Laurent Pinchart wrote: fs_enet_close() calls napi_disable() unconditionally. This patch skips the call when use_napi isn't set. Signed-off-by: Laurent Pinchart [EMAIL PROTECTED] --- drivers/net/fs_enet/fs_enet-main.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git

Re: [patch] PS3: Fix gelic net module dependency

2008-04-09 Thread Jeff Garzik
' ps3_gelic_net.c:1337: undefined reference to `.ps3_sys_manager_set_wol' CC: Masakazu Mokuno [EMAIL PROTECTED] CC: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Geoff Levand [EMAIL PROTECTED] --- Hi Paul, This fixes an error introduced in my 2.6.26 WOL patches now queued in your powerpc tree. Please apply

Re: [PATCH 3/3] sata_fsl: reduce compatibility to fsl,pq-sata

2008-03-28 Thread Jeff Garzik
Kumar Gala wrote: On Mar 28, 2008, at 10:51 AM, Kim Phillips wrote: as prescribed in Documentation/powerpc/booting-without-of.txt. Signed-off-by: Kim Phillips [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] --- Jeff, I'll take this via the powerpc tree if you don't have any issue. ACK

Re: [patch 6/6] PS3: Gelic network driver Wake-on-LAN support

2008-03-28 Thread Jeff Garzik
Geoff Levand wrote: From: Masakazu Mokuno [EMAIL PROTECTED] Add Wake-on-LAN support to the PS3 Gelic network driver. Other OS WOL support was introduced in PS3 system firmware 2.20. Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED] Signed-off-by: Geoff Levand [EMAIL PROTECTED] ---

Re: [PATCH] Make pasemi_mac.c depend on PPC_PASEMI to prevent link errors

2008-03-28 Thread Jeff Garzik
Michael Ellerman wrote: drivers/net/pasemi_mac.c is enabled by CONFIG_PASEMI_MAC, which depends on PPC64 PCI. However pasemi_mac.c uses several routines that are only built when PPC_PASEMI is selected. This can lead to an unbuildable config: ERROR: .pasemi_dma_start_chan

  1   2   3   >