From: Stefan Roscher <[EMAIL PROTECTED]>
The new Small QP code had a few bugs that would also trigger for non-Small
QPs. Fix them.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_qp.c | 10 ++
drivers/infiniband/hw/ehca/ipz_pt_fn.c
eview the changes and apply the patches for 2.6.23-rc5 if they are okay.
Regards,
Joachim
--
Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer
IBM Deutschland Entwicklung GmbH -- Dept. 3627 (I/O Firmware Dev. 2)
Schoenaicher Strasse 220 -- 71032 Boeblingen -- Germany
[EMAIL PROTECTED] (Linas Vepstas) wrote on 30.08.2007 23:28:16:
> On Thu, Aug 30, 2007 at 04:00:56PM +0200, Joachim Fenkes wrote:
> >
> > Plus, I rather like using
> > the full_name since it also contains a descriptive name as opposed to
> > being just nondescript
Nathan Lynch <[EMAIL PROTECTED]> wrote on 29.08.2007 20:12:32:
> > Previously, ibmebus derived a device's bus_id from its location code.
The
> > location code is not guaranteed to be unique, so we might get bus_id
> > collisions if two devices share the same location code. The OFDT
full_name,
>
Previously, ibmebus derived a device's bus_id from its location code. The
location code is not guaranteed to be unique, so we might get bus_id
collisions if two devices share the same location code. The OFDT full_name,
however, is unique, so we use that instead.
Signed-off-by: Joachim F
> kmalloc() returns a void pointer so there is absolutely no need to
> cast it in ibmebus_chomp().
>
> Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
Acked-By: Joachim Fenkes <[EMAIL PROTECTED]>
___
Linuxppc-dev mailing list
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
This patch should apply cleanly on top of Stefan's recent patchset. Please
review and apply for 2.6.23. Thanks.
drivers/infiniband/hw/ehca/ehca_hca.c | 10 +++---
1 files changed, 7 insertions(+), 3 deletions(-)
diff --gi
Roland Dreier <[EMAIL PROTECTED]> wrote on 17.07.2007 05:50:13:
> > > Why the module parameter? Is there any reason a user would want to
> > > turn this off? Or conversely, why is it off by default?
> >
> > We're pretty confident this new feature works, but as with all new
and
> > possib
Roland Dreier <[EMAIL PROTECTED]> wrote on 16.07.2007 19:37:09:
> > If enabled via the mr_largepage module parameter,
>
> Why the module parameter? Is there any reason a user would want to
> turn this off? Or conversely, why is it off by default?
We're pretty confident this new feature works
Roland Dreier <[EMAIL PROTECTED]> wrote on 16.07.2007 19:14:03:
> applied, but as a further cleanup it seems that ehca2ib_return_code()
> should be moved into a .c file and moved out of line -- I think it
> would probably shrink the compiled code quite a bit, and as far as I
> can see it is never
Roland Dreier <[EMAIL PROTECTED]> wrote on 16.07.2007 18:04:26:
> It seems not quite right to me for the driver to advertise nr_eqs
> completion vectors, but then if round-robin is turned on to ignore the
> consumer's decision about which vector to use.
The round-robin feature was primarily meant
> > [09/10] fixes a lot of checkpatch.pl warnings
>
> Are these warnings from earlier patches in the series, or problems
> that already existed in the code? If they are coming from other
> patches in the series, please just fix the earlier patches before I
> merge them.
Nam did a diff -Nurp emp
>= 16M, 16M pages are used, for example.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_classes.h | 10 +
drivers/infiniband/hw/ehca/ehca_main.c| 17 ++-
drivers/infiniband/hw/ehca/ehca_mrmw.c| 371 -
driver
From: Hoang-Nam Nguyen <[EMAIL PROTECTED]>
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_av.c |2 +-
drivers/infiniband/hw/ehca/ehca_classes.h |4 +-
drivers/infiniband/hw/ehca/ehca_classes_pSer
From: Hoang-Nam Nguyen <[EMAIL PROTECTED]>
Split ehca_set_pagebuf() into three functions depending on MR type
(phys/user/fast) and remove superfluous ehca_set_pagebuf_1().
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_m
From: Hoang-Nam Nguyen <[EMAIL PROTECTED]>
- Rename struct ehca_mr fields to clearly distinguish between kernel and HW
page size
- Sort struct ehca_mr_pginfo into a common part and a union containing
specific fields for physical, user and fast MR
Signed-off-by: Joachim Fenkes &
From: Hoang-Nam Nguyen <[EMAIL PROTECTED]>
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_mrmw.c | 47 ---
1 files changed, 24 insertions(+), 23 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_mrmw.
From: Hoang-Nam Nguyen <[EMAIL PROTECTED]>
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_mrmw.c | 19 +++
1 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_mrmw.c
b/drivers/infini
From: Hoang-Nam Nguyen <[EMAIL PROTECTED]>
Instead of one error mapping function for each potential error source in
ehca_mrmw.c, use a centralized function that handles all cases, saving a
three-figure line count.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infini
Autodetection was missing a few HW revisions, causing certain eHCA1
revisions to be treated like eHCA2. Fixed.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_main.c | 29 +
1 files changed, 17 insertions(+), 12 del
From: Hoang-Nam Nguyen <[EMAIL PROTECTED]>
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_mrmw.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_mrmw.c
b/drivers/infiniband/hw/ehca/ehca_
st_eqs module parameter is supplied, using a round-robin scheme.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_classes.h | 13 +++-
drivers/infiniband/hw/ehca/ehca_cq.c | 16 +++-
drivers/infiniband/hw/ehca/ehca_eq.c
y are okay.
Regards,
Joachim
--
Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer
IBM Deutschland Entwicklung GmbH -- Dept. 3627 (I/O Firmware Dev. 2)
Schoenaicher Strasse 220 -- 71032 Boeblingen -- Germany
eMail: [EMAIL
Hi all,
while the idr discussion is still hot, there's another thing that caught my
eye recently:
As to my reading of idr.h, I have two choices of initializing a global idr:
a) static struct idr foo; /* ... */ idr_init(&foo);
b) static DEFINE_IDR(foo);
idr_init(), when called for the first tim
Roland Dreier <[EMAIL PROTECTED]> wrote on 10.07.2007 00:11:42:
> thanks, I applied these for 2.6.23 and fixed a bunch of minor things
> that scripts/checkpatch.pl complained about (since I was in a mood to
> do mindless things).
Thanks! Both for the quick merge and for the fixes!
> In the futur
Roland Dreier <[EMAIL PROTECTED]> wrote on 09.07.2007 23:35:31:
> Out of curiousity, does this mean that a GRH will be sent on all UD
> messages (for non-LL QPs)?
No - the bit instructs the hardware to fetch the GRH parts of the QP
context.
The GRH will only be used if the WQE says so.
Joachim
From: Hoang-Nam Nguyen <[EMAIL PROTECTED]>
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_reqs.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_reqs.c
b/drivers/infiniband/hw/ehca
When firmware reports a nondisruptive port configuration change event,
previous versions of the eHCA driver didn't forward the event to consumers
like IPoIB. Add code that determines the type of configuration change by
comparing old and new port attributes and reports it.
Signed-off-by: Jo
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_reqs.c | 11 ---
1 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_reqs.c
b/drivers/infiniband/hw/ehca/ehca_reqs.c
index 73f0c06..fd3ba22 100644
This eliminates lock contention among IRQs as well as the need to disable
IRQs around idr_find, because there are no IRQ writers.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_classes.h |4 ++--
drivers/infiniband/hw/ehca/ehca_cq.c
- ehca_cq.nr_events is made an atomic_t, eliminating a lot of locking.
- The CQ is removed from the CQ idr first now to make sure no more
completions are scheduled on that CQ. The "wait for all completions to
end" code becomes much simpler this way.
Signed-off-by: Joachim Fenk
- Renamed all spinlock flags to "flags", matching the vast majority of kernel
code.
- Moved hcall_lock into the only module it's used in.
- Replaced spin_lock_init() and friends with static initializers for
global variables.
Signed-off-by: Joachim Fenkes <[EMAIL PROTEC
From: Hoang-Nam Nguyen <[EMAIL PROTECTED]>
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_qp.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_qp.c
b/drivers/infiniband/hw/ehca/ehc
From: Stefan Roscher <[EMAIL PROTECTED]>
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_qp.c | 11 +++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_qp.c
b/drivers/infiniband/hw/eh
From: Stefan Roscher <[EMAIL PROTECTED]>
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_qp.c | 84 +++---
1 files changed, 57 insertions(+), 27 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_qp.
Support SRQs on eHCA2. Since an SRQ is a QP for eHCA2, a lot of code
(structures, create, destroy, post_recv) can be shared between QP and SRQ.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_classes.h | 26 +-
drivers/infiniband/h
igned-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_classes.h | 46 +-
drivers/infiniband/hw/ehca/ehca_qp.c | 254 +
drivers/infiniband/hw/ehca/hcp_if.c | 35 ++---
drivers/infiniband/hw/ehca/hcp_if.h |1
: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_av.c |6 ++-
drivers/infiniband/hw/ehca/ehca_classes.h |2 +
drivers/infiniband/hw/ehca/ehca_hca.c | 27 +++-
drivers/infiniband/hw/ehca/ehca_main.c| 62 ++---
d
From: Hoang-Nam Nguyen <[EMAIL PROTECTED]>
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_main.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_main.c
b/drivers/infiniband/hw/ehca/ehca_
SM LID etc. changes
[13/13] adds a slight latency improvement
The patches should apply cleanly, in order, against Roland's git. Please
review the changes and apply the patches for 2.6.23 if they are okay.
Regards,
Joachim
--
Joachim Fenkes -- eHCA Linux Driver Developer and Hardware
101 - 140 of 140 matches
Mail list logo
