Re: [PATCH net-next] ibmveth: v1 calculate correct gso_size and set gso_type

On Thu, Nov 3, 2016 at 8:40 AM, Brian King wrote: > On 10/27/2016 10:26 AM, Eric Dumazet wrote: >> On Wed, 2016-10-26 at 11:09 +1100, Jon Maxwell wrote: >>> We recently encountered a bug where a few customers using ibmveth on the >>> same LPAR hit an issue where a TCP

Re: [PATCH net-next] ibmveth: v1 calculate correct gso_size and set gso_type

On Fri, Oct 28, 2016 at 5:08 AM, Eric Dumazet wrote: > On Thu, 2016-10-27 at 12:54 -0500, Thomas Falcon wrote: >> On 10/27/2016 10:26 AM, Eric Dumazet wrote: >> > On Wed, 2016-10-26 at 11:09 +1100, Jon Maxwell wrote: >> >> We recently encountered a bug where a few

Re: [PATCH net-next] ibmveth: calculate correct gso_size and set gso_type

>> + u16 hdr_len = ETH_HLEN + sizeof(struct tcphdr); > Compiler may optmize this, but maybe move hdr_len to [*] ?> There are other places in the stack where a u16 is used for the same purpose. So I'll rather stick to that convention. I'll make the other formatting changes you suggested and