Re: [PATCH] powerpc: Fix fatal warnings flag for LLVM's integrated assembler

2024-04-05 Thread Justin Stitt
n version of the flag, '--fatal-warnings', which > works with both the GNU assembler and LLVM's integrated assembler. > > Fixes: 608d4a5ca563 ("powerpc: Error on assembly warnings") > Signed-off-by: Nathan Chancellor Nice catch. Reviewed-by: Justin Stitt > --- >

[PATCH] scsi: ibmvscsi: replace deprecated strncpy with strscpy

2023-10-30 Thread Justin Stitt
g. Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1] Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2] Link: https://github.com/KSPP/linux/issues/90 Cc: linux-harden...@vger.kernel.org Signed-off-by: Justin Stitt

[PATCH] scsi: ibmvfc: replace deprecated strncpy with strscpy

2023-10-30 Thread Justin Stitt
Link: https://github.com/KSPP/linux/issues/90 Cc: linux-harden...@vger.kernel.org Signed-off-by: Justin Stitt --- Note: build-tested only. Found with: $ rg "strncpy\(" --- drivers/scsi/ibmvscsi/ibmvfc.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a

[PATCH] ibmvnic: replace deprecated strncpy with strscpy

2023-10-09 Thread Justin Stitt
NUL-padding. Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1] Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2] Link: https://github.com/KSPP/linux/issues/90 Cc: linux-harden...@vger.kernel.org Signed-off-by: Jus

[PATCH] i2c: replace deprecated strncpy

2023-09-20 Thread Justin Stitt
linux-harden...@vger.kernel.org Signed-off-by: Justin Stitt --- drivers/i2c/busses/i2c-powermac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-powermac.c b/drivers/i2c/busses/i2c-powermac.c index 4996a628fdae..8e57ebe595be 100644 --- a/drivers/i2c/busses/i2c-powe

[PATCH v2] hwmon: (ibmpowernv) refactor deprecated strncpy

2023-09-18 Thread Justin Stitt
/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1] Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2] Link: https://github.com/KSPP/linux/issues/90 Cc: linux-harden...@vger.kernel.org Signed-off-by: Justin Stitt --- Changes in v2: - prefer memcpy

[PATCH] hwmon: (ibmpowernv) refactor deprecated strncpy

2023-09-14 Thread Justin Stitt
...@vger.kernel.org Signed-off-by: Justin Stitt --- drivers/hwmon/ibmpowernv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwmon/ibmpowernv.c b/drivers/hwmon/ibmpowernv.c index 594254d6a72d..57d829dbcda6 100644 --- a/drivers/hwmon/ibmpowernv.c +++ b/drivers/hwmon

[PATCH] powerpc/ps3: refactor strncpy usage

2023-08-16 Thread Justin Stitt
the NUL-padding. Link: www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings[1] Link: https://github.com/KSPP/linux/issues/90 Cc: linux-harden...@vger.kernel.org Signed-off-by: Justin Stitt --- Note: This follows up on a previous RFC which can be found here: https

Re: [PATCH RFC 0/3] powerpc/ps3: refactor strncpy usage

2023-08-11 Thread Justin Stitt
On Fri, Aug 11, 2023 at 2:19 PM Justin Stitt wrote: > > Within this RFC-series I want to get some comments on two ideas that I > have for refactoring the current `strncpy` usage in repository.c. > > When looking at `make_first_field` we see a u64 is being used to store >

[PATCH RFC 2/3] powerpc/ps3: refactor strncpy usage attempt 2

2023-08-11 Thread Justin Stitt
should be the same but would love some comments on this. Signed-off-by: Justin Stitt --- Note: I swapped the position of the two methods so as to not have to forward declare `make_field`. This results in a weird diff here. --- arch/powerpc/platforms/ps3/repository.c | 21 + 1

[PATCH RFC 3/3] powerpc/ps3: refactor strncpy usage attempt 2.5

2023-08-11 Thread Justin Stitt
Forward declare `make_field` for a cleaner diff Signed-off-by: Justin Stitt --- arch/powerpc/platforms/ps3/repository.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/arch/powerpc/platforms/ps3/repository.c b/arch/powerpc/platforms/ps3

[PATCH RFC 1/3] powerpc/ps3: refactor strncpy usage attempt 1

2023-08-11 Thread Justin Stitt
This approach simply replicates the implementation of `make_field` which means we drop `strncpy` for `memcpy`. Signed-off-by: Justin Stitt --- arch/powerpc/platforms/ps3/repository.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/platforms/ps3/repository.c

[PATCH RFC 0/3] powerpc/ps3: refactor strncpy usage

2023-08-11 Thread Justin Stitt
? In regards to `strncpy` here, it makes the code needlessly complex imo. Please see my two ideas to change this and let me know if any other approaches are more reasonable. Link: https://github.com/KSPP/linux/issues/90 Signed-off-by: Justin Stitt --- Justin Stitt (3): [RFC] powerpc/ps3: refactor

[PATCH] ASoC: fsl_micfil: refactor deprecated strncpy

2023-07-27 Thread Justin Stitt
-4.8/strscpy.9.en.html [3]: https://elixir.bootlin.com/linux/v6.3/source/lib/string.c#L183 Link: https://github.com/KSPP/linux/issues/90 Signed-off-by: Justin Stitt --- sound/soc/fsl/fsl_micfil.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/fsl_micfil.c b