RE: [PATCH 1/1] arch:hexagon/powerpc: use KSYM_NAME_LEN in array size

2023-05-30 Thread Maninder Singh
or kallsym changes again with seq_buf to take care of length argument. Thanks, Maninder Singh

[PATCH 2/2] powerpc/xmon: use KSYM_NAME_LEN in array size

2023-05-29 Thread Maninder Singh
ith new size. Fixes: 61968dbc2d5d ("kallsyms: increase maximum kernel symbol length to 512") Co-developed-by: Onkarnath Signed-off-by: Onkarnath Signed-off-by: Maninder Singh --- arch/powerpc/xmon/xmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powe

[PATCH 1/2] hexagon/traps.c: use KSYM_NAME_LEN in array size

2023-05-29 Thread Maninder Singh
ith new size. Fixes: 61968dbc2d5d ("kallsyms: increase maximum kernel symbol length to 512") Co-developed-by: Onkarnath Signed-off-by: Onkarnath Signed-off-by: Maninder Singh --- arch/hexagon/kernel/traps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch

RE: [PATCH 1/1] arch:hexagon/powerpc: use KSYM_NAME_LEN in array size

2023-05-29 Thread Maninder Singh
t; and commit '61968dbc2d5d' changed define value to 512, >> So both were missed to update with new size. >> >> Fixes: 61968dbc2d5d ("kallsyms: increase maximum kernel symbol length to >> 512") >> Signed-off-by: Onkarnath >> Signed-off-by: Maninder Singh

[PATCH 1/1] arch:hexagon/powerpc: use KSYM_NAME_LEN in array size

2023-05-28 Thread Maninder Singh
d to update with new size. Fixes: 61968dbc2d5d ("kallsyms: increase maximum kernel symbol length to 512") Signed-off-by: Onkarnath Signed-off-by: Maninder Singh --- arch/hexagon/kernel/traps.c | 2 +- arch/powerpc/xmon/xmon.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions

[PATCH 4/5] kallsyms: pass buffer size argument in *lookup* APIs

2022-05-20 Thread Maninder Singh
Although *lookup* APIs are safe, but better to pass size as an argument rather than using define KSYM_NAME_LEN. Because it can cause issue if called with lesser array size. Co-developed-by: Onkarnath Signed-off-by: Onkarnath Signed-off-by: Maninder Singh --- arch/hexagon/kernel/traps.c

[PATCH 5/5] kallsyms: remove unsed API lookup_symbol_attrs

2022-05-20 Thread Maninder Singh
with commit '7878c231dae0 ("slab: remove /proc/slab_allocators")' lookup_symbol_attrs usage is removed. Thus removing redundant API. Signed-off-by: Maninder Singh --- include/linux/kallsyms.h | 6 -- include/linux/module.h | 6 -- kernel/kallsyms.c

[PATCH 3/5] arch:hexagon/powerpc: use KSYM_NAME_LEN as array size

2022-05-20 Thread Maninder Singh
d to update with new size. Fixes: 61968dbc2d5d("kallsyms: increase maximum kernel symbol length to 512") Signed-off-by: Maninder Singh --- arch/hexagon/kernel/traps.c | 2 +- arch/powerpc/xmon/xmon.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/hexagon

[PATCH 1/5] kallsyms: pass buffer size in sprint_* APIs

2022-05-20 Thread Maninder Singh
As of now sprint_* APIs don't pass buffer size as an argument and use sprintf directly. To replace dangerous sprintf API to scnprintf, buffer size is required in arguments. Co-developed-by: Onkarnath Signed-off-by: Onkarnath Signed-off-by: Maninder Singh --- arch/s390/lib/test_unwind.c

[PATCH 2/5] kallsyms: replace sprintf with scnprintf

2022-05-20 Thread Maninder Singh
replace sprintf API with scnprintf which prevents buffer overflow. Co-developed-by: Onkarnath Signed-off-by: Onkarnath Signed-off-by: Maninder Singh --- kernel/kallsyms.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/kernel/kallsyms.c b/kernel/kallsyms.c

[PATCH 0/5] kallsyms: make kallsym APIs more safe with scnprintf

2022-05-20 Thread Maninder Singh
] el0t_32_sync_handler+0x90/0x140 [ 12.264600] el0t_32_sync+0x190/0x194 Maninder Singh, Onkarnath (5): kallsyms: pass buffer size in sprint_* APIs kallsyms: replace sprintf with scprintf arch:hexagon/powerpc: use KSYM_NAME_LEN as array size kallsyms: pass buffer size argument in *lookup* APIs kallsyms

[PATCH 1/1] cxl/vphb.c: Use phb pointer after NULL check

2015-06-29 Thread Maninder Singh
static Anlaysis detected below error:- (error) Possible null pointer dereference: phb So, Use phb after NULL check. Signed-off-by: Maninder Singh maninder...@samsung.com --- drivers/misc/cxl/vphb.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/misc/cxl/vphb.c