Re: [PATCH 6/6] cxlflash: Update documentation

Acked-by: Manoj N. Kumar On 8/9/2016 6:40 PM, Matthew R. Ochs wrote: Update the block library link in the API documentation. Signed-off-by: Matthew R. Ochs --- Documentation/powerpc/cxlflash.txt | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH 5/6] cxlflash: Remove adapter file descriptor cache

Acked-by: Manoj N. Kumar On 8/9/2016 6:40 PM, Matthew R. Ochs wrote: The adapter file descriptor was previously cached within the kernel for a given context in order to support performing a close on behalf of an application. This is no longer needed as applications

Re: [PATCH 4/6] cxlflash: Transition to application close model

Acked-by: Manoj N. Kumar On 8/9/2016 6:39 PM, Matthew R. Ochs wrote: Caching the adapter file descriptor and performing a close on behalf of an application is a poor design. This is due to the fact that once a file descriptor in installed, it is free to be altered

Re: [PATCH 3/6] cxlflash: Add kref to context

Acked-by: Manoj N. Kumar On 8/9/2016 6:39 PM, Matthew R. Ochs wrote: Currently, context user references are tracked via the list of LUNs that have attached to the context. While convenient, this is not intuitive without a deep study of the code and is inconsistent

Re: [PATCH 2/6] cxlflash: Cache owning adapter within context

Acked-by: Manoj N. Kumar On 8/9/2016 6:39 PM, Matthew R. Ochs wrote: The context removal routine requires access to the owning adapter structure to reset the context within the AFU as part of the tear down sequence. In order to support kref adoption, the owning

Re: [PATCH 1/6] cxlflash: Avoid mutex when destroying context

Acked-by: Manoj N. Kumar On 8/9/2016 6:39 PM, Matthew R. Ochs wrote: Context information structures are protected by a mutex that is held when accessing/manipulating the context. When the code that manages these structures was authored, a decision was made to include

Re: [PATCH 3/3] cxlflash: Shutdown notify support for CXL Flash cards

On 6/15/2016 6:49 PM, Uma Krishnan wrote: Some CXL Flash cards need notification of device shutdown in order to flush pending I/Os. A PCI notification hook for shutdown has been added where the driver notifies the card and returns. When the device is removed in the PCI remove path, notification

Re: [PATCH 2/3] cxlflash: Add device dependent flags

On 6/15/2016 6:49 PM, Uma Krishnan wrote: Device dependent flags are needed to support functions that are specific to a particular device. Acked-by: Manoj N. Kumar ___ Linuxppc-dev mailing list

Re: [PATCH] cxl: Increase timeout for detection of AFU mmio hang

Tested-by: Manoj Kumar <ma...@linux.vnet.ibm.com> On 4/19/2016 11:34 AM, Frederic Barrat wrote: PSL designers recommend a larger value for the mmio hang pulse, 256 us instead of 1 us. The CAIA architecture states that it needs to be smaller than 1/2 of the RTOS timeout set in t

Re: [PATCH v6 19/20] cxlflash: Use new cxl_pci_read_adapter_vpd() API

Fred: Thanks for submitting this. Including linux-scsi. Acked-by: Manoj N. Kumar - Manoj On 3/4/2016 5:26 AM, Frederic Barrat wrote: To read the adapter VPD, drivers can't rely on pci config APIs, as it wouldn't work on powerVM. cxl introduced a new kernel API

Re: [PATCH v5 14/18] cxl: Support to flash a new image on the adapter from a guest

Fred: Comments below. On 2/25/2016 7:11 AM, Frederic Barrat wrote: Le 24/02/2016 21:03, Manoj Kumar a écrit : From: Christophe Lombard <clomb...@linux.vnet.ibm.com> +#define CXL_DEV_MINORS 13 /* 1 control + 4 AFUs * 3 (dedicated/master/shared) */ Where does this limit of 4 AFU

Re: [PATCH v5 15/18] cxl: Parse device tree and create cxl device(s) at boot

Fred: Thanks for the clarification. Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com> --- Manoj Kumar On 2/25/2016 7:19 AM, Frederic Barrat wrote: Le 24/02/2016 21:15, Manoj Kumar a écrit : On 2/23/2016 10:21 AM, Frederic Barrat wrote: +module_init(cxl_base_init); Is this a r

Re: [PATCH v5 17/18] cxl: Adapter failure handling

Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com> --- Manoj Kumar On 2/23/2016 10:21 AM, Frederic Barrat wrote: From: Christophe Lombard <clomb...@linux.vnet.ibm.com> Check the AFU state whenever an API is called. The hypervisor may issue a reset of the adapter when it det

Re: [PATCH v5 16/18] cxl: Support the cxl kernel API from a guest

Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com> --- Manoj Kumar On 2/23/2016 10:21 AM, Frederic Barrat wrote: Like on bare-metal, the cxl driver creates a virtual PHB and a pci device for the AFU. The configuration space of the device is mapped to the configuration record of t

Re: [PATCH v5 15/18] cxl: Parse device tree and create cxl device(s) at boot

Fred, Christophe: See comment below. --- Manoj Kumar On 2/23/2016 10:21 AM, Frederic Barrat wrote: +module_init(cxl_base_init); Is this a remnant from when there were two modules? Do you really need two module_init() calls (can't one be called from the other)? What is the tear-down portion

Re: [PATCH v5 14/18] cxl: Support to flash a new image on the adapter from a guest

Fred, Christophe: See comments below. -- Manoj Kumar On 2/23/2016 10:21 AM, Frederic Barrat wrote: From: Christophe Lombard <clomb...@linux.vnet.ibm.com> +#define CXL_DEV_MINORS 13 /* 1 control + 4 AFUs * 3 (dedicated/master/shared) */ Where does this limit of 4 AFUs com

Re: [PATCH v5 13/18] cxl: sysfs support for guests

Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com> --- Manoj Kumar On 2/23/2016 10:21 AM, Frederic Barrat wrote: From: Christophe Lombard <clomb...@linux.vnet.ibm.com> Filter out a few adapter parameters which don't make sense in a guest. Document the changes. Co-authored-

Re: [PATCH v5 12/18] cxl: Add guest-specific code

Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com> --- Manoj Kumar On 2/23/2016 10:21 AM, Frederic Barrat wrote: From: Christophe Lombard <clomb...@linux.vnet.ibm.com> The new of.c file contains code to parse the device tree to find out about cxl adapters and AFUs. guest.

Re: [PATCH v5 11/18] cxl: Separate bare-metal fields in adapter and AFU data structures

Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com> --- Manoj Kumar On 2/23/2016 10:21 AM, Frederic Barrat wrote: From: Christophe Lombard <clomb...@linux.vnet.ibm.com> Introduce sub-structures containing the bare-metal specific fields in the structures describing the adapter

Re: [PATCH v5 10/18] cxl: New hcalls to support cxl adapters

Fred: Thanks for correcting those spellings. Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com> --- Manoj Kumar On 2/23/2016 10:21 AM, Frederic Barrat wrote: From: Christophe Lombard <clomb...@linux.vnet.ibm.com> The hypervisor calls provide an interface with a coherent platf

Re: [PATCH v5 09/18] cxl: New possible return value from hcall

Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com> --- Manoj Kumar On 2/23/2016 10:21 AM, Frederic Barrat wrote: From: Christophe Lombard <clomb...@linux.vnet.ibm.com> The hcalls introduced for cxl use a possible new value: H_STATE (invalid state). Co-authored-by: Frederic

Re: [PATCH v5 08/18] cxl: IRQ allocation for guests

Fred: Thanks for revising the commit message. Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com> --- Manoj Kumar On 2/23/2016 10:21 AM, Frederic Barrat wrote: The PSL interrupt cannot be multiplexed in a guest, as it is not supported by the hypervisor. So an interrupt will be all

Re: [PATCH v5 07/18] cxl: Update cxl_irq() prototype

Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com> --- Manoj Kumar On 2/23/2016 10:21 AM, Frederic Barrat wrote: The context parameter when calling cxl_irq() should be strongly typed. Co-authored-by: Christophe Lombard <clomb...@linux.vnet.ibm.com> Signed-off-by: Frederic

Re: [PATCH v5 06/18] cxl: Isolate a few bare-metal-specific calls

Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com> --- Manoj Kumar On 2/23/2016 10:21 AM, Frederic Barrat wrote: A few functions are mostly common between bare-metal and guest and just need minor tuning. To avoid crowding the backend API, introduce a few 'if' based on the CPU being in H

Re: [PATCH v5 05/18] cxl: Rename some bare-metal specific functions

Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com> --- Manoj Kumar On 2/23/2016 10:21 AM, Frederic Barrat wrote: Rename a few functions, changing the 'cxl_' prefix to either 'cxl_pci_' or 'cxl_native_', to make clear that the implementation is bare-metal specific. Those functions wil

Re: [PATCH v5 04/18] cxl: Introduce implementation-specific API

Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com> --- Manoj Kumar On 2/23/2016 10:21 AM, Frederic Barrat wrote: The backend API (in cxl.h) lists some low-level functions whose implementation is different on bare-metal and in a guest. Each environment implements its own fun

Re: [PATCH v5 03/18] cxl: Define process problem state area at attach time only

Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com> --- Manoj Kumar On 2/23/2016 10:21 AM, Frederic Barrat wrote: CXL kernel API was defining the process problem state area during context initialization, making it possible to map the problem state area before attaching the context. This

Re: [PATCH v5 02/18] cxl: Move bare-metal specific code to specialized files

Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com> --- Manoj Kumar On 2/23/2016 10:21 AM, Frederic Barrat wrote: Move a few functions around to better separate code specific to bare-metal environment from code which will be commonly used between guest and bare-metal. Code specific t

Re: [PATCH v5 01/18] cxl: Move common code away from bare-metal-specific files

Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com> --- Manoj Kumar On 2/23/2016 10:21 AM, Frederic Barrat wrote: From: Christophe Lombard <clomb...@linux.vnet.ibm.com> Move around some functions which will be accessed from the bare-metal and guest environments. Code in native

Re: Fwd: [PATCH v4 10/18] cxl: New hcalls to support CAPI adapters

On 2/22/2016 12:14 PM, Frederic Barrat wrote: platoform->platform Irreverent to the Socratic amongst us. Hope we didn't hurt your feelings :-D Fred No, you did not! ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org

Re: Fwd: [PATCH v4 08/18] cxl: IRQ allocation for guests

On 2/22/2016 8:46 AM, Frederic Barrat wrote: Le 21/02/2016 23:30, Manoj Kumar a écrit : Subject: [PATCH v4 08/18] cxl: IRQ allocation for guests Date: Tue, 16 Feb 2016 22:39:01 +0100 From: Frederic Barrat <fbar...@linux.vnet.ibm.com> To: imun...@au1.ibm.com, michael.neul...@au1.ibm.

Re: Fwd: [PATCH v4 11/18] cxl: Separate bare-metal fields in adapter and AFU data structures

to address it in this patchset. Fred Fred: I am fine with this approach. -- Manoj Kumar ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: Fwd: [PATCH v4 12/18] cxl: Add guest-specific code

. Will pick it back up after you resubmit. -- Manoj Kumar Subject: [PATCH v4 12/18] cxl: Add guest-specific code Date: Tue, 16 Feb 2016 22:39:05 +0100 From: Frederic Barrat <fbar...@linux.vnet.ibm.com> To: imun...@au1.ibm.com, michael.neul...@au1.ibm.com, m...@ellerman.id.au, linuxppc-dev@lists.ozla

Re: Fwd: [PATCH v4 11/18] cxl: Separate bare-metal fields in adapter and AFU data structures

Christophe, Fred: Perhaps none of these comments below are specific to your patch, but clarification would help the next reviewer. -- Manoj Kumar Subject: [PATCH v4 11/18] cxl: Separate bare-metal fields in adapter and -WARN_ON(afu->spa_size > 0x10); /* Max size sup

Re: Fwd: [PATCH v4 10/18] cxl: New hcalls to support CAPI adapters

Fred: See comments below. The most egregious checkpatch violations so far in this series, for going beyond 80 columns. total: 65 warnings, 924 lines checked On 2/21/2016 3:31 PM, Uma Krishnan wrote: From: Christophe Lombard The hypervisor calls provide an

Re: Fwd: [PATCH v4 09/18] cxl: New possible return value from hcall

Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com> --- Manoj Kumar Subject: [PATCH v4 09/18] cxl: New possible return value from hcall Date: Tue, 16 Feb 2016 22:39:02 +0100 From: Frederic Barrat <fbar...@linux.vnet.ibm.com> To: imun...@au1.ibm.com, michael.neul...@au

Re: Fwd: [PATCH v4 08/18] cxl: IRQ allocation for guests

Fred: See comment below. --- Manoj Kumar Subject: [PATCH v4 08/18] cxl: IRQ allocation for guests Date: Tue, 16 Feb 2016 22:39:01 +0100 From: Frederic Barrat <fbar...@linux.vnet.ibm.com> To: imun...@au1.ibm.com, michael.neul...@au1.ibm.com, m...@ellerman.id.au, linuxppc-dev@lists.ozla

Re: Fwd: [PATCH v4 07/18] cxl: Update cxl_irq() prototype

Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com> --- Manoj Kumar Subject: [PATCH v4 07/18] cxl: Update cxl_irq() prototype Date: Tue, 16 Feb 2016 22:39:00 +0100 From: Frederic Barrat <fbar...@linux.vnet.ibm.com> To: imun...@au1.ibm.com, michael.neul...@au1.ibm.com, m...@el

Re: Fwd: [PATCH v4 06/18] cxl: Isolate a few bare-metal-specific calls

Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com> --- Manoj Kumar Subject: [PATCH v4 06/18] cxl: Isolate a few bare-metal-specific calls Date: Tue, 16 Feb 2016 22:38:59 +0100 From: Frederic Barrat <fbar...@linux.vnet.ibm.com> To: imun...@au1.ibm.com, michael.neul...@au

Re: Fwd: [PATCH v4 05/18] cxl: Rename some bare-metal specific functions

Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com> --- Manoj Kumar Subject: [PATCH v4 05/18] cxl: Rename some bare-metal specific functions Date: Tue, 16 Feb 2016 22:38:58 +0100 From: Frederic Barrat <fbar...@linux.vnet.ibm.com> To: imun...@au1.ibm.com, michael.neul...@au

Re: Fwd: [PATCH v4 04/18] cxl: Introduce implementation-specific API

Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com> --- Manoj Kumar Subject: [PATCH v4 04/18] cxl: Introduce implementation-specific API Date: Tue, 16 Feb 2016 22:38:57 +0100 From: Frederic Barrat <fbar...@linux.vnet.ibm.com> To: imun...@au1.ibm.com, michael.neul...@au

Re: Fwd: [PATCH v4 03/18] cxl: Define process problem state area at attach time only

Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com> --- Manoj Kumar Subject: [PATCH v4 03/18] cxl: Define process problem state area at attach time only Date: Tue, 16 Feb 2016 22:38:56 +0100 From: Frederic Barrat <fbar...@linux.vnet.ibm.com> To: imun...@au1.ibm.com, michael

Re: Fwd: [PATCH v4 02/18] cxl: Move bare-metal specific code to specialized files

Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com> --- Manoj Kumar -- Subject: [PATCH v4 02/18] cxl: Move bare-metal specific code to specialized files Date: Tue, 16 Feb 2016 22:38:55 +0100 From: Frederic Barrat <fbar...@linux.vnet.ibm.com> To: imun...@au1.ibm.com, michael

Re: Fwd: [PATCH v4 01/18] cxl: Move common code away from bare-metal-specific files

Would have been nice to have the code and the commit messages consistent in the terminology. Commit comments: bare-metal and guest Code: powernv and phyp Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com> --- Manoj Kumar Forwarded Message Subject: [PATCH v4 01/1

Re: [PATCH v2 1/7] ibmvscsi: Correct values for several viosrp_crq_format enums

Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com> --- Manoj Kumar On 2/10/2016 7:32 PM, Tyrel Datwyler wrote: The enum values for VIOSRP_LINUX_FORMAT and VIOSRP_INLINE_FORMAT are off by one. They are currently defined as 0x06 and 0x07 respetively. These values are defined in PAPR cor

Re: [PATCH v2 2/7] ibmvscsi: Add and use enums for valid CRQ header values

Tyrel: Thanks for incorporating the suggestions. Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com> --- Manoj Kumar On 2/10/2016 7:32 PM, Tyrel Datwyler wrote: The PAPR defines four valid header values for the first byte of a CRQ message. Namely, an unused/empty message (0x00), a

Re: [PATCH v2 3/7] ibmvscsi: Replace magic values in set_adpater_info() with defines

Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com> --- Manoj Kumar On 2/10/2016 7:32 PM, Tyrel Datwyler wrote: Add defines for mad version and mad os_type, and replace the magic numbers in set_adapter_info() accordingly. Signed-off-by: Tyrel Datwyler <tyr...@linux.vne

Re: [PATCH 2/6] ibmvscsi: Add and use enums for valid CRQ header values

Yeah, I can see how that is confusing. Since, all three possible valid crq message types have the first bit set I think this was originally a cute hack to grab anything that was likely valid. Then in ibmvscsi_handle_crq() we explicitly match the full header value in a switch statement logging

Re: [PATCH 2/6] ibmvscsi: Add and use enums for valid CRQ header values

On 2/3/2016 5:28 PM, Tyrel Datwyler wrote: The PAPR defines four valid header values for the first byte of a CRQ message. Namely, an unused/empty message (0x00), a valid command/response entry (0x80), a valid initialization entry (0xC0), and a transport event (0xFF). Define these values as enums

Re: [PATCH v2 3/6] cxlflash: Removed driver date print

On 12/14/2015 3:06 PM, Uma Krishnan wrote: Having a date for the driver requires it to be updated quite often. Removing the date which is not necessary. Also made use of the existing symbol to print the driver name. Signed-off-by: Uma Krishnan --- Acked-by: Manoj

Re: [PATCH 6/6] cxlflash: Enable device id for future IBM CXL adapter

On 12/13/2015 9:47 PM, Andrew Donnellan wrote: On 11/12/15 09:54, Uma Krishnan wrote: From: Manoj Kumar <ma...@linux.vnet.ibm.com> This drop enables a future card with a device id of 0x0600 to be recognized by the cxlflash driver. No card specific programming has been added. Thes

Re: [PATCH 2/6] cxlflash: Fix to avoid virtual LUN failover failure

ry in a presence of an I/O failure. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Acked-by: Manoj Kumar <ma...@linux.vnet.ibm.com> ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v6 35/37] cxlflash: Fix to avoid corrupting port selection mask

Acked-by: Manoj Kumar <ma...@linux.vnet.ibm.com> On 10/21/2015 3:16 PM, Matthew R. Ochs wrote: The port selection mask of a LUN can be corrupted when the manage LUN ioctl (DK_CXLFLASH_MANAGE_LUN) is issued more than once for any device. ___ Li

Re: [PATCH v6 37/37] cxlflash: Fix to avoid bypassing context cleanup

Acked-by: Manoj Kumar <ma...@linux.vnet.ibm.com> On 10/21/2015 3:16 PM, Matthew R. Ochs wrote: Contexts may be skipped over for cleanup in situations where contention for the adapter's table-list mutex is experienced in the presence of a signal during the execution of the release h

Re: [PATCH v6 36/37] cxlflash: Fix to avoid lock instrumentation rejection

Acked-by: Manoj Kumar <ma...@linux.vnet.ibm.com> On 10/21/2015 3:16 PM, Matthew R. Ochs wrote: When running with lock instrumentation (e.g. lockdep), some of the instrumentation can become disabled at probe time for a cxlflash adapter. This is due to a missing lock regist

Re: [PATCH v5 33/34] cxlflash: Fix to avoid leaving dangling interrupt resources

Acked-by: Manoj Kumar <ma...@linux.vnet.ibm.com> ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev