Re: [PATCHv4 7/9] ASoC: fsl-asoc-card: add DT clock "cpu_sysclk" with generic codec

2024-05-17 Thread Mark Brown
On Fri, May 17, 2024 at 05:05:35AM -0400, Elinor Montmasson wrote: > From: "Mark Brown" > > On Wed, May 15, 2024 at 03:54:09PM +0200, Elinor Montmasson wrote: > >> + struct clk *cpu_sysclk = clk_get(>dev, "cpu_sysclk"

Re: [PATCHv4 9/9] ASoC: dt-bindings: fsl-asoc-card: add compatible for generic codec

2024-05-17 Thread Mark Brown
On Fri, May 17, 2024 at 05:05:41AM -0400, Elinor Montmasson wrote: > From: "Mark Brown" > > This description (and the code) don't feel like they're actually generic > > - they're clearly specific to the bidrectional S/PDIF case. I'd expect > > something call

Re: [PATCHv4 8/9] ASoC: fsl-asoc-card: add DT property "cpu-system-clock-direction-out"

2024-05-17 Thread Mark Brown
On Fri, May 17, 2024 at 05:05:38AM -0400, Elinor Montmasson wrote: > This new compatible is intended to be used when there is no codec > device/driver. There is technically no codec device/driver for which > the clock input can be set. This is obviously not true, there clearly is a driver. > Is

Re: [PATCHv4 8/9] ASoC: fsl-asoc-card: add DT property "cpu-system-clock-direction-out"

2024-05-16 Thread Mark Brown
On Wed, May 15, 2024 at 03:54:10PM +0200, Elinor Montmasson wrote: > Add new optional DT property "cpu-system-clock-direction-out" to set > sysclk direction as "out" for the CPU DAI when using the generic codec. > It is set for both Tx and Rx. > If not set, the direction is "in". > The way the

Re: [PATCHv4 7/9] ASoC: fsl-asoc-card: add DT clock "cpu_sysclk" with generic codec

2024-05-16 Thread Mark Brown
On Wed, May 15, 2024 at 03:54:09PM +0200, Elinor Montmasson wrote: > Add an optional DT clock "cpu_sysclk" to get the CPU DAI system-clock > frequency when using the generic codec. > It is set for both Tx and Rx. > The way the frequency value is used is up to the CPU DAI driver > implementation.

Re: [PATCHv4 9/9] ASoC: dt-bindings: fsl-asoc-card: add compatible for generic codec

2024-05-16 Thread Mark Brown
On Wed, May 15, 2024 at 03:54:11PM +0200, Elinor Montmasson wrote: > Add documentation about new dts bindings following new support > for compatible "fsl,imx-audio-generic". >audio-codec: > -$ref: /schemas/types.yaml#/definitions/phandle > -description: The phandle of an audio codec

Re: [PATCH 0/4] ASoC: Constify static snd_pcm_hardware

2024-05-07 Thread Mark Brown
On Mon, 29 Apr 2024 13:48:45 +0200, Krzysztof Kozlowski wrote: > No dependencies. > > Static 'struct snd_pcm_hardware' is not modified by few drivers and its > copy is passed to the core, so it can be made const for increased code > safety. > > Best regards, > Krzysztof > > [...] Applied to

Re: [PATCH 00/13] ASoC: Use snd_soc_substream_to_rtd() for accessing private_data

2024-05-07 Thread Mark Brown
On Tue, 30 Apr 2024 16:02:09 +0200, Krzysztof Kozlowski wrote: > Do not open-code snd_soc_substream_to_rtd() when accessing > snd_pcm_substream->private_data. This makes code more consistent with > rest of ASoC and allows in the future to move the field to any other > place or add additional

Re: [PATCH v4 00/29] arm64: Permission Overlay Extension

2024-05-05 Thread Mark Brown
On Fri, May 03, 2024 at 02:01:18PM +0100, Joey Gouly wrote: > One possible issue with this version, I took the last bit of HWCAP2. Fortunately we already have AT_HWCAP[34] defined thanks to PowerPC. signature.asc Description: PGP signature

Re: [PATCH v15 00/16] Add audio support in v4l2 framework

2024-05-02 Thread Mark Brown
On Thu, May 02, 2024 at 10:26:43AM +0100, Mauro Carvalho Chehab wrote: > Mauro Carvalho Chehab escreveu: > > There are still time control associated with it, as audio and video > > needs to be in sync. This is done by controlling the buffers size > > and could be fine-tuned by checking when the

Re: [PATCH v15 00/16] Add audio support in v4l2 framework

2024-04-30 Thread Mark Brown
On Tue, Apr 30, 2024 at 05:27:52PM +0100, Mauro Carvalho Chehab wrote: > Mark Brown escreveu: > > On Tue, Apr 30, 2024 at 10:21:12AM +0200, Sebastian Fricke wrote: > > The discussion around this originally was that all the audio APIs are > > very much centered around real t

Re: [PATCH v15 00/16] Add audio support in v4l2 framework

2024-04-30 Thread Mark Brown
On Tue, Apr 30, 2024 at 10:21:12AM +0200, Sebastian Fricke wrote: > first of all thanks for all of this work and I am very sorry for only > emerging this late into the series, I sadly didn't notice it earlier. It might be worth checking out the discussion on earlier versions... > 1. The biggest

Re: [PATCH 0/2] ASoC: fsl-asoc-card: add wm8904 codec support

2024-04-16 Thread Mark Brown
On Mon, 15 Apr 2024 15:17:34 +0800, Shengjiu Wang wrote: > add wm8904 codec support in fsl-asoc-card. > > Shengjiu Wang (2): > ASoC: fsl-asoc-card: add wm8904 codec support > ASoC: dt-bindings: fsl-asoc-card: Add compatbile string for wm8904 > codec > > [...] Applied to

Re: [PATCH v3 0/5] ASoC: fsl: Support register and unregister rpmsg sound card through remoteproc

2024-03-26 Thread Mark Brown
On Mon, 11 Mar 2024 20:13:44 +0900, Chancel Liu wrote: > echo /lib/firmware/fw.elf > /sys/class/remoteproc/remoteproc0/firmware > (A) echo start > /sys/class/remoteproc/remoteproc0/state > (B) echo stop > /sys/class/remoteproc/remoteproc0/state > > The rpmsg sound card is registered in

Re: [PATCH v1 1/1] ASoC: fsl: imx-es8328: Remove leftover gpio initialisation

2024-03-26 Thread Mark Brown
On Mon, 25 Mar 2024 21:13:41 +0200, Andy Shevchenko wrote: > The gpio field is not used anymore, remove the leftover. > This also fixes the compilation error after the ... > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: fsl:

Re: [PATCH v2 1/1] ASoC: fsl: imx-es8328: Switch to using gpiod API

2024-03-25 Thread Mark Brown
On Mon, 18 Mar 2024 22:07:56 +0200, Andy Shevchenko wrote: > This updates the driver to gpiod API, and removes yet another use of > of_get_named_gpio(). > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: fsl: imx-es8328: Switch to

Re: [PATCH 1/1] ASoC: fsl: fsl_ssi: Add dev_err_probe if PCM DMA init fails

2024-03-25 Thread Mark Brown
On Thu, 14 Mar 2024 15:16:42 +0100, Alexander Stein wrote: > This happens especially if this driver is built-in, but SDMA driver > is configured as module. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: fsl: fsl_ssi: Add

Re: [PATCH] ASoC: soc-card: Fix missing locking in snd_soc_card_get_kcontrol()

2024-02-23 Thread Mark Brown
On Wed, 21 Feb 2024 12:37:10 +, Richard Fitzgerald wrote: > snd_soc_card_get_kcontrol() must be holding a read lock on > card->controls_rwsem while walking the controls list. > > Compare with snd_ctl_find_numid(). > > The existing function is renamed snd_soc_card_get_kcontrol_locked() > so

Re: [PATCH v1] spi: spi-ppc4xx: include missing platform_device.h

2024-02-09 Thread Mark Brown
On Fri, 09 Feb 2024 15:59:07 +0100, Christian Lamparter wrote: > the driver currently fails to compile on 6.8-rc3 due to: > | spi-ppc4xx.c: In function ‘spi_ppc4xx_of_probe’: > | @346:36: error: invalid use of undefined type ‘struct platform_device’ > | 346 | struct device_node *np =

Re: [PATCH v2 0/3] ASoC: Support SAI and MICFIL on i.MX95 platform

2024-01-22 Thread Mark Brown
On Fri, 12 Jan 2024 14:43:28 +0900, Chancel Liu wrote: > Support SAI and MICFIL on i.MX95 platform > > changes in v2 > - Remove unnecessary "item" in fsl,micfil.yaml > - Don't change alphabetical order in fsl,sai.yaml > > Chancel Liu (3): > ASoC: dt-bindings: fsl,sai: Add compatible string for

Re: [PATCH] ASoC: fsl_rpmsg: Fix error handler with pm_runtime_enable

2023-12-29 Thread Mark Brown
On Mon, 25 Dec 2023 17:06:08 +0900, Chancel Liu wrote: > There is error message when defer probe happens: > > fsl_rpmsg rpmsg_audio: Unbalanced pm_runtime_enable! > > Fix the error handler with pm_runtime_enable. > > > [...] Applied to

Re: [PATCH v2] ASoC: fsl_sai: Fix channel swap issue on i.MX8MP

2023-12-19 Thread Mark Brown
On Tue, 19 Dec 2023 10:30:57 +0800, Shengjiu Wang wrote: > When flag mclk_with_tere and mclk_direction_output enabled, > The SAI transmitter or receiver will be enabled in very early > stage, that if FSL_SAI_xMR is set by previous case, > for example previous case is one channel, current case is >

Re: [PATCH] ASoC: fsl_mqs: remove duplicated including

2023-12-15 Thread Mark Brown
On Fri, 15 Dec 2023 17:13:51 +0800, Wang Jinchao wrote: > rm the second \#include > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: fsl_mqs: remove duplicated including commit: e7a4a2fd9a4116286a1523ea1a5cbabd2c36f5b9 All

Re: [PATCH 15/22] arch: vdso: consolidate gettime prototypes

2023-11-24 Thread Mark Brown
On Wed, Nov 08, 2023 at 01:58:36PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > The VDSO functions are defined as globals in the kernel sources but intended > to be called from userspace, so there is no need to declare them in a kernel > side header. This is in -next as commit

Re: [PATCH] ASoC: fsl_xcvr: refine the requested phy clock frequency

2023-11-23 Thread Mark Brown
On Thu, 23 Nov 2023 09:14:53 +0800, Shengjiu Wang wrote: > As the input phy clock frequency will divided by 2 by default > on i.MX8MP with the implementation of clk-imx8mp-audiomix driver, > So the requested frequency need to be updated. > > The relation of phy clock is: > sai_pll_ref_sel >

Re: (subset) [PATCH 1/2] ASoC: fsl: mpc8610_hpcd: Remove unused driver

2023-11-23 Thread Mark Brown
On Wed, 22 Nov 2023 17:27:11 +1100, Michael Ellerman wrote: > The mpc8610_hpcd.c driver depends on CONFIG_MPC8610_HPCD which was > removed in commit 248667f8bbde ("powerpc: drop HPCD/MPC8610 evaluation > platform support"). That makes the driver unbuildable and unusable, so > remove it. > >

Re: [PATCH] ASoC: fsl_xcvr: Enable 2 * TX bit clock for spdif only case

2023-11-22 Thread Mark Brown
On Wed, 22 Nov 2023 09:42:53 +0800, Shengjiu Wang wrote: > The bit 10 in TX_DPTH_CTRL register controls the TX clock rate. > If this bit is set, TX datapath clock should be = 2* TX bit rate. > If this bit is not set, TX datapath clock should be 10* TX bit rate. > > As the spdif only case, we

Re: [PATCH 2/2] ASoC: cs4270: Remove unused codec

2023-11-22 Thread Mark Brown
On Wed, Nov 22, 2023 at 05:27:12PM +1100, Michael Ellerman wrote: > The only driver to enable SND_SOC_CS4270 was SND_SOC_MPC8610_HPCD, which > was dropped in the preceding commit. Remove the codec as unused. There's no real overhead from having extra drivers and we do have generic drivers that

Re: [PATCH v5 1/2] ASoC: dt-bindings: sound-card-common: List sound widgets ignoring system suspend

2023-11-21 Thread Mark Brown
On Tue, 21 Nov 2023 13:25:11 +0800, Chancel Liu wrote: > Add a property to list audio sound widgets which are marked ignoring > system suspend. Paths between these endpoints are still active over > suspend of the main application processor that the current operating > system is running. > >

Re: [PATCH v4 2/2] ASoC: imx-rpmsg: Force codec power on in low power audio mode

2023-11-20 Thread Mark Brown
On Mon, Oct 23, 2023 at 10:07:18AM +0800, Chancel Liu wrote: > Low power audio mode requires binding codec still power on while Acore > enters into suspend so Mcore can continue playback music. > > ASoC machine driver acquires DAPM endpoints through reading > "ignore-suspend-widgets" property

Re: [PATCH] ASoC: fsl_mqs: Remove duplicate linux/of.h header

2023-11-20 Thread Mark Brown
On Sun, 19 Nov 2023 10:45:14 +, Lucas Tanure wrote: > Remove linux/of.h as is included more than once. > Reported by make includecheck. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: fsl_mqs: Remove duplicate linux/of.h

Re: [PATCH] ASoC: fsl_sai: Fix no frame sync clock issue on i.MX8MP

2023-11-20 Thread Mark Brown
On Mon, 20 Nov 2023 18:05:35 +0800, Shengjiu Wang wrote: > On i.MX8MP, when the TERE and FSD_MSTR enabled before configuring > the word width, there will be no frame sync clock issue, because > old word width impact the generation of frame sync. > > TERE enabled earlier only for i.MX8MP case for

Re: [PATCH 34/34] KVM: selftests: Add a memory region subtest to validate invalid flags

2023-11-20 Thread Mark Brown
On Wed, Nov 08, 2023 at 05:08:01PM -0800, Anish Moorthy wrote: > Applying [1] and [2] reveals that this also breaks non-x86 builds- the > MEM_REGION_GPA/SLOT definitions are guarded behind an #ifdef > __x86_64__, while the usages introduced here aren't. > > Should > > On Sun, Nov 5, 2023 at 8:35 

Re: [PATCH v9 00/27] Add support for QMC HDLC, framer infrastructure and PEF2256 framer

2023-11-20 Thread Mark Brown
On Fri, Nov 17, 2023 at 04:47:46PM -0800, Jakub Kicinski wrote: > On Wed, 15 Nov 2023 15:39:36 +0100 Herve Codina wrote: > >- Removed Patches 6, 7 and 8 (patches applied) > > > >- Patches 7, 20, 21, 23 (patches 10, 23, 24, 26 in v8) > > Add 'Acked-by: Jakub Kicinski ' > I thought

Re: [PATCH v4 1/2] ASoC: dt-bindings: sound-card-common: List sound widgets ignoring system suspend

2023-10-26 Thread Mark Brown
On Thu, Oct 26, 2023 at 12:58:42PM -0500, Rob Herring wrote: > On Mon, Oct 23, 2023 at 10:07:17AM +0800, Chancel Liu wrote: > > Add a property to list audio sound widgets which are marked ignoring > > system suspend. Paths between these endpoints are still active over > > suspend of the main

Re: [PATCH v8 00/30] Add support for QMC HDLC, framer infrastructure and PEF2256 framer

2023-10-25 Thread Mark Brown
On Wed, Oct 25, 2023 at 12:32:15PM -0700, Jakub Kicinski wrote: > On Wed, 25 Oct 2023 17:00:51 +0200 Herve Codina wrote: > > > Which way will those patches go? Via some FSL SoC tree? > > This series seems mature now. > > What is the plan next in order to have it applied ? > > Don't hesitate to

Re: [PATCH v2] ASoC: fsl: Fix PM disable depth imbalance in fsl_easrc_probe

2023-10-24 Thread Mark Brown
On Thu, 12 Oct 2023 21:03:15 +0800, Zhang Shurong wrote: > The pm_runtime_enable will increase power disable depth. Thus > a pairing decrement is needed on the error handling path to > keep it balanced according to context. We fix it by calling > pm_runtime_disable when error returns. > >

Re: Re: [PATCH v3 1/2] ASoC: dt-bindings: sound-card-common: List DAPM endpoints ignoring system suspend

2023-10-16 Thread Mark Brown
On Mon, Oct 16, 2023 at 12:08:56PM +, Chancel Liu wrote: > Thanks Mark and Rob for your advice. In fact, it's common use case. We can see > many drivers set widgets ignoring suspend. I will remove the linux specifics > and focus on the key concept. How about the modification on the property

Re: [RFC PATCH v6 05/11] ASoC: fsl_easrc: register m2m platform device

2023-10-13 Thread Mark Brown
On Fri, Oct 13, 2023 at 04:30:59PM +0800, Shengjiu Wang wrote: > Register m2m platform device,that user can > use M2M feature. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [RFC PATCH v6 04/11] ASoC: fsl_asrc: register m2m platform device

2023-10-13 Thread Mark Brown
On Fri, Oct 13, 2023 at 04:30:58PM +0800, Shengjiu Wang wrote: > Register m2m platform device, that user can > use M2M feature. > > Defined platform data structure and platform > driver name. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [RFC PATCH v6 03/11] ASoC: fsl_asrc: move fsl_asrc_common.h to include/sound

2023-10-13 Thread Mark Brown
On Fri, Oct 13, 2023 at 04:30:57PM +0800, Shengjiu Wang wrote: > Move fsl_asrc_common.h to include/sound that it can be > included from other drivers. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [RFC PATCH v6 02/11] ASoC: fsl_easrc: define functions for memory to memory usage

2023-10-13 Thread Mark Brown
On Fri, Oct 13, 2023 at 04:30:56PM +0800, Shengjiu Wang wrote: > ASRC can be used on memory to memory case, define several > functions for m2m usage and export them as function pointer. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [RFC PATCH v6 01/11] ASoC: fsl_asrc: define functions for memory to memory usage

2023-10-13 Thread Mark Brown
On Fri, Oct 13, 2023 at 04:30:55PM +0800, Shengjiu Wang wrote: > ASRC can be used on memory to memory case, define several > functions for m2m usage. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH v3 1/2] ASoC: dt-bindings: sound-card-common: List DAPM endpoints ignoring system suspend

2023-10-11 Thread Mark Brown
On Wed, Oct 11, 2023 at 07:47:58PM +0800, Chancel Liu wrote: > + lpa-widgets: > +$ref: /schemas/types.yaml#/definitions/non-unique-string-array > +description: | > + A list of DAPM endpoints which mark paths between these endpoints > should > + not be disabled when system

Re: [PATCH v3 0/5] ASoC: DT matching and header cleanups

2023-10-10 Thread Mark Brown
On Fri, 06 Oct 2023 15:09:09 -0500, Rob Herring wrote: > (trimmed the recipient list due to bounces on v1) > > This is a series is part of ongoing clean-ups related to device > matching and DT related implicit includes. Essentially of_device.h has > a bunch of implicit includes and generally

Re: [PATCH v2 0/5] ASoC: DT matching and header cleanups

2023-10-10 Thread Mark Brown
On Wed, 04 Oct 2023 10:58:04 -0500, Rob Herring wrote: > (trimmed the recipient list due to bounces on v1) > > This is a series is part of ongoing clean-ups related to device > matching and DT related implicit includes. Essentially of_device.h has > a bunch of implicit includes and generally

Re: [PATCH RESEND 0/5] ASoC: DT matching and header cleanups

2023-10-10 Thread Mark Brown
On Tue, 03 Oct 2023 13:13:09 -0500, Rob Herring wrote: > (Got a bunch of bounces on the first try. Something weird going on with > the To header best I can tell. Retrying with git-send-email instead of > b4.) > > This is a series is part of ongoing clean-ups related to device > matching and DT

Re: [EXT] Re: Re: [PATCH v2 1/2] ASoC: dt-bindings: fsl_rpmsg: List DAPM endpoints ignoring system suspend

2023-10-09 Thread Mark Brown
On Sat, Oct 07, 2023 at 11:13:49AM +, Chancel Liu wrote: > Instead of "fsl,lpa-widgets", I would like to add a common property > "ignore-suspend-widgets" in sound-card-common.yaml file. So not only rpmsg > sound cards but also other sound cards which have such feature can use this > property

Re: [PATCH v2 1/5] ASoC: Explicitly include correct DT includes

2023-10-04 Thread Mark Brown
On Wed, Oct 04, 2023 at 10:58:05AM -0500, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it was merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each

Re: [RFC PATCH v5 00/11] Add audio support in v4l2 framework

2023-10-02 Thread Mark Brown
On Thu, Sep 28, 2023 at 05:00:08PM +0800, Shengjiu Wang wrote: > Audio signal processing also has the requirement for memory to > memory similar as Video. > This asrc memory to memory (memory ->asrc->memory) case is a non > real time use case. Other than the naming thing I sent in reply to one

Re: [RFC PATCH v5 01/11] ASoC: fsl_asrc: define functions for memory to memory usage

2023-10-02 Thread Mark Brown
On Thu, Sep 28, 2023 at 05:00:09PM +0800, Shengjiu Wang wrote: > m2m_start_part_one: first part of the start steps > m2m_start_part_two: second part of the start steps > m2m_stop_part_one: first part of stop steps > m2m_stop_part_two: second part of stop steps, optional The part_one/two naming

Re: Re: [PATCH v2 1/2] ASoC: dt-bindings: fsl_rpmsg: List DAPM endpoints ignoring system suspend

2023-09-27 Thread Mark Brown
On Wed, Sep 27, 2023 at 03:07:49AM +, Chancel Liu wrote: > > This is a fairly standard DSP playback case as far as I can see so it > > should work with DAPM without needing this obviously use case specific > > stuff peering into the Linux implementation. Generally this is done by > > tagging

Re: [PATCH] ASoC: dt-bindings: Add missing (unevaluated|additional)Properties on child node schemas

2023-09-26 Thread Mark Brown
On Mon, 25 Sep 2023 17:09:28 -0500, Rob Herring wrote: > Just as unevaluatedProperties or additionalProperties are required at > the top level of schemas, they should (and will) also be required for > child node schemas. That ensures only documented properties are > present for any node. > > Add

Re: [PATCH] ASoC: fsl-asoc-card: use integer type for fll_id and pll_id

2023-09-26 Thread Mark Brown
On Wed, 20 Sep 2023 17:43:12 +0800, Shengjiu Wang wrote: > As the pll_id and pll_id can be zero (WM8960_SYSCLK_AUTO) > with the commit 2bbc2df46e67 ("ASoC: wm8960: Make automatic the > default clocking mode") > > Then the machine driver will skip to call set_sysclk() and set_pll() > for codec,

Re: [PATCH] ASoC: fsl_sai: Don't disable bitclock for i.MX8MP

2023-09-26 Thread Mark Brown
On Tue, 19 Sep 2023 17:42:13 +0800, Shengjiu Wang wrote: > On i.MX8MP, the BCE and TERE bit are binding with mclk > enablement, if BCE and TERE are cleared the MCLK also be > disabled on output pin, that cause the external codec (wm8960) > in wrong state. > > Codec (wm8960) is using the mclk to

Re: [PATCH v2 1/2] ASoC: dt-bindings: fsl_rpmsg: List DAPM endpoints ignoring system suspend

2023-09-25 Thread Mark Brown
On Mon, Sep 25, 2023 at 07:09:45PM +0800, Chancel Liu wrote: > + fsl,lpa-widgets: > +$ref: /schemas/types.yaml#/definitions/non-unique-string-array > +description: | > + A list of DAPM endpoints which mark paths between these endpoints > should > + not be disabled when system

Re: [RFC PATCH v4 09/11] media: uapi: Add V4L2_CID_USER_IMX_ASRC_RATIO_MOD control

2023-09-21 Thread Mark Brown
On Thu, Sep 21, 2023 at 07:13:14PM +0800, Shengjiu Wang wrote: > Ratio modification on i.MX is to modify the configured ratio. > For example, the input rate is 44.1kHz, output rate is 48kHz, > configured ratio = 441/480, the ratio modification is to modify > the fractional part of (441/480)

Re: [PATCH] ASoC: imx-audmix: Fix return error with devm_clk_get()

2023-09-15 Thread Mark Brown
On Fri, 15 Sep 2023 14:02:11 +0800, Shengjiu Wang wrote: > The devm_clk_get() can return -EPROBE_DEFER error, > modify the error code to be -EINVAL is not correct, which > cause the -EPROBE_DEFER error is not correctly handled. > > This patch is to fix the return error code. > > > [...]

Re: [PATCH v2] ASoC: imx-rpmsg: Set ignore_pmdown_time for dai_link

2023-09-14 Thread Mark Brown
On Wed, 13 Sep 2023 18:26:56 +0800, Chancel Liu wrote: > i.MX rpmsg sound cards work on codec slave mode. MCLK will be disabled > by CPU DAI driver in hw_free(). Some codec requires MCLK present at > power up/down sequence. So need to set ignore_pmdown_time to power down > codec immediately before

Re: [PATCH v5 24/31] net: wan: Add framer framework support

2023-09-13 Thread Mark Brown
On Tue, Sep 12, 2023 at 12:14:36PM +0200, Herve Codina wrote: > A framer is a component in charge of an E1/T1 line interface. > Connected usually to a TDM bus, it converts TDM frames to/from E1/T1 > frames. It also provides information related to the E1/T1 line. > > The framer framework provides

Re: [PATCH v5 28/31] pinctrl: Add support for the Lantic PEF2256 pinmux

2023-09-12 Thread Mark Brown
On Tue, Sep 12, 2023 at 01:04:56PM +0200, Linus Walleij wrote: > On Tue, Sep 12, 2023 at 12:15 PM Herve Codina > wrote: > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +/* > I think SPDX mandates that you start the tag with C99 comments > // SPDX-License-Identifier: GPL-2.0-only Not for

Re: [PATCH] ASoC: fsl: imx-pcm-rpmsg: Add SNDRV_PCM_INFO_BATCH flag

2023-09-11 Thread Mark Brown
On Mon, 11 Sep 2023 14:38:07 +0800, Shengjiu Wang wrote: > The rpmsg pcm device is a device which should support > double buffering. > > Found this issue with pipewire. When there is no > SNDRV_PCM_INFO_BATCH flag in driver, the pipewire will > set headroom to be zero, and because rpmsg pcm

Re: (subset) [PATCH 00/11] add missing of_node_put

2023-09-11 Thread Mark Brown
On Thu, 07 Sep 2023 11:55:10 +0200, Julia Lawall wrote: > Add of_node_put on a break out of an of_node loop. > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [10/11] ASoC: rsnd: add missing of_node_put commit:

Re: [RFC PATCH v2 0/7] Add audio support in v4l2 framework

2023-08-24 Thread Mark Brown
On Thu, Aug 24, 2023 at 07:03:09PM +0200, Takashi Iwai wrote: > Shengjiu Wang wrote: > > But there are several issues: > > 1. Need to create sound cards. ASRC module support multi instances, then > > need to create multi sound cards for each instance. > Hm, why can't it be multiple PCM

Re: [PATCH] spi: fsl-cpm: Properly define and use IO pointers

2023-08-09 Thread Mark Brown
On Wed, 09 Aug 2023 10:54:27 +0200, Christophe Leroy wrote: > Sparse reports several issues with IO pointers. > > Fix it by adding missing __iomem flags and using iowriteXXbe() > generic helpers instead of the powerpc specific out_beXX() ones. > > Applied to

Re: [PATCH -next] ASoC: imx-audio-rpmsg: Remove redundant initialization owner in imx_audio_rpmsg_driver

2023-08-08 Thread Mark Brown
On Tue, 08 Aug 2023 10:17:28 +0800, Li Zetao wrote: > The module_rpmsg_driver() will set "THIS_MODULE" to driver.owner when > register a rpmsg_driver driver, so it is redundant initialization to set > driver.owner in the statement. Remove it for clean code. > > Applied to

Re: [PATCH v2 24/28] pinctrl: Add support for the Lantic PEF2256 pinmux

2023-08-07 Thread Mark Brown
On Mon, Aug 07, 2023 at 03:05:15PM +0200, Linus Walleij wrote: > On Wed, Jul 26, 2023 at 5:04 PM Herve Codina wrote: > > +#include "linux/bitfield.h" > Really? I don't think there is such a file there. > Do you mean and does this even compile? #include "" means "try the local directory first

Re: [PATCH v2 RESEND*3] ASoC: fsl MPC52xx drivers require PPC_BESTCOMM

2023-08-03 Thread Mark Brown
On Thu, Aug 03, 2023 at 11:09:43AM -0700, Randy Dunlap wrote: > On 8/3/23 04:27, Mark Brown wrote: > > On Wed, Aug 02, 2023 at 07:59:41PM -0700, Randy Dunlap wrote: > >> Both SND_MPC52xx_SOC_PCM030 and SND_MPC52xx_SOC_EFIKA select > >> SND_SOC_MPC5200_AC97

Re: [PATCH v2 RESEND*3] ASoC: fsl MPC52xx drivers require PPC_BESTCOMM

2023-08-03 Thread Mark Brown
On Wed, Aug 02, 2023 at 07:59:41PM -0700, Randy Dunlap wrote: > Both SND_MPC52xx_SOC_PCM030 and SND_MPC52xx_SOC_EFIKA select > SND_SOC_MPC5200_AC97. The latter symbol depends on PPC_BESTCOMM, > so the 2 former symbols should also depend on PPC_BESTCOMM since > "select" does not follow any

Re: [PATCH v2 0/3] Update the register list of MICFIL

2023-08-02 Thread Mark Brown
On Wed, 02 Aug 2023 13:21:14 +0800, Chancel Liu wrote: > MICFIL IP is upgraded on i.MX93 platform. Add new registers and new bit > definition. > > changes in v2: > - rename check_version to use_verid to make it more explicit > - rename fsl_micfil_check_version to fsl_micfil_use_verid > > [...]

Re: [RFC PATCH v2 0/7] Add audio support in v4l2 framework

2023-08-02 Thread Mark Brown
On Wed, Aug 02, 2023 at 10:41:43PM +0800, Shengjiu Wang wrote: > Currently the ASRC in ALSA is to connect to another I2S device as > a sound card. But we'd like to the ASRC can be used by user space directly > that user space application can get the output after conversion from ASRC. That sort

Re: [RFC PATCH v2 0/7] Add audio support in v4l2 framework

2023-08-02 Thread Mark Brown
On Wed, Aug 02, 2023 at 08:02:29PM +0800, Shengjiu Wang wrote: > On Wed, Aug 2, 2023 at 7:22 PM Takashi Iwai wrote: > > Well, I personally don't mind to have some audio capability in v4l2 > > layer. But, the only uncertain thing for now is whether this is a > > must-have or not. > Thanks, I

Re: [PATCH] ASoC: fsl_micfil: refactor deprecated strncpy

2023-07-28 Thread Mark Brown
On Thu, 27 Jul 2023 22:26:41 +, Justin Stitt wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings [1]. > > A suitable replacement is `strscpy` [2] due to the fact that it > guarantees NUL-termination on its destination buffer argument which is > _not_ always the case

Re: [RFC PATCH v2 4/7] media: v4l2: Add audio capture and output support

2023-07-28 Thread Mark Brown
On Fri, Jul 28, 2023 at 07:59:33AM +, Tomasz Figa wrote: > On Tue, Jul 25, 2023 at 02:12:17PM +0800, Shengjiu Wang wrote: > > + case VFL_TYPE_AUDIO: > > + name_base = "audio"; > I think it was mentioned before that "audio" could be confusing. Wasn't > there actually some other

Re: [PATCH 1/1] ASoC: fsl: fsl_qmc_audio: Fix snd_pcm_format_t values handling

2023-07-26 Thread Mark Brown
On Wed, 26 Jul 2023 18:16:20 +0200, Herve Codina wrote: > Running sparse on fsl_qmc_audio (make C=1) raises the following warnings: > fsl_qmc_audio.c:387:26: warning: restricted snd_pcm_format_t degrades to > integer > fsl_qmc_audio.c:389:59: warning: incorrect type in argument 1 (different >

Re: [PATCH] ASoC: fsl_spdif: Silence output on stop

2023-07-21 Thread Mark Brown
On Wed, 19 Jul 2023 18:47:29 +0200, Matus Gajdos wrote: > Clear TX registers on stop to prevent the SPDIF interface from sending > last written word over and over again. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC:

Re: [PATCH] ASoC: fsl_spdif: Add support for 22.05 kHz sample rate

2023-07-19 Thread Mark Brown
On Wed, 19 Jul 2023 18:31:53 +0200, Matus Gajdos wrote: > Add support for 22.05 kHz sample rate for TX. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: fsl_spdif: Add support for 22.05 kHz sample rate commit:

Re: [PATCH] ASoC: fsl_sai: Disable bit clock with transmitter

2023-07-18 Thread Mark Brown
On Wed, 12 Jul 2023 14:49:33 +0200, Matus Gajdos wrote: > Otherwise bit clock remains running writing invalid data to the DAC. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: fsl_sai: Disable bit clock with transmitter

Re: [PATCH 0/2] Add support for rpmsg sound card on i.MX93 platform

2023-07-17 Thread Mark Brown
On Fri, 14 Jul 2023 17:29:11 +0800, Chancel Liu wrote: > Support rpmsg sound card on i.MX93 platform. > > Chancel Liu (2): > ASoC: dt-bindings: fsl_rpmsg: Add compatible string for i.MX93 > ASoC: fsl_rpmsg: Add support for i.MX93 platform > >

Re: [PATCH v9 01/42] mm: Rename arch pte_mkwrite()'s to pte_mkwrite_novma()

2023-07-17 Thread Mark Brown
On Mon, Jul 17, 2023 at 03:55:50PM +, Edgecombe, Rick P wrote: > On Fri, 2023-07-14 at 23:57 +0100, Mark Brown wrote: > > The same issue seems to apply with the version that was in -next > > based > > on v6.4-rc4 too. > The version in your branch is not the same as t

Re: [PATCH] ASoC: fsl_sai: Disable bit clock with transmitter

2023-07-17 Thread Mark Brown
On Mon, Jul 17, 2023 at 09:31:38AM -0300, Fabio Estevam wrote: > On Wed, Jul 12, 2023 at 9:53 AM Matus Gajdos wrote: > > > > Otherwise bit clock remains running writing invalid data to the DAC. > > > > Signed-off-by: Matus Gajdos > > Should this contain a Fixes tag so that it could be

Re: [PATCH v9 01/42] mm: Rename arch pte_mkwrite()'s to pte_mkwrite_novma()

2023-07-14 Thread Mark Brown
On Mon, Jun 12, 2023 at 05:10:27PM -0700, Rick Edgecombe wrote: > The x86 Shadow stack feature includes a new type of memory called shadow > stack. This shadow stack memory has some unusual properties, which requires > some core mm changes to function properly. This seems to break

Re: [PATCH] ASoC: imx-pcm-rpmsg: Set PCM hardware parameters separately

2023-07-12 Thread Mark Brown
On Sun, 25 Jun 2023 14:54:12 +0800, Chancel Liu wrote: > Different PCM devices may have different PCM hardware parameters. It > requires PCM hardware parameters set separately if there is more than > one rpmsg sound card. > > Applied to

Re: [PATCH 1/6] media: v4l2: Add audio capture and output support

2023-07-03 Thread Mark Brown
On Mon, Jul 03, 2023 at 03:12:55PM +0200, Hans Verkuil wrote: > My main concern is that these cross-subsystem drivers are a pain to > maintain. So there have to be good reasons to do this. > Also it is kind of weird to have to use the V4L2 API in userspace to > deal with a specific audio

Re: [PATCH 1/6] media: v4l2: Add audio capture and output support

2023-07-03 Thread Mark Brown
On Mon, Jul 03, 2023 at 02:07:10PM +0200, Takashi Iwai wrote: > Shengjiu Wang wrote: > > There is no such memory to memory interface defined in ALSA.  Seems > > ALSA is not designed for M2M cases. > There is no restriction to implement memory-to-memory capture in ALSA > framework. It'd be a

Re: [PATCH 4/6] ASoC: fsl_asrc: Add memory to memory driver

2023-06-30 Thread Mark Brown
On Fri, Jun 30, 2023 at 11:37:29AM +0800, Shengjiu Wang wrote: > On Thu, Jun 29, 2023 at 7:39 PM Mark Brown wrote: > > On Thu, Jun 29, 2023 at 09:37:51AM +0800, Shengjiu Wang wrote: > > > Implement the ASRC memory to memory function using > > > the v4l2 framework,

Re: [PATCH 4/6] ASoC: fsl_asrc: Add memory to memory driver

2023-06-29 Thread Mark Brown
On Thu, Jun 29, 2023 at 09:37:51AM +0800, Shengjiu Wang wrote: > Implement the ASRC memory to memory function using > the v4l2 framework, user can use this function with > v4l2 ioctl interface. > > User send the output and capture buffer to driver and > driver store the converted data to the

Re: [PATCH] ASoC: imx-audmix: check return value of devm_kasprintf()

2023-06-19 Thread Mark Brown
On Wed, 14 Jun 2023 15:15:09 +0300, Claudiu Beznea wrote: > devm_kasprintf() returns a pointer to dynamically allocated memory. > Pointer could be NULL in case allocation fails. Check pointer validity. > Identified with coccinelle (kmerr.cocci script). > > Applied to

Re: [PATCH] ASoC: fsl_sai: Enable BCI bit if SAI works on synchronous mode with BYP asserted

2023-06-02 Thread Mark Brown
On Tue, 30 May 2023 18:30:12 +0800, Chancel Liu wrote: > There's an issue on SAI synchronous mode that TX/RX side can't get BCLK > from RX/TX it sync with if BYP bit is asserted. It's a workaround to > fix it that enable SION of IOMUX pad control and assert BCI. > > For example if TX sync with RX

Re: [PATCH v2 0/2] ASoC: do not include runtime_pm.h if not needed

2023-05-23 Thread Mark Brown
On Wed, 17 May 2023 12:49:01 +0300, Claudiu Beznea wrote: > Series removes the pm_runtime.h inclusion in files where > APIs exported though pm_runtime.h are not used. In case > of files that make use of pm.h which comes form pm_runtime.h > added patch 2/2. > > Changes were built with allmodconfig

Re: [PATCH] ASoC: fsl_sai: MCLK bind with TX/RX enable bit

2023-05-09 Thread Mark Brown
On Fri, 05 May 2023 15:55:22 +0800, Shengjiu Wang wrote: > On i.MX8MP, the sai MCLK is bound with TX/RX enable bit, > which means the TX/RE enable bit need to be enabled then > MCLK can be output on PAD. > > Some codec (for example: WM8962) needs the MCLK output > earlier, otherwise there will be

Re: [PATCH] ASoC: fsl_micfil: Fix error handler with pm_runtime_enable

2023-05-08 Thread Mark Brown
On Mon, 08 May 2023 18:16:36 +0800, Shengjiu Wang wrote: > There is error message when defer probe happens: > > fsl-micfil-dai 30ca.micfil: Unbalanced pm_runtime_enable! > > Fix the error handler with pm_runtime_enable and add > fsl_micfil_remove() for pm_runtime_disable. > > [...] Applied

Re: [PATCH] Revert "ASoC: fsl: remove unnecessary dai_link->platform"

2023-04-19 Thread Mark Brown
On Wed, 19 Apr 2023 18:29:18 +0800, Shengjiu Wang wrote: > This reverts commit 33683cbf49b5412061cb1e4c876063fdef86def4. > > dai_link->platform is needed. The platform component is > "snd_dmaengine_pcm", which is registered from cpu driver, > > If dai_link->platform is not assigned, then

Re: [PATCH] ASoC: fsl: Simplify an error message

2023-04-19 Thread Mark Brown
On Sun, 16 Apr 2023 08:29:34 +0200, Christophe JAILLET wrote: > dev_err_probe() already display the error code. There is no need to > duplicate it explicitly in the error message. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC:

Re: [PATCH] ASoC: fsl_asrc_dma: fix potential null-ptr-deref

2023-04-19 Thread Mark Brown
On Mon, 17 Apr 2023 06:32:42 -0700, Nikita Zhandarovich wrote: > dma_request_slave_channel() may return NULL which will lead to > NULL pointer dereference error in 'tmp_chan->private'. > > Correct this behaviour by, first, switching from deprecated function > dma_request_slave_channel() to

Re: [PATCH] ASoC: fsl_sai: Fix pins setting for i.MX8QM platform

2023-04-19 Thread Mark Brown
On Tue, 18 Apr 2023 17:42:59 +0800, Chancel Liu wrote: > SAI on i.MX8QM platform supports the data lines up to 4. So the pins > setting should be corrected to 4. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: fsl_sai: Fix pins

Re: [PATCH] Revert "ASoC: fsl: remove unnecessary dai_link->platform"

2023-04-19 Thread Mark Brown
On Wed, Apr 19, 2023 at 06:29:18PM +0800, Shengjiu Wang wrote: > This reverts commit 33683cbf49b5412061cb1e4c876063fdef86def4. Please include human readable descriptions of things like commits and issues being discussed in e-mail in your mails, this makes them much easier for humans to read

Re: linux-next: manual merge of the drm tree with the powerpc tree

2023-04-18 Thread Mark Brown
On Tue, Apr 18, 2023 at 11:21:45AM -0700, Nathan Chancellor wrote: > On Fri, Apr 14, 2023 at 05:55:10PM +0100, Mark Brown wrote: > > Done. > Thanks a lot, sorry for not saying it sooner! It looks like this > regressed in next-20230417 and next-20230418 though. Someone sen

Re: [PATCH 1/2] ASoC: fsl_mqs: move of_node_put() to the correct location

2023-04-17 Thread Mark Brown
On Mon, 03 Apr 2023 23:26:47 +0800, Liliang Ye wrote: > of_node_put() should have been done directly after > mqs_priv->regmap = syscon_node_to_regmap(gpr_np); > otherwise it creates a reference leak on the success path. > > To fix this, of_node_put() is moved to the correct location, and change >

Re: [PATCH 2/2] ASoC: fsl_mqs: call pm_runtime_disable() on error path

2023-04-17 Thread Mark Brown
On Mon, Apr 03, 2023 at 11:27:37PM +0800, Liliang Ye wrote: > pm_runtime_disable was missed in cleanup operation, which corresponds to > the earlier call to pm_runtime_enable. This doesn't apply against current code, please check and resend. signature.asc Description: PGP signature

  1   2   3   4   5   6   7   8   9   >