Re: [PATCH v2] perf: libdw support for powerpc [ping]

2017-06-21 Thread Mark Wielaard
On Tue, Jun 20, 2017 at 10:06:35PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Jun 15, 2017 at 01:16:32PM +0200, Mark Wielaard escreveu: > > On Thu, 2017-06-15 at 10:46 +0200, Milian Wolff wrote: > > > Just a quick question: Have you guys applied my recent patch: &

Re: [PATCH v2] perf: libdw support for powerpc [ping]

2017-06-15 Thread Mark Wielaard
On Thu, 2017-06-15 at 10:46 +0200, Milian Wolff wrote: > Just a quick question: Have you guys applied my recent patch: > > commit 5ea0416f51cc93436bbe497c62ab49fd9cb245b6 > Author: Milian Wolff > Date: Thu Jun 1 23:00:21 2017 +0200 > > perf report: Include partial stacks unwound with libdw

Re: [PATCH v2] perf: libdw support for powerpc [ping]

2017-06-13 Thread Mark Wielaard
Hi Ravi, On Mon, 2017-06-12 at 17:28 +0530, Ravi Bangoria wrote: > So, I tested this patch along with Mark's patch[1] on elfutils an looks > like it's not working. Steps on what I did: > > After applying Mark's patch on upstream elfutils: > > $ aclocal > $ autoheader > $ autoconf > $ aut

Re: [PATCH] perf/probe: Search both .eh_frame and .debug_frame sections for probe location

2015-09-24 Thread Mark Wielaard
On Thu, 2015-09-24 at 10:56 +, 平松雅巳 / HIRAMATU,MASAMI wrote: > >I am not too familiar with the code so there might be a reason for > >setting and reusing the pf->cfi to do the search twice. But might it not > >be more clear to just store both pf->cfi_eh and pf->cfi_debug and then > >check both

Re: [PATCH] perf/probe: Search both .eh_frame and .debug_frame sections for probe location

2015-09-24 Thread Mark Wielaard
Hi Hemant, On Thu, 2015-09-24 at 07:46 +0530, Hemant Kumar wrote: > perf probe through debuginfo__find_probes() in util/probe-finder.c > checks for the functions' frame descriptions in either .eh_frame section > of an ELF or the .debug_frame. The check is based on whether either one > of these sec

Re: [PATCH 6/8] Use proper types for do_div

2009-12-09 Thread Mark Wielaard
Hi Anton, On Wed, 2009-12-09 at 19:09 +0300, Anton Vorontsov wrote: > I think this should be fixed by this patch: > > http://sourceware.org/ml/systemtap/2009-q4/msg00800.html > > Can you try it? With this patch I see no new regressions on x86_64. Yes, that fixes everything. Sorry I didn't see t

Re: [PATCH 6/8] Use proper types for do_div

2009-12-09 Thread Mark Wielaard
Hi Anton, On Sat, 2009-11-28 at 01:33 +0300, Anton Vorontsov wrote: > do_div accepts unsigned 64-bit integer type for dividend, signed types > would cause do_div's typecheck fail: > > stat-common.c: In function 'needed_space': > stat-common.c:50: error: comparison of distinct pointer types lacks