Re: [PATCH 1/2] MAINTAINERS: Make cxlflash obsolete

2024-04-24 Thread Martin K. Petersen
> a position to access cxlflash hardware, so remove him from the maintainers > list. > > [...] Applied to 6.10/scsi-queue, thanks! [1/2] MAINTAINERS: Make cxlflash obsolete https://git.kernel.org/mkp/scsi/c/6d97e807c906 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v3] scsi: sg: Avoid race in error handling & drop bogus warn

2024-04-05 Thread Martin K. Petersen
andling & drop bogus warn https://git.kernel.org/mkp/scsi/c/d4e655c49f47 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v3] scsi: sg: Avoid race in error handling & drop bogus warn

2024-04-04 Thread Martin K. Petersen
Alexander, > commit 27f58c04a8f4 ("scsi: sg: Avoid sg device teardown race") > introduced an incorrect WARN_ON_ONCE() and missed a sequence where > sg_device_destroy() was used after scsi_device_put(). Applied to 6.9/scsi-fixes, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: (subset) [PATCH 0/9] enabled -Wformat-truncation for clang

2024-04-01 Thread Martin K. Petersen
t; "make W=1". > > Unfortunately, gcc produces a lot more warnings when the option > is enabled, so it's not yet possible to turn it on both both > compilers. > > [...] Applied to 6.9/scsi-fixes, thanks! [7/9] scsi: mylex: fix sysfs buffer lengths https://git.kernel.org/mkp/scs

Re: (subset) [PATCH 00/42] Fix coccicheck warnings

2024-02-05 Thread Martin K. Petersen
git.kernel.org/mkp/scsi/c/01105c23de42 [27/42] drivers/scsi/isci: Convert snprintf to sysfs_emit https://git.kernel.org/mkp/scsi/c/5fbf37e53091 [34/42] drivers/scsi/pm8001: Convert snprintf to sysfs_emit https://git.kernel.org/mkp/scsi/c/8179041f801d -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: ibmvscsi: replace deprecated strncpy with strscpy

2023-12-13 Thread Martin K. Petersen
t;%s\n", > |hostdata->madapter_info.partition_name); > > [...] Applied to 6.8/scsi-queue, thanks! [1/1] scsi: ibmvscsi: replace deprecated strncpy with strscpy https://git.kernel.org/mkp/scsi/c/712b3f43ba0e -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: ibmvfc: replace deprecated strncpy with strscpy

2023-12-13 Thread Martin K. Petersen
erty names from > which they are derived are also NUL-terminated. > > [...] Applied to 6.8/scsi-queue, thanks! [1/1] scsi: ibmvfc: replace deprecated strncpy with strscpy https://git.kernel.org/mkp/scsi/c/a9baa16b4fc1 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: ipr: Remove obsolete check for old CPUs

2023-12-13 Thread Martin K. Petersen
t; The most recent CPU it checks for is Power4+ which was removed in commit > 471d7ff8b51b ("powerpc/64s: Remove POWER4 support"). > > [...] Applied to 6.8/scsi-queue, thanks! [1/1] scsi: ipr: Remove obsolete check for old CPUs https://git.kernel.org/mkp/scsi/c/84e46978b91

Re: [PATCH] scsi: ibmvscsi: replace deprecated strncpy with strscpy

2023-12-05 Thread Martin K. Petersen
to 6.8/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: ibmvfc: replace deprecated strncpy with strscpy

2023-12-05 Thread Martin K. Petersen
to me too. > > Reviewed-by: Kees Cook Applied to 6.8/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: ipr: Remove obsolete check for old CPUs

2023-12-05 Thread Martin K. Petersen
Michael, > The IPR driver has a routine to check whether it's running on certain > CPU versions and if so whether the adapter is supported on that CPU. Applied to 6.8/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/6] x86: Use PCI_HEADER_TYPE_* instead of literals

2023-12-05 Thread Martin K. Petersen
Bjorn, > So I kept these in the PCI tree: > > 420ac76610d7 ("scsi: lpfc: Use PCI_HEADER_TYPE_MFD instead of literal") I merged this without seeing your note but I haven't pushed yet so I'll just drop the commit. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: ibmvfc: Use 'unsigned int' for single-bit bitfields in 'struct ibmvfc_host'

2023-10-16 Thread Martin K. Petersen
https://git.kernel.org/mkp/scsi/c/78882c7657bb -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: ibmvfc: Use 'unsigned int' for single-bit bitfields in 'struct ibmvfc_host'

2023-10-13 Thread Martin K. Petersen
version] > 650 | vhost->reinit = 1; > | ^ ~ > Applied to 6.7/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: (subset) [PATCH 00/17] -Wmissing-prototype warning fixes

2023-08-24 Thread Martin K. Petersen
scsi-queue, thanks! [07/17] scsi: qlogicpti: mark qlogicpti_info() static https://git.kernel.org/mkp/scsi/c/71cc486335c4 [11/17] scsi: gvp11: remove unused gvp11_setup() function https://git.kernel.org/mkp/scsi/c/bfaa4a0ce1bb -- Martin K. Petersen Oracle Linux Engineering

Re: (subset) [PATCH 00/35] Documentation: correct lots of spelling errors (series 1)

2023-02-14 Thread Martin K. Petersen
patches are based on linux-next-20230125. > > [...] Applied to 6.3/scsi-queue, thanks! [28/35] Documentation: target: correct spelling https://git.kernel.org/mkp/scsi/c/c57ac5748be5 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] ibmvfc: Avoid path failures during live migration

2022-11-07 Thread Martin K. Petersen
to 6.1/scsi-fixes, thanks! [1/1] ibmvfc: Avoid path failures during live migration https://git.kernel.org/mkp/scsi/c/62fa3ce05d5d -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v3 0/3] phase out CONFIG_VIRT_TO_BUS

2022-07-07 Thread Martin K. Petersen
obsolete driver https://git.kernel.org/mkp/scsi/c/b04e75a4a8a8 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v3 0/3] phase out CONFIG_VIRT_TO_BUS

2022-06-27 Thread Martin K. Petersen
- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] ibmvfc: multiqueue bug fixes

2022-06-16 Thread Martin K. Petersen
https://git.kernel.org/mkp/scsi/c/aeaadcde1a60 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] ibmvscsis: increase INITIAL_SRP_LIMIT to 1024

2022-03-29 Thread Martin K. Petersen
to 5.18/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 00/16] Remove usage of the deprecated "pci-dma-compat.h" API

2022-01-18 Thread Martin K. Petersen
f61e0 [13/16] scsi: mptsas: Use dma_alloc_coherent() in mptsas_exp_repmanufacture_info() https://git.kernel.org/mkp/scsi/c/7a960b3a5e37 [14/16] scsi: mptsas: Use dma_alloc_coherent() https://git.kernel.org/mkp/scsi/c/76a334d756c5 [15/16] scsi: mptctl: Use dma_alloc_coherent() https://git.kernel.o

Re: [PATCH 00/16] Remove usage of the deprecated "pci-dma-compat.h" API

2022-01-10 Thread Martin K. Petersen
Christophe, > This serie axes all the remaining usages of the deprecated > "pci-dma-compat.h" API. Applied patches 10-15 to 5.17/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] ibmvscsi: use GFP_KERNEL with dma_alloc_coherent in initialize_event_pool

2021-10-20 Thread Martin K. Petersen
ry. > > Fix by passing GFP_KERNEL explicitly to dma_alloc_coherent(). > > [...] Applied to 5.16/scsi-queue, thanks! [1/1] ibmvscsi: use GFP_KERNEL with dma_alloc_coherent in initialize_event_pool https://git.kernel.org/mkp/scsi/c/3319a8ba82b9 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] ibmvscsi: use GFP_KERNEL with dma_alloc_coherent in initialize_event_pool

2021-10-16 Thread Martin K. Petersen
Michael, > It's marked "Changes Requested" here: Not sure why. Applied to 5.16/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: ibmvfc: Stop using scsi_cmnd.tag

2021-08-24 Thread Martin K. Petersen
On Tue, 17 Aug 2021 21:43:37 +0800, John Garry wrote: > Use scsi_cmd_to_rq(scsi_cmnd)->tag in preference to scsi_cmnd.tag. > > > > Applied to 5.15/scsi-queue, thanks! [1/1] scsi: ibmvfc: Stop using scsi_cmnd.tag https://git.kernel.org/mkp/scsi/c/6a036ce0e25c --

Re: [PATCH] scsi: ibmvfc: Stop using scsi_cmnd.tag

2021-08-17 Thread Martin K. Petersen
John, > Use scsi_cmd_to_rq(scsi_cmnd)->tag in preference to scsi_cmnd.tag. Applied to 5.15/scsi-staging and rebased for bisectability. Just to be picky it looks like there's another scsi_cmmd tag lurking in qla1280.c but it's sitting behind an #ifdef DEBUG_QLA1280. -- Martin K. Pe

Re: [PATCH] ibmvfc: fix command state accounting and stale response detection

2021-07-28 Thread Martin K. Petersen
si-fixes, thanks! [1/1] ibmvfc: fix command state accounting and stale response detection https://git.kernel.org/mkp/scsi/c/73bfdf707d01 -- Martin K. Petersen Oracle Linux Engineering

Re: switch the block layer to use kmap_local_page v2

2021-06-16 Thread Martin K. Petersen
Christoph, > this series switches the core block layer code and all users of the > existing bvec kmap helpers to use kmap_local_page. Drivers that > currently use open coded kmap_atomic calls will converted in a follow > on series. Looks OK to me. Reviewed-by: Martin K. Petersen

Re: [PATCH] ibmvfc: Fix invalid state machine BUG_ON

2021-04-15 Thread Martin K. Petersen
he reset / reenable > state until we've finished processing the reset or reenable. Applied to 5.13/scsi-queue, thanks! [1/1] ibmvfc: Fix invalid state machine BUG_ON https://git.kernel.org/mkp/scsi/c/15cfef8623a4 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] ibmvfc: Fix invalid state machine BUG_ON

2021-04-12 Thread Martin K. Petersen
..] Applied to 5.13/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: ibmvscsi: delete the useless casting value returned

2021-03-29 Thread Martin K. Petersen
https://git.kernel.org/mkp/scsi/c/0d556a21a9da -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 00/36] [Set 4] Rid W=1 warnings in SCSI

2021-03-24 Thread Martin K. Petersen
es https://git.kernel.org/mkp/scsi/c/841d7df0d416 [34/36] scsi: ibmvscsi: ibmvfc: Fix a bunch of misdocumentation https://git.kernel.org/mkp/scsi/c/dd9c77297148 [35/36] scsi: ibmvscsi_tgt: ibmvscsi_tgt: Remove duplicate section 'NOTE' https://git.kernel.org/mkp/scsi/c/

Re: [PATCH 0/2] Fix EH race and MQ support

2021-03-24 Thread Martin K. Petersen
race in ibmvfc_wait_for_ops https://git.kernel.org/mkp/scsi/c/8b1c9b202549 [2/2] ibmvfc: make ibmvfc_wait_for_ops MQ aware https://git.kernel.org/mkp/scsi/c/62fc2661482b -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 00/36] [Set 4] Rid W=1 warnings in SCSI

2021-03-18 Thread Martin K. Petersen
Lee, > This set is part of a larger effort attempting to clean-up W=1 kernel > builds, which are currently overwhelmingly riddled with niggly little > warnings. Applied to 5.13/scsi-staging, thanks! I fixed a few little things. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: ibmvfc: Switch to using the new API kobj_to_dev()

2021-03-16 Thread Martin K. Petersen
https://git.kernel.org/mkp/scsi/c/18c2a59a4190 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: ibmvfc: Switch to using the new API kobj_to_dev()

2021-03-15 Thread Martin K. Petersen
kobj_to_dev() https://git.kernel.org/mkp/scsi/c/18c2a59a4190 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] ibmvfc: free channel_setup_buf during device tear down

2021-03-15 Thread Martin K. Petersen
of a hotplug remove. > > Fix this issue by freeing the buffer allocation in ibmvfc_free_mem(). Applied to 5.12/scsi-fixes, thanks! [1/1] ibmvfc: free channel_setup_buf during device tear down https://git.kernel.org/mkp/scsi/c/febb0cc847e7 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v5 0/5] ibmvfc: hard reset fixes

2021-03-03 Thread Martin K. Petersen
perform channel enquiry after LPM https://git.kernel.org/mkp/scsi/c/f4c5e949056d -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH][next] scsi: ibmvfc: Fix spelling mistake "succeded" -> "succeeded"

2021-01-22 Thread Martin K. Petersen
On Mon, 18 Jan 2021 11:13:46 +, Colin King wrote: > There is a spelling mistake in a ibmvfc_dbg debug message. Fix it. Applied to 5.12/scsi-queue, thanks! [1/1] scsi: ibmvfc: Fix spelling mistake "succeded" -> "succeeded" https://git.kernel.org/mkp/scsi/c/

Re: [PATCH v5 00/21] ibmvfc: initial MQ development/enablement

2021-01-20 Thread Martin K. Petersen
ibmvfc: enable MQ and set reasonable defaults https://git.kernel.org/mkp/scsi/c/9000cb998bcf [21/21] ibmvfc: provide modules parameters for MQ settings https://git.kernel.org/mkp/scsi/c/032d1900869f -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH][next] scsi: ibmvfc: Fix spelling mistake "succeded" -> "succeeded"

2021-01-20 Thread Martin K. Petersen
Colin, > There is a spelling mistake in a ibmvfc_dbg debug message. Fix it. Applied to 5.12/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v5 00/21] ibmvfc: initial MQ development/enablement

2021-01-14 Thread Martin K. Petersen
s to associated VIOS HW backed channels. Applied to 5.12/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2 0/5] ibmvfc: MQ preparatory locking work

2021-01-12 Thread Martin K. Petersen
vfc: complete commands outside the host/queue lock https://git.kernel.org/mkp/scsi/c/1f4a4a19508d [5/5] ibmvfc: relax locking around ibmvfc_queuecommand https://git.kernel.org/mkp/scsi/c/654080d02edb -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2 0/5] ibmvfc: MQ preparatory locking work

2021-01-07 Thread Martin K. Petersen
; from the host lock reducing lock contention while also relaxing > locking for submissions and completions to simply the list lock of the > queue in question. Applied to 5.12/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] ibmvfc: fix missing cast of ibmvfc_event pointer to u64 handle

2021-01-07 Thread Martin K. Petersen
e] val > ibmvfc.c:2375:36: sparse: got struct ibmvfc_event *[assigned] evt > > [...] Applied to 5.11/scsi-fixes, thanks! [1/1] ibmvfc: fix missing cast of ibmvfc_event pointer to u64 handle https://git.kernel.org/mkp/scsi/c/901d01c8e50c -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2 4/5] ibmvfc: complete commands outside the host/queue lock

2021-01-05 Thread Martin K. Petersen
l patches. thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v3 0/6] ibmvfc: Protocol definition updates and new targetWWPN Support

2020-11-23 Thread Martin K. Petersen
kp/scsi/c/5a9d16f71c26 [5/6] scsi: ibmvfc: Add support for target_wwpn field in v2 MADs and vfcFrame https://git.kernel.org/mkp/scsi/c/ebc7c74bd2dc [6/6] scsi: ibmvfc: Advertise client support for targetWWPN using v2 commands https://git.kernel.org/mkp/scsi/c/e4af87b7079e -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/3] ibmvfc: byte swap login_buf.resp values in attribute show functions

2020-11-23 Thread Martin K. Petersen
emove trailing semicolon https://git.kernel.org/mkp/scsi/c/4e0716199ab6 [3/3] scsi: ibmvfc: Use correlation token to tag commands https://git.kernel.org/mkp/scsi/c/2aa0102c6688 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v3 0/6] ibmvfc: Protocol definition updates and new targetWWPN Support

2020-11-19 Thread Martin K. Petersen
and exposing > the capability to the VIOS. This targetWWPN support is a prerequisuite > for upcoming channelization/MQ support. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/3] ibmvfc: byte swap login_buf.resp values in attribute show functions

2020-11-19 Thread Martin K. Petersen
staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/6] ibmvfc: byte swap login_buf.resp values in attribute show functions

2020-11-16 Thread Martin K. Petersen
judgment to optimize for readability. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] ibmvfc: add new fields for version 2 of several MADs

2020-10-29 Thread Martin K. Petersen
Tyrel, > I'm going to have to ask that this patch be unstaged. Done! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] ibmvfc: add new fields for version 2 of several MADs

2020-10-26 Thread Martin K. Petersen
ising client > support for targetWWPN with the VIOS. This latter capability flag will > be required for future clients capable of requesting multiple hardware > queues from the host adapter. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] ibmvscsi: fix race potential race after loss of transport

2020-10-26 Thread Martin K. Petersen
Tyrel, > After a loss of tranport due to an adatper migration or > crash/disconnect from the host partner there is a tiny window where we > can race adjusting the request_limit of the adapter. Applied to 5.10/scsi-fixes, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] ibmvfc: Protect vhost->task_set increment by the host lock

2020-09-29 Thread Martin K. Petersen
/git.kernel.org/mkp/scsi/c/2584e5aef87a -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] ibmvfc: Protect vhost->task_set increment by the host lock

2020-09-22 Thread Martin K. Petersen
ly small, since this > should all be done in a single threaded loop from the discovery > thread, but let's fix it up anyway to be safe. Applied to 5.10/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] ibmvfc: Avoid link down on FS9100 canister reboot

2020-09-21 Thread Martin K. Petersen
rder to get the VIOS and client LPAR in sync. > > [...] Applied to 5.10/scsi-queue, thanks! [1/1] scsi: ibmvfc: Avoid link down on FS9100 canister reboot https://git.kernel.org/mkp/scsi/c/4b29cb6197d9 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] ibmvfc: Avoid link down on FS9100 canister reboot

2020-09-15 Thread Martin K. Petersen
Brian, > When a canister on a FS9100, or similar storage, running in NPIV mode, > is rebooted, its WWPNs will fail over to another canister. [...] Applied to 5.10/scsi-staging, thanks! I fixed a bunch of checkpatch warnings. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: ibmvfc: Fix error return in ibmvfc_probe()

2020-09-15 Thread Martin K. Petersen
Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: ibmvfc: Fix error return in ibmvfc_probe()

2020-09-09 Thread Martin K. Petersen
Jing, > Fix to return error code PTR_ERR() from the error handling case instead > of 0. Applied to 5.10/scsi-staging. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 00/29] treewide: Convert comma separated statements

2020-09-08 Thread Martin K. Petersen
b: zstd: Avoid comma separated statements (no commit info) [27/29] ipv6: fib6: Avoid comma separated statements (no commit info) [28/29] sunrpc: Avoid comma separated statements (no commit info) [29/29] tools: Avoid comma separated statements (no commit info) --

Re: [PATCH v3 1/2] scsi: ibmvfc: use compiler attribute defines instead of __attribute__()

2020-09-08 Thread Martin K. Petersen
Tyrel, > Update ibmvfc.h structs to use the preferred __packed and __aligned() > attribute macros defined in include/linux/compiler_attributes.h in place > of __attribute__(). Applied 1+2 to my 5.10 staging tree. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] scsi: ibmvfc: interface updates for future FPIN and MQ support

2020-09-02 Thread Martin K. Petersen
Tyrel, > Fixup complier errors from neglected commit --amend Bunch of formatting-related checkpatch warnings. Please fix. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 00/20] Documentation: eliminate duplicated words

2020-07-08 Thread Martin K. Petersen
On Tue, 7 Jul 2020 11:03:54 -0700, Randy Dunlap wrote: > Drop doubled words in various parts of Documentation/. > > [...] Applied to 5.9/scsi-queue, thanks! [17/20] scsi: advansys: docs: Eliminate duplicated word https://git.kernel.org/mkp/scsi/c/3010dfb0b77c -- Martin K.

Re: [PATCH] scsi: target/sbp: remove firewire SBP target driver

2020-06-16 Thread Martin K. Petersen
ing them back if somebody uses them or - even better - are willing to step up and maintain them. I don't particularly like the notion of a driver being orphaned because all that really means is that the driver transitions from being (at least partially) somebody else's problem to being mine

Re: [PATCH] scsi: target/sbp: remove firewire SBP target driver

2020-06-16 Thread Martin K. Petersen
ch any of that again. I could understand an objection if we were to entertain removing sbp2. But really, how many people are setting up FireWire targets? -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 00/17] spelling.txt: /decriptors/descriptors/

2020-06-15 Thread Martin K. Petersen
ith an addition in > scripts/spelling.txt so it shouldn't re-appear ;-) > > [...] Applied to 5.9/scsi-queue, thanks! [06/17] scsi: Fix trivial spelling https://git.kernel.org/mkp/scsi/c/0a19a725c0ed -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] ibmvscsi: don't send host info in adapter info MAD after LPM

2020-06-09 Thread Martin K. Petersen
result after Live Partition Migration > (LPM) we erroneously report the hosts info as our own. Applied to 5.8/scsi-queue, thanks! [1/1] scsi: ibmvscsi: Don't send host info in adapter info MAD after LPM https://git.kernel.org/mkp/scsi/c/4919b33b63c8 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH -next] scsi: ibmvscsi: Make some functions static

2020-05-26 Thread Martin K. Petersen
mvscsi_module_exit' was not declared. Should it be static? Applied to 5.8/scsi-queue, thanks! [1/1] scsi: ibmvscsi: Make some functions static https://git.kernel.org/mkp/scsi/c/1f93ad177d24 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] ibmvfc: don't send implicit logouts prior to NPIV login

2020-04-27 Thread Martin K. Petersen
g to a BUG assert. Applied to 5.7/scsi-fixes, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] ibmvscsi: fix WARN_ON during event pool release

2020-04-27 Thread Martin K. Petersen
scsi/c/cff6a5746645 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: ibmvfc: Mark expected switch fall-throughs

2019-08-07 Thread Martin K. Petersen
Gustavo, > Mark switch cases where we are expecting to fall through. Applied to 5.4/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] ibmvfc: fix WARN_ON during event pool release

2019-07-24 Thread Martin K. Petersen
Tyrel, > While removing an ibmvfc client adapter a WARN_ON like the following > WARN_ON is seen in the kernel log: Applied to 5.3/scsi-fixes, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v3] scsi: ibmvscsi: Don't use rc uninitialized in ibmvscsi_do_work

2019-06-04 Thread Martin K. Petersen
scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2 1/3] ibmvscsi: Wire up host_reset() in the drivers scsi_host_template

2019-05-29 Thread Martin K. Petersen
Tyrel, > Wire up the host_reset function in our driver_template to allow a user > requested adpater reset via the host_reset sysfs attribute. Series applied to 5.3/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/4] ibmvfc: Remove "failed" from logged errors

2019-03-27 Thread Martin K. Petersen
s to whether a command was > successfully cancelled. The following real log message for example it > is unclear if the transaction was actaully cancelled. Applied to 5.1/scsi-fixes. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/2] ibmvscsi: Protect ibmvscsi_head from concurrent modificaiton

2019-03-20 Thread Martin K. Petersen
ls > to prevent concurrent updates as is done similarly in the ibmvfc > driver and ipr driver. Applied to 5.1/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 2/2] ibmvscsi: Fix empty event pool access during host removal

2019-03-20 Thread Martin K. Petersen
NULL pointer > dereference as seen here: Applied to 5.1/scsi-fixes. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: cxlflash: Prevent deadlock when adapter probe fails

2019-02-04 Thread Martin K. Petersen
Vaibhav, > Presently when an error is encountered during probe of the cxlflash > adapter, a deadlock is seen with cpu thread stuck inside > cxlflash_remove(). Below is the trace of the deadlock as logged by > khungtaskd: Applied to 5.0/scsi-fixes, thanks! -- Martin K. Petersen

Re: [PATCH 0/7] Miscellaneous patches and bug fixes

2018-05-18 Thread Martin K. Petersen
Uma, > This patch series adds few improvements to the cxlflash driver and it > also contains couple of bug fixes. Applied to 4.18/scsi-queue, thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v3 00/41] cxlflash: OCXL transport support and miscellaneous fixes

2018-03-28 Thread Martin K. Petersen
le to ensure proper zeroday coverage for all these commits. I have started a 4.18/scsi-queue branch to hold this series for now. The 4.18 branch will be rebased once 4.17rc1 is out in a few weeks. Your changes won't show up in for-next until then either. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [trivial PATCH V2] treewide: Align function definition open/close braces

2018-03-21 Thread Martin K. Petersen
Joe, > Some functions definitions have either the initial open brace and/or > the closing brace outside of column 1. > > Move those braces to column 1. drivers/scsi and drivers/message/fusion parts look fine. Acked-by: Martin K. Petersen <martin.peter...@oracle.com> --

Re: [PATCH v2 00/38] cxlflash: OCXL transport support

2018-03-06 Thread Martin K. Petersen
sting > core driver that communicates with the AFU. This one has been sitting for a week without any reviews. Andrew, when will you have time to take a look? Being a pretty big chunk of code, I would like to merge it sooner rather than later. Or we can postpone until 4.18, of course. -- Mar

Re: [PATCH] ibmvfc: fix misdefined reserved field in ibmvfc_fcp_rsp_info

2018-01-30 Thread Martin K. Petersen
always being reported as zero by the > driver. Applied to 4.16/scsi-fixes, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/6] cxlflash: Miscellaneous patches

2018-01-08 Thread Martin K. Petersen
Uma, > This patch series contains miscellaneous fixes. The first patch fixes > a bug while the rest improve the code structure and prepare the code > for future enhancements. Added stable tag to first patch and applied series to 4.16/scsi-queue. Thank you! -- Martin K. Petersen

Re: [trivial PATCH] treewide: Align function definition open/close braces

2017-12-18 Thread Martin K. Petersen
Joe, > Some functions definitions have either the initial open brace and/or > the closing brace outside of column 1. > > Move those braces to column 1. SCSI bits look OK. Acked-by: Martin K. Petersen <martin.peter...@oracle.com> -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: ibmvscsi: Convert timers to use timer_setup()

2017-10-31 Thread Martin K. Petersen
Kees, > In preparation for unconditionally passing the struct timer_list > pointer to all timer callbacks, switch to using the new timer_setup() > and from_timer() to pass the timer pointer explicitly. Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com> -- Mar

Re: [PATCH 0/3] cxlflash: Miscellaneous fixes

2017-10-31 Thread Martin K. Petersen
Uma, > This patch series contains miscellaneous fixes. All three patches resolve > minor issues. > > This series is intended for 4.15 and is bisectable. Applied to 4.15/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/3] cxlflash: Miscellaneous fixes

2017-08-25 Thread Martin K. Petersen
.14/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [BUG][bisected 270065e] linux-next fails to boot on powerpc

2017-08-21 Thread Martin K. Petersen
fore I submit, as it will impact much more than > just this case. I agree. In this case where a command is not supported, a check condition would be a better way to signal the failure to the SCSI midlayer. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] ipr: Set no_report_opcodes for RAID arrays

2017-08-21 Thread Martin K. Petersen
Brian, > Since ipr RAID arrays do not support the MAINTENANCE_IN / > MI_REPORT_SUPPORTED_OPERATION_CODES, set no_report_opcodes to prevent > it from being sent. Applied to 4.13/scsi-fixes. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] ipr: Fix scsi-mq lockdep issue

2017-08-07 Thread Martin K. Petersen
Brian, > Fixes the following lockdep warning that can occur when scsi-mq is > enabled with ipr due to ipr calling scsi_unblock_requests from irq > context. The fix is to move the call to scsi_unblock_requests to ipr's > existing workqueue. Applied to 4.13/scsi-fixes. Thank you!

Re: [PATCH] scsi: ibmvfc: constify dev_pm_ops structures.

2017-07-01 Thread Martin K. Petersen
Arvind, > dev_pm_ops are not supposed to change at runtime. All functions > working with dev_pm_ops provided by work with const > dev_pm_ops. So mark the non-const structs as const. Applied to 4.13/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: ibmvscsi: constify dev_pm_ops structures.

2017-07-01 Thread Martin K. Petersen
Arvind, > dev_pm_ops are not supposed to change at runtime. All functions > working with dev_pm_ops provided by work with const > dev_pm_ops. So mark the non-const structs as const. Applied to 4.13/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/3] cxlflash: Minor fix and EH refactoring

2017-07-01 Thread Martin K. Petersen
Matthew, > This small series fixes a recently injected double free and also > includes two patches to refactor the host and reset handlers to ease > the burden of making this driver compatible with an updated SCSI EH > framework. Applied to 4.13/scsi-queue. Thanks! -- Martin

Re: [PATCH 00/17] cxlflash: LUN provisioning support and miscellaneous fixes

2017-06-26 Thread Martin K. Petersen
Uma, > This patch series contains miscellaneous fixes and several > enhancements such as LUN provisioning support, WS16 unmap and AFU > debug capabilities. Applied to 4.13/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: ibmvfc: don't check for failure from mempool_alloc()

2017-04-18 Thread Martin K. Petersen
NeilBrown <ne...@suse.com> writes: > mempool_alloc() cannot fail when passed GFP_NOIO or any other gfp > setting that is permitted to sleep. So remove this pointless code. Applied to 4.12/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 00/17] cxlflash: Enhancements and miscellaneous fixes

2017-04-13 Thread Martin K. Petersen
Uma, > This patch series contains miscellaneous patches and adds 4 port > device support. This series also includes patches to improve > performance of the driver in the legacy IO path. Applied to 4.12/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] cxlflash: Enable PCI device ID for future IBM CXL Flash AFU

2017-02-20 Thread Martin K. Petersen
>>>>> "Uma" == Uma Krishnan <ukri...@linux.vnet.ibm.com> writes: Uma> From: "Matthew R. Ochs" <mro...@linux.vnet.ibm.com> Add support for Uma> a future IBM Coherent Accelerator (CXL) flash AFU with an ID of Uma> 0x0624. Applied to 4.

  1   2   >