^~~
./arch/arm64/include/asm/jump_label.h:32:2: note: in expansion of macro
'asm_volatile_goto'
asm_volatile_goto(
^~~~~
Signed-off-by: Masahiro Yamada
---
Changes in v3: None
Changes in v2:
- split into a separate patch
arch/arm64/include/asm/cpufeature.h | 4 ++-
y improves the "Kernel hacking" Kconfig menu as
e61aca5158a8 ("Merge branch 'kconfig-diet' from Dave Hansen') suggested;
this config option would be a good fit in the "compiler option" menu.
Signed-off-by: Masahiro Yamada
---
Changes in v2:
- split into a separate patch
-mips.o:sc-mips.c:(.text.unlikely+0x44): more undefined
references to `mips_gcr_base'
Signed-off-by: Masahiro Yamada
---
Changes in v2:
- new patch
arch/mips/include/asm/bitops.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/include/asm/bitops.h b/arch/mips/include/asm
-by: Masahiro Yamada
---
Changes in v2:
- new patch
arch/powerpc/mm/tlb-radix.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/powerpc/mm/tlb-radix.c b/arch/powerpc/mm/tlb-radix.c
index a2b2848f0ae3..14ff414d1545 100644
--- a/arch/powerpc/mm/tlb-radix.c
+++ b/arch
ta_access);
~~~
Signed-off-by: Masahiro Yamada
---
Changes in v2:
- split into a separate patch
drivers/mtd/nand/raw/vf610_nfc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/vf610_nfc.c b/drivers/mtd/nand/raw/vf610_nfc.c
index a66
: error: asm operand 3 probably doesn't match
constraints [-Werror]
asm volatile(PPC_TLBIEL(%0, %4, %3, %2, %1)
^~~
arch/powerpc/mm/tlb-radix.c:104:2: error: impossible constraint in 'asm'
Signed-off-by: Masahiro Yamada
---
Changes in v2:
- split into a separate patch
arch/powerpc/mm/tlb
setup_machine_tags() to the function .init.text:early_print()
The function setup_machine_tags() references
the function __init early_print().
This is often because setup_machine_tags lacks a __init
annotation or the annotation of early_print is wrong.
Signed-off-by: Masahiro Yamada
---
Changes in v2
from the
function .prom_getproplen() to the function .init.text:.call_prom()
The function .prom_getproplen() references
the function __init .call_prom().
This is often because .prom_getproplen lacks a __init
annotation or the annotation of .call_prom is wrong.
Signed-off-by: Masahiro Yamada
Major changes in v2:
- Eliminate more errors and warnings
- Delete 'depends on !MIPS'
- Split into separate patches
Arnd Bergmann (1):
ARM: prevent tracing IPI_CPU_BACKTRACE
Masahiro Yamada (10):
arm64: mark (__)cpus_have_const_cap as __always_inline
MIPS: mark mult_sh_align_mod
v3.17
Signed-off-by: Arnd Bergmann
[yamada.masah...@socionext.com: rebase on v5.0-rc1]
Signed-off-by: Masahiro Yamada
---
This is a long-standing issue, and
Arnd posted this patch two years ago:
http://lists.infradead.org/pipermail/linux-arm-kernel/2016-February/409393.html
It is no longer ap
':
./arch/s390/include/asm/cpacf.h:170:2: warning: asm operand 3 probably doesn't
match constraints
asm volatile(
^~~
./arch/s390/include/asm/cpacf.h:170:2: error: impossible constraint in 'asm'
Signed-off-by: Masahiro Yamada
---
Changes in v2:
- split into a separate patch
arch/s390
volatile(
^~~
arch/mips/kernel/cpu-bugs64.c:33:2: error: impossible constraint in 'asm'
asm volatile(
^~~
Signed-off-by: Masahiro Yamada
---
Changes in v2:
- split into a separate patch
arch/mips/kernel/cpu-bugs64.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch
^~~
./arch/arm64/include/asm/jump_label.h:32:2: note: in expansion of macro
'asm_volatile_goto'
asm_volatile_goto(
^~~~~
Signed-off-by: Masahiro Yamada
---
Changes in v2:
- split into a separate patch
arch/arm64/include/asm/cpufeature.h | 4 ++--
1 file changed
Hi Joe,
On Wed, Mar 27, 2019 at 2:33 AM Joe Lawrence wrote:
>
> On Tue, Mar 26, 2019 at 02:29:47PM +0900, Masahiro Yamada wrote:
> > On Tue, Mar 26, 2019 at 1:05 AM Joe Lawrence
> > wrote:
> > >
> > > CC_FLAGS_FTRACE may contain trailing whitespace t
\
- if [ "$(findstring $(CC_FLAGS_FTRACE),$(_c_flags))" = \
-"$(CC_FLAGS_FTRACE)" ]; then \
- $(sub_cmd_record_mcount)\
- fi
+cmd_record_mcount = $(if $(findstring $(CC_FLAGS_FTRACE),$(_c_flags)),\
+ $(sub_cmd_record_mcount))
endif # CC_USING_RECORD_MCOUNT
endif # CONFIG_FTRACE_MCOUNT_RECORD
--
Best Regards
Masahiro Yamada
On Mon, Mar 25, 2019 at 4:33 PM Arnd Bergmann wrote:
>
> On Mon, Mar 25, 2019 at 7:11 AM Masahiro Yamada
> wrote:
> > On Wed, Mar 20, 2019 at 10:34 PM Arnd Bergmann wrote:
> > >
> > > On Wed, Mar 20, 2019 at 10:41 AM Arnd Bergmann wrote:
> > > >
&
fined in discarded section
> > `exit.text' of drivers/char/ipmi/ipmi_msghandler.o
>
> Wouldn't it be useful to activate -Winline gcc warning to ease finding
> out problematic usage of inline keyword ?
Yes, it is useful to find out
which function is causing the error.
Thanks for the tip.
--
Best Regards
Masahiro Yamada
Hi Heiko,
On Thu, Mar 21, 2019 at 5:02 PM Heiko Carstens
wrote:
>
> On Wed, Mar 20, 2019 at 03:20:27PM +0900, Masahiro Yamada wrote:
> > Commit 60a3cdd06394 ("x86: add optimized inlining") introduced
> > CONFIG_OPTIMIZE_INLINING, but it has been available on
On Mon, Mar 25, 2019 at 3:10 PM Masahiro Yamada
wrote:
>
> Hi Arnd,
>
>
>
>
> On Wed, Mar 20, 2019 at 10:34 PM Arnd Bergmann wrote:
> >
> > On Wed, Mar 20, 2019 at 10:41 AM Arnd Bergmann wrote:
> > >
> > > I've added your patch to my randcon
uot;no ATAGS support: can't continue\n");
>
I do not know why to reproduce it,
but is "__init __noreturn" more sensible than
"__always_inline" here?
--
Best Regards
Masahiro Yamada
Hi Arnd,
On Wed, Mar 20, 2019 at 10:05 PM Arnd Bergmann wrote:
>
> On Wed, Mar 20, 2019 at 11:19 AM Masahiro Yamada
> wrote:
> > On Wed, Mar 20, 2019 at 6:39 PM Arnd Bergmann wrote:
> > >
> > > On Wed, Mar 20, 2019 at 7:41 AM Masahiro Yamada
> > >
Hi Arnd,
On Wed, Mar 20, 2019 at 6:39 PM Arnd Bergmann wrote:
>
> On Wed, Mar 20, 2019 at 7:41 AM Masahiro Yamada
> wrote:
>
> > It is unclear to me how to fix it.
> > That's why I ended up with "depends on !MIPS".
> >
> >
> > MODPO
On Wed, Mar 20, 2019 at 3:21 PM Masahiro Yamada
wrote:
>
> Commit 60a3cdd06394 ("x86: add optimized inlining") introduced
> CONFIG_OPTIMIZE_INLINING, but it has been available only for x86.
>
> The idea is obviously arch-agnostic although we need some code fixups.
>
ncluded in this. The patch is available in ML:
http://lists.infradead.org/pipermail/linux-arm-kernel/2016-February/409393.html
Signed-off-by: Masahiro Yamada
---
arch/arm64/include/asm/cpufeature.h | 4 ++--
arch/mips/kernel/cpu-bugs64.c | 4 ++--
arch/powerpc/kernel/prom_init.c | 6
tch would break my driver.
Probably, all the 8250* drivers would be broken in the same way.
For 8250 drivers, request_mem_region() is called
from 8250_port.c
Let's not touch around the code you do not
understand how it works.
Thanks.
Masahiro Yamada
> drivers/tty/serial/8250/8250_uniphi
On Thu, Mar 14, 2019 at 11:27 AM Michael Ellerman wrote:
>
> Mathieu Malaterre writes:
> > On Sat, Feb 16, 2019 at 3:26 AM Masahiro Yamada
> > wrote:
> >>
> >> On Sat, Feb 16, 2019 at 1:11 AM Mathieu Malaterre wrote:
> >> >
> >> > On
not report
-Wunused-function warnings for functions with 'inline' marker.
Signed-off-by: Masahiro Yamada
---
Changes in v2:
- Add __maybe_unsed to prom_getproplen()
- Add __init to enter_prom() as well
arch/powerpc/kernel/prom_init.c | 29 +++--
1 file changed, 15
6/um/Kconfig
> index f5a8cded3ca4..1628a54af003 100644
> --- a/arch/x86/um/Kconfig
> +++ b/arch/x86/um/Kconfig
> @@ -49,6 +49,3 @@ config ARCH_HAS_SC_SIGNALS
>
> config ARCH_REUSE_HOST_VSYSCALL_AREA
> def_bool !64BIT
> -
> -config GENERIC_HWEIGHT
> - def_bool y
> diff --git a/arch/xtensa/Kconfig b/arch/xtensa/Kconfig
> index d02c25184ca0..ff57afdeda04 100644
> --- a/arch/xtensa/Kconfig
> +++ b/arch/xtensa/Kconfig
> @@ -47,9 +47,6 @@ config XTENSA
> with reasonable minimum requirements. The Xtensa Linux project has
> a home page at <http://www.linux-xtensa.org/>.
>
> -config GENERIC_HWEIGHT
> - def_bool y
> -
> config ARCH_HAS_ILOG2_U32
> def_bool n
>
> diff --git a/lib/Kconfig b/lib/Kconfig
> index bd2e7e74c321..91019f26d0a8 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -35,6 +35,13 @@ config RATIONAL
> config GENERIC_CSUM
> bool
>
> +config ARCH_HAS_HWEIGHT
> + bool
> +
> +config GENERIC_HWEIGHT
> + default y if !ARCH_HAS_HWEIGHT
> + bool
> +
> config GENERIC_STRNCPY_FROM_USER
> bool
>
> --
> 2.20.1
>
>
> ___
> linux-riscv mailing list
> linux-ri...@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
--
Best Regards
Masahiro Yamada
On Sat, Feb 16, 2019 at 1:11 AM Mathieu Malaterre wrote:
>
> On Fri, Feb 15, 2019 at 10:41 AM Masahiro Yamada
> wrote:
> >
> > I often test all Kconfig commands for all architectures. To ease my
> > workflow, I want 'make defconfig' at least working wit
his commit, it will succeed:
$ make ARCH=powerpc defconfig
*** Default configuration is based on 'ppc64_defconfig'
#
# configuration written to .config
#
Signed-off-by: Masahiro Yamada
---
arch/powerpc/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/Makef
lt 3 if 64BIT
> default 2
>
> -config HAVE_KPROBES
> - def_bool n
> -
> menu "Platform type"
>
> choice
> --
> 2.20.1
>
>
> ___
> linux-riscv mailing list
> linux-ri...@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
--
Best Regards
Masahiro Yamada
garding the #ifdef __KERNEL__ , I think we should do a wide cleanup in
> arch/powerpc/include/asm, not only asm/checksum.h
>
> Christophe
Please send such cleanups to PowerPC ML
instead of to me (Kbuild).
Christoph,
I think this one is independent of the rest of this series.
How about separating it if you volunteer to Powerpc cleansup?
--
Best Regards
Masahiro Yamada
if BUG
> + select GENERIC_BUG_RELATIVE_POINTERSif X86_64
Precisely,
select GENERIC_BUG_RELATIVE_POINTERSif X86_64 && BUG
--
Best Regards
Masahiro Yamada
> -
> config NO_IOPORT_MAP
> bool
>
You missed to add 'select GENERIC_CSUM' for unicore32.
--
Best Regards
Masahiro Yamada
.debug
> +++ b/arch/nios2/Kconfig.debug
> @@ -1,8 +1,5 @@
> # SPDX-License-Identifier: GPL-2.0
>
> -config TRACE_IRQFLAGS_SUPPORT
> - def_bool y
> -
> config EARLY_PRINTK
> bool "Activate early kernel debugging"
> default y
--
Best Regards
Masahiro Yamada
___
> linux-riscv mailing list
> linux-ri...@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
--
Best Regards
Masahiro Yamada
UPPORT in nds32.
It is now available in lib/Kconfig.debug,
so this commit enables LOCKDEP_SUPPORT for nds32.
-
--
Best Regards
Masahiro Yamada
On Tue, Feb 5, 2019 at 7:33 PM Michael Ellerman wrote:
>
> Masahiro Yamada writes:
>
> > It is fragile to rely on the compiler's optimization to avoid the
> > section mismatch. Some functions may not be necessarily inlined
> > when the compiler's inlining heuristic
is guaranteed because PowerPC never enables
CONFIG_OPTIMIZE_INLINING. However, it would be better to leave the
inlining decision to the compiler. I replaced 'inline' with __init.
Signed-off-by: Masahiro Yamada
---
arch/powerpc/kernel/prom_init.c | 24
1 file changed, 12
Hi Michael,
On Fri, Jan 11, 2019 at 2:20 PM Masahiro Yamada
wrote:
>
> I am trying to get rid of crappy magic from Kbuild core makefiles.
>
> Before that, I want to drop as many useless paths as possible.
> Actually, many Makefiles are adding around pointless options.
>
&g
,$^) in cmd_link_multi-m because $^ may
include auto-generated dependencies from the .*.cmd file when a single
object module is changed into a multi object module. Refer to commit
69ea912fda74 ("kbuild: remove unneeded link_multi_deps"). I added some
comment to avoid accidental breakage.
Signed-off-by
Signed-off-by: Masahiro Yamada
---
Documentation/devicetree/bindings/Makefile | 2 +-
arch/mips/boot/Makefile| 2 +-
arch/powerpc/boot/Makefile | 2 +-
arch/x86/realmode/rm/Makefile | 3 +--
scripts/Kbuild.include | 4 +++
On Tue, Jan 15, 2019 at 5:07 PM Masahiro Yamada
wrote:
>
> Commit c3ff2a5193fa ("powerpc/32: add stack protector support")
> caused kernel panic on PowerPC if an external module is used with
> CONFIG_STACKPROTECTOR because the 'prepare' target was not executed
> for
On Tue, Jan 15, 2019 at 7:45 PM Alexey Kardashevskiy wrote:
>
>
>
> On 15/01/2019 18:19, Masahiro Yamada wrote:
> > Commit c3ff2a5193fa ("powerpc/32: add stack protector support")
> > caused kernel panic on PowerPC if an external module is used with
> > CO
On Tue, Jan 15, 2019 at 7:35 PM Mathieu Malaterre wrote:
>
> On Tue, Jan 15, 2019 at 8:22 AM Masahiro Yamada
> wrote:
> >
> > Commit c3ff2a5193fa ("powerpc/32: add stack protector support")
> > caused kernel panic on PowerPC if an external module is used w
s: 0a1213fa7432 ("arm64: enable per-task stack canaries")
Cc: linux-stable # v4.20
Reported-by: Samuel Holland
Reported-by: Alexey Kardashevskiy
Signed-off-by: Masahiro Yamada
---
Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
The same path -Iarch/$(ARCH) is passed to KBUILD_CPPFLAGS,
KBUILD_AFLAGS, and KBUILD_CFLAGS.
As you see in scripts/Makefile.lib, KBUILD_CPPFLAGS is passed
to c_flags and a_flags as well.
Passing it to KBUILD_CPPFLAGS is enough.
Signed-off-by: Masahiro Yamada
---
arch/powerpc/Makefile | 4
I am trying to get rid of crappy magic from Kbuild core makefiles.
Before that, I want to drop as many useless paths as possible.
Actually, many Makefiles are adding around pointless options.
This series cleans some powerpc Makefiles.
(only compile-tested by 0day bot)
Masahiro Yamada (3
se options, but they are completely useless.
Signed-off-by: Masahiro Yamada
---
arch/powerpc/kvm/Makefile | 5 -
1 file changed, 5 deletions(-)
diff --git a/arch/powerpc/kvm/Makefile b/arch/powerpc/kvm/Makefile
index 64f1135..3223aec 100644
--- a/arch/powerpc/kvm/Makefile
+++ b/arch/powerpc/kvm/Makefile
@@ -1
without these header search paths.
Signed-off-by: Masahiro Yamada
---
arch/powerpc/math-emu/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/math-emu/Makefile b/arch/powerpc/math-emu/Makefile
index 494df26..a879403 100644
--- a/arch/powerpc/math-emu
prepare
>
> +ifeq ($(KBUILD_EXTMOD),)
> stack_protector_prepare: prepare0
> +else
> +stack_protector_prepare:
> +endif
Honestly, I think this is ugly.
Do you want me to send an alternative solution?
> ifdef CONFIG_PPC64
> $(eval KBUILD_CFLAGS += -mstack-protector-guard-offset=$(shell awk
> '{if ($$2 == "PACA_CANARY") print $$3;}' include/generated/asm-offsets.h))
> else
> --
> 2.17.1
>
--
Best Regards
Masahiro Yamada
nel cannot be compiled with Clang
since it lacks the asm-goto support.
$ make CC=clang
Compiler lacks asm-goto support.
arch/x86/Makefile:293: recipe for target 'checkbin' failed
make: *** [checkbin] Error 1
--
Best Regards
Masahiro Yamada
'asm goto' support in Kconfig, then
make JUMP_LABEL depend on CC_HAS_ASM_GOTO.
Ugly #ifdef HAVE_JUMP_LABEL will go away, and CONFIG_JUMP_LABEL will
match to the real kernel capability.
Signed-off-by: Masahiro Yamada
---
This is a trivial conversion from the build system PoV.
I want to queue this
m a normal build to
> avoid a hard dependency on the external DT schema project and because
> there are lots of warnings generated.
>
> Cc: Jonathan Corbet
> Cc: Mark Rutland
> Cc: Masahiro Yamada
> Cc: Michal Marek
> Cc: linux-...@vger.kernel.org
> Cc: devicet...@vger.ke
On Wed, Dec 12, 2018 at 3:36 AM Rob Herring wrote:
>
> On Tue, Dec 11, 2018 at 10:03 AM Masahiro Yamada
> wrote:
> >
> > On Wed, Dec 12, 2018 at 12:13 AM Rob Herring wrote:
> >
> > >
> > > > > +$(obj)/%.example.dts: $(src)/%.yaml FO
EMA_FILES)))
> >
> > I do not understand this line.
> > Why is it necessary?
> >
> > *.example.dtb files are generated anyway
> > since they are listed in extra-y.
>
> It is enforcing the ordering. Without it, the binding checks and
> building .schema.yaml.tmp happen in parallel because both only have
> the source files as dependencies. The '|' keeps the dependencies out
> of the dependency list($^).
What kind problem would you see if
the binding checks and building .schema.yaml.tmp
happen in parallel?
--
Best Regards
Masahiro Yamada
ntly, the validation targets are separate from a normal build to
> avoid a hard dependency on the external DT schema project and because
> there are lots of warnings generated.
>
> Cc: Jonathan Corbet
> Cc: Mark Rutland
> Cc: Masahiro Yamada
> Cc: Michal Marek
>
Hi Richard,
On Sat, Dec 8, 2018 at 5:55 PM Richard Weinberger wrote:
>
> Am Samstag, 8. Dezember 2018, 07:35:47 CET schrieb Masahiro Yamada:
> > x86 maintainers,
> >
> >
> > Ping.
>
> I thought you carry this via your kbuild tree.
> That said, I c
Hi Borislav,
On Sat, Dec 8, 2018 at 8:34 PM Borislav Petkov wrote:
>
> On Sat, Dec 08, 2018 at 03:36:52PM +0900, Masahiro Yamada wrote:
> > x86 maintainers,
> >
> > Ping.
>
> You got the required ACKs. If you want me to carry this one and the
> UML one through
x86 maintainers,
Ping.
On Mon, Nov 12, 2018 at 8:23 PM Michael Ellerman wrote:
>
> Masahiro Yamada writes:
>
> > GCC 4.6 manual says:
> >
> > -funit-at-a-time
> > This option is left for compatibility reasons. -funit-at-a-time has
> > no effect,
x86 maintainers,
Ping.
On Tue, Nov 13, 2018 at 6:48 PM Richard Weinberger wrote:
>
> Am Montag, 12. November 2018, 03:35:19 CET schrieb Masahiro Yamada:
> > Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6")
> > bumped the minimum GCC version
eparate from a normal build to
> avoid a hard dependency on the external DT schema project and because
> there are lots of warnings generated.
>
> Cc: Jonathan Corbet
> Cc: Mark Rutland
> Cc: Masahiro Yamada
> Cc: Michal Marek
> Cc: linux-...@vger.kernel.org
> Cc: devicet...
Now that Kbuild automatically creates asm-generic wrappers for missing
mandatory headers, it is redundant to list the same headers in
generic-y and mandatory-y.
Suggested-by: Sam Ravnborg
Signed-off-by: Masahiro Yamada
---
arch/alpha/include/uapi/asm/Kbuild | 5 -
arch/arc/include
st a matter of slight taste.
I just wanted the code to look consistent.
--
Best Regards
Masahiro Yamada
CH_NO_PREEMPT
> select ARCH_USE_CMPXCHG_LOCKREF
> + select PCI if !ALPHA_JENSEN
> select HAVE_AOUT
> select HAVE_IDE
> select HAVE_OPROFILE
> --
> 2.19.1
>
--
Best Regards
Masahiro Yamada
e difference between arch/powerpc/Kconfig and arch/arm/Kconfig
is the presence of ---help--- property.
I squashed this to "eisa: consolidate EISA ..."
> Suggested-by: Masahiro Yamada
> Signed-off-by: Christoph Hellwig
> ---
> arch/arm/Kconfig | 15 ---
> 1 f
this also select PCI_DOMAINS to preserve the existing behavior?
> >
> > If not, could you explain why in the commit message?
>
> Ah, I see - PCI already selects PCI_DOMAINS. I think it would have been
> worth mentioning
OK, I added "PCI already selects PCI_DOMAINS"
in the commit description.
> but I don't mind if you don't think it a big enough
> deal to respin the patch, so:
>
> Acked-by: Paul Burton
>
> Thanks,
> Paul
--
Best Regards
Masahiro Yamada
On Fri, Nov 23, 2018 at 11:32 AM Masahiro Yamada
wrote:
>
> Hi Christoph,
>
>
> On Fri, Nov 16, 2018 at 4:08 AM Christoph Hellwig wrote:
> >
> > Hi all,
> >
> > currently every architecture that wants to provide on of the common
> > periphal busses n
-off-by: Christoph Hellwig
> Acked-by: Thomas Gleixner
> ---
--
Best Regards
Masahiro Yamada
_MSI for riscv
> - update x86 and riscv defconfigs to include PCI
> - actually inclue drivers/eisa/Kconfig
> - adjust some captilizations
--
Best Regards
Masahiro Yamada
s
> KBUILD_CFLAGS += $(CLANG_FLAGS)
> KBUILD_AFLAGS += $(CLANG_FLAGS)
> --
> 2.19.1
>
--
Best Regards
Masahiro Yamada
> > +BOOTCFLAGS += $(CLANG_FLAGS)
> > +BOOTAFLAGS += $(CLANG_FLAGS)
> > +endif
> > +
> > ifdef CONFIG_DEBUG_INFO
> > BOOTCFLAGS += -g
> > endif
> > --
> > 2.19.1
> >
>
>
> --
> Thanks,
> ~Nick Desaulniers
--
Best Regards
Masahiro Yamada
On Tue, Nov 6, 2018 at 12:06 PM Masahiro Yamada
wrote:
>
> Collect basic Clang options such as --target, --prefix, --gcc-toolchain,
> -no-integrated-as into a single variable CLANG_FLAGS so that it can be
> easily reused in other parts of Makefile.
>
> Signed-off-b
On Tue, Nov 6, 2018 at 12:06 PM Masahiro Yamada
wrote:
>
> We are still a way off the Clang's integrated assembler support for
> the kernel. Hence, -no-integrated-as is mandatory to build the kernel
> with Clang. If you had an ancient version of Clang that does not
> recognize t
ort'.
> Either way, I think it would be clearer to export this after all the
> relevant flags are set.
OK. It is just a matter of preference,
but I will move the export line below
when I pick up this patch set.
> > KBUILD_CFLAGS += $(CLANG_FLAGS)
> > KBUILD_AFLAGS += $(CLANG_FLAGS)
> > --
> > 2.19.1
> >
>
>
> --
> Thanks,
> ~Nick Desaulniers
--
Best Regards
Masahiro Yamada
On Mon, Nov 12, 2018 at 10:05 AM Michael Ellerman wrote:
>
> Masahiro Yamada writes:
> > On Sat, Nov 10, 2018 at 3:35 AM Greg Hackmann wrote:
> >>
> >> On 11/09/2018 10:29 AM, Nick Desaulniers wrote:
> >> > On Mon, Nov 5, 2018 at 7:05 PM Masahiro Yam
Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6")
bumped the minimum GCC version to 4.6 for all architectures.
'$(call cc-option,-fno-unit-at-a-time)' is now dead code since
'$(cc-version) -lt 0400' is always false.
Signed-off-by: Masahiro Yamada
---
arch/x86/M
GCC 4.6 manual says:
-funit-at-a-time
This option is left for compatibility reasons. -funit-at-a-time has
no effect, while -fno-unit-at-a-time implies -fno-toplevel-reorder
and -fno-section-anchors.
Enabled by default.
Signed-off-by: Masahiro Yamada
---
arch/powerpc/Makefile | 4
1/2: remove dead code, which is logically obvious
because the minimum GCC version is now 4.6
2/2: we can say -funit-at-a-time is no longer useful
according to GCC 4.6 manual
I hope, this series can be applied through x86 tree.
Masahiro Yamada (2):
um: remove -fno-unit-at-a-time
On Sat, Nov 10, 2018 at 3:35 AM Greg Hackmann wrote:
>
> On 11/09/2018 10:29 AM, Nick Desaulniers wrote:
> > On Mon, Nov 5, 2018 at 7:05 PM Masahiro Yamada
> > wrote:
> >>
> >> Collect basic Clang options such as --target, --prefix, --gcc-toolchain,
> >
-by: Masahiro Yamada
---
Changes in v2:
- New patch
Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 93315eb..da11700 100644
--- a/Makefile
+++ b/Makefile
@@ -497,8 +497,8 @@ CLANG_GCC_TC:= --gcc-toolchain=$(GCC_TOOLCHAIN)
endif
Collect basic Clang options such as --target, --prefix, --gcc-toolchain,
-no-integrated-as into a single variable CLANG_FLAGS so that it can be
easily reused in other parts of Makefile.
Signed-off-by: Masahiro Yamada
---
Changes in v2:
- Use := flavor instead of = because $(CLANG_FLAGS
ke a look at my patch, please?
https://patchwork.kernel.org/patch/10667369/
By using it as a prerequisite,
your patch set will be more simplified.
--
Best Regards
Masahiro Yamada
Hi Christoph,
On Fri, Oct 19, 2018 at 9:58 PM Masahiro Yamada
wrote:
>
> On Fri, Oct 19, 2018 at 9:23 PM Russell King - ARM Linux
> wrote:
>
> > > index a68b34183107..b185794549be 100644
> > > --- a/arch/arm/mach-pxa/Kconfig
> > > +++ b/arch/arm/
lp
> > @@ -219,6 +221,7 @@ config AKEBONO
> > select SWIOTLB
> > select 476FPE
> > select PPC4xx_PCI_EXPRESS
> > + select PCI
> > select PCI_MSI
> > select PPC4xx_HSTA_MSI
> > select I2C
> > --
> > 2.19.1
> >
--
Best Regards
Masahiro Yamada
amp; SCSI
> + depends on EISA && SCSI
> select SCSI_SPI_ATTRS
> ---help---
> This driver is for NCR53c710 based SCSI host adapters.
>
> - It currently supports Compaq EISA cards and NCR MCA cards
> + It currently supports Compaq EISA cards.
>
> config SCSI_DC395x
> tristate "Tekram DC395(U/UW/F) and DC315(U) SCSI support"
> --
> 2.19.1
>
--
Best Regards
Masahiro Yamada
Say Y here if you have a system based on a Motorola 8xx-series
> - embedded processor with a QSPAN PCI interface, otherwise say N.
> -
> config PCI_8260
> bool
> depends on PCI && 8260
> --
> 2.19.1
>
--
Best Regards
Masahiro Yamada
s/scsi/pcmcia/aha152x_core.c
> b/drivers/scsi/pcmcia/aha152x_core.c
> index dba3716511c5..24b89228b241 100644
> --- a/drivers/scsi/pcmcia/aha152x_core.c
> +++ b/drivers/scsi/pcmcia/aha152x_core.c
> @@ -1,3 +1,3 @@
> -#define PCMCIA 1
> +#define AHA152X_PCMCIA 1
> #define AHA152X_STAT 1
> #include "aha152x.c"
> --
> 2.19.1
>
--
Best Regards
Masahiro Yamada
Evaluating cc-name invokes the compiler every time even when you are
not compiling anything, like 'make help'. This is not efficient.
The compiler type has been already detected in the Kconfig stage.
Use CONFIG_CC_IS_CLANG, instead.
Signed-off-by: Masahiro Yamada
Acked-by: Michael Ellerman
On Tue, Oct 30, 2018 at 9:36 PM Michael Ellerman wrote:
>
> Masahiro Yamada writes:
> > diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile
> > index 17be664..338e827 100644
> > --- a/arch/powerpc/Makefile
> > +++ b/arch/powerpc/Makefil
Evaluating cc-name invokes the compiler every time even when you are
not compiling anything, like 'make help'. This is not efficient.
The compiler type has been already detected in the Kconfig stage.
Use CONFIG_CC_IS_CLANG, instead.
Signed-off-by: Masahiro Yamada
---
Makefile
cted. Your patch will
> cause Kconfig to complain for those which mandatorily have PCI but
> do not set HAVE_PCI.
Good catch!
But, adding a bunch of 'select HAVE_PCI' along with 'select PCI' is ugly.
Do you have any suggestion?
How about letting CONFIG_ARM to select HAVE_PCI ?
--
Best Regards
Masahiro Yamada
esurrect it easily by selecting
> HAVE_EISA for the right arm configs after this series.
What is your concern?
This absolutely looks dead to me.
> Suggested-by: Masahiro Yamada
> Signed-off-by: Christoph Hellwig
> ---
> arch/arm/Kconfig | 15 ---
> 1 file changed, 15 de
We could add 'depends on HAVE_PCI' or something
to guard it to avoid changing the logic.
config PCI_ENDPOINT
bool "PCI Endpoint Support"
depends on HAVE_PCI # Is this correct ??
depends on HAS_DMA
or better to have 'depends on PCI' ?
PCI ML is also CC'ed, so comments are appreciated.
--
Best Regards
Masahiro Yamada
Acked-by: Thomas Gleixner
--
Best Regards
Masahiro Yamada
> Acked-by: Thomas Gleixner
> ---
--
Best Regards
Masahiro Yamada
kernel for an EISA-based machine.
> -
> - Otherwise, say N.
> -
> config SBUS
> bool
>
--
Best Regards
Masahiro Yamada
depends on EISA && SCSI
> select SCSI_SPI_ATTRS
> ---help---
> This driver is for NCR53c710 based SCSI host adapters.
>
> - It currently supports Compaq EISA cards and NCR MCA cards
> + It currently supports Compaq EISA cards.
>
> config SCSI_DC395x
> tristate "Tekram DC395(U/UW/F) and DC315(U) SCSI support"
> --
> 2.19.1
>
--
Best Regards
Masahiro Yamada
On Mon, Oct 15, 2018 at 5:57 PM Christoph Hellwig wrote:
>
> On Mon, Oct 15, 2018 at 03:37:05PM +0900, Masahiro Yamada wrote:
> > I think HAVE_ is a preferred prefix in this case according to this doc:
> > https://github.com/masahir0y/linux/blob/v4.19-rc4/Documentation/kbuild/kc
nce
> (when needed) and then handles everything in the bus-specific
> Kconfig file under drivers/.
>
Thanks for great work again.
However, I suspect some breakages
(not testing yet, just quick review by my eyes.)
I left some comments in individual patches.
--
Best Regards
Masahiro Yamada
301 - 400 of 453 matches
Mail list logo
